)]}'
{"manila/share/drivers/generic.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44b3415063e2d3e189ac904b840b65770bb77a3f","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            return self._get_volume_legacy(context, share_id)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_legacy(self, context, share_id):"},{"line_number":372,"context_line":"        # NOTE(u_glide): this method should be deprecated and removed in"},{"line_number":373,"context_line":"        # feature versions"},{"line_number":374,"context_line":"        volume_name \u003d self._get_volume_name(share_id)"},{"line_number":375,"context_line":"        search_opts \u003d {\u0027name\u0027: volume_name}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_118fbc24","line":372,"updated":"2015-04-27 11:06:06.000000000","message":"it is \"deprecated\" with appearence of this change. Right? Then why it is said that it \"should be deprecated\" instead of \"it is deprecated\"?","commit_id":"44cf822bfb7de935f2a07fe09d1addd2306397e7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9c602b10f8edd1838520d7aa56fbd869456d24e0","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            return self._get_volume_legacy(context, share_id)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_legacy(self, context, share_id):"},{"line_number":372,"context_line":"        # NOTE(u_glide): this method should be deprecated and removed in"},{"line_number":373,"context_line":"        # feature versions"},{"line_number":374,"context_line":"        volume_name \u003d self._get_volume_name(share_id)"},{"line_number":375,"context_line":"        search_opts \u003d {\u0027name\u0027: volume_name}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_342ce949","line":372,"in_reply_to":"9abe1de1_118fbc24","updated":"2015-04-27 13:14:15.000000000","message":"Done","commit_id":"44cf822bfb7de935f2a07fe09d1addd2306397e7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44b3415063e2d3e189ac904b840b65770bb77a3f","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            return self._get_volume_snapshot_legacy(context, snapshot_id)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _get_volume_snapshot_legacy(self, context, snapshot_id):"},{"line_number":402,"context_line":"        # NOTE(u_glide): this method should be deprecated and removed in"},{"line_number":403,"context_line":"        # feature versions"},{"line_number":404,"context_line":"        volume_snapshot_name \u003d ("},{"line_number":405,"context_line":"            self.configuration.volume_snapshot_name_template % snapshot_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_d198246d","line":402,"updated":"2015-04-27 11:06:06.000000000","message":"ditto","commit_id":"44cf822bfb7de935f2a07fe09d1addd2306397e7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9c602b10f8edd1838520d7aa56fbd869456d24e0","unresolved":false,"context_lines":[{"line_number":399,"context_line":"            return self._get_volume_snapshot_legacy(context, snapshot_id)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _get_volume_snapshot_legacy(self, context, snapshot_id):"},{"line_number":402,"context_line":"        # NOTE(u_glide): this method should be deprecated and removed in"},{"line_number":403,"context_line":"        # feature versions"},{"line_number":404,"context_line":"        volume_snapshot_name \u003d ("},{"line_number":405,"context_line":"            self.configuration.volume_snapshot_name_template % snapshot_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_f425515c","line":402,"in_reply_to":"9abe1de1_d198246d","updated":"2015-04-27 13:14:15.000000000","message":"Done","commit_id":"44cf822bfb7de935f2a07fe09d1addd2306397e7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44b3415063e2d3e189ac904b840b65770bb77a3f","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                        \"to service instance.\") % share_volume[\u0027id\u0027]"},{"line_number":743,"context_line":"                raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"            self.private_storage.update("},{"line_number":746,"context_line":"                share[\u0027id\u0027], {\u0027volume_id\u0027: share_volume[\u0027id\u0027]})"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"            share_size \u003d share_volume[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_ac2437af","line":745,"updated":"2015-04-27 11:06:06.000000000","message":"What about saving compatibility here too?","commit_id":"44cf822bfb7de935f2a07fe09d1addd2306397e7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9c602b10f8edd1838520d7aa56fbd869456d24e0","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                        \"to service instance.\") % share_volume[\u0027id\u0027]"},{"line_number":743,"context_line":"                raise exception.ManageInvalidShare(reason\u003dmsg)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"            self.private_storage.update("},{"line_number":746,"context_line":"                share[\u0027id\u0027], {\u0027volume_id\u0027: share_volume[\u0027id\u0027]})"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"            share_size \u003d share_volume[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abe1de1_94c73545","line":745,"in_reply_to":"9abe1de1_ac2437af","updated":"2015-04-27 13:14:15.000000000","message":"Done","commit_id":"44cf822bfb7de935f2a07fe09d1addd2306397e7"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"312fc1db06ae4e01edf40b08f7df75bb54d59308","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_legacy(self, context, share_id):"},{"line_number":372,"context_line":"        # NOTE(u_glide): this method is deprecated and will be removed in"},{"line_number":373,"context_line":"        # feature versions"},{"line_number":374,"context_line":"        volume_name \u003d self._get_volume_name(share_id)"},{"line_number":375,"context_line":"        search_opts \u003d {\u0027name\u0027: volume_name}"},{"line_number":376,"context_line":"        if context.is_admin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_252fdcf7","line":373,"updated":"2015-05-01 00:37:51.000000000","message":"s/feature/future/","commit_id":"b1b9bc8cd612e338bb23ae609a521228aa1ac075"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6dd91c145db0fe8609eeea742165ef1296cc6029","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_legacy(self, context, share_id):"},{"line_number":372,"context_line":"        # NOTE(u_glide): this method is deprecated and will be removed in"},{"line_number":373,"context_line":"        # feature versions"},{"line_number":374,"context_line":"        volume_name \u003d self._get_volume_name(share_id)"},{"line_number":375,"context_line":"        search_opts \u003d {\u0027name\u0027: volume_name}"},{"line_number":376,"context_line":"        if context.is_admin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_aa84895d","line":373,"in_reply_to":"3acd31a7_252fdcf7","updated":"2015-05-05 11:01:49.000000000","message":"Done","commit_id":"b1b9bc8cd612e338bb23ae609a521228aa1ac075"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"312fc1db06ae4e01edf40b08f7df75bb54d59308","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _get_volume_snapshot_legacy(self, context, snapshot_id):"},{"line_number":402,"context_line":"        # NOTE(u_glide): this method is deprecated and will be removed in"},{"line_number":403,"context_line":"        # feature versions"},{"line_number":404,"context_line":"        volume_snapshot_name \u003d ("},{"line_number":405,"context_line":"            self.configuration.volume_snapshot_name_template % snapshot_id)"},{"line_number":406,"context_line":"        volume_snapshot_list \u003d self.volume_api.get_all_snapshots("}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_2516bca7","line":403,"updated":"2015-05-01 00:37:51.000000000","message":"s/feature/future/","commit_id":"b1b9bc8cd612e338bb23ae609a521228aa1ac075"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6dd91c145db0fe8609eeea742165ef1296cc6029","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def _get_volume_snapshot_legacy(self, context, snapshot_id):"},{"line_number":402,"context_line":"        # NOTE(u_glide): this method is deprecated and will be removed in"},{"line_number":403,"context_line":"        # feature versions"},{"line_number":404,"context_line":"        volume_snapshot_name \u003d ("},{"line_number":405,"context_line":"            self.configuration.volume_snapshot_name_template % snapshot_id)"},{"line_number":406,"context_line":"        volume_snapshot_list \u003d self.volume_api.get_all_snapshots("}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_8a89cd77","line":403,"in_reply_to":"3acd31a7_2516bca7","updated":"2015-05-05 11:01:49.000000000","message":"Done","commit_id":"b1b9bc8cd612e338bb23ae609a521228aa1ac075"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"312fc1db06ae4e01edf40b08f7df75bb54d59308","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":585,"context_line":"        volume_snapshot \u003d self._get_volume_snapshot(self.admin_context,"},{"line_number":586,"context_line":"                                                    snapshot[\u0027id\u0027])"},{"line_number":587,"context_line":"        if volume_snapshot is None:"},{"line_number":588,"context_line":"            return"},{"line_number":589,"context_line":"        self.volume_api.delete_snapshot(self.admin_context,"},{"line_number":590,"context_line":"                                        volume_snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_c5038841","line":587,"updated":"2015-05-01 00:37:51.000000000","message":"If you hit this, I think you might still want to attempt to delete private storage for this no-longer-existing snapshot which probably did exist at one time.","commit_id":"b1b9bc8cd612e338bb23ae609a521228aa1ac075"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6dd91c145db0fe8609eeea742165ef1296cc6029","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":585,"context_line":"        volume_snapshot \u003d self._get_volume_snapshot(self.admin_context,"},{"line_number":586,"context_line":"                                                    snapshot[\u0027id\u0027])"},{"line_number":587,"context_line":"        if volume_snapshot is None:"},{"line_number":588,"context_line":"            return"},{"line_number":589,"context_line":"        self.volume_api.delete_snapshot(self.admin_context,"},{"line_number":590,"context_line":"                                        volume_snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_4a297536","line":587,"in_reply_to":"3acd31a7_c5038841","updated":"2015-05-05 11:01:49.000000000","message":"We shouldn\u0027t delete private data here because we can get \u0027volume_snapshot is None\u0027  only in the case when we don\u0027t have any data related to this snapshot in private_storage.","commit_id":"b1b9bc8cd612e338bb23ae609a521228aa1ac075"}]}
