)]}'
{"doc/source/devref/generic_driver.rst":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7c2b19a0b769546464cf76dfae35b2bbbadf5be4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  These data will be just ignored."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- Liberty version terminates client connections to share when performs extend"},{"line_number":87,"context_line":"  operation on it."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The :mod:`manila.share.drivers.generic` Module"},{"line_number":90,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7a016987_de45106f","line":87,"updated":"2015-05-30 02:33:02.000000000","message":"\"terminates client connections\" sounds like connection will be lost forever.  Suggest changing to the following:\n\nFor the Liberty version, access to the share will be briefly interrupted during the extend operation.","commit_id":"868487c7192667efbc142800e58df95f608424f9"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"04b43adcd435e32e65f6729aabe307347948cb3e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  These data will be just ignored."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- Liberty version terminates client connections to share when performs extend"},{"line_number":87,"context_line":"  operation on it."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The :mod:`manila.share.drivers.generic` Module"},{"line_number":90,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5afe65bd_b730949f","line":87,"in_reply_to":"7a016987_74706d0b","updated":"2015-06-03 14:47:32.000000000","message":"Thanks! Done.","commit_id":"868487c7192667efbc142800e58df95f608424f9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"10e885d32603763fcd8a363549e6a7cd850fd00d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  These data will be just ignored."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- Liberty version terminates client connections to share when performs extend"},{"line_number":87,"context_line":"  operation on it."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The :mod:`manila.share.drivers.generic` Module"},{"line_number":90,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":12,"id":"7a016987_74706d0b","line":87,"in_reply_to":"7a016987_de45106f","updated":"2015-06-01 03:35:37.000000000","message":"+1, although in both versions the wording suggests that prior to Liberty, this wasn\u0027t an issue.  Perhaps:\n\n\"Liberty version adds a share extend capability.  Share access will be briefly interrupted during an extend operation.\"","commit_id":"868487c7192667efbc142800e58df95f608424f9"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4e9ee9edb0b9c44af2731831209f3006250e7113","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        msg_error \u003d _(\u0027Failed to extend volume\u0027)"},{"line_number":541,"context_line":"        msg_timeout \u003d ("},{"line_number":542,"context_line":"            _(\u0027Volume have not been extended in %ss. Giving up\u0027) %"},{"line_number":543,"context_line":"            self.configuration.max_time_to_create_volume"},{"line_number":544,"context_line":"        )"},{"line_number":545,"context_line":"        return self._wait_for_available_volume("},{"line_number":546,"context_line":"            volume, self.configuration.max_time_to_extend_volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_f71d1567","line":543,"updated":"2015-05-13 06:54:42.000000000","message":"max_time_to_create_volume -\u003e max_time_to_extend_volume","commit_id":"496626701f01bed02976f100e9e28b7ddd0bde93"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"3707962619721a50796b48c69eb7334e62d60650","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        msg_error \u003d _(\u0027Failed to extend volume\u0027)"},{"line_number":541,"context_line":"        msg_timeout \u003d ("},{"line_number":542,"context_line":"            _(\u0027Volume have not been extended in %ss. Giving up\u0027) %"},{"line_number":543,"context_line":"            self.configuration.max_time_to_create_volume"},{"line_number":544,"context_line":"        )"},{"line_number":545,"context_line":"        return self._wait_for_available_volume("},{"line_number":546,"context_line":"            volume, self.configuration.max_time_to_extend_volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_8d792a96","line":543,"in_reply_to":"9a0c5dc1_f71d1567","updated":"2015-05-13 08:16:26.000000000","message":"Done","commit_id":"496626701f01bed02976f100e9e28b7ddd0bde93"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"61c66130394fe491d6b9272a6e3631d8c023b30f","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                break"},{"line_number":463,"context_line":"            if volume[\u0027status\u0027] \u003d\u003d \u0027error\u0027:"},{"line_number":464,"context_line":"                raise exception.ManilaException(msg_error)"},{"line_number":465,"context_line":"            time.sleep(1)"},{"line_number":466,"context_line":"            volume \u003d self.volume_api.get(self.admin_context, volume[\u0027id\u0027])"},{"line_number":467,"context_line":"        else:"},{"line_number":468,"context_line":"            raise exception.ManilaException(msg_timeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_4c6ea130","line":465,"updated":"2015-05-15 03:34:50.000000000","message":"This line and the following 3 lines aren\u0027t covered by unit tests.  Can you add a test or two to cover those?\n\nAnd I learned something here.  I didn\u0027t know about Python\u0027s while...else construct!","commit_id":"3d352f58288859b9d8d1f2bf4cffad90b443d47f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"61c66130394fe491d6b9272a6e3631d8c023b30f","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                                        share[\u0027name\u0027])"},{"line_number":516,"context_line":"        return location"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":519,"context_line":"        if not self.driver_handles_share_servers:"},{"line_number":520,"context_line":"            share_server \u003d self.service_instance_manager.get_common_server()"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_6c5f1d73","line":518,"updated":"2015-05-15 03:34:50.000000000","message":"Perfect coverage on these 3 new methods, thanks!","commit_id":"3d352f58288859b9d8d1f2bf4cffad90b443d47f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e53289e3317e9e252eb451693f919e93f704d197","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        msg_error \u003d _(\u0027Failed to create volume\u0027)"},{"line_number":447,"context_line":"        msg_timeout \u003d ("},{"line_number":448,"context_line":"            _(\u0027Volume have not been created in %ss. Giving up\u0027) %"},{"line_number":449,"context_line":"            self.configuration.max_time_to_create_volume"},{"line_number":450,"context_line":"        )"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_8399ca21","line":448,"updated":"2015-05-18 11:59:55.000000000","message":"s/have/has/","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6a6c3b7df736ccc1edd99b8e039b3be83a90b80b","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        msg_error \u003d _(\u0027Failed to create volume\u0027)"},{"line_number":447,"context_line":"        msg_timeout \u003d ("},{"line_number":448,"context_line":"            _(\u0027Volume have not been created in %ss. Giving up\u0027) %"},{"line_number":449,"context_line":"            self.configuration.max_time_to_create_volume"},{"line_number":450,"context_line":"        )"},{"line_number":451,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_55dee43f","line":448,"in_reply_to":"7a016987_8399ca21","updated":"2015-05-18 14:33:26.000000000","message":"Done","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e53289e3317e9e252eb451693f919e93f704d197","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        return location"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":519,"context_line":"        if not self.driver_handles_share_servers:"},{"line_number":520,"context_line":"            share_server \u003d self.service_instance_manager.get_common_server()"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        server_details \u003d share_server[\u0027backend_details\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_66837c05","line":519,"updated":"2015-05-18 11:59:55.000000000","message":"This condition should consider value of param \"share_server\".","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6a6c3b7df736ccc1edd99b8e039b3be83a90b80b","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        return location"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":519,"context_line":"        if not self.driver_handles_share_servers:"},{"line_number":520,"context_line":"            share_server \u003d self.service_instance_manager.get_common_server()"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        server_details \u003d share_server[\u0027backend_details\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_d56d3499","line":519,"in_reply_to":"7a016987_66837c05","updated":"2015-05-18 14:33:26.000000000","message":"Done","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e53289e3317e9e252eb451693f919e93f704d197","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    def _extend_volume(self, context, volume, new_size):"},{"line_number":539,"context_line":"        self.volume_api.extend(context, volume[\u0027id\u0027], new_size)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        msg_error \u003d _(\u0027Failed to extend volume\u0027)"},{"line_number":542,"context_line":"        msg_timeout \u003d ("},{"line_number":543,"context_line":"            _(\u0027Volume have not been extended in %ss. Giving up\u0027) %"},{"line_number":544,"context_line":"            self.configuration.max_time_to_extend_volume"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_03adda30","line":541,"updated":"2015-05-18 11:59:55.000000000","message":"Which volume? Need to provide ID","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6a6c3b7df736ccc1edd99b8e039b3be83a90b80b","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    def _extend_volume(self, context, volume, new_size):"},{"line_number":539,"context_line":"        self.volume_api.extend(context, volume[\u0027id\u0027], new_size)"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        msg_error \u003d _(\u0027Failed to extend volume\u0027)"},{"line_number":542,"context_line":"        msg_timeout \u003d ("},{"line_number":543,"context_line":"            _(\u0027Volume have not been extended in %ss. Giving up\u0027) %"},{"line_number":544,"context_line":"            self.configuration.max_time_to_extend_volume"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_15986cbf","line":541,"in_reply_to":"7a016987_03adda30","updated":"2015-05-18 14:33:26.000000000","message":"Done","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e53289e3317e9e252eb451693f919e93f704d197","unresolved":false,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        msg_error \u003d _(\u0027Failed to extend volume\u0027)"},{"line_number":542,"context_line":"        msg_timeout \u003d ("},{"line_number":543,"context_line":"            _(\u0027Volume have not been extended in %ss. Giving up\u0027) %"},{"line_number":544,"context_line":"            self.configuration.max_time_to_extend_volume"},{"line_number":545,"context_line":"        )"},{"line_number":546,"context_line":"        return self._wait_for_available_volume("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_83c0aae1","line":543,"updated":"2015-05-18 11:59:55.000000000","message":"s/have/has/","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"6a6c3b7df736ccc1edd99b8e039b3be83a90b80b","unresolved":false,"context_lines":[{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        msg_error \u003d _(\u0027Failed to extend volume\u0027)"},{"line_number":542,"context_line":"        msg_timeout \u003d ("},{"line_number":543,"context_line":"            _(\u0027Volume have not been extended in %ss. Giving up\u0027) %"},{"line_number":544,"context_line":"            self.configuration.max_time_to_extend_volume"},{"line_number":545,"context_line":"        )"},{"line_number":546,"context_line":"        return self._wait_for_available_volume("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_95ea1c0e","line":543,"in_reply_to":"7a016987_83c0aae1","updated":"2015-05-18 14:33:26.000000000","message":"Done","commit_id":"551f74bc73a61b87934ed5cda250b7b78d434f82"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"903f09e705b142292785a0f84c088b5a7091a1b0","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"        self._driver._resize_filesystem(fake_server_details, fake_volume)"},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"        self._driver._ssh_exec.assert_any_call("},{"line_number":1318,"context_line":"            fake_server_details, [\u0027sudo\u0027, \u0027fsck\u0027, \u0027-pf\u0027, \u0027/dev/fake\u0027])"},{"line_number":1319,"context_line":"        self._driver._ssh_exec.assert_any_call("},{"line_number":1320,"context_line":"            fake_server_details, [\u0027sudo\u0027, \u0027resize2fs\u0027, \u0027/dev/fake\u0027])"},{"line_number":1321,"context_line":"        self.assertEqual(2, self._driver._ssh_exec.call_count)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_be72ed47","line":1318,"updated":"2015-05-26 17:14:00.000000000","message":"Test case for failure of \"fsck ...\" is absent. What do we expect in that case?","commit_id":"e068189419837222c22735e5cc18015333be70e5"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"0619327da15d57c83bab3daf99866532b841912b","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"        self._driver._resize_filesystem(fake_server_details, fake_volume)"},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"        self._driver._ssh_exec.assert_any_call("},{"line_number":1318,"context_line":"            fake_server_details, [\u0027sudo\u0027, \u0027fsck\u0027, \u0027-pf\u0027, \u0027/dev/fake\u0027])"},{"line_number":1319,"context_line":"        self._driver._ssh_exec.assert_any_call("},{"line_number":1320,"context_line":"            fake_server_details, [\u0027sudo\u0027, \u0027resize2fs\u0027, \u0027/dev/fake\u0027])"},{"line_number":1321,"context_line":"        self.assertEqual(2, self._driver._ssh_exec.call_count)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_d1e9feb8","line":1318,"in_reply_to":"7a016987_be72ed47","updated":"2015-05-27 10:29:54.000000000","message":"This exceptional case is handled in Share Manager and cause ShareExtendingError.","commit_id":"e068189419837222c22735e5cc18015333be70e5"}]}
