)]}'
{"contrib/tempest/tempest/api/share/test_shares_actions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0ef4e7d677fbb53b6f0257406770a48cde36de62","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":384,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":385,"context_line":"    def test_extend_share(self):"},{"line_number":386,"context_line":"        share \u003d self.create_share(size\u003d1)"},{"line_number":387,"context_line":"        new_size \u003d 2"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        # extend share and wait for active status"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_e0bcdb07","line":386,"updated":"2015-05-19 11:33:06.000000000","message":"Need to provide param \"cleanup_in_class\u003dFalse\" explicitly. Else share will be deleted only after this whole test suite. Because default value for shares is to be deleted after test suite and not single test, see:\n\nhttps://github.com/openstack/manila/blob/2335afa9/contrib/tempest/tempest/api/share/base.py#L284\n\nP.S. yes, we already have tests that leave their resource cleanup for end of test suite. But, please, fix it here.","commit_id":"1065c686ee6c8a3bd0fd9a12b0f44967bc1ecb9c"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"2d0d207d1c1b80a1648c847a39652c45134bb35e","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":384,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":385,"context_line":"    def test_extend_share(self):"},{"line_number":386,"context_line":"        share \u003d self.create_share(size\u003d1)"},{"line_number":387,"context_line":"        new_size \u003d 2"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        # extend share and wait for active status"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_007c971d","line":386,"in_reply_to":"7a016987_e0bcdb07","updated":"2015-05-19 11:45:00.000000000","message":"Done","commit_id":"1065c686ee6c8a3bd0fd9a12b0f44967bc1ecb9c"}],"contrib/tempest/tempest/api/share/test_shares_actions_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6acc40ec125d633f7a7a32b09296294322f3288f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_share_extend_over_quota(self):"},{"line_number":39,"context_line":"        tenant_quotas \u003d self.shares_client.show_quotas("},{"line_number":40,"context_line":"            self.shares_client.tenant_id)"},{"line_number":41,"context_line":"        new_size \u003d int(tenant_quotas[\"gigabytes\"]) + 10"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # extend share with over quota and check result"},{"line_number":44,"context_line":"        self.assertRaises(lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_20dfac6a","line":41,"updated":"2015-05-18 10:20:55.000000000","message":"Better to test border values. Please, replace 10 with 1.","commit_id":"eb94cb1fc40492fe2a21e9b982bbfc53b1553ed7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"ec46fd62a80b940e14be070d5af5bc5f8e2e9a2f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def test_share_extend_over_quota(self):"},{"line_number":39,"context_line":"        tenant_quotas \u003d self.shares_client.show_quotas("},{"line_number":40,"context_line":"            self.shares_client.tenant_id)"},{"line_number":41,"context_line":"        new_size \u003d int(tenant_quotas[\"gigabytes\"]) + 10"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # extend share with over quota and check result"},{"line_number":44,"context_line":"        self.assertRaises(lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_1add3be0","line":41,"in_reply_to":"7a016987_20dfac6a","updated":"2015-05-18 14:15:36.000000000","message":"Done","commit_id":"eb94cb1fc40492fe2a21e9b982bbfc53b1553ed7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6acc40ec125d633f7a7a32b09296294322f3288f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @testtools.skipUnless("},{"line_number":51,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":52,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":53,"context_line":"    def test_share_extend_with_less_size(self):"},{"line_number":54,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027]) - 1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # extend share with invalid size and check result"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_e0bf54f9","line":53,"updated":"2015-05-18 10:20:55.000000000","message":"Bigger and smaller sizes are covered, but what do we expect for same size? Anyway, case of same size is not covered. Please, add it.","commit_id":"eb94cb1fc40492fe2a21e9b982bbfc53b1553ed7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"ec46fd62a80b940e14be070d5af5bc5f8e2e9a2f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @testtools.skipUnless("},{"line_number":51,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":52,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":53,"context_line":"    def test_share_extend_with_less_size(self):"},{"line_number":54,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027]) - 1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # extend share with invalid size and check result"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_fad7ffbc","line":53,"in_reply_to":"7a016987_e0bf54f9","updated":"2015-05-18 14:15:36.000000000","message":"Done","commit_id":"eb94cb1fc40492fe2a21e9b982bbfc53b1553ed7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6acc40ec125d633f7a7a32b09296294322f3288f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.shares_client.extend_share(self.share[\u0027id\u0027], new_size)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # run another extend operation on same share and check result"},{"line_number":73,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":74,"context_line":"                          self.shares_client.extend_share,"},{"line_number":75,"context_line":"                          self.share[\u0027id\u0027],"},{"line_number":76,"context_line":"                          new_size + 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_00cb9073","line":73,"updated":"2015-05-18 10:20:55.000000000","message":"It is likely that tempest will perform operations longer than backend.\n\nFor example, in case of GlusterFS, it is just update of quota for share.\n\nAlso, test that changes some object should be the only user of this object. Right now, it is possible that this test can break other two tests.","commit_id":"eb94cb1fc40492fe2a21e9b982bbfc53b1553ed7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"ec46fd62a80b940e14be070d5af5bc5f8e2e9a2f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.shares_client.extend_share(self.share[\u0027id\u0027], new_size)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # run another extend operation on same share and check result"},{"line_number":73,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":74,"context_line":"                          self.shares_client.extend_share,"},{"line_number":75,"context_line":"                          self.share[\u0027id\u0027],"},{"line_number":76,"context_line":"                          new_size + 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_dae683b3","line":73,"in_reply_to":"7a016987_00cb9073","updated":"2015-05-18 14:15:36.000000000","message":"Done","commit_id":"eb94cb1fc40492fe2a21e9b982bbfc53b1553ed7"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"7c5a2ec93e2727cdc14c359684457d61daae980b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"},{"line_number":17,"context_line":"import testtools  # noqa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.share import base"},{"line_number":20,"context_line":"from tempest import config_share as config"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_f1cf1d7d","line":17,"updated":"2015-05-18 22:15:27.000000000","message":"Why are these lines skipping hacking checks?","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"0a901352f74018a9e7e8b5834bec768f4fbb049f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"},{"line_number":17,"context_line":"import testtools  # noqa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest.api.share import base"},{"line_number":20,"context_line":"from tempest import config_share as config"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_b04998b9","line":17,"in_reply_to":"7a016987_f1cf1d7d","updated":"2015-05-19 11:09:20.000000000","message":"# noqa skipping is required because this tests in manila tree and pep8 check shows false-positive error:\nH307  like imports should be grouped together (testtools and tempest.api.share.base from third-party are separated by whitespace)","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"12f0059b6f64d401fcd322745b78ce072f4b1832","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # run delete operation"},{"line_number":84,"context_line":"        self.shares_client.delete_share(share[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # run extend operation on same share and check result"},{"line_number":87,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_bdc97e7a","line":84,"updated":"2015-05-18 17:01:07.000000000","message":"We have admin API of share status update/set/reset - [1]. So, this one should have been used.\n\n[1]  https://github.com/openstack/manila/blob/2335afa9/contrib/tempest/tempest/services/share/json/shares_client.py#L400","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"0a901352f74018a9e7e8b5834bec768f4fbb049f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # run delete operation"},{"line_number":84,"context_line":"        self.shares_client.delete_share(share[\u0027id\u0027])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # run extend operation on same share and check result"},{"line_number":87,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_3deb407a","line":84,"in_reply_to":"7a016987_bdc97e7a","updated":"2015-05-19 11:09:20.000000000","message":"Done","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"7c5a2ec93e2727cdc14c359684457d61daae980b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":88,"context_line":"                          self.shares_client.extend_share,"},{"line_number":89,"context_line":"                          share[\u0027id\u0027],"},{"line_number":90,"context_line":"                          new_size)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_919b4972","line":90,"updated":"2015-05-18 22:15:27.000000000","message":"What about a test for when you extend without enough space left on the backend?","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"0a901352f74018a9e7e8b5834bec768f4fbb049f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":88,"context_line":"                          self.shares_client.extend_share,"},{"line_number":89,"context_line":"                          share[\u0027id\u0027],"},{"line_number":90,"context_line":"                          new_size)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_f0015039","line":90,"in_reply_to":"7a016987_919b4972","updated":"2015-05-19 11:09:20.000000000","message":"It\u0027s impossible to simulate such situation in API tests because API doesn\u0027t know anything about current back-end capacity.","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cd66ae9133ae70a973fef44c3e62aecee374b42e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":88,"context_line":"                          self.shares_client.extend_share,"},{"line_number":89,"context_line":"                          share[\u0027id\u0027],"},{"line_number":90,"context_line":"                          new_size)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_00db77ed","line":90,"in_reply_to":"7a016987_f0015039","updated":"2015-05-19 11:50:07.000000000","message":"Igor is right. We have no possibility to simulate such case by means of Manila API.","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0ef4e7d677fbb53b6f0257406770a48cde36de62","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":79,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":80,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":81,"context_line":"        share \u003d self.create_share(size\u003d1)"},{"line_number":82,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_00201747","line":81,"updated":"2015-05-19 11:33:06.000000000","message":"Same as here:\n\nhttps://review.openstack.org/#/c/183497/9/contrib/tempest/tempest/api/share/test_shares_actions.py","commit_id":"1065c686ee6c8a3bd0fd9a12b0f44967bc1ecb9c"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"2d0d207d1c1b80a1648c847a39652c45134bb35e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        CONF.share.run_extend_tests,"},{"line_number":79,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":80,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":81,"context_line":"        share \u003d self.create_share(size\u003d1)"},{"line_number":82,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_e0abbb73","line":81,"in_reply_to":"7a016987_00201747","updated":"2015-05-19 11:45:00.000000000","message":"Done","commit_id":"1065c686ee6c8a3bd0fd9a12b0f44967bc1ecb9c"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"54759e6d0838b8c443b73038c025b32a2259ae73","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":80,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":81,"context_line":"        share \u003d self.create_share(size\u003d1, cleanup_in_class\u003dFalse)"},{"line_number":82,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"},{"line_number":85,"context_line":"        admin_client \u003d clients.AdminManager().shares_client"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_39edc2b7","line":82,"updated":"2015-05-27 19:50:02.000000000","message":"Shouldn\u0027t this be new_size \u003d int(self.share[\u0027share\u0027] + 1 to make sure that the BadRequest exception is actually raised due to \"error state\" of the share and not because of trying to extend to the same size.","commit_id":"256f79770d6e4bb63a5886df75f7488038b4f5b3"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"ad810de4c28864fa614e589a0c9fc33c9d97b992","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":80,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":81,"context_line":"        share \u003d self.create_share(size\u003d1, cleanup_in_class\u003dFalse)"},{"line_number":82,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"},{"line_number":85,"context_line":"        admin_client \u003d clients.AdminManager().shares_client"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_cdc7f610","line":82,"in_reply_to":"7a016987_39edc2b7","updated":"2015-05-28 07:51:51.000000000","message":"Done","commit_id":"256f79770d6e4bb63a5886df75f7488038b4f5b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3f0ce431d29bb79bd615b75635eb0059f4f9ffd5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":80,"context_line":"    def test_share_extend_with_invalid_share_state(self):"},{"line_number":81,"context_line":"        share \u003d self.create_share(size\u003d1, cleanup_in_class\u003dFalse)"},{"line_number":82,"context_line":"        new_size \u003d int(self.share[\u0027size\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"},{"line_number":85,"context_line":"        admin_client \u003d clients.AdminManager().shares_client"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_c87b727a","line":82,"in_reply_to":"7a016987_39edc2b7","updated":"2015-05-27 22:00:44.000000000","message":"Good idea. +1","commit_id":"256f79770d6e4bb63a5886df75f7488038b4f5b3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ff002af29b1b5812899cb79623b81ef0a50681b0","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"},{"line_number":85,"context_line":"        admin_client \u003d clients.AdminManager().shares_client"},{"line_number":86,"context_line":"        admin_client.reset_state(share[\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # run extend operation on same share and check result"},{"line_number":89,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5afe65bd_7a0afc22","line":86,"updated":"2015-06-03 16:49:22.000000000","message":"I think it is strange that our default state is \u0027error\u0027 instead of being \u0027available\u0027 like on the command line.  But this is correct for now.","commit_id":"eedd348c7e67563db7eab656e78ff9a7130273c9"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"7f6e6eefa54cf006dbab02bd5a3248744190ca04","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # set \"error\" state"},{"line_number":85,"context_line":"        admin_client \u003d clients.AdminManager().shares_client"},{"line_number":86,"context_line":"        admin_client.reset_state(share[\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # run extend operation on same share and check result"},{"line_number":89,"context_line":"        self.assertRaises(lib_exc.BadRequest,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5afe65bd_4d78928f","line":86,"in_reply_to":"5afe65bd_7a0afc22","updated":"2015-06-04 06:36:29.000000000","message":"It\u0027s negative test for the case when share in the invalid state. So \u0027error\u0027 state is appropriate here.","commit_id":"eedd348c7e67563db7eab656e78ff9a7130273c9"}],"contrib/tempest/tempest/config_share.py":[{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"7c5a2ec93e2727cdc14c359684457d61daae980b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                default\u003dTrue,"},{"line_number":128,"context_line":"                help\u003d\"Defines whether to run share extend tests or not.\""},{"line_number":129,"context_line":"                     \"Disable this feature if used driver doesn\u0027t \""},{"line_number":130,"context_line":"                     \"support it.\"),"},{"line_number":131,"context_line":"]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_5193914f","line":130,"updated":"2015-05-18 22:15:27.000000000","message":"Thanks for adding this!","commit_id":"365b86c3877710136789f7bdf2f188f3f41dd5d1"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f4c3d6a173bb4c4fac6416af57045573b930bfa7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"               help\u003d\"Image password.\"),"},{"line_number":126,"context_line":"    cfg.BoolOpt(\"run_extend_tests\","},{"line_number":127,"context_line":"                default\u003dTrue,"},{"line_number":128,"context_line":"                help\u003d\"Defines whether to run share extend tests or not.\""},{"line_number":129,"context_line":"                     \"Disable this feature if used driver doesn\u0027t \""},{"line_number":130,"context_line":"                     \"support it.\"),"},{"line_number":131,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_207e7319","line":128,"updated":"2015-05-28 19:43:08.000000000","message":"Missing space at end of line.","commit_id":"0084d29d6ba7b5783c02b74d33b0e5b2abea8a99"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ff002af29b1b5812899cb79623b81ef0a50681b0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"               default\u003d\"ubuntu\","},{"line_number":125,"context_line":"               help\u003d\"Image password.\"),"},{"line_number":126,"context_line":"    cfg.BoolOpt(\"run_extend_tests\","},{"line_number":127,"context_line":"                default\u003dTrue,"},{"line_number":128,"context_line":"                help\u003d\"Defines whether to run share extend tests or not.\""},{"line_number":129,"context_line":"                     \"Disable this feature if used driver doesn\u0027t \""},{"line_number":130,"context_line":"                     \"support it.\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5afe65bd_5a5bc02e","line":127,"updated":"2015-06-03 16:49:22.000000000","message":"Shouldn\u0027t this default to False at least until it is implemented by more vendors (like manage/unmanage)?","commit_id":"eedd348c7e67563db7eab656e78ff9a7130273c9"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"7f6e6eefa54cf006dbab02bd5a3248744190ca04","unresolved":false,"context_lines":[{"line_number":124,"context_line":"               default\u003d\"ubuntu\","},{"line_number":125,"context_line":"               help\u003d\"Image password.\"),"},{"line_number":126,"context_line":"    cfg.BoolOpt(\"run_extend_tests\","},{"line_number":127,"context_line":"                default\u003dTrue,"},{"line_number":128,"context_line":"                help\u003d\"Defines whether to run share extend tests or not.\""},{"line_number":129,"context_line":"                     \"Disable this feature if used driver doesn\u0027t \""},{"line_number":130,"context_line":"                     \"support it.\"),"}],"source_content_type":"text/x-python","patch_set":13,"id":"5afe65bd_0d45fa15","line":127,"in_reply_to":"5afe65bd_5a5bc02e","updated":"2015-06-04 06:36:29.000000000","message":"By default, this set to True to run this tests in the gate with generic driver. 3rd-party CI\u0027s could disable it by custom config (like Netapp CI)","commit_id":"eedd348c7e67563db7eab656e78ff9a7130273c9"}]}
