)]}'
{"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"befad2ce247960114c0b4565e5b3d74e5522f6e7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"echo \"API_RATE_LIMIT\u003dFalse\" \u003e\u003e $localrc_path"},{"line_number":26,"context_line":"echo \"TEMPEST_SERVICES+\u003d,manila\" \u003e\u003e $localrc_path"},{"line_number":27,"context_line":"echo \"VOLUME_BACKING_FILE_SIZE\u003d22G\" \u003e\u003e $localrc_path"},{"line_number":28,"context_line":"echo \"ENABLE_ISOLATED_METADATA\u003dTrue\" \u003e\u003e $localrc_path"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"MANILA_BACKEND1_CONFIG_GROUP_NAME\u003dlondon\" \u003e\u003e $localrc_path"},{"line_number":31,"context_line":"echo \"MANILA_BACKEND2_CONFIG_GROUP_NAME\u003dparis\" \u003e\u003e $localrc_path"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3afb71cf_061f0cb8","line":28,"updated":"2015-06-09 13:20:13.000000000","message":"Please, add comment above it to spill the light on it. It is not obvious right now, why do we need it and what we get in each of boolean values set...","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9760ec2e7b65a527b6c551763ab0b42ae4943f9d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"echo \"API_RATE_LIMIT\u003dFalse\" \u003e\u003e $localrc_path"},{"line_number":26,"context_line":"echo \"TEMPEST_SERVICES+\u003d,manila\" \u003e\u003e $localrc_path"},{"line_number":27,"context_line":"echo \"VOLUME_BACKING_FILE_SIZE\u003d22G\" \u003e\u003e $localrc_path"},{"line_number":28,"context_line":"echo \"ENABLE_ISOLATED_METADATA\u003dTrue\" \u003e\u003e $localrc_path"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"MANILA_BACKEND1_CONFIG_GROUP_NAME\u003dlondon\" \u003e\u003e $localrc_path"},{"line_number":31,"context_line":"echo \"MANILA_BACKEND2_CONFIG_GROUP_NAME\u003dparis\" \u003e\u003e $localrc_path"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3afb71cf_74499fb6","line":28,"in_reply_to":"3afb71cf_061f0cb8","updated":"2015-06-10 06:47:17.000000000","message":"Done","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ac61a4cde94262362bc237bb6ff81de9698c2607","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Enabling isolated metadata in Neutron is required because"},{"line_number":30,"context_line":"# Tempest creates isolated networks and created vm\u0027s in scenario tests don\u0027t"},{"line_number":31,"context_line":"# have access to Nova Metadata service. This leeds to unavailability of"},{"line_number":32,"context_line":"# created vm\u0027s in scenario tests."},{"line_number":33,"context_line":"echo \"ENABLE_ISOLATED_METADATA\u003dTrue\" \u003e\u003e $localrc_path"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3afb71cf_9e850d09","line":31,"updated":"2015-06-11 15:52:30.000000000","message":"s/leeds/leads/","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"7bd4f474b75ad3c63185bf5b1c7dc814b635e6d4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Enabling isolated metadata in Neutron is required because"},{"line_number":30,"context_line":"# Tempest creates isolated networks and created vm\u0027s in scenario tests don\u0027t"},{"line_number":31,"context_line":"# have access to Nova Metadata service. This leeds to unavailability of"},{"line_number":32,"context_line":"# created vm\u0027s in scenario tests."},{"line_number":33,"context_line":"echo \"ENABLE_ISOLATED_METADATA\u003dTrue\" \u003e\u003e $localrc_path"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1af86dd1_15657244","line":31,"in_reply_to":"3afb71cf_9e850d09","updated":"2015-06-12 08:44:42.000000000","message":"Done","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"}],"contrib/tempest/tempest/config_share.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"befad2ce247960114c0b4565e5b3d74e5522f6e7","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    cfg.StrOpt(\"image_password\","},{"line_number":124,"context_line":"               default\u003d\"manila\","},{"line_number":125,"context_line":"               help\u003d\"Image password.\"),"},{"line_number":126,"context_line":"    cfg.StrOpt(\"flavor_ref\","},{"line_number":127,"context_line":"               default\u003d\"100\","},{"line_number":128,"context_line":"               help\u003d\"Flavor used for scenario tests.\"),"},{"line_number":129,"context_line":"    cfg.BoolOpt(\"run_extend_tests\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_86cf7c28","line":126,"updated":"2015-06-09 13:20:13.000000000","message":"Flavor is generic-driver-specific. It should not be in tempest\u0027s config.","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"}],"contrib/tempest/tempest/scenario/manager_share.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"befad2ce247960114c0b4565e5b3d74e5522f6e7","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        client_params \u003d {\u0027username\u0027: kwargs[\u0027username\u0027]}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # NOTE(u_glide): new service image supports public-key auth"},{"line_number":170,"context_line":"        if client_params[\u0027username\u0027] \u003d\u003d \u0027manila\u0027:"},{"line_number":171,"context_line":"            client_params.update({\u0027password\u0027: None,"},{"line_number":172,"context_line":"                                  \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)})"},{"line_number":173,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_c665741e","line":170,"updated":"2015-06-09 13:20:13.000000000","message":"No need to use condition. Just provide both - key and password at once.","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9760ec2e7b65a527b6c551763ab0b42ae4943f9d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        client_params \u003d {\u0027username\u0027: kwargs[\u0027username\u0027]}"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # NOTE(u_glide): new service image supports public-key auth"},{"line_number":170,"context_line":"        if client_params[\u0027username\u0027] \u003d\u003d \u0027manila\u0027:"},{"line_number":171,"context_line":"            client_params.update({\u0027password\u0027: None,"},{"line_number":172,"context_line":"                                  \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)})"},{"line_number":173,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_f4b8ef76","line":170,"in_reply_to":"3afb71cf_c665741e","updated":"2015-06-10 06:47:17.000000000","message":"Done","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"50400e24f3f0fb8a8c6d4cae4db992d9ac33f9df","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # NOTE(u_glide): new service image supports public-key auth"},{"line_number":170,"context_line":"        if client_params[\u0027username\u0027] \u003d\u003d \u0027manila\u0027:"},{"line_number":171,"context_line":"            client_params.update({\u0027password\u0027: None,"},{"line_number":172,"context_line":"                                  \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)})"},{"line_number":173,"context_line":"        else:"},{"line_number":174,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":175,"context_line":"            # the keypair and use the configured username and password"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_b061b13b","line":172,"updated":"2015-06-08 19:04:21.000000000","message":"why does comment say public-key, but get \u0027private_key\u0027?","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"200a738d89c69a9ae0978eb85d18c6573c6215f8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # NOTE(u_glide): new service image supports public-key auth"},{"line_number":170,"context_line":"        if client_params[\u0027username\u0027] \u003d\u003d \u0027manila\u0027:"},{"line_number":171,"context_line":"            client_params.update({\u0027password\u0027: None,"},{"line_number":172,"context_line":"                                  \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)})"},{"line_number":173,"context_line":"        else:"},{"line_number":174,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":175,"context_line":"            # the keypair and use the configured username and password"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_463f3924","line":172,"in_reply_to":"3afb71cf_17298637","updated":"2015-06-09 16:12:17.000000000","message":"OK. Makes sense (just looks odd so close together). Thanks for the link.","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79bfd93b427ee41f138123895384416d626a4fa1","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        # NOTE(u_glide): new service image supports public-key auth"},{"line_number":170,"context_line":"        if client_params[\u0027username\u0027] \u003d\u003d \u0027manila\u0027:"},{"line_number":171,"context_line":"            client_params.update({\u0027password\u0027: None,"},{"line_number":172,"context_line":"                                  \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)})"},{"line_number":173,"context_line":"        else:"},{"line_number":174,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":175,"context_line":"            # the keypair and use the configured username and password"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_17298637","line":172,"in_reply_to":"3afb71cf_b061b13b","updated":"2015-06-09 07:45:41.000000000","message":"A Public key is deployed as usual to service vm at creation time, and client use a private key for authentication to service vm. This auth method called \"publickey\" https://tools.ietf.org/html/rfc4252","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ac61a4cde94262362bc237bb6ff81de9698c2607","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"},{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"},{"line_number":174,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_9eebcd78","line":171,"updated":"2015-06-11 15:52:30.000000000","message":"getting username and password from different places looks odd.  username from kwargs and password from CONF.  Can\u0027t you still use CONF for both (or kwargs)?","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"7bd4f474b75ad3c63185bf5b1c7dc814b635e6d4","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"},{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"},{"line_number":174,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af86dd1_d5a35a4e","line":171,"in_reply_to":"3afb71cf_9eebcd78","updated":"2015-06-12 08:44:42.000000000","message":"It\u0027s compatibility leftover. We will remove this code when we migrate to new service image","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"882965c4074c0208c39c5bcd764f72f41f4688b1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            return super(ShareScenarioTest,"},{"line_number":157,"context_line":"                         self).get_remote_client(*args, **kwargs)"},{"line_number":158,"context_line":"        # NOTE(u_glide): We need custom implementation of this method until"},{"line_number":159,"context_line":"        # original depends on CONF.compute.ssh_auth_method option."},{"line_number":160,"context_line":"        server_or_ip \u003d kwargs[\u0027server_or_ip\u0027]"},{"line_number":161,"context_line":"        if isinstance(server_or_ip, six.string_types):"},{"line_number":162,"context_line":"            ip \u003d server_or_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_57de206e","line":159,"updated":"2015-06-16 05:55:38.000000000","message":"original what?","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79b0b8a92f2149ef5dc9d7ce34139068c1262ab1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            return super(ShareScenarioTest,"},{"line_number":157,"context_line":"                         self).get_remote_client(*args, **kwargs)"},{"line_number":158,"context_line":"        # NOTE(u_glide): We need custom implementation of this method until"},{"line_number":159,"context_line":"        # original depends on CONF.compute.ssh_auth_method option."},{"line_number":160,"context_line":"        server_or_ip \u003d kwargs[\u0027server_or_ip\u0027]"},{"line_number":161,"context_line":"        if isinstance(server_or_ip, six.string_types):"},{"line_number":162,"context_line":"            ip \u003d server_or_ip"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_0fef1c88","line":159,"in_reply_to":"fa32b979_57de206e","updated":"2015-06-16 07:39:46.000000000","message":"Done","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef749dff3c04644d7a4ff3f86d05e1fe3c377674","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        client_params \u003d {"},{"line_number":168,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"},{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_76fee36c","line":170,"updated":"2015-06-15 15:48:37.000000000","message":"as -\u003e As\nPlease Add a \u0027.\u0027 in the end.","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"882965c4074c0208c39c5bcd764f72f41f4688b1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        client_params \u003d {"},{"line_number":168,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"},{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_97ca68a0","line":170,"in_reply_to":"fa32b979_76fee36c","updated":"2015-06-16 05:55:38.000000000","message":"I guess it can be removed at all. Just specify both - password and key.","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79b0b8a92f2149ef5dc9d7ce34139068c1262ab1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        client_params \u003d {"},{"line_number":168,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"},{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_2ff22070","line":170,"in_reply_to":"fa32b979_97ca68a0","updated":"2015-06-16 07:39:46.000000000","message":"Done","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef749dff3c04644d7a4ff3f86d05e1fe3c377674","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"},{"line_number":174,"context_line":"        }"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_5624ff0b","line":172,"updated":"2015-06-15 15:48:37.000000000","message":"Please Add a \u0027.\u0027 in the end. \nBegin with a capital letter.","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"882965c4074c0208c39c5bcd764f72f41f4688b1","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"},{"line_number":174,"context_line":"        }"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_f73ad497","line":172,"in_reply_to":"fa32b979_5624ff0b","updated":"2015-06-16 05:55:38.000000000","message":"Same here, why do we need it? If we say that some specific image supports, then we should name which one, else it is strange to say \"some new image does support it\".","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79b0b8a92f2149ef5dc9d7ce34139068c1262ab1","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            # HINT(mkoderer): as workaround for bug #1421104 we have to ignore"},{"line_number":170,"context_line":"            # the keypair and use the configured username and password"},{"line_number":171,"context_line":"            \u0027password\u0027: CONF.share.image_password,"},{"line_number":172,"context_line":"            # NOTE(u_glide): new service image supports public-key auth"},{"line_number":173,"context_line":"            \u0027pkey\u0027: kwargs.get(\u0027private_key\u0027)"},{"line_number":174,"context_line":"        }"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_8f032c42","line":172,"in_reply_to":"fa32b979_f73ad497","updated":"2015-06-16 07:39:46.000000000","message":"Done","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7e8886d4277f0dfb8f2791de7d61e3a4b2605116","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            addr \u003d server_or_ip[\u0027addresses\u0027][CONF.compute.network_for_ssh][0]"},{"line_number":166,"context_line":"            ip \u003d addr[\u0027addr\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # NOTE(u_glide): Both options (pkey and password) is required here to"},{"line_number":169,"context_line":"        # support service images without Nova metadata support"},{"line_number":170,"context_line":"        client_params \u003d {"},{"line_number":171,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_1c1af16e","line":168,"updated":"2015-06-16 10:46:37.000000000","message":"s/is/are/","commit_id":"33601c7c3a1a8069fdd8711a777bbf87fd4f8ea7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"847bc1a0cf96bb1b2368bdf6fd4bb1d389937c9c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            addr \u003d server_or_ip[\u0027addresses\u0027][CONF.compute.network_for_ssh][0]"},{"line_number":166,"context_line":"            ip \u003d addr[\u0027addr\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # NOTE(u_glide): Both options (pkey and password) is required here to"},{"line_number":169,"context_line":"        # support service images without Nova metadata support"},{"line_number":170,"context_line":"        client_params \u003d {"},{"line_number":171,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_62f4a7f1","line":168,"in_reply_to":"fa32b979_1c1af16e","updated":"2015-06-16 14:55:24.000000000","message":"Done","commit_id":"33601c7c3a1a8069fdd8711a777bbf87fd4f8ea7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"70a0f8b6b4fe2471402730a819235c362d1e8b96","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            addr \u003d server_or_ip[\u0027addresses\u0027][CONF.compute.network_for_ssh][0]"},{"line_number":166,"context_line":"            ip \u003d addr[\u0027addr\u0027]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # NOTE(u_glide): Both options (pkey and password) is required here to"},{"line_number":169,"context_line":"        # support service images without Nova metadata support"},{"line_number":170,"context_line":"        client_params \u003d {"},{"line_number":171,"context_line":"            \u0027username\u0027: kwargs[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa32b979_223c5fc7","line":168,"updated":"2015-06-16 14:53:22.000000000","message":"Reminding not addressed comment: https://review.openstack.org/#/c/187550/11/contrib/tempest/tempest/scenario/manager_share.py","commit_id":"bb694b493ee3d4fd6e7817c7d0850d4d9ec246dc"}],"contrib/tempest/tempest/scenario/test_share_basic_ops.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ac61a4cde94262362bc237bb6ff81de9698c2607","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestShareBasicOpsCIFS(TestShareBasicOpsNFS):"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    protocol \u003d \"CIFS\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_990c073d","line":186,"updated":"2015-06-11 15:52:30.000000000","message":"Would be better if NFS and CIFS extended TestShareBasicOps.  Having CIFS extend NFS doesn\u0027t generally look as good.","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a9f8e3b7cd715fc4df7088ff78e9ce01136f110a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestShareBasicOpsCIFS(TestShareBasicOpsNFS):"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    protocol \u003d \"CIFS\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1af86dd1_fc8629b8","line":186,"in_reply_to":"1af86dd1_380503c2","updated":"2015-06-12 18:13:36.000000000","message":"Not a big deal, but look at this example:\nhttps://review.openstack.org/#/c/180219/25..27/manilaclient/tests/functional/test_shares.py","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9e13321081298f7942af51ebce505cde2ea3d62f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestShareBasicOpsCIFS(TestShareBasicOpsNFS):"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    protocol \u003d \"CIFS\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_07fad8bd","line":186,"in_reply_to":"1af86dd1_fc8629b8","updated":"2015-06-15 09:50:19.000000000","message":"Hmm, interesting. I will take a look. Thanks!","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"7bd4f474b75ad3c63185bf5b1c7dc814b635e6d4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestShareBasicOpsCIFS(TestShareBasicOpsNFS):"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    protocol \u003d \"CIFS\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1af86dd1_380503c2","line":186,"in_reply_to":"3afb71cf_990c073d","updated":"2015-06-12 08:44:42.000000000","message":"It terms of general OOP it doesn\u0027t look good, but in tests it\u0027s required because if I extract base class from TestShareBasicOpsNFS and place this class in this file, then test runner will attempt to run 3 test cases instead of 2. We could create a workaround, for this and place extracted parent  class in the different folder, but it will be even worse than TestShareBasicOpsCIFS inherited from TestShareBasicOpsNFS. That\u0027s why NFS test cases are parent  classes and CIFS is child. As you can see in existing test cases (for example in contrib/tempest/tempest/api/share/test_shares.py).","commit_id":"89abfe88721ae88b759b667b3dd16de9a935798e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"882965c4074c0208c39c5bcd764f72f41f4688b1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            server_ip \u003d self.share[\u0027export_location\u0027].split(\":\")[0]"},{"line_number":97,"context_line":"            ssh_client.exec_command(\"ping -c 1 %s\" % server_ip)"},{"line_number":98,"context_line":"        return ssh_client"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def mount_share(self, location, ssh_client):"},{"line_number":101,"context_line":"        ssh_client.exec_command(\"sudo mount \\\"%s\\\" /mnt\" % location)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_174c186f","line":99,"updated":"2015-06-16 05:55:38.000000000","message":"Since you separate NFS and CIFS protocols, then this method should not be implemented here - in base class and should be redefined in inheritor.\n\nHere:\n\n\"\"\"\n\nraise NotImplementedError\n\n\"\"\"","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79b0b8a92f2149ef5dc9d7ce34139068c1262ab1","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            server_ip \u003d self.share[\u0027export_location\u0027].split(\":\")[0]"},{"line_number":97,"context_line":"            ssh_client.exec_command(\"ping -c 1 %s\" % server_ip)"},{"line_number":98,"context_line":"        return ssh_client"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def mount_share(self, location, ssh_client):"},{"line_number":101,"context_line":"        ssh_client.exec_command(\"sudo mount \\\"%s\\\" /mnt\" % location)"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_8f8a4cbe","line":99,"in_reply_to":"fa32b979_174c186f","updated":"2015-06-16 07:39:46.000000000","message":"Done","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"882965c4074c0208c39c5bcd764f72f41f4688b1","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestShareBasicOpsNFS(ShareBasicOpsBase):"},{"line_number":187,"context_line":"    protocol \u003d \"NFS\""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"class TestShareBasicOpsCIFS(ShareBasicOpsBase):"},{"line_number":191,"context_line":"    protocol \u003d \"CIFS\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_776484e4","line":188,"updated":"2015-06-16 05:55:38.000000000","message":"def mount_share(self, location, ssh_client):\n\n    ssh_client.exec_command(\"sudo mount \\\"%s\\\" /mnt\" % location)","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79b0b8a92f2149ef5dc9d7ce34139068c1262ab1","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class TestShareBasicOpsNFS(ShareBasicOpsBase):"},{"line_number":187,"context_line":"    protocol \u003d \"NFS\""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"class TestShareBasicOpsCIFS(ShareBasicOpsBase):"},{"line_number":191,"context_line":"    protocol \u003d \"CIFS\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_af85d0ad","line":188,"in_reply_to":"fa32b979_776484e4","updated":"2015-06-16 07:39:46.000000000","message":"Done","commit_id":"c864e3df76b5a71d660303697763d8ec37dfe72b"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"2e09356bd0d88028ecef76e42e70968f2bc4ab0d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShareBasicOpsBase(manager.ShareScenarioTest):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    \"\"\"This smoke test case follows this basic set of operations:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa32b979_5f5c767c","line":29,"updated":"2015-06-18 13:20:20.000000000","message":"How is this reorganization related to the commit msg \"Use new manila-service-image with public-key auth\" ?","commit_id":"ea5b2501adc68c82d5feaa145dd3d44f220574ad"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"754d22ce7123ad871e7a9a703bfc5d97ca4b3984","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShareBasicOpsBase(manager.ShareScenarioTest):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    \"\"\"This smoke test case follows this basic set of operations:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa32b979_e2292d9c","line":29,"in_reply_to":"fa32b979_5f5c767c","updated":"2015-06-18 13:38:16.000000000","message":"Scenario tests are tied on service image features. So, with usage of new image tests are updated. Same approach as for unit tests.","commit_id":"ea5b2501adc68c82d5feaa145dd3d44f220574ad"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"2f703e671c3710021f1914dc2cfab85e219a94ad","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShareBasicOpsBase(manager.ShareScenarioTest):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    \"\"\"This smoke test case follows this basic set of operations:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa32b979_73a411b9","line":29,"in_reply_to":"fa32b979_e2292d9c","updated":"2015-06-18 14:17:27.000000000","message":"Hm. This commit closes lp#1421104. Imo it should do what this bug requires to get fixed. I\u0027m sure testing now a CIFS mount is not required to fix the bug. But if you are both fine with this, fine for me.","commit_id":"ea5b2501adc68c82d5feaa145dd3d44f220574ad"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"1993246aca1f693de62ad6d85d5aa65de1028a6d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShareBasicOpsBase(manager.ShareScenarioTest):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    \"\"\"This smoke test case follows this basic set of operations:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa32b979_788b901f","line":29,"in_reply_to":"fa32b979_e2292d9c","updated":"2015-06-18 14:00:09.000000000","message":"Valeriy +1","commit_id":"ea5b2501adc68c82d5feaa145dd3d44f220574ad"}],"devstack/plugin.sh":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"50400e24f3f0fb8a8c6d4cae4db992d9ac33f9df","unresolved":false,"context_lines":[{"line_number":87,"context_line":"MANILA_PATH_TO_PRIVATE_KEY\u003d${MANILA_PATH_TO_PRIVATE_KEY:-\"$USER_HOME/.ssh/id_rsa\"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":90,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"https://github.com/uglide/manila-service-image/releases/download/debug-2/manila-service-image.qcow2\"}"},{"line_number":91,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image\"}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"MANILA_SERVICE_VM_FLAVOR_REF\u003d${MANILA_SERVICE_VM_FLAVOR_REF:-100}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3afb71cf_d0d78deb","line":90,"updated":"2015-06-08 19:04:21.000000000","message":"manila-image-elements","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"200a738d89c69a9ae0978eb85d18c6573c6215f8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"MANILA_PATH_TO_PRIVATE_KEY\u003d${MANILA_PATH_TO_PRIVATE_KEY:-\"$USER_HOME/.ssh/id_rsa\"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":90,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"https://github.com/uglide/manila-service-image/releases/download/debug-2/manila-service-image.qcow2\"}"},{"line_number":91,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image\"}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"MANILA_SERVICE_VM_FLAVOR_REF\u003d${MANILA_SERVICE_VM_FLAVOR_REF:-100}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3afb71cf_26767d06","line":90,"in_reply_to":"3afb71cf_17b746f6","updated":"2015-06-09 16:12:17.000000000","message":"They why does https://github.com/uglide/manila-service-image take me to here: https://github.com/uglide/manila-image-elements   ???","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"9760ec2e7b65a527b6c551763ab0b42ae4943f9d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"MANILA_PATH_TO_PRIVATE_KEY\u003d${MANILA_PATH_TO_PRIVATE_KEY:-\"$USER_HOME/.ssh/id_rsa\"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":90,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"https://github.com/uglide/manila-service-image/releases/download/debug-2/manila-service-image.qcow2\"}"},{"line_number":91,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image\"}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"MANILA_SERVICE_VM_FLAVOR_REF\u003d${MANILA_SERVICE_VM_FLAVOR_REF:-100}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3afb71cf_3438c7ee","line":90,"in_reply_to":"3afb71cf_26767d06","updated":"2015-06-10 06:47:17.000000000","message":"Github automatically redirects to correct url if repo was renamed.\nI will change this url.","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"79bfd93b427ee41f138123895384416d626a4fa1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"MANILA_PATH_TO_PRIVATE_KEY\u003d${MANILA_PATH_TO_PRIVATE_KEY:-\"$USER_HOME/.ssh/id_rsa\"}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":90,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"https://github.com/uglide/manila-service-image/releases/download/debug-2/manila-service-image.qcow2\"}"},{"line_number":91,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image\"}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"MANILA_SERVICE_VM_FLAVOR_REF\u003d${MANILA_SERVICE_VM_FLAVOR_REF:-100}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3afb71cf_17b746f6","line":90,"in_reply_to":"3afb71cf_d0d78deb","updated":"2015-06-09 07:45:41.000000000","message":"manila-image-elements is name of project which contains elements (modules) for manila-service-image creation. So manila-service-image is correct name here.","commit_id":"14951e24c07b2240ceade5f3535300a8258eabe6"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"1180900bc127ce8713e9ba30ae099964b098a1c4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"MANILA_SERVICE_KEYPAIR_NAME\u003d${MANILA_SERVICE_KEYPAIR_NAME:-\"manila-service\"}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"MANILA_SERVICE_INSTANCE_USER\u003d${MANILA_SERVICE_INSTANCE_USER:-\"manila\"}"},{"line_number":91,"context_line":"MANILA_SERVICE_IMAGE_URL\u003d${MANILA_SERVICE_IMAGE_URL:-\"https://github.com/uglide/manila-image-elements/releases/download/0.1.0/manila-service-image.qcow2\"}"},{"line_number":92,"context_line":"MANILA_SERVICE_IMAGE_NAME\u003d${MANILA_SERVICE_IMAGE_NAME:-\"manila-service-image\"}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"MANILA_SERVICE_VM_FLAVOR_REF\u003d${MANILA_SERVICE_VM_FLAVOR_REF:-100}"}],"source_content_type":"text/x-sh","patch_set":17,"id":"fa32b979_1bce572d","line":91,"updated":"2015-06-23 13:33:56.000000000","message":"I want to see this updated to point to something from the manila-image-elements project ASAP","commit_id":"d3d5d77ab61e0837aa0612482c9e0762999e0e0a"}]}
