)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to setting \u0027rw\u0027 and \u0027ro\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9f9202242ec89c0dad27befce8992481e298d407"},{"line_number":13,"context_line":"Partially-Implements: bp huawei-driver-read-only-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_654eab3c","line":13,"updated":"2015-06-04 18:15:31.000000000","message":"why partially?","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to setting \u0027rw\u0027 and \u0027ro\u0027."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9f9202242ec89c0dad27befce8992481e298d407"},{"line_number":13,"context_line":"Partially-Implements: bp huawei-driver-read-only-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_ff3ab1e6","line":13,"in_reply_to":"5afe65bd_654eab3c","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3f6f4b5ba7805624355184cd74688ccb1d4b643d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        LOG.debug(\"Allow access.\")"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        access_info \u003d self.plugin.allow_access(share, access, share_server)"},{"line_number":131,"context_line":"        return {\u0027access_info\u0027: access_info}"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":134,"context_line":"        \"\"\"Deny access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_2c065786","line":131,"updated":"2015-06-09 19:22:58.000000000","message":"Why is this backend-specific structure being returned from allow_access?  The share manager isn\u0027t expecting anything to be returned from this driver method.  Please find a different way (i.e. mocks and asserts) to make your unit tests work.","commit_id":"0e9a360c00d127cb65a075b28beedbd1a4276e53"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58f79532ede1d4797a4cf9b64bcd961f21bc330a","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":280,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if access_level !\u003d \u0027rw\u0027 and access_level !\u003d \u0027ro\u0027:"},{"line_number":283,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":284,"context_line":"                reason\u003d(_(\u0027Unsupported level of access was provided - %s\u0027) %"},{"line_number":285,"context_line":"                        access_level))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_8b65bfe2","line":282,"updated":"2015-06-05 10:38:56.000000000","message":"Please, use constants here instead of literals:\n\nhttps://github.com/openstack/manila/blob/36fae29e/manila/common/constants.py#L76\n\nhttps://github.com/openstack/manila/blob/36fae29e/manila/common/constants.py#L77\n\nAlso, condition can be simplified:\n\n\"\"\"\n\nif access_level not in manila.common.constants.ACCESS_LEVELS:\n\n\"\"\"","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":280,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if access_level !\u003d \u0027rw\u0027 and access_level !\u003d \u0027ro\u0027:"},{"line_number":283,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":284,"context_line":"                reason\u003d(_(\u0027Unsupported level of access was provided - %s\u0027) %"},{"line_number":285,"context_line":"                        access_level))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_01586031","line":282,"in_reply_to":"3afb71cf_8b65bfe2","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"ebac9be38f37dc371592085544e466cf0f8cb1ed","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if access_level !\u003d \u0027rw\u0027 and access_level !\u003d \u0027ro\u0027:"},{"line_number":283,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":284,"context_line":"                reason\u003d(_(\u0027Unsupported level of access was provided - %s\u0027) %"},{"line_number":285,"context_line":"                        access_level))"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_26268615","line":283,"updated":"2015-06-04 14:41:54.000000000","message":"Might want to add a unit test to cover this case.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        if access_level !\u003d \u0027rw\u0027 and access_level !\u003d \u0027ro\u0027:"},{"line_number":283,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":284,"context_line":"                reason\u003d(_(\u0027Unsupported level of access was provided - %s\u0027) %"},{"line_number":285,"context_line":"                        access_level))"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_0a7e6de4","line":283,"in_reply_to":"5afe65bd_26268615","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58f79532ede1d4797a4cf9b64bcd961f21bc330a","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":288,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":289,"context_line":"                if access_level \u003d\u003d \u0027rw\u0027:"},{"line_number":290,"context_line":"                    access_level \u003d constants.ACCESS_NFS_RW"},{"line_number":291,"context_line":"                else:"},{"line_number":292,"context_line":"                    access_level \u003d constants.ACCESS_NFS_RO"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_8bda5f77","line":289,"updated":"2015-06-05 10:38:56.000000000","message":"same here","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":288,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":289,"context_line":"                if access_level \u003d\u003d \u0027rw\u0027:"},{"line_number":290,"context_line":"                    access_level \u003d constants.ACCESS_NFS_RW"},{"line_number":291,"context_line":"                else:"},{"line_number":292,"context_line":"                    access_level \u003d constants.ACCESS_NFS_RO"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_e15ae429","line":289,"in_reply_to":"3afb71cf_8bda5f77","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7730916acc390c649c4b77f36bd4212ab100bddf","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_323ddc2b","line":306,"updated":"2015-06-15 08:18:23.000000000","message":"If share protocol not \"NFS\" or \"CIFS\", then var \"access_level\" won\u0027t be defined and you will get NameError exception on line 317. So, this should be fixed AND covered with unit tests.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"255b321427da0b0607a9b776b67c0451b62dedd6","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_43565bd3","line":306,"in_reply_to":"fa32b979_0864f21f","updated":"2015-06-16 08:57:07.000000000","message":"On line 283 access level is checked. Not share proto. It is two different things.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f0ea453fa5bb354d91e530902ebb8559172e7c28","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_3405a879","line":306,"in_reply_to":"fa32b979_323ddc2b","updated":"2015-06-15 20:29:08.000000000","message":"+1","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f731245b7f56329a8045a4042b1dbceab5805eba","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_0864f21f","line":306,"in_reply_to":"fa32b979_323ddc2b","updated":"2015-06-16 08:48:49.000000000","message":"In line 283, I check the share protocol not \"NFS\" or \"CIFS\".\n\nIf I add a branch in there, it will not be not be covered.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"14dc2381e325520b7b9ed1625cec84e6c2166ab2","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_fce62db3","line":306,"in_reply_to":"fa32b979_43565bd3","updated":"2015-06-16 10:57:56.000000000","message":"sorry, Actually, In line 279, I check the share protocol not \"NFS\" or \"CIFS\".\nIf I add a branch in there, it will not be not be covered.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"09d279cab1f4bacf334b6193311ad5aedafa63ef","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_6ccd1930","line":306,"in_reply_to":"fa32b979_5c5b9954","updated":"2015-06-18 11:56:31.000000000","message":"I agree that the names are bad but the names are already there. So I would like to see the rename in a different commit. This one is about rw/ro support.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7691ff97aadbdb4360d60809694b4a650a94196","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            else:"},{"line_number":304,"context_line":"                message \u003d _(\u0027Only USER access type is allowed\u0027"},{"line_number":305,"context_line":"                            \u0027 for CIFS shares.\u0027)"},{"line_number":306,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":309,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_5c5b9954","line":306,"in_reply_to":"fa32b979_fce62db3","updated":"2015-06-16 11:16:10.000000000","message":"Now I see. Line 279 indeed covers mentioned case. But it has confusing name, because \"share type\" is used in Manila for different thing. It should not have been named so. Same about helper method \"_get_share_type\".","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d36d9122621d6078fece200d0b9e7eb271962fe9","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # The unit is the sectors."},{"line_number":101,"context_line":"        size \u003d new_size * units.Mi * 2"},{"line_number":102,"context_line":"        share_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":105,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_ec3fe9b1","line":102,"updated":"2015-06-18 11:44:49.000000000","message":"Unleated to the commit message. Why are you renaming this? imo has nothing to do with the rw/ro thing","commit_id":"87131d7a3c1bb95a6262610c018ee54bd7c349ea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"728a870c27688ee631d861a8c56b1186d9e0302b","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # The unit is the sectors."},{"line_number":101,"context_line":"        size \u003d new_size * units.Mi * 2"},{"line_number":102,"context_line":"        share_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":105,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_5bd1ca21","line":102,"in_reply_to":"fa32b979_6c3759ff","updated":"2015-06-19 01:25:32.000000000","message":"Done","commit_id":"87131d7a3c1bb95a6262610c018ee54bd7c349ea"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"b7e55322d3ac9dc5cc9827f449516a25e7e0196f","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # The unit is the sectors."},{"line_number":101,"context_line":"        size \u003d new_size * units.Mi * 2"},{"line_number":102,"context_line":"        share_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":105,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_6c3759ff","line":102,"in_reply_to":"fa32b979_8c197d24","updated":"2015-06-18 11:58:27.000000000","message":"I agree with Valeriy that the names are bad. But as answered in Patch8, the names are already there. Please change them in a different commit. This commit is about rw/ro support.","commit_id":"87131d7a3c1bb95a6262610c018ee54bd7c349ea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fdf1cc6b441b093070b7a60ac1228d6ac5b9bcac","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        # The unit is the sectors."},{"line_number":101,"context_line":"        size \u003d new_size * units.Mi * 2"},{"line_number":102,"context_line":"        share_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_type)"},{"line_number":105,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_8c197d24","line":102,"in_reply_to":"fa32b979_ec3fe9b1","updated":"2015-06-18 11:47:09.000000000","message":"Please see patch 8.\n\nValeriy Ponomaryov\t\tJun 16 7:16 PM\nNow I see. Line 279 indeed covers mentioned case. But it has confusing name, because \"share type\" is used in Manila for different thing. It should not have been named so. Same about helper method \"_get_share_type\".","commit_id":"87131d7a3c1bb95a6262610c018ee54bd7c349ea"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d36d9122621d6078fece200d0b9e7eb271962fe9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        share_proto \u003d snapshot[\u0027share_proto\u0027]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        share_name \u003d self.helper._get_share_name_by_id(snapshot[\u0027share_id\u0027])"},{"line_number":127,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":128,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_4c77f59f","line":127,"updated":"2015-06-18 11:44:49.000000000","message":"Same here and in most of the changes...","commit_id":"87131d7a3c1bb95a6262610c018ee54bd7c349ea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"728a870c27688ee631d861a8c56b1186d9e0302b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        share_proto \u003d snapshot[\u0027share_proto\u0027]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        share_name \u003d self.helper._get_share_name_by_id(snapshot[\u0027share_id\u0027])"},{"line_number":127,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":128,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        if not share:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa32b979_7bccce88","line":127,"in_reply_to":"fa32b979_4c77f59f","updated":"2015-06-19 01:25:32.000000000","message":"Done","commit_id":"87131d7a3c1bb95a6262610c018ee54bd7c349ea"}],"manila/share/drivers/huawei/v3/helper.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                return item[\u0027ID\u0027]"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _allow_access_rest(self, share_id, access_to,"},{"line_number":370,"context_line":"                           share_proto, share_level):"},{"line_number":371,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":372,"context_line":"        access_type \u003d self._get_share_client_type(share_proto)"},{"line_number":373,"context_line":"        url \u003d self.url + \"/\" + access_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_e5d5fb1b","line":370,"updated":"2015-06-04 18:15:31.000000000","message":"I\u0027d  s/share_level/access_level/  but if you prefer this it\u0027s OK with me.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"58f79532ede1d4797a4cf9b64bcd961f21bc330a","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                return item[\u0027ID\u0027]"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _allow_access_rest(self, share_id, access_to,"},{"line_number":370,"context_line":"                           share_proto, share_level):"},{"line_number":371,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":372,"context_line":"        access_type \u003d self._get_share_client_type(share_proto)"},{"line_number":373,"context_line":"        url \u003d self.url + \"/\" + access_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_2b5ecbe9","line":370,"in_reply_to":"5afe65bd_e5d5fb1b","updated":"2015-06-05 10:38:56.000000000","message":"Actually, it is exactly \"access\" level. There is no such thing as \"share level\". Please, rename it.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                return item[\u0027ID\u0027]"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _allow_access_rest(self, share_id, access_to,"},{"line_number":370,"context_line":"                           share_proto, share_level):"},{"line_number":371,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":372,"context_line":"        access_type \u003d self._get_share_client_type(share_proto)"},{"line_number":373,"context_line":"        url \u003d self.url + \"/\" + access_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_9f229db8","line":370,"in_reply_to":"5afe65bd_e5d5fb1b","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            \u0027access_type\u0027: \u0027user\u0027,"},{"line_number":370,"context_line":"            \u0027access_to\u0027: \u0027user_name\u0027,"},{"line_number":371,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":372,"context_line":"        }"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        self.share_server \u003d None"},{"line_number":375,"context_line":"        self.driver._licenses \u003d [\u0027fake\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_85b3e7e8","line":372,"updated":"2015-06-04 18:15:31.000000000","message":"Curious why your \u0027ro\u0027 test data isn\u0027t here or maybe these should be moved below.  I may be missing a reason for the inconsistency.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"79dd1ccfa55e3a77734effa20f5dd8f37922255b","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            \u0027access_type\u0027: \u0027user\u0027,"},{"line_number":370,"context_line":"            \u0027access_to\u0027: \u0027user_name\u0027,"},{"line_number":371,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"},{"line_number":372,"context_line":"        }"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        self.share_server \u003d None"},{"line_number":375,"context_line":"        self.driver._licenses \u003d [\u0027fake\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_efc60a67","line":372,"in_reply_to":"5afe65bd_85b3e7e8","updated":"2015-06-09 11:56:59.000000000","message":"Because \u0027ro\u0027 test data only used once.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"ebac9be38f37dc371592085544e466cf0f8cb1ed","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        self.assertEqual(2, capacity[\u0027TOTALCAPACITY\u0027])"},{"line_number":646,"context_line":"        self.assertEqual(1, capacity[\u0027CAPACITY\u0027])"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_allow_access_ip_success(self):"},{"line_number":649,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":650,"context_line":"        self.allow_flag \u003d False"},{"line_number":651,"context_line":"        self.driver.allow_access(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_46de22de","line":648,"updated":"2015-06-04 14:41:54.000000000","message":"I wonder if you\u0027d rather call this \"test_allow_access_ip_rw_success\" to better contrast with the following test.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        self.assertEqual(2, capacity[\u0027TOTALCAPACITY\u0027])"},{"line_number":646,"context_line":"        self.assertEqual(1, capacity[\u0027CAPACITY\u0027])"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_allow_access_ip_success(self):"},{"line_number":649,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":650,"context_line":"        self.allow_flag \u003d False"},{"line_number":651,"context_line":"        self.driver.allow_access(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_a5e5c3dc","line":648,"in_reply_to":"5afe65bd_46de22de","updated":"2015-06-04 18:15:31.000000000","message":"+1","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        self.assertEqual(2, capacity[\u0027TOTALCAPACITY\u0027])"},{"line_number":646,"context_line":"        self.assertEqual(1, capacity[\u0027CAPACITY\u0027])"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_allow_access_ip_success(self):"},{"line_number":649,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":650,"context_line":"        self.allow_flag \u003d False"},{"line_number":651,"context_line":"        self.driver.allow_access(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ca5bb52d","line":648,"in_reply_to":"5afe65bd_46de22de","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                                 self.share_nfs,"},{"line_number":668,"context_line":"                                 access_ro,"},{"line_number":669,"context_line":"                                 self.share_server)"},{"line_number":670,"context_line":"        self.assertTrue(self.driver.plugin.helper.allow_flag)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def test_allow_access_user_success(self):"},{"line_number":673,"context_line":"        self.driver.plugin.helper.login()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_a5cf0328","line":670,"updated":"2015-06-04 18:15:31.000000000","message":"I think you need to test for \u0027ro\u0027 or \u0027rw\u0027 not just True.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"ebac9be38f37dc371592085544e466cf0f8cb1ed","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                 self.share_server)"},{"line_number":670,"context_line":"        self.assertTrue(self.driver.plugin.helper.allow_flag)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def test_allow_access_user_success(self):"},{"line_number":673,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":674,"context_line":"        self.allow_flag \u003d False"},{"line_number":675,"context_line":"        self.driver.allow_access(self._context, self.share_cifs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_a6f5d657","line":672,"updated":"2015-06-04 14:41:54.000000000","message":"Same suggestion here.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                 self.share_server)"},{"line_number":670,"context_line":"        self.assertTrue(self.driver.plugin.helper.allow_flag)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def test_allow_access_user_success(self):"},{"line_number":673,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":674,"context_line":"        self.allow_flag \u003d False"},{"line_number":675,"context_line":"        self.driver.allow_access(self._context, self.share_cifs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_25daf317","line":672,"in_reply_to":"5afe65bd_a6f5d657","updated":"2015-06-04 18:15:31.000000000","message":"+1","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a0e509fb843153c2426d14d4e8e2eff36e0dc27c","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                 self.share_server)"},{"line_number":670,"context_line":"        self.assertTrue(self.driver.plugin.helper.allow_flag)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def test_allow_access_user_success(self):"},{"line_number":673,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":674,"context_line":"        self.allow_flag \u003d False"},{"line_number":675,"context_line":"        self.driver.allow_access(self._context, self.share_cifs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ca805549","line":672,"in_reply_to":"5afe65bd_a6f5d657","updated":"2015-06-08 02:15:25.000000000","message":"Done","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"715ca5fc30e3608aa088f20477ce2dc7864524d0","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        self.allow_flag \u003d False"},{"line_number":688,"context_line":"        self.driver.allow_access(self._context, self.share_cifs,"},{"line_number":689,"context_line":"                                 access_ro, self.share_server)"},{"line_number":690,"context_line":"        self.assertTrue(self.driver.plugin.helper.allow_flag)"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def test_get_share_client_type_fail(self):"},{"line_number":693,"context_line":"        share_proto \u003d \u0027fake_proto\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_45dbafec","line":690,"updated":"2015-06-04 18:15:31.000000000","message":"I think you need to test for \u0027ro\u0027 or \u0027rw\u0027 not just True.","commit_id":"f05210f2563cc27bf9f303a73262dec1aa0502dd"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8b5416fd6bf686684ce3b8e0da551dfed16f6b70","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def call(self, url, data\u003dNone, method\u003dNone):"},{"line_number":93,"context_line":"        url \u003d url.replace(\u0027http://100.115.10.69:8082/deviceManager/rest\u0027, \u0027\u0027)"},{"line_number":94,"context_line":"        url \u003d url.replace(\u0027/210235G7J20000000000/\u0027, \u0027\u0027)"},{"line_number":95,"context_line":"        response \u003d None"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if self.test_normal:"},{"line_number":98,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_bf3bc79b","line":95,"updated":"2015-06-08 16:50:24.000000000","message":"Would be cleaner patch if you didn\u0027t introduce this unneeded rename.","commit_id":"e590bccb9fa671669d1b860a2a396302926ec5f3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fd52aa2312053ed89735b35134aa253ff15ebebd","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if self.test_normal:"},{"line_number":161,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"},{"line_number":162,"context_line":"                result \u003d data_session(url)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            if url \u003d\u003d \"storagepool\":"},{"line_number":165,"context_line":"                result \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_e13916f3","line":162,"updated":"2015-06-11 09:46:12.000000000","message":"Please, introduce renaming in separate commit. It introduces too many changes and not related to the goal of commit.","commit_id":"20072bd10c262a9a75463f869d4bf933407374f7"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"61e2da834b26cca74420713a817ab20de2a75edd","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if self.test_normal:"},{"line_number":161,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"},{"line_number":162,"context_line":"                result \u003d data_session(url)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            if url \u003d\u003d \"storagepool\":"},{"line_number":165,"context_line":"                result \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":6,"id":"3afb71cf_cd3401fd","line":162,"in_reply_to":"3afb71cf_e13916f3","updated":"2015-06-11 14:54:43.000000000","message":"+1","commit_id":"20072bd10c262a9a75463f869d4bf933407374f7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"866fe31ed9f6309359bc7b8d26a7f95fc55024af","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if self.test_normal:"},{"line_number":161,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"},{"line_number":162,"context_line":"                result \u003d data_session(url)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            if url \u003d\u003d \"storagepool\":"},{"line_number":165,"context_line":"                result \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_b3afc4e2","line":162,"in_reply_to":"3afb71cf_e13916f3","updated":"2015-06-14 00:16:58.000000000","message":"Actually, The \u0027result\u0027 is a temporary variable. Should not be named \u0027data\u0027. \n\nBut if ranaming in separate commit, how to make this case run?\n\nIs it OK? I am open a bug. and the renaming at the same time in bug and this bp?","commit_id":"20072bd10c262a9a75463f869d4bf933407374f7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"191f509f13672260a13e17f7e68c1089bda3fd7e","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if self.test_normal:"},{"line_number":161,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"},{"line_number":162,"context_line":"                result \u003d data_session(url)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            if url \u003d\u003d \"storagepool\":"},{"line_number":165,"context_line":"                result \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_21490f8c","line":162,"in_reply_to":"fa32b979_b3afc4e2","updated":"2015-06-15 04:06:52.000000000","message":"Please change \"result\" back to \"data\" in this patch.\n\nSubmit another patch later to rename \"data\" to \"result\".","commit_id":"20072bd10c262a9a75463f869d4bf933407374f7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7730916acc390c649c4b77f36bd4212ab100bddf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return data"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def allow_access_nfs(method, data):"},{"line_number":69,"context_line":"    allow_ro_flag \u003d False"},{"line_number":70,"context_line":"    allow_rw_flag \u003d False"},{"line_number":71,"context_line":"    access \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_d277d000","line":68,"updated":"2015-06-15 08:18:23.000000000","message":"This func and \"allow_access_cifs\" have lots of common lines. Better to make them use some common func with this duplicated code.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7691ff97aadbdb4360d60809694b4a650a94196","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return data"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def allow_access_nfs(method, data):"},{"line_number":69,"context_line":"    allow_ro_flag \u003d False"},{"line_number":70,"context_line":"    allow_rw_flag \u003d False"},{"line_number":71,"context_line":"    access \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_ff6dbf98","line":68,"in_reply_to":"fa32b979_03de1311","updated":"2015-06-16 11:16:10.000000000","message":"Ok. Note, that \"done\" is third form of verb \"do\" that refers to past tense. Would be proper to say \"I will do\".","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"255b321427da0b0607a9b776b67c0451b62dedd6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return data"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def allow_access_nfs(method, data):"},{"line_number":69,"context_line":"    allow_ro_flag \u003d False"},{"line_number":70,"context_line":"    allow_rw_flag \u003d False"},{"line_number":71,"context_line":"    access \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_6316fff2","line":68,"in_reply_to":"fa32b979_084b9288","updated":"2015-06-16 08:57:07.000000000","message":"Please, use \"done\" only when patch-set was uploaded. Right now it looks like you forgot to upload patch-set.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"baeef07ce4c75f69a1ad6425899a3dec2fd48597","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return data"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def allow_access_nfs(method, data):"},{"line_number":69,"context_line":"    allow_ro_flag \u003d False"},{"line_number":70,"context_line":"    allow_rw_flag \u003d False"},{"line_number":71,"context_line":"    access \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_03de1311","line":68,"in_reply_to":"fa32b979_6316fff2","updated":"2015-06-16 09:01:06.000000000","message":"sorry, I will done.","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f731245b7f56329a8045a4042b1dbceab5805eba","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    return data"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def allow_access_nfs(method, data):"},{"line_number":69,"context_line":"    allow_ro_flag \u003d False"},{"line_number":70,"context_line":"    allow_rw_flag \u003d False"},{"line_number":71,"context_line":"    access \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_084b9288","line":68,"in_reply_to":"fa32b979_d277d000","updated":"2015-06-16 08:48:49.000000000","message":"Done","commit_id":"fd53d6235ed86ae8dde7bbdf95491af0eb0588d6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7a7e61fcc2705cb6eee9728f5c82c575bc36ed6a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def call(self, url, data\u003dNone, method\u003dNone):"},{"line_number":91,"context_line":"        url \u003d url.replace(\u0027http://100.115.10.69:8082/deviceManager/rest\u0027, \u0027\u0027)"},{"line_number":92,"context_line":"        url \u003d url.replace(\u0027/210235G7J20000000000/\u0027, \u0027\u0027)"},{"line_number":93,"context_line":"        data \u003d None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if self.test_normal:"},{"line_number":96,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_ca9cb7c2","side":"PARENT","line":93,"updated":"2015-06-16 11:31:49.000000000","message":"How this is related to another existing commit - https://review.openstack.org/#/c/192087/ ?","commit_id":"dfed9c66a8ee8658ed13547636a6721404663e88"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"218986604e100bd48d1da182aae9364e92ddb549","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def call(self, url, data\u003dNone, method\u003dNone):"},{"line_number":91,"context_line":"        url \u003d url.replace(\u0027http://100.115.10.69:8082/deviceManager/rest\u0027, \u0027\u0027)"},{"line_number":92,"context_line":"        url \u003d url.replace(\u0027/210235G7J20000000000/\u0027, \u0027\u0027)"},{"line_number":93,"context_line":"        data \u003d None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if self.test_normal:"},{"line_number":96,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_9187bfd6","side":"PARENT","line":93,"updated":"2015-06-16 14:03:53.000000000","message":"Duplicating comment from patch-set 9:\n\n\"\"\"\n\nHow this is related to another existing commit - https://review.openstack.org/#/c/192087/ ?\n\n\"\"\"","commit_id":"dfed9c66a8ee8658ed13547636a6721404663e88"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e80691fd65ad2bf14cbe31bb0669f5f11356990e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def call(self, url, data\u003dNone, method\u003dNone):"},{"line_number":91,"context_line":"        url \u003d url.replace(\u0027http://100.115.10.69:8082/deviceManager/rest\u0027, \u0027\u0027)"},{"line_number":92,"context_line":"        url \u003d url.replace(\u0027/210235G7J20000000000/\u0027, \u0027\u0027)"},{"line_number":93,"context_line":"        data \u003d None"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if self.test_normal:"},{"line_number":96,"context_line":"            if url \u003d\u003d \"/xx/sessions\" or url \u003d\u003d \"sessions\":"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_a6338013","side":"PARENT","line":93,"in_reply_to":"fa32b979_9187bfd6","updated":"2015-06-17 08:38:39.000000000","message":"The test is ok After delete \u0027data \u003d None\u0027, so https://review.openstack.org/#/c/192087/ is cancelled.","commit_id":"dfed9c66a8ee8658ed13547636a6721404663e88"}]}