)]}'
{"manila/share/drivers/generic.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"f6b8e1faa366ff1de3d11d5ebd2454d1dde59f62","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            try:"},{"line_number":346,"context_line":"                attach(self.admin_context, instance_id, volume[\u0027id\u0027])"},{"line_number":347,"context_line":"            except Exception as e:"},{"line_number":348,"context_line":"                if retry_on_error:"},{"line_number":349,"context_line":"                    time.sleep(5)"},{"line_number":350,"context_line":"                    attach(self.admin_context, instance_id, volume[\u0027id\u0027])"},{"line_number":351,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af86dd1_849b5bc9","line":348,"updated":"2015-06-12 19:58:43.000000000","message":"hm. I would prefer to use the retrying module which is already in global-requirements.","commit_id":"f4ddb0cfc924678aec043bd68ecf275a9dd811d3"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a2e643681b182f2e9d213c32c44fa9f61f36aa68","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        return os.path.join(self.configuration.share_mount_path, share[\u0027name\u0027])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _attach_volume(self, context, share, instance_id, volume,"},{"line_number":329,"context_line":"                       retry_on_error\u003dFalse):"},{"line_number":330,"context_line":"        \"\"\"Attaches cinder volume to service vm.\"\"\""},{"line_number":331,"context_line":"        @utils.synchronized("},{"line_number":332,"context_line":"            \"generic_driver_attach_detach_%s\" % instance_id, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_ebedfd25","line":329,"updated":"2015-06-16 12:28:18.000000000","message":"Do we really need \"retry_on_error\" as a parameter? In which case don\u0027t you want to retry? I would just always retry.","commit_id":"377a5df0382f93bbad5b6a1d10f304f9222ca7b0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f820ccf187c084b5b37fad049a3380f2eb0136b7","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        return os.path.join(self.configuration.share_mount_path, share[\u0027name\u0027])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _attach_volume(self, context, share, instance_id, volume,"},{"line_number":329,"context_line":"                       retry_on_error\u003dFalse):"},{"line_number":330,"context_line":"        \"\"\"Attaches cinder volume to service vm.\"\"\""},{"line_number":331,"context_line":"        @utils.synchronized("},{"line_number":332,"context_line":"            \"generic_driver_attach_detach_%s\" % instance_id, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_0b786129","line":329,"in_reply_to":"fa32b979_ebedfd25","updated":"2015-06-16 12:31:32.000000000","message":"+1","commit_id":"377a5df0382f93bbad5b6a1d10f304f9222ca7b0"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"c9c240e15fcd8b18efe571f176290579dcc46ad2","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        return os.path.join(self.configuration.share_mount_path, share[\u0027name\u0027])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _attach_volume(self, context, share, instance_id, volume,"},{"line_number":329,"context_line":"                       retry_on_error\u003dFalse):"},{"line_number":330,"context_line":"        \"\"\"Attaches cinder volume to service vm.\"\"\""},{"line_number":331,"context_line":"        @utils.synchronized("},{"line_number":332,"context_line":"            \"generic_driver_attach_detach_%s\" % instance_id, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2ba76550","line":329,"in_reply_to":"fa32b979_ebedfd25","updated":"2015-06-16 12:41:32.000000000","message":"Good point. Done","commit_id":"377a5df0382f93bbad5b6a1d10f304f9222ca7b0"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"12ec872e83846a3340a33e96513756f88c8ac256","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                          self._context, self.share, fake_server,"},{"line_number":454,"context_line":"                          available_volume,"},{"line_number":455,"context_line":"                          retry_on_error\u003dTrue)"},{"line_number":456,"context_line":"        self.assertEqual("},{"line_number":457,"context_line":"            2, self._driver.compute_api.instance_volume_attach.call_count)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def test_attach_volume_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_151d7273","line":456,"updated":"2015-06-12 08:31:26.000000000","message":"Please, add case when it works from second attempt.","commit_id":"569a074255dbb50b642cedac2bf700f564fd7f3d"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"cd5eea85a26eefe52de868b08f86e9307055795c","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                          self._context, self.share, fake_server,"},{"line_number":454,"context_line":"                          available_volume,"},{"line_number":455,"context_line":"                          retry_on_error\u003dTrue)"},{"line_number":456,"context_line":"        self.assertEqual("},{"line_number":457,"context_line":"            2, self._driver.compute_api.instance_volume_attach.call_count)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    def test_attach_volume_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_adc1a530","line":456,"in_reply_to":"1af86dd1_151d7273","updated":"2015-06-12 16:17:53.000000000","message":"Done","commit_id":"569a074255dbb50b642cedac2bf700f564fd7f3d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"44456cb423559d1a22a147524f8e37fc7365b648","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                         mock.Mock(return_value\u003d[attached_volume]))"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        result \u003d self._driver._attach_volume(self._context, self.share,"},{"line_number":470,"context_line":"                                             fake_server, attached_volume)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        self.assertEqual(result, attached_volume)"},{"line_number":473,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_895e1a44","line":470,"updated":"2015-06-13 05:51:52.000000000","message":"This isn\u0027t doing a retry.","commit_id":"f4ddb0cfc924678aec043bd68ecf275a9dd811d3"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"d33f29d3916199d8fc5c70d1cfb24a6204e2ab73","unresolved":false,"context_lines":[{"line_number":467,"context_line":"                         mock.Mock(return_value\u003d[attached_volume]))"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        result \u003d self._driver._attach_volume(self._context, self.share,"},{"line_number":470,"context_line":"                                             fake_server, attached_volume)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        self.assertEqual(result, attached_volume)"},{"line_number":473,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_5d068c21","line":470,"in_reply_to":"fa32b979_895e1a44","updated":"2015-06-13 15:34:02.000000000","message":"+1","commit_id":"f4ddb0cfc924678aec043bd68ecf275a9dd811d3"}]}
