)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"e92afbfe23dc43a6f8bfeaa3a8605bab8acafd88","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Parameter can not be test in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In test_huawei_nas.py:"},{"line_number":10,"context_line":"The \u0027Call\u0027 function of the parameters(\u0027data\u0027) can not be"},{"line_number":11,"context_line":"test. Because of the variable(\u0027data\u0027) is assigned None in line 93."},{"line_number":12,"context_line":"So modify the variable name from \u0027data\u0027 to \u0027result\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_f2d41fbe","line":10,"updated":"2015-06-16 07:59:51.000000000","message":"Commit description is unclear and it\u0027s hard to understand what this commit do. \n\nShould be changed to something like this:\n\n\"\"\"\n\nFunction manila.tests.share.drivers.huawei.test_huawei_nas.FakeHuaweiNasHelper#call cannot be properly tested because argument \u0027data\u0027 is hidden by the local variable with the same name. That\u0027s why this variable should be renamed to \u0027result\u0027.\n\n\"\"\"","commit_id":"8456899a87c0e00c33fed581432d0a628d329035"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"e92afbfe23dc43a6f8bfeaa3a8605bab8acafd88","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def data_session(url):"},{"line_number":42,"context_line":"    if url \u003d\u003d \"/xx/sessions\":"},{"line_number":43,"context_line":"        result \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":44,"context_line":"                       \"data\":{\"username\":\"admin\","},{"line_number":45,"context_line":"                               \"iBaseToken\":\"2001031430\","},{"line_number":46,"context_line":"                               \"deviceid\":\"210235G7J20000000000\"}}\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_72724f4b","line":43,"updated":"2015-06-16 07:59:51.000000000","message":"Why do you need renaming in this function? If I understand correctly you just need t o rename data-\u003eresult in body of function FakeHuaweiNasHelper#call\n\nLooks like this is out of the scope of this patch.","commit_id":"8456899a87c0e00c33fed581432d0a628d329035"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"16e1cd7d212d6c6772e92fda618f739980eb838e","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def data_session(url):"},{"line_number":42,"context_line":"    if url \u003d\u003d \"/xx/sessions\":"},{"line_number":43,"context_line":"        result \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":44,"context_line":"                       \"data\":{\"username\":\"admin\","},{"line_number":45,"context_line":"                               \"iBaseToken\":\"2001031430\","},{"line_number":46,"context_line":"                               \"deviceid\":\"210235G7J20000000000\"}}\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_7996b24d","line":43,"in_reply_to":"fa32b979_72724f4b","updated":"2015-06-16 09:45:52.000000000","message":"Yes. It is not related to change and fix.","commit_id":"8456899a87c0e00c33fed581432d0a628d329035"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"e92afbfe23dc43a6f8bfeaa3a8605bab8acafd88","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def filesystem(method, fs_status_flag):"},{"line_number":53,"context_line":"    if method \u003d\u003d \"DELETE\":"},{"line_number":54,"context_line":"        result \u003d \"\"\"{\"error\":{\"code\":0}}\"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if method \u003d\u003d \"GET\":"},{"line_number":57,"context_line":"        if fs_status_flag:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f29c1f5f","line":54,"updated":"2015-06-16 07:59:51.000000000","message":"Same here.","commit_id":"8456899a87c0e00c33fed581432d0a628d329035"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"16e1cd7d212d6c6772e92fda618f739980eb838e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def filesystem(method, fs_status_flag):"},{"line_number":53,"context_line":"    if method \u003d\u003d \"DELETE\":"},{"line_number":54,"context_line":"        result \u003d \"\"\"{\"error\":{\"code\":0}}\"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    if method \u003d\u003d \"GET\":"},{"line_number":57,"context_line":"        if fs_status_flag:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_99913655","line":54,"in_reply_to":"fa32b979_f29c1f5f","updated":"2015-06-16 09:45:52.000000000","message":"+1","commit_id":"8456899a87c0e00c33fed581432d0a628d329035"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"16e1cd7d212d6c6772e92fda618f739980eb838e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def _change_file_mode(self, filepath):"},{"line_number":88,"context_line":"        pass"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def call(self, url, data\u003dNone, method\u003dNone):"},{"line_number":91,"context_line":"        url \u003d url.replace(\u0027http://100.115.10.69:8082/deviceManager/rest\u0027, \u0027\u0027)"},{"line_number":92,"context_line":"        url \u003d url.replace(\u0027/210235G7J20000000000/\u0027, \u0027\u0027)"},{"line_number":93,"context_line":"        result \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f92ba2e9","line":90,"updated":"2015-06-16 09:45:52.000000000","message":"Even with rename of data/result input param still not tested. In this case I do not see any reason to perform renaming. Behaviour was not changed at all. Param \"data\" was ignored and still ignored.","commit_id":"8456899a87c0e00c33fed581432d0a628d329035"}]}