)]}'
{"manila/share/drivers/huawei/base.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9e08884da2413d49b4837750484bfc17310895d7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\"Shrinks size of existing share.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @abc.abstractmethod"},{"line_number":63,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":64,"context_line":"        \"\"\"Manage existing share.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_1d3ca191","line":63,"updated":"2015-07-29 17:50:26.000000000","message":"What about unmanage?  Is there nothing to do in your driver for unmanage, so that you can rely on the driver superclass to handle that for you?","commit_id":"a054273464298907664394c54e23db6326ea63ae"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fd88fbdacb9c325ac9805dd4b1dcfb9b919818","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\"Shrinks size of existing share.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @abc.abstractmethod"},{"line_number":63,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":64,"context_line":"        \"\"\"Manage existing share.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a50d1a3_77184776","line":63,"in_reply_to":"3a50d1a3_1d3ca191","updated":"2015-07-30 06:57:41.000000000","message":"Yes, there is nothing to do in our driver for unmanage. I rely on the driver superclass to handle that.","commit_id":"a054273464298907664394c54e23db6326ea63ae"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"27e078c0beaabf03fc88db40b4a880f3d90d9fbd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        LOG.debug(\"Manage existing share to manila.\")"},{"line_number":155,"context_line":"        share_size, location \u003d self.plugin.manage_existing(share,"},{"line_number":156,"context_line":"                                                           driver_options)"},{"line_number":157,"context_line":"        return {\u0027size\u0027: share_size, \u0027export_locations\u0027: location}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _update_share_stats(self):"},{"line_number":160,"context_line":"        \"\"\"Retrieve status info from share group.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_02397c41","line":157,"updated":"2015-07-24 06:55:10.000000000","message":"\u0027export_locations\u0027 is expected to be a list at final. So, would be great to provide it as list.","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"03552c5a0dae00d9a39ff10f28ccd7fd26632639","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        LOG.debug(\"Manage existing share to manila.\")"},{"line_number":155,"context_line":"        share_size, location \u003d self.plugin.manage_existing(share,"},{"line_number":156,"context_line":"                                                           driver_options)"},{"line_number":157,"context_line":"        return {\u0027size\u0027: share_size, \u0027export_locations\u0027: location}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _update_share_stats(self):"},{"line_number":160,"context_line":"        \"\"\"Retrieve status info from share group.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_8eb8522c","line":157,"in_reply_to":"3a50d1a3_02397c41","updated":"2015-07-25 03:38:50.000000000","message":"Done","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f4a7512c402ac90baf669d78abedbbe5878658af","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Executes commands relating to Shares."},{"line_number":46,"context_line":"    API version history:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        1.0 - Initial version."},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_1f6980be","line":47,"updated":"2015-07-27 11:19:20.000000000","message":"update of version? Same as here -https://review.openstack.org/#/c/197410/12/manila/share/drivers/huawei/huawei_nas.py","commit_id":"31085511ae3866b8b63d543ad45439007c425499"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0bb4fbee8635b9a4307e0d9ea94b82987e9321da","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Executes commands relating to Shares."},{"line_number":46,"context_line":"    API version history:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        1.0 - Initial version."},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_c2d6df26","line":47,"in_reply_to":"3a50d1a3_1f6980be","updated":"2015-07-27 11:48:47.000000000","message":"Done","commit_id":"31085511ae3866b8b63d543ad45439007c425499"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5948a8df63cfe1bdd56f35573e6634b70903aa39","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        1.0 - Initial version."},{"line_number":49,"context_line":"        1.1 - Add shrink share"},{"line_number":50,"context_line":"              Add manage share."},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_f92cbead","line":50,"updated":"2015-07-28 09:58:27.000000000","message":"1.2 ?","commit_id":"41954b418215d7b34db7528bf9e806499968ca1c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"843e24fd8c0da522fa47b91966cd390600d3f92c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        1.0 - Initial version."},{"line_number":49,"context_line":"        1.1 - Add shrink share"},{"line_number":50,"context_line":"              Add manage share."},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_94ad3f9d","line":50,"in_reply_to":"3a50d1a3_f92cbead","updated":"2015-07-28 10:05:37.000000000","message":"Done","commit_id":"41954b418215d7b34db7528bf9e806499968ca1c"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c7927079bb9e777f91537c09242e4d4773094966","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        fs_id \u003d share[\u0027FSID\u0027]"},{"line_number":361,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"},{"line_number":362,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":363,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":364,"context_line":"            raise exception.InvalidShare("},{"line_number":365,"context_line":"                reason\u003d(_(\u0027Invalid status of filesystem: %(health)s \u0027"},{"line_number":366,"context_line":"                          \u0027%(running)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_67758f96","line":363,"updated":"2015-07-14 12:19:02.000000000","message":"According to unit tests looks like this part of code (362-368) is not covered by unit tests.","commit_id":"f75ba52b9945ef40a6200443688b37811c29a6ca"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"19d79692e8f4a4ba70e457febf67a6c4336451ea","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        fs_id \u003d share[\u0027FSID\u0027]"},{"line_number":361,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"},{"line_number":362,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":363,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":364,"context_line":"            raise exception.InvalidShare("},{"line_number":365,"context_line":"                reason\u003d(_(\u0027Invalid status of filesystem: %(health)s \u0027"},{"line_number":366,"context_line":"                          \u0027%(running)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_27422711","line":363,"in_reply_to":"9a41bdd9_67758f96","updated":"2015-07-14 12:21:37.000000000","message":"Thank you for remind me, I will do.","commit_id":"f75ba52b9945ef40a6200443688b37811c29a6ca"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c7927079bb9e777f91537c09242e4d4773094966","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                           \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]}))"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        if pool_name and pool_name !\u003d fs[\u0027POOLNAME\u0027]:"},{"line_number":371,"context_line":"            raise exception.InvalidHost("},{"line_number":372,"context_line":"                reason\u003d(_(\u0027The current pool(%(fs_pool)s) of filesystem \u0027"},{"line_number":373,"context_line":"                          \u0027does not match the input pool(%(host_pool)s).\u0027)"},{"line_number":374,"context_line":"                        % {\u0027fs_pool\u0027: fs[\u0027POOLNAME\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_276f87c6","line":371,"updated":"2015-07-14 12:19:02.000000000","message":"Same here.","commit_id":"f75ba52b9945ef40a6200443688b37811c29a6ca"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"19d79692e8f4a4ba70e457febf67a6c4336451ea","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                           \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]}))"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        if pool_name and pool_name !\u003d fs[\u0027POOLNAME\u0027]:"},{"line_number":371,"context_line":"            raise exception.InvalidHost("},{"line_number":372,"context_line":"                reason\u003d(_(\u0027The current pool(%(fs_pool)s) of filesystem \u0027"},{"line_number":373,"context_line":"                          \u0027does not match the input pool(%(host_pool)s).\u0027)"},{"line_number":374,"context_line":"                        % {\u0027fs_pool\u0027: fs[\u0027POOLNAME\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_a75637d0","line":371,"in_reply_to":"9a41bdd9_276f87c6","updated":"2015-07-14 12:21:37.000000000","message":"I will do.","commit_id":"f75ba52b9945ef40a6200443688b37811c29a6ca"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"cc811dbe9f3139a2e26446deb9d86bd32e9ed66a","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":433,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        share \u003d self.helper._get_share_by_name(old_export_location,"},{"line_number":436,"context_line":"                                               share_url_type)"},{"line_number":437,"context_line":"        if not share:"},{"line_number":438,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_79307956","line":435,"updated":"2015-07-29 06:32:27.000000000","message":"should drop \"LogicalPortIP\" from \"old_export_location\"","commit_id":"4319cf3f12294d780159ff461c14ead8ba01bded"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6f4ceaed5a443ff29e3b4736344c5c5e221db3b0","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":433,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        share \u003d self.helper._get_share_by_name(old_export_location,"},{"line_number":436,"context_line":"                                               share_url_type)"},{"line_number":437,"context_line":"        if not share:"},{"line_number":438,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_eaad8931","line":435,"in_reply_to":"3a50d1a3_79307956","updated":"2015-07-29 08:12:58.000000000","message":"Done","commit_id":"4319cf3f12294d780159ff461c14ead8ba01bded"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"2a9056d75306f5096c85cc94448b8193c93ecf57","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                           \u0027host_pool\u0027: pool_name}))"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self.helper._change_fs_name(fs_id, share_name)"},{"line_number":461,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        location \u003d self._get_location_path(share_name, share_proto)"},{"line_number":464,"context_line":"        return (share_size, [location])"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_c66f8fc2","line":461,"updated":"2015-07-28 14:57:04.000000000","message":"what\u0027s mean \u00272\u0027?","commit_id":"4319cf3f12294d780159ff461c14ead8ba01bded"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e161b103981b8071657048005b923fe74df20fec","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                           \u0027host_pool\u0027: pool_name}))"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self.helper._change_fs_name(fs_id, share_name)"},{"line_number":461,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        location \u003d self._get_location_path(share_name, share_proto)"},{"line_number":464,"context_line":"        return (share_size, [location])"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_3993db5c","line":461,"in_reply_to":"3a50d1a3_c66f8fc2","updated":"2015-07-29 01:05:53.000000000","message":"Because the unit is in sectors. Please see line 132.","commit_id":"4319cf3f12294d780159ff461c14ead8ba01bded"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"fcc05d0f8c4992d3baf7dd8e52e7c9d33eb04751","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            common_constants.ExtraSpecs.DRIVER_HANDLES_SHARE_SERVERS)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        if strutils.bool_from_string(driver_mode):"},{"line_number":442,"context_line":"            msg \u003d _(\"%(mode)s !\u003d False\") % {"},{"line_number":443,"context_line":"                \u0027mode\u0027:"},{"line_number":444,"context_line":"                common_constants.ExtraSpecs.DRIVER_HANDLES_SHARE_SERVERS"},{"line_number":445,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_44add4e7","line":442,"updated":"2015-08-03 07:59:19.000000000","message":"(1) keep \"\" or \u0027\u0027 consistent.\n(2) Missing . at EOL.","commit_id":"f89676963dc9f08004699eacb19a34a932fde3c2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ee7a3d9093712f66232c4912d7b86ddde9749ba3","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            common_constants.ExtraSpecs.DRIVER_HANDLES_SHARE_SERVERS)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        if strutils.bool_from_string(driver_mode):"},{"line_number":442,"context_line":"            msg \u003d _(\"%(mode)s !\u003d False\") % {"},{"line_number":443,"context_line":"                \u0027mode\u0027:"},{"line_number":444,"context_line":"                common_constants.ExtraSpecs.DRIVER_HANDLES_SHARE_SERVERS"},{"line_number":445,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_523d928c","line":442,"in_reply_to":"3a50d1a3_44add4e7","updated":"2015-08-03 08:49:37.000000000","message":"Please see line 78: \nhttps://review.openstack.org/#/c/188365/22/cinder/volume/drivers/huawei/huawei_driver.py","commit_id":"f89676963dc9f08004699eacb19a34a932fde3c2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5556312d033e526b4b02b003bb8f41e2427d3e57","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            common_constants.ExtraSpecs.DRIVER_HANDLES_SHARE_SERVERS)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        if strutils.bool_from_string(driver_mode):"},{"line_number":442,"context_line":"            msg \u003d _(\"%(mode)s !\u003d False\") % {"},{"line_number":443,"context_line":"                \u0027mode\u0027:"},{"line_number":444,"context_line":"                common_constants.ExtraSpecs.DRIVER_HANDLES_SHARE_SERVERS"},{"line_number":445,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_87b19ee2","line":442,"in_reply_to":"3a50d1a3_44add4e7","updated":"2015-08-03 08:30:26.000000000","message":"With the use of LOG.exception this is correct add it is.","commit_id":"f89676963dc9f08004699eacb19a34a932fde3c2"}],"manila/share/drivers/huawei/v3/helper.py":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"873e5868b1c727571e7de4b38f66446c3bdc1544","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        data \u003d jsonutils.dumps(fs_param)"},{"line_number":643,"context_line":"        result \u003d self.call(url, data, \"PUT\")"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        msg \u003d \"Change filesystem name error!\""},{"line_number":646,"context_line":"        self._assert_rest_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a50d1a3_8fe30934","line":645,"updated":"2015-08-02 09:31:22.000000000","message":"missing _()","commit_id":"58a607437de7d07e89b14a984c40e2058ed730af"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a2c6f0b0e9e1b02ae37a633358ae4eaf8a6dfed7","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        data \u003d jsonutils.dumps(fs_param)"},{"line_number":643,"context_line":"        result \u003d self.call(url, data, \"PUT\")"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        msg \u003d \"Change filesystem name error!\""},{"line_number":646,"context_line":"        self._assert_rest_result(result, msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a50d1a3_e72d0990","line":645,"in_reply_to":"3a50d1a3_8fe30934","updated":"2015-08-03 03:51:31.000000000","message":"Done","commit_id":"58a607437de7d07e89b14a984c40e2058ed730af"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"94d4889c2bb89c4521d7043f6300138c91e35d26","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        if share_name is None:"},{"line_number":613,"context_line":"            raise exception.InvalidInput("},{"line_number":614,"context_line":"                reason\u003d(_(\u0027The export location path(%s) is fail.\u0027)"},{"line_number":615,"context_line":"                        % export_location))"},{"line_number":616,"context_line":"        return share_name"},{"line_number":617,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_9f8dd733","line":614,"updated":"2015-08-04 03:14:57.000000000","message":"This isn\u0027t valid English.  How about something like...\n\n\u0027No share with export location %s could be found.\"","commit_id":"9d78c850e2e24998fd6058566196b874f3045ca7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9b97362c89d86e3e45961170fe358f5d185952d3","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        if share_name is None:"},{"line_number":613,"context_line":"            raise exception.InvalidInput("},{"line_number":614,"context_line":"                reason\u003d(_(\u0027The export location path(%s) is fail.\u0027)"},{"line_number":615,"context_line":"                        % export_location))"},{"line_number":616,"context_line":"        return share_name"},{"line_number":617,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_ff02db3d","line":614,"in_reply_to":"1a4dcd0f_9f8dd733","updated":"2015-08-04 07:40:23.000000000","message":"Done","commit_id":"9d78c850e2e24998fd6058566196b874f3045ca7"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eb0943dc1b435a97bcfb0a844e2c3fbf20631149","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                          self.driver.delete_snapshot, self._context,"},{"line_number":1096,"context_line":"                          self.cifs_snapshot, self.share_server)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def test_manage_share_nfs_success(self):"},{"line_number":1099,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1100,"context_line":"        share_info \u003d self.driver.manage_existing(self.share_manage_nfs,"},{"line_number":1101,"context_line":"                                                 self.driver_options)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a2c9a85c","line":1098,"updated":"2015-07-24 06:53:29.000000000","message":"This","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"03552c5a0dae00d9a39ff10f28ccd7fd26632639","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                          self.driver.delete_snapshot, self._context,"},{"line_number":1096,"context_line":"                          self.cifs_snapshot, self.share_server)"},{"line_number":1097,"context_line":""},{"line_number":1098,"context_line":"    def test_manage_share_nfs_success(self):"},{"line_number":1099,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1100,"context_line":"        share_info \u003d self.driver.manage_existing(self.share_manage_nfs,"},{"line_number":1101,"context_line":"                                                 self.driver_options)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_5d03b7b8","line":1098,"in_reply_to":"3a50d1a3_a2c9a85c","updated":"2015-07-25 03:38:50.000000000","message":"Done","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eb0943dc1b435a97bcfb0a844e2c3fbf20631149","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"        self.assertEqual(\"100.115.10.68:/share_fake_manage_uuid\","},{"line_number":1104,"context_line":"                         share_info[\"export_locations\"])"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    def test_manage_share_cifs_success(self):"},{"line_number":1107,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1108,"context_line":"        share_info \u003d self.driver.manage_existing(self.share_manage_cifs,"},{"line_number":1109,"context_line":"                                                 self.driver_options)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_a2d0c8f8","line":1106,"updated":"2015-07-24 06:53:29.000000000","message":"And this tests should be combined using lib \"ddt\" to avoid code duplication.","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"03552c5a0dae00d9a39ff10f28ccd7fd26632639","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"        self.assertEqual(\"100.115.10.68:/share_fake_manage_uuid\","},{"line_number":1104,"context_line":"                         share_info[\"export_locations\"])"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    def test_manage_share_cifs_success(self):"},{"line_number":1107,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1108,"context_line":"        share_info \u003d self.driver.manage_existing(self.share_manage_cifs,"},{"line_number":1109,"context_line":"                                                 self.driver_options)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_7dfeb3af","line":1106,"in_reply_to":"3a50d1a3_a2d0c8f8","updated":"2015-07-25 03:38:50.000000000","message":"Done","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eb0943dc1b435a97bcfb0a844e2c3fbf20631149","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        self.assertEqual(\"\\\\\\\\100.115.10.68\\\\share_fake_manage_uuid\","},{"line_number":1112,"context_line":"                         share_info[\"export_locations\"])"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def test_manage_share_not_exist(self):"},{"line_number":1115,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1116,"context_line":"        self.driver.plugin.helper.share_exist \u003d False"},{"line_number":1117,"context_line":"        self.assertRaises(exception.InvalidShare,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_4208e491","line":1114,"updated":"2015-07-24 06:53:29.000000000","message":"Also, this and following two can be combined using \"ddt\" lib too.","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"03552c5a0dae00d9a39ff10f28ccd7fd26632639","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        self.assertEqual(\"\\\\\\\\100.115.10.68\\\\share_fake_manage_uuid\","},{"line_number":1112,"context_line":"                         share_info[\"export_locations\"])"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"    def test_manage_share_not_exist(self):"},{"line_number":1115,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1116,"context_line":"        self.driver.plugin.helper.share_exist \u003d False"},{"line_number":1117,"context_line":"        self.assertRaises(exception.InvalidShare,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_1d2c4f49","line":1114,"in_reply_to":"3a50d1a3_4208e491","updated":"2015-07-25 03:38:50.000000000","message":"Done","commit_id":"1589fa129c81bd8b78645c3ed25700dc27c49921"}]}