)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"0fb14a713409906d2fd00c310df23e914b2ee80c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This ports all existing Manila Tempest test to the new structure."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It uses manila_tempest_tests as new top folder for all Tempest"},{"line_number":16,"context_line":"tests. It follow the model of Heat (see [1])."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://github.com/openstack/heat/tree/master/heat_integrationtests"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a4dcd0f_167af2f1","line":16,"updated":"2015-08-04 14:03:48.000000000","message":"S/follow/follows","commit_id":"136920b422b5c4022ed1ae72a84b64cf7ab40c97"}],"manila_integrationtests/config_share.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75d3452ec865f4c6b46483f1e337a2987b438cdc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"]"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class TempestConfigProxyManila(object):"},{"line_number":137,"context_line":"    \"\"\"Wrapper over standard Tempest config that sets Manila opts.\"\"\""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_dd535a6b","line":136,"updated":"2015-07-17 08:54:07.000000000","message":"It is expected that \"plugin\" does not require this \"workaround\".","commit_id":"58d7c1ada1ca8d7cec11935701bf97829357d0b7"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"de7dac6d7a809bc69c2da9ffe59a2bb7dc1c8172","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila_tempest_tests import config_share"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ManilaTempestPlugin(plugins.TempestPlugin):"},{"line_number":26,"context_line":"    def load_tests(self):"},{"line_number":27,"context_line":"        base_path \u003d os.path.split(os.path.dirname("}],"source_content_type":"text/x-python","patch_set":15,"id":"da20952f_569f1303","line":24,"updated":"2015-08-27 15:37:43.000000000","message":"Why this module is separated from \"config_share\"? I think, the latter should be included here. Making Manila Tempest tests as real plugin - there is no need anymore to have separate module, because we do not do workarounds for Tempest\u0027s config file.","commit_id":"21089a84607085cd2c260ec085ae4471066fffa6"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a0f07c75d5ab37bb892353d7bf0a408d7231d93e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila_tempest_tests import config_share"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ManilaTempestPlugin(plugins.TempestPlugin):"},{"line_number":26,"context_line":"    def load_tests(self):"},{"line_number":27,"context_line":"        base_path \u003d os.path.split(os.path.dirname("}],"source_content_type":"text/x-python","patch_set":15,"id":"da20952f_60f6e8d8","line":24,"in_reply_to":"da20952f_569f1303","updated":"2015-08-28 06:24:24.000000000","message":"Yep according to [1] the file must be renamed from config.py to plugin.py. And config_share.py will be renamend to config.py. So I will do this to make it clearer.\n\n[1]: http://docs.openstack.org/developer/tempest/plugin.html","commit_id":"21089a84607085cd2c260ec085ae4471066fffa6"}],"manila_tempest_tests/config_share.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a93c484c7459be7c69a3560db8bd902403a526d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3a50d1a3_44e00d26","side":"PARENT","line":116,"updated":"2015-07-29 19:55:23.000000000","message":"I guess it is mistakenly removed because of improper rebase.","commit_id":"c0c073316d77acb33a3a7f931e84cd1aa217d2df"}],"manila_tempest_tests/plugin.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"261a395a7c6a58b1256372f3d8313be08a3a4e26","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                  config_share.ShareGroup)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_opt_lists(self):"},{"line_number":41,"context_line":"        return [(config_share.share_group, config_share.ShareGroup)]"}],"source_content_type":"text/x-python","patch_set":17,"id":"da20952f_c67a6cf1","line":41,"updated":"2015-08-28 07:22:17.000000000","message":"According the documentation of get_opt_lists(), the returned value should be: :return option_list: A list of tuples with the group name and options in that group.\n\nBut share_group is an OptGroup.","commit_id":"698072e1f0a0237d215045c9737fc9d40918edc0"}],"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad0bc79edc7910cdf9bd3e065860f2e96cfcafd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3a50d1a3_043c4591","side":"PARENT","line":163,"updated":"2015-07-29 19:56:20.000000000","message":"Same here.","commit_id":"c0c073316d77acb33a3a7f931e84cd1aa217d2df"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad0bc79edc7910cdf9bd3e065860f2e96cfcafd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3a50d1a3_644d093d","side":"PARENT","line":378,"updated":"2015-07-29 19:56:20.000000000","message":"and here.","commit_id":"c0c073316d77acb33a3a7f931e84cd1aa217d2df"}],"manila_tempest_tests/tests/api/admin/test_quotas_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"de7dac6d7a809bc69c2da9ffe59a2bb7dc1c8172","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config  # noqa"},{"line_number":17,"context_line":"from tempest import test  # noqa"},{"line_number":18,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"},{"line_number":19,"context_line":"import testtools  # noqa"}],"source_content_type":"text/x-python","patch_set":15,"id":"da20952f_d1624dd8","line":16,"updated":"2015-08-27 15:37:43.000000000","message":"Do we still need \" noqa\"?","commit_id":"21089a84607085cd2c260ec085ae4471066fffa6"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a0f07c75d5ab37bb892353d7bf0a408d7231d93e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config  # noqa"},{"line_number":17,"context_line":"from tempest import test  # noqa"},{"line_number":18,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"},{"line_number":19,"context_line":"import testtools  # noqa"}],"source_content_type":"text/x-python","patch_set":15,"id":"da20952f_e0be78d3","line":16,"in_reply_to":"da20952f_d1624dd8","updated":"2015-08-28 06:24:24.000000000","message":"Mh I kept the noqa for tempest only since Tempest is not mandatory to install on an environment and the pep8 checks should work. But I never tested it to be honest...","commit_id":"21089a84607085cd2c260ec085ae4471066fffa6"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"37a46961ce0780a1339a35b768e20d43724bf950","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"from tempest.common import isolated_creds  # noqa"},{"line_number":24,"context_line":"from tempest import config  # noqa"},{"line_number":25,"context_line":"from tempest import exceptions  # noqa"},{"line_number":26,"context_line":"from tempest import test  # noqa"},{"line_number":27,"context_line":"from tempest_lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_64fbc9c1","line":24,"updated":"2015-07-29 19:57:08.000000000","message":"Are these \"noqa\" still required?","commit_id":"3636e0b0c19ebab0c6e259b92367dbaa005f3278"}]}
