)]}'
{"manila/share/drivers/quobyte/jsonrpc.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cb41ea92ebc96d0b473994f2cd46eb580c94a8af","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                     \u0027params\u0027: parameters,"},{"line_number":118,"context_line":"                     \u0027id\u0027: six.text_type(self._id)}"},{"line_number":119,"context_line":"        self.call_counter \u003d 0"},{"line_number":120,"context_line":"        self._connection.connect()  # prevents httplib timing issue"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        while self.call_counter \u003c CONNECTION_RETRIES:"},{"line_number":123,"context_line":"            self.call_counter +\u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_757346b2","line":120,"updated":"2015-07-20 13:56:51.000000000","message":"Please, cover it with unit tests.","commit_id":"7b2c5a84eb50d00fe9dc542880cc11f2ab719142"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"65be24668089b43e173baa3cf288fcc9265657d3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                     \u0027params\u0027: parameters,"},{"line_number":118,"context_line":"                     \u0027id\u0027: six.text_type(self._id)}"},{"line_number":119,"context_line":"        self.call_counter \u003d 0"},{"line_number":120,"context_line":"        self._connection.connect()  # prevents httplib timing issue"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        while self.call_counter \u003c CONNECTION_RETRIES:"},{"line_number":123,"context_line":"            self.call_counter +\u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_d205507a","line":120,"in_reply_to":"3a50d1a3_757346b2","updated":"2015-07-21 13:39:53.000000000","message":"Done","commit_id":"7b2c5a84eb50d00fe9dc542880cc11f2ab719142"}],"manila/tests/share/drivers/quobyte/test_jsonrpc.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c7b2397b5786b79c105b4d4c7e6ab21b4d9ae83f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                          self.rpc.call,"},{"line_number":185,"context_line":"                          \u0027method\u0027, {\u0027param\u0027: \u0027value\u0027})"},{"line_number":186,"context_line":"        httplib.HTTPSConnection.assert_called_once_with(self.rpc._netloc)"},{"line_number":187,"context_line":"        assert (self.rpc._disabled_cert_verification is True,"},{"line_number":188,"context_line":"                \u0027Cert verify should be off\u0027)"},{"line_number":189,"context_line":"        jsonrpc.LOG.warning.assert_called_once_with("},{"line_number":190,"context_line":"            \"Could not verify server certificate of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_65df55d6","line":187,"updated":"2015-07-23 13:44:10.000000000","message":"This is always True. \"parentheses\" should be removed.\n\nBUT, it is incorrect assertion in general.\n\nShould be used following:\n\n\"\"\"\n\nself.assertTrue(self.rpc._disabled_cert_verification)\n\n\"\"\"","commit_id":"50b15ba9910b0066a479364a5d739f2eab327eaa"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"9348e32b98ab11b2b9f9b46f09309a763ac7d861","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                          self.rpc.call,"},{"line_number":185,"context_line":"                          \u0027method\u0027, {\u0027param\u0027: \u0027value\u0027})"},{"line_number":186,"context_line":"        httplib.HTTPSConnection.assert_called_once_with(self.rpc._netloc)"},{"line_number":187,"context_line":"        assert (self.rpc._disabled_cert_verification is True,"},{"line_number":188,"context_line":"                \u0027Cert verify should be off\u0027)"},{"line_number":189,"context_line":"        jsonrpc.LOG.warning.assert_called_once_with("},{"line_number":190,"context_line":"            \"Could not verify server certificate of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_9e23ce55","line":187,"in_reply_to":"3a50d1a3_65df55d6","updated":"2015-07-23 14:20:34.000000000","message":"Done","commit_id":"50b15ba9910b0066a479364a5d739f2eab327eaa"}]}
