)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"78f738023126b2ec84b4063e7c0cb1c15a044cc6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Update db schema and create db migration"},{"line_number":14,"context_line":"- Update appropriate unit tests"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially implements bp availability-zones"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iea9fbc3fea5c0128772115c028989121f397e0c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_85b2f394","line":16,"updated":"2015-08-03 10:59:27.000000000","message":"S/Partially implements/Partially implements:  ?\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"51db679c899e62ff3dbc8cfde9d528a593323c9c"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"aae47f7a7bfeffe3c0d15efab159a977b7531d82","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Update db schema and create db migration"},{"line_number":14,"context_line":"- Update appropriate unit tests"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially implements bp availability-zones"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iea9fbc3fea5c0128772115c028989121f397e0c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_84228cb8","line":16,"updated":"2015-08-03 14:32:08.000000000","message":"Please add the APIImpact flag :)","commit_id":"8abb96638d9c80f733b8704d78e9da37acc6b26a"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"7cab7b5a8ecfb3e5ea7ce2700a48ed5b800f1cc7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Update db schema and create db migration"},{"line_number":14,"context_line":"- Update appropriate unit tests"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially implements bp availability-zones"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iea9fbc3fea5c0128772115c028989121f397e0c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_c040c936","line":16,"in_reply_to":"1a4dcd0f_84228cb8","updated":"2015-08-06 13:25:07.000000000","message":"Done","commit_id":"8abb96638d9c80f733b8704d78e9da37acc6b26a"}],"manila/api/contrib/availability_zones.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"11977c196f4b0fa076bcb42d43f018fde09400c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"authorize \u003d extensions.extension_authorizer(\u0027share\u0027, \u0027availability_zones\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class Controller(wsgi.Controller):"},{"line_number":24,"context_line":"    def index(self, req):"},{"line_number":25,"context_line":"        \"\"\"Describe all known availability zones.\"\"\""},{"line_number":26,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_df2a492f","line":23,"updated":"2015-08-15 20:56:26.000000000","message":"Any reason this is an extension and not core API? Esp if the generic driver will support it.","commit_id":"08d2e326328582c9336d29fdbd7479a5ea5c34ee"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"43bac9cb2ef16b96bf86792661f88d614f317add","unresolved":false,"context_lines":[{"line_number":20,"context_line":"authorize \u003d extensions.extension_authorizer(\u0027share\u0027, \u0027availability_zones\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class Controller(wsgi.Controller):"},{"line_number":24,"context_line":"    def index(self, req):"},{"line_number":25,"context_line":"        \"\"\"Describe all known availability zones.\"\"\""},{"line_number":26,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_8c59ef90","line":23,"in_reply_to":"1a4dcd0f_df2a492f","updated":"2015-08-17 16:27:34.000000000","message":"It\u0027s new feature and administrator should be able to disable it.","commit_id":"08d2e326328582c9336d29fdbd7479a5ea5c34ee"}],"manila/api/v1/shares.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"11977c196f4b0fa076bcb42d43f018fde09400c6","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if availability_zone:"},{"line_number":195,"context_line":"            try:"},{"line_number":196,"context_line":"                db.availability_zone_get(context, availability_zone)"},{"line_number":197,"context_line":"            except exception.AvailabilityZoneNotFound as e:"},{"line_number":198,"context_line":"                raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_bf273d62","line":196,"updated":"2015-08-15 20:56:26.000000000","message":"These checks are usually in the share/api.py layer (for some reason). This should probably be consistent with that.","commit_id":"08d2e326328582c9336d29fdbd7479a5ea5c34ee"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"48122a1daa761762299dd34f02a08633a6216a3f","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        if availability_zone:"},{"line_number":195,"context_line":"            try:"},{"line_number":196,"context_line":"                db.availability_zone_get(context, availability_zone)"},{"line_number":197,"context_line":"            except exception.AvailabilityZoneNotFound as e:"},{"line_number":198,"context_line":"                raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_ce5bb553","line":196,"in_reply_to":"1a4dcd0f_bf273d62","updated":"2015-08-17 16:39:04.000000000","message":"As you can see in this controller snapshot and share are checked and passed to Share API in the same way - existence is checked in controller.","commit_id":"08d2e326328582c9336d29fdbd7479a5ea5c34ee"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"973efc9c14a79e80f0c341348bc48b779712cd2d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        share \u003d self.share_api.update(context, share, update_dict)"},{"line_number":162,"context_line":"        share.update(update_dict)"},{"line_number":163,"context_line":"        return self._view_builder.detail(req, share)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create(self, req, body):"},{"line_number":166,"context_line":"        \"\"\"Creates a new share.\"\"\""},{"line_number":167,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_109bc3ca","line":164,"updated":"2015-08-24 21:16:30.000000000","message":"Microversion bump needed here.","commit_id":"f9278cb39aa2caff29aacf987d226ed8bb7b866b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"65baae319d44234fbb7d7cbdb49f3a58c83d87c4","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        share \u003d self.share_api.update(context, share, update_dict)"},{"line_number":162,"context_line":"        share.update(update_dict)"},{"line_number":163,"context_line":"        return self._view_builder.detail(req, share)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def create(self, req, body):"},{"line_number":166,"context_line":"        \"\"\"Creates a new share.\"\"\""},{"line_number":167,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_f3d15dfc","line":164,"in_reply_to":"fa1b9901_109bc3ca","updated":"2015-08-25 11:41:43.000000000","message":"I disagree. Only internal behaviour was changed, no user-facing changes. \u0027availability_zone\u0027 field is supported since v1 API.","commit_id":"f9278cb39aa2caff29aacf987d226ed8bb7b866b"}],"manila/db/migrations/alembic/versions/1f0bd302c1a6_add_availability_zones_table.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8a4ebcc5e3b08b38f1e7ce7c95a141aebbdf2db7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":58,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"},{"line_number":59,"context_line":"        Column(\u0027deleted_at\u0027, DateTime),"},{"line_number":60,"context_line":"        Column(\u0027deleted\u0027, String(length\u003d36), default\u003d\u0027False\u0027),"},{"line_number":61,"context_line":"        Column(\u0027id\u0027, String(length\u003d36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":62,"context_line":"        Column(\u0027name\u0027, String(length\u003d255)),"},{"line_number":63,"context_line":"        UniqueConstraint(\u0027name\u0027, \u0027deleted\u0027, name\u003d\u0027az_name_uc\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa1b9901_963d0b91","line":60,"updated":"2015-08-21 04:45:00.000000000","message":"deleted is usually an int","commit_id":"ee27fc9087d7cb5a8625dbffda21a9584401560e"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"66461142dbb711764411f3223b66ce43426a623f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        Column(\u0027created_at\u0027, DateTime),"},{"line_number":58,"context_line":"        Column(\u0027updated_at\u0027, DateTime),"},{"line_number":59,"context_line":"        Column(\u0027deleted_at\u0027, DateTime),"},{"line_number":60,"context_line":"        Column(\u0027deleted\u0027, String(length\u003d36), default\u003d\u0027False\u0027),"},{"line_number":61,"context_line":"        Column(\u0027id\u0027, String(length\u003d36), primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":62,"context_line":"        Column(\u0027name\u0027, String(length\u003d255)),"},{"line_number":63,"context_line":"        UniqueConstraint(\u0027name\u0027, \u0027deleted\u0027, name\u003d\u0027az_name_uc\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa1b9901_f7555ef9","line":60,"in_reply_to":"fa1b9901_963d0b91","updated":"2015-08-21 08:05:27.000000000","message":"Type of \u0027deleted\u0027 equals type of \u0027id\u0027 always :)","commit_id":"ee27fc9087d7cb5a8625dbffda21a9584401560e"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"973efc9c14a79e80f0c341348bc48b779712cd2d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":65,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    az_column \u003d lambda fk_id: ("},{"line_number":68,"context_line":"        Column(\u0027availability_zone_id\u0027, String(36),"},{"line_number":69,"context_line":"               ForeignKey(\u0027availability_zones.id\u0027, name\u003d\"%s_az_id_fk\" % fk_id))"},{"line_number":70,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_3098471b","line":67,"updated":"2015-08-24 21:16:30.000000000","message":"I find these 6 lines difficult to read. Why can\u0027t we use simpler more straighforward code?\n\n op.add_column(\u0027services\u0027,\n               Column(\u0027availability_zone_id\u0027, String(36),\n                      ForeignKey(\u0027availability_zones.id\u0027, name\u003d\"service_az_id_fk\")))\n op.add_column(\u0027share_instances\u0027,\n               Column(\u0027availability_zone_id\u0027, String(36),\n                      ForeignKey(\u0027availability_zones.id\u0027, name\u003d\"si_az_id_fk\")))","commit_id":"f9278cb39aa2caff29aacf987d226ed8bb7b866b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"65baae319d44234fbb7d7cbdb49f3a58c83d87c4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":65,"context_line":"        mysql_charset\u003d\u0027utf8\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    az_column \u003d lambda fk_id: ("},{"line_number":68,"context_line":"        Column(\u0027availability_zone_id\u0027, String(36),"},{"line_number":69,"context_line":"               ForeignKey(\u0027availability_zones.id\u0027, name\u003d\"%s_az_id_fk\" % fk_id))"},{"line_number":70,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_f3895dcb","line":67,"in_reply_to":"fa1b9901_3098471b","updated":"2015-08-25 11:41:43.000000000","message":"Done","commit_id":"f9278cb39aa2caff29aacf987d226ed8bb7b866b"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"973efc9c14a79e80f0c341348bc48b779712cd2d","unresolved":false,"context_lines":[{"line_number":2900,"context_line":"    az \u003d models.AvailabilityZone()"},{"line_number":2901,"context_line":"    az.update({\u0027id\u0027: uuidutils.generate_uuid(), \u0027name\u0027: name})"},{"line_number":2902,"context_line":"    try:"},{"line_number":2903,"context_line":"        with session.begin():"},{"line_number":2904,"context_line":"            az.save(session)"},{"line_number":2905,"context_line":"    # NOTE(u_glide): Do not catch specific exception here, because it depends"},{"line_number":2906,"context_line":"    # on concrete backend used by SqlAlchemy"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_7018ff75","line":2903,"updated":"2015-08-24 21:16:30.000000000","message":"How will this code prevent a race condition between 2 services creating 2 AZs with the same name?","commit_id":"f9278cb39aa2caff29aacf987d226ed8bb7b866b"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"65baae319d44234fbb7d7cbdb49f3a58c83d87c4","unresolved":false,"context_lines":[{"line_number":2900,"context_line":"    az \u003d models.AvailabilityZone()"},{"line_number":2901,"context_line":"    az.update({\u0027id\u0027: uuidutils.generate_uuid(), \u0027name\u0027: name})"},{"line_number":2902,"context_line":"    try:"},{"line_number":2903,"context_line":"        with session.begin():"},{"line_number":2904,"context_line":"            az.save(session)"},{"line_number":2905,"context_line":"    # NOTE(u_glide): Do not catch specific exception here, because it depends"},{"line_number":2906,"context_line":"    # on concrete backend used by SqlAlchemy"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa1b9901_560cb73a","line":2903,"in_reply_to":"fa1b9901_7018ff75","updated":"2015-08-25 11:41:43.000000000","message":"The first request will create AZ and the second one will fail with an exception on line 2904 and will return AZ created by the first request.","commit_id":"f9278cb39aa2caff29aacf987d226ed8bb7b866b"}]}
