)]}'
{"manila/network/neutron/neutron_network_plugin.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"21f4fa6c55405c9985334db6da1b007874a0abf8","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def neutron_api(self):"},{"line_number":59,"context_line":"        if not self._neutron_api:"},{"line_number":60,"context_line":"            self._neutron_api \u003d neutron_api.API(*self._neutron_api_args,"},{"line_number":61,"context_line":"                                                **self._neutron_api_kwargs)"},{"line_number":62,"context_line":"        return self._neutron_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_fce34ea2","line":59,"updated":"2015-08-05 22:39:07.000000000","message":"I see a race condition here. It\u0027s not clear if there\u0027s any locking from the @property decorator. Is it okay for multiple API objects to get instantiated or is this property protected by some other mechanism that ensures single-threaded access?","commit_id":"eec4d28c47d97ba270d6f90731ebd534a4545c25"},{"author":{"_account_id":13084,"name":"Ryan Hefner","email":"rhefner1@gmail.com","username":"rhefner"},"change_message_id":"3badb21059c554146fd1f3adb87f90d3e112c62e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def neutron_api(self):"},{"line_number":59,"context_line":"        if not self._neutron_api:"},{"line_number":60,"context_line":"            self._neutron_api \u003d neutron_api.API(*self._neutron_api_args,"},{"line_number":61,"context_line":"                                                **self._neutron_api_kwargs)"},{"line_number":62,"context_line":"        return self._neutron_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5371b60a","line":59,"in_reply_to":"1a4dcd0f_6a9bb518","updated":"2015-08-07 14:26:47.000000000","message":"Talked with ameade and he said that this probably isn\u0027t a concern. Even if there is a race condition here and the API is instantiated twice, one of them will win and the other will be garbage collected.  I don\u0027t see a significant downside to implementing it like this.\n\nLet me know if you feel differently.","commit_id":"eec4d28c47d97ba270d6f90731ebd534a4545c25"},{"author":{"_account_id":13084,"name":"Ryan Hefner","email":"rhefner1@gmail.com","username":"rhefner"},"change_message_id":"4c0e6d368c4039df0807578475ca654a94b4e46b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def neutron_api(self):"},{"line_number":59,"context_line":"        if not self._neutron_api:"},{"line_number":60,"context_line":"            self._neutron_api \u003d neutron_api.API(*self._neutron_api_args,"},{"line_number":61,"context_line":"                                                **self._neutron_api_kwargs)"},{"line_number":62,"context_line":"        return self._neutron_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_6a9bb518","line":59,"in_reply_to":"1a4dcd0f_fce34ea2","updated":"2015-08-07 00:14:52.000000000","message":"Agreed that this could be a potential issue. I\u0027m not familiar enough with the Neutron API object to know if multiple instances would pose an issue, but it probably isn\u0027t desired.\n\nTrying to think of a way to get around this. Would the existing locking mechanism we have in Manila be useful in this case?","commit_id":"eec4d28c47d97ba270d6f90731ebd534a4545c25"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"21f4fa6c55405c9985334db6da1b007874a0abf8","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    @property"},{"line_number":659,"context_line":"    def neutron_api(self):"},{"line_number":660,"context_line":"        if not self._neutron_api:"},{"line_number":661,"context_line":"            self._neutron_api \u003d neutron.API("},{"line_number":662,"context_line":"                config_group_name\u003dself._network_config_group)"},{"line_number":663,"context_line":"        return self._neutron_api"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_3c053645","line":660,"updated":"2015-08-05 22:39:07.000000000","message":"same concern about a potential race here","commit_id":"eec4d28c47d97ba270d6f90731ebd534a4545c25"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"0f3c5011bccbc37946c8e29ce62a906dfe797694","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        return net[\u0027name\u0027]"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    @utils.synchronized(\"service_instance_get_service_network\", external\u003dTrue)"},{"line_number":680,"context_line":"    def get_service_network_id(self):"},{"line_number":681,"context_line":"        \"\"\"Finds existing or creates new service network.\"\"\""},{"line_number":682,"context_line":"        service_network_name \u003d self.get_config_option(\"service_network_name\")"},{"line_number":683,"context_line":"        networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_c7b3b199","line":680,"updated":"2015-08-13 19:23:58.000000000","message":"shouldn\u0027t the impl of this method get moved into the new property above? Given that there is a single caller, and it is now locked, it seems like overkill to retain this lock and method below.","commit_id":"548cc1d31699cc630404e30f0cd5aee6d85966b3"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"ca91849a073c8712d2c8856b7f6f97704b4b9f2d","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        return net[\u0027name\u0027]"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    @utils.synchronized(\"service_instance_get_service_network\", external\u003dTrue)"},{"line_number":680,"context_line":"    def get_service_network_id(self):"},{"line_number":681,"context_line":"        \"\"\"Finds existing or creates new service network.\"\"\""},{"line_number":682,"context_line":"        service_network_name \u003d self.get_config_option(\"service_network_name\")"},{"line_number":683,"context_line":"        networks \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_a9c4065f","line":680,"in_reply_to":"1a4dcd0f_c7b3b199","updated":"2015-08-18 15:39:16.000000000","message":"The method should be made private but I see no reason to actually move it.","commit_id":"548cc1d31699cc630404e30f0cd5aee6d85966b3"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"c59237e22b53a9b8a0ada8681973d1694e0dee75","unresolved":false,"context_lines":[{"line_number":668,"context_line":"    @utils.synchronized(\"service_network_id_neutron_net_helper\")"},{"line_number":669,"context_line":"    def service_network_id(self):"},{"line_number":670,"context_line":"        if not self._service_network_id:"},{"line_number":671,"context_line":"            self._service_network_id \u003d self.get_service_network_id()"},{"line_number":672,"context_line":"        return self._service_network_id"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def get_network_name(self, network_info):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ff062584","line":671,"updated":"2015-08-24 18:39:25.000000000","message":"Shouldn\u0027t you change the name here as well?  Same in the unit tests.","commit_id":"4fd2a93642991eb4b71ce46a3f5e9a290cd08723"}]}
