)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"757afde546a81f42b473cab4bfbb894d8dbcb410","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Common capabilities documentation for discussion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A very rough first draft of share type extra-spec/capabilities to"},{"line_number":10,"context_line":"aid in defining common capabilities (and make progress on docs)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2c5bdf5ef9bfd6c8e7e06dac1fde08ad56cc6af1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_ec4e2e6e","line":9,"updated":"2015-08-06 09:04:46.000000000","message":"s/extra-spec/extra-specs","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"}],"doc/source/devref/capabilities_and_extra_specs.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"757afde546a81f42b473cab4bfbb894d8dbcb410","unresolved":false,"context_lines":[{"line_number":41,"context_line":"match a boolean capability the extra-spec value would be \u0027\u003cis\u003e True\u0027."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"For vendor-specific capabilities (which need to be visible to the"},{"line_number":44,"context_line":"CapabilityFilter), it is recommented to use the vendor prefix followed"},{"line_number":45,"context_line":"by an underscore. This is not a strict requirement, but will provide a"},{"line_number":46,"context_line":"consistent look along-side the scoped extra-specs and will be a clear"},{"line_number":47,"context_line":"indicator of vendor capabilties vs. common capabilities."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_f16927fa","line":44,"updated":"2015-08-06 09:04:46.000000000","message":"s/recommented/recommended","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f15417914c3e1e6b64ce42e520a107138af0cdd0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"match a boolean capability the extra-spec value would be \u0027\u003cis\u003e True\u0027."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"For vendor-specific capabilities (which need to be visible to the"},{"line_number":44,"context_line":"CapabilityFilter), it is recommented to use the vendor prefix followed"},{"line_number":45,"context_line":"by an underscore. This is not a strict requirement, but will provide a"},{"line_number":46,"context_line":"consistent look along-side the scoped extra-specs and will be a clear"},{"line_number":47,"context_line":"indicator of vendor capabilties vs. common capabilities."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_6f11945c","line":44,"in_reply_to":"1a4dcd0f_f16927fa","updated":"2015-08-06 18:51:57.000000000","message":"Done","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"757afde546a81f42b473cab4bfbb894d8dbcb410","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CapabilityFilter), it is recommented to use the vendor prefix followed"},{"line_number":45,"context_line":"by an underscore. This is not a strict requirement, but will provide a"},{"line_number":46,"context_line":"consistent look along-side the scoped extra-specs and will be a clear"},{"line_number":47,"context_line":"indicator of vendor capabilties vs. common capabilities."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Common Capabilities"},{"line_number":50,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_f1504734","line":47,"updated":"2015-08-06 09:04:46.000000000","message":"s/capabilties/capabilities","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f15417914c3e1e6b64ce42e520a107138af0cdd0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CapabilityFilter), it is recommented to use the vendor prefix followed"},{"line_number":45,"context_line":"by an underscore. This is not a strict requirement, but will provide a"},{"line_number":46,"context_line":"consistent look along-side the scoped extra-specs and will be a clear"},{"line_number":47,"context_line":"indicator of vendor capabilties vs. common capabilities."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Common Capabilities"},{"line_number":50,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_8f14204d","line":47,"in_reply_to":"1a4dcd0f_f1504734","updated":"2015-08-06 18:51:57.000000000","message":"Done","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"757afde546a81f42b473cab4bfbb894d8dbcb410","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Common Capabilities"},{"line_number":50,"context_line":"-------------------"},{"line_number":51,"context_line":"For capabilities that apply to multiple backends a common capability can"},{"line_number":52,"context_line":"be created. "},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* `driver_handles_share_servers` is a special, required, user-visible common"},{"line_number":55,"context_line":"  capability."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_8c71aa78","line":52,"updated":"2015-08-06 09:04:46.000000000","message":"Suggest to delete redundant space.","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f15417914c3e1e6b64ce42e520a107138af0cdd0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Common Capabilities"},{"line_number":50,"context_line":"-------------------"},{"line_number":51,"context_line":"For capabilities that apply to multiple backends a common capability can"},{"line_number":52,"context_line":"be created. "},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* `driver_handles_share_servers` is a special, required, user-visible common"},{"line_number":55,"context_line":"  capability."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_2f106c56","line":52,"in_reply_to":"1a4dcd0f_8c71aa78","updated":"2015-08-06 18:51:57.000000000","message":"Done","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"338922bfd44342b99b99bfe6018143bc58fc0790","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  thin-provisioned shares.  *TODO* Should we use manila_thin_provisioning?"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* `thick_provisioning_support` indicates that a backend/pool can provide"},{"line_number":61,"context_line":"  fully provisioned shares.  *TODO* Should we use manila_thick_provisioning?"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* `manila_dedup` indicates that a backend/pool can provide shares using some"},{"line_number":64,"context_line":"  deduplication technology.  *TODO* This is proposed -- not agreed upon."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_6c7be27b","line":61,"updated":"2015-08-06 17:20:26.000000000","message":"thin_provisioning - shares will not be space guaranteed and overprovisioning will be enabled\ncapability defaults to False\nextra_spec defaults to None, False is not allowed\n\nthick_provisioning - shares will be space guaranteed and overprovisioning will be prevented\ncapability defaults to True\nextra_spec defaults to None, False is not allowed\n\n\nBackends have 4 options for capability reporting, only 3 of which are valid:\nthin_provisioning\u003dFalse, thick_provisioning\u003dFalse - INVALID, doesn\u0027t make sense\nthin_provisioning\u003dFalse, thick_provisioning\u003dTrue - This is the default, backend only supports thick provisioning\nthin_provisioning\u003dTrue, thick_provisioning\u003dFalse - Backend only supports thin provisioning\nthin_provisioning\u003dTrue, thick_provisioning\u003dTrue - Backend can do either, and will look at the share type extra specs\n\n\nAdministrators have 4 options for share type extra specs, only 3 of which are valid:\nthin_provisioning\u003dNone, thick_provisioning\u003dNone - This is the default, indicating the admin doesn\u0027t care if its thick or thin\nthin_provisioning\u003dNone, thick_provisioning\u003dTrue - Share must be thick provisioned\nthin_provisioning\u003dTrue, thick_provisioning\u003dNone - Share must be thin provisioned\nthin_provisioning\u003dTrue, thick_provisioning\u003dTrue - INVALID, doesn\u0027t make sense","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f15417914c3e1e6b64ce42e520a107138af0cdd0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  thin-provisioned shares.  *TODO* Should we use manila_thin_provisioning?"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* `thick_provisioning_support` indicates that a backend/pool can provide"},{"line_number":61,"context_line":"  fully provisioned shares.  *TODO* Should we use manila_thick_provisioning?"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* `manila_dedup` indicates that a backend/pool can provide shares using some"},{"line_number":64,"context_line":"  deduplication technology.  *TODO* This is proposed -- not agreed upon."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_80f2af04","line":61,"in_reply_to":"1a4dcd0f_6c7be27b","updated":"2015-08-06 18:51:57.000000000","message":"I caught most of this, but I think the compatibilities vs extra-specs is a little confusing. So I left a little out, but I expect more feedback to get it back in.  Also by the way, we currently need the extra-spec value to be \u0027\u003cis\u003e True\u0027 to match a boolean.","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"757afde546a81f42b473cab4bfbb894d8dbcb410","unresolved":false,"context_lines":[{"line_number":60,"context_line":"* `thick_provisioning_support` indicates that a backend/pool can provide"},{"line_number":61,"context_line":"  fully provisioned shares.  *TODO* Should we use manila_thick_provisioning?"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* `manila_dedup` indicates that a backend/pool can provide shares using some"},{"line_number":64,"context_line":"  deduplication technology.  *TODO* This is proposed -- not agreed upon."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_072d7594","line":63,"updated":"2015-08-06 09:04:46.000000000","message":"Maybe we could set name to dedup.","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"338922bfd44342b99b99bfe6018143bc58fc0790","unresolved":false,"context_lines":[{"line_number":60,"context_line":"* `thick_provisioning_support` indicates that a backend/pool can provide"},{"line_number":61,"context_line":"  fully provisioned shares.  *TODO* Should we use manila_thick_provisioning?"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* `manila_dedup` indicates that a backend/pool can provide shares using some"},{"line_number":64,"context_line":"  deduplication technology.  *TODO* This is proposed -- not agreed upon."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_785abdf3","line":63,"in_reply_to":"1a4dcd0f_072d7594","updated":"2015-08-06 17:20:26.000000000","message":"We agreed in the weekly meeting NOT to use the manila_ prefix,\n\nThe spelling should be \"dedupe\".\n\nThe default value of the dedupe capability (if a driver doesn\u0027t report it) is False.\nThe default value of the dedupe extra spec (if a share type doesn\u0027t specify it) is None.\n\nDrivers cannot report to the scheduler that they support both dedupe and non-deduped share. For each pool it\u0027s either always on or always off.","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"757afde546a81f42b473cab4bfbb894d8dbcb410","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  fully provisioned shares.  *TODO* Should we use manila_thick_provisioning?"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* `manila_dedup` indicates that a backend/pool can provide shares using some"},{"line_number":64,"context_line":"  deduplication technology.  *TODO* This is proposed -- not agreed upon."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_ccdfb238","line":64,"updated":"2015-08-06 09:04:46.000000000","message":"Maybe we could add \u0027manila_compression\u0027.","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f15417914c3e1e6b64ce42e520a107138af0cdd0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  fully provisioned shares.  *TODO* Should we use manila_thick_provisioning?"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* `manila_dedup` indicates that a backend/pool can provide shares using some"},{"line_number":64,"context_line":"  deduplication technology.  *TODO* This is proposed -- not agreed upon."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_a0a7ab09","line":64,"in_reply_to":"1a4dcd0f_ccdfb238","updated":"2015-08-06 18:51:57.000000000","message":"We\u0027re trying to get dedup/thin/thick handled first. You should propose compression at a future meeting to determine if it should be left as huawei_compression, or if others would agree to promote it to common.","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"996c88eaa1e0fc45f556408f7a29447c3b31baef","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \u0027share_backend_name\u0027: \u0027My Backend\u0027,   #\\"},{"line_number":88,"context_line":"        \u0027vendor_name\u0027: \u0027OpenStack\u0027,           #  backend level"},{"line_number":89,"context_line":"        \u0027driver_version\u0027: \u00271.0\u0027,              #  mandatory/fixed"},{"line_number":90,"context_line":"        \u0027storage_protocol\u0027: \u0027NFS/CIFS\u0027,       #- stats\u0026capabilities"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        \u0027active_shares\u0027: 10,                  #\\"},{"line_number":93,"context_line":"        \u0027IOPS_provisioned\u0027: 30000,            #  optional custom"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_cf530816","line":90,"updated":"2015-08-06 17:36:59.000000000","message":"Currently we have \"NFS_CIFS\".","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f15417914c3e1e6b64ce42e520a107138af0cdd0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \u0027share_backend_name\u0027: \u0027My Backend\u0027,   #\\"},{"line_number":88,"context_line":"        \u0027vendor_name\u0027: \u0027OpenStack\u0027,           #  backend level"},{"line_number":89,"context_line":"        \u0027driver_version\u0027: \u00271.0\u0027,              #  mandatory/fixed"},{"line_number":90,"context_line":"        \u0027storage_protocol\u0027: \u0027NFS/CIFS\u0027,       #- stats\u0026capabilities"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        \u0027active_shares\u0027: 10,                  #\\"},{"line_number":93,"context_line":"        \u0027IOPS_provisioned\u0027: 30000,            #  optional custom"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a4dcd0f_40b34750","line":90,"in_reply_to":"1a4dcd0f_cf530816","updated":"2015-08-06 18:51:57.000000000","message":"Done","commit_id":"24ff77037e712269e03b58899cfc22a2fa0957ae"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"ebbb3d3c6f825207dc637b3fe1c769de832b2958","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  For each pool it\u0027s either always on or always off."},{"line_number":61,"context_line":"  Administrators can make a share type use deduplication by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":62,"context_line":"  Administrators can make a share type use deduplication by setting this extra-spec to \u0027\u003cis\u003e False\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* `thin_provisioning` - shares will not be space guaranteed and overprovisioning will be enabled."},{"line_number":65,"context_line":"  This capability defaults to False. Backends/pools that support thin provisioning must report True for"},{"line_number":66,"context_line":"  this capability. Administrators can make a share type use thin provisioned shares by setting this"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a4dcd0f_b607f180","line":63,"updated":"2015-08-06 19:58:19.000000000","message":"Last patchset I made a mistake in assuming that allowing both thin and thick in the same pool was something we wanted to support. Mixing thick and thin volumes in a pool causes major problems for the over subscription logic.\n\nWhile some backends may be able to support either thick or thin, it\u0027s typically a bad idea to allow that in the real world, and at cloud scale it makes absolutely no sense to allow that.\n\nIf we only have to support one or the other, and not both, the we can get away with a single capability and avoid all the messiness I proposed in my last comment.","commit_id":"f6e2d83a06fc967206d405edbd6c9539985185d9"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"87f4b9f73b2a4507d815593e49fc98f332a87a74","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  Drivers cannot report to the scheduler that they support both dedupe and non-deduped share."},{"line_number":60,"context_line":"  For each pool it\u0027s either always on or always off."},{"line_number":61,"context_line":"  Administrators can make a share type use deduplication by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":62,"context_line":"  Administrators can make a share type use deduplication by setting this extra-spec to \u0027\u003cis\u003e False\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* `thin_provisioning` - shares will not be space guaranteed and overprovisioning will be enabled."},{"line_number":65,"context_line":"  This capability defaults to False. Backends/pools that support thin provisioning must report True for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_b1505b0c","line":62,"updated":"2015-08-06 20:22:18.000000000","message":"Oops that second one should say \"not use\"","commit_id":"4b56d8803a02bd59781dba875dee159b18301aa2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"340926592a71678fca0ca5c21e5d073b58550972","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  Drivers cannot report to the scheduler that they support both dedupe and non-deduped share."},{"line_number":60,"context_line":"  For each pool it\u0027s either always on or always off."},{"line_number":61,"context_line":"  Administrators can make a share type use deduplication by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":62,"context_line":"  Administrators can make a share type use deduplication by setting this extra-spec to \u0027\u003cis\u003e False\u0027."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* `thin_provisioning` - shares will not be space guaranteed and overprovisioning will be enabled."},{"line_number":65,"context_line":"  This capability defaults to False. Backends/pools that support thin provisioning must report True for"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_29e93fb7","line":62,"in_reply_to":"1a4dcd0f_b1505b0c","updated":"2015-08-06 22:38:08.000000000","message":"Done","commit_id":"4b56d8803a02bd59781dba875dee159b18301aa2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"87f4b9f73b2a4507d815593e49fc98f332a87a74","unresolved":false,"context_lines":[{"line_number":137,"context_line":"             \u0027super_hero_2\u0027: \u0027Hulk\u0027,"},{"line_number":138,"context_line":"             \u0027dedup\u0027: False,"},{"line_number":139,"context_line":"             \u0027thin_provisioning\u0027: True,"},{"line_number":140,"context_line":"             \u0027thick_provisioning\u0027: True,"},{"line_number":141,"context_line":"             }"},{"line_number":142,"context_line":"         ]"},{"line_number":143,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_f1c34336","line":140,"updated":"2015-08-06 20:22:18.000000000","message":"and the example needs fixing","commit_id":"4b56d8803a02bd59781dba875dee159b18301aa2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"340926592a71678fca0ca5c21e5d073b58550972","unresolved":false,"context_lines":[{"line_number":137,"context_line":"             \u0027super_hero_2\u0027: \u0027Hulk\u0027,"},{"line_number":138,"context_line":"             \u0027dedup\u0027: False,"},{"line_number":139,"context_line":"             \u0027thin_provisioning\u0027: True,"},{"line_number":140,"context_line":"             \u0027thick_provisioning\u0027: True,"},{"line_number":141,"context_line":"             }"},{"line_number":142,"context_line":"         ]"},{"line_number":143,"context_line":"    }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_e9cfd753","line":140,"in_reply_to":"1a4dcd0f_f1c34336","updated":"2015-08-06 22:38:08.000000000","message":"Done","commit_id":"4b56d8803a02bd59781dba875dee159b18301aa2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"417ff347d82ef11e20324bdc9b3d6e0739955bbe","unresolved":false,"context_lines":[{"line_number":101,"context_line":"             \u0027free_capacity_gb\u0027: 230,         #  pools"},{"line_number":102,"context_line":"             \u0027allocated_capacity_gb\u0027: 270,    # |"},{"line_number":103,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,          # |"},{"line_number":104,"context_line":"             \u0027reserved_percentage\u0027: 0,        #/"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"             \u0027dying_disks\u0027: 100,              #\\"},{"line_number":107,"context_line":"             \u0027super_hero_1\u0027: \u0027spider-man\u0027,    #  optional custom"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_33e173d1","line":104,"updated":"2015-08-07 23:50:23.000000000","message":"This is missing provisioned_capacity_gb and max_over_subscription_ratio.  Those two should be mandatory for thin_provisioning\u003dTrue.","commit_id":"6532aac546b090a9681708d97bd3856c5ce19f2c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"faf6ec2478438f20170f5c42eca32b7a34157e34","unresolved":false,"context_lines":[{"line_number":101,"context_line":"             \u0027free_capacity_gb\u0027: 230,         #  pools"},{"line_number":102,"context_line":"             \u0027allocated_capacity_gb\u0027: 270,    # |"},{"line_number":103,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,          # |"},{"line_number":104,"context_line":"             \u0027reserved_percentage\u0027: 0,        #/"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"             \u0027dying_disks\u0027: 100,              #\\"},{"line_number":107,"context_line":"             \u0027super_hero_1\u0027: \u0027spider-man\u0027,    #  optional custom"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_7774bcfc","line":104,"in_reply_to":"1a4dcd0f_33e173d1","updated":"2015-08-17 17:56:40.000000000","message":"Done","commit_id":"6532aac546b090a9681708d97bd3856c5ce19f2c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"417ff347d82ef11e20324bdc9b3d6e0739955bbe","unresolved":false,"context_lines":[{"line_number":124,"context_line":"             \u0027thin_provisioning\u0027: False,"},{"line_number":125,"context_line":"             },"},{"line_number":126,"context_line":"         ]"},{"line_number":127,"context_line":"    }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Work Flow"},{"line_number":130,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_531f5fb7","line":127,"updated":"2015-08-07 23:50:23.000000000","message":"Talked to Ben a little bit about this. We should also clarify that if a pool can support both thin and thick from the array\u0027s point of view, the driver needs to programmatically determine whether  \"thin_provisioning\" is True or False.  This could be through configure options in manila.conf.  So admin can set up a thin_pool and a thick_pool.  Even though both can support thin and thick on the array, the driver needs to parse the configure file and reports thin_provisioning\u003dTrue for one pool and False for the other.","commit_id":"6532aac546b090a9681708d97bd3856c5ce19f2c"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"faf6ec2478438f20170f5c42eca32b7a34157e34","unresolved":false,"context_lines":[{"line_number":124,"context_line":"             \u0027thin_provisioning\u0027: False,"},{"line_number":125,"context_line":"             },"},{"line_number":126,"context_line":"         ]"},{"line_number":127,"context_line":"    }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Work Flow"},{"line_number":130,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa1b9901_0225fca9","line":127,"in_reply_to":"1a4dcd0f_531f5fb7","updated":"2015-08-17 17:56:40.000000000","message":"Done","commit_id":"6532aac546b090a9681708d97bd3856c5ce19f2c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"match a boolean capability the extra-spec value would be \u0027\u003cis\u003e True\u0027."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"For vendor-specific capabilities (which need to be visible to the"},{"line_number":44,"context_line":"CapabilityFilter), it is recommended to use the vendor prefix followed"},{"line_number":45,"context_line":"by an underscore. This is not a strict requirement, but will provide a"},{"line_number":46,"context_line":"consistent look along-side the scoped extra-specs and will be a clear"},{"line_number":47,"context_line":"indicator of vendor capabilities vs. common capabilities."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_78b48ff1","line":44,"updated":"2015-08-18 09:28:16.000000000","message":"Need to provide an example for \"the vendor prefix followed by an underscore\".","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d900018e4ebb3d716996d9f568040c8da4dc34a6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"match a boolean capability the extra-spec value would be \u0027\u003cis\u003e True\u0027."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"For vendor-specific capabilities (which need to be visible to the"},{"line_number":44,"context_line":"CapabilityFilter), it is recommended to use the vendor prefix followed"},{"line_number":45,"context_line":"by an underscore. This is not a strict requirement, but will provide a"},{"line_number":46,"context_line":"consistent look along-side the scoped extra-specs and will be a clear"},{"line_number":47,"context_line":"indicator of vendor capabilities vs. common capabilities."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_9284b0d4","line":44,"in_reply_to":"fa1b9901_78b48ff1","updated":"2015-08-19 05:54:59.000000000","message":"used \"my_\" in the \"My Backend\" example below.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"For capabilities that apply to multiple backends a common capability can"},{"line_number":52,"context_line":"be created."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* `driver_handles_share_servers` is a special, required, user-visible common"},{"line_number":55,"context_line":"  capability."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* `dedupe` - indicates that a backend/pool can provide shares using some"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_985de3eb","line":54,"updated":"2015-08-18 09:28:16.000000000","message":"We have only one set of docs, so we should be accurate documenting \"new\" features. I propose to say/mention, somehow, realese when feature was added.\n\nSo, \"driver_handles_share_servers\" is \"K\" feature. Below things are \"L\" feature.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d900018e4ebb3d716996d9f568040c8da4dc34a6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"For capabilities that apply to multiple backends a common capability can"},{"line_number":52,"context_line":"be created."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* `driver_handles_share_servers` is a special, required, user-visible common"},{"line_number":55,"context_line":"  capability."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* `dedupe` - indicates that a backend/pool can provide shares using some"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_32e284a0","line":54,"in_reply_to":"fa1b9901_985de3eb","updated":"2015-08-19 05:54:59.000000000","message":"Done, but perhaps someone can come up with a better way. This doc will evolve (after merge I hope).","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0bebff560e7e566724a774b3c6234d55b53072a9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  thin_provisioning\u003dFalse (the default) then it\u0027s assumed that the driver is"},{"line_number":72,"context_line":"  doing thick provisioning and overprovisioning is turned off."},{"line_number":73,"context_line":"  If an array can technically support both thin and thick provisioning in a"},{"line_number":74,"context_line":"  pool, the driver still needs to programmatically determine which to use."},{"line_number":75,"context_line":"  This should be done by configuring one pool for thin and another pool for"},{"line_number":76,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":77,"context_line":"  False."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_a04997d2","line":74,"updated":"2015-08-18 03:36:21.000000000","message":"The purpose of openstack should be more open to support various types of storage, and to support maximize storage capabilities. If the storage itself can support a more flexible configuration (eg. can create both thin and thick shares in one single pool),  then why don\u0027t we allow this to be introduced into manila? We should have a higher scalability, not one size fits all.\n\nAbout the problem of can\u0027t create a share with both thick and dedupe attribute at the same time, I think here could be some other solutions:\n\n1.  We could let the drivers to check if there are some extra-specs can\u0027t co-exist, and return creating share fail if there are.\n\n2.  We could also do this kind of check in the CapabilitiesFilter.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  thin_provisioning\u003dFalse (the default) then it\u0027s assumed that the driver is"},{"line_number":72,"context_line":"  doing thick provisioning and overprovisioning is turned off."},{"line_number":73,"context_line":"  If an array can technically support both thin and thick provisioning in a"},{"line_number":74,"context_line":"  pool, the driver still needs to programmatically determine which to use."},{"line_number":75,"context_line":"  This should be done by configuring one pool for thin and another pool for"},{"line_number":76,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":77,"context_line":"  False."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_b81227b3","line":74,"in_reply_to":"fa1b9901_a04997d2","updated":"2015-08-18 09:28:16.000000000","message":"As I understood, it is covered by \"pools\" approach. So, your driver instance can refer to more than one pool and they can have different values of this capability.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  This should be done by configuring one pool for thin and another pool for"},{"line_number":76,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":77,"context_line":"  False."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Reporting Capabilities"},{"line_number":80,"context_line":"----------------------"},{"line_number":81,"context_line":"Drivers report capabilities as part of the updated stats (e.g. capacity)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_b8eea789","line":78,"updated":"2015-08-18 09:28:16.000000000","message":"Also, would be great to mention \"snapshot_support\" that was \"agreed\" for implementation on last midcycle meetup and already ready for review [1] (This is also \"L\" feature).\n\n[1] https://review.openstack.org/#/c/211222/","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d900018e4ebb3d716996d9f568040c8da4dc34a6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  This should be done by configuring one pool for thin and another pool for"},{"line_number":76,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":77,"context_line":"  False."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Reporting Capabilities"},{"line_number":80,"context_line":"----------------------"},{"line_number":81,"context_line":"Drivers report capabilities as part of the updated stats (e.g. capacity)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_6dac9ded","line":78,"in_reply_to":"fa1b9901_b8eea789","updated":"2015-08-19 05:54:59.000000000","message":"Yeah, but we need to get agreement on these first ones and snapshot_support brings more questions. Let\u0027s address that in a separate patch.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"             \u0027reserved_percentage\u0027: 0,        #/"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"             \u0027dying_disks\u0027: 100,                #\\"},{"line_number":116,"context_line":"             \u0027super_hero_1\u0027: \u0027spider-man\u0027,      #  optional custom"},{"line_number":117,"context_line":"             \u0027super_hero_2\u0027: \u0027flash\u0027,           #  stats \u0026 capabilities"},{"line_number":118,"context_line":"             \u0027thin_provisioning\u0027: True,         #"},{"line_number":119,"context_line":"             \u0027provisioned_capacity_gb\u0027: 505,    #  mandatory for thin"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_f33440df","line":116,"updated":"2015-08-18 09:28:16.000000000","message":"\"Hulk\" starts with uppercase, but not \"spider-man\". It is unacceptable! ^_^","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d900018e4ebb3d716996d9f568040c8da4dc34a6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"             \u0027reserved_percentage\u0027: 0,        #/"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"             \u0027dying_disks\u0027: 100,                #\\"},{"line_number":116,"context_line":"             \u0027super_hero_1\u0027: \u0027spider-man\u0027,      #  optional custom"},{"line_number":117,"context_line":"             \u0027super_hero_2\u0027: \u0027flash\u0027,           #  stats \u0026 capabilities"},{"line_number":118,"context_line":"             \u0027thin_provisioning\u0027: True,         #"},{"line_number":119,"context_line":"             \u0027provisioned_capacity_gb\u0027: 505,    #  mandatory for thin"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_6d933da4","line":116,"in_reply_to":"fa1b9901_f33440df","updated":"2015-08-19 05:54:59.000000000","message":"Sorry if I offended anyone. This is just a copy of an old example.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,"},{"line_number":128,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":129,"context_line":"             \u0027dying_disks\u0027: 200,"},{"line_number":130,"context_line":"             \u0027super_hero_1\u0027: \u0027superman\u0027,"},{"line_number":131,"context_line":"             \u0027super_hero_2\u0027: \u0027 \u0027,"},{"line_number":132,"context_line":"             \u0027super_hero_2\u0027: \u0027Hulk\u0027,"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_d8683bf8","line":130,"updated":"2015-08-18 09:28:16.000000000","message":"Same here - \"Hulk\" starts with uppercase, but not \"superman\".","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d900018e4ebb3d716996d9f568040c8da4dc34a6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,"},{"line_number":128,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":129,"context_line":"             \u0027dying_disks\u0027: 200,"},{"line_number":130,"context_line":"             \u0027super_hero_1\u0027: \u0027superman\u0027,"},{"line_number":131,"context_line":"             \u0027super_hero_2\u0027: \u0027 \u0027,"},{"line_number":132,"context_line":"             \u0027super_hero_2\u0027: \u0027Hulk\u0027,"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_2d5225de","line":130,"in_reply_to":"fa1b9901_d8683bf8","updated":"2015-08-19 05:54:59.000000000","message":"I tried to improve and clean up this example.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"44e218d6d6c9dcf3b6244b7cb44a2b6248ea17f9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":129,"context_line":"             \u0027dying_disks\u0027: 200,"},{"line_number":130,"context_line":"             \u0027super_hero_1\u0027: \u0027superman\u0027,"},{"line_number":131,"context_line":"             \u0027super_hero_2\u0027: \u0027 \u0027,"},{"line_number":132,"context_line":"             \u0027super_hero_2\u0027: \u0027Hulk\u0027,"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":134,"context_line":"             \u0027thin_provisioning\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_f3be80fe","line":131,"updated":"2015-08-18 09:28:16.000000000","message":"dict can not have two identical keys - \"super_hero_2\"","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d900018e4ebb3d716996d9f568040c8da4dc34a6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":129,"context_line":"             \u0027dying_disks\u0027: 200,"},{"line_number":130,"context_line":"             \u0027super_hero_1\u0027: \u0027superman\u0027,"},{"line_number":131,"context_line":"             \u0027super_hero_2\u0027: \u0027 \u0027,"},{"line_number":132,"context_line":"             \u0027super_hero_2\u0027: \u0027Hulk\u0027,"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":134,"context_line":"             \u0027thin_provisioning\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_cdd12959","line":131,"in_reply_to":"fa1b9901_f3be80fe","updated":"2015-08-19 05:54:59.000000000","message":"Done, but you could argue for sidekick here.  Thanks for noticing.","commit_id":"7d7cab2e1741c26b923dc50926ceec9cf523b8e8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"89e5bfdbae77445d3d74010227b03991a7b2610a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"             \u0027dedupe\u0027: True,                    #\\"},{"line_number":119,"context_line":"             \u0027thin_provisioning\u0027: True,         # common capabilities"},{"line_number":120,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10, # (mandatory for thin)"},{"line_number":121,"context_line":"             \u0027dedupe\u0027: True,                    #/"},{"line_number":122,"context_line":"            },"},{"line_number":123,"context_line":"            {\u0027pool_name\u0027: \u0027thick pool\u0027,"},{"line_number":124,"context_line":"             \u0027total_capacity_gb\u0027: 1024,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa1b9901_ad3f15d5","line":121,"updated":"2015-08-19 06:17:52.000000000","message":"dict can not have two identical keys - \"dedupe\"","commit_id":"fdf195fd723d87246d5d4b9a0cdb74feee6426af"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1e848e473e2beeb60b640e9c9d6282c268eae10f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"             \u0027dedupe\u0027: True,                    #\\"},{"line_number":119,"context_line":"             \u0027thin_provisioning\u0027: True,         # common capabilities"},{"line_number":120,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10, # (mandatory for thin)"},{"line_number":121,"context_line":"             \u0027dedupe\u0027: True,                    #/"},{"line_number":122,"context_line":"            },"},{"line_number":123,"context_line":"            {\u0027pool_name\u0027: \u0027thick pool\u0027,"},{"line_number":124,"context_line":"             \u0027total_capacity_gb\u0027: 1024,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa1b9901_870c49ee","line":121,"in_reply_to":"fa1b9901_ad3f15d5","updated":"2015-08-19 17:49:37.000000000","message":"Done","commit_id":"fdf195fd723d87246d5d4b9a0cdb74feee6426af"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ec504b83108c723d477f1d9cb29fe00db7794385","unresolved":false,"context_lines":[{"line_number":125,"context_line":"             \u0027free_capacity_gb\u0027: 1024,"},{"line_number":126,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,"},{"line_number":127,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":128,"context_line":"             \u0027my_dying_disks\u0027: 200,"},{"line_number":129,"context_line":"             \u0027my_super_hero_1\u0027: \u0027Batman\u0027,"},{"line_number":130,"context_line":"             \u0027my_super_hero_2\u0027: \u0027Robin\u0027,"},{"line_number":131,"context_line":"             \u0027dedupe\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_c79a416e","line":128,"updated":"2015-08-19 17:51:10.000000000","message":"Would be much easier to read if order of key-values here is the same as above. Can you please reorder it?","commit_id":"48325a26ac562d9f4b00c6e295ebc83ea7f86900"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ec55b6d4973392c6b21bdeb68f3f230bedc1ad07","unresolved":false,"context_lines":[{"line_number":125,"context_line":"             \u0027free_capacity_gb\u0027: 1024,"},{"line_number":126,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,"},{"line_number":127,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":128,"context_line":"             \u0027my_dying_disks\u0027: 200,"},{"line_number":129,"context_line":"             \u0027my_super_hero_1\u0027: \u0027Batman\u0027,"},{"line_number":130,"context_line":"             \u0027my_super_hero_2\u0027: \u0027Robin\u0027,"},{"line_number":131,"context_line":"             \u0027dedupe\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa1b9901_e0a5eb46","line":128,"in_reply_to":"fa1b9901_c79a416e","updated":"2015-08-19 19:00:18.000000000","message":"Done","commit_id":"48325a26ac562d9f4b00c6e295ebc83ea7f86900"}]}
