)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"0c843cc62e496630558588aaf296a8f0b1d7fc7f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Valeriy Ponomaryov \u003cvponomaryov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-11 12:53:56 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add retry wrapper for DB methods that are vulnerable for deadlocks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is very likely to get \u0027deadlock\u0027 updating common records such as"},{"line_number":10,"context_line":"quotas, usages, reservations and metadata. All of these things are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_2f0f632f","line":7,"updated":"2015-08-11 10:01:43.000000000","message":"The first line should be limited to 50 characters, see https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"a7cc5f157f1e8abcc2a63e895fbe8ff9b1c9e40a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"97da1ec7bdbe4d780e3d848c11bab1b61eeebacd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Valeriy Ponomaryov \u003cvponomaryov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-11 12:53:56 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add retry wrapper for DB methods that are vulnerable for deadlocks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is very likely to get \u0027deadlock\u0027 updating common records such as"},{"line_number":10,"context_line":"quotas, usages, reservations and metadata. All of these things are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_6f29eb36","line":7,"in_reply_to":"1a4dcd0f_2f0f632f","updated":"2015-08-11 10:12:23.000000000","message":"First, it is allowed to make it up to 72 symbols.\n\nSecond, if you know better topic that satisfies length of 50 symbols, then, please, provide it. Else, I leave it as is.","commit_id":"a7cc5f157f1e8abcc2a63e895fbe8ff9b1c9e40a"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"52e8b0e59e9fafe7da8eab932a454cd489216352","unresolved":false,"context_lines":[{"line_number":10,"context_line":"quotas, usages, reservations and metadata. All of these things are"},{"line_number":11,"context_line":"API-dependent. So, add wrappers, that retries request on \u0027deadlock\u0027"},{"line_number":12,"context_line":"exceptions."},{"line_number":13,"context_line":"Also, set database config opt \"max_pool_size\" to \u002740\u0027 instead of having default"},{"line_number":14,"context_line":"value - \u00275\u0027. It allows to keep upto 40 SQL connections alive at once."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia6ec09d4617191c51ad95dd6d9f053141ec1c4c4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_51efe486","line":13,"updated":"2015-08-11 14:07:37.000000000","message":"We\u0027ll need to wrap this line here as it\u0027s longer than 72 characters. Perhaps something like:\n\n Also, set database config opt \"max_pool_size\" to \u002740\u0027 instead of having\n default value - \u00275\u0027. It allows to keep up to 40 SQL connections alive at \n once.","commit_id":"9e1f0cdb427b71e0189a0d2ce3f54f68500e27df"}],"devstack/plugin.sh":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c6ce869de0bd4d1724080810ad411b52200fbe9d","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    iniset $MANILA_CONF DEFAULT scheduler_driver $MANILA_SCHEDULER_DRIVER"},{"line_number":248,"context_line":"    iniset $MANILA_CONF DEFAULT share_name_template ${SHARE_NAME_PREFIX}%s"},{"line_number":249,"context_line":"    iniset $MANILA_CONF DATABASE connection `database_connection_url manila`"},{"line_number":250,"context_line":"    iniset $MANILA_CONF DATABASE max_pool_size 40"},{"line_number":251,"context_line":"    iniset $MANILA_CONF DEFAULT api_paste_config $MANILA_API_PASTE_INI"},{"line_number":252,"context_line":"    iniset $MANILA_CONF DEFAULT rootwrap_config $MANILA_CONF_DIR/rootwrap.conf"},{"line_number":253,"context_line":"    iniset $MANILA_CONF DEFAULT osapi_share_extension manila.api.contrib.standard_extensions"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a4dcd0f_09d495e9","line":250,"updated":"2015-08-12 15:18:12.000000000","message":"How did you determine to set max_pool_size to 40 instead of other values?  I\u0027m just curious as I submitted a patch to change max_pool_size to 20 and max_overflow to 30 for cinder. We have been using those numbers in our CI setup.\n\nhttps://review.openstack.org/#/c/211735/1/lib/cinder","commit_id":"ab05b5c4651f400b7aaab803be4ace8c6e0bc114"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"216bbba31e64bb189c9b562b29a502d5b6ece864","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    iniset $MANILA_CONF DEFAULT scheduler_driver $MANILA_SCHEDULER_DRIVER"},{"line_number":248,"context_line":"    iniset $MANILA_CONF DEFAULT share_name_template ${SHARE_NAME_PREFIX}%s"},{"line_number":249,"context_line":"    iniset $MANILA_CONF DATABASE connection `database_connection_url manila`"},{"line_number":250,"context_line":"    iniset $MANILA_CONF DATABASE max_pool_size 40"},{"line_number":251,"context_line":"    iniset $MANILA_CONF DEFAULT api_paste_config $MANILA_API_PASTE_INI"},{"line_number":252,"context_line":"    iniset $MANILA_CONF DEFAULT rootwrap_config $MANILA_CONF_DIR/rootwrap.conf"},{"line_number":253,"context_line":"    iniset $MANILA_CONF DEFAULT osapi_share_extension manila.api.contrib.standard_extensions"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a4dcd0f_c92d4da9","line":250,"in_reply_to":"1a4dcd0f_09d495e9","updated":"2015-08-12 15:22:45.000000000","message":"I was running heavy load of Rally scenarios that required it.\n\nSure it is not strict to have exactly \"40\", but having this value I did not face pool limit exceedance.","commit_id":"ab05b5c4651f400b7aaab803be4ace8c6e0bc114"}]}