)]}'
{"contrib/tempest/tempest/api/share/test_microversions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99c7ba0c1f46699dee8aa65accf05b1cb05bd289","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_305b40f8","line":16,"updated":"2015-08-19 15:36:58.000000000","message":"Please, use \"jsonutils\" from \"oslo_serialization\".","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c83f6cfd2fd84921892f9c3bc5763543ad966b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5e49f05e","line":16,"in_reply_to":"fa1b9901_305b40f8","updated":"2015-08-25 19:56:33.000000000","message":"Moved the method below to shares_client.","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99c7ba0c1f46699dee8aa65accf05b1cb05bd289","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _API_MICROVERSIONS_HEADER \u003d \u0027x-openstack-manila-api-version\u0027"},{"line_number":31,"context_line":"    _MIN_API_VERSION \u003d \u00271.0\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _send_microversion_request(self, version\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Prepare and send the HTTP GET Request to the base URL."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_506034a5","line":31,"updated":"2015-08-19 15:36:58.000000000","message":"Maybe better to make configurable? To avoid need to update codebase in case min version is updated in Manila. Same for \"top\" version, that is expected to be changed not so rarely.","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c83f6cfd2fd84921892f9c3bc5763543ad966b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    _API_MICROVERSIONS_HEADER \u003d \u0027x-openstack-manila-api-version\u0027"},{"line_number":31,"context_line":"    _MIN_API_VERSION \u003d \u00271.0\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _send_microversion_request(self, version\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Prepare and send the HTTP GET Request to the base URL."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c57479ff","line":31,"in_reply_to":"fa1b9901_506034a5","updated":"2015-08-25 19:56:33.000000000","message":"Made both configurable, and added an additional max_version testcase.","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99c7ba0c1f46699dee8aa65accf05b1cb05bd289","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    _API_MICROVERSIONS_HEADER \u003d \u0027x-openstack-manila-api-version\u0027"},{"line_number":31,"context_line":"    _MIN_API_VERSION \u003d \u00271.0\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _send_microversion_request(self, version\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Prepare and send the HTTP GET Request to the base URL."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        Extracts the base URL from the shares_client endpoint and makes a GET"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d043e440","line":33,"updated":"2015-08-19 15:36:58.000000000","message":"It should be in shares client, not here.","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c83f6cfd2fd84921892f9c3bc5763543ad966b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    _API_MICROVERSIONS_HEADER \u003d \u0027x-openstack-manila-api-version\u0027"},{"line_number":31,"context_line":"    _MIN_API_VERSION \u003d \u00271.0\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _send_microversion_request(self, version\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Prepare and send the HTTP GET Request to the base URL."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        Extracts the base URL from the shares_client endpoint and makes a GET"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e5717d0d","line":33,"in_reply_to":"fa1b9901_d043e440","updated":"2015-08-25 19:56:33.000000000","message":"Done","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99c7ba0c1f46699dee8aa65accf05b1cb05bd289","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.assertEqual(self._MIN_API_VERSION,"},{"line_number":57,"context_line":"                         resp[self._API_MICROVERSIONS_HEADER])"},{"line_number":58,"context_line":"        self.assertTrue(\u0027min_version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":59,"context_line":"        self.assertTrue(\u0027version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8d047518","line":58,"updated":"2015-08-19 15:36:58.000000000","message":"self.assertNotIn(\u0027min_version\u0027, resp_body[\u0027versions\u0027][0])\n\nAlso, this is test, and we should verify length of a \"resp_body[\u0027versions\u0027]\" first, then try to take its first element:\n\n\"\"\"\n\nself.assertTrue(len(resp_body[\u0027versions\u0027]) \u003e 0)\n\n\"\"\"","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c83f6cfd2fd84921892f9c3bc5763543ad966b","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.assertEqual(self._MIN_API_VERSION,"},{"line_number":57,"context_line":"                         resp[self._API_MICROVERSIONS_HEADER])"},{"line_number":58,"context_line":"        self.assertTrue(\u0027min_version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":59,"context_line":"        self.assertTrue(\u0027version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_655c8d7d","line":58,"in_reply_to":"fa1b9901_8d047518","updated":"2015-08-25 19:56:33.000000000","message":"That\u0027s definitely required. Thank you.","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99c7ba0c1f46699dee8aa65accf05b1cb05bd289","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(self._MIN_API_VERSION,"},{"line_number":57,"context_line":"                         resp[self._API_MICROVERSIONS_HEADER])"},{"line_number":58,"context_line":"        self.assertTrue(\u0027min_version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":59,"context_line":"        self.assertTrue(\u0027version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"},{"line_number":62,"context_line":"    def test_microversions_version_min_version(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_10071c19","line":59,"updated":"2015-08-19 15:36:58.000000000","message":"self.assertNotIn(\u0027version\u0027, resp_body[\u0027versions\u0027][0])","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c83f6cfd2fd84921892f9c3bc5763543ad966b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertEqual(self._MIN_API_VERSION,"},{"line_number":57,"context_line":"                         resp[self._API_MICROVERSIONS_HEADER])"},{"line_number":58,"context_line":"        self.assertTrue(\u0027min_version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":59,"context_line":"        self.assertTrue(\u0027version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"},{"line_number":62,"context_line":"    def test_microversions_version_min_version(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c0e4673d","line":59,"in_reply_to":"fa1b9901_10071c19","updated":"2015-08-25 19:56:33.000000000","message":"Done","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99c7ba0c1f46699dee8aa65accf05b1cb05bd289","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertEqual(self._MIN_API_VERSION,"},{"line_number":69,"context_line":"                         resp[self._API_MICROVERSIONS_HEADER])"},{"line_number":70,"context_line":"        self.assertTrue(\u0027min_version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":71,"context_line":"        self.assertTrue(\u0027version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b08bd067","line":70,"updated":"2015-08-19 15:36:58.000000000","message":"Same here and below.","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6c83f6cfd2fd84921892f9c3bc5763543ad966b","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertEqual(self._MIN_API_VERSION,"},{"line_number":69,"context_line":"                         resp[self._API_MICROVERSIONS_HEADER])"},{"line_number":70,"context_line":"        self.assertTrue(\u0027min_version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":71,"context_line":"        self.assertTrue(\u0027version\u0027 not in resp_body[\u0027versions\u0027][0])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e0e16b2b","line":70,"in_reply_to":"fa1b9901_b08bd067","updated":"2015-08-25 19:56:33.000000000","message":"Done","commit_id":"42c385efdd8efb57459b669a9be5709dcf42ab07"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"04737b7f9e76f0fa02ee447856d05abd32ede5b8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"},{"line_number":43,"context_line":"    def test_microversions_version_min_version(self):"},{"line_number":44,"context_line":"        \"\"\"Requests base version 1.0.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        resp, resp_body \u003d self.shares_client.send_microversion_request("},{"line_number":47,"context_line":"            self._MIN_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_f5ba76e0","line":44,"updated":"2015-08-26 05:26:32.000000000","message":"If you do another patch, it\u0027s probably not a good idea to hard-comment the 1.0, when the code made it configurable.","commit_id":"2521b16d36fc4c211137d3015013eb2d336d6cc3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f0f624d6e063001a34f3a5720f245c763349be8f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @test.attr(type\u003d[\"gate\", \"smoke\", ])"},{"line_number":43,"context_line":"    def test_microversions_version_min_version(self):"},{"line_number":44,"context_line":"        \"\"\"Requests base version 1.0.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        resp, resp_body \u003d self.shares_client.send_microversion_request("},{"line_number":47,"context_line":"            self._MIN_API_VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_6f299c9a","line":44,"in_reply_to":"fa1b9901_f5ba76e0","updated":"2015-08-26 13:54:46.000000000","message":"Yes, it should say about \"min version\".","commit_id":"2521b16d36fc4c211137d3015013eb2d336d6cc3"}]}