)]}'
{"manila/tests/share/drivers/netapp/dataontap/client/fake_api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"50aedfe74aa1302396487133d3c85874354018ce","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\"Add the child element to the element.\"\"\""},{"line_number":97,"context_line":"        if isinstance(na_element, NaElement):"},{"line_number":98,"context_line":"            self._element.append(na_element._element)"},{"line_number":99,"context_line":"            return"},{"line_number":100,"context_line":"        raise"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get_child_by_name(self, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_a120bdf8","line":99,"updated":"2015-08-27 09:35:20.000000000","message":"Here you have just \"return\"","commit_id":"ca6168d01bea405718bbf6a36d4bb75c23d1b783"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"50aedfe74aa1302396487133d3c85874354018ce","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        for child in self._element.iterchildren():"},{"line_number":105,"context_line":"            if child.tag \u003d\u003d name or etree.QName(child.tag).localname \u003d\u003d name:"},{"line_number":106,"context_line":"                return NaElement(child)"},{"line_number":107,"context_line":"        return None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def get_child_content(self, name):"},{"line_number":110,"context_line":"        \"\"\"Get the content of the child.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_415f6172","line":107,"updated":"2015-08-27 09:35:20.000000000","message":"but here \"return None\". It works OK, but not consistent with each other.","commit_id":"ca6168d01bea405718bbf6a36d4bb75c23d1b783"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"50aedfe74aa1302396487133d3c85874354018ce","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        for child in self._element.iterchildren():"},{"line_number":112,"context_line":"            if child.tag \u003d\u003d name or etree.QName(child.tag).localname \u003d\u003d name:"},{"line_number":113,"context_line":"                return child.text"},{"line_number":114,"context_line":"        return None"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def get_children(self):"},{"line_number":117,"context_line":"        \"\"\"Get the children for the element.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_0152c967","line":114,"updated":"2015-08-27 09:35:20.000000000","message":"same here.","commit_id":"ca6168d01bea405718bbf6a36d4bb75c23d1b783"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"50aedfe74aa1302396487133d3c85874354018ce","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        return attributes.get(name)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def get_attr_names(self):"},{"line_number":131,"context_line":"        \"\"\"Returns the list of attribute names.\"\"\""},{"line_number":132,"context_line":"        attributes \u003d self._element.attrib or {}"},{"line_number":133,"context_line":"        return attributes.keys()"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_21ab4d8b","line":131,"updated":"2015-08-27 09:35:20.000000000","message":"Here you say that you expect \"list\", BUT","commit_id":"ca6168d01bea405718bbf6a36d4bb75c23d1b783"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"50aedfe74aa1302396487133d3c85874354018ce","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    def get_attr_names(self):"},{"line_number":131,"context_line":"        \"\"\"Returns the list of attribute names.\"\"\""},{"line_number":132,"context_line":"        attributes \u003d self._element.attrib or {}"},{"line_number":133,"context_line":"        return attributes.keys()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def add_new_child(self, name, content, convert\u003dFalse):"},{"line_number":136,"context_line":"        \"\"\"Add child with tag name and context."}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_21e7cde5","line":133,"updated":"2015-08-27 09:35:20.000000000","message":"using py3 it will return \"dict keys\" class instance. That does not have some \"list\" methods. If you want to be consistent then need to wrap it with \"list(..)\".","commit_id":"ca6168d01bea405718bbf6a36d4bb75c23d1b783"}]}