)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b967a200552d592c3fee9710fc539b1106f8a182","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Method get_stats was not considering other data, overheads or"},{"line_number":10,"context_line":"snapshots in filesystem, just virtual-volumes quotas. With this"},{"line_number":11,"context_line":"fix, it returns correctly usage of filesystem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1494780"},{"line_number":14,"context_line":"Change-Id: I5a7f9936f7aa6f308ee9e6360773a2934520b835"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_851d0e11","line":11,"updated":"2015-09-11 14:52:40.000000000","message":"Please add that you are fixing a small detail in manage method as well.","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"2e02a6278b7b334a020cab57616e1bf2f6ef4c79","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Method get_stats was not considering other data, overheads or"},{"line_number":10,"context_line":"snapshots in filesystem, just virtual-volumes quotas. With this"},{"line_number":11,"context_line":"fix, it returns correctly usage of filesystem."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1494780"},{"line_number":14,"context_line":"Change-Id: I5a7f9936f7aa6f308ee9e6360773a2934520b835"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_3f5e8b13","line":11,"in_reply_to":"da20952f_851d0e11","updated":"2015-09-11 17:16:32.000000000","message":"Done","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"}],"manila/share/drivers/hitachi/hds_hnas.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b967a200552d592c3fee9710fc539b1106f8a182","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        else:"},{"line_number":451,"context_line":"            if managing:"},{"line_number":452,"context_line":"                msg \u003d _(\"Error in managing share %(shr_id)s. \""},{"line_number":453,"context_line":"                        \"It is already being managed.\") % {\u0027shr\u0027: [\u0027host\u0027]}"},{"line_number":454,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":455,"context_line":"        return hnas_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_45b2964a","line":453,"updated":"2015-09-11 14:52:40.000000000","message":"it must be:\n\n{\u0027shr_id\u0027: share_id}","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ea5f6ea497fc98a23c0b45a0e871dda6793b5b3","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        else:"},{"line_number":451,"context_line":"            if managing:"},{"line_number":452,"context_line":"                msg \u003d _(\"Error in managing share %(shr_id)s. \""},{"line_number":453,"context_line":"                        \"It is already being managed.\") % {\u0027shr\u0027: [\u0027host\u0027]}"},{"line_number":454,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":455,"context_line":"        return hnas_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f4811a4e","line":453,"in_reply_to":"da20952f_45b2964a","updated":"2015-09-11 16:47:25.000000000","message":"+1","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"b547efda16dea1a40b1499b2763030664208e25c","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        else:"},{"line_number":451,"context_line":"            if managing:"},{"line_number":452,"context_line":"                msg \u003d _(\"Error in managing share %(shr_id)s. \""},{"line_number":453,"context_line":"                        \"It is already being managed.\") % {\u0027shr\u0027: [\u0027host\u0027]}"},{"line_number":454,"context_line":"                raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":455,"context_line":"        return hnas_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d4e736e1","line":453,"in_reply_to":"da20952f_f4811a4e","updated":"2015-09-11 17:16:06.000000000","message":"Done.","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"}],"manila/share/drivers/hitachi/ssh.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ea5f6ea497fc98a23c0b45a0e871dda6793b5b3","unresolved":false,"context_lines":[{"line_number":811,"context_line":"class Capacity(object):"},{"line_number":812,"context_line":"    def __init__(self, data):"},{"line_number":813,"context_line":"        if data:"},{"line_number":814,"context_line":"            items \u003d data.split()"},{"line_number":815,"context_line":"            self.id \u003d items[0]"},{"line_number":816,"context_line":"            self.label \u003d items[1]"},{"line_number":817,"context_line":"            self.evs \u003d items[2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_94653ee2","line":814,"updated":"2015-09-11 16:47:25.000000000","message":"It better to check the items length, and exception the clear reason if the items length is not match.","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"75af1b914e7f59cada96a6f2d0e8e0dd4b913175","unresolved":false,"context_lines":[{"line_number":811,"context_line":"class Capacity(object):"},{"line_number":812,"context_line":"    def __init__(self, data):"},{"line_number":813,"context_line":"        if data:"},{"line_number":814,"context_line":"            items \u003d data.split()"},{"line_number":815,"context_line":"            self.id \u003d items[0]"},{"line_number":816,"context_line":"            self.label \u003d items[1]"},{"line_number":817,"context_line":"            self.evs \u003d items[2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_54ffa601","line":814,"in_reply_to":"da20952f_94653ee2","updated":"2015-09-11 17:13:36.000000000","message":"The output length from the backend can either be consistent, as example in test_ssh.py HNAS_RESULT_df, or inconsistent, which would cause the method to fail and throw the respective exception. I believe catching such an exception to not treat it, just re-raise, is not worth even adding the try catch block.","commit_id":"0578131b5953df592b39dbcc9de4c2ecc2ac69bc"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"3794aed166f52bc1eb73a1fd92d4582d1f1123ea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        fs_capacities[0].size \u003d Total size from filesystem."},{"line_number":53,"context_line":"        available_space \u003d Free space currently on filesystem."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        fs_capacities \u003d []"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        command \u003d [\u0027df\u0027, \u0027-a\u0027, \u0027-f\u0027, self.fs_name]"},{"line_number":58,"context_line":"        output, err \u003d self._execute(command)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_72032e43","line":55,"updated":"2015-09-15 12:07:46.000000000","message":"This does not need to be an array. You are only using 1 element.","commit_id":"c42355a1c74a46ec04ac638d6afa39964c501273"},{"author":{"_account_id":14863,"name":"Diego Zamboni Latance","email":"dzambonil@gmail.com","username":"DiegoZamboni"},"change_message_id":"6be74912f59ab6fe6989539798a5c7d6ffed907d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        available_space \u003d fs_capacities[0].size - fs_capacities[0].used"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        LOG.debug(\"Total space in file system: %(total)s.\","},{"line_number":66,"context_line":"                  {\u0027total\u0027: fs_capacities[0].size})"},{"line_number":67,"context_line":"        LOG.debug(\"Used space in the file system: %(used)s.\","},{"line_number":68,"context_line":"                  {\u0027used\u0027: fs_capacities[0].used})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_f7b0be8d","line":65,"updated":"2015-09-14 13:41:41.000000000","message":"Maybe it\u0027s a good idea to put the unit in these log messages.","commit_id":"c42355a1c74a46ec04ac638d6afa39964c501273"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"3794aed166f52bc1eb73a1fd92d4582d1f1123ea","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        available_space \u003d fs_capacities[0].size - fs_capacities[0].used"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        LOG.debug(\"Total space in file system: %(total)s.\","},{"line_number":66,"context_line":"                  {\u0027total\u0027: fs_capacities[0].size})"},{"line_number":67,"context_line":"        LOG.debug(\"Used space in the file system: %(used)s.\","},{"line_number":68,"context_line":"                  {\u0027used\u0027: fs_capacities[0].used})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_724c8e42","line":65,"in_reply_to":"ba15a1d1_f7b0be8d","updated":"2015-09-15 12:07:46.000000000","message":"+1","commit_id":"c42355a1c74a46ec04ac638d6afa39964c501273"}]}