)]}'
{"manila/api/views/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a612e7da6d5b2dca85425bac9cbb928ed828001e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":109,"context_line":"        })"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @common.ViewBuilder.versioned_method(\"2.5\", None, True)"},{"line_number":112,"context_line":"    def add_task_state_field(self, share_dict, share):"},{"line_number":113,"context_line":"        share_dict[\u0027task_state\u0027] \u003d share.get(\u0027task_state\u0027)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_fa4e53c0","line":111,"updated":"2015-09-14 20:36:57.000000000","message":"Can you please place it between 2.4 and 2.6 modifiers?","commit_id":"1cbf4840aef1644d34cccf2814a98acbca85761d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"88ef973737d733ac7b469e0ff51f3f28d7165bfc","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":109,"context_line":"        })"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @common.ViewBuilder.versioned_method(\"2.5\", None, True)"},{"line_number":112,"context_line":"    def add_task_state_field(self, share_dict, share):"},{"line_number":113,"context_line":"        share_dict[\u0027task_state\u0027] \u003d share.get(\u0027task_state\u0027)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_c1635fb0","line":111,"in_reply_to":"ba15a1d1_fa4e53c0","updated":"2015-09-15 13:35:04.000000000","message":"Done","commit_id":"1cbf4840aef1644d34cccf2814a98acbca85761d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ecb0c92f164b7de485883db9578e0ae147046452","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":24,"context_line":"        \"add_consistency_group_fields\","},{"line_number":25,"context_line":"        \"modify_share_type_field\","},{"line_number":26,"context_line":"        \"add_task_state_field\","},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def summary_list(self, request, shares):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_40197b87","line":26,"updated":"2015-09-15 10:18:36.000000000","message":"This is out of order too. Er.","commit_id":"306f511b2f5cff5c63268d005ecfde27fc3bbdf0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"518f2e24b80f5e75dbe837094bba6198a6f7e0d6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":24,"context_line":"        \"add_consistency_group_fields\","},{"line_number":25,"context_line":"        \"modify_share_type_field\","},{"line_number":26,"context_line":"        \"add_task_state_field\","},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def summary_list(self, request, shares):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_c6291c39","line":26,"in_reply_to":"ba15a1d1_40197b87","updated":"2015-09-15 13:35:14.000000000","message":"Done","commit_id":"306f511b2f5cff5c63268d005ecfde27fc3bbdf0"}],"manila/tests/api/v1/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a612e7da6d5b2dca85425bac9cbb928ed828001e","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":734,"context_line":"        self.assertEqual(res_dict[\u0027shares\u0027][0][\u0027volume_type\u0027],"},{"line_number":735,"context_line":"                         res_dict[\u0027shares\u0027][0][\u0027share_type\u0027])"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def test_share_list_detail_with_consistency_group(self):"},{"line_number":738,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":739,"context_line":"                         stubs.stub_share_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_9a49578e","line":736,"updated":"2015-09-14 20:36:57.000000000","message":"This","commit_id":"1cbf4840aef1644d34cccf2814a98acbca85761d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"88ef973737d733ac7b469e0ff51f3f28d7165bfc","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        self.assertEqual(expected, res_dict)"},{"line_number":734,"context_line":"        self.assertEqual(res_dict[\u0027shares\u0027][0][\u0027volume_type\u0027],"},{"line_number":735,"context_line":"                         res_dict[\u0027shares\u0027][0][\u0027share_type\u0027])"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"    def test_share_list_detail_with_consistency_group(self):"},{"line_number":738,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":739,"context_line":"                         stubs.stub_share_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_869fa44f","line":736,"in_reply_to":"ba15a1d1_9a49578e","updated":"2015-09-15 13:35:04.000000000","message":"Done","commit_id":"1cbf4840aef1644d34cccf2814a98acbca85761d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a612e7da6d5b2dca85425bac9cbb928ed828001e","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        self.assertEqual(res_dict[\u0027shares\u0027][0][\u0027volume_type\u0027],"},{"line_number":782,"context_line":"                         res_dict[\u0027shares\u0027][0][\u0027share_type\u0027])"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    def test_share_list_detail_with_task_state(self):"},{"line_number":785,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":786,"context_line":"                         stubs.stub_share_get_all_by_project)"},{"line_number":787,"context_line":"        env \u003d {\u0027QUERY_STRING\u0027: \u0027name\u003dShare+Test+Name\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_fa589358","line":784,"updated":"2015-09-14 20:36:57.000000000","message":"And this tests could be combined. They differ only by two lines.","commit_id":"1cbf4840aef1644d34cccf2814a98acbca85761d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"88ef973737d733ac7b469e0ff51f3f28d7165bfc","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        self.assertEqual(res_dict[\u0027shares\u0027][0][\u0027volume_type\u0027],"},{"line_number":782,"context_line":"                         res_dict[\u0027shares\u0027][0][\u0027share_type\u0027])"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    def test_share_list_detail_with_task_state(self):"},{"line_number":785,"context_line":"        self.mock_object(share_api.API, \u0027get_all\u0027,"},{"line_number":786,"context_line":"                         stubs.stub_share_get_all_by_project)"},{"line_number":787,"context_line":"        env \u003d {\u0027QUERY_STRING\u0027: \u0027name\u003dShare+Test+Name\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e6b6a0db","line":784,"in_reply_to":"ba15a1d1_fa589358","updated":"2015-09-15 13:35:04.000000000","message":"Done","commit_id":"1cbf4840aef1644d34cccf2814a98acbca85761d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8ea70033f8283361f6de82ceea469a477ac47ca4","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                                      version\u003d\"2.4\")"},{"line_number":747,"context_line":"        expected \u003d self._list_detail_common_expected()"},{"line_number":748,"context_line":"        expected[\u0027shares\u0027][0][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":749,"context_line":"        expected[\u0027shares\u0027][0][\u0027source_cgsnapshot_member_id\u0027] \u003d None"},{"line_number":750,"context_line":"        self._list_detail_test_common(req, expected)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def test_share_list_detail_with_task_state(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_fb3640e6","line":749,"updated":"2015-09-15 10:21:31.000000000","message":"Absence of \"task_state\" is not verified. But it is exactly the point of commit.","commit_id":"306f511b2f5cff5c63268d005ecfde27fc3bbdf0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"518f2e24b80f5e75dbe837094bba6198a6f7e0d6","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                                      version\u003d\"2.4\")"},{"line_number":747,"context_line":"        expected \u003d self._list_detail_common_expected()"},{"line_number":748,"context_line":"        expected[\u0027shares\u0027][0][\u0027consistency_group_id\u0027] \u003d None"},{"line_number":749,"context_line":"        expected[\u0027shares\u0027][0][\u0027source_cgsnapshot_member_id\u0027] \u003d None"},{"line_number":750,"context_line":"        self._list_detail_test_common(req, expected)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def test_share_list_detail_with_task_state(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_0662b4ad","line":749,"in_reply_to":"ba15a1d1_fb3640e6","updated":"2015-09-15 13:35:14.000000000","message":"Absence of task_state is verified through comparison with \"expected\" which does not contain it. Please see line 733 in _list_detail_test_common.","commit_id":"306f511b2f5cff5c63268d005ecfde27fc3bbdf0"}]}
