)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60cf831c8622541a1df3711ebbdb78ed9728e7f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"It is impacting directly on managing shares."},{"line_number":12,"context_line":"As an example, managing a 500 Mb share results in 500 Gb share in HDS HNAS"},{"line_number":13,"context_line":"Driver."},{"line_number":14,"context_line":"The unit Tb was already being transformed in Gb."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch implements a conditition to deny share with quota smaller than"},{"line_number":17,"context_line":"1GB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_7cb3860a","line":14,"updated":"2015-09-17 17:20:29.000000000","message":"use TB, GB, MB, KB...","commit_id":"a19c5d66a57a7a7644e9d48a467b8f12b07c4799"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60cf831c8622541a1df3711ebbdb78ed9728e7f4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Driver."},{"line_number":14,"context_line":"The unit Tb was already being transformed in Gb."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch implements a conditition to deny share with quota smaller than"},{"line_number":17,"context_line":"1GB."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: #1496917"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_1cc36a58","line":16,"updated":"2015-09-17 17:20:29.000000000","message":"condition","commit_id":"a19c5d66a57a7a7644e9d48a467b8f12b07c4799"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"94f512dd22fcc3a7ea044bb270f159708654bb1a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alyson Rosa \u003calyson.rodrigues.rosa@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-17 15:12:38 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix how get_quota handles size units in manage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Method get_quota does not handle quotas smaller than 1 GB."},{"line_number":10,"context_line":"When the share quota is KB or MB, get_quota transforms everything to GB."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_3359ad8e","line":7,"updated":"2015-09-18 03:49:51.000000000","message":"I think this top-line should better describe the change.  Maybe \"HNAS Make manage refuse shares less than 1 GB\" -- more-or-less.  Up to you.","commit_id":"a5301e897e9234610ec308a578511333bc1305cb"}],"manila/share/drivers/hitachi/ssh.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60cf831c8622541a1df3711ebbdb78ed9728e7f4","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                if \u0027Limit\u0027 in items[i] and \u0027Hard\u0027 in items[i]:"},{"line_number":668,"context_line":"                    quota \u003d float(items[i].split(\u0027 \u0027)[12])"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"                    if items[i].split(\u0027 \u0027)[13] in (\u0027TB\u0027, \u0027GB\u0027):"},{"line_number":671,"context_line":"                        # If the quota is 1 or more TB, converts to GB"},{"line_number":672,"context_line":"                        if items[i].split(\u0027 \u0027)[13] \u003d\u003d \u0027TB\u0027:"},{"line_number":673,"context_line":"                            return quota * units.Ki"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_7c5706ca","line":670,"updated":"2015-09-17 17:20:29.000000000","message":"It is better to save the result of \" items[i].split(\u0027 \u0027)[13] \" in a variable instead of splitting twice.","commit_id":"a19c5d66a57a7a7644e9d48a467b8f12b07c4799"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"24603e2efade277cb87ed990dab6c1125fe00e41","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                            return quota * units.Ki"},{"line_number":674,"context_line":"                        return quota"},{"line_number":675,"context_line":"                    else:"},{"line_number":676,"context_line":"                        msg \u003d (_(\"Share quota must be in GB or TB.\"))"},{"line_number":677,"context_line":"                        raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":678,"context_line":"            else:"},{"line_number":679,"context_line":"                # Returns None if the quota is unset"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c21aecc5","line":676,"updated":"2015-09-17 18:02:40.000000000","message":"Also, I would change the message to \"Share %(share_id)s only supports quota values above 1GB.\"","commit_id":"a19c5d66a57a7a7644e9d48a467b8f12b07c4799"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60cf831c8622541a1df3711ebbdb78ed9728e7f4","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                            return quota * units.Ki"},{"line_number":674,"context_line":"                        return quota"},{"line_number":675,"context_line":"                    else:"},{"line_number":676,"context_line":"                        msg \u003d (_(\"Share quota must be in GB or TB.\"))"},{"line_number":677,"context_line":"                        raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":678,"context_line":"            else:"},{"line_number":679,"context_line":"                # Returns None if the quota is unset"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_9cdf7a39","line":676,"updated":"2015-09-17 17:20:29.000000000","message":"It is a good idea to print share_id within this message.","commit_id":"a19c5d66a57a7a7644e9d48a467b8f12b07c4799"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"94f512dd22fcc3a7ea044bb270f159708654bb1a","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                            return quota * units.Ki"},{"line_number":674,"context_line":"                        return quota"},{"line_number":675,"context_line":"                    else:"},{"line_number":676,"context_line":"                        msg \u003d (_(\"Share %s does not supports quotas values \""},{"line_number":677,"context_line":"                                 \"below 1GB.\") % share_id)"},{"line_number":678,"context_line":"                        raise exception.HNASBackendException(msg\u003dmsg)"},{"line_number":679,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_33d0cdc8","line":676,"updated":"2015-09-18 03:49:51.000000000","message":"s/supports/support/  s/quotas/quota/","commit_id":"a5301e897e9234610ec308a578511333bc1305cb"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f8b76b07de0a224dde6caac55f15f072be2d5b72","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                        if size_unit \u003d\u003d \u0027TB\u0027:"},{"line_number":673,"context_line":"                            return quota * units.Ki"},{"line_number":674,"context_line":"                        return quota"},{"line_number":675,"context_line":"                    else:"},{"line_number":676,"context_line":"                        msg \u003d (_(\"Share %s does not support quota values \""},{"line_number":677,"context_line":"                                 \"below 1GB.\") % share_id)"},{"line_number":678,"context_line":"                        raise exception.HNASBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_7ed4bbea","line":675,"updated":"2015-09-18 13:56:08.000000000","message":"Are you certain you\u0027ll never see something like 1100 MB?  Because if you\u0027re not certain about that, it would be safer to process the number and units values into bytes and then compare to the 1 GB minimum.","commit_id":"dd77cf98c1018531d0e539e915b3421bd14fc3e8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3c9b295b1531ac20892e2fba99881d40736813db","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                        if size_unit \u003d\u003d \u0027TB\u0027:"},{"line_number":673,"context_line":"                            return quota * units.Ki"},{"line_number":674,"context_line":"                        return quota"},{"line_number":675,"context_line":"                    else:"},{"line_number":676,"context_line":"                        msg \u003d (_(\"Share %s does not support quota values \""},{"line_number":677,"context_line":"                                 \"below 1GB.\") % share_id)"},{"line_number":678,"context_line":"                        raise exception.HNASBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_cdcbdba2","line":675,"in_reply_to":"ba15a1d1_7ed4bbea","updated":"2015-09-18 15:29:50.000000000","message":"Hi Clinton, we tested here, below 1024 MB it returns as MB, and 1024 MB and above it returns as GB. It automatically converts, same for GB \u003d\u003e TB.","commit_id":"dd77cf98c1018531d0e539e915b3421bd14fc3e8"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"02bf1dcfd38d68d6d04e14404537462c31fd73b7","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                        if size_unit \u003d\u003d \u0027TB\u0027:"},{"line_number":673,"context_line":"                            return quota * units.Ki"},{"line_number":674,"context_line":"                        return quota"},{"line_number":675,"context_line":"                    else:"},{"line_number":676,"context_line":"                        msg \u003d (_(\"Share %s does not support quota values \""},{"line_number":677,"context_line":"                                 \"below 1GB.\") % share_id)"},{"line_number":678,"context_line":"                        raise exception.HNASBackendException(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_4df6eb5d","line":675,"in_reply_to":"ba15a1d1_cdcbdba2","updated":"2015-09-18 15:37:58.000000000","message":"OK, thanks, Rodrigo.","commit_id":"dd77cf98c1018531d0e539e915b3421bd14fc3e8"}]}