)]}'
{"manila_tempest_tests/config.py":[{"author":{"_account_id":14863,"name":"Diego Zamboni Latance","email":"dzambonil@gmail.com","username":"DiegoZamboni"},"change_message_id":"7ce751bf4adc417a6b4982e6546f1bc7aad7dd01","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               deprecated_name\u003d\"storage_protocol\","},{"line_number":86,"context_line":"               default\u003d\"NFS_CIFS\","},{"line_number":87,"context_line":"               help\u003d\"Backend protocol to target when creating volume types.\"),"},{"line_number":88,"context_line":"    cfg.BoolOpt(\"capability_snapshot_support\","},{"line_number":89,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end\""},{"line_number":90,"context_line":"                     \"capability called \u0027snapshot_support\u0027 and will be used \""},{"line_number":91,"context_line":"                     \"for setting up custom share type. Defaults to value of\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_ab36de4e","line":88,"updated":"2015-09-23 19:08:35.000000000","message":"Shouldn\u0027t you use \u0027default\u003dTrue\u0027 as in base.py snapshot_support used to be true?\n\nAlso, I think you\u0027re missing some spaces at the end of 2 lines in the help message below.","commit_id":"a8b1f2645fda1ad03ddd004e37d6ee19ed1b5d95"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"80ad65d6a91f8cd3c622f3fe96b4a6f04f45efa0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               deprecated_name\u003d\"storage_protocol\","},{"line_number":86,"context_line":"               default\u003d\"NFS_CIFS\","},{"line_number":87,"context_line":"               help\u003d\"Backend protocol to target when creating volume types.\"),"},{"line_number":88,"context_line":"    cfg.BoolOpt(\"capability_snapshot_support\","},{"line_number":89,"context_line":"                help\u003d\"Defines extra spec that satisfies specific back end\""},{"line_number":90,"context_line":"                     \"capability called \u0027snapshot_support\u0027 and will be used \""},{"line_number":91,"context_line":"                     \"for setting up custom share type. Defaults to value of\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_7fc2bc86","line":88,"in_reply_to":"ba15a1d1_ab36de4e","updated":"2015-09-23 20:45:47.000000000","message":"Base.py uses this opt, not fixed value anymore. Added missed spaces.","commit_id":"a8b1f2645fda1ad03ddd004e37d6ee19ed1b5d95"}],"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"94a4d6c48a86f8a4cebd22b74ee6991edb8c26b5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.st_name_invalid \u003d data_utils.rand_name(\"manage-st-name-invalid\")"},{"line_number":50,"context_line":"        cls.extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":52,"context_line":"            \u0027driver_handles_share_servers\u0027: False"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"        cls.extra_specs_invalid \u003d {"},{"line_number":55,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_6b7e77b0","line":52,"updated":"2015-09-24 04:00:55.000000000","message":"Here should add “snapshot_support” key","commit_id":"2dd6ee92d3e8614190bb1c268cc44eb96baca97e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"111b8766ab553291ff49ce1a2b52acc9314f7497","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.st_name_invalid \u003d data_utils.rand_name(\"manage-st-name-invalid\")"},{"line_number":50,"context_line":"        cls.extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":52,"context_line":"            \u0027driver_handles_share_servers\u0027: False"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"        cls.extra_specs_invalid \u003d {"},{"line_number":55,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_96968b4a","line":52,"in_reply_to":"ba15a1d1_6b7e77b0","updated":"2015-09-24 06:47:09.000000000","message":"It is added in base.py class using config option \"capability_snapshot_support\".\n\nAlso, do you know, why on failed run of Huawei CI logs are absent [1] ?\n\n[1] http://205.177.226.209:8088/huawei_manila_test/713/logs/","commit_id":"2dd6ee92d3e8614190bb1c268cc44eb96baca97e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"859f91b93851316341dc6f8bd6feab1dae37ef1e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.st_name_invalid \u003d data_utils.rand_name(\"manage-st-name-invalid\")"},{"line_number":50,"context_line":"        cls.extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":52,"context_line":"            \u0027driver_handles_share_servers\u0027: False"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"        cls.extra_specs_invalid \u003d {"},{"line_number":55,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_47bb5f0f","line":52,"in_reply_to":"ba15a1d1_8c275e11","updated":"2015-09-24 08:21:59.000000000","message":"Oh, you are completely right! Thanks!","commit_id":"2dd6ee92d3e8614190bb1c268cc44eb96baca97e"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"408e226e217e0ef2d5bd63f90783db5999a724d4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.st_name_invalid \u003d data_utils.rand_name(\"manage-st-name-invalid\")"},{"line_number":50,"context_line":"        cls.extra_specs \u003d {"},{"line_number":51,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":52,"context_line":"            \u0027driver_handles_share_servers\u0027: False"},{"line_number":53,"context_line":"        }"},{"line_number":54,"context_line":"        cls.extra_specs_invalid \u003d {"},{"line_number":55,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_8c275e11","line":52,"in_reply_to":"ba15a1d1_96968b4a","updated":"2015-09-24 08:04:35.000000000","message":"I see the change \"add_required_extra_specs_to_dict\" in base.py. But Here did not call it.\nI think you should add:\n\u0027snapshot_support\u0027: CONF.share.capability_snapshot_support","commit_id":"2dd6ee92d3e8614190bb1c268cc44eb96baca97e"},{"author":{"_account_id":14863,"name":"Diego Zamboni Latance","email":"dzambonil@gmail.com","username":"DiegoZamboni"},"change_message_id":"44dde54b7695c2e7e3a4a6859169733d7ab4d424","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.st_name \u003d data_utils.rand_name(\"manage-st-name\")"},{"line_number":50,"context_line":"        cls.st_name_invalid \u003d data_utils.rand_name(\"manage-st-name-invalid\")"},{"line_number":51,"context_line":"        cls.extra_specs \u003d {"},{"line_number":52,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":53,"context_line":"            \u0027driver_handles_share_servers\u0027: False,"},{"line_number":54,"context_line":"            \u0027snapshot_support\u0027: six.text_type("},{"line_number":55,"context_line":"                CONF.share.capability_snapshot_support),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_7dc10f80","line":52,"updated":"2015-09-24 14:17:18.000000000","message":"Since you added \u0027six\u0027, maybe you should use it here too?","commit_id":"29f2695eb9c615d258344bbc2a835e98940c6290"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fa1e23b413419e43be3e71bcafe5dcea616c1a1d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        cls.st_name \u003d data_utils.rand_name(\"manage-st-name\")"},{"line_number":50,"context_line":"        cls.st_name_invalid \u003d data_utils.rand_name(\"manage-st-name-invalid\")"},{"line_number":51,"context_line":"        cls.extra_specs \u003d {"},{"line_number":52,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":53,"context_line":"            \u0027driver_handles_share_servers\u0027: False,"},{"line_number":54,"context_line":"            \u0027snapshot_support\u0027: six.text_type("},{"line_number":55,"context_line":"                CONF.share.capability_snapshot_support),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_ddb5bbd0","line":52,"in_reply_to":"9a1a9d01_7dc10f80","updated":"2015-09-24 14:20:14.000000000","message":"\"capability_storage_protocol\" is string by default. \"capability_snapshot_support\" is boolean by deafult.","commit_id":"29f2695eb9c615d258344bbc2a835e98940c6290"},{"author":{"_account_id":14863,"name":"Diego Zamboni Latance","email":"dzambonil@gmail.com","username":"DiegoZamboni"},"change_message_id":"44dde54b7695c2e7e3a4a6859169733d7ab4d424","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                CONF.share.capability_snapshot_support),"},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":"        cls.extra_specs_invalid \u003d {"},{"line_number":58,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":59,"context_line":"            \u0027driver_handles_share_servers\u0027: True,"},{"line_number":60,"context_line":"            \u0027snapshot_support\u0027: six.text_type("},{"line_number":61,"context_line":"                CONF.share.capability_snapshot_support),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_1d5573c5","line":58,"updated":"2015-09-24 14:17:18.000000000","message":"And here","commit_id":"29f2695eb9c615d258344bbc2a835e98940c6290"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fa1e23b413419e43be3e71bcafe5dcea616c1a1d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                CONF.share.capability_snapshot_support),"},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":"        cls.extra_specs_invalid \u003d {"},{"line_number":58,"context_line":"            \u0027storage_protocol\u0027: CONF.share.capability_storage_protocol,"},{"line_number":59,"context_line":"            \u0027driver_handles_share_servers\u0027: True,"},{"line_number":60,"context_line":"            \u0027snapshot_support\u0027: six.text_type("},{"line_number":61,"context_line":"                CONF.share.capability_snapshot_support),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_bdb487d1","line":58,"in_reply_to":"9a1a9d01_1d5573c5","updated":"2015-09-24 14:20:14.000000000","message":"ditto","commit_id":"29f2695eb9c615d258344bbc2a835e98940c6290"}]}