)]}'
{"manila/scheduler/host_manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"337dd457eb2755690f591417fadd2e1c94031ee8","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if \u0027snapshot_support\u0027 not in pool_cap:"},{"line_number":282,"context_line":"            pool_cap[\u0027snapshot_support\u0027] \u003d self.snapshot_support"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if not pool_cap.get(\u0027consistency_group_support\u0027):"},{"line_number":285,"context_line":"            pool_cap[\u0027consistency_group_support\u0027] \u003d \\"},{"line_number":286,"context_line":"                self.consistency_group_support"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6e11b451","line":284,"updated":"2015-09-23 19:17:30.000000000","message":"Should not it be changed too?","commit_id":"8a34fb3890810330a9b8a2d659739d92134a832c"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f1e09c366627f4202c62c138d45778ea5de932eb","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if \u0027snapshot_support\u0027 not in pool_cap:"},{"line_number":282,"context_line":"            pool_cap[\u0027snapshot_support\u0027] \u003d self.snapshot_support"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if not pool_cap.get(\u0027consistency_group_support\u0027):"},{"line_number":285,"context_line":"            pool_cap[\u0027consistency_group_support\u0027] \u003d \\"},{"line_number":286,"context_line":"                self.consistency_group_support"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8122d952","line":284,"in_reply_to":"ba15a1d1_6e11b451","updated":"2015-09-23 19:43:53.000000000","message":"This one isn\u0027t a boolean.  It accepts values like \u0027host\u0027 or \u0027pool\u0027.  So changing it now isn\u0027t necessary.\n\nMy preference would be to maintain a list of fields that must be copied and simply iterate over that, but I\u0027m trying to make a surgical fix appropriate for a Liberty backport.","commit_id":"8a34fb3890810330a9b8a2d659739d92134a832c"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"33508b546ba77ac44ea7e0361818a32148d4981e","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        if \u0027snapshot_support\u0027 not in pool_cap:"},{"line_number":282,"context_line":"            pool_cap[\u0027snapshot_support\u0027] \u003d self.snapshot_support"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if not pool_cap.get(\u0027consistency_group_support\u0027):"},{"line_number":285,"context_line":"            pool_cap[\u0027consistency_group_support\u0027] \u003d \\"},{"line_number":286,"context_line":"                self.consistency_group_support"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_1f69408c","line":284,"in_reply_to":"ba15a1d1_8122d952","updated":"2015-09-23 20:47:15.000000000","message":"My preference is to copy everything from the host capabilities to the pools if the pools don\u0027t override the host capabilities.","commit_id":"8a34fb3890810330a9b8a2d659739d92134a832c"}]}
