)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"232f1a7302bc5b4447673454cab2a8db91f51613","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Varlamova \u003cjvarlamova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-09 05:00:33 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add LVM driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia46c51ed400dbb0f1d87a758fb165ca711ed3d7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a2ca52d_65ddcd13","line":7,"updated":"2015-10-14 00:44:42.000000000","message":"Can you add some descriptions on what is the purpose of this patch?  Is there a blueprint?","commit_id":"16db587dead1914d31598b0582235ff4ffc1a62f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"a5e37b071f8b41631cbf7cb21b13398434469777","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Varlamova \u003cjvarlamova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-09 05:00:33 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add LVM driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia46c51ed400dbb0f1d87a758fb165ca711ed3d7c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_23fd623a","line":7,"in_reply_to":"5a2ca52d_65ddcd13","updated":"2015-10-20 08:19:12.000000000","message":"Done","commit_id":"16db587dead1914d31598b0582235ff4ffc1a62f"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"DRIVER_GROUPS\u003d$(iniget $MANILA_CONF DEFAULT enabled_share_backends)"},{"line_number":135,"context_line":"for driver_group in ${DRIVER_GROUPS//,/ }; do"},{"line_number":136,"context_line":"    if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]]; then"},{"line_number":137,"context_line":"        SHARE_DRIVER\u003d\u0027manila.share.drivers.LVMShareDriver\u0027"},{"line_number":138,"context_line":"    else"},{"line_number":139,"context_line":"        SHARE_DRIVER\u003d$(iniget $MANILA_CONF $driver_group share_driver)"},{"line_number":140,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"da85f559_dfbea7d3","line":137,"updated":"2015-11-10 12:23:26.000000000","message":"1) Incorrect path to driver.\n\n2) This part is required only by Generic driver.","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"DRIVER_GROUPS\u003d$(iniget $MANILA_CONF DEFAULT enabled_share_backends)"},{"line_number":135,"context_line":"for driver_group in ${DRIVER_GROUPS//,/ }; do"},{"line_number":136,"context_line":"    if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]]; then"},{"line_number":137,"context_line":"        SHARE_DRIVER\u003d\u0027manila.share.drivers.LVMShareDriver\u0027"},{"line_number":138,"context_line":"    else"},{"line_number":139,"context_line":"        SHARE_DRIVER\u003d$(iniget $MANILA_CONF $driver_group share_driver)"},{"line_number":140,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"da85f559_5e66bd51","line":137,"updated":"2015-11-12 12:27:11.000000000","message":"Not addressed comment from previous patch-set: https://review.openstack.org/#/c/232970/7/contrib/ci/post_test_hook.sh","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":134,"context_line":"DRIVER_GROUPS\u003d$(iniget $MANILA_CONF DEFAULT enabled_share_backends)"},{"line_number":135,"context_line":"for driver_group in ${DRIVER_GROUPS//,/ }; do"},{"line_number":136,"context_line":"    if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]]; then"},{"line_number":137,"context_line":"        SHARE_DRIVER\u003d\u0027manila.share.drivers.LVMShareDriver\u0027"},{"line_number":138,"context_line":"    else"},{"line_number":139,"context_line":"        SHARE_DRIVER\u003d$(iniget $MANILA_CONF $driver_group share_driver)"},{"line_number":140,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba8a016a_6a855805","line":137,"in_reply_to":"da85f559_5e66bd51","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    export RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":44,"context_line":"    export RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":45,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share run_shrink_tests False"},{"line_number":46,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_ip_rules_for_protocols \u0027[\"nfs\", ]\u0027"},{"line_number":47,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_user_rules_for_protocols \u0027[\"cifs\", ]\u0027"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"ba8a016a_b00e7be3","line":46,"updated":"2015-11-23 16:01:28.000000000","message":"\u0027nfs\u0027","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"45818250cae77505db46bb1235e7b511b3f323e8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    export RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":44,"context_line":"    export RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":45,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share run_shrink_tests False"},{"line_number":46,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_ip_rules_for_protocols \u0027[\"nfs\", ]\u0027"},{"line_number":47,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_user_rules_for_protocols \u0027[\"cifs\", ]\u0027"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"9a8ffd7b_32c50e5b","line":46,"in_reply_to":"ba8a016a_b00e7be3","updated":"2015-11-24 13:20:26.000000000","message":"Done","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    export RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":45,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share run_shrink_tests False"},{"line_number":46,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_ip_rules_for_protocols \u0027[\"nfs\", ]\u0027"},{"line_number":47,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_user_rules_for_protocols \u0027[\"cifs\", ]\u0027"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"ba8a016a_30036bba","line":47,"updated":"2015-11-23 16:01:28.000000000","message":"\u0027cifs\u0027","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"45818250cae77505db46bb1235e7b511b3f323e8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    export RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":45,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share run_shrink_tests False"},{"line_number":46,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_ip_rules_for_protocols \u0027[\"nfs\", ]\u0027"},{"line_number":47,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share enable_user_rules_for_protocols \u0027[\"cifs\", ]\u0027"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"9a8ffd7b_f2a546b5","line":47,"in_reply_to":"ba8a016a_30036bba","updated":"2015-11-24 13:20:26.000000000","message":"Done","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"USERNAME_FOR_USER_RULES\u003d${USERNAME_FOR_USER_RULES:-\"Administrator\"}"},{"line_number":43,"context_line":"PASSWORD_FOR_SAMBA_USER\u003d${PASSWORD_FOR_SAMBA_USER:-$USERNAME_FOR_USER_RULES}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]] || [[ \"$JOB_NAME\" \u003d~ \"lvm\" ]]; then"},{"line_number":46,"context_line":"    export RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":47,"context_line":"    export RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":48,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share run_shrink_tests False"}],"source_content_type":"text/x-sh","patch_set":31,"id":"9a8ffd7b_28152448","line":45,"updated":"2015-12-02 11:16:50.000000000","message":"Block with job related things is located starting with line number 123.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":42,"context_line":"USERNAME_FOR_USER_RULES\u003d${USERNAME_FOR_USER_RULES:-\"Administrator\"}"},{"line_number":43,"context_line":"PASSWORD_FOR_SAMBA_USER\u003d${PASSWORD_FOR_SAMBA_USER:-$USERNAME_FOR_USER_RULES}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]] || [[ \"$JOB_NAME\" \u003d~ \"lvm\" ]]; then"},{"line_number":46,"context_line":"    export RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":47,"context_line":"    export RUN_MANILA_MANAGE_TESTS\u003dFalse"},{"line_number":48,"context_line":"    iniset $BASE/new/tempest/etc/tempest.conf share run_shrink_tests False"}],"source_content_type":"text/x-sh","patch_set":31,"id":"9a8ffd7b_a255b01e","line":45,"in_reply_to":"9a8ffd7b_28152448","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"lvm\"  ]]; then"},{"line_number":143,"context_line":"    # Using approach without handling of share servers we have bigger load for"},{"line_number":144,"context_line":"    # volume creation in Cinder using Generic driver. So, reduce amount of"},{"line_number":145,"context_line":"    # threads to avoid errors for Cinder volume creations that appear"},{"line_number":146,"context_line":"    # because of lack of free space."},{"line_number":147,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":148,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":149,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"}],"source_content_type":"text/x-sh","patch_set":49,"id":"da6ed579_2c442919","line":146,"range":{"start_line":143,"start_character":6,"end_line":146,"end_character":36},"updated":"2016-01-14 15:51:11.000000000","message":"Copy-paste from Generic driver specific things.","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":140,"context_line":"fi"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"if [[ \"$DRIVER\" \u003d\u003d \"lvm\"  ]]; then"},{"line_number":143,"context_line":"    # Using approach without handling of share servers we have bigger load for"},{"line_number":144,"context_line":"    # volume creation in Cinder using Generic driver. So, reduce amount of"},{"line_number":145,"context_line":"    # threads to avoid errors for Cinder volume creations that appear"},{"line_number":146,"context_line":"    # because of lack of free space."},{"line_number":147,"context_line":"    MANILA_TEMPEST_CONCURRENCY\u003d8"},{"line_number":148,"context_line":"    RUN_MANILA_CG_TESTS\u003dFalse"},{"line_number":149,"context_line":"    RUN_MANILA_MANAGE_TESTS\u003dFalse"}],"source_content_type":"text/x-sh","patch_set":49,"id":"da6ed579_9a72997b","line":146,"range":{"start_line":143,"start_character":6,"end_line":146,"end_character":36},"in_reply_to":"da6ed579_2c442919","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4793836e6c0d94c1729bb60c5cfdea41660dc35b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    echo \"MANILA_MULTI_BACKEND\u003dFalse\" \u003e\u003e $localrc_path"},{"line_number":51,"context_line":"fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]]; then"},{"line_number":54,"context_line":"    echo \"SHARE_DRIVER\u003dmanila.share.drivers.lvm.LVMShareDriver\" \u003e\u003e $localrc_path"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"ba8a016a_0f9c1e5c","line":53,"updated":"2015-11-23 10:40:53.000000000","message":"Reminder - it is temporary approach until we get separate CI job for LVM driver.","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"fc986e297c9df09eaeb589c55687a0b89f8d6ac0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    echo \"MANILA_MULTI_BACKEND\u003dFalse\" \u003e\u003e $localrc_path"},{"line_number":51,"context_line":"fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"if [[ \"$JOB_NAME\" \u003d~ \"no-share-servers\" ]]; then"},{"line_number":54,"context_line":"    echo \"SHARE_DRIVER\u003dmanila.share.drivers.lvm.LVMShareDriver\" \u003e\u003e $localrc_path"},{"line_number":55,"context_line":"fi"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a8ffd7b_03875e62","line":53,"in_reply_to":"ba8a016a_0f9c1e5c","updated":"2015-11-24 13:20:10.000000000","message":"Yes, thanks for reminding!","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"}],"devstack/plugin.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"#configure_samba - Configure node as Samba server"},{"line_number":577,"context_line":"function configure_samba {"},{"line_number":578,"context_line":"    sudo cp /usr/share/samba/smb.conf $SMB_CONF"},{"line_number":579,"context_line":"    iniset $SMB_CONF global include registry"},{"line_number":580,"context_line":"    if [ ! -d \"$SMB_PRIVATE_DIR\" ]; then"},{"line_number":581,"context_line":"        sudo mkdir $SMB_PRIVATE_DIR"}],"source_content_type":"text/x-sh","patch_set":8,"id":"da85f559_4902850b","line":578,"updated":"2015-11-12 12:27:11.000000000","message":"This should be done only if LVM driver is used.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":575,"context_line":""},{"line_number":576,"context_line":"#configure_samba - Configure node as Samba server"},{"line_number":577,"context_line":"function configure_samba {"},{"line_number":578,"context_line":"    sudo cp /usr/share/samba/smb.conf $SMB_CONF"},{"line_number":579,"context_line":"    iniset $SMB_CONF global include registry"},{"line_number":580,"context_line":"    if [ ! -d \"$SMB_PRIVATE_DIR\" ]; then"},{"line_number":581,"context_line":"        sudo mkdir $SMB_PRIVATE_DIR"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba8a016a_872d1500","line":578,"in_reply_to":"da85f559_4902850b","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":586,"context_line":"# start_manila - Start running processes, including screen"},{"line_number":587,"context_line":"function start_manila {"},{"line_number":588,"context_line":"    samba_daemon_name\u003dsmbd"},{"line_number":589,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":590,"context_line":"        if is_fedora; then"},{"line_number":591,"context_line":"            samba_daemon_name\u003dsmb"},{"line_number":592,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"da85f559_de0aad25","line":589,"updated":"2015-11-12 12:27:11.000000000","message":"This should be done only if LVM driver is used.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":586,"context_line":"# start_manila - Start running processes, including screen"},{"line_number":587,"context_line":"function start_manila {"},{"line_number":588,"context_line":"    samba_daemon_name\u003dsmbd"},{"line_number":589,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":590,"context_line":"        if is_fedora; then"},{"line_number":591,"context_line":"            samba_daemon_name\u003dsmb"},{"line_number":592,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba8a016a_a732995d","line":589,"in_reply_to":"da85f559_de0aad25","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4793836e6c0d94c1729bb60c5cfdea41660dc35b","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            sudo touch $SMB_PRIVATE_DIR/secrets.tdb"},{"line_number":593,"context_line":"        fi"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        for group_name in $MANILA_BACKEND1_CONFIG_GROUP_NAME $MANILA_BACKEND2_CONFIG_GROUP_NAME; do"},{"line_number":596,"context_line":"            iniset $MANILA_CONF $group_name driver_handles_share_servers False"},{"line_number":597,"context_line":"            iniset $MANILA_CONF $group_name share_export_ip $MANILA_SERVICE_HOST"},{"line_number":598,"context_line":"        done"}],"source_content_type":"text/x-sh","patch_set":14,"id":"ba8a016a_cfe29601","line":595,"updated":"2015-11-23 10:40:53.000000000","message":"It is incorrect way to loop back-ends. see example on line 385.","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"fc986e297c9df09eaeb589c55687a0b89f8d6ac0","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            sudo touch $SMB_PRIVATE_DIR/secrets.tdb"},{"line_number":593,"context_line":"        fi"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        for group_name in $MANILA_BACKEND1_CONFIG_GROUP_NAME $MANILA_BACKEND2_CONFIG_GROUP_NAME; do"},{"line_number":596,"context_line":"            iniset $MANILA_CONF $group_name driver_handles_share_servers False"},{"line_number":597,"context_line":"            iniset $MANILA_CONF $group_name share_export_ip $MANILA_SERVICE_HOST"},{"line_number":598,"context_line":"        done"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a8ffd7b_92e71aac","line":595,"in_reply_to":"ba8a016a_cfe29601","updated":"2015-11-24 13:20:10.000000000","message":"Done","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            sudo touch $SMB_PRIVATE_DIR/secrets.tdb"},{"line_number":594,"context_line":"        fi"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        for group_name in $MANILA_BACKEND1_CONFIG_GROUP_NAME $MANILA_BACKEND2_CONFIG_GROUP_NAME; do"},{"line_number":597,"context_line":"            iniset $MANILA_CONF $group_name driver_handles_share_servers False"},{"line_number":598,"context_line":"            iniset $MANILA_CONF $group_name share_export_ip $MANILA_SERVICE_HOST"},{"line_number":599,"context_line":"        done"}],"source_content_type":"text/x-sh","patch_set":15,"id":"ba8a016a_90c9f77b","line":596,"updated":"2015-11-23 16:01:28.000000000","message":"Comment for this line from previous patch-set is not addressed.","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"45818250cae77505db46bb1235e7b511b3f323e8","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            sudo touch $SMB_PRIVATE_DIR/secrets.tdb"},{"line_number":594,"context_line":"        fi"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        for group_name in $MANILA_BACKEND1_CONFIG_GROUP_NAME $MANILA_BACKEND2_CONFIG_GROUP_NAME; do"},{"line_number":597,"context_line":"            iniset $MANILA_CONF $group_name driver_handles_share_servers False"},{"line_number":598,"context_line":"            iniset $MANILA_CONF $group_name share_export_ip $MANILA_SERVICE_HOST"},{"line_number":599,"context_line":"        done"}],"source_content_type":"text/x-sh","patch_set":15,"id":"9a8ffd7b_c3807649","line":596,"in_reply_to":"ba8a016a_90c9f77b","updated":"2015-11-24 13:20:26.000000000","message":"Done","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"MANILA_CONF\u003d$MANILA_CONF_DIR/manila.conf"},{"line_number":56,"context_line":"MANILA_API_PASTE_INI\u003d$MANILA_CONF_DIR/api-paste.ini"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"SMB_CONF\u003d${SMB_CONF:-/etc/samba/smb.conf}"},{"line_number":59,"context_line":"SMB_PRIVATE_DIR\u003d${SMB_PRIVATE_DIR:-/var/lib/samba/private}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"MANILA_DEFAULT_SHARE_TYPE\u003d${MANILA_DEFAULT_SHARE_TYPE:-default}"}],"source_content_type":"text/x-sh","patch_set":31,"id":"9a8ffd7b_834bd358","line":58,"updated":"2015-12-02 11:16:50.000000000","message":"Please, define all \"LVM\" driver related opts in one place and add note for it that they are related only for LVM driver.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":55,"context_line":"MANILA_CONF\u003d$MANILA_CONF_DIR/manila.conf"},{"line_number":56,"context_line":"MANILA_API_PASTE_INI\u003d$MANILA_CONF_DIR/api-paste.ini"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"SMB_CONF\u003d${SMB_CONF:-/etc/samba/smb.conf}"},{"line_number":59,"context_line":"SMB_PRIVATE_DIR\u003d${SMB_PRIVATE_DIR:-/var/lib/samba/private}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"MANILA_DEFAULT_SHARE_TYPE\u003d${MANILA_DEFAULT_SHARE_TYPE:-default}"}],"source_content_type":"text/x-sh","patch_set":31,"id":"9a8ffd7b_93bc7cbc","line":58,"in_reply_to":"9a8ffd7b_834bd358","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        # By default, the backing file is 8G in size, and is stored in ``/opt/stack/data``."},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if ! sudo vgs $SHARE_GROUP; then"},{"line_number":541,"context_line":"            SHARE_BACKING_FILE\u003d${SHARE_BACKING_FILE:-$DATA_DIR/${SHARE_GROUP}-backing-file}"},{"line_number":542,"context_line":"            # Only create if the file doesn\u0027t already exists"},{"line_number":543,"context_line":"            [[ -f $SHARE_BACKING_FILE ]] || truncate -s $SHARE_BACKING_FILE_SIZE $SHARE_BACKING_FILE"},{"line_number":544,"context_line":"            DEV\u003d`sudo losetup -f --show $SHARE_BACKING_FILE`"}],"source_content_type":"text/x-sh","patch_set":31,"id":"9a8ffd7b_63ecaf29","line":541,"updated":"2015-12-02 11:16:50.000000000","message":"It should not be configured always. it should be possible to disable it.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        # By default, the backing file is 8G in size, and is stored in ``/opt/stack/data``."},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        if ! sudo vgs $SHARE_GROUP; then"},{"line_number":541,"context_line":"            SHARE_BACKING_FILE\u003d${SHARE_BACKING_FILE:-$DATA_DIR/${SHARE_GROUP}-backing-file}"},{"line_number":542,"context_line":"            # Only create if the file doesn\u0027t already exists"},{"line_number":543,"context_line":"            [[ -f $SHARE_BACKING_FILE ]] || truncate -s $SHARE_BACKING_FILE_SIZE $SHARE_BACKING_FILE"},{"line_number":544,"context_line":"            DEV\u003d`sudo losetup -f --show $SHARE_BACKING_FILE`"}],"source_content_type":"text/x-sh","patch_set":31,"id":"9a8ffd7b_73bb18e6","line":541,"in_reply_to":"9a8ffd7b_63ecaf29","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9da23c311329b8830917679d82aa176cd3ce94d6","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        #"},{"line_number":409,"context_line":"        # By default, the backing file is 8G in size, and is stored in ``/opt/stack/data``."},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        if ! sudo vgs $SHARE_GROUP; then"},{"line_number":412,"context_line":"            if [ \"$CONFIGURE_BACKING_FILE\" \u003d \"True\" ]; then"},{"line_number":413,"context_line":"                SHARE_BACKING_FILE\u003d${SHARE_BACKING_FILE:-$DATA_DIR/${SHARE_GROUP}-backing-file}"},{"line_number":414,"context_line":"                # Only create if the file doesn\u0027t already exists"}],"source_content_type":"text/x-sh","patch_set":44,"id":"fa69d971_1959a2fe","line":411,"range":{"start_line":411,"start_character":36,"end_line":411,"end_character":40},"updated":"2016-01-04 19:30:53.000000000","message":"I don\u0027t think our devstack plugin should do this for non-LVM. Could you check some conf setting and only do this for LVM?","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        #"},{"line_number":409,"context_line":"        # By default, the backing file is 8G in size, and is stored in ``/opt/stack/data``."},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        if ! sudo vgs $SHARE_GROUP; then"},{"line_number":412,"context_line":"            if [ \"$CONFIGURE_BACKING_FILE\" \u003d \"True\" ]; then"},{"line_number":413,"context_line":"                SHARE_BACKING_FILE\u003d${SHARE_BACKING_FILE:-$DATA_DIR/${SHARE_GROUP}-backing-file}"},{"line_number":414,"context_line":"                # Only create if the file doesn\u0027t already exists"}],"source_content_type":"text/x-sh","patch_set":44,"id":"fa69d971_aa1ecb09","line":411,"range":{"start_line":411,"start_character":36,"end_line":411,"end_character":40},"in_reply_to":"fa69d971_1959a2fe","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9da23c311329b8830917679d82aa176cd3ce94d6","unresolved":false,"context_lines":[{"line_number":434,"context_line":"function install_manila {"},{"line_number":435,"context_line":"    git_clone $MANILACLIENT_REPO $MANILACLIENT_DIR $MANILACLIENT_BRANCH"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":438,"context_line":"        if is_ubuntu; then"},{"line_number":439,"context_line":"            sudo apt-get install -y nfs-kernel-server nfs-common samba"},{"line_number":440,"context_line":"        elif is_fedora; then"}],"source_content_type":"text/x-sh","patch_set":44,"id":"fa69d971_f96e0e95","line":437,"range":{"start_line":437,"start_character":33,"end_line":437,"end_character":37},"updated":"2016-01-04 19:30:53.000000000","message":"and here.  Probably not a good idea to install extra stuff by default. Only do it when needed (for LVM)","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":434,"context_line":"function install_manila {"},{"line_number":435,"context_line":"    git_clone $MANILACLIENT_REPO $MANILACLIENT_DIR $MANILACLIENT_BRANCH"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":438,"context_line":"        if is_ubuntu; then"},{"line_number":439,"context_line":"            sudo apt-get install -y nfs-kernel-server nfs-common samba"},{"line_number":440,"context_line":"        elif is_fedora; then"}],"source_content_type":"text/x-sh","patch_set":44,"id":"fa69d971_6a1453e8","line":437,"range":{"start_line":437,"start_character":33,"end_line":437,"end_character":37},"in_reply_to":"fa69d971_f96e0e95","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"9da23c311329b8830917679d82aa176cd3ce94d6","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    create_service_share_servers"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    echo_summary \"Configure Samba server\""},{"line_number":566,"context_line":"    configure_samba"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    echo_summary \"Starting Manila\""},{"line_number":569,"context_line":"    start_manila"}],"source_content_type":"text/x-sh","patch_set":44,"id":"fa69d971_79d77e23","line":566,"range":{"start_line":566,"start_character":4,"end_line":566,"end_character":19},"updated":"2016-01-04 19:30:53.000000000","message":"Same here. Might be handy, but I think devstack should only add this for LVM, for now.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    create_service_share_servers"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    echo_summary \"Configure Samba server\""},{"line_number":566,"context_line":"    configure_samba"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    echo_summary \"Starting Manila\""},{"line_number":569,"context_line":"    start_manila"}],"source_content_type":"text/x-sh","patch_set":44,"id":"fa69d971_aacc8b89","line":566,"range":{"start_line":566,"start_character":4,"end_line":566,"end_character":19},"in_reply_to":"fa69d971_79d77e23","updated":"2016-01-13 15:09:45.000000000","message":"Already done at line 453.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    iniset $MANILA_CONF DEFAULT wsgi_keep_alive False"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    iniset $MANILA_CONF DEFAULT share_volume_group $SHARE_GROUP"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    if [ \"$SHARE_DRIVER\" \u003d\u003d \"manila.share.drivers.lvm.LVMShareDriver\" ]; then"},{"line_number":189,"context_line":"        iniset $MANILA_CONF DEFAULT lvm_share_volume_group $SHARE_GROUP"}],"source_content_type":"text/x-sh","patch_set":49,"id":"da6ed579_8c8e7577","line":186,"range":{"start_line":186,"start_character":32,"end_line":186,"end_character":50},"updated":"2016-01-14 15:51:11.000000000","message":"Why two options are used for same thing? \"share_volume_group\" and \"lvm_share_volume_group\"?","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    iniset $MANILA_CONF DEFAULT wsgi_keep_alive False"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    iniset $MANILA_CONF DEFAULT share_volume_group $SHARE_GROUP"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    if [ \"$SHARE_DRIVER\" \u003d\u003d \"manila.share.drivers.lvm.LVMShareDriver\" ]; then"},{"line_number":189,"context_line":"        iniset $MANILA_CONF DEFAULT lvm_share_volume_group $SHARE_GROUP"}],"source_content_type":"text/x-sh","patch_set":49,"id":"da6ed579_ba6d1d9b","line":186,"range":{"start_line":186,"start_character":32,"end_line":186,"end_character":50},"in_reply_to":"da6ed579_8c8e7577","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"daaa2c33edd886cb64f44efcf222b587dab28d5c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# cleanup_manila - Remove residual data files, anything left over from previous"},{"line_number":42,"context_line":"# runs that a clean run would need to clean up"},{"line_number":43,"context_line":"function cleanup_manila {"},{"line_number":44,"context_line":"    # This is placeholder."},{"line_number":45,"context_line":"    # All stuff, that are created by Generic driver will be cleaned up by other services."},{"line_number":46,"context_line":"    :"},{"line_number":47,"context_line":"    _clean_share_group $SHARE_GROUP $SHARE_NAME_PREFIX"}],"source_content_type":"text/x-sh","patch_set":55,"id":"9a68dd71_ca1163b1","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":26},"updated":"2016-01-20 13:26:21.000000000","message":"It is not placeholder anymore. So, line 44 should be removed. As well as line 46.","commit_id":"4ea2eef732d871f16f130356bbd3a39214787b37"}],"etc/manila/rootwrap.d/share.filters":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"cp: CommandFilter, cp, root"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# manila/utils.py : \u0027chown\u0027, \u0027%s\u0027, \u0027%s\u0027"},{"line_number":8,"context_line":"chown: CommandFilter, chown, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da85f559_0940fd05","line":5,"updated":"2015-11-12 12:27:11.000000000","message":"Already exists on line 106","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"cp: CommandFilter, cp, root"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# manila/utils.py : \u0027chown\u0027, \u0027%s\u0027, \u0027%s\u0027"},{"line_number":8,"context_line":"chown: CommandFilter, chown, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba8a016a_dd824f00","line":5,"in_reply_to":"da85f559_0940fd05","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"mkfs.ext4: CommandFilter, /sbin/mkfs.ext4, root"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# manila/share/drivers/lvm.py: \u0027exportfs\u0027, ..."},{"line_number":16,"context_line":"exportfs: CommandFilter, /usr/sbin/exportfs, root"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# manila/share/drivers/lvm.py: \u0027smbd\u0027, \u0027-s\u0027, \u0027%s\u0027, \u0027-D\u0027"},{"line_number":19,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da85f559_e9701974","line":16,"updated":"2015-11-12 12:27:11.000000000","message":"Already exists on line 95.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":13,"context_line":"mkfs.ext4: CommandFilter, /sbin/mkfs.ext4, root"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# manila/share/drivers/lvm.py: \u0027exportfs\u0027, ..."},{"line_number":16,"context_line":"exportfs: CommandFilter, /usr/sbin/exportfs, root"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# manila/share/drivers/lvm.py: \u0027smbd\u0027, \u0027-s\u0027, \u0027%s\u0027, \u0027-D\u0027"},{"line_number":19,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba8a016a_fd85d306","line":16,"in_reply_to":"da85f559_e9701974","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# manila/share/drivers/lvm.py: \u0027umount\u0027, \u0027-f\u0027, \u0027%s\u0027"},{"line_number":22,"context_line":"umount: CommandFilter, /bin/umount, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# manila/share/drivers/lvm.py: \u0027mount\u0027, \u0027/dev/mapper/%s\u0027, \u0027%s\u0027"},{"line_number":25,"context_line":"mount: CommandFilter, /bin/mount, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da85f559_8902adb2","line":22,"updated":"2015-11-12 12:27:11.000000000","message":"Already exists on line 71.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":19,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# manila/share/drivers/lvm.py: \u0027umount\u0027, \u0027-f\u0027, \u0027%s\u0027"},{"line_number":22,"context_line":"umount: CommandFilter, /bin/umount, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# manila/share/drivers/lvm.py: \u0027mount\u0027, \u0027/dev/mapper/%s\u0027, \u0027%s\u0027"},{"line_number":25,"context_line":"mount: CommandFilter, /bin/mount, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba8a016a_9d7da71e","line":22,"in_reply_to":"da85f559_8902adb2","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"umount: CommandFilter, /bin/umount, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# manila/share/drivers/lvm.py: \u0027mount\u0027, \u0027/dev/mapper/%s\u0027, \u0027%s\u0027"},{"line_number":25,"context_line":"mount: CommandFilter, /bin/mount, root"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# manila/share/drivers/lvm.py: \u0027chmod\u0027, \u0027777\u0027, \u0027%s\u0027"},{"line_number":28,"context_line":"chmod: CommandFilter, /bin/chmod, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da85f559_c923d554","line":25,"updated":"2015-11-12 12:27:11.000000000","message":"line 54","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":22,"context_line":"umount: CommandFilter, /bin/umount, root"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# manila/share/drivers/lvm.py: \u0027mount\u0027, \u0027/dev/mapper/%s\u0027, \u0027%s\u0027"},{"line_number":25,"context_line":"mount: CommandFilter, /bin/mount, root"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# manila/share/drivers/lvm.py: \u0027chmod\u0027, \u0027777\u0027, \u0027%s\u0027"},{"line_number":28,"context_line":"chmod: CommandFilter, /bin/chmod, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba8a016a_bd78ab2c","line":25,"in_reply_to":"da85f559_c923d554","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"mount: CommandFilter, /bin/mount, root"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# manila/share/drivers/lvm.py: \u0027chmod\u0027, \u0027777\u0027, \u0027%s\u0027"},{"line_number":28,"context_line":"chmod: CommandFilter, /bin/chmod, root"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# manila/share/drivers/lvm.py: \u0027chown\u0027, \u0027nobody\u0027, \u0027-R\u0027, \u0027%s\u0027"},{"line_number":31,"context_line":"chown: CommandFilter, /bin/chown, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da85f559_89f06dca","line":28,"updated":"2015-11-12 12:27:11.000000000","message":"112","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":25,"context_line":"mount: CommandFilter, /bin/mount, root"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# manila/share/drivers/lvm.py: \u0027chmod\u0027, \u0027777\u0027, \u0027%s\u0027"},{"line_number":28,"context_line":"chmod: CommandFilter, /bin/chmod, root"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# manila/share/drivers/lvm.py: \u0027chown\u0027, \u0027nobody\u0027, \u0027-R\u0027, \u0027%s\u0027"},{"line_number":31,"context_line":"chown: CommandFilter, /bin/chown, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba8a016a_7d72434b","line":28,"in_reply_to":"da85f559_89f06dca","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"chmod: CommandFilter, /bin/chmod, root"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# manila/share/drivers/lvm.py: \u0027chown\u0027, \u0027nobody\u0027, \u0027-R\u0027, \u0027%s\u0027"},{"line_number":31,"context_line":"chown: CommandFilter, /bin/chown, root"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# manila/share/drivers/lvm.py: \u0027pkill\u0027, \u0027-HUP\u0027, \u0027smbd\u0027"},{"line_number":34,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"da85f559_09b31d0b","line":31,"updated":"2015-11-12 12:27:11.000000000","message":"8","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":28,"context_line":"chmod: CommandFilter, /bin/chmod, root"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# manila/share/drivers/lvm.py: \u0027chown\u0027, \u0027nobody\u0027, \u0027-R\u0027, \u0027%s\u0027"},{"line_number":31,"context_line":"chown: CommandFilter, /bin/chown, root"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# manila/share/drivers/lvm.py: \u0027pkill\u0027, \u0027-HUP\u0027, \u0027smbd\u0027"},{"line_number":34,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba8a016a_1d90d742","line":31,"in_reply_to":"da85f559_09b31d0b","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4793836e6c0d94c1729bb60c5cfdea41660dc35b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"mkfs.ext4: CommandFilter, /sbin/mkfs.ext4, root"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# manila/share/drivers/lvm.py: \u0027smbd\u0027, \u0027-s\u0027, \u0027%s\u0027, \u0027-D\u0027"},{"line_number":14,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# manila/share/drivers/lvm.py: \u0027rmdir\u0027, \u0027%s\u0027"},{"line_number":17,"context_line":"rmdir: CommandFilter, /bin/rmdir, root"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"ba8a016a_cf6376dc","line":14,"updated":"2015-11-23 10:40:53.000000000","message":"It is ubuntu-specific. Other possible variant - \"smb\".","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"fc986e297c9df09eaeb589c55687a0b89f8d6ac0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"mkfs.ext4: CommandFilter, /sbin/mkfs.ext4, root"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# manila/share/drivers/lvm.py: \u0027smbd\u0027, \u0027-s\u0027, \u0027%s\u0027, \u0027-D\u0027"},{"line_number":14,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# manila/share/drivers/lvm.py: \u0027rmdir\u0027, \u0027%s\u0027"},{"line_number":17,"context_line":"rmdir: CommandFilter, /bin/rmdir, root"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a8ffd7b_4348065c","line":14,"in_reply_to":"ba8a016a_cf6376dc","updated":"2015-11-24 13:20:10.000000000","message":"Done","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4793836e6c0d94c1729bb60c5cfdea41660dc35b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"rmdir: CommandFilter, /bin/rmdir, root"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# manila/share/drivers/lvm.py: \u0027pkill\u0027, \u0027-HUP\u0027, \u0027smbd\u0027"},{"line_number":20,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# manila/share/drivers/lvm.py: \u0027smbcontrol\u0027, \u0027all\u0027, \u0027close-share\u0027, \u0027%s\u0027"},{"line_number":23,"context_line":"smbcontrol: CommandFilter, /usr/bin/smbcontrol, root"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"ba8a016a_efa43a09","line":20,"updated":"2015-11-23 10:40:53.000000000","message":"\"pkill\" is not used in manila/share/drivers/lvm.py","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"fc986e297c9df09eaeb589c55687a0b89f8d6ac0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"rmdir: CommandFilter, /bin/rmdir, root"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# manila/share/drivers/lvm.py: \u0027pkill\u0027, \u0027-HUP\u0027, \u0027smbd\u0027"},{"line_number":20,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# manila/share/drivers/lvm.py: \u0027smbcontrol\u0027, \u0027all\u0027, \u0027close-share\u0027, \u0027%s\u0027"},{"line_number":23,"context_line":"smbcontrol: CommandFilter, /usr/bin/smbcontrol, root"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a8ffd7b_b816bd53","line":20,"in_reply_to":"ba8a016a_efa43a09","updated":"2015-11-24 13:20:10.000000000","message":"Done","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4793836e6c0d94c1729bb60c5cfdea41660dc35b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# manila/share/drivers/lvm.py: \u0027smbcontrol\u0027, \u0027all\u0027, \u0027close-share\u0027, \u0027%s\u0027"},{"line_number":23,"context_line":"smbcontrol: CommandFilter, /usr/bin/smbcontrol, root"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027addshare\u0027, \u0027%s\u0027, \u0027%s\u0027, \u0027writeable\u003dy\u0027, \u0027guest_ok\u003dy"},{"line_number":26,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027delshare\u0027, \u0027%s\u0027"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"ba8a016a_2f824253","line":23,"updated":"2015-11-23 10:40:53.000000000","message":"\"smbcontrol\" is not used in manila/share/drivers/lvm.py","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"fc986e297c9df09eaeb589c55687a0b89f8d6ac0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# manila/share/drivers/lvm.py: \u0027smbcontrol\u0027, \u0027all\u0027, \u0027close-share\u0027, \u0027%s\u0027"},{"line_number":23,"context_line":"smbcontrol: CommandFilter, /usr/bin/smbcontrol, root"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027addshare\u0027, \u0027%s\u0027, \u0027%s\u0027, \u0027writeable\u003dy\u0027, \u0027guest_ok\u003dy"},{"line_number":26,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027delshare\u0027, \u0027%s\u0027"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a8ffd7b_580c7142","line":23,"in_reply_to":"ba8a016a_2f824253","updated":"2015-11-24 13:20:10.000000000","message":"Done","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4793836e6c0d94c1729bb60c5cfdea41660dc35b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027delshare\u0027, \u0027%s\u0027"},{"line_number":27,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027setparm\u0027, \u0027%s\u0027, \u0027%s\u0027, \u0027%s\u0027"},{"line_number":28,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027getparm\u0027, \u0027%s\u0027, \u0027hosts allow\u0027"},{"line_number":29,"context_line":"net: CommandFilter, /usr/bin/net, root"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# manila/share/drivers/glusterfs.py: \u0027mkdir\u0027, \u0027%s\u0027"},{"line_number":32,"context_line":"# manila/share/drivers/ganesha/manager.py: \u0027mkdir\u0027, \u0027-p\u0027, \u0027%s\u0027"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"ba8a016a_cfd85682","line":29,"updated":"2015-11-23 10:40:53.000000000","message":"same here.","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"fc986e297c9df09eaeb589c55687a0b89f8d6ac0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027delshare\u0027, \u0027%s\u0027"},{"line_number":27,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027setparm\u0027, \u0027%s\u0027, \u0027%s\u0027, \u0027%s\u0027"},{"line_number":28,"context_line":"# manila/share/drivers/lvm.py: \u0027net\u0027, \u0027conf\u0027, \u0027getparm\u0027, \u0027%s\u0027, \u0027hosts allow\u0027"},{"line_number":29,"context_line":"net: CommandFilter, /usr/bin/net, root"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# manila/share/drivers/glusterfs.py: \u0027mkdir\u0027, \u0027%s\u0027"},{"line_number":32,"context_line":"# manila/share/drivers/ganesha/manager.py: \u0027mkdir\u0027, \u0027-p\u0027, \u0027%s\u0027"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a8ffd7b_3803ad11","line":29,"in_reply_to":"ba8a016a_cfd85682","updated":"2015-11-24 13:20:10.000000000","message":"Done","commit_id":"50537188bd26a953c5cc6acb1da3aff7efacf9c4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"rmdir: CommandFilter, /bin/rmdir, root"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# manila/share/drivers/lvm.py: \u0027pkill\u0027, \u0027-HUP\u0027, \u0027smbd\u0027"},{"line_number":20,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# manila/share/drivers/lvm.py: \u0027smbcontrol\u0027, \u0027all\u0027, \u0027close-share\u0027, \u0027%s\u0027"},{"line_number":23,"context_line":"smbcontrol: CommandFilter, /usr/bin/smbcontrol, root"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"ba8a016a_7095733e","line":20,"updated":"2015-11-23 16:01:28.000000000","message":"Please, see comments from previous patch-set.","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"45818250cae77505db46bb1235e7b511b3f323e8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"rmdir: CommandFilter, /bin/rmdir, root"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# manila/share/drivers/lvm.py: \u0027pkill\u0027, \u0027-HUP\u0027, \u0027smbd\u0027"},{"line_number":20,"context_line":"pkill: CommandFilter, /usr/bin/pkill, root"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# manila/share/drivers/lvm.py: \u0027smbcontrol\u0027, \u0027all\u0027, \u0027close-share\u0027, \u0027%s\u0027"},{"line_number":23,"context_line":"smbcontrol: CommandFilter, /usr/bin/smbcontrol, root"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"9a8ffd7b_78c4d091","line":20,"in_reply_to":"ba8a016a_7095733e","updated":"2015-11-24 13:20:26.000000000","message":"Done","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# manila/share/drivers/lvm.py: \u0027mkfs.ext4\u0027, \u0027/dev/mapper/%s\u0027"},{"line_number":11,"context_line":"mkfs.ext4: CommandFilter, /sbin/mkfs.ext4, root"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# manila/share/drivers/lvm.py: \u0027smbd\u0027, \u0027-s\u0027, \u0027%s\u0027, \u0027-D\u0027"},{"line_number":14,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"},{"line_number":15,"context_line":"smb: CommandFilter, /usr/sbin/smb, root"}],"source_content_type":"application/octet-stream","patch_set":49,"id":"da6ed579_a901eb07","line":12,"updated":"2016-01-14 15:51:11.000000000","message":"After addressing of comment for config opt with FS will be required to add here appropriate wrappers too.","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# manila/share/drivers/lvm.py: \u0027mkfs.ext4\u0027, \u0027/dev/mapper/%s\u0027"},{"line_number":11,"context_line":"mkfs.ext4: CommandFilter, /sbin/mkfs.ext4, root"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# manila/share/drivers/lvm.py: \u0027smbd\u0027, \u0027-s\u0027, \u0027%s\u0027, \u0027-D\u0027"},{"line_number":14,"context_line":"smbd: CommandFilter, /usr/sbin/smbd, root"},{"line_number":15,"context_line":"smb: CommandFilter, /usr/sbin/smb, root"}],"source_content_type":"application/octet-stream","patch_set":49,"id":"da6ed579_3a084dd9","line":12,"in_reply_to":"da6ed579_a901eb07","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"}],"manila/locale/manila.pot":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"msgid \"_wait_for_condition: %s timed out.\""},{"line_number":2346,"context_line":"msgstr \"\""},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"#: manila/share/drivers/ibm/ganesha_utils.py:152 manila/share/drivers/glusterfs.py:144 manila/share/drivers/lvm.py:306"},{"line_number":2349,"context_line":"#, python-format"},{"line_number":2350,"context_line":"msgid \"\""},{"line_number":2351,"context_line":"\"Invalid export config file %(configpath)s: %(exports)s export clauses \""}],"source_content_type":"application/mspowerpoint","patch_set":7,"id":"da85f559_3f225353","line":2348,"updated":"2015-11-10 12:23:26.000000000","message":"This file should not be changed manually.","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":2345,"context_line":"msgid \"_wait_for_condition: %s timed out.\""},{"line_number":2346,"context_line":"msgstr \"\""},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"#: manila/share/drivers/ibm/ganesha_utils.py:152 manila/share/drivers/glusterfs.py:144 manila/share/drivers/lvm.py:306"},{"line_number":2349,"context_line":"#, python-format"},{"line_number":2350,"context_line":"msgid \"\""},{"line_number":2351,"context_line":"\"Invalid export config file %(configpath)s: %(exports)s export clauses \""}],"source_content_type":"application/mspowerpoint","patch_set":7,"id":"da85f559_be16c949","line":2348,"in_reply_to":"da85f559_3f225353","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"}],"manila/share/driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        default\u003dTrue,"},{"line_number":112,"context_line":"        help\u003d\"Specify whether read only access mode is supported in this\""},{"line_number":113,"context_line":"             \"backend.\"),"},{"line_number":114,"context_line":"    cfg.StrOpt(\u0027share_mount_path\u0027,"},{"line_number":115,"context_line":"               default\u003d\u0027/shares\u0027,"},{"line_number":116,"context_line":"               help\u003d\"Parent path where shares will be mounted.\"),"},{"line_number":117,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_498b651f","line":114,"updated":"2015-11-12 12:27:11.000000000","message":"Why this opt is added here?","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"50233e4dc38e40f8cbf8fe70c6ecf5ca8a5aad18","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        default\u003dTrue,"},{"line_number":112,"context_line":"        help\u003d\"Specify whether read only access mode is supported in this\""},{"line_number":113,"context_line":"             \"backend.\"),"},{"line_number":114,"context_line":"    cfg.StrOpt(\u0027share_mount_path\u0027,"},{"line_number":115,"context_line":"               default\u003d\u0027/shares\u0027,"},{"line_number":116,"context_line":"               help\u003d\"Parent path where shares will be mounted.\"),"},{"line_number":117,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_a0a3edfe","line":114,"in_reply_to":"da85f559_498b651f","updated":"2015-11-12 18:15:35.000000000","message":"+1, I think it should be in lvm.py.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        default\u003dTrue,"},{"line_number":112,"context_line":"        help\u003d\"Specify whether read only access mode is supported in this\""},{"line_number":113,"context_line":"             \"backend.\"),"},{"line_number":114,"context_line":"    cfg.StrOpt(\u0027share_mount_path\u0027,"},{"line_number":115,"context_line":"               default\u003d\u0027/shares\u0027,"},{"line_number":116,"context_line":"               help\u003d\"Parent path where shares will be mounted.\"),"},{"line_number":117,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_0fa3be50","line":114,"in_reply_to":"da85f559_498b651f","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"}],"manila/share/drivers/glusterfs/common.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    :param execute: command exectution function"},{"line_number":248,"context_line":"    :param mount_path: path where volume is mounted"},{"line_number":249,"context_line":"    \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    try:"},{"line_number":252,"context_line":"        execute(\u0027umount\u0027, mount_path, run_as_root\u003dTrue)"},{"line_number":253,"context_line":"    except exception.ProcessExecutionError as exc:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3f7ed319","side":"PARENT","line":250,"updated":"2015-11-10 12:23:26.000000000","message":"Not related to the goal of commit.","commit_id":"adb72b8f519efe2fd4a73b0080d3517f6c72730e"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    :param execute: command exectution function"},{"line_number":248,"context_line":"    :param mount_path: path where volume is mounted"},{"line_number":249,"context_line":"    \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    try:"},{"line_number":252,"context_line":"        execute(\u0027umount\u0027, mount_path, run_as_root\u003dTrue)"},{"line_number":253,"context_line":"    except exception.ProcessExecutionError as exc:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3e29798a","side":"PARENT","line":250,"in_reply_to":"da85f559_3f7ed319","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"adb72b8f519efe2fd4a73b0080d3517f6c72730e"}],"manila/share/drivers/helpers.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_e93fb9b1","line":15,"updated":"2015-11-12 12:27:11.000000000","message":"This module should have its unit tests in following module:\n\nmanila/tests/share/drivers/test_helpers.py","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_87919f9b","line":15,"in_reply_to":"da85f559_e93fb9b1","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self._ssh_exec(server, [\u0027sudo\u0027, \u0027rm\u0027, \u0027-f\u0027, maintenance_file])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class CIFSHelper(NASHelperBase):"},{"line_number":197,"context_line":"    \"\"\"Manage shares in samba server by net conf tool."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    Class provides functionality to operate with CIFS shares."}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_697f49e0","line":196,"updated":"2015-11-12 12:27:11.000000000","message":"This helper is \"NetConf\" too as one below, also why do you have two CIFS helpers?","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self._ssh_exec(server, [\u0027sudo\u0027, \u0027rm\u0027, \u0027-f\u0027, maintenance_file])"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class CIFSHelper(NASHelperBase):"},{"line_number":197,"context_line":"    \"\"\"Manage shares in samba server by net conf tool."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    Class provides functionality to operate with CIFS shares."}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_27f793f6","line":196,"in_reply_to":"da85f559_697f49e0","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        self._ssh_exec(server, [\u0027sudo\u0027, \u0027rm\u0027, \u0027-f\u0027, maintenance_file])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class CIFSHelper(NASHelperBase):"},{"line_number":207,"context_line":"    \"\"\"Manage shares in samba server by net conf tool."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    Class provides functionality to operate with CIFS shares."}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_103427f9","line":206,"updated":"2015-11-23 16:01:28.000000000","message":"If this class related only to IP access then, please, rename it.","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"45818250cae77505db46bb1235e7b511b3f323e8","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        self._ssh_exec(server, [\u0027sudo\u0027, \u0027rm\u0027, \u0027-f\u0027, maintenance_file])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class CIFSHelper(NASHelperBase):"},{"line_number":207,"context_line":"    \"\"\"Manage shares in samba server by net conf tool."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    Class provides functionality to operate with CIFS shares."}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_b840f808","line":206,"in_reply_to":"ba8a016a_103427f9","updated":"2015-11-24 13:20:26.000000000","message":"Done","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def remove_export(self, server, share_name):"},{"line_number":122,"context_line":"        \"\"\"Remove export.\"\"\""},{"line_number":123,"context_line":"        pass"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @nfs_synchronized"},{"line_number":126,"context_line":"    def allow_access(self, server, share_name, access_type, access_level,"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_e36dff99","line":123,"updated":"2015-12-02 11:16:50.000000000","message":"\"pass\" can be removed. Docstring is enough.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def remove_export(self, server, share_name):"},{"line_number":122,"context_line":"        \"\"\"Remove export.\"\"\""},{"line_number":123,"context_line":"        pass"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @nfs_synchronized"},{"line_number":126,"context_line":"    def allow_access(self, server, share_name, access_type, access_level,"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_b303c00f","line":123,"in_reply_to":"9a8ffd7b_e36dff99","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    Class provides functionality to operate with CIFS shares."},{"line_number":367,"context_line":"    Samba server should be configured to use registry as configuration"},{"line_number":368,"context_line":"    backend to allow dynamically share managements. Class provide"},{"line_number":369,"context_line":"    functionality of use read-only and read-write access and user access."},{"line_number":370,"context_line":"    \"\"\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def init_helper(self, server):"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_23b787f6","line":369,"updated":"2015-12-02 11:16:50.000000000","message":"\"Class provide functionality of use read-only and read-write access and user access.\" Sounds very strange. \n\n\"\"\"\n\nThis class allows to define access to shares by usernames with either RW or RO access levels.\n\n\"\"\" ?","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    Class provides functionality to operate with CIFS shares."},{"line_number":367,"context_line":"    Samba server should be configured to use registry as configuration"},{"line_number":368,"context_line":"    backend to allow dynamically share managements. Class provide"},{"line_number":369,"context_line":"    functionality of use read-only and read-write access and user access."},{"line_number":370,"context_line":"    \"\"\""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def init_helper(self, server):"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_d37be4bc","line":369,"in_reply_to":"9a8ffd7b_23b787f6","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        for param, value in parameters.items():"},{"line_number":413,"context_line":"            # These are combined in one list to run in one process"},{"line_number":414,"context_line":"            # instead of big chain of one action calls."},{"line_number":415,"context_line":"            self._ssh_exec(server, [\u0027sudo\u0027, \u0027net\u0027, \u0027conf\u0027, \u0027setparm\u0027,"},{"line_number":416,"context_line":"                           share_name, param, value])"},{"line_number":417,"context_line":"        return \u0027\\\\\\\\%s\\\\%s\u0027 % (server[\u0027public_address\u0027], share_name)"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_83775301","line":415,"updated":"2015-12-02 11:16:50.000000000","message":"Comment is not suitable for code it describes. Comment taken from alien code part and should be changed. Or, code should be changed.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        for param, value in parameters.items():"},{"line_number":413,"context_line":"            # These are combined in one list to run in one process"},{"line_number":414,"context_line":"            # instead of big chain of one action calls."},{"line_number":415,"context_line":"            self._ssh_exec(server, [\u0027sudo\u0027, \u0027net\u0027, \u0027conf\u0027, \u0027setparm\u0027,"},{"line_number":416,"context_line":"                           share_name, param, value])"},{"line_number":417,"context_line":"        return \u0027\\\\\\\\%s\\\\%s\u0027 % (server[\u0027public_address\u0027], share_name)"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_b37e60ad","line":415,"in_reply_to":"9a8ffd7b_83775301","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        if access_type !\u003d \u0027user\u0027:"},{"line_number":423,"context_line":"            reason \u003d _(\u0027Only user access type allowed.\u0027)"},{"line_number":424,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":425,"context_line":"        all_users \u003d self._get_valid_users(server, share_name, const.ACCESS_LEVEL_RW) + \\"},{"line_number":426,"context_line":"            self._get_valid_users(server, share_name, const.ACCESS_LEVEL_RO)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        if access_to in all_users:"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_e3fdff3b","line":425,"updated":"2015-12-02 11:16:50.000000000","message":"Such construction says that \"_get_valid_users\" should be able to return \"combined\" data.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        if access_type !\u003d \u0027user\u0027:"},{"line_number":423,"context_line":"            reason \u003d _(\u0027Only user access type allowed.\u0027)"},{"line_number":424,"context_line":"            raise exception.InvalidShareAccess(reason\u003dreason)"},{"line_number":425,"context_line":"        all_users \u003d self._get_valid_users(server, share_name, const.ACCESS_LEVEL_RW) + \\"},{"line_number":426,"context_line":"            self._get_valid_users(server, share_name, const.ACCESS_LEVEL_RO)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        if access_to in all_users:"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_2e5527c1","line":425,"in_reply_to":"9a8ffd7b_e3fdff3b","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4b1f48cf633dcf61a9adbb1022071ad435ff55a9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                  share_name)"},{"line_number":130,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":131,"context_line":"            reason \u003d \u0027only ip access type allowed\u0027"},{"line_number":132,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # check if presents in export"},{"line_number":135,"context_line":"        out, _ \u003d self._ssh_exec(server, [\u0027sudo\u0027, \u0027exportfs\u0027])"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_8a485cb4","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":53},"updated":"2016-01-07 01:18:23.000000000","message":"msg \u003d _(\u0027only ip access type allowed\u0027)\nraise exception.InvalidShareAccess(reason\u003dmsg)","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                                  share_name)"},{"line_number":130,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":131,"context_line":"            reason \u003d \u0027only ip access type allowed\u0027"},{"line_number":132,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # check if presents in export"},{"line_number":135,"context_line":"        out, _ \u003d self._ssh_exec(server, [\u0027sudo\u0027, \u0027exportfs\u0027])"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_b0ccfc89","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":53},"in_reply_to":"fa69d971_8a485cb4","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"917caee568ff1e82b3ac3681b971b1d6f35245af","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"share_opts \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027share_export_root\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027Base folder where exported shares are located\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_bbf2dd6d","line":41,"updated":"2015-10-20 16:54:46.000000000","message":"Add this opts in manila/opts.py ?","commit_id":"38df2c609fbb66e7881a0136d3afdc74329a7f64"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"cc26ee431d1b537847e936932ee1c39f7ed4d203","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"share_opts \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027share_export_root\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027Base folder where exported shares are located\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_699c5f5d","line":41,"in_reply_to":"3a29b11f_bbf2dd6d","updated":"2015-11-02 08:33:55.000000000","message":"Hi, Alyson! Thank you for review!\n\nWhy do we need to move this opts to manila/opts? Options for other drivers are in drivers modules, not in manila/opts.py.","commit_id":"38df2c609fbb66e7881a0136d3afdc74329a7f64"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 NetApp"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_7fb1bbe0","line":1,"updated":"2015-11-10 12:23:26.000000000","message":"Vim headers should not be added.","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 NetApp"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3e85f958","line":1,"in_reply_to":"da85f559_7fb1bbe0","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"CONF.register_opts(share_opts)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class LVMHelper(driver.ShareDriver):"},{"line_number":72,"context_line":"    def check_for_setup_error(self):"},{"line_number":73,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""},{"line_number":74,"context_line":"        out, err \u003d self._execute(\u0027sudo\u0027, \u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_5fce375b","line":71,"updated":"2015-11-10 12:23:26.000000000","message":"It is not Helper. It is \"mixin\". And it should use \"object\" as parent. -\u003e LVMMixin.","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"CONF.register_opts(share_opts)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class LVMHelper(driver.ShareDriver):"},{"line_number":72,"context_line":"    def check_for_setup_error(self):"},{"line_number":73,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""},{"line_number":74,"context_line":"        out, err \u003d self._execute(\u0027sudo\u0027, \u0027vgs\u0027, \u0027--noheadings\u0027, \u0027-o\u0027, \u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_1e591535","line":71,"in_reply_to":"da85f559_5fce375b","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6ad063563edf4b54f989739e701838d8d8261ca3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            \u0027--name\u0027, snapshot[\u0027name\u0027],"},{"line_number":122,"context_line":"            \u0027--snapshot\u0027, orig_lv_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":125,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":126,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3b5eb412","line":124,"updated":"2015-11-11 07:48:17.000000000","message":"Why need a function(delete_snapshot) to appear in two different place(Line 243)?","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2a4c2b5a45dff6ec0d1875295d19fe783a0b51d5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            \u0027--name\u0027, snapshot[\u0027name\u0027],"},{"line_number":122,"context_line":"            \u0027--snapshot\u0027, orig_lv_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":125,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":126,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_2cf8b848","line":124,"in_reply_to":"da85f559_3b5eb412","updated":"2015-11-11 09:21:43.000000000","message":"+1","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            \u0027--name\u0027, snapshot[\u0027name\u0027],"},{"line_number":122,"context_line":"            \u0027--snapshot\u0027, orig_lv_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":125,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":126,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_de3f0db2","line":124,"in_reply_to":"da85f559_3b5eb412","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class LVMShareDriver(driver.ExecuteMixin, LVMHelper):"},{"line_number":130,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_7fff7b67","line":129,"updated":"2015-11-10 12:23:26.000000000","message":"class LVMShareDriver(driver.ExecuteMixin, LVMMixin, driver.ShareDriver):","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class LVMShareDriver(driver.ExecuteMixin, LVMHelper):"},{"line_number":130,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3e7739a1","line":129,"in_reply_to":"da85f559_7fff7b67","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6ad063563edf4b54f989739e701838d8d8261ca3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def _local_path(self, share):"},{"line_number":166,"context_line":"        # NOTE(vish): stops deprecation warning"},{"line_number":167,"context_line":"        escaped_group \u003d \\"},{"line_number":168,"context_line":"            self.configuration.share_volume_group.replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":169,"context_line":"        escaped_name \u003d share[\u0027name\u0027].replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":170,"context_line":"        return \"/dev/mapper/%s-%s\" % (escaped_group, escaped_name)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_98db264f","line":168,"updated":"2015-11-11 07:48:17.000000000","message":"Better to use \"()\":\nescaped_group \u003d (        self.configuration.share_volume_group.replace(\u0027-\u0027, \u0027--\u0027))","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    def _local_path(self, share):"},{"line_number":166,"context_line":"        # NOTE(vish): stops deprecation warning"},{"line_number":167,"context_line":"        escaped_group \u003d \\"},{"line_number":168,"context_line":"            self.configuration.share_volume_group.replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":169,"context_line":"        escaped_name \u003d share[\u0027name\u0027].replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":170,"context_line":"        return \"/dev/mapper/%s-%s\" % (escaped_group, escaped_name)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_1e7035a3","line":168,"in_reply_to":"da85f559_98db264f","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6ad063563edf4b54f989739e701838d8d8261ca3","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                             access[\u0027access_to\u0027])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def deny_access(self, ctx, share, access, share_server\u003dNone):"},{"line_number":254,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":255,"context_line":"        self._get_helper(share).deny_access(self.share_server, share[\u0027name\u0027],"},{"line_number":256,"context_line":"                                            access)"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_d8bc4ede","line":254,"updated":"2015-11-11 07:48:17.000000000","message":"Allow access -\u003e Deny access from the share.","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                             access[\u0027access_to\u0027])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def deny_access(self, ctx, share, access, share_server\u003dNone):"},{"line_number":254,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":255,"context_line":"        self._get_helper(share).deny_access(self.share_server, share[\u0027name\u0027],"},{"line_number":256,"context_line":"                                            access)"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_de662dec","line":254,"in_reply_to":"da85f559_d8bc4ede","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                      *extra_flags, run_as_root\u003dTrue)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"class CIFSNetConfHelper(helpers.NASHelperBase):"},{"line_number":305,"context_line":"    \"\"\"Manage shares in samba server by net conf tool."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    Class provides functionality to operate with CIFS shares. Samba"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_7f369b53","line":304,"updated":"2015-11-10 12:23:26.000000000","message":"Why two helpers are located in two different places?","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                      *extra_flags, run_as_root\u003dTrue)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"class CIFSNetConfHelper(helpers.NASHelperBase):"},{"line_number":305,"context_line":"    \"\"\"Manage shares in samba server by net conf tool."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    Class provides functionality to operate with CIFS shares. Samba"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_fea3f1fd","line":304,"in_reply_to":"da85f559_7f369b53","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"50233e4dc38e40f8cbf8fe70c6ecf5ca8a5aad18","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d\u0027IP to be added to export string\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027smb_config_path\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027$state_path/smb.conf\u0027,"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"               help\u003d\"Path to smb config\"),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_c0107102","line":47,"updated":"2015-11-12 18:15:35.000000000","message":"Empty line","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d\u0027IP to be added to export string\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027smb_config_path\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027$state_path/smb.conf\u0027,"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"               help\u003d\"Path to smb config\"),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_07592ffe","line":47,"in_reply_to":"da85f559_c0107102","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class LVMShareDriver(driver.ExecuteMixin, LVMMixin, driver.ShareDriver):"},{"line_number":127,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":130,"context_line":"        \"\"\"Do initialization.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_494da598","line":127,"updated":"2015-11-12 12:27:11.000000000","message":"Each driver should have capabilities.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class LVMShareDriver(driver.ExecuteMixin, LVMMixin, driver.ShareDriver):"},{"line_number":127,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":130,"context_line":"        \"\"\"Do initialization.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_a72b8393","line":127,"in_reply_to":"da85f559_494da598","updated":"2015-11-18 13:53:33.000000000","message":"What capabilities do you mean? Seems that \u0027_update_share_stats\u0027 function in driver interface helps to set capabilities.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"50233e4dc38e40f8cbf8fe70c6ecf5ca8a5aad18","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"\"\"Do initialization.\"\"\""},{"line_number":131,"context_line":"        super(LVMShareDriver, self).__init__([False], *args, **kwargs)"},{"line_number":132,"context_line":"        self.configuration.append_config_values(share_opts)"},{"line_number":133,"context_line":"        self.configuration.share_mount_path \u003d \\"},{"line_number":134,"context_line":"            self.configuration.share_export_root"},{"line_number":135,"context_line":"        self._helpers \u003d None"},{"line_number":136,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_c0363150","line":133,"updated":"2015-11-12 18:15:35.000000000","message":"use parenthesis instead of backslash","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"\"\"Do initialization.\"\"\""},{"line_number":131,"context_line":"        super(LVMShareDriver, self).__init__([False], *args, **kwargs)"},{"line_number":132,"context_line":"        self.configuration.append_config_values(share_opts)"},{"line_number":133,"context_line":"        self.configuration.share_mount_path \u003d \\"},{"line_number":134,"context_line":"            self.configuration.share_export_root"},{"line_number":135,"context_line":"        self._helpers \u003d None"},{"line_number":136,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_62bee9d5","line":133,"in_reply_to":"da85f559_c0363150","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self._helpers \u003d None"},{"line_number":136,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":137,"context_line":"            \u0027share_backend_name\u0027) or \u0027LVM\u0027"},{"line_number":138,"context_line":"        self.share_server \u003d {"},{"line_number":139,"context_line":"            \u0027public_address\u0027: self.configuration.share_export_ip,"},{"line_number":140,"context_line":"            \u0027instance_id\u0027: self.backend_name,"},{"line_number":141,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_491b6581","line":138,"updated":"2015-11-12 12:27:11.000000000","message":"Need add comment that it is used for compatibility with Generic driver\u0027s helpers.","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self._helpers \u003d None"},{"line_number":136,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":137,"context_line":"            \u0027share_backend_name\u0027) or \u0027LVM\u0027"},{"line_number":138,"context_line":"        self.share_server \u003d {"},{"line_number":139,"context_line":"            \u0027public_address\u0027: self.configuration.share_export_ip,"},{"line_number":140,"context_line":"            \u0027instance_id\u0027: self.backend_name,"},{"line_number":141,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_42bba5e5","line":138,"in_reply_to":"da85f559_491b6581","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"50233e4dc38e40f8cbf8fe70c6ecf5ca8a5aad18","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def allow_access(self, ctx, share, access, share_server\u003dNone):"},{"line_number":241,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":242,"context_line":"        self._get_helper(share).allow_access(self.share_server, share[\u0027name\u0027],"},{"line_number":243,"context_line":"                                             access[\u0027access_type\u0027], \u0027rw\u0027,"},{"line_number":244,"context_line":"                                             access[\u0027access_to\u0027])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def deny_access(self, ctx, share, access, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_20a93d24","line":243,"updated":"2015-11-12 18:15:35.000000000","message":"Shouldn\u0027t you read the access_level here?","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def allow_access(self, ctx, share, access, share_server\u003dNone):"},{"line_number":241,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":242,"context_line":"        self._get_helper(share).allow_access(self.share_server, share[\u0027name\u0027],"},{"line_number":243,"context_line":"                                             access[\u0027access_type\u0027], \u0027rw\u0027,"},{"line_number":244,"context_line":"                                             access[\u0027access_to\u0027])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def deny_access(self, ctx, share, access, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_42a2c5af","line":243,"in_reply_to":"da85f559_20a93d24","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        # Set of parameters used for compatibility with"},{"line_number":143,"context_line":"        # Generic driver\u0027s helpers."},{"line_number":144,"context_line":"        self.share_server \u003d {"},{"line_number":145,"context_line":"            \u0027public_address\u0027: self.configuration.share_export_ip,"},{"line_number":146,"context_line":"            \u0027instance_id\u0027: self.backend_name,"},{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_505dcf13","line":145,"updated":"2015-11-23 16:01:28.000000000","message":"Looks like it is not required. Your method \"_ssh_exec\" does nto use it.","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"45818250cae77505db46bb1235e7b511b3f323e8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        # Set of parameters used for compatibility with"},{"line_number":143,"context_line":"        # Generic driver\u0027s helpers."},{"line_number":144,"context_line":"        self.share_server \u003d {"},{"line_number":145,"context_line":"            \u0027public_address\u0027: self.configuration.share_export_ip,"},{"line_number":146,"context_line":"            \u0027instance_id\u0027: self.backend_name,"},{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_787cd020","line":145,"in_reply_to":"ba8a016a_505dcf13","updated":"2015-11-24 13:20:26.000000000","message":"But it is used in \u0027create_export\u0027 and \u0027get_exports_for_share\u0027 methods.","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"},{"author":{"_account_id":6938,"name":"Alexey Ovchinnikov","email":"aovchinnikov@mirantis.com","username":"aovchinnikov"},"change_message_id":"33e10db09a3c73aacdf20792b74466e4cbb2f38a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class LVMShareDriver(driver.ExecuteMixin, LVMMixin, driver.ShareDriver):"},{"line_number":131,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a8ffd7b_4a6c5b9c","line":130,"updated":"2015-12-01 12:56:27.000000000","message":"It appears that you use driver.ExecuteMixin in LVMMixin rather than  in LVMShareDriver.  Maybe it would be better to move it to LVMMixin definition?","commit_id":"e119c0ba31607a533be1847f489775f5bc52a746"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"b3853b6b76c36103c9d3c01b7fc5b7ed8835c793","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class LVMShareDriver(driver.ExecuteMixin, LVMMixin, driver.ShareDriver):"},{"line_number":131,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9a8ffd7b_3bb927cc","line":130,"in_reply_to":"9a8ffd7b_4a6c5b9c","updated":"2015-12-01 13:43:02.000000000","message":"Alexey, agree with you. Done.","commit_id":"e119c0ba31607a533be1847f489775f5bc52a746"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"168f54eddbbf98ce126cbf324c23fcaf137c9075","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 NetApp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_1fd566b8","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":23},"updated":"2016-01-07 19:05:39.000000000","message":"Shouldn\u0027t this be 2015 (or 2016?) Mirantis?","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 NetApp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_2bbc1dba","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":23},"in_reply_to":"fa69d971_1fd566b8","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a625469590bd457e52017d3b2b9eab36d911eacd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 NetApp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_35c64917","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":23},"in_reply_to":"fa69d971_1fd566b8","updated":"2016-01-07 19:36:10.000000000","message":"Mirantis should *add* a copyright line here.  But the Manila LVM driver was part of the initial Manila commit and bore the NetApp copyright at that time.  https://github.com/openstack/manila/blob/f99ef92c9024b1dfc604646c8c0912b963c11523/cinder/share/drivers/lvm.py","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 NetApp"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_cb954132","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":23},"in_reply_to":"fa69d971_35c64917","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_utils import importutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from manila.db import api as db_api"},{"line_number":29,"context_line":"from manila import exception"},{"line_number":30,"context_line":"from manila.i18n import _"},{"line_number":31,"context_line":"from manila.i18n import _LE"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_246d4b31","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":35},"updated":"2016-01-05 03:02:12.000000000","message":"A driver should not have or need a reference to the DB API.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_utils import importutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from manila.db import api as db_api"},{"line_number":29,"context_line":"from manila import exception"},{"line_number":30,"context_line":"from manila.i18n import _"},{"line_number":31,"context_line":"from manila.i18n import _LE"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_f61d8973","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":35},"in_reply_to":"fa69d971_246d4b31","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"share_opts \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027share_export_root\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Base folder where exported shares are located\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027share_export_ip\u0027,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_9ac6dd66","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":33},"updated":"2016-01-05 03:02:12.000000000","message":"Can we add an \u0027lvm_\u0027 prefix to each of these config options?  That is the pattern that all the vendor drivers follow, as does the LVM driver in Cinder.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"share_opts \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027share_export_root\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Base folder where exported shares are located\u0027),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027share_export_ip\u0027,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_98c23352","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":33},"in_reply_to":"fa69d971_9ac6dd66","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027IP to be added to export string\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027smb_config_path\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027$state_path/smb.conf\u0027,"},{"line_number":48,"context_line":"               help\u003d\"Path to smb config\"),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_2f3f6988","line":48,"range":{"start_line":48,"start_character":29,"end_line":48,"end_character":32},"updated":"2016-01-05 03:02:12.000000000","message":"s/smb/SMB/","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027IP to be added to export string\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027smb_config_path\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027$state_path/smb.conf\u0027,"},{"line_number":48,"context_line":"               help\u003d\"Path to smb config\"),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_588efb2e","line":48,"range":{"start_line":48,"start_character":29,"end_line":48,"end_character":32},"in_reply_to":"fa69d971_2f3f6988","updated":"2016-01-13 15:09:45.000000000","message":"Removed this option.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               help\u003d\"Path to smb config\"),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_cf500dd7","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":40},"updated":"2016-01-05 03:02:12.000000000","message":"s/lvms/LVMs/","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               help\u003d\"Path to smb config\"),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_98ec73bc","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":40},"in_reply_to":"fa69d971_cf500dd7","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Name for the VG that will contain exported shares\u0027),"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_2f5689ce","line":52,"range":{"start_line":52,"start_character":51,"end_line":52,"end_character":54},"updated":"2016-01-05 03:02:12.000000000","message":"s/pvs/PVs/","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Name for the VG that will contain exported shares\u0027),"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_cf67adb5","line":52,"range":{"start_line":52,"start_character":70,"end_line":52,"end_character":75},"updated":"2016-01-05 03:02:12.000000000","message":"s/space/space./","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    cfg.IntOpt(\u0027share_lvm_mirrors\u0027,"},{"line_number":50,"context_line":"               default\u003d0,"},{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Name for the VG that will contain exported shares\u0027),"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_58311b59","line":52,"range":{"start_line":52,"start_character":51,"end_line":52,"end_character":54},"in_reply_to":"fa69d971_2f5689ce","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Name for the VG that will contain exported shares\u0027),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027share_lvm_helpers\u0027,"},{"line_number":57,"context_line":"                default\u003d["}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_7701b704","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":29},"updated":"2016-01-05 03:02:12.000000000","message":"I wonder if something like \u0027lvm-shares\u0027 or \u0027manila-shares\u0027 would be more fitting...","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"               help\u003d\u0027If set, create lvms with multiple mirrors. Note that \u0027"},{"line_number":52,"context_line":"                    \u0027this requires lvm_mirrors + 2 pvs with available space\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027share_volume_group\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027stack-shares\u0027,"},{"line_number":55,"context_line":"               help\u003d\u0027Name for the VG that will contain exported shares\u0027),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027share_lvm_helpers\u0027,"},{"line_number":57,"context_line":"                default\u003d["}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_f89b2f15","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":29},"in_reply_to":"fa69d971_7701b704","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _deallocate_container(self, share_name):"},{"line_number":103,"context_line":"        \"\"\"Deletes a logical volume for share.\"\"\""},{"line_number":104,"context_line":"        # zero out old volumes to prevent data leaking between users"},{"line_number":105,"context_line":"        # TODO(ja): reclaiming space should be done lazy and low priority"},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_84d2f75a","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":15},"updated":"2016-01-05 03:02:12.000000000","message":"This comment originates in the Cinder LVM driver, which has a method that does actually clear an LV.  Where is the Manila code that zeroes old volumes?  This would appear to be a serious security issue.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6e45513a6e959baf440591754cc19c88a2abe204","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _deallocate_container(self, share_name):"},{"line_number":103,"context_line":"        \"\"\"Deletes a logical volume for share.\"\"\""},{"line_number":104,"context_line":"        # zero out old volumes to prevent data leaking between users"},{"line_number":105,"context_line":"        # TODO(ja): reclaiming space should be done lazy and low priority"},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_c2599b36","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":15},"in_reply_to":"fa69d971_84d2f75a","updated":"2016-01-05 21:41:23.000000000","message":"After conferring with Ben, I realize this isn\u0027t an issue in Manila, since we\u0027re putting a filesystem on the LV and one cannot read unallocated blocks from a filesystem.  It seems these comments don\u0027t apply and should be removed.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _deallocate_container(self, share_name):"},{"line_number":103,"context_line":"        \"\"\"Deletes a logical volume for share.\"\"\""},{"line_number":104,"context_line":"        # zero out old volumes to prevent data leaking between users"},{"line_number":105,"context_line":"        # TODO(ja): reclaiming space should be done lazy and low priority"},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            self._try_execute(\u0027lvremove\u0027, \u0027-f\u0027, \"%s/%s\" %"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_d30acc25","line":104,"range":{"start_line":104,"start_character":14,"end_line":104,"end_character":15},"in_reply_to":"fa69d971_c2599b36","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               share_name), run_as_root\u003dTrue)"},{"line_number":110,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":111,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":112,"context_line":"                LOG.error(_LE(\"Error deleting volume: %s\") % exc.stderr)"},{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_84f0b768","line":112,"range":{"start_line":112,"start_character":20,"end_line":112,"end_character":25},"updated":"2016-01-05 03:02:12.000000000","message":"You can use LOG.exception to include the exception details automatically.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               share_name), run_as_root\u003dTrue)"},{"line_number":110,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":111,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":112,"context_line":"                LOG.error(_LE(\"Error deleting volume: %s\") % exc.stderr)"},{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_01bc356b","line":112,"range":{"start_line":112,"start_character":20,"end_line":112,"end_character":25},"in_reply_to":"fa69d971_84f0b768","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":112,"context_line":"                LOG.error(_LE(\"Error deleting volume: %s\") % exc.stderr)"},{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":117,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_a4f5bb57","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":21},"updated":"2016-01-05 03:02:12.000000000","message":"Same","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":112,"context_line":"                LOG.error(_LE(\"Error deleting volume: %s\") % exc.stderr)"},{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":117,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_21c139e5","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":21},"in_reply_to":"fa69d971_8712d555","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6e45513a6e959baf440591754cc19c88a2abe204","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":112,"context_line":"                LOG.error(_LE(\"Error deleting volume: %s\") % exc.stderr)"},{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":"            LOG.error(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":117,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_8712d555","line":114,"range":{"start_line":114,"start_character":16,"end_line":114,"end_character":21},"in_reply_to":"fa69d971_a4f5bb57","updated":"2016-01-05 21:41:23.000000000","message":"After further reflection, if an LV isn\u0027t found, we correctly swallow the exception and allow Manila to delete the share normally.  So I would argue this should be a warning, not an error.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class LVMShareDriver(LVMMixin, driver.ShareDriver):"},{"line_number":131,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_24ceab82","line":130,"range":{"start_line":130,"start_character":21,"end_line":130,"end_character":29},"updated":"2016-01-05 03:02:12.000000000","message":"Will the LVMMixin be used in other drivers, such as the LXD driver?  Otherwise, I don\u0027t understand why the code is in a mixin rather than part of LVMShareDriver.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._deallocate_container(snapshot[\u0027name\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class LVMShareDriver(LVMMixin, driver.ShareDriver):"},{"line_number":131,"context_line":"    \"\"\"Executes commands relating to Shares.\"\"\""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_41aa2d1b","line":130,"range":{"start_line":130,"start_character":21,"end_line":130,"end_character":29},"in_reply_to":"fa69d971_24ceab82","updated":"2016-01-13 15:09:45.000000000","message":"Yes, LVMMixin will be used in LXD driver.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"6e45513a6e959baf440591754cc19c88a2abe204","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self._helpers[share_proto.upper()] \u003d helper("},{"line_number":170,"context_line":"                self._execute, self._ssh_exec_as_root, self.configuration)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _local_path(self, share):"},{"line_number":173,"context_line":"        # NOTE(vish): stops deprecation warning"},{"line_number":174,"context_line":"        escaped_group \u003d ("},{"line_number":175,"context_line":"            self.configuration.share_volume_group.replace(\u0027-\u0027, \u0027--\u0027))"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_041ee05e","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":19},"updated":"2016-01-05 21:41:23.000000000","message":"Can we rename this to _get_local_path or _get_device_mapper_path ?\n\nAnd please let\u0027s improve the comment.  The escape characters are expected by the device mapper.  http://man7.org/linux/man-pages/man8/dmsetup.8.html","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self._helpers[share_proto.upper()] \u003d helper("},{"line_number":170,"context_line":"                self._execute, self._ssh_exec_as_root, self.configuration)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def _local_path(self, share):"},{"line_number":173,"context_line":"        # NOTE(vish): stops deprecation warning"},{"line_number":174,"context_line":"        escaped_group \u003d ("},{"line_number":175,"context_line":"            self.configuration.share_volume_group.replace(\u0027-\u0027, \u0027--\u0027))"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_fc03c874","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":19},"in_reply_to":"fa69d971_041ee05e","updated":"2016-01-13 15:09:45.000000000","message":"Clinton, could you please explain in detail what\u0027s the issue with escape characters for device mapper?","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _update_share_stats(self):"},{"line_number":180,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":181,"context_line":"        data \u003d dict("},{"line_number":182,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":183,"context_line":"            reserved_percentage\u003dself.configuration.reserved_share_percentage,"},{"line_number":184,"context_line":"            consistency_group_support\u003dNone,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_173abbcc","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":19},"updated":"2016-01-05 03:02:12.000000000","message":"This info should contain a single pool with VG capacity data.  It should also contain other typical fields, such as driver name and snapshot support.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _update_share_stats(self):"},{"line_number":180,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":181,"context_line":"        data \u003d dict("},{"line_number":182,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":183,"context_line":"            reserved_percentage\u003dself.configuration.reserved_share_percentage,"},{"line_number":184,"context_line":"            consistency_group_support\u003dNone,"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_7da7d14f","line":181,"range":{"start_line":181,"start_character":15,"end_line":181,"end_character":19},"in_reply_to":"fa69d971_173abbcc","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4b1f48cf633dcf61a9adbb1022071ad435ff55a9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":183,"context_line":"            reserved_percentage\u003dself.configuration.reserved_share_percentage,"},{"line_number":184,"context_line":"            consistency_group_support\u003dNone,"},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        super(LVMShareDriver, self)._update_share_stats(data)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_6a80888b","line":185,"updated":"2016-01-07 01:18:23.000000000","message":"Please use dict comprehension rather than dict constructor.  See the following fix:\n\nhttps://github.com/openstack/manila/commit/51069d5390683007ad612b15a882626326bd2d53","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            storage_protocol\u003d\u0027NFS_CIFS\u0027,"},{"line_number":183,"context_line":"            reserved_percentage\u003dself.configuration.reserved_share_percentage,"},{"line_number":184,"context_line":"            consistency_group_support\u003dNone,"},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        super(LVMShareDriver, self)._update_share_stats(data)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_dd6cbd0a","line":185,"in_reply_to":"fa69d971_6a80888b","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Is called to create share from snapshot.\"\"\""},{"line_number":200,"context_line":"        self._allocate_container(share)"},{"line_number":201,"context_line":"        device_name \u003d self._local_path(snapshot)"},{"line_number":202,"context_line":"        snapshot \u003d db_api.share_snapshot_get(context, snapshot[\u0027snapshot_id\u0027])"},{"line_number":203,"context_line":"        self._copy_volume(device_name, self._local_path(share),"},{"line_number":204,"context_line":"                          snapshot[\u0027share\u0027][\u0027size\u0027])"},{"line_number":205,"context_line":"        location \u003d self._get_helper(share).create_export(self.share_server,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_e41bb3c8","line":202,"range":{"start_line":202,"start_character":19,"end_line":202,"end_character":25},"updated":"2016-01-05 03:02:12.000000000","message":"Please let\u0027s find a way to eliminate this DB access.","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Is called to create share from snapshot.\"\"\""},{"line_number":200,"context_line":"        self._allocate_container(share)"},{"line_number":201,"context_line":"        device_name \u003d self._local_path(snapshot)"},{"line_number":202,"context_line":"        snapshot \u003d db_api.share_snapshot_get(context, snapshot[\u0027snapshot_id\u0027])"},{"line_number":203,"context_line":"        self._copy_volume(device_name, self._local_path(share),"},{"line_number":204,"context_line":"                          snapshot[\u0027share\u0027][\u0027size\u0027])"},{"line_number":205,"context_line":"        location \u003d self._get_helper(share).create_export(self.share_server,"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_5d81ad8e","line":202,"range":{"start_line":202,"start_character":19,"end_line":202,"end_character":25},"in_reply_to":"fa69d971_aa28c09a","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4b1f48cf633dcf61a9adbb1022071ad435ff55a9","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Is called to create share from snapshot.\"\"\""},{"line_number":200,"context_line":"        self._allocate_container(share)"},{"line_number":201,"context_line":"        device_name \u003d self._local_path(snapshot)"},{"line_number":202,"context_line":"        snapshot \u003d db_api.share_snapshot_get(context, snapshot[\u0027snapshot_id\u0027])"},{"line_number":203,"context_line":"        self._copy_volume(device_name, self._local_path(share),"},{"line_number":204,"context_line":"                          snapshot[\u0027share\u0027][\u0027size\u0027])"},{"line_number":205,"context_line":"        location \u003d self._get_helper(share).create_export(self.share_server,"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_aa28c09a","line":202,"range":{"start_line":202,"start_character":19,"end_line":202,"end_character":25},"in_reply_to":"fa69d971_e41bb3c8","updated":"2016-01-07 01:18:23.000000000","message":"+1","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a13cc15e03155ecb32daa17b1a828be0fce73b7e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                            access)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def _get_helper(self, share):"},{"line_number":263,"context_line":"        if share[\u0027share_proto\u0027].startswith(\u0027NFS\u0027):"},{"line_number":264,"context_line":"            return self._helpers[\u0027NFS\u0027]"},{"line_number":265,"context_line":"        elif share[\u0027share_proto\u0027].startswith(\u0027CIFS\u0027):"},{"line_number":266,"context_line":"            return self._helpers[\u0027CIFS\u0027]"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_04b36799","line":263,"range":{"start_line":263,"start_character":32,"end_line":263,"end_character":42},"updated":"2016-01-05 03:02:12.000000000","message":"Can you make these checks case-insensitive?","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                            access)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def _get_helper(self, share):"},{"line_number":263,"context_line":"        if share[\u0027share_proto\u0027].startswith(\u0027NFS\u0027):"},{"line_number":264,"context_line":"            return self._helpers[\u0027NFS\u0027]"},{"line_number":265,"context_line":"        elif share[\u0027share_proto\u0027].startswith(\u0027CIFS\u0027):"},{"line_number":266,"context_line":"            return self._helpers[\u0027CIFS\u0027]"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_5d068d21","line":263,"range":{"start_line":263,"start_character":32,"end_line":263,"end_character":42},"in_reply_to":"fa69d971_04b36799","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"168f54eddbbf98ce126cbf324c23fcaf137c9075","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                          run_as_root\u003dTrue, check_exit_code\u003dTrue)"},{"line_number":279,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":280,"context_line":"            if \u0027already mounted\u0027 in exc.stderr:"},{"line_number":281,"context_line":"                LOG.warn(_LW(\"%s is already mounted\"), device_name)"},{"line_number":282,"context_line":"            else:"},{"line_number":283,"context_line":"                raise"},{"line_number":284,"context_line":"        return mount_path"}],"source_content_type":"text/x-python","patch_set":44,"id":"fa69d971_a268bd88","line":281,"range":{"start_line":281,"start_character":20,"end_line":281,"end_character":24},"updated":"2016-01-07 19:05:39.000000000","message":"please use LOG.warning","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"f7c07c5aac0b4847643da1dd17a1d59105bf0ff8","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                          run_as_root\u003dTrue, check_exit_code\u003dTrue)"},{"line_number":279,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":280,"context_line":"            if \u0027already mounted\u0027 in exc.stderr:"},{"line_number":281,"context_line":"                LOG.warn(_LW(\"%s is already mounted\"), device_name)"},{"line_number":282,"context_line":"            else:"},{"line_number":283,"context_line":"                raise"},{"line_number":284,"context_line":"        return mount_path"}],"source_content_type":"text/x-python","patch_set":44,"id":"da6ed579_46f23a9c","line":281,"range":{"start_line":281,"start_character":20,"end_line":281,"end_character":24},"in_reply_to":"fa69d971_a268bd88","updated":"2016-01-13 15:09:45.000000000","message":"Done","commit_id":"2d2ec968729cb10a3ac994096ca644309e00690a"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"aa7db992a600b1325b37dc2d986367b7033727d4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":108,"context_line":"                LOG.exception(_LE(\"Error deleting volume\"))"},{"line_number":109,"context_line":"                raise"},{"line_number":110,"context_line":"            LOG.warn(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":113,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_b79b8f65","line":110,"range":{"start_line":110,"start_character":21,"end_line":110,"end_character":24},"updated":"2016-01-14 14:09:21.000000000","message":"_LW","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"14ec104e260aaf529888d58b88bb4179cacf6356","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if \"not found\" not in exc.stderr:"},{"line_number":108,"context_line":"                LOG.exception(_LE(\"Error deleting volume\"))"},{"line_number":109,"context_line":"                raise"},{"line_number":110,"context_line":"            LOG.warn(_LE(\"Volume not found: %s\") % exc.stderr)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":113,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_8d3998d9","line":110,"range":{"start_line":110,"start_character":21,"end_line":110,"end_character":24},"in_reply_to":"da6ed579_b79b8f65","updated":"2016-01-14 14:26:59.000000000","message":"Done","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"aa7db992a600b1325b37dc2d986367b7033727d4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                os.rmdir(mount_path)"},{"line_number":242,"context_line":"            except OSError:"},{"line_number":243,"context_line":"                LOG.info(_LI(\u0027Unable to delete %s\u0027), mount_path)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def ensure_share(self, ctx, share, share_server\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Ensure that storage are mounted and exported.\"\"\""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_37723f12","line":243,"range":{"start_line":243,"start_character":20,"end_line":243,"end_character":24},"updated":"2016-01-14 14:09:21.000000000","message":"Is it better to log a warning here?","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"14ec104e260aaf529888d58b88bb4179cacf6356","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                os.rmdir(mount_path)"},{"line_number":242,"context_line":"            except OSError:"},{"line_number":243,"context_line":"                LOG.info(_LI(\u0027Unable to delete %s\u0027), mount_path)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def ensure_share(self, ctx, share, share_server\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Ensure that storage are mounted and exported.\"\"\""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_cd59d036","line":243,"range":{"start_line":243,"start_character":20,"end_line":243,"end_character":24},"in_reply_to":"da6ed579_37723f12","updated":"2016-01-14 14:26:59.000000000","message":"agree with you, thank you!","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"aa7db992a600b1325b37dc2d986367b7033727d4","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            self._get_helper(share).remove_export(self.share_server,"},{"line_number":256,"context_line":"                                                  share[\u0027name\u0027])"},{"line_number":257,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":258,"context_line":"            LOG.info(_LI(\"Can\u0027t remove share %r\"), share[\u0027id\u0027])"},{"line_number":259,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":260,"context_line":"            LOG.info(exc.message)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_3749dfb7","line":258,"range":{"start_line":258,"start_character":12,"end_line":258,"end_character":15},"updated":"2016-01-14 14:09:21.000000000","message":"Ditto","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"14ec104e260aaf529888d58b88bb4179cacf6356","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            self._get_helper(share).remove_export(self.share_server,"},{"line_number":256,"context_line":"                                                  share[\u0027name\u0027])"},{"line_number":257,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":258,"context_line":"            LOG.info(_LI(\"Can\u0027t remove share %r\"), share[\u0027id\u0027])"},{"line_number":259,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":260,"context_line":"            LOG.info(exc.message)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_8d40b835","line":258,"range":{"start_line":258,"start_character":12,"end_line":258,"end_character":15},"in_reply_to":"da6ed579_3749dfb7","updated":"2016-01-14 14:26:59.000000000","message":"Done","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"aa7db992a600b1325b37dc2d986367b7033727d4","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":258,"context_line":"            LOG.info(_LI(\"Can\u0027t remove share %r\"), share[\u0027id\u0027])"},{"line_number":259,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":260,"context_line":"            LOG.info(exc.message)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def allow_access(self, ctx, share, access, share_server\u003dNone):"},{"line_number":263,"context_line":"        \"\"\"Allow access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_f7cd8731","line":260,"range":{"start_line":260,"start_character":12,"end_line":260,"end_character":15},"updated":"2016-01-14 14:09:21.000000000","message":"Ditto","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"14ec104e260aaf529888d58b88bb4179cacf6356","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":258,"context_line":"            LOG.info(_LI(\"Can\u0027t remove share %r\"), share[\u0027id\u0027])"},{"line_number":259,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":260,"context_line":"            LOG.info(exc.message)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def allow_access(self, ctx, share, access, share_server\u003dNone):"},{"line_number":263,"context_line":"        \"\"\"Allow access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":48,"id":"da6ed579_2d498c60","line":260,"range":{"start_line":260,"start_character":12,"end_line":260,"end_character":15},"in_reply_to":"da6ed579_f7cd8731","updated":"2016-01-14 14:26:59.000000000","message":"Done","commit_id":"59980a2a1fdea4198cc5da44b447e0d5aa2f4a08"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Base folder where exported shares are located.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027lvm_share_export_ip\u0027,"},{"line_number":45,"context_line":"               default\u003dNone,"},{"line_number":46,"context_line":"               help\u003d\u0027IP to be added to export string.\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027lvm_share_mirrors\u0027,"},{"line_number":48,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_09c837a7","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":27},"updated":"2016-01-14 15:51:11.000000000","message":"line 45 is redundant.","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Base folder where exported shares are located.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027lvm_share_export_ip\u0027,"},{"line_number":45,"context_line":"               default\u003dNone,"},{"line_number":46,"context_line":"               help\u003d\u0027IP to be added to export string.\u0027),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027lvm_share_mirrors\u0027,"},{"line_number":48,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_fa115505","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":27},"in_reply_to":"da6ed579_09c837a7","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rsize \u003d int(2 ** math.ceil(math.log(terras) / math.log(2)))"},{"line_number":88,"context_line":"                # NOTE(vish): Next power of two for region size. See:"},{"line_number":89,"context_line":"                #             http://red.ht/U2BPOD"},{"line_number":90,"context_line":"                cmd +\u003d [\u0027-R\u0027, str(rsize)]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._try_execute(*cmd, run_as_root\u003dTrue)"},{"line_number":93,"context_line":"        device_name \u003d self._get_local_path(share)"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_c998dfc2","line":90,"range":{"start_line":90,"start_character":30,"end_line":90,"end_character":33},"updated":"2016-01-14 15:51:11.000000000","message":"s/str/six.text_type/","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                rsize \u003d int(2 ** math.ceil(math.log(terras) / math.log(2)))"},{"line_number":88,"context_line":"                # NOTE(vish): Next power of two for region size. See:"},{"line_number":89,"context_line":"                #             http://red.ht/U2BPOD"},{"line_number":90,"context_line":"                cmd +\u003d [\u0027-R\u0027, str(rsize)]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._try_execute(*cmd, run_as_root\u003dTrue)"},{"line_number":93,"context_line":"        device_name \u003d self._get_local_path(share)"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_baf43dcf","line":90,"range":{"start_line":90,"start_character":30,"end_line":90,"end_character":33},"in_reply_to":"da6ed579_c998dfc2","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._try_execute(*cmd, run_as_root\u003dTrue)"},{"line_number":93,"context_line":"        device_name \u003d self._get_local_path(share)"},{"line_number":94,"context_line":"        self._execute(\u0027mkfs.ext4\u0027, device_name, run_as_root\u003dTrue)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _extend_container(self, share, device_name, size):"},{"line_number":97,"context_line":"        cmd \u003d [\u0027lvextend\u0027, \u0027-L\u0027, \u0027%sG\u0027 % size, \u0027-n\u0027, device_name]"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_8960a7d0","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":32},"updated":"2016-01-14 15:51:11.000000000","message":"Better to do here same thing as for generic driver - allow to set FS via config. See https://github.com/openstack/manila/blob/f6d54dde/manila/share/drivers/generic.py#L78","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._try_execute(*cmd, run_as_root\u003dTrue)"},{"line_number":93,"context_line":"        device_name \u003d self._get_local_path(share)"},{"line_number":94,"context_line":"        self._execute(\u0027mkfs.ext4\u0027, device_name, run_as_root\u003dTrue)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _extend_container(self, share, device_name, size):"},{"line_number":97,"context_line":"        cmd \u003d [\u0027lvextend\u0027, \u0027-L\u0027, \u0027%sG\u0027 % size, \u0027-n\u0027, device_name]"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_5a03c1b8","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":32},"in_reply_to":"da6ed579_8960a7d0","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":183,"context_line":"            \u0027driver_name\u0027: \u0027LVMShareDriver\u0027,"},{"line_number":184,"context_line":"            \u0027pools\u0027: self.get_share_server_pools()"},{"line_number":185,"context_line":"        }"},{"line_number":186,"context_line":"        super(LVMShareDriver, self)._update_share_stats(data)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_share_server_pools(self, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_899d0768","line":185,"updated":"2016-01-14 15:51:11.000000000","message":"\u0027backend_name\u0027: self.backend_name,","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            \u0027snapshot_support\u0027: True,"},{"line_number":183,"context_line":"            \u0027driver_name\u0027: \u0027LVMShareDriver\u0027,"},{"line_number":184,"context_line":"            \u0027pools\u0027: self.get_share_server_pools()"},{"line_number":185,"context_line":"        }"},{"line_number":186,"context_line":"        super(LVMShareDriver, self)._update_share_stats(data)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_share_server_pools(self, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_1a2c6949","line":185,"in_reply_to":"da6ed579_899d0768","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        elif share[\u0027share_proto\u0027].lower().startswith(\u0027cifs\u0027):"},{"line_number":278,"context_line":"            return self._helpers[\u0027CIFS\u0027]"},{"line_number":279,"context_line":"        else:"},{"line_number":280,"context_line":"            raise exception.InvalidShare(reason\u003d\u0027Wrong share type\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _mount_device(self, share, device_name):"},{"line_number":283,"context_line":"        \"\"\"Mount LVM share and ignore if already mounted.\"\"\""}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_c9a53fa2","line":280,"range":{"start_line":280,"start_character":61,"end_line":280,"end_character":65},"updated":"2016-01-14 15:51:11.000000000","message":"s/type/protocol/","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        elif share[\u0027share_proto\u0027].lower().startswith(\u0027cifs\u0027):"},{"line_number":278,"context_line":"            return self._helpers[\u0027CIFS\u0027]"},{"line_number":279,"context_line":"        else:"},{"line_number":280,"context_line":"            raise exception.InvalidShare(reason\u003d\u0027Wrong share type\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _mount_device(self, share, device_name):"},{"line_number":283,"context_line":"        \"\"\"Mount LVM share and ignore if already mounted.\"\"\""}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_fa287535","line":280,"range":{"start_line":280,"start_character":61,"end_line":280,"end_character":65},"in_reply_to":"da6ed579_c9a53fa2","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            self._execute(\u0027chmod\u0027, \u0027777\u0027, mount_path,"},{"line_number":290,"context_line":"                          run_as_root\u003dTrue, check_exit_code\u003dTrue)"},{"line_number":291,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":292,"context_line":"            if \u0027already mounted\u0027 in exc.stderr:"},{"line_number":293,"context_line":"                LOG.warning(_LW(\"%s is already mounted\"), device_name)"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_09e597da","line":292,"range":{"start_line":292,"start_character":16,"end_line":292,"end_character":31},"updated":"2016-01-14 15:51:11.000000000","message":"It is too weak approach to use error message for making decision. Better to get current mount list and look for it.","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            self._execute(\u0027chmod\u0027, \u0027777\u0027, mount_path,"},{"line_number":290,"context_line":"                          run_as_root\u003dTrue, check_exit_code\u003dTrue)"},{"line_number":291,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":292,"context_line":"            if \u0027already mounted\u0027 in exc.stderr:"},{"line_number":293,"context_line":"                LOG.warning(_LW(\"%s is already mounted\"), device_name)"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_7a1565e3","line":292,"range":{"start_line":292,"start_character":16,"end_line":292,"end_character":31},"in_reply_to":"da6ed579_09e597da","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1a97196c9d7581a15642d6f069041b4fc8788e04","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    \u0027NFS\u003dmanila.share.drivers.helpers.NFSHelper\u0027,"},{"line_number":57,"context_line":"                ],"},{"line_number":58,"context_line":"                help\u003d\u0027Specify list of share export helpers.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027share_volume_fstype\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027ext4\u0027,"},{"line_number":61,"context_line":"               choices\u003d[\u0027ext4\u0027, \u0027ext3\u0027],"},{"line_number":62,"context_line":"               help\u003d\u0027Filesystem type of the share volume.\u0027),"}],"source_content_type":"text/x-python","patch_set":53,"id":"ba63e191_a2264866","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":35},"updated":"2016-01-19 21:04:40.000000000","message":"Please add lvm_ prefix.","commit_id":"be75cd1cc1fe36616314d3156cd6b85d04d332ab"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"ce1baa171892088d835119e234dfe06560092a85","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    \u0027NFS\u003dmanila.share.drivers.helpers.NFSHelper\u0027,"},{"line_number":57,"context_line":"                ],"},{"line_number":58,"context_line":"                help\u003d\u0027Specify list of share export helpers.\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027share_volume_fstype\u0027,"},{"line_number":60,"context_line":"               default\u003d\u0027ext4\u0027,"},{"line_number":61,"context_line":"               choices\u003d[\u0027ext4\u0027, \u0027ext3\u0027],"},{"line_number":62,"context_line":"               help\u003d\u0027Filesystem type of the share volume.\u0027),"}],"source_content_type":"text/x-python","patch_set":53,"id":"ba63e191_88d9e585","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":35},"in_reply_to":"ba63e191_a2264866","updated":"2016-01-19 21:30:24.000000000","message":"Actually this look like an attempt to reuse an option from the generic driver. It would be simpler to just import the generic driver\u0027s options.","commit_id":"be75cd1cc1fe36616314d3156cd6b85d04d332ab"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"1a97196c9d7581a15642d6f069041b4fc8788e04","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        escaped_name \u003d share[\u0027name\u0027].replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":177,"context_line":"        return \"/dev/mapper/%s-%s\" % (escaped_group, escaped_name)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def _update_share_stats(self):"},{"line_number":180,"context_line":"        \"\"\"Retrieve stats info from share volume group.\"\"\""},{"line_number":181,"context_line":"        data \u003d {"},{"line_number":182,"context_line":"            \u0027backend_name\u0027: self.backend_name,"}],"source_content_type":"text/x-python","patch_set":53,"id":"ba63e191_624050a6","line":179,"range":{"start_line":179,"start_character":8,"end_line":179,"end_character":27},"updated":"2016-01-19 21:04:40.000000000","message":"This method needs a unit test.","commit_id":"be75cd1cc1fe36616314d3156cd6b85d04d332ab"}],"manila/tests/fake_driver.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FakeShareDriver(generic.GenericShareDriver):"},{"line_number":25,"context_line":"    \"\"\"Logs calls instead of executing.\"\"\""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":27,"context_line":"        super(FakeShareDriver, self).__init__([True, False], *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_9f101faa","line":24,"updated":"2015-11-10 12:23:26.000000000","message":"Why it is changed?","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class FakeShareDriver(generic.GenericShareDriver):"},{"line_number":25,"context_line":"    \"\"\"Logs calls instead of executing.\"\"\""},{"line_number":26,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":27,"context_line":"        super(FakeShareDriver, self).__init__([True, False], *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_9e8ae562","line":24,"in_reply_to":"da85f559_9f101faa","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"}],"manila/tests/fake_utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\"This modules stubs out functions in manila.utils.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from eventlet import greenthread"},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_49636542","line":16,"updated":"2015-11-12 12:27:11.000000000","message":"Why this file is changed?","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\"This modules stubs out functions in manila.utils.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from eventlet import greenthread"},{"line_number":18,"context_line":"from oslo_log import log"},{"line_number":19,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_890c51ee","line":16,"in_reply_to":"da85f559_49636542","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"}],"manila/tests/scheduler/test_filter_scheduler.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"          for v in (\u0027False\u0027, \u0027\u003cis\u003e False\u0027, \u0027false\u0027, \u00270\u0027)]"},{"line_number":116,"context_line":"    )"},{"line_number":117,"context_line":"    @mock.patch(\u0027manila.db.service_get_all_by_topic\u0027)"},{"line_number":118,"context_line":"    def test__schedule_share_without_snapshot_support("},{"line_number":119,"context_line":"            self, share_type, _mock_service_get_all_by_topic):"},{"line_number":120,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":121,"context_line":"        sched.host_manager \u003d fakes.FakeHostManager()"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_9f87bfd6","side":"PARENT","line":118,"updated":"2015-11-10 12:23:26.000000000","message":"Why it is deleted?","commit_id":"adb72b8f519efe2fd4a73b0080d3517f6c72730e"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"          for v in (\u0027False\u0027, \u0027\u003cis\u003e False\u0027, \u0027false\u0027, \u00270\u0027)]"},{"line_number":116,"context_line":"    )"},{"line_number":117,"context_line":"    @mock.patch(\u0027manila.db.service_get_all_by_topic\u0027)"},{"line_number":118,"context_line":"    def test__schedule_share_without_snapshot_support("},{"line_number":119,"context_line":"            self, share_type, _mock_service_get_all_by_topic):"},{"line_number":120,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":121,"context_line":"        sched.host_manager \u003d fakes.FakeHostManager()"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_dedb8d7a","side":"PARENT","line":118,"in_reply_to":"da85f559_9f87bfd6","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"adb72b8f519efe2fd4a73b0080d3517f6c72730e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    driver_cls \u003d filter_scheduler.FilterScheduler"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_share_no_hosts(self):"},{"line_number":42,"context_line":"        # Ensure empty hosts/child_zones result in NoValidHosts exception."},{"line_number":43,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":44,"context_line":"        fake_context \u003d context.RequestContext(\u0027user\u0027, \u0027project\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_5e7f9ddf","line":41,"updated":"2015-11-12 12:27:11.000000000","message":"Why this file is changed?","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    driver_cls \u003d filter_scheduler.FilterScheduler"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_share_no_hosts(self):"},{"line_number":42,"context_line":"        # Ensure empty hosts/child_zones result in NoValidHosts exception."},{"line_number":43,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":44,"context_line":"        fake_context \u003d context.RequestContext(\u0027user\u0027, \u0027project\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_14e71412","line":41,"in_reply_to":"da85f559_5e7f9ddf","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"}],"manila/tests/share/drivers/glusterfs/test_common.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"315ac4973219ac578431ac112112739e0bc06ae3","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def test_mount_gluster_vol_mounted_noensure(self):"},{"line_number":337,"context_line":"        def exec_runner(*ignore_args, **ignore_kwargs):"},{"line_number":338,"context_line":"            raise exception.ProcessExecutionError(stderr\u003d\u0027already mounted\u0027)"},{"line_number":339,"context_line":"        expected_exec \u003d self._mount_exec(fakeexport, fakemnt)"},{"line_number":340,"context_line":"        fake_utils.fake_execute_set_repliers([(expected_exec[1], exec_runner)])"},{"line_number":341,"context_line":"        self.assertRaises(exception.GlusterfsException,"},{"line_number":342,"context_line":"                          common._mount_gluster_vol,"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_fee691ae","line":339,"updated":"2015-11-12 12:27:11.000000000","message":"Why this file changed?","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def test_mount_gluster_vol_mounted_noensure(self):"},{"line_number":337,"context_line":"        def exec_runner(*ignore_args, **ignore_kwargs):"},{"line_number":338,"context_line":"            raise exception.ProcessExecutionError(stderr\u003d\u0027already mounted\u0027)"},{"line_number":339,"context_line":"        expected_exec \u003d self._mount_exec(fakeexport, fakemnt)"},{"line_number":340,"context_line":"        fake_utils.fake_execute_set_repliers([(expected_exec[1], exec_runner)])"},{"line_number":341,"context_line":"        self.assertRaises(exception.GlusterfsException,"},{"line_number":342,"context_line":"                          common._mount_gluster_vol,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_54b35ce9","line":339,"in_reply_to":"da85f559_fee691ae","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"}],"manila/tests/share/drivers/test_helpers.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@ddt.ddt"},{"line_number":35,"context_line":"class NFSHelperTestCase(test.TestCase):"},{"line_number":36,"context_line":"    \"\"\"Test case for NFS helper of generic driver.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(NFSHelperTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_c35ebb44","line":36,"updated":"2015-12-02 11:16:50.000000000","message":"Comment is wrong.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@ddt.ddt"},{"line_number":35,"context_line":"class NFSHelperTestCase(test.TestCase):"},{"line_number":36,"context_line":"    \"\"\"Test case for NFS helper of generic driver.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(NFSHelperTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_8e0bf3d5","line":36,"in_reply_to":"9a8ffd7b_c35ebb44","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"@ddt.ddt"},{"line_number":170,"context_line":"class CIFSHelperIPAccessTestCase(test.TestCase):"},{"line_number":171,"context_line":"    \"\"\"Test case for CIFS helper of generic driver.\"\"\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def setUp(self):"},{"line_number":174,"context_line":"        super(CIFSHelperIPAccessTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_233ea7da","line":171,"updated":"2015-12-02 11:16:50.000000000","message":"Better to change comment here. Not saying about driver, but about access type.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"@ddt.ddt"},{"line_number":170,"context_line":"class CIFSHelperIPAccessTestCase(test.TestCase):"},{"line_number":171,"context_line":"    \"\"\"Test case for CIFS helper of generic driver.\"\"\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def setUp(self):"},{"line_number":174,"context_line":"        super(CIFSHelperIPAccessTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_8ec0d351","line":171,"in_reply_to":"9a8ffd7b_233ea7da","updated":"2015-12-02 14:11:23.000000000","message":"Done","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"}],"manila/tests/share/drivers/test_lvm.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        share \u003d fake_share(name\u003d\u0027fake_sharename\u0027)"},{"line_number":155,"context_line":"        CONF.set_default(\u0027share_volume_group\u0027, \u0027fake_vg\u0027)"},{"line_number":156,"context_line":"        ret \u003d self._driver._local_path(share)"},{"line_number":157,"context_line":"        self.assertEqual(ret, \u0027/dev/mapper/fake_vg-fake_sharename\u0027)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_local_path_escapes(self):"},{"line_number":160,"context_line":"        share \u003d fake_share(name\u003d\u0027fake-sharename\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_13624ed9","line":157,"updated":"2015-11-16 09:18:20.000000000","message":"Please fix incorrect order assertEqual(observed, expected) as below.\n  assertEqual(observed, expected) \u003d\u003e assertEqual(expected, observed)\n\nself.assertEqual(ret, \u0027/dev/mapper/fake_vg-fake_sharename\u0027) -\u003e \nself.assertEqual(\u0027/dev/mapper/fake_vg-fake_sharename\u0027, ret)","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        share \u003d fake_share(name\u003d\u0027fake_sharename\u0027)"},{"line_number":155,"context_line":"        CONF.set_default(\u0027share_volume_group\u0027, \u0027fake_vg\u0027)"},{"line_number":156,"context_line":"        ret \u003d self._driver._local_path(share)"},{"line_number":157,"context_line":"        self.assertEqual(ret, \u0027/dev/mapper/fake_vg-fake_sharename\u0027)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_local_path_escapes(self):"},{"line_number":160,"context_line":"        share \u003d fake_share(name\u003d\u0027fake-sharename\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_94cea42c","line":157,"in_reply_to":"ba8a016a_13624ed9","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        share \u003d fake_share(name\u003d\u0027fake-sharename\u0027)"},{"line_number":161,"context_line":"        CONF.set_default(\u0027share_volume_group\u0027, \u0027fake-vg\u0027)"},{"line_number":162,"context_line":"        ret \u003d self._driver._local_path(share)"},{"line_number":163,"context_line":"        self.assertEqual(ret, \u0027/dev/mapper/fake--vg-fake--sharename\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def test_create_share(self):"},{"line_number":166,"context_line":"        self._helper_nfs.create_export.return_value \u003d \u0027fakelocation\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_d39a86c5","line":163,"updated":"2015-11-16 09:18:20.000000000","message":"same","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        share \u003d fake_share(name\u003d\u0027fake-sharename\u0027)"},{"line_number":161,"context_line":"        CONF.set_default(\u0027share_volume_group\u0027, \u0027fake-vg\u0027)"},{"line_number":162,"context_line":"        ret \u003d self._driver._local_path(share)"},{"line_number":163,"context_line":"        self.assertEqual(ret, \u0027/dev/mapper/fake--vg-fake--sharename\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def test_create_share(self):"},{"line_number":166,"context_line":"        self._helper_nfs.create_export.return_value \u003d \u0027fakelocation\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_34cfb82a","line":163,"in_reply_to":"ba8a016a_d39a86c5","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            \u0027mkfs.ext4 /dev/mapper/fakevg-fakename\u0027,"},{"line_number":176,"context_line":"        ]"},{"line_number":177,"context_line":"        self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)"},{"line_number":178,"context_line":"        self.assertEqual(ret, \u0027fakelocation\u0027)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_create_share_from_snapshot(self):"},{"line_number":181,"context_line":"        CONF.set_default(\u0027share_lvm_mirrors\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_f39f8ab2","line":178,"updated":"2015-11-16 09:18:20.000000000","message":"same","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            \u0027mkfs.ext4 /dev/mapper/fakevg-fakename\u0027,"},{"line_number":176,"context_line":"        ]"},{"line_number":177,"context_line":"        self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)"},{"line_number":178,"context_line":"        self.assertEqual(ret, \u0027fakelocation\u0027)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_create_share_from_snapshot(self):"},{"line_number":181,"context_line":"        CONF.set_default(\u0027share_lvm_mirrors\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_d4e0ac98","line":178,"in_reply_to":"ba8a016a_f39f8ab2","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            \u0027mkfs.ext4 /dev/mapper/fakevg-fakename\u0027,"},{"line_number":217,"context_line":"        ]"},{"line_number":218,"context_line":"        self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)"},{"line_number":219,"context_line":"        self.assertEqual(ret, \u0027fakelocation\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_deallocate_container(self):"},{"line_number":222,"context_line":"        expected_exec \u003d [\u0027sudo lvremove -f fakevg/fakename\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_b0ba586d","line":219,"updated":"2015-11-16 09:18:20.000000000","message":"self.assertEqual(\u0027fakelocation\u0027, ret)","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            \u0027mkfs.ext4 /dev/mapper/fakevg-fakename\u0027,"},{"line_number":217,"context_line":"        ]"},{"line_number":218,"context_line":"        self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)"},{"line_number":219,"context_line":"        self.assertEqual(ret, \u0027fakelocation\u0027)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_deallocate_container(self):"},{"line_number":222,"context_line":"        expected_exec \u003d [\u0027sudo lvremove -f fakevg/fakename\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_741a207f","line":219,"in_reply_to":"ba8a016a_b0ba586d","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            \"chmod 777 %s\" % (mount_path,),"},{"line_number":342,"context_line":"        ]"},{"line_number":343,"context_line":"        self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)"},{"line_number":344,"context_line":"        self.assertEqual(ret, mount_path)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def test_mount_device_already(self):"},{"line_number":347,"context_line":"        def exec_runner(*ignore_args, **ignore_kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_909e3406","line":344,"updated":"2015-11-16 09:18:20.000000000","message":"self.assertEqual(mount_path, ret)","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            \"chmod 777 %s\" % (mount_path,),"},{"line_number":342,"context_line":"        ]"},{"line_number":343,"context_line":"        self.assertEqual(fake_utils.fake_execute_get_log(), expected_exec)"},{"line_number":344,"context_line":"        self.assertEqual(ret, mount_path)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def test_mount_device_already(self):"},{"line_number":347,"context_line":"        def exec_runner(*ignore_args, **ignore_kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_4f298936","line":344,"in_reply_to":"ba8a016a_909e3406","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    def test_create_export(self):"},{"line_number":418,"context_line":"        ret \u003d self._helper.create_export(self.server, \u0027volume-00001\u0027)"},{"line_number":419,"context_line":"        expected_location \u003d \u0027%s:/shares/volume-00001\u0027 % CONF.share_export_ip"},{"line_number":420,"context_line":"        self.assertEqual(ret, expected_location)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def test_remove_export(self):"},{"line_number":423,"context_line":"        self._helper.remove_export(\u0027/opt/nfs\u0027, \u0027volume-00001\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_50dbeced","line":420,"updated":"2015-11-16 09:18:20.000000000","message":"self.assertEqual(expected_location, ret)","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"76c0d5585c394ed99e42514e707d848feaaa5f19","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    def test_create_export(self):"},{"line_number":418,"context_line":"        ret \u003d self._helper.create_export(self.server, \u0027volume-00001\u0027)"},{"line_number":419,"context_line":"        expected_location \u003d \u0027%s:/shares/volume-00001\u0027 % CONF.share_export_ip"},{"line_number":420,"context_line":"        self.assertEqual(ret, expected_location)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    def test_remove_export(self):"},{"line_number":423,"context_line":"        self._helper.remove_export(\u0027/opt/nfs\u0027, \u0027volume-00001\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_877bd5f4","line":420,"in_reply_to":"ba8a016a_50dbeced","updated":"2015-11-18 13:53:33.000000000","message":"Done","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                                   value, run_as_root\u003dTrue))"},{"line_number":511,"context_line":"        self._helper._execute.assert_has_calls(calls)"},{"line_number":512,"context_line":"        expected_ret \u003d \"//127.0.0.1/%s\" % (share_name,)"},{"line_number":513,"context_line":"        self.assertEqual(ret, expected_ret)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def test_create_export_already_exists(self):"},{"line_number":516,"context_line":"        def exec_runner(*ignore_args, **ignore_kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_50544c53","line":513,"updated":"2015-11-16 09:18:20.000000000","message":"self.assertEqual(expected_ret, ret)","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        self._helper._get_allow_hosts \u003d mock.Mock(return_value\u003d[\u0027127.0.0.1\u0027,"},{"line_number":625,"context_line":"                                                                \u002710.0.0.1\u0027])"},{"line_number":626,"context_line":"        self._helper._set_allow_hosts \u003d mock.Mock()"},{"line_number":627,"context_line":"        self._helper.deny_access(self.server, share_name, {\u0027access_to\u0027:\u002710.0.0.1\u0027})"},{"line_number":628,"context_line":"        self._helper._set_allow_hosts.assert_called_with("},{"line_number":629,"context_line":"            [\u0027127.0.0.1\u0027], share_name)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_b039f843","line":627,"updated":"2015-11-16 09:18:20.000000000","message":"add a apace.\n{\u0027access_to\u0027:\u002710.0.0.1\u0027} -\u003e{\u0027access_to\u0027: \u002710.0.0.1\u0027}","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e1136feaa7474e4249ea8bdaa316163961325b5","unresolved":false,"context_lines":[{"line_number":665,"context_line":"        self._helper._execute \u003d mock.Mock(return_value\u003d("},{"line_number":666,"context_line":"            \u0027127.0.0.1 10.0.0.1\u0027, \u0027\u0027))"},{"line_number":667,"context_line":"        ret \u003d self._helper._get_allow_hosts(share_name)"},{"line_number":668,"context_line":"        self.assertEqual(ret, [\u0027127.0.0.1\u0027, \u002710.0.0.1\u0027])"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    def test_set_allow_hosts(self):"},{"line_number":671,"context_line":"        share_name \u003d self.share[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_9082b4c7","line":668,"updated":"2015-11-16 09:18:20.000000000","message":"self.assertEqual([\u0027127.0.0.1\u0027, \u002710.0.0.1\u0027], ret)","commit_id":"d4faa5bded439420fbe1611ae40be86ae34f68a9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a78bbec35d78079397f919072d46d4d3e00f054a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"\"\"\"Unit tests for the NFS driver module.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_a9f7ab57","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":39},"updated":"2016-01-14 15:51:11.000000000","message":"NFS? Should be \"LVM driver module\".","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"bb8931909b92dd7e60b9a616fb9bc6ad2aea78ee","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"\"\"\"Unit tests for the NFS driver module.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"da6ed579_9ae7f911","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":39},"in_reply_to":"da6ed579_a9f7ab57","updated":"2016-01-18 13:00:06.000000000","message":"Done","commit_id":"b8eabb4a0ab0999c38c884be5e3f054d35476659"}],"manila/tests/test_share_lvm.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c08be0926ae515b0660e565f69d5b1112636da9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"\"\"\"Unit tests for the NFS driver module.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_bfef2386","line":15,"updated":"2015-11-10 12:23:26.000000000","message":"This file should be located in \"manila/tests/share/drivers/test_lvm.py\"","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"159ab2ba5d3adb11fdc027fa7c8058bc6c9b468e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"\"\"\"Unit tests for the NFS driver module.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_1eccb5b9","line":15,"in_reply_to":"da85f559_bfef2386","updated":"2015-11-12 12:04:01.000000000","message":"Done","commit_id":"f07ee71d8b538009a13c5ade3dc6fd9ad252261f"}],"manila_tempest_tests/tests/api/admin/test_multi_backend.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9a9a0aaf990ebebcead3f6238737431c935b3e0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                # //%ip%/%share_path%"},{"line_number":99,"context_line":"                ip \u003d get[\"export_location\"][2:].split(\"/\")[0]"},{"line_number":100,"context_line":"                ips.append(ip)"},{"line_number":101,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":102,"context_line":"            self.assertNotEqual(ips[0], ips[1])"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            self.assertEqual(ips[0], ips[1])"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_ff110f53","line":101,"updated":"2015-12-02 11:16:50.000000000","message":"Why this is changed?","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"0ee834913cf1162a00da123d116d741379d9ce81","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                # //%ip%/%share_path%"},{"line_number":99,"context_line":"                ip \u003d get[\"export_location\"][2:].split(\"/\")[0]"},{"line_number":100,"context_line":"                ips.append(ip)"},{"line_number":101,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":102,"context_line":"            self.assertNotEqual(ips[0], ips[1])"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            self.assertEqual(ips[0], ips[1])"}],"source_content_type":"text/x-python","patch_set":31,"id":"9a8ffd7b_45a16e45","line":101,"in_reply_to":"9a8ffd7b_ff110f53","updated":"2015-12-02 14:11:23.000000000","message":"Hi, Valeriy! With Generic driver and \"multitenancy_enabled\u003dTrue\" we had 2 different share servers in this test, so IPs of shares exports will be different. With LVM driver and \"multitenancy_enabled\u003dFalse\" we haven\u0027t share servers, so export IPs will be the same. Please correct me if I\u0027m wrong.","commit_id":"e852d1257b3cc37bc2c43e4421f8460d590482ae"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b93c28005592d3fbe84f66b6561c0d83c2c43d1f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            \u0027share_type_id\u0027: share_type_id,"},{"line_number":322,"context_line":"            \u0027is_public\u0027: is_public,"},{"line_number":323,"context_line":"        })"},{"line_number":324,"context_line":"        if CONF.share.multitenancy_enabled:"},{"line_number":325,"context_line":"            share_network_id \u003d (share_network_id or client.share_network_id"},{"line_number":326,"context_line":"                                or None)"},{"line_number":327,"context_line":"            kwargs.update({\u0027share_network_id\u0027: share_network_id})"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba8a016a_50538f39","line":324,"updated":"2015-11-23 16:01:28.000000000","message":"Why it is changed? In case of \"multitenancy_enabled\u003dFalse\" it will be None.","commit_id":"9edcda2b4857169341e5c2a68449076e7ea27724"}]}
