)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0f8ff96471b74086d7d7247dd936e041727ef2cf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba8a016a_564bd259","line":9,"updated":"2015-11-16 15:22:33.000000000","message":"This is inaccurate as CLI commands are related to python-manilaclient project. You added API entry points for listing Snapshot Instances.\n\nI would rephrase to \"Added new API entry points for share snapshot instances\"","commit_id":"cb4620e320776f91d0865c5bfe262f4563e37a1d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"91bb2bb4c523aec618e4eecb90147559e8aa6409","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a8ffd7b_b46fe1c2","line":9,"updated":"2015-12-03 12:34:34.000000000","message":"Since you are uploading a new patch, please address my comment from the previous patch.\n\nAlso, since you are changing the API, you should bump microversion and update api_version_request.py and rest_api_version_history.rst.","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_1e92eb57","line":9,"in_reply_to":"9a8ffd7b_b46fe1c2","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"02e304559a15730aa17d97d11115bf15db5166f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_49346ddd","line":9,"updated":"2015-12-10 11:09:37.000000000","message":"Still have not adressed: Please change \"Add new CLI commands\" to \"Add new API entry points\".\n\n\"CLI commands\" refer to python-manilaclient.","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da6ed579_73910b99","line":9,"in_reply_to":"7a740942_49346ddd","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"},{"line_number":13,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_53eb7678","line":12,"updated":"2015-12-07 14:21:22.000000000","message":"What else is left for implementation apart from the list API?","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add new CLI commands for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint snapshot-instances"},{"line_number":13,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da6ed579_33eab310","line":12,"in_reply_to":"7a740942_53eb7678","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":13,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"da0c15f0_9e919455","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":30},"updated":"2016-03-27 01:42:44.000000000","message":"I think you should include other admin actions too.. such as, reset_state and force_delete..","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ced0d03a97debab9bfdb1f1fd3a36e1ee2628d87","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":13,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"da0c15f0_be40d8a6","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2016-03-27 01:56:58.000000000","message":"Please add an APIImpact flag","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-01 17:54:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_b0bafe08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":27},"updated":"2016-04-02 15:00:09.000000000","message":"Add snapshot instances admin APIs","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-01 17:54:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9a061dce_c2cdc65e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":27},"in_reply_to":"ba0121b8_b0bafe08","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":"- share-snapshot-instance-show"},{"line_number":12,"context_line":"- share-snapshot-instance-reset"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_70d98683","line":12,"range":{"start_line":12,"start_character":26,"end_line":12,"end_character":31},"updated":"2016-04-02 15:00:09.000000000","message":"reset-status?","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":"- share-snapshot-instance-show"},{"line_number":12,"context_line":"- share-snapshot-instance-reset"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9a061dce_22dda20e","line":12,"range":{"start_line":12,"start_character":26,"end_line":12,"end_character":31},"in_reply_to":"ba0121b8_70d98683","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add snapshot instances admin APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-detail"},{"line_number":11,"context_line":"- share-snapshot-instance-list"},{"line_number":12,"context_line":"- share-snapshot-instance-show"},{"line_number":13,"context_line":"- share-snapshot-instance-reset-status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a122d0e_b26169ab","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":32},"updated":"2016-04-21 14:53:43.000000000","message":"It is server side change. So, better to write not CLI-like things, because they can be different.","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4639e6f6fc61cedbcbc72c02a1a61cef48095670","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- share-snapshot-instance-reset-status"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":17,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":62,"id":"bacf61ea_5ad616c6","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"updated":"2016-07-28 09:17:47.000000000","message":"Now that we have the api-ref in tree, please include a DocImpact.. we need to update the api-ref to include these APIs","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15b706ec5d9723fe6ed9153e730f5f6ce71e64cc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- share-snapshot-instance-reset-status"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":17,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":62,"id":"bacf61ea_c76fbf90","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"bacf61ea_5ad616c6","updated":"2016-07-28 13:54:23.000000000","message":"Done","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"}],"etc/manila/policy.json":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":42,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":7,"id":"9a8ffd7b_dfcbeb51","line":42,"updated":"2015-12-02 11:29:07.000000000","message":"Please, place it after \"share_snapshot:\" definitions. Also, need to do same changes for \"manila/tests/policy.json\"","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"14ba867f70e76d1f3825d1236c40e7847a674fda","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":42,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":7,"id":"9a8ffd7b_8db770d7","line":42,"in_reply_to":"9a8ffd7b_b79ba317","updated":"2015-12-02 15:13:06.000000000","message":"True sorry.. not here. Please ignore that comment.","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":42,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":7,"id":"7a740942_fefa7fbc","line":42,"in_reply_to":"9a8ffd7b_dfcbeb51","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee53e30a8769d50648a9fd95fe99038c04a47b24","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":42,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":7,"id":"9a8ffd7b_f355c84f","line":42,"in_reply_to":"9a8ffd7b_dfcbeb51","updated":"2015-12-02 14:39:04.000000000","message":"share_snapshot_instances for consistency..","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7e023df8c1c7734f9d5d161297d631289ddd06ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":42,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":7,"id":"9a8ffd7b_b79ba317","line":42,"in_reply_to":"9a8ffd7b_f355c84f","updated":"2015-12-02 14:52:00.000000000","message":"Which consistency? Look around in this file, all are singular. I tis ok.","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \"share_snapshot:reset_status\": \"rule:admin_api\","},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":55,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    \"share_type:index\": \"rule:default\","},{"line_number":58,"context_line":"    \"share_type:show\": \"rule:default\","}],"source_content_type":"application/json","patch_set":10,"id":"7a740942_130c0e40","line":55,"updated":"2015-12-07 14:21:22.000000000","message":"You have the \"show\" method in the policy, but the method is renamed in the API\n\nmanila/api/v2/share_snapshot_instances.py","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \"share_snapshot:force_delete\": \"rule:admin_api\","},{"line_number":62,"context_line":"    \"share_snapshot:reset_status\": \"rule:admin_api\","},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":65,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":66,"context_line":"    \"share_snapshot_instance:reset_status\": \"rule:admin_api\","},{"line_number":67,"context_line":""}],"source_content_type":"application/json","patch_set":18,"id":"ba0121b8_f0d3d65d","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":53},"updated":"2016-04-02 15:00:09.000000000","message":"You now have a /detail API too..","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \"share_snapshot:force_delete\": \"rule:admin_api\","},{"line_number":62,"context_line":"    \"share_snapshot:reset_status\": \"rule:admin_api\","},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    \"share_snapshot_instance:index\": \"rule:admin_api\","},{"line_number":65,"context_line":"    \"share_snapshot_instance:show\": \"rule:admin_api\","},{"line_number":66,"context_line":"    \"share_snapshot_instance:reset_status\": \"rule:admin_api\","},{"line_number":67,"context_line":""}],"source_content_type":"application/json","patch_set":18,"id":"9a061dce_365a0850","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":53},"in_reply_to":"ba0121b8_f0d3d65d","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"02e304559a15730aa17d97d11115bf15db5166f3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    * 2.5 - Share Migration admin API"},{"line_number":54,"context_line":"    * 2.6 - Return share_type UUID instead of name in Share API"},{"line_number":55,"context_line":"    * 2.7 - Rename old extension-like API URLs to core-API-like"},{"line_number":56,"context_line":"    * 2.8 - Share snapshot instances admin API"},{"line_number":57,"context_line":"\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_e97e7969","line":56,"updated":"2015-12-10 11:09:37.000000000","message":"Bump microversion.","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    * 2.5 - Share Migration admin API"},{"line_number":54,"context_line":"    * 2.6 - Return share_type UUID instead of name in Share API"},{"line_number":55,"context_line":"    * 2.7 - Rename old extension-like API URLs to core-API-like"},{"line_number":56,"context_line":"    * 2.8 - Share snapshot instances admin API"},{"line_number":57,"context_line":"\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_f3f3bb08","line":56,"in_reply_to":"7a740942_e97e7969","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"02e304559a15730aa17d97d11115bf15db5166f3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"# The default api version request is defined to be the"},{"line_number":61,"context_line":"# the minimum version of the API supported."},{"line_number":62,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":63,"context_line":"_MAX_API_VERSION \u003d \"2.8\""},{"line_number":64,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_2977a1a0","line":63,"updated":"2015-12-10 11:09:37.000000000","message":"Bump microversion.","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Share snapshot instances admin API"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"\"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_fea090a1","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":43},"updated":"2016-03-27 01:42:44.000000000","message":"list/show APIs","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Share snapshot instances admin APIs(list/show/reset)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"\"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_90c37a8a","line":68,"range":{"start_line":68,"start_character":59,"end_line":68,"end_character":64},"updated":"2016-04-02 15:00:09.000000000","message":"reset-status?","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027migration_get_progress\u0027, \u0027migration_complete\u0027 APIs, renamed"},{"line_number":66,"context_line":"            \u0027migrate_share\u0027 to \u0027migration_start\u0027 and added notify parameter"},{"line_number":67,"context_line":"             to \u0027migration_start\u0027."},{"line_number":68,"context_line":"    * 2.16 - Share snapshot instances admin APIs(list/show/reset)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"\"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_b63c58e3","line":68,"range":{"start_line":68,"start_character":59,"end_line":68,"end_character":64},"in_reply_to":"ba0121b8_90c37a8a","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"02e304559a15730aa17d97d11115bf15db5166f3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---"},{"line_number":67,"context_line":"  Rename old extension-like API URLs to core-API-like."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"2.8"},{"line_number":70,"context_line":"---"},{"line_number":71,"context_line":"  Share snapshot instances admin API"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a740942_a991519c","line":69,"updated":"2015-12-10 11:09:37.000000000","message":"Bump microversion.","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":66,"context_line":"---"},{"line_number":67,"context_line":"  Rename old extension-like API URLs to core-API-like."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"2.8"},{"line_number":70,"context_line":"---"},{"line_number":71,"context_line":"  Share snapshot instances admin API"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da6ed579_b3dea36b","line":69,"in_reply_to":"7a740942_a991519c","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"2.9"},{"line_number":74,"context_line":"---"},{"line_number":75,"context_line":"  Share snapshot instances admin API"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_f0de246c","line":75,"range":{"start_line":75,"start_character":33,"end_line":75,"end_character":36},"updated":"2016-01-14 00:55:33.000000000","message":"missing period","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"2.16"},{"line_number":111,"context_line":"----"},{"line_number":112,"context_line":"  Share snapshot instances admin APIs(list/show/reset)."}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_30454e17","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":55},"updated":"2016-04-02 15:00:09.000000000","message":"Added admin APIs to list/show/reset-status of snapshot instances","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"2.16"},{"line_number":111,"context_line":"----"},{"line_number":112,"context_line":"  Share snapshot instances admin APIs(list/show/reset)."}],"source_content_type":"text/x-rst","patch_set":18,"id":"9a061dce_f626d0cc","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":55},"in_reply_to":"ba0121b8_30454e17","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"}],"manila/api/v1/router.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                       action\u003d\u0027get_share_instances\u0027,"},{"line_number":128,"context_line":"                       conditions\u003d{\"method\": [\u0027GET\u0027]})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self.resources[\u0027share_snapshot_instances\u0027] \u003d ("},{"line_number":131,"context_line":"            share_snapshot_instances.create_resource())"},{"line_number":132,"context_line":"        mapper.resource(\"share_snapshot_instance\", \"share_snapshot_instances\","},{"line_number":133,"context_line":"                        controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_1f96533e","line":130,"updated":"2015-12-02 11:29:07.000000000","message":"That new API should be added only to v2 router, see https://github.com/openstack/manila/tree/master/manila/api/v2","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                       action\u003d\u0027get_share_instances\u0027,"},{"line_number":128,"context_line":"                       conditions\u003d{\"method\": [\u0027GET\u0027]})"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self.resources[\u0027share_snapshot_instances\u0027] \u003d ("},{"line_number":131,"context_line":"            share_snapshot_instances.create_resource())"},{"line_number":132,"context_line":"        mapper.resource(\"share_snapshot_instance\", \"share_snapshot_instances\","},{"line_number":133,"context_line":"                        controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_5b364853","line":130,"in_reply_to":"9a8ffd7b_1f96533e","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"}],"manila/api/v1/share_snapshot_instances.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1c5e072c1fdff4e6556f4071909fb694877238ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_bb45606f","line":1,"updated":"2015-11-12 18:40:21.000000000","message":"Shouldn\u0027t be Huawei?","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"292d63a89de8f8b4cf3f738a5d774a2ad016442d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_2b03f943","line":1,"in_reply_to":"da85f559_bb45606f","updated":"2015-11-16 07:26:43.000000000","message":"Done","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee53e30a8769d50648a9fd95fe99038c04a47b24","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from webob import exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila.api.openstack import wsgi"},{"line_number":19,"context_line":"from manila.api.views import share_snapshot_instance as instance_view"},{"line_number":20,"context_line":"from manila import db"},{"line_number":21,"context_line":"from manila import exception"},{"line_number":22,"context_line":"from manila import policy"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_b37420fe","line":19,"updated":"2015-12-02 14:39:04.000000000","message":"s/share_snapshot_instance/share_snapshot_instances for consistency","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee53e30a8769d50648a9fd95fe99038c04a47b24","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotInstancesController(wsgi.Controller):"},{"line_number":27,"context_line":"    \"\"\"The share instances API controller for the OpenStack API.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    resource_name \u003d \u0027share_snapshot_instance\u0027"},{"line_number":30,"context_line":"    _view_builder_class \u003d instance_view.ViewBuilder"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_9318fcd4","line":27,"updated":"2015-12-02 14:39:04.000000000","message":"do you mean share snapshot instances API controller?","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotInstancesController(wsgi.Controller):"},{"line_number":27,"context_line":"    \"\"\"The share instances API controller for the OpenStack API.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    resource_name \u003d \u0027share_snapshot_instance\u0027"},{"line_number":30,"context_line":"    _view_builder_class \u003d instance_view.ViewBuilder"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_3b6a5c1b","line":27,"in_reply_to":"9a8ffd7b_9318fcd4","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee53e30a8769d50648a9fd95fe99038c04a47b24","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        try:"},{"line_number":38,"context_line":"            policy.check_policy(context, self.resource_name, action)"},{"line_number":39,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":40,"context_line":"            raise exc.HTTPForbidden()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":43,"context_line":"    def index(self, req):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_336a70ee","line":40,"updated":"2015-12-02 14:39:04.000000000","message":"This isn\u0027t necessary.. \n\nuse the decorator from wsgi.py\u0027s Controller for policy checking..\n\n\n    @wsgi.Controller.authorize\n    def index(self, req):\n\nwill do the same thing as:\n\n    def index(self, req):\n        context \u003d req.environ[\u0027manila.context\u0027]\n        self._authorize(context, \u0027index\u0027)","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        try:"},{"line_number":38,"context_line":"            policy.check_policy(context, self.resource_name, action)"},{"line_number":39,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":40,"context_line":"            raise exc.HTTPForbidden()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":43,"context_line":"    def index(self, req):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_5bd2c8d3","line":40,"in_reply_to":"9a8ffd7b_336a70ee","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":40,"context_line":"            raise exc.HTTPForbidden()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":43,"context_line":"    def index(self, req):"},{"line_number":44,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":45,"context_line":"        self._authorize(context, \u0027index\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_9fc5635d","line":42,"updated":"2015-12-02 11:29:07.000000000","message":"It is wrong microversion. You implement completely new API. And new API requires bump of microversion, and newest one should be set in that decorator.\n\nAlso, it should be placed under v2 API dir, see https://github.com/openstack/manila/tree/master/manila/api/v2","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        except exception.PolicyNotAuthorized:"},{"line_number":40,"context_line":"            raise exc.HTTPForbidden()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":43,"context_line":"    def index(self, req):"},{"line_number":44,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":45,"context_line":"        self._authorize(context, \u0027index\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_be04f7bf","line":42,"in_reply_to":"9a8ffd7b_9fc5635d","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":51,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":52,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":53,"context_line":"        self._authorize(context, \u0027index\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, share_snapshot_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_9f9c836b","line":53,"updated":"2015-12-02 11:29:07.000000000","message":"We have dedicated decorator for auth. See https://github.com/openstack/manila/commit/379ee2f31ca62fba16609b7aaf5ecb3670791463","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee53e30a8769d50648a9fd95fe99038c04a47b24","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":51,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":52,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":53,"context_line":"        self._authorize(context, \u0027index\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, share_snapshot_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_1c6ad4b3","line":53,"in_reply_to":"9a8ffd7b_9f9c836b","updated":"2015-12-02 14:39:04.000000000","message":"+1","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @wsgi.Controller.api_version(\"2.3\")"},{"line_number":51,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":52,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":53,"context_line":"        self._authorize(context, \u0027index\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, share_snapshot_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_deff83a8","line":53,"in_reply_to":"9a8ffd7b_9f9c836b","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"}],"manila/api/v2/router.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                        controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"},{"line_number":177,"context_line":"                        collection\u003d{\u0027detail\u0027: \u0027GET\u0027},"},{"line_number":178,"context_line":"                        member\u003d{\u0027action\u0027: \u0027POST\u0027})"},{"line_number":179,"context_line":"        mapper.connect(\"share_snapshot_instance\","},{"line_number":180,"context_line":"                       \"/{project_id}/snapshots/{share_snapshot_id}/instances\","},{"line_number":181,"context_line":"                       controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"},{"line_number":182,"context_line":"                       action\u003d\u0027get_share_snapshot_instances\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_73df920d","line":179,"updated":"2015-12-07 14:21:22.000000000","message":"I guess this isn\u0027t necessary if you rename the single snapshot listing API to \"show\" -\u003e Please evaluate removing 179-183","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        mapper.resource(\"share_snapshot_instance\", \"share_snapshot_instances\","},{"line_number":172,"context_line":"                        controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"},{"line_number":173,"context_line":"                        collection\u003d{\u0027detail\u0027: \u0027GET\u0027},"},{"line_number":174,"context_line":"                        member\u003d{\u0027action\u0027: \u0027POST\u0027})"},{"line_number":175,"context_line":"        mapper.connect(\"share_snapshot_instance\","},{"line_number":176,"context_line":"                       \"/{project_id}/snapshots/{share_snapshot_id}/instances\","},{"line_number":177,"context_line":"                       controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_3a2496ad","line":174,"range":{"start_line":174,"start_character":32,"end_line":174,"end_character":48},"updated":"2016-01-14 00:55:33.000000000","message":"We don\u0027t have a POST API..","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        mapper.connect(\"share_snapshot_instance\","},{"line_number":176,"context_line":"                       \"/{project_id}/snapshots/{share_snapshot_id}/instances\","},{"line_number":177,"context_line":"                       controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"},{"line_number":178,"context_line":"                       action\u003d\u0027get_share_snapshot_instances\u0027,"},{"line_number":179,"context_line":"                       conditions\u003d{\"method\": [\u0027GET\u0027]})"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.resources[\"share_metadata\"] \u003d share_metadata.create_resource()"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_fa0fde2b","line":178,"range":{"start_line":178,"start_character":31,"end_line":178,"end_character":59},"updated":"2016-01-14 00:55:33.000000000","message":"Where is this action?","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.resources[\u0027share_snapshot_instances\u0027] \u003d ("},{"line_number":209,"context_line":"            share_snapshot_instances.create_resource())"},{"line_number":210,"context_line":"        mapper.resource(\"share_snapshot_instance\", \"share_snapshot_instances\","},{"line_number":211,"context_line":"                        controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"},{"line_number":212,"context_line":"                        collection\u003d{\u0027detail\u0027: \u0027GET\u0027},"},{"line_number":213,"context_line":"                        member\u003d{\u0027action\u0027: \u0027POST\u0027})"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_7e83e004","line":210,"range":{"start_line":210,"start_character":25,"end_line":210,"end_character":48},"updated":"2016-03-27 01:42:44.000000000","message":"Should have the hyphenated aliases too:\n\nshare-snapshot-instances, share-snapshot-instance","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                        controller\u003dself.resources[\"snapshots\"],"},{"line_number":200,"context_line":"                        collection\u003d{\"detail\": \"GET\"},"},{"line_number":201,"context_line":"                        member\u003d{\"action\": \"POST\"})"},{"line_number":202,"context_line":"        mapper.connect(\"snapshots\","},{"line_number":203,"context_line":"                       \"/{project_id}/snapshots/manage\","},{"line_number":204,"context_line":"                       controller\u003dself.resources[\"snapshots\"],"},{"line_number":205,"context_line":"                       action\u003d\"manage\","}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_7047c61d","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":8},"updated":"2016-04-02 15:00:09.000000000","message":"This empty line need not be removed..","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                        controller\u003dself.resources[\"snapshots\"],"},{"line_number":200,"context_line":"                        collection\u003d{\"detail\": \"GET\"},"},{"line_number":201,"context_line":"                        member\u003d{\"action\": \"POST\"})"},{"line_number":202,"context_line":"        mapper.connect(\"snapshots\","},{"line_number":203,"context_line":"                       \"/{project_id}/snapshots/manage\","},{"line_number":204,"context_line":"                       controller\u003dself.resources[\"snapshots\"],"},{"line_number":205,"context_line":"                       action\u003d\"manage\","}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_d608ec2f","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":8},"in_reply_to":"ba0121b8_7047c61d","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"12210872f1ed4b1374115ec6326d052a4f64ef05","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self.resources[\u0027share_snapshot_instances\u0027] \u003d ("},{"line_number":210,"context_line":"            share_snapshot_instances.create_resource())"},{"line_number":211,"context_line":"        mapper.resource(\"share-snapshot-instance\", \"share-snapshot-instances\","},{"line_number":212,"context_line":"                        controller\u003dself.resources[\u0027share_snapshot_instances\u0027],"},{"line_number":213,"context_line":"                        collection\u003d{\u0027detail\u0027: \u0027GET\u0027},"},{"line_number":214,"context_line":"                        member\u003d{\u0027action\u0027: \u0027POST\u0027})"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_61cac650","line":211,"range":{"start_line":211,"start_character":52,"end_line":211,"end_character":66},"updated":"2016-05-05 14:21:41.000000000","message":"We have \"snapshot\"s in Manila, so its instances should be \"snapshot-instance\"s. Otherwise we should rename \"snapshot\" API to \"share-snapshot\". Same for classnames, client commands, etc...","commit_id":"f5f3af1c7948b1f9fd4be8acd62451d9685951c5"}],"manila/api/v2/share_snapshot_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from webob import exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila.api.openstack import wsgi"},{"line_number":19,"context_line":"from manila.api.views import share_snapshot_instance as instance_view"},{"line_number":20,"context_line":"from manila import db"},{"line_number":21,"context_line":"from manila import exception"},{"line_number":22,"context_line":"from manila import share"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_d37c46b7","line":19,"updated":"2015-12-07 14:21:22.000000000","message":"try and use the same name as this file for the view builder file as well:\n\n\nshare_snapshot_instances.py","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return self._view_builder.detail_list(req, instances)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @wsgi.Controller.api_version(\"2.8\")"},{"line_number":44,"context_line":"    @wsgi.Controller.authorize(\u0027index\u0027)"},{"line_number":45,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":46,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_73331215","line":44,"updated":"2015-12-07 14:21:22.000000000","message":"When you rename the below method to \"show\", you no longer need to pass the name of the method to authorize..","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return self._view_builder.detail_list(req, instances)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @wsgi.Controller.api_version(\"2.8\")"},{"line_number":44,"context_line":"    @wsgi.Controller.authorize(\u0027index\u0027)"},{"line_number":45,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":46,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_93735f15","line":44,"in_reply_to":"7a740942_73331215","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @wsgi.Controller.api_version(\"2.8\")"},{"line_number":44,"context_line":"    @wsgi.Controller.authorize(\u0027index\u0027)"},{"line_number":45,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":46,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_5312960a","line":45,"updated":"2015-12-07 14:21:22.000000000","message":"rename this method to \"show\"\n\nSince this is retrieving details of a single snapshot instance.. \n\nlike the show methods for the rest of the resources we have:\n\nEx:\n\nShares: https://github.com/openstack/manila/blob/2686e32/manila/api/v1/shares.py#L56\n\n\nSnapshots: https://github.com/openstack/manila/blob/31a19b1/manila/api/v1/share_snapshots.py#L73\n\nShare Networks: https://github.com/openstack/manila/blob/31a19b1fb/manila/api/v1/share_networks.py#L52\n\netc.\n\nAlso, you\u0027ve used \"show\" as the method name in policy.json","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @wsgi.Controller.api_version(\"2.8\")"},{"line_number":44,"context_line":"    @wsgi.Controller.authorize(\u0027index\u0027)"},{"line_number":45,"context_line":"    def get_share_snapshot_instances(self, req, share_snapshot_id):"},{"line_number":46,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_734fcbbd","line":45,"in_reply_to":"7a740942_5312960a","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @wsgi.Controller.api_version(\"2.9\")"},{"line_number":36,"context_line":"    @wsgi.Controller.authorize"},{"line_number":37,"context_line":"    def index(self, req):"},{"line_number":38,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        instances \u003d db.share_snapshot_instances_get_all(context)"},{"line_number":41,"context_line":"        return self._view_builder.detail_list(req, instances)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @wsgi.Controller.api_version(\"2.9\")"},{"line_number":44,"context_line":"    def show(self, req, share_snapshot_id):"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_25c4698f","line":41,"range":{"start_line":37,"start_character":4,"end_line":41,"end_character":61},"updated":"2016-01-14 00:55:33.000000000","message":"we could also look for a query parameter \"snapshot ID\" so that we can get a list of snapshot instances for a given snapshot.. \n\nexample:\nhttps://review.openstack.org/#/c/238572/15/manila/api/v2/share_replicas.py\n\nthe _get_share_replicas method looks for the share_id as a query parameter:     \n\n    share_id \u003d req.params.get(\u0027share_id\u0027)","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return self._view_builder.detail_list(req, instances)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @wsgi.Controller.api_version(\"2.9\")"},{"line_number":44,"context_line":"    def show(self, req, share_snapshot_id):"},{"line_number":45,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_c560edd1","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":7},"updated":"2016-01-14 00:55:33.000000000","message":"missing the authorize decorator","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            raise exc.HTTPNotFound()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        view \u003d instance_view.ViewBuilder()"},{"line_number":53,"context_line":"        return view.detail_list(req, snapshot[\u0027instances\u0027])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_254b092c","line":53,"range":{"start_line":53,"start_character":15,"end_line":53,"end_character":31},"updated":"2016-01-14 00:55:33.000000000","message":"self._view_builder.detail()","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_be7d781e","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-03-27 01:42:44.000000000","message":"2016?","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareSnapshotInstancesController(wsgi.Controller,"},{"line_number":27,"context_line":"                                       wsgi.AdminActionsMixin):"},{"line_number":28,"context_line":"    \"\"\"The share snapshot instances API controller for the OpenStack API.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    resource_name \u003d \u0027share_snapshot_instance\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_dea94c7d","line":27,"range":{"start_line":27,"start_character":44,"end_line":27,"end_character":61},"updated":"2016-03-27 01:42:44.000000000","message":"If you have inherited the AdminActionsMixin, you should provide override methods for _get(), _delete() and _update() and you will be able to use the reset-state and force-delete APIs as well.","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def index(self, req):"},{"line_number":40,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":41,"context_line":"        snapshot_id \u003d req.params.get(\u0027snapshot_id\u0027)"},{"line_number":42,"context_line":"        if snapshot_id:"},{"line_number":43,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, snapshot_id)"},{"line_number":44,"context_line":"            instances \u003d snapshot[\u0027instances\u0027]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            instances \u003d db.share_snapshot_instances_get_all(context)"},{"line_number":47,"context_line":"        return self._view_builder.detail_list(req, instances)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @wsgi.Controller.api_version(\u00272.16\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_fe77f037","line":46,"range":{"start_line":42,"start_character":8,"end_line":46,"end_character":68},"updated":"2016-03-27 01:42:44.000000000","message":"You could use:\n\n    instances \u003d db.share_snapshot_instance_get_all_with_filters(context, {\u0027snapshot_ids\u0027: snapshot_id})","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            instances \u003d snapshot[\u0027instances\u0027]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            instances \u003d db.share_snapshot_instances_get_all(context)"},{"line_number":47,"context_line":"        return self._view_builder.detail_list(req, instances)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @wsgi.Controller.api_version(\u00272.16\u0027)"},{"line_number":50,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_9e9fd44f","line":47,"range":{"start_line":47,"start_character":34,"end_line":47,"end_character":45},"updated":"2016-03-27 01:42:44.000000000","message":"index calls must give you a summary containing the minimum required keys.. \n\ndetail should be its own API.. \n\nTake a look at share_replicas.py for an example..","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        try:"},{"line_number":55,"context_line":"            snapshot_instance \u003d db.share_snapshot_instance_get("},{"line_number":56,"context_line":"                context, id)"},{"line_number":57,"context_line":"        except exception.NotFound:"},{"line_number":58,"context_line":"            msg \u003d (_(\"Snapshot instance %s not found.\") % id)"},{"line_number":59,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":60,"context_line":"        return self._view_builder.detail(req, snapshot_instance)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_de72ec48","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":33},"updated":"2016-03-27 01:42:44.000000000","message":"exception.ShareSnapshotInstanceNotFound","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":68,"context_line":"                context, {\u0027snapshot_ids\u0027: snapshot_id})"},{"line_number":69,"context_line":"        except exception.NotFound:"},{"line_number":70,"context_line":"            msg \u003d (_(\"Snapshot instance with snapshot ID %s not found.\")"},{"line_number":71,"context_line":"                   % snapshot_id)"},{"line_number":72,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_10d2ca34","line":69,"range":{"start_line":69,"start_character":15,"end_line":69,"end_character":33},"updated":"2016-04-02 15:00:09.000000000","message":"This exception is not raised by the db api you used.. It does querying with filters.. so, if Snapshot ID is invalid, it will return an empty list...\n\nTwo ways of doing this.. \n\n1) Validate snapshot before this call and return HTTPBadRequest if it is an invalid snapshot ID or name, or\n\n2) after you get instances, check if (snapshot_id is provided and list is empty), return HTTPBadRequest","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Reset the \u0027status\u0027 attribute in the database.\"\"\""},{"line_number":83,"context_line":"        return self._reset_status(req, id, body)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _update(self, *args, **kwargs):"},{"line_number":86,"context_line":"        db.share_snapshot_instance_update(*args, **kwargs)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_928f0d75","line":86,"range":{"start_line":85,"start_character":4,"end_line":86,"end_character":58},"updated":"2016-04-21 14:53:43.000000000","message":"Where is it used?","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        \"\"\"Reset the \u0027status\u0027 attribute in the database.\"\"\""},{"line_number":83,"context_line":"        return self._reset_status(req, id, body)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _update(self, *args, **kwargs):"},{"line_number":86,"context_line":"        db.share_snapshot_instance_update(*args, **kwargs)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_9644d3b7","line":86,"range":{"start_line":85,"start_character":4,"end_line":86,"end_character":58},"in_reply_to":"1a122d0e_928f0d75","updated":"2016-04-23 09:44:21.000000000","message":"API reset-status will call this function.\n\nPlease see this link:\nhttps://github.com/openstack/manila/blob/master/manila/api/openstack/wsgi.py#L1234","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"763d4f3be58f753514379c561c2926fde2182e79","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"},{"line_number":68,"context_line":"        if not instances:"},{"line_number":69,"context_line":"            msg \u003d (_(\"Snapshot instance with snapshot ID %s not found.\")"},{"line_number":70,"context_line":"                   % snapshot_id)"},{"line_number":71,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1a122d0e_24ec8528","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":39},"updated":"2016-04-25 19:35:14.000000000","message":"instances","commit_id":"44db1670ca444ce76e9a231386396b8be3ead75e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"},{"line_number":68,"context_line":"        if not instances:"},{"line_number":69,"context_line":"            msg \u003d (_(\"Snapshot instances with snapshot ID %s not found.\")"},{"line_number":70,"context_line":"                   % snapshot_id)"},{"line_number":71,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if is_detail:"},{"line_number":74,"context_line":"            instances \u003d self._view_builder.detail_list(req, instances)"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_b20eca38","line":71,"range":{"start_line":68,"start_character":8,"end_line":71,"end_character":53},"updated":"2016-06-24 10:23:51.000000000","message":"It is list operation. It should return empty list if nothing exists.","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"},{"line_number":68,"context_line":"        if not instances:"},{"line_number":69,"context_line":"            msg \u003d (_(\"Snapshot instances with snapshot ID %s not found.\")"},{"line_number":70,"context_line":"                   % snapshot_id)"},{"line_number":71,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if is_detail:"},{"line_number":74,"context_line":"            instances \u003d self._view_builder.detail_list(req, instances)"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_a1eac8d8","line":71,"range":{"start_line":68,"start_character":8,"end_line":71,"end_character":53},"in_reply_to":"3aaa91ec_b20eca38","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _get_instances(self, req, is_detail\u003dFalse):"},{"line_number":62,"context_line":"        \"\"\"Returns list of snapshot instances.\"\"\""},{"line_number":63,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":64,"context_line":"        snapshot_id \u003d req.params.get(\u0027snapshot_id\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_47180c85","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":51},"updated":"2016-07-28 03:43:02.000000000","message":"You should verify that this, if not None, is a valid manila snapshot ID and return HTTPBadRequest if it is not..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _get_instances(self, req, is_detail\u003dFalse):"},{"line_number":62,"context_line":"        \"\"\"Returns list of snapshot instances.\"\"\""},{"line_number":63,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":64,"context_line":"        snapshot_id \u003d req.params.get(\u0027snapshot_id\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_8b232a05","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":51},"in_reply_to":"bacf61ea_47180c85","updated":"2016-07-28 08:43:59.000000000","message":"ManilaClient has checked whether manila snapshot ID is valid, Is there need to check it again? \n\nIf the snapshot_id is None, it will return all instances.\nIf the snapshot_id is not None: \n1. snapshot_id exists: it will return special snapshot instance\n2. snapshot_id not exists: it will return HTTPNotFound?\nDoes I need to add follow code?\n\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\ntry:\n    db.share_snapshot_get(context, snapshot_id)\nexcept exception.NotFound:\n    msg \u003d _(\"Snapshot ID %s not found.\") % snapshot_id\n    raise exc.HTTPNotFound(explanation\u003dmsg)\n\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\n\nwhy need to return HTTPBadRequest?","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9b43b7900c75f2694dfcee7b5f7785d17cd18a48","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _get_instances(self, req, is_detail\u003dFalse):"},{"line_number":62,"context_line":"        \"\"\"Returns list of snapshot instances.\"\"\""},{"line_number":63,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":64,"context_line":"        snapshot_id \u003d req.params.get(\u0027snapshot_id\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_5a9e1657","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":51},"updated":"2016-07-28 09:15:24.000000000","message":"in response to your previous question, we should return HTTPBadRequest here if snapshot_id is invalid; manila client may be performing this check, but the REST API is not supposed to be designed only for the manila client..","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0291bc845a21c3fbdd9b5439eed5abd84a77a5fe","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def _get_instances(self, req, is_detail\u003dFalse):"},{"line_number":62,"context_line":"        \"\"\"Returns list of snapshot instances.\"\"\""},{"line_number":63,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":64,"context_line":"        snapshot_id \u003d req.params.get(\u0027snapshot_id\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        instances \u003d db.share_snapshot_instance_get_all_with_filters("},{"line_number":67,"context_line":"            context, {\u0027snapshot_ids\u0027: snapshot_id})"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_f0c8c976","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":51},"in_reply_to":"bacf61ea_5a9e1657","updated":"2016-07-28 09:47:54.000000000","message":"Thanks for checking on the channel. I reviewed a few other uses. Please leave your implementation as is. HTTPBadRequest may appropriate here but using it would lead to an inconsistent behavior since we don\u0027t do that on \"filters\" across the board in manila.","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"}],"manila/api/views/share_snapshot_instance.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1c5e072c1fdff4e6556f4071909fb694877238ba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    _collection_name \u003d \u0027share_snapshot_instances\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def detail_list(self, request, instances):"},{"line_number":22,"context_line":"        \"\"\"Detailed view of a list of share instances.\"\"\""},{"line_number":23,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def detail(self, request, share_snapshot_instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_d6011b06","line":22,"updated":"2015-11-12 18:40:21.000000000","message":"snapshot instances","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"292d63a89de8f8b4cf3f738a5d774a2ad016442d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    _collection_name \u003d \u0027share_snapshot_instances\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def detail_list(self, request, instances):"},{"line_number":22,"context_line":"        \"\"\"Detailed view of a list of share instances.\"\"\""},{"line_number":23,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def detail(self, request, share_snapshot_instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_4bfe7d39","line":22,"in_reply_to":"da85f559_d6011b06","updated":"2015-11-16 07:26:43.000000000","message":"Done","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1c5e072c1fdff4e6556f4071909fb694877238ba","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def detail(self, request, share_snapshot_instance):"},{"line_number":26,"context_line":"        \"\"\"Detailed view of a single share instance.\"\"\""},{"line_number":27,"context_line":"        instance_dict \u003d {"},{"line_number":28,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"},{"line_number":29,"context_line":"            \u0027snapshot_id\u0027: share_snapshot_instance.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_b60a571e","line":26,"updated":"2015-11-12 18:40:21.000000000","message":"snapshot instance","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"292d63a89de8f8b4cf3f738a5d774a2ad016442d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def detail(self, request, share_snapshot_instance):"},{"line_number":26,"context_line":"        \"\"\"Detailed view of a single share instance.\"\"\""},{"line_number":27,"context_line":"        instance_dict \u003d {"},{"line_number":28,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"},{"line_number":29,"context_line":"            \u0027snapshot_id\u0027: share_snapshot_instance.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_ebfc1140","line":26,"in_reply_to":"da85f559_b60a571e","updated":"2015-11-16 07:26:43.000000000","message":"Done","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee53e30a8769d50648a9fd95fe99038c04a47b24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_dcee8cec","line":1,"updated":"2015-12-02 14:39:04.000000000","message":"Please rename this file share_snapshot_instances.py for consistency..","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_9befd086","line":1,"in_reply_to":"9a8ffd7b_dcee8cec","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    _collection_name \u003d \u0027share_snapshot_instances\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def detail_list(self, request, instances):"},{"line_number":24,"context_line":"        \"\"\"Detailed view of a list of share instances.\"\"\""},{"line_number":25,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def detail(self, request, share_snapshot_instance):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_932d5e97","line":24,"updated":"2015-12-07 14:21:22.000000000","message":"snapshot instances?","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    _collection_name \u003d \u0027share_snapshot_instances\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def detail_list(self, request, instances):"},{"line_number":24,"context_line":"        \"\"\"Detailed view of a list of share instances.\"\"\""},{"line_number":25,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def detail(self, request, share_snapshot_instance):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_f3e89b7e","line":24,"in_reply_to":"7a740942_932d5e97","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def detail(self, request, share_snapshot_instance):"},{"line_number":28,"context_line":"        \"\"\"Detailed view of a single share instance.\"\"\""},{"line_number":29,"context_line":"        instance_dict \u003d {"},{"line_number":30,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"},{"line_number":31,"context_line":"            \u0027snapshot_id\u0027: share_snapshot_instance.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_f33ce2c9","line":28,"updated":"2015-12-07 14:21:22.000000000","message":"same","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def detail(self, request, share_snapshot_instance):"},{"line_number":28,"context_line":"        \"\"\"Detailed view of a single share instance.\"\"\""},{"line_number":29,"context_line":"        instance_dict \u003d {"},{"line_number":30,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"},{"line_number":31,"context_line":"            \u0027snapshot_id\u0027: share_snapshot_instance.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_13ec4f8e","line":28,"in_reply_to":"7a740942_f33ce2c9","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"},{"line_number":31,"context_line":"            \u0027snapshot_id\u0027: share_snapshot_instance.get(\u0027snapshot_id\u0027),"},{"line_number":32,"context_line":"            \u0027created_at\u0027: share_snapshot_instance.get(\u0027created_at\u0027),"},{"line_number":33,"context_line":"            \u0027status\u0027: share_snapshot_instance.get(\u0027status\u0027),"},{"line_number":34,"context_line":"        }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        return {\u0027share_snapshot_instance\u0027: instance_dict}"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_c58eb978","line":33,"updated":"2015-12-07 14:21:22.000000000","message":"I think the share_id would be helpful as well...\n\nshare_snapshot_instance.share_id","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"},{"line_number":31,"context_line":"            \u0027snapshot_id\u0027: share_snapshot_instance.get(\u0027snapshot_id\u0027),"},{"line_number":32,"context_line":"            \u0027created_at\u0027: share_snapshot_instance.get(\u0027created_at\u0027),"},{"line_number":33,"context_line":"            \u0027status\u0027: share_snapshot_instance.get(\u0027status\u0027),"},{"line_number":34,"context_line":"        }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        return {\u0027share_snapshot_instance\u0027: instance_dict}"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_339633f1","line":33,"in_reply_to":"7a740942_c58eb978","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"}],"manila/api/views/share_snapshot_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_3e904843","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-03-27 01:42:44.000000000","message":"2016","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":19,"context_line":"    \"\"\"Model a server API response as a python dictionary.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _collection_name \u003d \u0027share_snapshot_instances\u0027"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_1e93c450","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":14},"updated":"2016-03-27 01:42:44.000000000","message":"nit: the","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \"\"\"Detailed view of a list of share snapshot instances.\"\"\""},{"line_number":25,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def detail(self, request, share_snapshot_instance):"},{"line_number":28,"context_line":"        \"\"\"Detailed view of a single share snapshot instance.\"\"\""},{"line_number":29,"context_line":"        instance_dict \u003d {"},{"line_number":30,"context_line":"            \u0027id\u0027: share_snapshot_instance.get(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_5e9d3c58","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":14},"updated":"2016-03-27 01:42:44.000000000","message":"You need a summary view for the index API and detail for the show API..","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                share_snapshot_instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027progress\u0027: share_snapshot_instance.get(\u0027progress\u0027),"},{"line_number":40,"context_line":"            \u0027provider_location\u0027:"},{"line_number":41,"context_line":"                share_snapshot_instance.get(\u0027provider_location\u0027),"},{"line_number":42,"context_line":"        }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return {\u0027share_snapshot_instance\u0027: instance_dict}"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_7e9ac064","line":41,"range":{"start_line":41,"start_character":62,"end_line":41,"end_character":65},"updated":"2016-03-27 01:42:44.000000000","message":"You should include \u0027share_id\u0027","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":47,"context_line":"            \u0027created_at\u0027: instance.get(\u0027created_at\u0027),"},{"line_number":48,"context_line":"            \u0027updated_at\u0027: instance.get(\u0027updated_at\u0027),"},{"line_number":49,"context_line":"            \u0027deleted_at\u0027: instance.get(\u0027deleted_at\u0027),"},{"line_number":50,"context_line":"            \u0027deleted\u0027: instance.get(\u0027deleted\u0027),"},{"line_number":51,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":52,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_id\u0027),"},{"line_number":53,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_90a25a99","line":50,"range":{"start_line":49,"start_character":12,"end_line":50,"end_character":47},"updated":"2016-04-02 15:00:09.000000000","message":"These two keys are not necessary","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":47,"context_line":"            \u0027created_at\u0027: instance.get(\u0027created_at\u0027),"},{"line_number":48,"context_line":"            \u0027updated_at\u0027: instance.get(\u0027updated_at\u0027),"},{"line_number":49,"context_line":"            \u0027deleted_at\u0027: instance.get(\u0027deleted_at\u0027),"},{"line_number":50,"context_line":"            \u0027deleted\u0027: instance.get(\u0027deleted\u0027),"},{"line_number":51,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":52,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_id\u0027),"},{"line_number":53,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_815c70ee","line":50,"range":{"start_line":49,"start_character":12,"end_line":50,"end_character":47},"in_reply_to":"ba0121b8_90a25a99","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def summary(self, request, instance):"},{"line_number":32,"context_line":"        \"\"\"Generic, non-detailed view of a share replica.\"\"\""},{"line_number":33,"context_line":"        instance_dict \u003d {"},{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        return {\u0027share_snapshot_instance\u0027: instance_dict}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_d286a515","line":38,"range":{"start_line":34,"start_character":12,"end_line":38,"end_character":67},"updated":"2016-04-21 14:53:43.000000000","message":"Why \"provider_location\" is absent here? It is much preferred than share[_instance]_id\u0027s.","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def summary(self, request, instance):"},{"line_number":32,"context_line":"        \"\"\"Generic, non-detailed view of a share replica.\"\"\""},{"line_number":33,"context_line":"        instance_dict \u003d {"},{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"        return {\u0027share_snapshot_instance\u0027: instance_dict}"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_36585ffa","line":38,"range":{"start_line":34,"start_character":12,"end_line":38,"end_character":67},"in_reply_to":"1a122d0e_d286a515","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def summary(self, request, instance):"},{"line_number":32,"context_line":"        \"\"\"Generic, non-detailed view of a share replica.\"\"\""},{"line_number":33,"context_line":"        instance_dict \u003d {"},{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_555af02a","line":32,"range":{"start_line":32,"start_character":43,"end_line":32,"end_character":56},"updated":"2016-06-24 10:23:51.000000000","message":"share replica?","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        return self._list_view(self.detail, request, instances)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def summary(self, request, instance):"},{"line_number":32,"context_line":"        \"\"\"Generic, non-detailed view of a share replica.\"\"\""},{"line_number":33,"context_line":"        instance_dict \u003d {"},{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_41b684f9","line":32,"range":{"start_line":32,"start_character":43,"end_line":32,"end_character":56},"in_reply_to":"3aaa91ec_555af02a","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"93f3ad2b9370c6e8ed5166bf3b48e048fd848573","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"},{"line_number":40,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":51,"id":"1aa78d24_40e0d7fa","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":71},"updated":"2016-07-09 16:06:40.000000000","message":"This seems right.  But I wonder if we should just change the share_id property in the ShareSnapshotInstance model to really be the share_id instead of the share_instance_id ?","commit_id":"bf6309592ed500c49bd92ac8d9f66fce614bd32b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b6734275f3437a61c7e671b10a009cdffc9c1cc7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"},{"line_number":40,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":51,"id":"1aa78d24_5ce8a510","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":71},"in_reply_to":"1aa78d24_40e0d7fa","updated":"2016-07-11 10:08:55.000000000","message":"That what I thought before. But I saw u_glide added it, and it sounds like it is very useful for u_glide.  Maybe we could see all of other code and open another bug to change all of this?  This bug could be merged after this bp? Thanks Tom\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L704","commit_id":"bf6309592ed500c49bd92ac8d9f66fce614bd32b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"93f3ad2b9370c6e8ed5166bf3b48e048fd848573","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027created_at\u0027: instance.get(\u0027created_at\u0027),"},{"line_number":49,"context_line":"            \u0027updated_at\u0027: instance.get(\u0027updated_at\u0027),"},{"line_number":50,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":51,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":52,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":53,"context_line":"            \u0027progress\u0027: instance.get(\u0027progress\u0027),"},{"line_number":54,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"}],"source_content_type":"text/x-python","patch_set":51,"id":"1aa78d24_80e2bfff","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":71},"updated":"2016-07-09 16:06:40.000000000","message":"Ditto.","commit_id":"bf6309592ed500c49bd92ac8d9f66fce614bd32b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2a80bfc7269cf5046f2d48cf859f0b2b05cc5170","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        instances_dict \u003d {self._collection_name: instances_list}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if instances_links:"},{"line_number":69,"context_line":"            instances_dict[self._collection_name] \u003d instances_links"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return instances_dict"}],"source_content_type":"text/x-python","patch_set":56,"id":"dada55a8_e06136aa","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":48},"updated":"2016-07-22 15:31:41.000000000","message":"Here you will overwrite list data you write on line 66.\nUse some other key, for example \"share_snapshot_instances_links\". Also,it is not tested: http://logs.openstack.org/58/234658/56/check/manila-coverage-db/4e7e366/console.html.gz#_2016-07-11_13_17_57_214364","commit_id":"3d1b491ba0c15f0f89925920cce87e8e7b22654e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e3e0e7a277f63fe796182ba4a4176fdb48d3d1d0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        instances_dict \u003d {self._collection_name: instances_list}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if instances_links:"},{"line_number":69,"context_line":"            instances_dict[self._collection_name] \u003d instances_links"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        return instances_dict"}],"source_content_type":"text/x-python","patch_set":56,"id":"dada55a8_e229cc9c","line":69,"range":{"start_line":69,"start_character":27,"end_line":69,"end_character":48},"in_reply_to":"dada55a8_e06136aa","updated":"2016-07-26 03:53:16.000000000","message":"Done","commit_id":"3d1b491ba0c15f0f89925920cce87e8e7b22654e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def summary(self, request, instance):"},{"line_number":32,"context_line":"        \"\"\"Generic, non-detailed view of a share snapshot instance.\"\"\""},{"line_number":33,"context_line":"        instance_dict \u003d {"},{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_274fd893","line":36,"range":{"start_line":34,"start_character":12,"end_line":36,"end_character":45},"updated":"2016-07-28 03:43:02.000000000","message":"These three keys make sense in the summary.. the rest should be in detail; please..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def summary(self, request, instance):"},{"line_number":32,"context_line":"        \"\"\"Generic, non-detailed view of a share snapshot instance.\"\"\""},{"line_number":33,"context_line":"        instance_dict \u003d {"},{"line_number":34,"context_line":"            \u0027id\u0027: instance.get(\u0027id\u0027),"},{"line_number":35,"context_line":"            \u0027snapshot_id\u0027: instance.get(\u0027snapshot_id\u0027),"},{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_7eb035f5","line":36,"range":{"start_line":34,"start_character":12,"end_line":36,"end_character":45},"in_reply_to":"bacf61ea_274fd893","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"        return {\u0027snapshot_instance\u0027: instance_dict}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_c777dcd2","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":67},"updated":"2016-07-28 03:43:02.000000000","message":"Why is this key in the summary?","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \u0027status\u0027: instance.get(\u0027status\u0027),"},{"line_number":37,"context_line":"            \u0027share_id\u0027: instance.get(\u0027share_instance\u0027).get(\u0027share_id\u0027),"},{"line_number":38,"context_line":"            \u0027share_instance_id\u0027: instance.get(\u0027share_instance_id\u0027),"},{"line_number":39,"context_line":"            \u0027provider_location\u0027: instance.get(\u0027provider_location\u0027),"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"        return {\u0027snapshot_instance\u0027: instance_dict}"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_de95e140","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":67},"in_reply_to":"bacf61ea_c777dcd2","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"}],"manila/db/api.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1c5e072c1fdff4e6556f4071909fb694877238ba","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":307,"context_line":"    \"\"\"Returns all share instances.\"\"\""},{"line_number":308,"context_line":"    return IMPL.share_snapshot_instances_get_all(context)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_9655d3fa","line":307,"updated":"2015-11-12 18:40:21.000000000","message":"snapshot","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"292d63a89de8f8b4cf3f738a5d774a2ad016442d","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":307,"context_line":"    \"\"\"Returns all share instances.\"\"\""},{"line_number":308,"context_line":"    return IMPL.share_snapshot_instances_get_all(context)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_8bd465bd","line":307,"in_reply_to":"da85f559_9655d3fa","updated":"2015-11-16 07:26:43.000000000","message":"Done","commit_id":"96508c329a040d27b8ff14ac8bd089f0c516116a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":317,"context_line":"    \"\"\"Returns all share instances.\"\"\""},{"line_number":318,"context_line":"    return IMPL.share_snapshot_instances_get_all(context)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_7306b287","line":317,"updated":"2015-12-07 14:21:22.000000000","message":"snapshot instances?","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f1326cf8e4f15b893da7483a51850f4e25bb2377","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":317,"context_line":"    \"\"\"Returns all share instances.\"\"\""},{"line_number":318,"context_line":"    return IMPL.share_snapshot_instances_get_all(context)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_f3b65b89","line":317,"in_reply_to":"7a740942_7306b287","updated":"2016-01-13 09:56:04.000000000","message":"Done","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                                      with_share_data\u003dwith_share_data)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":318,"context_line":"    \"\"\"Returns all share snapshot instances.\"\"\""},{"line_number":319,"context_line":"    return IMPL.share_snapshot_instances_get_all(context)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def share_instances_get_all(context):"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_3eb7a8d9","line":319,"range":{"start_line":317,"start_character":1,"end_line":319,"end_character":57},"updated":"2016-03-27 01:42:44.000000000","message":"Not necessary..","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        context, instance_id, with_share_data\u003dwith_share_data)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"def share_snapshot_instance_get_all_with_filters(context, filters,"},{"line_number":506,"context_line":"                                                 with_share_data\u003dFalse):"},{"line_number":507,"context_line":"    \"\"\"Get all snapshot instances satisfying provided filters.\"\"\""},{"line_number":508,"context_line":"    return IMPL.share_snapshot_instance_get_all_with_filters("}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_7eb120e1","line":505,"updated":"2016-03-27 01:42:44.000000000","message":"You should re-use this one..","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"b698d8a81222f066760c0d6290695a5c6fe6e602","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    return instances"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"################"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"@require_admin_context"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_8eb793f4","line":1281,"updated":"2015-11-16 07:45:31.000000000","message":"This red line should be removed. just one under your code is enough.","commit_id":"2e6f1ea526a918db80663b0d0bcbc8aacda877d3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0069c90e8bb0686a43bf8b542ea97c52ab52a1c4","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"    return instances"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"################"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"@require_admin_context"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_0e45e3b1","line":1281,"in_reply_to":"da85f559_8eb793f4","updated":"2015-11-16 07:51:25.000000000","message":"Done","commit_id":"2e6f1ea526a918db80663b0d0bcbc8aacda877d3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"    session \u003d get_session()"},{"line_number":1284,"context_line":"    return ("},{"line_number":1285,"context_line":"        model_query(context, models.ShareSnapshotInstance, session\u003dsession,"},{"line_number":1286,"context_line":"                    read_deleted\u003d\"no\").all()"},{"line_number":1287,"context_line":"    )"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_1f8093be","line":1286,"updated":"2015-12-02 11:29:07.000000000","message":"You add only \"read\" method. Where are you going to get \"deleted\" ones?","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"709f7b897c652f2a1df3d45889dcb3fc989a8906","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"@require_admin_context"},{"line_number":1285,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":1286,"context_line":"    session \u003d get_session()"},{"line_number":1287,"context_line":"    return ("},{"line_number":1288,"context_line":"        model_query(context, models.ShareSnapshotInstance, session\u003dsession,"},{"line_number":1289,"context_line":"                    read_deleted\u003d\"no\").all()"},{"line_number":1290,"context_line":"    )"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":""},{"line_number":1293,"context_line":"################"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_25a3099f","line":1290,"range":{"start_line":1285,"start_character":0,"end_line":1290,"end_character":5},"updated":"2016-01-14 00:56:47.000000000","message":"This block requires a unit test in:\n\nmanila/tests/db/sqlalchemy/test_api.py","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":1451,"context_line":"################"},{"line_number":1452,"context_line":""},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"@require_admin_context"},{"line_number":1455,"context_line":"def share_snapshot_instances_get_all(context):"},{"line_number":1456,"context_line":"    session \u003d get_session()"},{"line_number":1457,"context_line":"    return ("},{"line_number":1458,"context_line":"        model_query(context, models.ShareSnapshotInstance, session\u003dsession,"},{"line_number":1459,"context_line":"                    read_deleted\u003d\"no\").all()"},{"line_number":1460,"context_line":"    )"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":""},{"line_number":1463,"context_line":"################"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_becbb852","line":1460,"range":{"start_line":1454,"start_character":0,"end_line":1460,"end_character":5},"updated":"2016-03-27 01:42:44.000000000","message":"Not necessary.. Reuse the existing method on line 1966 of this file","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"}],"manila/tests/api/v1/test_share_snapshot_instances.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class ShareSnapshotInstancesApiTest(test.TestCase):"},{"line_number":27,"context_line":"    \"\"\"Share snapshot Api Test.\"\"\""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(ShareSnapshotInstancesApiTest, self).setUp()"},{"line_number":30,"context_line":"        self.controller \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_9f7483fe","line":27,"updated":"2015-12-02 11:29:07.000000000","message":".. instance ..","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@ddt.ddt"},{"line_number":26,"context_line":"class ShareSnapshotInstancesApiTest(test.TestCase):"},{"line_number":27,"context_line":"    \"\"\"Share snapshot Api Test.\"\"\""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(ShareSnapshotInstancesApiTest, self).setUp()"},{"line_number":30,"context_line":"        self.controller \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_db9478e3","line":27,"in_reply_to":"9a8ffd7b_9f7483fe","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6ce81e040feb8d9bbe24ffda785cea3003f53b89","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _validate_ids_in_share_snapshot_instances_list(self, expected, actual):"},{"line_number":42,"context_line":"        self.assertEqual(len(expected), len(actual))"},{"line_number":43,"context_line":"        self.assertEqual([i[\u0027id\u0027] for i in expected],"},{"line_number":44,"context_line":"                         [i[\u0027id\u0027] for i in actual])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_index(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_3f5c777c","line":43,"updated":"2015-12-02 11:29:07.000000000","message":"It is common agreement in programming, that \"i\" and \"j\" are used for integers.","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c44c9941bb5c4b5b772034faa16065da6e864940","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _validate_ids_in_share_snapshot_instances_list(self, expected, actual):"},{"line_number":42,"context_line":"        self.assertEqual(len(expected), len(actual))"},{"line_number":43,"context_line":"        self.assertEqual([i[\u0027id\u0027] for i in expected],"},{"line_number":44,"context_line":"                         [i[\u0027id\u0027] for i in actual])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_index(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_963805a2","line":43,"in_reply_to":"9a8ffd7b_3f5c777c","updated":"2015-12-07 06:43:31.000000000","message":"Done","commit_id":"b38457c9dc1318378e46d24f9d8a004286485556"}],"manila/tests/api/v2/test_share_snapshot_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44c7cc9a3ece888d85a224aeae287689871001e0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _get_request(self, uri, context\u003dNone):"},{"line_number":37,"context_line":"        if context is None:"},{"line_number":38,"context_line":"            context \u003d self.context"},{"line_number":39,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/snapshots\u0027, version\u003d\"2.8\")"},{"line_number":40,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d context"},{"line_number":41,"context_line":"        return req"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_5338563d","line":39,"updated":"2015-12-07 14:21:22.000000000","message":"the URL mentioned in the router is different..","commit_id":"694fec5b275d6feccf74b8000adda2581cb8c3cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            share_snapshot_instances.ShareSnapshotInstancesController())"},{"line_number":34,"context_line":"        self.context \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _get_request(self, uri, context\u003dNone):"},{"line_number":37,"context_line":"        if context is None:"},{"line_number":38,"context_line":"            context \u003d self.context"},{"line_number":39,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/snapshots\u0027, version\u003d\"2.9\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_45b2bd07","line":36,"range":{"start_line":36,"start_character":27,"end_line":36,"end_character":30},"updated":"2016-01-14 00:55:33.000000000","message":"uri\u003d\u0027/share_snapshot_instances\u0027","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _get_request(self, uri, context\u003dNone):"},{"line_number":37,"context_line":"        if context is None:"},{"line_number":38,"context_line":"            context \u003d self.context"},{"line_number":39,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/snapshots\u0027, version\u003d\"2.9\")"},{"line_number":40,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d context"},{"line_number":41,"context_line":"        return req"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_2595493e","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":49},"updated":"2016-01-14 00:55:33.000000000","message":"uri","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c276b97e458738fdc7043837f478d36e4cd564ed","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self._validate_ids_in_share_snapshot_instances_list("},{"line_number":69,"context_line":"            [test_snapshot.instance],"},{"line_number":70,"context_line":"            actual_result[\u0027share_snapshot_instances\u0027]"},{"line_number":71,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_25f9c9c7","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":9},"updated":"2016-01-14 00:55:33.000000000","message":"please also test:\n\n - non-admin context\n - unsupported micro versions","commit_id":"182b4059866c788e871849bd039de5f9092ddea4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_9ec6b447","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2016-03-27 01:42:44.000000000","message":"2016","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _get_request(self, uri, context\u003dNone):"},{"line_number":37,"context_line":"        if context is None:"},{"line_number":38,"context_line":"            context \u003d self.context"},{"line_number":39,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/snapshots\u0027, version\u003d\"2.9\")"},{"line_number":40,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d context"},{"line_number":41,"context_line":"        return req"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_dec02c2d","line":39,"range":{"start_line":39,"start_character":61,"end_line":39,"end_character":65},"updated":"2016-03-27 01:42:44.000000000","message":"2.16","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a213d035c4ede4942f27b15b2948f0cd4a2a6ce","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_get_show(self):"},{"line_number":62,"context_line":"        test_snapshot \u003d db_utils.create_snapshot(with_share\u003dTrue, size\u003d1)"},{"line_number":63,"context_line":"        id \u003d test_snapshot[\u0027id\u0027]"},{"line_number":64,"context_line":"        req \u003d self._get_request(\u0027fake\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        actual_result \u003d self.controller.show(req, id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_3ede8811","line":63,"range":{"start_line":63,"start_character":13,"end_line":63,"end_character":32},"updated":"2016-03-27 01:42:44.000000000","message":"test_snapshot[\u0027instance\u0027][\u0027id\u0027]","commit_id":"542eb10f0026c811fdbd92de1e6b76589f211440"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.api_version \u003d \u00272.16\u0027"},{"line_number":44,"context_line":"        self.snapshot_instances_req \u003d fakes.HTTPRequest.blank("},{"line_number":45,"context_line":"            \u0027/share-snapshot-instances\u0027, version\u003dself.api_version)"},{"line_number":46,"context_line":"        self.context \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":47,"context_line":"        self.admin_context \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":48,"context_line":"        self.member_context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":49,"context_line":"        self.snapshot_instances_req.environ[\u0027manila.context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_d0da1217","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":68},"updated":"2016-04-02 15:00:09.000000000","message":"This is the same as self.admin_context, so can be removed.","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.api_version \u003d \u00272.16\u0027"},{"line_number":44,"context_line":"        self.snapshot_instances_req \u003d fakes.HTTPRequest.blank("},{"line_number":45,"context_line":"            \u0027/share-snapshot-instances\u0027, version\u003dself.api_version)"},{"line_number":46,"context_line":"        self.context \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":47,"context_line":"        self.admin_context \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":48,"context_line":"        self.member_context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":49,"context_line":"        self.snapshot_instances_req.environ[\u0027manila.context\u0027] \u003d self.context"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_61067ccf","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":68},"in_reply_to":"ba0121b8_d0da1217","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_request(self, uri, context\u003dNone):"},{"line_number":56,"context_line":"        if context is None:"},{"line_number":57,"context_line":"            context \u003d self.context"},{"line_number":58,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/share_snapshot_instances\u0027,"},{"line_number":59,"context_line":"                                      version\u003d\"2.16\")"},{"line_number":60,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d context"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_b0d79eec","line":57,"range":{"start_line":57,"start_character":27,"end_line":57,"end_character":34},"updated":"2016-04-02 15:00:09.000000000","message":"admin_context","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_request(self, uri, context\u003dNone):"},{"line_number":56,"context_line":"        if context is None:"},{"line_number":57,"context_line":"            context \u003d self.context"},{"line_number":58,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/share_snapshot_instances\u0027,"},{"line_number":59,"context_line":"                                      version\u003d\"2.16\")"},{"line_number":60,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d context"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_4109b8dc","line":57,"range":{"start_line":57,"start_character":27,"end_line":57,"end_character":34},"in_reply_to":"ba0121b8_b0d79eec","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return req"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_fake_snapshot_instance(self, summary\u003dFalse, **values):"},{"line_number":64,"context_line":"        snaphot_instance \u003d fake_share.fake_snapshot_instance(as_primitive\u003dTrue)"},{"line_number":65,"context_line":"        expected_keys \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027,"},{"line_number":67,"context_line":"            \u0027snapshot_id\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_90253a0c","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":25},"updated":"2016-04-02 15:00:09.000000000","message":"snapshot_instance","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return req"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_fake_snapshot_instance(self, summary\u003dFalse, **values):"},{"line_number":64,"context_line":"        snaphot_instance \u003d fake_share.fake_snapshot_instance(as_primitive\u003dTrue)"},{"line_number":65,"context_line":"        expected_keys \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027,"},{"line_number":67,"context_line":"            \u0027snapshot_id\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_e121ec4e","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":25},"in_reply_to":"ba0121b8_90253a0c","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            expected_snapshot_instance.update({"},{"line_number":78,"context_line":"                \u0027created_at\u0027: snaphot_instance.get(\u0027created_at\u0027),"},{"line_number":79,"context_line":"                \u0027updated_at\u0027: snaphot_instance.get(\u0027updated_at\u0027),"},{"line_number":80,"context_line":"                \u0027deleted_at\u0027: snaphot_instance.get(\u0027deleted_at\u0027),"},{"line_number":81,"context_line":"                \u0027deleted\u0027: snaphot_instance.get(\u0027deleted\u0027),"},{"line_number":82,"context_line":"                \u0027progress\u0027: snaphot_instance.get(\u0027progress\u0027),"},{"line_number":83,"context_line":"                \u0027provider_location\u0027: snaphot_instance.get(\u0027provider_location\u0027),"},{"line_number":84,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_1003ea77","line":81,"range":{"start_line":80,"start_character":17,"end_line":81,"end_character":59},"updated":"2016-04-02 15:00:09.000000000","message":"not necessary..","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            expected_snapshot_instance.update({"},{"line_number":78,"context_line":"                \u0027created_at\u0027: snaphot_instance.get(\u0027created_at\u0027),"},{"line_number":79,"context_line":"                \u0027updated_at\u0027: snaphot_instance.get(\u0027updated_at\u0027),"},{"line_number":80,"context_line":"                \u0027deleted_at\u0027: snaphot_instance.get(\u0027deleted_at\u0027),"},{"line_number":81,"context_line":"                \u0027deleted\u0027: snaphot_instance.get(\u0027deleted\u0027),"},{"line_number":82,"context_line":"                \u0027progress\u0027: snaphot_instance.get(\u0027progress\u0027),"},{"line_number":83,"context_line":"                \u0027provider_location\u0027: snaphot_instance.get(\u0027provider_location\u0027),"},{"line_number":84,"context_line":"            })"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_c11ca815","line":81,"range":{"start_line":80,"start_character":17,"end_line":81,"end_character":59},"in_reply_to":"ba0121b8_1003ea77","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                \u0027provider_location\u0027: snaphot_instance.get(\u0027provider_location\u0027),"},{"line_number":84,"context_line":"            })"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        return snaphot_instance, expected_snapshot_instance"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _setup_snapshot_instance_data(self, instance\u003dNone, version\u003d\u00272.16\u0027):"},{"line_number":89,"context_line":"        if instance is None:"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_d01fb2b5","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":31},"updated":"2016-04-02 15:00:09.000000000","message":"snapshot_instance","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                \u0027provider_location\u0027: snaphot_instance.get(\u0027provider_location\u0027),"},{"line_number":84,"context_line":"            })"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        return snaphot_instance, expected_snapshot_instance"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _setup_snapshot_instance_data(self, instance\u003dNone, version\u003d\u00272.16\u0027):"},{"line_number":89,"context_line":"        if instance is None:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_211c8411","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":31},"in_reply_to":"ba0121b8_d01fb2b5","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _get_context(self, role):"},{"line_number":108,"context_line":"        return getattr(self, \u0027%s_context\u0027 % role)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_snapshot_summary(self):"},{"line_number":111,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":112,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":113,"context_line":"        self.mock_object(share_snapshot_instances.db,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_102acae7","line":110,"range":{"start_line":110,"start_character":18,"end_line":110,"end_character":26},"updated":"2016-04-02 15:00:09.000000000","message":"snapshot_instances","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _get_context(self, role):"},{"line_number":108,"context_line":"        return getattr(self, \u0027%s_context\u0027 % role)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_snapshot_summary(self):"},{"line_number":111,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":112,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":113,"context_line":"        self.mock_object(share_snapshot_instances.db,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_c2c66648","line":110,"range":{"start_line":110,"start_character":18,"end_line":110,"end_character":26},"in_reply_to":"ba0121b8_102acae7","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return getattr(self, \u0027%s_context\u0027 % role)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_snapshot_summary(self):"},{"line_number":111,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":112,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":113,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":114,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_10780af8","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":24},"updated":"2016-04-02 15:00:09.000000000","message":"snapshot_instance","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        return getattr(self, \u0027%s_context\u0027 % role)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_snapshot_summary(self):"},{"line_number":111,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":112,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":113,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":114,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_82ebceaf","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":24},"in_reply_to":"ba0121b8_10780af8","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual([expected_snapshot_instance],"},{"line_number":120,"context_line":"                         res_dict[\u0027share_snapshot_instances\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_list_snapshot_instances_summary(self):"},{"line_number":123,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":124,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":125,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":126,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":127,"context_line":"                         mock.Mock(return_value\u003d[snaphot_instance]))"},{"line_number":128,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":129,"context_line":"            \u0027/share-snapshot-instances?snapshot_id\u003dFAKE_SHARE_ID\u0027,"},{"line_number":130,"context_line":"            version\u003dself.api_version)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        self.assertEqual([expected_snapshot_instance],"},{"line_number":135,"context_line":"                         res_dict[\u0027share_snapshot_instances\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_list_snapshot_instances_detail(self):"},{"line_number":138,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_50344249","line":135,"range":{"start_line":122,"start_character":0,"end_line":135,"end_character":62},"updated":"2016-04-02 15:00:09.000000000","message":"duplicate of above?","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual([expected_snapshot_instance],"},{"line_number":120,"context_line":"                         res_dict[\u0027share_snapshot_instances\u0027])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_list_snapshot_instances_summary(self):"},{"line_number":123,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":124,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":125,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":126,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":127,"context_line":"                         mock.Mock(return_value\u003d[snaphot_instance]))"},{"line_number":128,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":129,"context_line":"            \u0027/share-snapshot-instances?snapshot_id\u003dFAKE_SHARE_ID\u0027,"},{"line_number":130,"context_line":"            version\u003dself.api_version)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        self.assertEqual([expected_snapshot_instance],"},{"line_number":135,"context_line":"                         res_dict[\u0027share_snapshot_instances\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_list_snapshot_instances_detail(self):"},{"line_number":138,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_a1ded43c","line":135,"range":{"start_line":122,"start_character":0,"end_line":135,"end_character":62},"in_reply_to":"ba0121b8_50344249","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                         res_dict[\u0027share_snapshot_instances\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_list_snapshot_instances_detail(self):"},{"line_number":138,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":139,"context_line":"            self._get_fake_snapshot_instance())"},{"line_number":140,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":141,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_f07c76ed","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":24},"updated":"2016-04-02 15:00:09.000000000","message":"snapshot_instance","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                         res_dict[\u0027share_snapshot_instances\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_list_snapshot_instances_detail(self):"},{"line_number":138,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":139,"context_line":"            self._get_fake_snapshot_instance())"},{"line_number":140,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":141,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_81e11001","line":138,"range":{"start_line":138,"start_character":8,"end_line":138,"end_character":24},"in_reply_to":"ba0121b8_f07c76ed","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def test_list_snapshot_instances_detail_invalid_snapshot(self):"},{"line_number":150,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":151,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":152,"context_line":"                         mock.Mock(side_effect\u003dexception.NotFound))"},{"line_number":153,"context_line":"        mock__view_builder_call \u003d self.mock_object("},{"line_number":154,"context_line":"            share_snapshot_instances.instance_view.ViewBuilder,"},{"line_number":155,"context_line":"            \u0027detail_list\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_10112ab0","line":152,"range":{"start_line":152,"start_character":35,"end_line":152,"end_character":65},"updated":"2016-04-02 15:00:09.000000000","message":"return_value\u003d[] would be the actual result..","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def test_list_snapshot_instances_detail_invalid_snapshot(self):"},{"line_number":150,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":151,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":152,"context_line":"                         mock.Mock(side_effect\u003dexception.NotFound))"},{"line_number":153,"context_line":"        mock__view_builder_call \u003d self.mock_object("},{"line_number":154,"context_line":"            share_snapshot_instances.instance_view.ViewBuilder,"},{"line_number":155,"context_line":"            \u0027detail_list\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_e17d6c1d","line":152,"range":{"start_line":152,"start_character":35,"end_line":152,"end_character":65},"in_reply_to":"ba0121b8_10112ab0","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8493b116177fb32ba4a3653dcca82c08b30264d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertFalse(mock__view_builder_call.called)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_show(self):"},{"line_number":164,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":165,"context_line":"            self._get_fake_snapshot_instance())"},{"line_number":166,"context_line":"        self.mock_object("},{"line_number":167,"context_line":"            share_snapshot_instances.db, \u0027share_snapshot_instance_get\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_30870ed9","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":24},"updated":"2016-04-02 15:00:09.000000000","message":"snapshot_instance","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c24ce8b3fc35a93679925bed8734ca33e232602","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.assertFalse(mock__view_builder_call.called)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_show(self):"},{"line_number":164,"context_line":"        snaphot_instance, expected_snapshot_instance \u003d ("},{"line_number":165,"context_line":"            self._get_fake_snapshot_instance())"},{"line_number":166,"context_line":"        self.mock_object("},{"line_number":167,"context_line":"            share_snapshot_instances.db, \u0027share_snapshot_instance_get\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a061dce_c1e30804","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":24},"in_reply_to":"ba0121b8_30870ed9","updated":"2016-04-06 06:19:40.000000000","message":"Done","commit_id":"4fd1c097c2c88f660a4306ac4885d4a0cf09ff3a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \u0027created_at\u0027: snapshot_instance.get(\u0027created_at\u0027),"},{"line_number":81,"context_line":"                \u0027updated_at\u0027: snapshot_instance.get(\u0027updated_at\u0027),"},{"line_number":82,"context_line":"                \u0027progress\u0027: snapshot_instance.get(\u0027progress\u0027),"},{"line_number":83,"context_line":"                \u0027provider_location\u0027:"},{"line_number":84,"context_line":"                    snapshot_instance.get(\u0027provider_location\u0027),"},{"line_number":85,"context_line":"            })"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return snapshot_instance, expected_snapshot_instance"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_65ba5bc2","line":84,"range":{"start_line":83,"start_character":16,"end_line":84,"end_character":63},"updated":"2016-05-24 16:55:06.000000000","message":"It is already added above.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                \u0027created_at\u0027: snapshot_instance.get(\u0027created_at\u0027),"},{"line_number":81,"context_line":"                \u0027updated_at\u0027: snapshot_instance.get(\u0027updated_at\u0027),"},{"line_number":82,"context_line":"                \u0027progress\u0027: snapshot_instance.get(\u0027progress\u0027),"},{"line_number":83,"context_line":"                \u0027provider_location\u0027:"},{"line_number":84,"context_line":"                    snapshot_instance.get(\u0027provider_location\u0027),"},{"line_number":85,"context_line":"            })"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return snapshot_instance, expected_snapshot_instance"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_41c9eb78","line":84,"range":{"start_line":83,"start_character":16,"end_line":84,"end_character":63},"in_reply_to":"bab6814e_65ba5bc2","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return snapshot_instance, expected_snapshot_instance"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _setup_snapshot_instance_data(self, instance\u003dNone, version\u003d\u00272.17\u0027):"},{"line_number":90,"context_line":"        if instance is None:"},{"line_number":91,"context_line":"            share_instance \u003d db_utils.create_share_instance("},{"line_number":92,"context_line":"                status\u003dconstants.STATUS_AVAILABLE,"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_05d1cffb","line":89,"range":{"start_line":89,"start_character":59,"end_line":89,"end_character":73},"updated":"2016-05-24 16:55:06.000000000","message":"It is not used in this method.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return snapshot_instance, expected_snapshot_instance"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _setup_snapshot_instance_data(self, instance\u003dNone, version\u003d\u00272.17\u0027):"},{"line_number":90,"context_line":"        if instance is None:"},{"line_number":91,"context_line":"            share_instance \u003d db_utils.create_share_instance("},{"line_number":92,"context_line":"                status\u003dconstants.STATUS_AVAILABLE,"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_01b7e3f5","line":89,"range":{"start_line":89,"start_character":59,"end_line":89,"end_character":73},"in_reply_to":"bab6814e_05d1cffb","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        snapshot_instance, expected_snapshot_instance \u003d ("},{"line_number":125,"context_line":"            self._get_fake_snapshot_instance())"},{"line_number":126,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":127,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":128,"context_line":"                         mock.Mock(return_value\u003d[snapshot_instance]))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        res_dict \u003d self.controller.detail(self.snapshot_instances_req)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_85949fe8","line":127,"range":{"start_line":127,"start_character":26,"end_line":127,"end_character":70},"updated":"2016-05-24 16:55:06.000000000","message":"It can be very useful to make call assertions on mocked stuff.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        snapshot_instance, expected_snapshot_instance \u003d ("},{"line_number":125,"context_line":"            self._get_fake_snapshot_instance())"},{"line_number":126,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":127,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":128,"context_line":"                         mock.Mock(return_value\u003d[snapshot_instance]))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        res_dict \u003d self.controller.detail(self.snapshot_instances_req)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_b5760da1","line":127,"range":{"start_line":127,"start_character":26,"end_line":127,"end_character":70},"in_reply_to":"bab6814e_85949fe8","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def test_policy_not_authorized(self, method_name):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        method \u003d getattr(self.controller, method_name)"},{"line_number":181,"context_line":"        arguments \u003d {"},{"line_number":182,"context_line":"            \u0027id\u0027: \u0027FAKE_SNAPSHOT_ID\u0027,"},{"line_number":183,"context_line":"            \u0027body\u0027: {\u0027FAKE_KEY\u0027: \u0027FAKE_VAL\u0027},"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":"        if method_name in (\u0027index\u0027, \u0027detail\u0027):"},{"line_number":186,"context_line":"            arguments.clear()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        noauthexc \u003d exception.PolicyNotAuthorized(action\u003dsix.text_type(method))"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_0526ef15","line":186,"range":{"start_line":181,"start_character":8,"end_line":186,"end_character":29},"updated":"2016-05-24 16:55:06.000000000","message":"\"\"\"\nIf method_name in (\u0027index\u0027, \u0027detail\u0027):\n    arguments \u003d {}\nelse:\n    arguments \u003d {\n        \u0027id\u0027: \u0027FAKE_SNAPSHOT_ID\u0027,\n        \u0027body\u0027: {\u0027FAKE_KEY\u0027: \u0027FAKE_VAL\u0027},\n    }\n\"\"\"\n^ Does not do redundant actions if condition is true.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def test_policy_not_authorized(self, method_name):"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        method \u003d getattr(self.controller, method_name)"},{"line_number":181,"context_line":"        arguments \u003d {"},{"line_number":182,"context_line":"            \u0027id\u0027: \u0027FAKE_SNAPSHOT_ID\u0027,"},{"line_number":183,"context_line":"            \u0027body\u0027: {\u0027FAKE_KEY\u0027: \u0027FAKE_VAL\u0027},"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":"        if method_name in (\u0027index\u0027, \u0027detail\u0027):"},{"line_number":186,"context_line":"            arguments.clear()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        noauthexc \u003d exception.PolicyNotAuthorized(action\u003dsix.text_type(method))"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_954b0959","line":186,"range":{"start_line":181,"start_character":8,"end_line":186,"end_character":29},"in_reply_to":"bab6814e_0526ef15","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _get_context(self, role):"},{"line_number":108,"context_line":"        return getattr(self, \u0027%s_context\u0027 % role)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_snapshot_instances_summary(self):"},{"line_number":111,"context_line":"        snapshot_instance, expected_snapshot_instance \u003d ("},{"line_number":112,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":113,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":114,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":115,"context_line":"                         mock.Mock(return_value\u003d[snapshot_instance]))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        res_dict \u003d self.controller.index(self.snapshot_instances_req)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertEqual([expected_snapshot_instance],"},{"line_number":120,"context_line":"                         res_dict[\u0027snapshot_instances\u0027])"},{"line_number":121,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":122,"context_line":"            self.admin_context, self.resource_name, \u0027index\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_list_snapshot_instances_detail(self):"},{"line_number":125,"context_line":"        snapshot_instance, expected_snapshot_instance \u003d ("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_ca41a33b","line":122,"range":{"start_line":110,"start_character":0,"end_line":122,"end_character":60},"updated":"2016-07-28 03:43:02.000000000","message":"Please use ddt and test this with providing the snapshot_id as well..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"07a462eb90a3c916c5aea62d551d582c978251ef","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _get_context(self, role):"},{"line_number":108,"context_line":"        return getattr(self, \u0027%s_context\u0027 % role)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_snapshot_instances_summary(self):"},{"line_number":111,"context_line":"        snapshot_instance, expected_snapshot_instance \u003d ("},{"line_number":112,"context_line":"            self._get_fake_snapshot_instance(summary\u003dTrue))"},{"line_number":113,"context_line":"        self.mock_object(share_snapshot_instances.db,"},{"line_number":114,"context_line":"                         \u0027share_snapshot_instance_get_all_with_filters\u0027,"},{"line_number":115,"context_line":"                         mock.Mock(return_value\u003d[snapshot_instance]))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        res_dict \u003d self.controller.index(self.snapshot_instances_req)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.assertEqual([expected_snapshot_instance],"},{"line_number":120,"context_line":"                         res_dict[\u0027snapshot_instances\u0027])"},{"line_number":121,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":122,"context_line":"            self.admin_context, self.resource_name, \u0027index\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_list_snapshot_instances_detail(self):"},{"line_number":125,"context_line":"        snapshot_instance, expected_snapshot_instance \u003d ("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_04cc4734","line":122,"range":{"start_line":110,"start_character":0,"end_line":122,"end_character":60},"in_reply_to":"bacf61ea_ca41a33b","updated":"2016-07-28 08:44:39.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        req \u003d self.snapshot_instances_req"},{"line_number":144,"context_line":"        req.GET[\u0027snapshot_id\u0027] \u003d \u0027FAKE_SNAPSHOT_ID\u0027"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        res_dict \u003d self.controller.detail(req)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.assertEqual([], res_dict[\u0027snapshot_instances\u0027])"},{"line_number":149,"context_line":"        self.mock_policy_check.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_6a0eb735","line":146,"range":{"start_line":146,"start_character":7,"end_line":146,"end_character":46},"updated":"2016-07-28 03:43:02.000000000","message":"This API should return HTTPBadRequest if the snapshot ID provided does not resolve to a valid snapshot in manila","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        req \u003d self.snapshot_instances_req"},{"line_number":144,"context_line":"        req.GET[\u0027snapshot_id\u0027] \u003d \u0027FAKE_SNAPSHOT_ID\u0027"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        res_dict \u003d self.controller.detail(req)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        self.assertEqual([], res_dict[\u0027snapshot_instances\u0027])"},{"line_number":149,"context_line":"        self.mock_policy_check.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_81c14983","line":146,"range":{"start_line":146,"start_character":7,"end_line":146,"end_character":46},"in_reply_to":"bacf61ea_6a0eb735","updated":"2016-07-28 08:43:59.000000000","message":"please see comment in \nhttps://review.openstack.org/#/c/234658/60/manila/api/v2/share_snapshot_instances.py","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":165,"context_line":"            self.admin_context, self.resource_name, \u0027show\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_show_no_snapshot_instance(self):"},{"line_number":168,"context_line":"        mock__view_builder_call \u003d self.mock_object("},{"line_number":169,"context_line":"            share_snapshot_instances.instance_view.ViewBuilder, \u0027detail\u0027)"},{"line_number":170,"context_line":"        fake_exception \u003d exception.ShareSnapshotInstanceNotFound("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_ea1aa76d","line":167,"range":{"start_line":167,"start_character":18,"end_line":167,"end_character":38},"updated":"2016-07-28 03:43:02.000000000","message":"nit: test_show_snapshot_instance_not_found","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":165,"context_line":"            self.admin_context, self.resource_name, \u0027show\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_show_no_snapshot_instance(self):"},{"line_number":168,"context_line":"        mock__view_builder_call \u003d self.mock_object("},{"line_number":169,"context_line":"            share_snapshot_instances.instance_view.ViewBuilder, \u0027detail\u0027)"},{"line_number":170,"context_line":"        fake_exception \u003d exception.ShareSnapshotInstanceNotFound("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_3ee23dd6","line":167,"range":{"start_line":167,"start_character":18,"end_line":167,"end_character":38},"in_reply_to":"bacf61ea_ea1aa76d","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @ddt.data(\u0027index\u0027, \u0027show\u0027, \u0027detail\u0027, \u0027reset_status\u0027)"},{"line_number":204,"context_line":"    def test_upsupported_microversion(self, method_name):"},{"line_number":205,"context_line":"        unsupported_microversions \u003d (\u00271.0\u0027, \u00272.2\u0027, \u00272.7\u0027, \u00272.17\u0027)"},{"line_number":206,"context_line":"        method \u003d getattr(self.controller, method_name)"},{"line_number":207,"context_line":"        arguments \u003d {"},{"line_number":208,"context_line":"            \u0027id\u0027: \u0027FAKE_SNAPSHOT_ID\u0027,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_0a357bd9","line":205,"range":{"start_line":205,"start_character":44,"end_line":205,"end_character":64},"updated":"2016-07-28 03:43:02.000000000","message":"can be replaced with \u00272.18\u0027","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @ddt.data(\u0027index\u0027, \u0027show\u0027, \u0027detail\u0027, \u0027reset_status\u0027)"},{"line_number":204,"context_line":"    def test_upsupported_microversion(self, method_name):"},{"line_number":205,"context_line":"        unsupported_microversions \u003d (\u00271.0\u0027, \u00272.2\u0027, \u00272.7\u0027, \u00272.17\u0027)"},{"line_number":206,"context_line":"        method \u003d getattr(self.controller, method_name)"},{"line_number":207,"context_line":"        arguments \u003d {"},{"line_number":208,"context_line":"            \u0027id\u0027: \u0027FAKE_SNAPSHOT_ID\u0027,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_7eecb5c7","line":205,"range":{"start_line":205,"start_character":44,"end_line":205,"end_character":64},"in_reply_to":"bacf61ea_0a357bd9","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"}],"manila/tests/fake_share.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ad798dce826f27e22cf65363a1604a5ba8dd64f7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027provider_location\u0027: \u0027i_live_here_actually\u0027,"},{"line_number":152,"context_line":"        \u0027share_name\u0027: \u0027fakename\u0027,"},{"line_number":153,"context_line":"        \u0027share_id\u0027: \u0027fakeshareinstanceid\u0027,"},{"line_number":154,"context_line":"        \u0027share_instance\u0027: {\u0027share_id\u0027: \u0027fakeshareid\u0027,}"},{"line_number":155,"context_line":"        \u0027share_instance_id\u0027: \u0027fakeshareinstanceid\u0027,"},{"line_number":156,"context_line":"        \u0027deleted\u0027: False,"},{"line_number":157,"context_line":"        \u0027updated_at\u0027: datetime.datetime(2016, 3, 21, 0, 5, 58),"}],"source_content_type":"text/x-python","patch_set":54,"id":"1aa78d24_06eecbb3","line":154,"updated":"2016-07-11 11:02:31.000000000","message":"need comma at the end","commit_id":"6465aea38d0d7eccc420d47a040df0c7edb8ba4a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b26f9eefbec07359705d2712682481dc4d2ad8a7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027provider_location\u0027: \u0027i_live_here_actually\u0027,"},{"line_number":152,"context_line":"        \u0027share_name\u0027: \u0027fakename\u0027,"},{"line_number":153,"context_line":"        \u0027share_id\u0027: \u0027fakeshareinstanceid\u0027,"},{"line_number":154,"context_line":"        \u0027share_instance\u0027: {\u0027share_id\u0027: \u0027fakeshareid\u0027,},"},{"line_number":155,"context_line":"        \u0027share_instance_id\u0027: \u0027fakeshareinstanceid\u0027,"},{"line_number":156,"context_line":"        \u0027deleted\u0027: False,"},{"line_number":157,"context_line":"        \u0027updated_at\u0027: datetime.datetime(2016, 3, 21, 0, 5, 58),"}],"source_content_type":"text/x-python","patch_set":55,"id":"1aa78d24_f53a3fcc","line":154,"range":{"start_line":154,"start_character":52,"end_line":154,"end_character":54},"updated":"2016-07-11 12:27:02.000000000","message":"Sorry, I should have noticed, but you also need a space between the comma and the brace.","commit_id":"0de200a7f90e3f5dee1cda93172e4c71d6780e58"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40695195f502eaf4f45764e3bf86ab7d5939cf82","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        \u0027provider_location\u0027: \u0027i_live_here_actually\u0027,"},{"line_number":152,"context_line":"        \u0027share_name\u0027: \u0027fakename\u0027,"},{"line_number":153,"context_line":"        \u0027share_id\u0027: \u0027fakeshareinstanceid\u0027,"},{"line_number":154,"context_line":"        \u0027share_instance\u0027: {\u0027share_id\u0027: \u0027fakeshareid\u0027,},"},{"line_number":155,"context_line":"        \u0027share_instance_id\u0027: \u0027fakeshareinstanceid\u0027,"},{"line_number":156,"context_line":"        \u0027deleted\u0027: False,"},{"line_number":157,"context_line":"        \u0027updated_at\u0027: datetime.datetime(2016, 3, 21, 0, 5, 58),"}],"source_content_type":"text/x-python","patch_set":55,"id":"1aa78d24_d9265d15","line":154,"range":{"start_line":154,"start_character":52,"end_line":154,"end_character":54},"in_reply_to":"1aa78d24_f53a3fcc","updated":"2016-07-11 12:58:30.000000000","message":"Nice catch, Thanks for your review, Tom.","commit_id":"0de200a7f90e3f5dee1cda93172e4c71d6780e58"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":559,"context_line":"    def list_snapshot_instances(self, detail\u003dFalse, snapshot_id\u003dNone,"},{"line_number":560,"context_line":"                                version\u003dLATEST_MICROVERSION):"},{"line_number":561,"context_line":"        \"\"\"Get list of share snapshot instances.\"\"\""},{"line_number":562,"context_line":"        uri \u003d (\u0027share-snapshot-instances/detail\u0027 if detail"},{"line_number":563,"context_line":"               else \u0027share-snapshot-instances\u0027)"},{"line_number":564,"context_line":"        uri +\u003d ((\u0027?snapshot_id\u003d%s\u0027 % snapshot_id) if snapshot_id"},{"line_number":565,"context_line":"                is not None else \u0027\u0027)"},{"line_number":566,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":567,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":568,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_b234c9fb","line":565,"range":{"start_line":562,"start_character":8,"end_line":565,"end_character":36},"updated":"2016-04-21 14:53:43.000000000","message":"no gain using such structure.\nBetter for reading common way:\n\n\"\"\"\nuri \u003d \"share-snapshot-instances%s\" % (\u0027/detail\u0027 if details else \u0027\u0027)\nif snapshot_id is not None:\n    uri +\u003d \u0027?snapshot_id\u003d%s\u0027 % snapshot_id\n\"\"\"","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":559,"context_line":"    def list_snapshot_instances(self, detail\u003dFalse, snapshot_id\u003dNone,"},{"line_number":560,"context_line":"                                version\u003dLATEST_MICROVERSION):"},{"line_number":561,"context_line":"        \"\"\"Get list of share snapshot instances.\"\"\""},{"line_number":562,"context_line":"        uri \u003d (\u0027share-snapshot-instances/detail\u0027 if detail"},{"line_number":563,"context_line":"               else \u0027share-snapshot-instances\u0027)"},{"line_number":564,"context_line":"        uri +\u003d ((\u0027?snapshot_id\u003d%s\u0027 % snapshot_id) if snapshot_id"},{"line_number":565,"context_line":"                is not None else \u0027\u0027)"},{"line_number":566,"context_line":"        resp, body \u003d self.get(uri, version\u003dversion)"},{"line_number":567,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":568,"context_line":"        return self._parse_resp(body)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_76f937c8","line":565,"range":{"start_line":562,"start_character":8,"end_line":565,"end_character":36},"in_reply_to":"1a122d0e_b234c9fb","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2a80bfc7269cf5046f2d48cf859f0b2b05cc5170","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            if instance_status \u003d\u003d expected_status:"},{"line_number":597,"context_line":"                return"},{"line_number":598,"context_line":"            if (\u0027error\u0027 in instance_status"},{"line_number":599,"context_line":"                    and expected_status !\u003d constants.STATUS_ERROR):"},{"line_number":600,"context_line":"                raise share_exceptions.SnapshotInstanceBuildErrorException("},{"line_number":601,"context_line":"                    id\u003dinstance_id)"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"dada55a8_99943045","line":599,"range":{"start_line":599,"start_character":20,"end_line":599,"end_character":65},"updated":"2016-07-22 15:31:41.000000000","message":"We already checked that current status is not expected and if it has \"error\" word in status then we raise exception. It means that second part of condition is redundant.","commit_id":"3d1b491ba0c15f0f89925920cce87e8e7b22654e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e3e0e7a277f63fe796182ba4a4176fdb48d3d1d0","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            if instance_status \u003d\u003d expected_status:"},{"line_number":597,"context_line":"                return"},{"line_number":598,"context_line":"            if (\u0027error\u0027 in instance_status"},{"line_number":599,"context_line":"                    and expected_status !\u003d constants.STATUS_ERROR):"},{"line_number":600,"context_line":"                raise share_exceptions.SnapshotInstanceBuildErrorException("},{"line_number":601,"context_line":"                    id\u003dinstance_id)"},{"line_number":602,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"dada55a8_3feadf0f","line":599,"range":{"start_line":599,"start_character":20,"end_line":599,"end_character":65},"in_reply_to":"dada55a8_99943045","updated":"2016-07-26 03:53:16.000000000","message":"Done","commit_id":"3d1b491ba0c15f0f89925920cce87e8e7b22654e"}],"manila_tempest_tests/share_exceptions.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e2f3b2448d7060041a9c81ca12d0bf029d7b286","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class SnapshotInstanceBuildErrorException(exceptions.TempestException):"},{"line_number":41,"context_line":"    message \u003d \"Snapshot instance %(id)s failed to build and is in ERROR status\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class CGSnapshotBuildErrorException(exceptions.TempestException):"}],"source_content_type":"text/x-python","patch_set":58,"id":"dada55a8_83336461","line":41,"range":{"start_line":41,"start_character":77,"end_line":41,"end_character":79},"updated":"2016-07-27 12:24:45.000000000","message":"period","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5cd4d793eb481883020569c53dc89399c4f18a92","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class SnapshotInstanceBuildErrorException(exceptions.TempestException):"},{"line_number":41,"context_line":"    message \u003d \"Snapshot instance %(id)s failed to build and is in ERROR status\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class CGSnapshotBuildErrorException(exceptions.TempestException):"}],"source_content_type":"text/x-python","patch_set":58,"id":"bacf61ea_4b7c9c72","line":41,"range":{"start_line":41,"start_character":77,"end_line":41,"end_character":79},"in_reply_to":"dada55a8_83336461","updated":"2016-07-28 01:05:21.000000000","message":"Done","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"}],"manila_tempest_tests/tests/api/admin/admin.rar":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe1d67d46b0f5d228c5502f40f07449ff1fcc931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"bacf61ea_d02e54f9","updated":"2016-07-28 14:26:09.000000000","message":"ouch","commit_id":"d4807c797af90a1b588e289f780455388c946e07"}],"manila_tempest_tests/tests/api/admin/test_share_snapshot_instances.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Zhongjun"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_d54b2f5e","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":25},"updated":"2016-04-21 14:53:43.000000000","message":"This single commits introduces two different copyrights. Is it intended?","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Zhongjun"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_f6dc271a","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":25},"in_reply_to":"1a122d0e_d54b2f5e","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":41,"context_line":"                         \u0027Too many snapshot instances found; expected 1, \u0027"},{"line_number":42,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":45,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_f5710baa","line":42,"range":{"start_line":41,"start_character":26,"end_line":42,"end_character":34},"updated":"2016-04-21 14:53:43.000000000","message":"There also can be 0. It is \"too few\" ))","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":41,"context_line":"                         \u0027Too many snapshot instances found; expected 1, \u0027"},{"line_number":42,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":45,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_96bfb3a9","line":42,"range":{"start_line":41,"start_character":26,"end_line":42,"end_character":34},"in_reply_to":"1a122d0e_f5710baa","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def test_get_snapshot_instance_v2_16(self):"},{"line_number":64,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":65,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":66,"context_line":"        instances_detail \u003d self.shares_v2_client.get_snapshot_instance("},{"line_number":67,"context_line":"            instance_id\u003dinstances[0][\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        expected_keys \u003d ["}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_f5f62bf8","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":17},"updated":"2016-04-21 14:53:43.000000000","message":"Why plural? You get single entity here.","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def test_get_snapshot_instance_v2_16(self):"},{"line_number":64,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":65,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":66,"context_line":"        instances_detail \u003d self.shares_v2_client.get_snapshot_instance("},{"line_number":67,"context_line":"            instance_id\u003dinstances[0][\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        expected_keys \u003d ["}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_b6762f3c","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":17},"in_reply_to":"1a122d0e_f5f62bf8","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        instances_detail \u003d self.shares_v2_client.get_snapshot_instance("},{"line_number":67,"context_line":"            instance_id\u003dinstances[0][\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        expected_keys \u003d ["},{"line_number":70,"context_line":"            \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027, \u0027progress\u0027, \u0027provider_location\u0027,"},{"line_number":71,"context_line":"            \u0027share_id\u0027, \u0027share_instance_id\u0027, \u0027snapshot_id\u0027, \u0027status\u0027,"},{"line_number":72,"context_line":"        ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        expected_keys \u003d sorted(expected_keys)"},{"line_number":75,"context_line":"        actual_keys \u003d sorted(instances_detail.keys())"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_75517bd8","line":72,"range":{"start_line":69,"start_character":24,"end_line":72,"end_character":9},"updated":"2016-04-21 14:53:43.000000000","message":"Please, use tuple for container-like objects that are going to be used only for iteration and not update.","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        instances_detail \u003d self.shares_v2_client.get_snapshot_instance("},{"line_number":67,"context_line":"            instance_id\u003dinstances[0][\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        expected_keys \u003d ["},{"line_number":70,"context_line":"            \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027, \u0027progress\u0027, \u0027provider_location\u0027,"},{"line_number":71,"context_line":"            \u0027share_id\u0027, \u0027share_instance_id\u0027, \u0027snapshot_id\u0027, \u0027status\u0027,"},{"line_number":72,"context_line":"        ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        expected_keys \u003d sorted(expected_keys)"},{"line_number":75,"context_line":"        actual_keys \u003d sorted(instances_detail.keys())"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_767c9720","line":72,"range":{"start_line":69,"start_character":24,"end_line":72,"end_character":9},"in_reply_to":"1a122d0e_75517bd8","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ee797a3a19a1f9474bef16f473ccad100aee0aa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \u0027share_id\u0027, \u0027share_instance_id\u0027, \u0027snapshot_id\u0027, \u0027status\u0027,"},{"line_number":72,"context_line":"        ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        expected_keys \u003d sorted(expected_keys)"},{"line_number":75,"context_line":"        actual_keys \u003d sorted(instances_detail.keys())"},{"line_number":76,"context_line":"        self.assertEqual(expected_keys, actual_keys)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":79,"context_line":"    def test_reset_snapshot_instance_status(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_150e47e5","line":76,"range":{"start_line":74,"start_character":8,"end_line":76,"end_character":52},"updated":"2016-04-21 14:53:43.000000000","message":"for key in keys:\n    self.assertIn(key, actual_keys)\nself.assertEqual(len(keys), len(actual_keys))","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b72fa7e556e950f07d7ba616eb178f2dd88a76bd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            \u0027share_id\u0027, \u0027share_instance_id\u0027, \u0027snapshot_id\u0027, \u0027status\u0027,"},{"line_number":72,"context_line":"        ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        expected_keys \u003d sorted(expected_keys)"},{"line_number":75,"context_line":"        actual_keys \u003d sorted(instances_detail.keys())"},{"line_number":76,"context_line":"        self.assertEqual(expected_keys, actual_keys)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":79,"context_line":"    def test_reset_snapshot_instance_status(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a122d0e_5677db3a","line":76,"range":{"start_line":74,"start_character":8,"end_line":76,"end_character":52},"in_reply_to":"1a122d0e_150e47e5","updated":"2016-04-23 09:44:21.000000000","message":"Done","commit_id":"2011c109ef63d8d95a57632bb59a19b7dfb5c127"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cfaefa0f4534ef54646f4f2a90caac78f61190b4","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        actual_keys \u003d instance_detail.keys()"},{"line_number":75,"context_line":"        for key in expected_keys:"},{"line_number":76,"context_line":"            self.assertIn(expected_keys, actual_keys)"},{"line_number":77,"context_line":"        self.assertEqual(len(expected_keys), len(actual_keys))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @test.attr(type\u003d[\"gate\", ])"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a122d0e_2a575003","line":76,"range":{"start_line":76,"start_character":26,"end_line":76,"end_character":39},"updated":"2016-04-23 16:03:05.000000000","message":"key","commit_id":"6fe1df53e5e8dc85089b8af339b62ab38827ecdd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"12210872f1ed4b1374115ec6326d052a4f64ef05","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ShareSnapshotInstancesTest(base.BaseSharesAdminTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_c17d9ae8","line":24,"updated":"2016-05-05 14:21:41.000000000","message":"It is only part of possible tests. negative cases not covered as it is done for other APIs.","commit_id":"f5f3af1c7948b1f9fd4be8acd62451d9685951c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"12210872f1ed4b1374115ec6326d052a4f64ef05","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ShareSnapshotInstancesTest(base.BaseSharesAdminTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def resource_setup(cls):"},{"line_number":29,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":30,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":31,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":34,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2_16(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_a14a1eab","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":75},"updated":"2016-05-05 14:21:41.000000000","message":"This test suite should consider config option \"run_snapshot_tests\".","commit_id":"f5f3af1c7948b1f9fd4be8acd62451d9685951c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"12210872f1ed4b1374115ec6326d052a4f64ef05","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.16\u0027"},{"line_number":84,"context_line":"        )"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        sii \u003d snapshot_instances[0][\u0027id\u0027]"},{"line_number":87,"context_line":"        self.shares_v2_client.reset_snapshot_instance_status("},{"line_number":88,"context_line":"            sii, constants.STATUS_ERROR)"},{"line_number":89,"context_line":"        self.shares_v2_client.wait_for_snapshot_instance_status("},{"line_number":90,"context_line":"            sii, constants.STATUS_ERROR)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a122d0e_a154de21","line":90,"range":{"start_line":86,"start_character":8,"end_line":90,"end_character":40},"updated":"2016-05-05 14:21:41.000000000","message":"Here you change \"shared\" resource among several tests. It is incorrect approach. All tests, that update something should use dedicated resource for it.","commit_id":"f5f3af1c7948b1f9fd4be8acd62451d9685951c5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc7e2411a65eb0f624fde0da13d09c49c8db2e42","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":37,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2_16(self):"},{"line_number":38,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":39,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":40,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"dab17558_3c80e58a","line":37,"range":{"start_line":37,"start_character":50,"end_line":37,"end_character":54},"updated":"2016-05-17 03:08:30.000000000","message":"2_17","commit_id":"ce01d382f884fcdfcafc313fb6ad727aea404130"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ef14da7ff68e1518469f37a4ec4d910b387bbec","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":37,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2_16(self):"},{"line_number":38,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":39,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":40,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"bab6814e_51feee38","line":37,"range":{"start_line":37,"start_character":50,"end_line":37,"end_character":54},"in_reply_to":"dab17558_3c80e58a","updated":"2016-05-19 02:27:11.000000000","message":"Done","commit_id":"ce01d382f884fcdfcafc313fb6ad727aea404130"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc7e2411a65eb0f624fde0da13d09c49c8db2e42","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                                    si[\u0027snapshot_id\u0027]))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":55,"context_line":"    def test_list_snapshot_instances_v2_16(self):"},{"line_number":56,"context_line":"        \"\"\"Test that we get at least the snapshot instance.\"\"\""},{"line_number":57,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances()"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"dab17558_1c7b61bf","line":55,"range":{"start_line":55,"start_character":38,"end_line":55,"end_character":42},"updated":"2016-05-17 03:08:30.000000000","message":"same","commit_id":"ce01d382f884fcdfcafc313fb6ad727aea404130"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ef14da7ff68e1518469f37a4ec4d910b387bbec","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                                                    si[\u0027snapshot_id\u0027]))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":55,"context_line":"    def test_list_snapshot_instances_v2_16(self):"},{"line_number":56,"context_line":"        \"\"\"Test that we get at least the snapshot instance.\"\"\""},{"line_number":57,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances()"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"bab6814e_b1fd9a3c","line":55,"range":{"start_line":55,"start_character":38,"end_line":55,"end_character":42},"in_reply_to":"dab17558_1c7b61bf","updated":"2016-05-19 02:27:11.000000000","message":"Done","commit_id":"ce01d382f884fcdfcafc313fb6ad727aea404130"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc7e2411a65eb0f624fde0da13d09c49c8db2e42","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":66,"context_line":"    def test_get_snapshot_instance_v2_16(self):"},{"line_number":67,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":68,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":69,"context_line":"        instance_detail \u003d self.shares_v2_client.get_snapshot_instance("}],"source_content_type":"text/x-python","patch_set":32,"id":"dab17558_7c4c2d9e","line":66,"range":{"start_line":66,"start_character":36,"end_line":66,"end_character":40},"updated":"2016-05-17 03:08:30.000000000","message":"same","commit_id":"ce01d382f884fcdfcafc313fb6ad727aea404130"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ef14da7ff68e1518469f37a4ec4d910b387bbec","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":66,"context_line":"    def test_get_snapshot_instance_v2_16(self):"},{"line_number":67,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":68,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":69,"context_line":"        instance_detail \u003d self.shares_v2_client.get_snapshot_instance("}],"source_content_type":"text/x-python","patch_set":32,"id":"bab6814e_91f8564b","line":66,"range":{"start_line":66,"start_character":36,"end_line":66,"end_character":40},"in_reply_to":"dab17558_7c4c2d9e","updated":"2016-05-19 02:27:11.000000000","message":"Done","commit_id":"ce01d382f884fcdfcafc313fb6ad727aea404130"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_e878e22d","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":26},"updated":"2016-05-24 16:55:06.000000000","message":"Use config from manila plugin.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":26,"context_line":"                      \u0027Snapshot instance tests disabled.\u0027)"},{"line_number":27,"context_line":"class ShareSnapshotInstancesTest(base.BaseSharesAdminTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"},{"line_number":31,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":32,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":33,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":36,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_45063721","line":33,"range":{"start_line":25,"start_character":0,"end_line":33,"end_character":75},"updated":"2016-05-24 16:55:06.000000000","message":"It should also be skipped is max supported microversion is lower than 2.17","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":26,"context_line":"                      \u0027Snapshot instance tests disabled.\u0027)"},{"line_number":27,"context_line":"class ShareSnapshotInstancesTest(base.BaseSharesAdminTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"},{"line_number":31,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":32,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":33,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":36,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_c43969a5","line":33,"range":{"start_line":25,"start_character":0,"end_line":33,"end_character":75},"in_reply_to":"bab6814e_45063721","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":33,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":36,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self):"},{"line_number":37,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":38,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":39,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"},{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":43,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":44,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":47,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"},{"line_number":48,"context_line":"                         \u0027Snapshot instance %s has incorrect snapshot id;\u0027"},{"line_number":49,"context_line":"                         \u0027 expected %s, got %s.\u0027 % (si[\u0027id\u0027],"},{"line_number":50,"context_line":"                                                    self.snapshot[\u0027id\u0027],"},{"line_number":51,"context_line":"                                                    si[\u0027snapshot_id\u0027]))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":54,"context_line":"    def test_list_snapshot_instances_v2(self):"},{"line_number":55,"context_line":"        \"\"\"Test that we get at least the snapshot instance.\"\"\""},{"line_number":56,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        snapshot_ids \u003d [si[\u0027snapshot_id\u0027] for si in snapshot_instances]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        msg \u003d (\u0027snapshot instance for snapshot %s was not found.\u0027 %"},{"line_number":61,"context_line":"               self.snapshot[\u0027id\u0027])"},{"line_number":62,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":65,"context_line":"    def test_get_snapshot_instance_v2(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_0868c6b9","line":62,"range":{"start_line":35,"start_character":4,"end_line":62,"end_character":61},"updated":"2016-05-24 16:55:06.000000000","message":"Only one instance attribute is tested - \"snapshot_id\".\nNeed to cover others too. As you do in \"get\" test below.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":33,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":36,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self):"},{"line_number":37,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":38,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":39,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"},{"line_number":40,"context_line":"        )"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":43,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":44,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":47,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"},{"line_number":48,"context_line":"                         \u0027Snapshot instance %s has incorrect snapshot id;\u0027"},{"line_number":49,"context_line":"                         \u0027 expected %s, got %s.\u0027 % (si[\u0027id\u0027],"},{"line_number":50,"context_line":"                                                    self.snapshot[\u0027id\u0027],"},{"line_number":51,"context_line":"                                                    si[\u0027snapshot_id\u0027]))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":54,"context_line":"    def test_list_snapshot_instances_v2(self):"},{"line_number":55,"context_line":"        \"\"\"Test that we get at least the snapshot instance.\"\"\""},{"line_number":56,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        snapshot_ids \u003d [si[\u0027snapshot_id\u0027] for si in snapshot_instances]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        msg \u003d (\u0027snapshot instance for snapshot %s was not found.\u0027 %"},{"line_number":61,"context_line":"               self.snapshot[\u0027id\u0027])"},{"line_number":62,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":65,"context_line":"    def test_get_snapshot_instance_v2(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_50724f7d","line":62,"range":{"start_line":35,"start_character":4,"end_line":62,"end_character":61},"in_reply_to":"bab6814e_0868c6b9","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027share_id\u0027, \u0027share_instance_id\u0027, \u0027snapshot_id\u0027, \u0027status\u0027,"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        actual_keys \u003d instance_detail.keys()"},{"line_number":77,"context_line":"        for key in expected_keys:"},{"line_number":78,"context_line":"            self.assertIn(key, actual_keys)"},{"line_number":79,"context_line":"        self.assertEqual(len(expected_keys), len(actual_keys))"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_e8caa26d","line":76,"range":{"start_line":76,"start_character":22,"end_line":76,"end_character":44},"updated":"2016-05-24 16:55:06.000000000","message":"Please, wrap it in list else it won\u0027t work using python 3 when such attempt happens.","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027share_id\u0027, \u0027share_instance_id\u0027, \u0027snapshot_id\u0027, \u0027status\u0027,"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        actual_keys \u003d instance_detail.keys()"},{"line_number":77,"context_line":"        for key in expected_keys:"},{"line_number":78,"context_line":"            self.assertIn(key, actual_keys)"},{"line_number":79,"context_line":"        self.assertEqual(len(expected_keys), len(actual_keys))"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_f5d375d3","line":76,"range":{"start_line":76,"start_character":22,"end_line":76,"end_character":44},"in_reply_to":"bab6814e_e8caa26d","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8422cd8416e441fa66abd972ce2b2bee2b3ddcb5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual(len(expected_keys), len(actual_keys))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":82,"context_line":"    def test_reset_snapshot_instance_status(self):"},{"line_number":83,"context_line":"        \"\"\"Test resetting a snapshot instance\u0027s status attribute.\"\"\""},{"line_number":84,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active("},{"line_number":85,"context_line":"            self.share[\"id\"])"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_882b1633","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":43},"updated":"2016-05-24 16:55:06.000000000","message":"s/test_reset_snapshot_instance_status/test_reset_snapshot_instance_status_and_delete/","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba9eb6d0c5e0bde272afe9de6750bf50fae3788c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual(len(expected_keys), len(actual_keys))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":82,"context_line":"    def test_reset_snapshot_instance_status(self):"},{"line_number":83,"context_line":"        \"\"\"Test resetting a snapshot instance\u0027s status attribute.\"\"\""},{"line_number":84,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active("},{"line_number":85,"context_line":"            self.share[\"id\"])"}],"source_content_type":"text/x-python","patch_set":34,"id":"bab6814e_c4be8963","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":43},"in_reply_to":"bab6814e_882b1633","updated":"2016-05-25 10:05:19.000000000","message":"Done","commit_id":"16ad1059e6f95540b6229dbff50b3f0f9e2c8f1e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5d8c1e2dfc9a1a928150261cfe395bfbdd5fea5c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":26,"context_line":"                      \u0027Snapshot instance tests disabled.\u0027)"},{"line_number":27,"context_line":"@base.skip_if_microversion_lt(\"2.17\")"}],"source_content_type":"text/x-python","patch_set":35,"id":"bab6814e_66febdaf","line":24,"updated":"2016-05-25 10:35:59.000000000","message":"Sorry, that din\u0027t mention it earlier, but negative tests are absent. Such as:\n\n- \"get\" nonexisting snapshot-instance\n- \"list\" with filtering by nonexisting snapshot\n- request all of these APIs with member user\n\nPlus for positive cases:\n\n- summary list is not tested.","commit_id":"bece9493ee4cf23c5cf4e96f53825198d24a9f5f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"28e8e9478a70fdb899bea0323ef0df6a3f1f18df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib import exceptions as lib_exc  # noqa"},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"7aa08908_f4cb9e70","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":53},"updated":"2016-06-06 13:40:30.000000000","message":"Why \"noqa\"?","commit_id":"d8f46009840a0c416221d90201b41c4a3c496a96"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d32c5066fe1716e8deedab1a0dce78f7ea4f91c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":"from tempest.lib import exceptions as lib_exc  # noqa"},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"7aa08908_3cb2bd06","line":17,"range":{"start_line":17,"start_character":45,"end_line":17,"end_character":53},"in_reply_to":"7aa08908_f4cb9e70","updated":"2016-06-08 06:13:57.000000000","message":"Done","commit_id":"d8f46009840a0c416221d90201b41c4a3c496a96"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"28e8e9478a70fdb899bea0323ef0df6a3f1f18df","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":38,"context_line":"    def test_summary_list_snapshot_instances_by_snapshot_v2(self):"},{"line_number":39,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":40,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":41,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"}],"source_content_type":"text/x-python","patch_set":36,"id":"7aa08908_743cce93","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":59},"updated":"2016-06-06 13:40:30.000000000","message":"It is \"list_snapshot_instances(detail\u003dFalse)\", but case with \"list_snapshot_instances(self, detail\u003dTrue\" is absent.","commit_id":"d8f46009840a0c416221d90201b41c4a3c496a96"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d32c5066fe1716e8deedab1a0dce78f7ea4f91c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":38,"context_line":"    def test_summary_list_snapshot_instances_by_snapshot_v2(self):"},{"line_number":39,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":40,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":41,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"}],"source_content_type":"text/x-python","patch_set":36,"id":"7aa08908_1cb701f6","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":59},"in_reply_to":"7aa08908_743cce93","updated":"2016-06-08 06:13:57.000000000","message":"Done","commit_id":"d8f46009840a0c416221d90201b41c4a3c496a96"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"28e8e9478a70fdb899bea0323ef0df6a3f1f18df","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":109,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":112,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":113,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":114,"context_line":"                          self.shares_v2_client.get_snapshot_instance,"},{"line_number":115,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":118,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"},{"line_number":119,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":120,"context_line":"                          self.shares_v2_client.list_snapshot_instances,"},{"line_number":121,"context_line":"                          snapshot_id\u003d\"nonexist_snapshot\", version\u003d\u00272.17\u0027)"}],"source_content_type":"text/x-python","patch_set":36,"id":"7aa08908_74e20ed7","line":121,"range":{"start_line":111,"start_character":3,"end_line":121,"end_character":74},"updated":"2016-06-06 13:40:30.000000000","message":"These are negative tests. So, I recommend to keep them separately.\n\nAlso, carry-over from previous patch-set:\n\nTest cases \"request all of these APIs with member user\" are absent.","commit_id":"d8f46009840a0c416221d90201b41c4a3c496a96"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d32c5066fe1716e8deedab1a0dce78f7ea4f91c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":109,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":112,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":113,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":114,"context_line":"                          self.shares_v2_client.get_snapshot_instance,"},{"line_number":115,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":118,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"},{"line_number":119,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":120,"context_line":"                          self.shares_v2_client.list_snapshot_instances,"},{"line_number":121,"context_line":"                          snapshot_id\u003d\"nonexist_snapshot\", version\u003d\u00272.17\u0027)"}],"source_content_type":"text/x-python","patch_set":36,"id":"7aa08908_7cd0c51f","line":121,"range":{"start_line":111,"start_character":3,"end_line":121,"end_character":74},"in_reply_to":"7aa08908_74e20ed7","updated":"2016-06-08 06:13:57.000000000","message":"Done","commit_id":"d8f46009840a0c416221d90201b41c4a3c496a96"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"22fb9158c495c89ebc4a51586442b471b5e16d70","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @ddt.data(True, False)"},{"line_number":40,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":41,"context_line":"    def test_summary_list_snapshot_instances_by_snapshot_v2(self, detail):"},{"line_number":42,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":43,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":44,"context_line":"            detail\u003ddetail, snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_1fa573a1","line":41,"range":{"start_line":41,"start_character":13,"end_line":41,"end_character":21},"updated":"2016-06-07 09:24:38.000000000","message":"Not only summary anymore.","commit_id":"20f37473f143b2a272c8640df38329a83307a1b5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bde76f9e45788ebfbdb5101e73e769503f73ac4b","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @ddt.data(True, False)"},{"line_number":40,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":41,"context_line":"    def test_summary_list_snapshot_instances_by_snapshot_v2(self, detail):"},{"line_number":42,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":43,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":44,"context_line":"            detail\u003ddetail, snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.17\u0027"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_dcc0d952","line":41,"range":{"start_line":41,"start_character":13,"end_line":41,"end_character":21},"in_reply_to":"7aa08908_1fa573a1","updated":"2016-06-08 06:14:53.000000000","message":"Done","commit_id":"20f37473f143b2a272c8640df38329a83307a1b5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7890fbae990a9f4c2dc55403f42db772ddc802f3","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if detail:"},{"line_number":53,"context_line":"            extra_detail_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027progress\u0027]"},{"line_number":54,"context_line":"            expected_keys.extend(extra_detail_keys)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":57,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_65786190","line":54,"range":{"start_line":54,"start_character":12,"end_line":54,"end_character":25},"updated":"2016-06-07 10:27:13.000000000","message":"\"expected_keys\" is immutable tuple and has no \"extend\" method. It will fail.","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef7ecde6757d52a9f0454ce8f6bb298771780abf","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if detail:"},{"line_number":53,"context_line":"            extra_detail_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027progress\u0027]"},{"line_number":54,"context_line":"            expected_keys.extend(extra_detail_keys)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":57,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_1c126109","line":54,"range":{"start_line":54,"start_character":12,"end_line":54,"end_character":25},"in_reply_to":"7aa08908_65786190","updated":"2016-06-08 06:12:27.000000000","message":"Done","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            extra_detail_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027progress\u0027]"},{"line_number":51,"context_line":"            expected_keys.extend(extra_detail_keys)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":54,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":55,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_55eaf0ac","line":53,"range":{"start_line":53,"start_character":28,"end_line":53,"end_character":52},"updated":"2016-06-24 10:23:51.000000000","message":"You calculate length of list twice. Better to save result of first calculation and just reuse it.","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            extra_detail_keys \u003d [\u0027created_at\u0027, \u0027updated_at\u0027, \u0027progress\u0027]"},{"line_number":51,"context_line":"            expected_keys.extend(extra_detail_keys)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertEqual(1, len(snapshot_instances),"},{"line_number":54,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":55,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_a175a864","line":53,"range":{"start_line":53,"start_character":28,"end_line":53,"end_character":52},"in_reply_to":"3aaa91ec_55eaf0ac","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":58,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"},{"line_number":59,"context_line":"                         \u0027Snapshot instance %s has incorrect snapshot id;\u0027"},{"line_number":60,"context_line":"                         \u0027 expected %s, got %s.\u0027 % (si[\u0027id\u0027],"},{"line_number":61,"context_line":"                                                    self.snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_f5f03c93","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":64},"updated":"2016-06-24 10:23:51.000000000","message":"Checked snapshot ID, why source share ID not checked?","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                         \u0027found %s\u0027 % len(snapshot_instances))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":58,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"},{"line_number":59,"context_line":"                         \u0027Snapshot instance %s has incorrect snapshot id;\u0027"},{"line_number":60,"context_line":"                         \u0027 expected %s, got %s.\u0027 % (si[\u0027id\u0027],"},{"line_number":61,"context_line":"                                                    self.snapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_e16b3083","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":64},"in_reply_to":"3aaa91ec_f5f03c93","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        for key in instance_detail:"},{"line_number":91,"context_line":"            self.assertIn(key, expected_keys)"},{"line_number":92,"context_line":"        self.assertEqual(len(expected_keys), len(instance_detail))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":95,"context_line":"    def test_reset_snapshot_instance_status_and_delete(self):"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_953e1826","line":92,"updated":"2016-06-24 10:23:51.000000000","message":"Values are not verified at all.","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        for key in instance_detail:"},{"line_number":91,"context_line":"            self.assertIn(key, expected_keys)"},{"line_number":92,"context_line":"        self.assertEqual(len(expected_keys), len(instance_detail))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":95,"context_line":"    def test_reset_snapshot_instance_status_and_delete(self):"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_610e20e6","line":92,"in_reply_to":"3aaa91ec_953e1826","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":101,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], version\u003d\u00272.18\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        states \u003d [\"error\", \"available\"]"},{"line_number":104,"context_line":"        sii \u003d snapshot_instances[0][\u0027id\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for status in states:"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_3562c43e","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":39},"updated":"2016-06-24 10:23:51.000000000","message":"This line could be removed.","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":101,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], version\u003d\u00272.18\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        states \u003d [\"error\", \"available\"]"},{"line_number":104,"context_line":"        sii \u003d snapshot_instances[0][\u0027id\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for status in states:"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_a1fc88b8","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":39},"in_reply_to":"3aaa91ec_3562c43e","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        states \u003d [\"error\", \"available\"]"},{"line_number":104,"context_line":"        sii \u003d snapshot_instances[0][\u0027id\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for status in states:"},{"line_number":107,"context_line":"            self.shares_v2_client.reset_snapshot_instance_status("},{"line_number":108,"context_line":"                sii, status\u003dstatus)"},{"line_number":109,"context_line":"            self.shares_v2_client.wait_for_snapshot_instance_status("}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_9553b86a","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":29},"updated":"2016-06-24 10:23:51.000000000","message":"and this updated to following:\n\n\"\"\"\nfor status in (\"error\", \"available\"):\n\"\"\"","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        states \u003d [\"error\", \"available\"]"},{"line_number":104,"context_line":"        sii \u003d snapshot_instances[0][\u0027id\u0027]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        for status in states:"},{"line_number":107,"context_line":"            self.shares_v2_client.reset_snapshot_instance_status("},{"line_number":108,"context_line":"                sii, status\u003dstatus)"},{"line_number":109,"context_line":"            self.shares_v2_client.wait_for_snapshot_instance_status("}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_81f7ccd1","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":29},"in_reply_to":"3aaa91ec_9553b86a","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2a80bfc7269cf5046f2d48cf859f0b2b05cc5170","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self, detail):"},{"line_number":41,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":42,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":43,"context_line":"            detail\u003ddetail, snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.19\u0027"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        expected_keys \u003d [\u0027id\u0027, \u0027provider_location\u0027, \u0027share_id\u0027,"}],"source_content_type":"text/x-python","patch_set":56,"id":"dada55a8_d41caf6c","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":74},"updated":"2016-07-22 15:31:41.000000000","message":"You specify API version only in 2 tests from 4. Why?","commit_id":"3d1b491ba0c15f0f89925920cce87e8e7b22654e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e3e0e7a277f63fe796182ba4a4176fdb48d3d1d0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self, detail):"},{"line_number":41,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":42,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":43,"context_line":"            detail\u003ddetail, snapshot_id\u003dself.snapshot[\u0027id\u0027], version\u003d\u00272.19\u0027"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        expected_keys \u003d [\u0027id\u0027, \u0027provider_location\u0027, \u0027share_id\u0027,"}],"source_content_type":"text/x-python","patch_set":56,"id":"dada55a8_ffe4c73c","line":43,"range":{"start_line":43,"start_character":60,"end_line":43,"end_character":74},"in_reply_to":"dada55a8_d41caf6c","updated":"2016-07-26 03:53:16.000000000","message":"Done \nThanks for point it out. When I add \"@base.skip_if_microversion_lt(\"2.19\")\", this version could be removed.","commit_id":"3d1b491ba0c15f0f89925920cce87e8e7b22654e"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e2f3b2448d7060041a9c81ca12d0bf029d7b286","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        si_num \u003d len(snapshot_instances)"},{"line_number":53,"context_line":"        self.assertEqual(1, si_num,"},{"line_number":54,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":55,"context_line":"                         \u0027found %s\u0027 % si_num)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        si \u003d snapshot_instances[0]"}],"source_content_type":"text/x-python","patch_set":58,"id":"dada55a8_633c70e1","line":54,"range":{"start_line":54,"start_character":26,"end_line":54,"end_character":44},"updated":"2016-07-27 12:24:45.000000000","message":"s/Incorrect snapshot/Incorrect amount of snapshot","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5cd4d793eb481883020569c53dc89399c4f18a92","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        si_num \u003d len(snapshot_instances)"},{"line_number":53,"context_line":"        self.assertEqual(1, si_num,"},{"line_number":54,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":55,"context_line":"                         \u0027found %s\u0027 % si_num)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        si \u003d snapshot_instances[0]"}],"source_content_type":"text/x-python","patch_set":58,"id":"bacf61ea_abe4383b","line":54,"range":{"start_line":54,"start_character":26,"end_line":54,"end_character":44},"in_reply_to":"dada55a8_633c70e1","updated":"2016-07-28 01:05:21.000000000","message":"Done","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e2f3b2448d7060041a9c81ca12d0bf029d7b286","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        si_num \u003d len(snapshot_instances)"},{"line_number":53,"context_line":"        self.assertEqual(1, si_num,"},{"line_number":54,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":55,"context_line":"                         \u0027found %s\u0027 % si_num)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":58,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"}],"source_content_type":"text/x-python","patch_set":58,"id":"dada55a8_231d5873","line":55,"range":{"start_line":55,"start_character":33,"end_line":55,"end_character":35},"updated":"2016-07-27 12:24:45.000000000","message":"period","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5cd4d793eb481883020569c53dc89399c4f18a92","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        si_num \u003d len(snapshot_instances)"},{"line_number":53,"context_line":"        self.assertEqual(1, si_num,"},{"line_number":54,"context_line":"                         \u0027Incorrect snapshot instances found; expected 1, \u0027"},{"line_number":55,"context_line":"                         \u0027found %s\u0027 % si_num)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        si \u003d snapshot_instances[0]"},{"line_number":58,"context_line":"        self.assertEqual(self.snapshot[\u0027id\u0027], si[\u0027snapshot_id\u0027],"}],"source_content_type":"text/x-python","patch_set":58,"id":"bacf61ea_0bd0e452","line":55,"range":{"start_line":55,"start_character":33,"end_line":55,"end_character":35},"in_reply_to":"dada55a8_231d5873","updated":"2016-07-28 01:05:21.000000000","message":"Done","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e2f3b2448d7060041a9c81ca12d0bf029d7b286","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        snapshot_ids \u003d [si[\u0027snapshot_id\u0027] for si in snapshot_instances]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        msg \u003d (\u0027snapshot instance for snapshot %s was not found.\u0027 %"},{"line_number":77,"context_line":"               self.snapshot[\u0027id\u0027])"},{"line_number":78,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"dada55a8_c30efc39","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":17},"updated":"2016-07-27 12:24:45.000000000","message":"S","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5cd4d793eb481883020569c53dc89399c4f18a92","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        snapshot_ids \u003d [si[\u0027snapshot_id\u0027] for si in snapshot_instances]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        msg \u003d (\u0027snapshot instance for snapshot %s was not found.\u0027 %"},{"line_number":77,"context_line":"               self.snapshot[\u0027id\u0027])"},{"line_number":78,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":58,"id":"bacf61ea_2bcfa8b1","line":76,"range":{"start_line":76,"start_character":15,"end_line":76,"end_character":17},"in_reply_to":"dada55a8_c30efc39","updated":"2016-07-28 01:05:21.000000000","message":"Done","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e2f3b2448d7060041a9c81ca12d0bf029d7b286","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":102,"context_line":"    def test_reset_snapshot_instance_status_and_delete(self):"},{"line_number":103,"context_line":"        \"\"\"Test resetting a snapshot instance\u0027s status attribute.\"\"\""},{"line_number":104,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active("},{"line_number":105,"context_line":"            self.share[\"id\"])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":108,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":58,"id":"dada55a8_1e2b4b83","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":29},"updated":"2016-07-27 12:24:45.000000000","message":"fits one line","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5cd4d793eb481883020569c53dc89399c4f18a92","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":102,"context_line":"    def test_reset_snapshot_instance_status_and_delete(self):"},{"line_number":103,"context_line":"        \"\"\"Test resetting a snapshot instance\u0027s status attribute.\"\"\""},{"line_number":104,"context_line":"        snapshot \u003d self.create_snapshot_wait_for_active("},{"line_number":105,"context_line":"            self.share[\"id\"])"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":108,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":58,"id":"bacf61ea_6bc1a080","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":29},"in_reply_to":"dada55a8_1e2b4b83","updated":"2016-07-28 01:05:21.000000000","message":"Done","commit_id":"328006626e2fe39fb192d2e1d5aabf78ddf11c14"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":27,"context_line":"                      \u0027Snapshot instance tests disabled.\u0027)"},{"line_number":28,"context_line":"@base.skip_if_microversion_lt(\"2.19\")"},{"line_number":29,"context_line":"@ddt.ddt"},{"line_number":30,"context_line":"class ShareSnapshotInstancesTest(base.BaseSharesAdminTest):"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_67a43057","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":56},"updated":"2016-07-28 03:43:02.000000000","message":"see comment in test_share_snapshots_negative.py","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":27,"context_line":"                      \u0027Snapshot instance tests disabled.\u0027)"},{"line_number":28,"context_line":"@base.skip_if_microversion_lt(\"2.19\")"},{"line_number":29,"context_line":"@ddt.ddt"},{"line_number":30,"context_line":"class ShareSnapshotInstancesTest(base.BaseSharesAdminTest):"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_191b131d","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":56},"in_reply_to":"bacf61ea_67a43057","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(True, False)"},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":40,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self, detail):"},{"line_number":41,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":42,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":43,"context_line":"            detail\u003ddetail, snapshot_id\u003dself.snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_caafe3e1","line":40,"range":{"start_line":40,"start_character":49,"end_line":40,"end_character":51},"updated":"2016-07-28 03:43:02.000000000","message":"?","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(True, False)"},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":40,"context_line":"    def test_list_snapshot_instances_by_snapshot_v2(self, detail):"},{"line_number":41,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":42,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":43,"context_line":"            detail\u003ddetail, snapshot_id\u003dself.snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_feef05ae","line":40,"range":{"start_line":40,"start_character":49,"end_line":40,"end_character":51},"in_reply_to":"bacf61ea_caafe3e1","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(len(expected_keys), len(si))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":70,"context_line":"    def test_list_snapshot_instances_v2(self):"},{"line_number":71,"context_line":"        \"\"\"Test that we get at least the snapshot instance.\"\"\""},{"line_number":72,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_eab6273c","line":70,"range":{"start_line":70,"start_character":37,"end_line":70,"end_character":39},"updated":"2016-07-28 03:43:02.000000000","message":"?","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(len(expected_keys), len(si))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":70,"context_line":"    def test_list_snapshot_instances_v2(self):"},{"line_number":71,"context_line":"        \"\"\"Test that we get at least the snapshot instance.\"\"\""},{"line_number":72,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_3e307d56","line":70,"range":{"start_line":70,"start_character":37,"end_line":70,"end_character":39},"in_reply_to":"bacf61ea_eab6273c","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":81,"context_line":"    def test_get_snapshot_instance_v2(self):"},{"line_number":82,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":83,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":84,"context_line":"        instance_detail \u003d self.shares_v2_client.get_snapshot_instance("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_ea8d877c","line":81,"range":{"start_line":81,"start_character":35,"end_line":81,"end_character":36},"updated":"2016-07-28 03:43:02.000000000","message":"?","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids, msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":81,"context_line":"    def test_get_snapshot_instance_v2(self):"},{"line_number":82,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":83,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":84,"context_line":"        instance_detail \u003d self.shares_v2_client.get_snapshot_instance("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_7e3af537","line":81,"range":{"start_line":81,"start_character":35,"end_line":81,"end_character":36},"in_reply_to":"bacf61ea_ea8d877c","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2712b39c5154a86866d7ad053afececac250621e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(True, False)"},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE])"},{"line_number":40,"context_line":"    def test_list_snapshot_instances_by_snapshot(self, detail):"},{"line_number":41,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":42,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":61,"id":"bacf61ea_bfdd8472","line":39,"updated":"2016-07-28 08:52:15.000000000","message":"Second tag is lost. reminding that, while this test uses created resources it will be \"api with backend\".","commit_id":"ff62bcd6b96bf669f9679b923b9c5a40044bf6da"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"876a7221f45cd5e37b61a504a78cac47d849549b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(True, False)"},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE])"},{"line_number":40,"context_line":"    def test_list_snapshot_instances_by_snapshot(self, detail):"},{"line_number":41,"context_line":"        \"\"\"Test that we get only the 1 snapshot instance from snapshot.\"\"\""},{"line_number":42,"context_line":"        snapshot_instances \u003d self.shares_v2_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":61,"id":"bacf61ea_ba963292","line":39,"in_reply_to":"bacf61ea_bfdd8472","updated":"2016-07-28 09:07:32.000000000","message":"+1 these were tagged correctly...","commit_id":"ff62bcd6b96bf669f9679b923b9c5a40044bf6da"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e43b6cfc1b63fb74f3cd15611a3dd8c34ab4b73","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if detail:"},{"line_number":48,"context_line":"            extra_detail_keys \u003d [\u0027provider_location\u0027, \u0027share_id\u0027,"},{"line_number":49,"context_line":"                                 \u0027share_instance_id\u0027,\u0027created_at\u0027,"},{"line_number":50,"context_line":"                                 \u0027updated_at\u0027, \u0027progress\u0027]"},{"line_number":51,"context_line":"            expected_keys.extend(extra_detail_keys)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_c53b42ea","line":49,"updated":"2016-07-28 11:31:54.000000000","message":"space is lost","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15b706ec5d9723fe6ed9153e730f5f6ce71e64cc","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if detail:"},{"line_number":48,"context_line":"            extra_detail_keys \u003d [\u0027provider_location\u0027, \u0027share_id\u0027,"},{"line_number":49,"context_line":"                                 \u0027share_instance_id\u0027,\u0027created_at\u0027,"},{"line_number":50,"context_line":"                                 \u0027updated_at\u0027, \u0027progress\u0027]"},{"line_number":51,"context_line":"            expected_keys.extend(extra_detail_keys)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_606361b2","line":49,"in_reply_to":"bacf61ea_c53b42ea","updated":"2016-07-28 13:54:23.000000000","message":"Done","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"22e86c3f831c288d50f6f2724f85d577426a4bd0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def resource_setup(cls):"},{"line_number":34,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":36,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @ddt.data(True, False)"},{"line_number":39,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":64,"id":"bacf61ea_3dca0e6f","line":36,"range":{"start_line":36,"start_character":7,"end_line":36,"end_character":75},"updated":"2016-07-28 23:54:59.000000000","message":"This will give you the snapshot object that the POST /share-snapshots API gives you; i.e, will not give you the updated snapshot after it has been successfully created. For you to verify provider location, remember that you need the latest snapshot data, after it has become available.\n\n  cls.snapshot \u003d cls.get_snapshot(cls.snapshot[\u0027id\u0027])","commit_id":"b553377a1004707ce6fe1584686be403dc69de52"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"b144572829bedf26f328e9fed1a3ad40abc26103","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":36,"context_line":"        snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":"        cls.snapshot \u003d cls.shares_v2_client.get_snapshot(snap[\u0027id\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @ddt.data(True, False)"},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":66,"id":"bacf61ea_d87da71d","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"updated":"2016-07-29 12:36:43.000000000","message":"I am in favor of moving this to the create_snapshot_wait_for_active method so it saves everybody from worrying about this logic for every snapshot instance test that has to create snapshots.","commit_id":"8a487bf95d785fe1a98de216310e0e06e734f830"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8f3e79e58d6babfd978fdbb3b99d612f34e015be","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":36,"context_line":"        snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":"        cls.snapshot \u003d cls.shares_v2_client.get_snapshot(snap[\u0027id\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @ddt.data(True, False)"},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":66,"id":"bacf61ea_ea308a03","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"in_reply_to":"bacf61ea_d87da71d","updated":"2016-07-29 15:16:17.000000000","message":"Hi Rodrigo Barbieri, this code is for \"Add snapshot instances admin APIs(list/show/reset-status)\", and there are some other places use the same function(create_snapshot_wait_for_active) to test. If we need to change this logic, we need to open another bug to fix this. Because some other tempest test is not include in this blueprint, and we need to fix all of these.  right? so, Could we let this patch go on? Thanks","commit_id":"8a487bf95d785fe1a98de216310e0e06e734f830"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ea33ee2f2a818980190151426167061c64b6a6ca","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        super(ShareSnapshotInstancesTest, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":36,"context_line":"        snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":"        cls.snapshot \u003d cls.shares_v2_client.get_snapshot(snap[\u0027id\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @ddt.data(True, False)"},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND])"}],"source_content_type":"text/x-python","patch_set":66,"id":"bacf61ea_7b3f4b87","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":68},"in_reply_to":"bacf61ea_ea308a03","updated":"2016-07-29 15:36:49.000000000","message":"Rodrigo, I feel that we should not fix this method at all. It\u0027s doing the right thing. giving you the response of the /POST API. How else would you be able to validate the response of that API if we return the response of the GET API in that call.","commit_id":"8a487bf95d785fe1a98de216310e0e06e734f830"}],"manila_tempest_tests/tests/api/admin/test_share_snapshot_instances_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"22fb9158c495c89ebc4a51586442b471b5e16d70","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def resource_setup(cls):"},{"line_number":33,"context_line":"        super(ShareSnapshotInstancesNegativeTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":35,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":38,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_1ffa9375","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":75},"updated":"2016-06-07 09:24:38.000000000","message":"Why do you create resources if you do not use it?","commit_id":"20f37473f143b2a272c8640df38329a83307a1b5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bde76f9e45788ebfbdb5101e73e769503f73ac4b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def resource_setup(cls):"},{"line_number":33,"context_line":"        super(ShareSnapshotInstancesNegativeTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":35,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":38,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_7c972548","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":75},"in_reply_to":"7aa08908_1ffa9375","updated":"2016-06-08 06:14:53.000000000","message":"Done","commit_id":"20f37473f143b2a272c8640df38329a83307a1b5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"22fb9158c495c89ebc4a51586442b471b5e16d70","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(ShareSnapshotInstancesNegativeTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":35,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":38,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":39,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_ff3b4736","line":36,"updated":"2016-06-07 09:24:38.000000000","message":"Still no cases for making requests with non-admin.","commit_id":"20f37473f143b2a272c8640df38329a83307a1b5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bde76f9e45788ebfbdb5101e73e769503f73ac4b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(ShareSnapshotInstancesNegativeTest, cls).resource_setup()"},{"line_number":34,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":35,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":38,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":39,"context_line":"        self.assertRaises(lib_exc.NotFound,"}],"source_content_type":"text/x-python","patch_set":39,"id":"7aa08908_5c94e941","line":36,"in_reply_to":"7aa08908_ff3b4736","updated":"2016-06-08 06:14:53.000000000","message":"Done","commit_id":"20f37473f143b2a272c8640df38329a83307a1b5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7890fbae990a9f4c2dc55403f42db772ddc802f3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":36,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":39,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":40,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":41,"context_line":"                          self.shares_v2_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_c5a6750f","line":38,"updated":"2016-06-07 10:27:13.000000000","message":"this","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef7ecde6757d52a9f0454ce8f6bb298771780abf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":36,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":39,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":40,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":41,"context_line":"                          self.shares_v2_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_bc018db1","line":38,"in_reply_to":"7aa08908_c5a6750f","updated":"2016-06-08 06:12:27.000000000","message":"Done","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7890fbae990a9f4c2dc55403f42db772ddc802f3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                          self.shares_v2_client.get_snapshot_instance,"},{"line_number":42,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":45,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"},{"line_number":46,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":47,"context_line":"                          self.shares_v2_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_25b6593d","line":44,"updated":"2016-06-07 10:27:13.000000000","message":"And this is \"negative\" too. If you add appropriate tag, then add it consistently.","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef7ecde6757d52a9f0454ce8f6bb298771780abf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                          self.shares_v2_client.get_snapshot_instance,"},{"line_number":42,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":45,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"},{"line_number":46,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":47,"context_line":"                          self.shares_v2_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_9cfe51ac","line":44,"in_reply_to":"7aa08908_25b6593d","updated":"2016-06-08 06:12:27.000000000","message":"Done","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7890fbae990a9f4c2dc55403f42db772ddc802f3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          snapshot_id\u003d\"nonexist_snapshot\", version\u003d\u00272.17\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":51,"context_line":"    def test_list_snapshot_instance_with_snapshot_by_member(self):"},{"line_number":52,"context_line":"        self.assertRaises("},{"line_number":53,"context_line":"            lib_exc.Forbidden,"},{"line_number":54,"context_line":"            self.member_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_6586a166","line":51,"range":{"start_line":51,"start_character":27,"end_line":51,"end_character":35},"updated":"2016-06-07 10:27:13.000000000","message":"s/instance/instances/","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef7ecde6757d52a9f0454ce8f6bb298771780abf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          snapshot_id\u003d\"nonexist_snapshot\", version\u003d\u00272.17\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":51,"context_line":"    def test_list_snapshot_instance_with_snapshot_by_member(self):"},{"line_number":52,"context_line":"        self.assertRaises("},{"line_number":53,"context_line":"            lib_exc.Forbidden,"},{"line_number":54,"context_line":"            self.member_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_fc2dd546","line":51,"range":{"start_line":51,"start_character":27,"end_line":51,"end_character":35},"in_reply_to":"7aa08908_6586a166","updated":"2016-06-08 06:12:27.000000000","message":"Done","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7890fbae990a9f4c2dc55403f42db772ddc802f3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":59,"context_line":"    def test_list_snapshot_instance_by_member(self):"},{"line_number":60,"context_line":"        self.assertRaises("},{"line_number":61,"context_line":"            lib_exc.Forbidden,"},{"line_number":62,"context_line":"            self.member_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_c57dd56f","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":35},"updated":"2016-06-07 10:27:13.000000000","message":"s/instance/instances/","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef7ecde6757d52a9f0454ce8f6bb298771780abf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":59,"context_line":"    def test_list_snapshot_instance_by_member(self):"},{"line_number":60,"context_line":"        self.assertRaises("},{"line_number":61,"context_line":"            lib_exc.Forbidden,"},{"line_number":62,"context_line":"            self.member_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_3c247d5e","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":35},"in_reply_to":"7aa08908_c57dd56f","updated":"2016-06-08 06:12:27.000000000","message":"Done","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7890fbae990a9f4c2dc55403f42db772ddc802f3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":76,"context_line":"    def test_reset_snapshot_instance_by_member(self):"},{"line_number":77,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":78,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":79,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_85eaad0d","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":36},"updated":"2016-06-07 10:27:13.000000000","message":"s/reset_snapshot_instance/reset_snapshot_instance_status/","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ef7ecde6757d52a9f0454ce8f6bb298771780abf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.attr(type\u003d[\"gate\", \"negative\"])"},{"line_number":76,"context_line":"    def test_reset_snapshot_instance_by_member(self):"},{"line_number":77,"context_line":"        instances \u003d self.shares_v2_client.list_snapshot_instances("},{"line_number":78,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":79,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":40,"id":"7aa08908_7c228553","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":36},"in_reply_to":"7aa08908_85eaad0d","updated":"2016-06-08 06:12:27.000000000","message":"Done","commit_id":"a5a9a4995bf0ccee11b4edec91607edfc08b209e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_156a28ee","line":44,"range":{"start_line":44,"start_character":39,"end_line":44,"end_character":47},"updated":"2016-06-24 10:23:51.000000000","message":"s/nonexist/nonexistent/\n\nsame in other places.","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_e10210b3","line":44,"range":{"start_line":44,"start_character":39,"end_line":44,"end_character":47},"in_reply_to":"3aaa91ec_156a28ee","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6a18eed1292d22c437697b17444226fa89420d41","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"},{"line_number":48,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":49,"context_line":"                          self.admin_client.list_snapshot_instances,"},{"line_number":50,"context_line":"                          snapshot_id\u003d\"nonexist_snapshot\", version\u003d\u00272.18\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":53,"context_line":"    def test_list_snapshot_instances_with_snapshot_by_member(self):"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_354c849d","line":50,"range":{"start_line":46,"start_character":4,"end_line":50,"end_character":74},"updated":"2016-06-24 10:23:51.000000000","message":"List operation should not return bad request. Just empty list.","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b2c3bec94267b477a919c4672c5c296d121908e2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexist_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instance_with_notexist_instance(self):"},{"line_number":48,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":49,"context_line":"                          self.admin_client.list_snapshot_instances,"},{"line_number":50,"context_line":"                          snapshot_id\u003d\"nonexist_snapshot\", version\u003d\u00272.18\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":53,"context_line":"    def test_list_snapshot_instances_with_snapshot_by_member(self):"}],"source_content_type":"text/x-python","patch_set":47,"id":"3aaa91ec_41dfa439","line":50,"range":{"start_line":46,"start_character":4,"end_line":50,"end_character":74},"in_reply_to":"3aaa91ec_354c849d","updated":"2016-06-26 02:14:32.000000000","message":"Done","commit_id":"fe90fc31c1dda31e067ed05084124f06b9a3abdc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":27,"context_line":"                      \u0027Snapshot instance negative tests disabled.\u0027)"},{"line_number":28,"context_line":"@base.skip_if_microversion_lt(\"2.19\")"},{"line_number":29,"context_line":"class ShareSnapshotInstancesNegativeTest(base.BaseSharesMixedTest):"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_67ed508b","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":64},"updated":"2016-07-28 03:43:02.000000000","message":"suggestion: You are not really providing a way to disable just this class of tests; so this message should really say \"Snapshot tests are disabled.\"; it gives you a hint of which option to enable. the name of the test is already suggested through the class name. \n\n setUpClass (manila_tempest_tests.tests.api.admin.test_share_snapshot_instances_negative.ShareSnapshotInstancesNegativeTest) ... SKIPPED: snapshot tests are disabled..\n\n\n^^\nThis is very clear what test was attempted and why it was skipped.","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@testtools.skipUnless(CONF.share.run_snapshot_tests,"},{"line_number":27,"context_line":"                      \u0027Snapshot instance negative tests disabled.\u0027)"},{"line_number":28,"context_line":"@base.skip_if_microversion_lt(\"2.19\")"},{"line_number":29,"context_line":"class ShareSnapshotInstancesNegativeTest(base.BaseSharesMixedTest):"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_be510d65","line":27,"range":{"start_line":27,"start_character":23,"end_line":27,"end_character":64},"in_reply_to":"bacf61ea_67ed508b","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_aa6f0f91","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":65},"updated":"2016-07-28 03:43:02.000000000","message":"Nope.. don\u0027t need a backend for this.","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c477240be7f96c68b4b1f13f59195120add1ebc2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_8422f7b7","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":65},"in_reply_to":"bacf61ea_9eb6c988","updated":"2016-07-28 08:56:26.000000000","message":"This test belongs to class that creates resources. So, for the moment it is correct.\n\nProper concern is to move this test out of class that creates resources. Same for all other.","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_9eb6c988","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":65},"in_reply_to":"bacf61ea_aa6f0f91","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexistent_instance\")"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_2a631fb3","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":48},"updated":"2016-07-28 03:43:02.000000000","message":"non_existent","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_notexist_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexistent_instance\")"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_3e687df5","line":41,"range":{"start_line":41,"start_character":40,"end_line":41,"end_character":48},"in_reply_to":"bacf61ea_2a631fb3","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexistent_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instances_with_snapshot_by_member(self):"},{"line_number":48,"context_line":"        self.assertRaises("},{"line_number":49,"context_line":"            lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_0a6d7b98","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":65},"updated":"2016-07-28 03:43:02.000000000","message":"same","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"},{"line_number":44,"context_line":"                          instance_id\u003d\"nonexistent_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instances_with_snapshot_by_member(self):"},{"line_number":48,"context_line":"        self.assertRaises("},{"line_number":49,"context_line":"            lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_deb0418e","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":65},"in_reply_to":"bacf61ea_0a6d7b98","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                          instance_id\u003d\"nonexistent_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instances_with_snapshot_by_member(self):"},{"line_number":48,"context_line":"        self.assertRaises("},{"line_number":49,"context_line":"            lib_exc.Forbidden,"},{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_4a05b3c0","line":47,"range":{"start_line":47,"start_character":54,"end_line":47,"end_character":60},"updated":"2016-07-28 03:43:02.000000000","message":"non_admin?","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                          instance_id\u003d\"nonexistent_instance\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":47,"context_line":"    def test_list_snapshot_instances_with_snapshot_by_member(self):"},{"line_number":48,"context_line":"        self.assertRaises("},{"line_number":49,"context_line":"            lib_exc.Forbidden,"},{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_5e4a9184","line":47,"range":{"start_line":47,"start_character":54,"end_line":47,"end_character":60},"in_reply_to":"bacf61ea_4a05b3c0","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            lib_exc.Forbidden,"},{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027],"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":55,"context_line":"    def test_list_snapshot_instances_by_member(self):"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_2a0affd2","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":9},"updated":"2016-07-28 03:43:02.000000000","message":"needs to end on previous line.. no trailing comma necessary","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            lib_exc.Forbidden,"},{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027],"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":55,"context_line":"    def test_list_snapshot_instances_by_member(self):"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_de5e8144","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":9},"in_reply_to":"bacf61ea_2a0affd2","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027],"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":55,"context_line":"    def test_list_snapshot_instances_by_member(self):"},{"line_number":56,"context_line":"        self.assertRaises("},{"line_number":57,"context_line":"            lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_6a14f7f4","line":54,"range":{"start_line":54,"start_character":40,"end_line":54,"end_character":65},"updated":"2016-07-28 03:43:02.000000000","message":"same..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027],"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":55,"context_line":"    def test_list_snapshot_instances_by_member(self):"},{"line_number":56,"context_line":"        self.assertRaises("},{"line_number":57,"context_line":"            lib_exc.Forbidden,"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_9e3b69eb","line":54,"range":{"start_line":54,"start_character":40,"end_line":54,"end_character":65},"in_reply_to":"bacf61ea_6a14f7f4","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertRaises("},{"line_number":57,"context_line":"            lib_exc.Forbidden,"},{"line_number":58,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":62,"context_line":"    def test_get_snapshot_instances_by_member(self):"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_ea00e7ac","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":9},"updated":"2016-07-28 03:43:02.000000000","message":"both these tests can be combined with ddt..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.assertRaises("},{"line_number":57,"context_line":"            lib_exc.Forbidden,"},{"line_number":58,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":62,"context_line":"    def test_get_snapshot_instances_by_member(self):"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_7e403557","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":9},"in_reply_to":"bacf61ea_ea00e7ac","updated":"2016-07-28 08:43:59.000000000","message":"Both these tests in order to test for different API, it will be more clear if these tests separately. Thanks","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":62,"context_line":"    def test_get_snapshot_instances_by_member(self):"},{"line_number":63,"context_line":"        instances \u003d self.admin_client.list_snapshot_instances("},{"line_number":64,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_8a268b66","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":65},"updated":"2016-07-28 03:43:02.000000000","message":"doesn\u0027t need a backend. .","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":62,"context_line":"    def test_get_snapshot_instances_by_member(self):"},{"line_number":63,"context_line":"        instances \u003d self.admin_client.list_snapshot_instances("},{"line_number":64,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_de25e1c2","line":61,"range":{"start_line":61,"start_character":40,"end_line":61,"end_character":65},"in_reply_to":"bacf61ea_8a268b66","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":62,"context_line":"    def test_get_snapshot_instances_by_member(self):"},{"line_number":63,"context_line":"        instances \u003d self.admin_client.list_snapshot_instances("},{"line_number":64,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_4a2c934a","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":35},"updated":"2016-07-28 03:43:02.000000000","message":"instance..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":62,"context_line":"    def test_get_snapshot_instances_by_member(self):"},{"line_number":63,"context_line":"        instances \u003d self.admin_client.list_snapshot_instances("},{"line_number":64,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_1e301901","line":62,"range":{"start_line":62,"start_character":26,"end_line":62,"end_character":35},"in_reply_to":"bacf61ea_4a2c934a","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            instance_id\u003dinstances[0][\u0027id\u0027]"},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":72,"context_line":"    def test_reset_snapshot_instance_status_by_member(self):"},{"line_number":73,"context_line":"        instances \u003d self.admin_client.list_snapshot_instances("},{"line_number":74,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_8addeb44","line":71,"range":{"start_line":71,"start_character":40,"end_line":71,"end_character":65},"updated":"2016-07-28 03:43:02.000000000","message":"doesn\u0027t need a backend.. you need base.TAG_API for this and all the tests above.","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            instance_id\u003dinstances[0][\u0027id\u0027]"},{"line_number":69,"context_line":"        )"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":72,"context_line":"    def test_reset_snapshot_instance_status_by_member(self):"},{"line_number":73,"context_line":"        instances \u003d self.admin_client.list_snapshot_instances("},{"line_number":74,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_fe2c25ad","line":71,"range":{"start_line":71,"start_character":40,"end_line":71,"end_character":65},"in_reply_to":"bacf61ea_8addeb44","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b961da1d642931363522bb159e2d55a9f14c5dd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            lib_exc.Forbidden,"},{"line_number":77,"context_line":"            self.member_client.reset_snapshot_instance_status,"},{"line_number":78,"context_line":"            instances[0][\u0027id\u0027],"},{"line_number":79,"context_line":"            \u0027error\u0027,"},{"line_number":80,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_cae7e310","line":80,"range":{"start_line":79,"start_character":19,"end_line":80,"end_character":9},"updated":"2016-07-28 03:43:02.000000000","message":"no trailing comma, pull brace to previous line..","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"53c06ee27eaff954034196016222d5c0d57995da","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            lib_exc.Forbidden,"},{"line_number":77,"context_line":"            self.member_client.reset_snapshot_instance_status,"},{"line_number":78,"context_line":"            instances[0][\u0027id\u0027],"},{"line_number":79,"context_line":"            \u0027error\u0027,"},{"line_number":80,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":60,"id":"bacf61ea_de0cc144","line":80,"range":{"start_line":79,"start_character":19,"end_line":80,"end_character":9},"in_reply_to":"bacf61ea_cae7e310","updated":"2016-07-28 08:43:59.000000000","message":"Done","commit_id":"5a87bf81bb5a3da44b41fc48576e82d1fdbabfcc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2712b39c5154a86866d7ad053afececac250621e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":61,"id":"bacf61ea_ff625cd7","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":40},"updated":"2016-07-28 08:52:15.000000000","message":"Run of this test will trigger creation of resources. It means, to make this tag say true, you should move that and similar tests, that do not use created resources out of this class. All tests, that belong to classes that create resources, should have tag you had in PS60.","commit_id":"ff62bcd6b96bf669f9679b923b9c5a40044bf6da"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a7d416ae15fec5ca04d4eb6d0c299853da3b8bd4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":61,"id":"bacf61ea_3a9b62cb","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":40},"in_reply_to":"bacf61ea_9f48802f","updated":"2016-07-28 09:06:38.000000000","message":"+1. I\u0027m sorry about my previous comment.. Valeriy is right here... i ignored the setup method.. We could use fake snapshot ids for the negative tests below, but that won\u0027t be right. Please revert the tag base.TAG_API_WITH_BACKEND ..","commit_id":"ff62bcd6b96bf669f9679b923b9c5a40044bf6da"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8a765f82d4cbca2696dc738614583b0e322ce263","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":61,"id":"bacf61ea_9f48802f","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":40},"in_reply_to":"bacf61ea_ff625cd7","updated":"2016-07-28 08:54:43.000000000","message":"Addition: this will fail anyway because of lost second tag.","commit_id":"ff62bcd6b96bf669f9679b923b9c5a40044bf6da"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c66312d76b477d71447e1855c1d74b45d5d0eeaa","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_daee86eb","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":66},"updated":"2016-07-28 09:12:07.000000000","message":"Please, do not hurry uploading new wrong patch-sets.","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e43b6cfc1b63fb74f3cd15611a3dd8c34ab4b73","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_a5d60ec3","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":66},"in_reply_to":"bacf61ea_9aa08e92","updated":"2016-07-28 11:31:54.000000000","message":"This","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15b706ec5d9723fe6ed9153e730f5f6ce71e64cc","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_67fff301","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":66},"in_reply_to":"bacf61ea_a5d60ec3","updated":"2016-07-28 13:54:23.000000000","message":"Done","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a3e02553d34e076f125f75363aaa658342922564","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cls.snapshot \u003d cls.create_snapshot_wait_for_active("},{"line_number":38,"context_line":"            cls.share[\"id\"], client\u003dcls.admin_client)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":41,"context_line":"    def test_get_snapshot_instance_with_non_existent_instance(self):"},{"line_number":42,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":43,"context_line":"                          self.admin_client.get_snapshot_instance,"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_9aa08e92","line":40,"range":{"start_line":40,"start_character":40,"end_line":40,"end_character":66},"in_reply_to":"bacf61ea_daee86eb","updated":"2016-07-28 09:14:11.000000000","message":"Sorry, I will pay attention next time","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e43b6cfc1b63fb74f3cd15611a3dd8c34ab4b73","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":54,"context_line":"    def test_list_snapshot_instances_by_non_admin(self):"},{"line_number":55,"context_line":"        self.assertRaises("},{"line_number":56,"context_line":"            lib_exc.Forbidden,"},{"line_number":57,"context_line":"            self.member_client.list_snapshot_instances)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":60,"context_line":"    def test_get_snapshot_instance_by_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_a5a44e57","line":57,"range":{"start_line":53,"start_character":4,"end_line":57,"end_character":55},"updated":"2016-07-28 11:31:54.000000000","message":"And this tests should be in separate class without creation of resources and they should have following tags:\n\n\"\"\"\nbase.TAG_NEGATIVE, base.TAG_API\n\"\"\"\n\nAll other should stay in this class having existing tags:\n\"\"\"\nbase.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND\n\"\"\"","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15b706ec5d9723fe6ed9153e730f5f6ce71e64cc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":54,"context_line":"    def test_list_snapshot_instances_by_non_admin(self):"},{"line_number":55,"context_line":"        self.assertRaises("},{"line_number":56,"context_line":"            lib_exc.Forbidden,"},{"line_number":57,"context_line":"            self.member_client.list_snapshot_instances)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":60,"context_line":"    def test_get_snapshot_instance_by_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_075397e2","line":57,"range":{"start_line":53,"start_character":4,"end_line":57,"end_character":55},"in_reply_to":"bacf61ea_a5a44e57","updated":"2016-07-28 13:54:23.000000000","message":"Done","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"15b706ec5d9723fe6ed9153e730f5f6ce71e64cc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            self.member_client.list_snapshot_instances,"},{"line_number":51,"context_line":"            snapshot_id\u003dself.snapshot[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":54,"context_line":"    def test_list_snapshot_instances_by_non_admin(self):"},{"line_number":55,"context_line":"        self.assertRaises("},{"line_number":56,"context_line":"            lib_exc.Forbidden,"},{"line_number":57,"context_line":"            self.member_client.list_snapshot_instances)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.attr(type\u003d[base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND])"},{"line_number":60,"context_line":"    def test_get_snapshot_instance_by_non_admin(self):"}],"source_content_type":"text/x-python","patch_set":62,"id":"bacf61ea_870e6732","line":57,"range":{"start_line":53,"start_character":4,"end_line":57,"end_character":55},"in_reply_to":"bacf61ea_a5a44e57","updated":"2016-07-28 13:54:23.000000000","message":"Done","commit_id":"0ea631ef37ac711a9bdfcb85d0f7d0bf548f7d08"}],"releasenotes/notes/add-snapshot-instances-admin-api-959a1121aa407629.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"93f3ad2b9370c6e8ed5166bf3b48e048fd848573","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added APIs for snapshot instances."}],"source_content_type":"text/x-yaml","patch_set":51,"id":"1aa78d24_20d02b53","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":15},"updated":"2016-07-09 16:06:40.000000000","message":"nit:\n   Add list, show, and reset-status admin APIs for snapshot instances.","commit_id":"bf6309592ed500c49bd92ac8d9f66fce614bd32b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b6734275f3437a61c7e671b10a009cdffc9c1cc7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added APIs for snapshot instances."}],"source_content_type":"text/x-yaml","patch_set":51,"id":"1aa78d24_3ca67953","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":15},"in_reply_to":"1aa78d24_20d02b53","updated":"2016-07-11 10:08:55.000000000","message":"Done","commit_id":"bf6309592ed500c49bd92ac8d9f66fce614bd32b"}]}
