)]}'
{"manila/share/drivers/generic.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d43261462d44417c1638fac266a1a1b6309f6726","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                if not common_sv_available:"},{"line_number":193,"context_line":"                    time.sleep(5)"},{"line_number":194,"context_line":"                    LOG.warning(_LW(\"Waiting for service VM %s to \""},{"line_number":195,"context_line":"                                    \"become available. \""},{"line_number":196,"context_line":"                                    \"Driver is currently uninitialized.\"))"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_fb5e6744","line":194,"updated":"2015-10-19 10:32:20.000000000","message":"\"%s\" exist but substitution data is not provided.","commit_id":"0ef97ca8bbeec5cad915105e9f9731e936e9f18f"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c3937412846fd8ddb3fc4c8d65f0294d8983086a","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                if not common_sv_available:"},{"line_number":193,"context_line":"                    time.sleep(5)"},{"line_number":194,"context_line":"                    LOG.warning(_LW(\"Waiting for service VM %s to \""},{"line_number":195,"context_line":"                                    \"become available. \""},{"line_number":196,"context_line":"                                    \"Driver is currently uninitialized.\"))"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_fe965593","line":194,"in_reply_to":"3a29b11f_fb5e6744","updated":"2015-10-19 10:37:39.000000000","message":"My bad, I\u0027ve missed this out. Thanks!","commit_id":"0ef97ca8bbeec5cad915105e9f9731e936e9f18f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45e474f4e0e23a0c27fb07f00648f349c916a65f","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if not self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            common_sv_available \u003d False"},{"line_number":182,"context_line":"            while not common_sv_available:"},{"line_number":183,"context_line":"                try:"},{"line_number":184,"context_line":"                    # Verify availability of common server"},{"line_number":185,"context_line":"                    share_server \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_87ffd400","line":182,"updated":"2015-10-19 11:39:24.000000000","message":"Condition on line 180 and this \"while\" loop could be combined to reduce indentation.","commit_id":"8f8c008bdeef4ed6039fd41c23daddcbdc5e1533"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"54c40ee3752089f83909f626dc6b44f1f418a37c","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if not self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            common_sv_available \u003d False"},{"line_number":182,"context_line":"            while not common_sv_available:"},{"line_number":183,"context_line":"                try:"},{"line_number":184,"context_line":"                    # Verify availability of common server"},{"line_number":185,"context_line":"                    share_server \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_8737d4af","line":182,"in_reply_to":"3a29b11f_87ffd400","updated":"2015-10-19 12:14:58.000000000","message":"Done","commit_id":"8f8c008bdeef4ed6039fd41c23daddcbdc5e1533"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"45e474f4e0e23a0c27fb07f00648f349c916a65f","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                if not common_sv_available:"},{"line_number":193,"context_line":"                    time.sleep(5)"},{"line_number":194,"context_line":"                    LOG.warning(_LW(\"Waiting for the common service VM to \""},{"line_number":195,"context_line":"                                    \"become available. \""},{"line_number":196,"context_line":"                                    \"Driver is currently uninitialized.\"))"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_a72bf081","line":194,"updated":"2015-10-19 11:39:24.000000000","message":"Actually, I expected that you will add substitution data instead of removing substitution at all. Info about wait time will be useful. - wait step and wait timeout.","commit_id":"8f8c008bdeef4ed6039fd41c23daddcbdc5e1533"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"54c40ee3752089f83909f626dc6b44f1f418a37c","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                if not common_sv_available:"},{"line_number":193,"context_line":"                    time.sleep(5)"},{"line_number":194,"context_line":"                    LOG.warning(_LW(\"Waiting for the common service VM to \""},{"line_number":195,"context_line":"                                    \"become available. \""},{"line_number":196,"context_line":"                                    \"Driver is currently uninitialized.\"))"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_276b6020","line":194,"in_reply_to":"3a29b11f_a72bf081","updated":"2015-10-19 12:14:58.000000000","message":"Agreed. One thing though, there is no wait timeout being used here. Or do you mean the timeout used by the service_instance_manager method? In that case, I think it would be best to log the timeout in that specific method, but that should be in a separate patch.","commit_id":"8f8c008bdeef4ed6039fd41c23daddcbdc5e1533"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d43261462d44417c1638fac266a1a1b6309f6726","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.assertFalse(self._driver._is_share_server_active.called)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":257,"context_line":"    def test_do_setup_dhss_false_server_not_active(self, mock_sleep):"},{"line_number":258,"context_line":"        CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":259,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake_server_id\u0027}"},{"line_number":260,"context_line":"        self.mock_object(volume, \u0027API\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_1e3f91b5","line":257,"updated":"2015-10-19 10:32:20.000000000","message":"\"not active\" is different than \"not exist\". So, need to add new test. And in this verify that \"warning log\" was not executed.","commit_id":"0ef97ca8bbeec5cad915105e9f9731e936e9f18f"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c3937412846fd8ddb3fc4c8d65f0294d8983086a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            self.assertFalse(self._driver._is_share_server_active.called)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":257,"context_line":"    def test_do_setup_dhss_false_server_not_active(self, mock_sleep):"},{"line_number":258,"context_line":"        CONF.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":259,"context_line":"        fake_server \u003d {\u0027id\u0027: \u0027fake_server_id\u0027}"},{"line_number":260,"context_line":"        self.mock_object(volume, \u0027API\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_5e466924","line":257,"in_reply_to":"3a29b11f_1e3f91b5","updated":"2015-10-19 10:37:39.000000000","message":"This actually tests both cases: first time, retrieving the instance raises an exception, the second time it\u0027s retrieved but it\u0027s not active. I can split this into two tests or rename it/add an inline comment to give a better overview if needed.","commit_id":"0ef97ca8bbeec5cad915105e9f9731e936e9f18f"}]}