)]}'
{"manila/exception.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"class EMCVnxInvalidMoverID(ManilaException):"},{"line_number":599,"context_line":"    message \u003d _(\"Invalid mover or vdm id(s).\")"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"class HP3ParInvalidClient(Invalid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_ff48a189","line":599,"updated":"2015-11-08 03:10:50.000000000","message":"Can you change to %(id)s","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"class EMCVnxInvalidMoverID(ManilaException):"},{"line_number":599,"context_line":"    message \u003d _(\"Invalid mover or vdm id(s).\")"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"class HP3ParInvalidClient(Invalid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_dc1d9e10","line":599,"in_reply_to":"da85f559_ff48a189","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"}],"manila/share/drivers/emc/plugins/vnx/connection.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"17a5f9dd9c22f9ef2120d48197b1cbb6a97ba578","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":66,"context_line":"            vdm_name \u003d self._get_share_server_name(share_server)"},{"line_number":67,"context_line":"            server_name \u003d vdm_name"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            # Check if cifs server exists."},{"line_number":70,"context_line":"            status, server \u003d self._get_context(\u0027CIFSServer\u0027).get(server_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_29ef79b1","line":67,"updated":"2015-10-20 13:51:18.000000000","message":"The server_name is as same as vdm_name. Why not just use vdm_name? and remove the server_name?","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5c7116bcf12b51e4fdac785fcf73f3d2c9f47f14","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":66,"context_line":"            vdm_name \u003d self._get_share_server_name(share_server)"},{"line_number":67,"context_line":"            server_name \u003d vdm_name"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            # Check if cifs server exists."},{"line_number":70,"context_line":"            status, server \u003d self._get_context(\u0027CIFSServer\u0027).get(server_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8a068d84","line":67,"in_reply_to":"3a29b11f_29ef79b1","updated":"2015-10-21 10:17:19.000000000","message":"It will make the statement below look better:\nstatus, server \u003d self._get_context(\u0027CIFSServer\u0027).get(server_name, vdm_name)","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if share_server is None:"},{"line_number":200,"context_line":"            LOG.warn(_LW(\"Driver does not support share deletion without \""},{"line_number":201,"context_line":"                         \"share network specified. \""},{"line_number":202,"context_line":"                         \"Return directly because there is nothing to clean\"))"},{"line_number":203,"context_line":"            return"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_7774c69b","line":202,"updated":"2015-11-04 00:19:10.000000000","message":"Add a period?  Same elsewhere in this file.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if share_server is None:"},{"line_number":200,"context_line":"            LOG.warn(_LW(\"Driver does not support share deletion without \""},{"line_number":201,"context_line":"                         \"share network specified. \""},{"line_number":202,"context_line":"                         \"Return directly because there is nothing to clean\"))"},{"line_number":203,"context_line":"            return"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_357393b3","line":202,"in_reply_to":"fa80f949_7774c69b","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        share_name \u003d share[\u0027id\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":287,"context_line":"            reason \u003d _(\u0027Only user access type allowed for cifs share\u0027)"},{"line_number":288,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_175c5a4a","line":287,"updated":"2015-11-04 00:19:10.000000000","message":"s/cifs/CIFS/\n\nGrep for the same change elsewhere for consistency.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        share_name \u003d share[\u0027id\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":287,"context_line":"            reason \u003d _(\u0027Only user access type allowed for cifs share\u0027)"},{"line_number":288,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_68bb8373","line":287,"in_reply_to":"fa80f949_175c5a4a","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            devices \u003d self._get_physical_devices(self.mover_name)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"            for net_info in network_info[\u0027network_allocations\u0027]:"},{"line_number":465,"context_line":"                random.shuffle(devices)"},{"line_number":466,"context_line":"                interface \u003d {"},{"line_number":467,"context_line":"                    \u0027name\u0027: net_info[\u0027id\u0027][-12:],"},{"line_number":468,"context_line":"                    \u0027device_name\u0027: devices[0],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_f70c3644","line":465,"updated":"2015-11-04 00:19:10.000000000","message":"This will make your driver non-deterministic, but it seems like a valid load-balancing scheme.\n\nBut what happens if the same interface is shuffled to device[0] multiple times?  Is that OK?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            devices \u003d self._get_physical_devices(self.mover_name)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"            for net_info in network_info[\u0027network_allocations\u0027]:"},{"line_number":465,"context_line":"                random.shuffle(devices)"},{"line_number":466,"context_line":"                interface \u003d {"},{"line_number":467,"context_line":"                    \u0027name\u0027: net_info[\u0027id\u0027][-12:],"},{"line_number":468,"context_line":"                    \u0027device_name\u0027: devices[0],"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_e855331d","line":465,"in_reply_to":"fa80f949_f70c3644","updated":"2015-11-04 03:37:00.000000000","message":"It is okay. It is for the load-balance, for sure. :)","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            \u0027user_name\u0027: security_service[\u0027user\u0027],"},{"line_number":545,"context_line":"            \u0027password\u0027: security_service[\u0027password\u0027],"},{"line_number":546,"context_line":"            \u0027mover_name\u0027: vdm_name,"},{"line_number":547,"context_line":"            \u0027is_vdm\u0027: True"},{"line_number":548,"context_line":"        }"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        self._get_context(\u0027CIFSServer\u0027).create(cifs_server_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_82ffa600","line":547,"updated":"2015-11-04 00:19:10.000000000","message":"Add a comma?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":544,"context_line":"            \u0027user_name\u0027: security_service[\u0027user\u0027],"},{"line_number":545,"context_line":"            \u0027password\u0027: security_service[\u0027password\u0027],"},{"line_number":546,"context_line":"            \u0027mover_name\u0027: vdm_name,"},{"line_number":547,"context_line":"            \u0027is_vdm\u0027: True"},{"line_number":548,"context_line":"        }"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        self._get_context(\u0027CIFSServer\u0027).create(cifs_server_args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_082677ce","line":547,"in_reply_to":"fa80f949_82ffa600","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_71828002","line":1,"updated":"2015-11-04 13:10:43.000000000","message":"Any copyright should contain only one year - year of \"first\" appearance.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_59444273","line":1,"in_reply_to":"fa80f949_71828002","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if share_proto !\u003d \u0027NFS\u0027 and share_proto !\u003d \u0027CIFS\u0027:"},{"line_number":61,"context_line":"            raise exception.InvalidShare("},{"line_number":62,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027)"},{"line_number":63,"context_line":"                        % share_proto))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b1b6a8da","line":60,"updated":"2015-11-04 13:10:43.000000000","message":"if share_proto.upper() not in (\u0027NFS\u0027, \u0027CIFS\u0027):","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if share_proto !\u003d \u0027NFS\u0027 and share_proto !\u003d \u0027CIFS\u0027:"},{"line_number":61,"context_line":"            raise exception.InvalidShare("},{"line_number":62,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027)"},{"line_number":63,"context_line":"                        % share_proto))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_3c112c53","line":60,"in_reply_to":"fa80f949_b1b6a8da","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self._share_server_validation(share_server)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":68,"context_line":"            vdm_name \u003d self._get_share_server_name(share_server)"},{"line_number":69,"context_line":"            server_name \u003d vdm_name"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_f1c43041","line":67,"updated":"2015-11-04 13:10:43.000000000","message":"Why NFS server is not verified?","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self._share_server_validation(share_server)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":68,"context_line":"            vdm_name \u003d self._get_share_server_name(share_server)"},{"line_number":69,"context_line":"            server_name \u003d vdm_name"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_99794aff","line":67,"in_reply_to":"fa80f949_f1c43041","updated":"2015-11-04 16:14:56.000000000","message":"By default, VDM can be served as NFS server. So only CIFS server should be created on VDM.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if share_proto !\u003d \u0027NFS\u0027 and share_proto !\u003d \u0027CIFS\u0027:"},{"line_number":174,"context_line":"            raise exception.InvalidShare("},{"line_number":175,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027)"},{"line_number":176,"context_line":"                        % share_proto))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_51cf3c56","line":173,"updated":"2015-11-04 13:10:43.000000000","message":"if share_proto.upper() not in (\u0027NFS\u0027, \u0027CIFS\u0027):","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        if share_proto !\u003d \u0027NFS\u0027 and share_proto !\u003d \u0027CIFS\u0027:"},{"line_number":174,"context_line":"            raise exception.InvalidShare("},{"line_number":175,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027)"},{"line_number":176,"context_line":"                        % share_proto))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_bc2bdc81","line":173,"in_reply_to":"fa80f949_51cf3c56","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""},{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":265,"context_line":"        \"\"\"Allow access to a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_f1f2f099","line":262,"updated":"2015-11-04 13:10:43.000000000","message":"Since it is refactoring, \"pass\" can be removed as redundant.\n\nAlso, what about implementing this method?","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3bb594d7512076a6795c4a41d6ea9ed8b4788744","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""},{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":265,"context_line":"        \"\"\"Allow access to a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_9e14c544","line":262,"in_reply_to":"fa80f949_39005e34","updated":"2015-11-04 17:12:45.000000000","message":"I mean there is no need to use \"pass\" here because you have docstring. So, you will not need to delete later when you implement that method.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ded4ff3c32e7aba18b8e79da83a168d1c35a49cb","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""},{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":265,"context_line":"        \"\"\"Allow access to a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_5214fe42","line":262,"in_reply_to":"fa80f949_9e14c544","updated":"2015-11-05 04:06:58.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":261,"context_line":"        \"\"\"Ensure that the share is exported.\"\"\""},{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":265,"context_line":"        \"\"\"Allow access to a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_39005e34","line":262,"in_reply_to":"fa80f949_f1f2f099","updated":"2015-11-04 16:14:56.000000000","message":"It will plan to implement in the coming submit. If so, do you mean that I should remove this function and implement in future?","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    def _get_valid_security_service(self, security_services):"},{"line_number":619,"context_line":"        \"\"\"Validate security services and return a supported security service."},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"            :param security_services:"},{"line_number":622,"context_line":"            :return: (\u003cis_valid\u003e, \u003cdata\u003e)"},{"line_number":623,"context_line":"                \u003cis_valid\u003e is true to indicate security_services includes zero"},{"line_number":624,"context_line":"                or single security service for active directory. Otherwise, it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_f14990d1","line":621,"updated":"2015-11-04 13:10:43.000000000","message":"http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ded4ff3c32e7aba18b8e79da83a168d1c35a49cb","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    def _get_valid_security_service(self, security_services):"},{"line_number":619,"context_line":"        \"\"\"Validate security services and return a supported security service."},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"            :param security_services:"},{"line_number":622,"context_line":"            :return: (\u003cis_valid\u003e, \u003cdata\u003e)"},{"line_number":623,"context_line":"                \u003cis_valid\u003e is true to indicate security_services includes zero"},{"line_number":624,"context_line":"                or single security service for active directory. Otherwise, it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_32193a7a","line":621,"in_reply_to":"fa80f949_1e4e956f","updated":"2015-11-05 04:06:58.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3bb594d7512076a6795c4a41d6ea9ed8b4788744","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    def _get_valid_security_service(self, security_services):"},{"line_number":619,"context_line":"        \"\"\"Validate security services and return a supported security service."},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"            :param security_services:"},{"line_number":622,"context_line":"            :return: (\u003cis_valid\u003e, \u003cdata\u003e)"},{"line_number":623,"context_line":"                \u003cis_valid\u003e is true to indicate security_services includes zero"},{"line_number":624,"context_line":"                or single security service for active directory. Otherwise, it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_1e4e956f","line":621,"in_reply_to":"fa80f949_dc5580c6","updated":"2015-11-04 17:12:45.000000000","message":"nit, but it is \"returnS\" in guidelines.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    def _get_valid_security_service(self, security_services):"},{"line_number":619,"context_line":"        \"\"\"Validate security services and return a supported security service."},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"            :param security_services:"},{"line_number":622,"context_line":"            :return: (\u003cis_valid\u003e, \u003cdata\u003e)"},{"line_number":623,"context_line":"                \u003cis_valid\u003e is true to indicate security_services includes zero"},{"line_number":624,"context_line":"                or single security service for active directory. Otherwise, it"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_dc5580c6","line":621,"in_reply_to":"fa80f949_f14990d1","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":287,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":288,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_5f2f6da1","line":288,"updated":"2015-11-08 03:10:50.000000000","message":"exception.InvalidShareAccess(reason\u003dreason)","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":287,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":288,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_7c1a7219","line":288,"in_reply_to":"da85f559_5f2f6da1","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":349,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":350,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_7f2cb1ab","line":350,"updated":"2015-11-08 03:10:50.000000000","message":"exception.InvalidShareAccess(reason\u003dreason)","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027user\u0027:"},{"line_number":349,"context_line":"            reason \u003d _(\u0027Only user access type allowed for CIFS share\u0027)"},{"line_number":350,"context_line":"            raise exception.InvalidShareAccess(reason)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        user_name \u003d access[\u0027access_to\u0027]"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_9c1716ed","line":350,"in_reply_to":"da85f559_7f2cb1ab","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"}],"manila/share/drivers/emc/plugins/vnx/connector.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import pipes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_concurrency import processutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_22c27a86","line":15,"updated":"2015-11-04 00:19:10.000000000","message":"Add a blank line before the first import, and remove the extra blank line after it.\n\nYour other files would also benefit from a blank line after the license text.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import pipes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_concurrency import processutils"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_834d6874","line":15,"in_reply_to":"fa80f949_22c27a86","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(XMLAPIConnector, self).__init__()"},{"line_number":38,"context_line":"        self.storage_ip \u003d configuration.emc_nas_server"},{"line_number":39,"context_line":"        self.user_name \u003d configuration.emc_nas_login"},{"line_number":40,"context_line":"        self.pass_word \u003d configuration.emc_nas_password"},{"line_number":41,"context_line":"        self.debug \u003d debug"},{"line_number":42,"context_line":"        self.auth_url \u003d \u0027https://\u0027 + self.storage_ip + \u0027/Login\u0027"},{"line_number":43,"context_line":"        self._url \u003d (\u0027https://\u0027 + self.storage_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_427c5e72","line":40,"updated":"2015-11-04 00:19:10.000000000","message":"s/pass_word/password/\n\n(It\u0027s a single compound word.)\n\nAnd optionally, most folks use \u0027username\u0027 as well in this context.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(XMLAPIConnector, self).__init__()"},{"line_number":38,"context_line":"        self.storage_ip \u003d configuration.emc_nas_server"},{"line_number":39,"context_line":"        self.user_name \u003d configuration.emc_nas_login"},{"line_number":40,"context_line":"        self.pass_word \u003d configuration.emc_nas_password"},{"line_number":41,"context_line":"        self.debug \u003d debug"},{"line_number":42,"context_line":"        self.auth_url \u003d \u0027https://\u0027 + self.storage_ip + \u0027/Login\u0027"},{"line_number":43,"context_line":"        self._url \u003d (\u0027https://\u0027 + self.storage_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_839b28c9","line":40,"in_reply_to":"fa80f949_427c5e72","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        super(SSHConnector, self).__init__()"},{"line_number":134,"context_line":"        self.storage_ip \u003d configuration.emc_nas_server"},{"line_number":135,"context_line":"        self.user_name \u003d configuration.emc_nas_login"},{"line_number":136,"context_line":"        self.pass_word \u003d configuration.emc_nas_password"},{"line_number":137,"context_line":"        self.debug \u003d debug"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.sshpool \u003d utils.SSHPool(ip\u003dself.storage_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_22db5a7e","line":136,"updated":"2015-11-04 00:19:10.000000000","message":"password","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        super(SSHConnector, self).__init__()"},{"line_number":134,"context_line":"        self.storage_ip \u003d configuration.emc_nas_server"},{"line_number":135,"context_line":"        self.user_name \u003d configuration.emc_nas_login"},{"line_number":136,"context_line":"        self.pass_word \u003d configuration.emc_nas_password"},{"line_number":137,"context_line":"        self.debug \u003d debug"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.sshpool \u003d utils.SSHPool(ip\u003dself.storage_ip,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_03b09842","line":136,"in_reply_to":"fa80f949_22db5a7e","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_710cc094","line":1,"updated":"2015-11-04 13:10:43.000000000","message":"Any copyright should contain only one year - year of \"first\" appearance.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_7c5d74e8","line":1,"in_reply_to":"fa80f949_710cc094","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"}],"manila/share/drivers/emc/plugins/vnx/constants.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_117534f8","line":1,"updated":"2015-11-04 13:10:43.000000000","message":"Any copyright should contain only one year - year of \"first\" appearance.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_5c0f50e1","line":1,"in_reply_to":"fa80f949_117534f8","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"}],"manila/share/drivers/emc/plugins/vnx/object_manager.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"17a5f9dd9c22f9ef2120d48197b1cbb6a97ba578","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _send_request(self, req):"},{"line_number":149,"context_line":"        req_xml \u003d constants.XML_HEADER + ET.tostring(req)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        rsp_xml \u003d self.conn[\u0027XML\u0027].request(req_xml)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_269006ec","line":149,"updated":"2015-10-20 13:51:18.000000000","message":"Can\u0027t convert \u0027bytes\u0027 object to str implicitly","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5c7116bcf12b51e4fdac785fcf73f3d2c9f47f14","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _send_request(self, req):"},{"line_number":149,"context_line":"        req_xml \u003d constants.XML_HEADER + ET.tostring(req)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        rsp_xml \u003d self.conn[\u0027XML\u0027].request(req_xml)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_6a12110b","line":149,"in_reply_to":"3a29b11f_269006ec","updated":"2015-10-21 10:17:19.000000000","message":"Done","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f9c4765397c35fcba3743e65d7420cbdbd31f503","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _send_request(self, req):"},{"line_number":149,"context_line":"        req_xml \u003d constants.XML_HEADER + ET.tostring(req)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        rsp_xml \u003d self.conn[\u0027XML\u0027].request(req_xml)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_271d4e0f","line":149,"in_reply_to":"3a29b11f_269006ec","updated":"2015-10-20 18:31:13.000000000","message":"I think you need to do decode here.","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5c7116bcf12b51e4fdac785fcf73f3d2c9f47f14","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        )"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _send_request(self, req):"},{"line_number":149,"context_line":"        req_xml \u003d constants.XML_HEADER + ET.tostring(req)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        rsp_xml \u003d self.conn[\u0027XML\u0027].request(req_xml)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_4a0dd5e6","line":149,"in_reply_to":"3a29b11f_271d4e0f","updated":"2015-10-21 10:17:19.000000000","message":"Done","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"17a5f9dd9c22f9ef2120d48197b1cbb6a97ba578","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Execute NAS command via SSH."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param retry_patterns: list of tuples,where each tuple contains"},{"line_number":164,"context_line":"                               a reg expression and a exception."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        if retry_patterns is None:"},{"line_number":167,"context_line":"            retry_patterns \u003d self.ssh_retry_patterns"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_b5d516ba","line":164,"updated":"2015-10-20 13:51:18.000000000","message":"It is better to add the \u0027check_exit_code\u0027 description.","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5c7116bcf12b51e4fdac785fcf73f3d2c9f47f14","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Execute NAS command via SSH."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        :param retry_patterns: list of tuples,where each tuple contains"},{"line_number":164,"context_line":"                               a reg expression and a exception."},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        if retry_patterns is None:"},{"line_number":167,"context_line":"            retry_patterns \u003d self.ssh_retry_patterns"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_ea6701b5","line":164,"in_reply_to":"3a29b11f_b5d516ba","updated":"2015-10-21 10:17:19.000000000","message":"Done","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"17a5f9dd9c22f9ef2120d48197b1cbb6a97ba578","unresolved":false,"context_lines":[{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"@vnx_utils.decorate_all_methods(vnx_utils.log_enter_exit,"},{"line_number":1028,"context_line":"                                debug_only\u003dTrue)"},{"line_number":1029,"context_line":"class SnapShot(StorageObject):"},{"line_number":1030,"context_line":"    def __init__(self, conn, elt_maker, xml_parser, manager):"},{"line_number":1031,"context_line":"        super(SnapShot, self).__init__(conn, elt_maker, xml_parser, manager)"},{"line_number":1032,"context_line":"        self.snap_map \u003d dict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_87af9193","line":1029,"updated":"2015-10-20 13:51:18.000000000","message":"\u0027Snap Shot\u0027 is not the same as \u0027Snapshot\u0027, Maybe the \u0027Snapshot\u0027 is better.","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5c7116bcf12b51e4fdac785fcf73f3d2c9f47f14","unresolved":false,"context_lines":[{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"@vnx_utils.decorate_all_methods(vnx_utils.log_enter_exit,"},{"line_number":1028,"context_line":"                                debug_only\u003dTrue)"},{"line_number":1029,"context_line":"class SnapShot(StorageObject):"},{"line_number":1030,"context_line":"    def __init__(self, conn, elt_maker, xml_parser, manager):"},{"line_number":1031,"context_line":"        super(SnapShot, self).__init__(conn, elt_maker, xml_parser, manager)"},{"line_number":1032,"context_line":"        self.snap_map \u003d dict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8a60cda6","line":1029,"in_reply_to":"3a29b11f_87af9193","updated":"2015-10-21 10:17:19.000000000","message":"Done","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"17a5f9dd9c22f9ef2120d48197b1cbb6a97ba578","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"                                debug_only\u003dTrue)"},{"line_number":1029,"context_line":"class SnapShot(StorageObject):"},{"line_number":1030,"context_line":"    def __init__(self, conn, elt_maker, xml_parser, manager):"},{"line_number":1031,"context_line":"        super(SnapShot, self).__init__(conn, elt_maker, xml_parser, manager)"},{"line_number":1032,"context_line":"        self.snap_map \u003d dict()"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"    def create(self, name, fs_name, pool_name, ckpt_size\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_67835505","line":1031,"updated":"2015-10-20 13:51:18.000000000","message":"same","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5c7116bcf12b51e4fdac785fcf73f3d2c9f47f14","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"                                debug_only\u003dTrue)"},{"line_number":1029,"context_line":"class SnapShot(StorageObject):"},{"line_number":1030,"context_line":"    def __init__(self, conn, elt_maker, xml_parser, manager):"},{"line_number":1031,"context_line":"        super(SnapShot, self).__init__(conn, elt_maker, xml_parser, manager)"},{"line_number":1032,"context_line":"        self.snap_map \u003d dict()"},{"line_number":1033,"context_line":""},{"line_number":1034,"context_line":"    def create(self, name, fs_name, pool_name, ckpt_size\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_4a5635cf","line":1031,"in_reply_to":"3a29b11f_67835505","updated":"2015-10-21 10:17:19.000000000","message":"Done","commit_id":"34cfab758e7bcd296adaf7ad7df8496893f74683"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@vnx_utils.decorate_all_methods(vnx_utils.log_enter_exit,"},{"line_number":39,"context_line":"                                debug_only\u003dTrue)"},{"line_number":40,"context_line":"class StorageObjectManager(object):"},{"line_number":41,"context_line":"    def __init__(self, configuration):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_54818049","line":38,"updated":"2015-11-04 00:19:10.000000000","message":"Just FYI, Cinder has a standard mechanism for logging driver methods and API calls, and we\u0027re planning to port that to Manila.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@vnx_utils.decorate_all_methods(vnx_utils.log_enter_exit,"},{"line_number":39,"context_line":"                                debug_only\u003dTrue)"},{"line_number":40,"context_line":"class StorageObjectManager(object):"},{"line_number":41,"context_line":"    def __init__(self, configuration):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_a3ee6c20","line":38,"in_reply_to":"fa80f949_54818049","updated":"2015-11-04 03:37:00.000000000","message":"Thanks. We can update the logging mechanism once the porting is done.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def delete(self, name):"},{"line_number":298,"context_line":"        status, out \u003d self.get(name)"},{"line_number":299,"context_line":"        if constants.STATUS_NOT_FOUND \u003d\u003d status:"},{"line_number":300,"context_line":"            LOG.warn(_LW(\"File system %s not found. Skip the deletion\"),"},{"line_number":301,"context_line":"                     name)"},{"line_number":302,"context_line":"            return"},{"line_number":303,"context_line":"        elif constants.STATUS_OK !\u003d status:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_d103420e","line":300,"updated":"2015-11-04 00:19:10.000000000","message":"Add a period?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def delete(self, name):"},{"line_number":298,"context_line":"        status, out \u003d self.get(name)"},{"line_number":299,"context_line":"        if constants.STATUS_NOT_FOUND \u003d\u003d status:"},{"line_number":300,"context_line":"            LOG.warn(_LW(\"File system %s not found. Skip the deletion\"),"},{"line_number":301,"context_line":"                     name)"},{"line_number":302,"context_line":"            return"},{"line_number":303,"context_line":"        elif constants.STATUS_OK !\u003d status:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_559bb7c9","line":300,"in_reply_to":"fa80f949_d103420e","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        id \u003d out[\u0027id\u0027]"},{"line_number":337,"context_line":"        size \u003d int(out[\u0027size\u0027])"},{"line_number":338,"context_line":"        if new_size \u003c size:"},{"line_number":339,"context_line":"            message \u003d (_(\"Failed to extent file system %(name)s because new \""},{"line_number":340,"context_line":"                         \"size %(new_size)d is smaller than old size \""},{"line_number":341,"context_line":"                         \"%(size)d.\") %"},{"line_number":342,"context_line":"                       {\u0027name\u0027: name, \u0027new_size\u0027: new_size, \u0027size\u0027: size})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_b12f9ea0","line":339,"updated":"2015-11-04 00:19:10.000000000","message":"s/extent/extend/","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        id \u003d out[\u0027id\u0027]"},{"line_number":337,"context_line":"        size \u003d int(out[\u0027size\u0027])"},{"line_number":338,"context_line":"        if new_size \u003c size:"},{"line_number":339,"context_line":"            message \u003d (_(\"Failed to extent file system %(name)s because new \""},{"line_number":340,"context_line":"                         \"size %(new_size)d is smaller than old size \""},{"line_number":341,"context_line":"                         \"%(size)d.\") %"},{"line_number":342,"context_line":"                       {\u0027name\u0027: name, \u0027new_size\u0027: new_size, \u0027size\u0027: size})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_e3e4743c","line":339,"in_reply_to":"fa80f949_b12f9ea0","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        response \u003d self._send_request(request)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":363,"context_line":"            message \u003d (_(\"Fail to extent file system %(name)s to new size \""},{"line_number":364,"context_line":"                         \"%(new_size)d. Reason: %(err)s.\") %"},{"line_number":365,"context_line":"                       {\u0027name\u0027: name,"},{"line_number":366,"context_line":"                        \u0027new_size\u0027: new_size,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_3112ce63","line":363,"updated":"2015-11-04 00:19:10.000000000","message":"s/Fail to extent/Failed to extend/","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        response \u003d self._send_request(request)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":363,"context_line":"            message \u003d (_(\"Fail to extent file system %(name)s to new size \""},{"line_number":364,"context_line":"                         \"%(new_size)d. Reason: %(err)s.\") %"},{"line_number":365,"context_line":"                       {\u0027name\u0027: name,"},{"line_number":366,"context_line":"                        \u0027new_size\u0027: new_size,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_03c5f88c","line":363,"in_reply_to":"fa80f949_3112ce63","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                        \u0027err\u0027: six.text_type(expt)})"},{"line_number":439,"context_line":"            LOG.error(message)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        # When there is an error happen during nas_copy, we need"},{"line_number":442,"context_line":"        # continue to delete the checkpoint of the target file system"},{"line_number":443,"context_line":"        # if it exists."},{"line_number":444,"context_line":"        query_fs_cmd \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_d431f0ed","line":441,"updated":"2015-11-04 00:19:10.000000000","message":"# When an error happens during nas_copy, we need to continue...","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                        \u0027err\u0027: six.text_type(expt)})"},{"line_number":439,"context_line":"            LOG.error(message)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        # When there is an error happen during nas_copy, we need"},{"line_number":442,"context_line":"        # continue to delete the checkpoint of the target file system"},{"line_number":443,"context_line":"        # if it exists."},{"line_number":444,"context_line":"        query_fs_cmd \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_23491c32","line":441,"in_reply_to":"fa80f949_d431f0ed","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            mover_id \u003d self.get_context(\u0027Mover\u0027).get_id(mover_name,"},{"line_number":552,"context_line":"                                                        self.xml_retry)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        if self.xml_retry:"},{"line_number":555,"context_line":"            self.xml_retry \u003d False"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        request \u003d self._build_task_package("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_74884423","line":554,"updated":"2015-11-04 00:19:10.000000000","message":"You are manipulating an instance field here, which introduces a side effect.  Will that not lead to concurrency issues with this class?  This pattern is repeated elsewhere as well.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            mover_id \u003d self.get_context(\u0027Mover\u0027).get_id(mover_name,"},{"line_number":552,"context_line":"                                                        self.xml_retry)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        if self.xml_retry:"},{"line_number":555,"context_line":"            self.xml_retry \u003d False"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        request \u003d self._build_task_package("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_a38d0c33","line":554,"in_reply_to":"fa80f949_74884423","updated":"2015-11-04 03:37:00.000000000","message":"There is no concurrency issue. The purpose of retry is to poll mover id from storage array and update the mover id in cache instead of using the mover id in cache. The same idea in somewhere else.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    @utils.retry(exception.EMCVnxInvalidMoverID)"},{"line_number":589,"context_line":"    def get(self, mover_name, is_vdm\u003dTrue):"},{"line_number":590,"context_line":"        if is_vdm:"},{"line_number":591,"context_line":"            mover_id \u003d self.get_context(\u0027VDM\u0027).get_id(mover_name)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            mover_id \u003d self.get_context(\u0027Mover\u0027).get_id(mover_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_74ba84e3","line":590,"updated":"2015-11-04 00:19:10.000000000","message":"You seem to repeat this if/else block a number of times.  Why not move it to a private method?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    @utils.retry(exception.EMCVnxInvalidMoverID)"},{"line_number":589,"context_line":"    def get(self, mover_name, is_vdm\u003dTrue):"},{"line_number":590,"context_line":"        if is_vdm:"},{"line_number":591,"context_line":"            mover_id \u003d self.get_context(\u0027VDM\u0027).get_id(mover_name)"},{"line_number":592,"context_line":"        else:"},{"line_number":593,"context_line":"            mover_id \u003d self.get_context(\u0027Mover\u0027).get_id(mover_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_638884e8","line":590,"in_reply_to":"fa80f949_74ba84e3","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":924,"context_line":"    def delete(self, name):"},{"line_number":925,"context_line":"        status, out \u003d self.get(name)"},{"line_number":926,"context_line":"        if constants.STATUS_NOT_FOUND \u003d\u003d status:"},{"line_number":927,"context_line":"            LOG.warn(_LW(\"VDM %s not found. Skip the deletion\"),"},{"line_number":928,"context_line":"                     name)"},{"line_number":929,"context_line":"            return"},{"line_number":930,"context_line":"        elif constants.STATUS_OK !\u003d status:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_d41d70be","line":927,"updated":"2015-11-04 00:19:10.000000000","message":"Add a period?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":924,"context_line":"    def delete(self, name):"},{"line_number":925,"context_line":"        status, out \u003d self.get(name)"},{"line_number":926,"context_line":"        if constants.STATUS_NOT_FOUND \u003d\u003d status:"},{"line_number":927,"context_line":"            LOG.warn(_LW(\"VDM %s not found. Skip the deletion\"),"},{"line_number":928,"context_line":"                     name)"},{"line_number":929,"context_line":"            return"},{"line_number":930,"context_line":"        elif constants.STATUS_OK !\u003d status:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_f5ac2bef","line":927,"in_reply_to":"fa80f949_d41d70be","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"    def delete(self, name):"},{"line_number":1107,"context_line":"        status, out \u003d self.get(name)"},{"line_number":1108,"context_line":"        if constants.STATUS_NOT_FOUND \u003d\u003d status:"},{"line_number":1109,"context_line":"            LOG.warn(_LW(\"Snapshot %s not found. Skip the deletion\"),"},{"line_number":1110,"context_line":"                     name)"},{"line_number":1111,"context_line":"            return"},{"line_number":1112,"context_line":"        elif constants.STATUS_OK !\u003d status:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_345abc84","line":1109,"updated":"2015-11-04 00:19:10.000000000","message":"Add a period?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"    def delete(self, name):"},{"line_number":1107,"context_line":"        status, out \u003d self.get(name)"},{"line_number":1108,"context_line":"        if constants.STATUS_NOT_FOUND \u003d\u003d status:"},{"line_number":1109,"context_line":"            LOG.warn(_LW(\"Snapshot %s not found. Skip the deletion\"),"},{"line_number":1110,"context_line":"                     name)"},{"line_number":1111,"context_line":"            return"},{"line_number":1112,"context_line":"        elif constants.STATUS_OK !\u003d status:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_95b91f31","line":1109,"in_reply_to":"fa80f949_345abc84","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"    @utils.retry(exception.EMCVnxInvalidMoverID)"},{"line_number":1156,"context_line":"    def create(self, interface):"},{"line_number":1157,"context_line":"        # maximum of 32 characters for mover interface name"},{"line_number":1158,"context_line":"        name \u003d interface[\u0027name\u0027]"},{"line_number":1159,"context_line":"        if len(name) \u003e 32:"},{"line_number":1160,"context_line":"            name \u003d name[0:31]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_94ccc836","line":1157,"updated":"2015-11-04 00:19:10.000000000","message":"s/maximum/Maximum/\n\nSame below.","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"    @utils.retry(exception.EMCVnxInvalidMoverID)"},{"line_number":1156,"context_line":"    def create(self, interface):"},{"line_number":1157,"context_line":"        # maximum of 32 characters for mover interface name"},{"line_number":1158,"context_line":"        name \u003d interface[\u0027name\u0027]"},{"line_number":1159,"context_line":"        if len(name) \u003e 32:"},{"line_number":1160,"context_line":"            name \u003d name[0:31]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_e37474fe","line":1157,"in_reply_to":"fa80f949_94ccc836","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"        elif self._response_validation("},{"line_number":1193,"context_line":"                response, constants.MSG_INTERFACE_NAME_EXIST):"},{"line_number":1194,"context_line":"            LOG.warn(_LW(\"Mover interface name %s already exists. \""},{"line_number":1195,"context_line":"                         \"Skip the creation\"), name)"},{"line_number":1196,"context_line":"            return"},{"line_number":1197,"context_line":"        elif self._response_validation("},{"line_number":1198,"context_line":"                response, constants.MSG_INTERFACE_EXIST):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_74ee048d","line":1195,"updated":"2015-11-04 00:19:10.000000000","message":"Add a period?\n\n(Same elsewhere below.)","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"        elif self._response_validation("},{"line_number":1193,"context_line":"                response, constants.MSG_INTERFACE_NAME_EXIST):"},{"line_number":1194,"context_line":"            LOG.warn(_LW(\"Mover interface name %s already exists. \""},{"line_number":1195,"context_line":"                         \"Skip the creation\"), name)"},{"line_number":1196,"context_line":"            return"},{"line_number":1197,"context_line":"        elif self._response_validation("},{"line_number":1198,"context_line":"                response, constants.MSG_INTERFACE_EXIST):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_5582d753","line":1195,"in_reply_to":"fa80f949_74ee048d","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"        elif self._response_validation("},{"line_number":1198,"context_line":"                response, constants.MSG_INTERFACE_EXIST):"},{"line_number":1199,"context_line":"            LOG.warn(_LW(\"Mover interface IP %s already exists. \""},{"line_number":1200,"context_line":"                         \"Skip the creation\"), ip_addr)"},{"line_number":1201,"context_line":"            return"},{"line_number":1202,"context_line":"        elif constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":1203,"context_line":"            message \u003d (_(\"Failed to create mover interface %(interface)s. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_94f36873","line":1200,"updated":"2015-11-04 00:19:10.000000000","message":"same","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"        elif self._response_validation("},{"line_number":1198,"context_line":"                response, constants.MSG_INTERFACE_EXIST):"},{"line_number":1199,"context_line":"            LOG.warn(_LW(\"Mover interface IP %s already exists. \""},{"line_number":1200,"context_line":"                         \"Skip the creation\"), ip_addr)"},{"line_number":1201,"context_line":"            return"},{"line_number":1202,"context_line":"        elif constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":1203,"context_line":"            message \u003d (_(\"Failed to create mover interface %(interface)s. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_157c4f71","line":1200,"in_reply_to":"fa80f949_94f36873","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1705,"context_line":"        try:"},{"line_number":1706,"context_line":"            self._execute_cmd(allow_access, check_exit_code\u003dTrue)"},{"line_number":1707,"context_line":"        except processutils.ProcessExecutionError as expt:"},{"line_number":1708,"context_line":"            dup_msg \u003d re.compile(r\u0027ACE for %(domain)s\\\\%(user)s unchanged\u0027 %"},{"line_number":1709,"context_line":"                                 {\u0027domain\u0027: domain, \u0027user\u0027: user_name}, re.I)"},{"line_number":1710,"context_line":"            if re.search(dup_msg, expt.stdout):"},{"line_number":1711,"context_line":"                LOG.warn(_LW(\"Duplicate ACEs, skipping allow...\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_946848f7","line":1708,"updated":"2015-11-04 00:19:10.000000000","message":"Will everyone reading your logs know what \u0027ACE\u0027 means?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1705,"context_line":"        try:"},{"line_number":1706,"context_line":"            self._execute_cmd(allow_access, check_exit_code\u003dTrue)"},{"line_number":1707,"context_line":"        except processutils.ProcessExecutionError as expt:"},{"line_number":1708,"context_line":"            dup_msg \u003d re.compile(r\u0027ACE for %(domain)s\\\\%(user)s unchanged\u0027 %"},{"line_number":1709,"context_line":"                                 {\u0027domain\u0027: domain, \u0027user\u0027: user_name}, re.I)"},{"line_number":1710,"context_line":"            if re.search(dup_msg, expt.stdout):"},{"line_number":1711,"context_line":"                LOG.warn(_LW(\"Duplicate ACEs, skipping allow...\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_63d644c7","line":1708,"in_reply_to":"fa80f949_946848f7","updated":"2015-11-04 03:37:00.000000000","message":"will update the log using the full name of ACE (access control entry)","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"    def deny_share_access(self, mover_name, share_name, user_name, domain,"},{"line_number":1720,"context_line":"                          access\u003dconstants.CIFS_ACL_FULLCONTROL):"},{"line_number":1721,"context_line":"        account \u003d user_name + \"@\" + domain"},{"line_number":1722,"context_line":"        allow_str \u003d (\u0027sharesd %(share_name)s revoke %(account)s\u003d%(access)s\u0027"},{"line_number":1723,"context_line":"                     % {\u0027share_name\u0027: share_name,"},{"line_number":1724,"context_line":"                        \u0027account\u0027: account,"},{"line_number":1725,"context_line":"                        \u0027access\u0027: access})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_d47ed0ad","line":1722,"updated":"2015-11-04 00:19:10.000000000","message":"Isn\u0027t this \u0027deny_str\u0027 or \u0027revoke_str\u0027?","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"    def deny_share_access(self, mover_name, share_name, user_name, domain,"},{"line_number":1720,"context_line":"                          access\u003dconstants.CIFS_ACL_FULLCONTROL):"},{"line_number":1721,"context_line":"        account \u003d user_name + \"@\" + domain"},{"line_number":1722,"context_line":"        allow_str \u003d (\u0027sharesd %(share_name)s revoke %(account)s\u003d%(access)s\u0027"},{"line_number":1723,"context_line":"                     % {\u0027share_name\u0027: share_name,"},{"line_number":1724,"context_line":"                        \u0027account\u0027: account,"},{"line_number":1725,"context_line":"                        \u0027access\u0027: access})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_03dc18e3","line":1722,"in_reply_to":"fa80f949_d47ed0ad","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"9267b3b593e0f31f4e9dea302b0a08fee666bf6a","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"                        \u0027account\u0027: account,"},{"line_number":1725,"context_line":"                        \u0027access\u0027: access})"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        allow_access \u003d ["},{"line_number":1728,"context_line":"            \u0027env\u0027, \u0027NAS_DB\u003d/nas\u0027, \u0027/nas/bin/.server_config\u0027, mover_name,"},{"line_number":1729,"context_line":"            \u0027-v\u0027, \"%s\" % allow_str,"},{"line_number":1730,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_744a8485","line":1727,"updated":"2015-11-04 00:19:10.000000000","message":"same","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"bc97a49d2f4720a86511ff9dd6cf088475b0a0a4","unresolved":false,"context_lines":[{"line_number":1724,"context_line":"                        \u0027account\u0027: account,"},{"line_number":1725,"context_line":"                        \u0027access\u0027: access})"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        allow_access \u003d ["},{"line_number":1728,"context_line":"            \u0027env\u0027, \u0027NAS_DB\u003d/nas\u0027, \u0027/nas/bin/.server_config\u0027, mover_name,"},{"line_number":1729,"context_line":"            \u0027-v\u0027, \"%s\" % allow_str,"},{"line_number":1730,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_c3e5b0a8","line":1727,"in_reply_to":"fa80f949_744a8485","updated":"2015-11-04 03:37:00.000000000","message":"Done","commit_id":"6eaaf5bcef2b89bb9706c5a4fd36cd91df4cd37f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_91404458","line":1,"updated":"2015-11-04 13:10:43.000000000","message":"Any copyright should contain only one year - year of \"first\" appearance.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_8dcb3d53","line":1,"in_reply_to":"fa80f949_91404458","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def _execute_cmd(self, cmd, retry_patterns\u003dNone, check_exit_code\u003dFalse):"},{"line_number":162,"context_line":"        \"\"\"Execute NAS command via SSH."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        :param retry_patterns:    list of tuples,where each tuple contains"},{"line_number":165,"context_line":"                                  a reg expression and a exception."},{"line_number":166,"context_line":"        :param check_exit_code:   Boolean. Raise"},{"line_number":167,"context_line":"                                  processutils.ProcessExecutionError if the"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_835c7726","line":164,"updated":"2015-11-04 13:10:43.000000000","message":"http://docs.openstack.org/developer/hacking/#docstrings\n\nAt least, it is just not consistent with other descriptions of params in your change.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def _execute_cmd(self, cmd, retry_patterns\u003dNone, check_exit_code\u003dFalse):"},{"line_number":162,"context_line":"        \"\"\"Execute NAS command via SSH."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        :param retry_patterns:    list of tuples,where each tuple contains"},{"line_number":165,"context_line":"                                  a reg expression and a exception."},{"line_number":166,"context_line":"        :param check_exit_code:   Boolean. Raise"},{"line_number":167,"context_line":"                                  processutils.ProcessExecutionError if the"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_dcad8089","line":164,"in_reply_to":"fa80f949_835c7726","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":608,"context_line":"                not self.xml_retry):"},{"line_number":609,"context_line":"            self.xml_retry \u003d True"},{"line_number":610,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":611,"context_line":"        elif constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":612,"context_line":"            return response[\u0027maxSeverity\u0027], response[\u0027objects\u0027]"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_22d04e53","line":610,"updated":"2015-11-08 03:10:50.000000000","message":"exception.EMCVnxInvalidMoverID(id\u003dmover_id) after you\u0027ve changed it in exception.py","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":608,"context_line":"                not self.xml_retry):"},{"line_number":609,"context_line":"            self.xml_retry \u003d True"},{"line_number":610,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":611,"context_line":"        elif constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":612,"context_line":"            return response[\u0027maxSeverity\u0027], response[\u0027objects\u0027]"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_3cd38a3a","line":610,"in_reply_to":"da85f559_22d04e53","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":638,"context_line":"                not self.xml_retry):"},{"line_number":639,"context_line":"            self.xml_retry \u003d True"},{"line_number":640,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":641,"context_line":"        elif self._is_mount_point_nonexistent(response):"},{"line_number":642,"context_line":"            LOG.warn(_LW(\u0027Mount point %(mount)s on mover %(mover_name)s \u0027"},{"line_number":643,"context_line":"                         \u0027not found.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_e2c9e6ad","line":640,"updated":"2015-11-08 03:10:50.000000000","message":"Same","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":638,"context_line":"                not self.xml_retry):"},{"line_number":639,"context_line":"            self.xml_retry \u003d True"},{"line_number":640,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":641,"context_line":"        elif self._is_mount_point_nonexistent(response):"},{"line_number":642,"context_line":"            LOG.warn(_LW(\u0027Mount point %(mount)s on mover %(mover_name)s \u0027"},{"line_number":643,"context_line":"                         \u0027not found.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_5cd8ce53","line":640,"in_reply_to":"da85f559_e2c9e6ad","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":869,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":870,"context_line":"                not self.xml_retry):"},{"line_number":871,"context_line":"            self.xml_retry \u003d True"},{"line_number":872,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":873,"context_line":"        elif self._response_validation(response, constants.MSG_VDM_EXIST):"},{"line_number":874,"context_line":"            LOG.warn(_LW(\"VDM %(name)s already exists. Skip the creation.\"),"},{"line_number":875,"context_line":"                     {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_62be5601","line":872,"updated":"2015-11-08 03:10:50.000000000","message":"Same","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":869,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":870,"context_line":"                not self.xml_retry):"},{"line_number":871,"context_line":"            self.xml_retry \u003d True"},{"line_number":872,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":873,"context_line":"        elif self._response_validation(response, constants.MSG_VDM_EXIST):"},{"line_number":874,"context_line":"            LOG.warn(_LW(\"VDM %(name)s already exists. Skip the creation.\"),"},{"line_number":875,"context_line":"                     {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_fcdc2248","line":872,"in_reply_to":"da85f559_62be5601","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":1179,"context_line":"                not self.xml_retry):"},{"line_number":1180,"context_line":"            self.xml_retry \u003d True"},{"line_number":1181,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":1182,"context_line":"        elif self._response_validation("},{"line_number":1183,"context_line":"                response, constants.MSG_INTERFACE_NAME_EXIST):"},{"line_number":1184,"context_line":"            LOG.warn(_LW(\"Mover interface name %s already exists. \""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_e240060a","line":1181,"updated":"2015-11-08 03:10:50.000000000","message":"Same","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":1179,"context_line":"                not self.xml_retry):"},{"line_number":1180,"context_line":"            self.xml_retry \u003d True"},{"line_number":1181,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":1182,"context_line":"        elif self._response_validation("},{"line_number":1183,"context_line":"                response, constants.MSG_INTERFACE_NAME_EXIST):"},{"line_number":1184,"context_line":"            LOG.warn(_LW(\"Mover interface name %s already exists. \""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_1ce24604","line":1181,"in_reply_to":"da85f559_e240060a","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a07fd6876a5fb61250bccdd99c5e2bd8fee32c26","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":1628,"context_line":"                not self.xml_retry):"},{"line_number":1629,"context_line":"            self.xml_retry \u003d True"},{"line_number":1630,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":1631,"context_line":"        elif constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":1632,"context_line":"            message \u003d (_(\"Failed to delete file system %(name)s. \""},{"line_number":1633,"context_line":"                         \"Reason: %(err)s.\") %"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_6255f6c4","line":1630,"updated":"2015-11-08 03:10:50.000000000","message":"Same","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5137e216e38d5b2ffb9f4ecef09cb31c26864ef2","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"                                      constants.MSG_INVALID_MOVER_ID) and"},{"line_number":1628,"context_line":"                not self.xml_retry):"},{"line_number":1629,"context_line":"            self.xml_retry \u003d True"},{"line_number":1630,"context_line":"            raise exception.EMCVnxInvalidMoverID"},{"line_number":1631,"context_line":"        elif constants.STATUS_OK !\u003d response[\u0027maxSeverity\u0027]:"},{"line_number":1632,"context_line":"            message \u003d (_(\"Failed to delete file system %(name)s. \""},{"line_number":1633,"context_line":"                         \"Reason: %(err)s.\") %"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_bce77a11","line":1630,"in_reply_to":"da85f559_6255f6c4","updated":"2015-11-09 01:20:49.000000000","message":"Done","commit_id":"f3af3c7a3a91fbc4ae7ff7b810d699bb5e75d315"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7d6e95f0770832c860f493359b5d9ac43efe932b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        old_Severity \u003d response[\u0027maxSeverity\u0027]"},{"line_number":90,"context_line":"        if response[\u0027maxSeverity\u0027] in [constants.STATUS_DEBUG,"},{"line_number":91,"context_line":"                                       constants.STATUS_INFO]:"},{"line_number":92,"context_line":"            response[\u0027maxSeverity\u0027] \u003d constants.STATUS_OK"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_8f113a54","line":90,"updated":"2015-11-12 17:04:52.000000000","message":"One more s/list/tuple/","commit_id":"5ac332346ce6bfca65c1fc3787f06506bbc98160"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"70bdf257452fcab2832be5fd98474364969ecd0d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            return"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        old_Severity \u003d response[\u0027maxSeverity\u0027]"},{"line_number":90,"context_line":"        if response[\u0027maxSeverity\u0027] in [constants.STATUS_DEBUG,"},{"line_number":91,"context_line":"                                       constants.STATUS_INFO]:"},{"line_number":92,"context_line":"            response[\u0027maxSeverity\u0027] \u003d constants.STATUS_OK"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_1fb9e5ec","line":90,"in_reply_to":"da85f559_8f113a54","updated":"2015-11-13 03:44:21.000000000","message":"Done","commit_id":"5ac332346ce6bfca65c1fc3787f06506bbc98160"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7d6e95f0770832c860f493359b5d9ac43efe932b","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            src \u003d response[\u0027objects\u0027][0]"},{"line_number":285,"context_line":"            filesystem \u003d {}"},{"line_number":286,"context_line":"            property_map \u003d ["},{"line_number":287,"context_line":"                \u0027name\u0027,"},{"line_number":288,"context_line":"                (\u0027pools_id\u0027, \u0027storagePools\u0027),"},{"line_number":289,"context_line":"                (\u0027volume_id\u0027, \u0027volume\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_2f8fee75","line":286,"updated":"2015-11-12 17:04:52.000000000","message":"Can it be a tuple?","commit_id":"5ac332346ce6bfca65c1fc3787f06506bbc98160"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"70bdf257452fcab2832be5fd98474364969ecd0d","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"            src \u003d response[\u0027objects\u0027][0]"},{"line_number":285,"context_line":"            filesystem \u003d {}"},{"line_number":286,"context_line":"            property_map \u003d ["},{"line_number":287,"context_line":"                \u0027name\u0027,"},{"line_number":288,"context_line":"                (\u0027pools_id\u0027, \u0027storagePools\u0027),"},{"line_number":289,"context_line":"                (\u0027volume_id\u0027, \u0027volume\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3fbe29d5","line":286,"in_reply_to":"da85f559_2f8fee75","updated":"2015-11-13 03:44:21.000000000","message":"Done","commit_id":"5ac332346ce6bfca65c1fc3787f06506bbc98160"}],"manila/share/drivers/emc/plugins/vnx/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_31fab8be","line":1,"updated":"2015-11-04 13:10:43.000000000","message":"Any copyright should contain only one year - year of \"first\" appearance.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_fc7404fe","line":1,"in_reply_to":"fa80f949_31fab8be","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7d6e95f0770832c860f493359b5d9ac43efe932b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import types"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_ccff5064","line":15,"updated":"2015-11-12 17:04:52.000000000","message":"Without redundant update of this file your commit would have only 8796 added code lines! :) And how many such places does this commit have?","commit_id":"5ac332346ce6bfca65c1fc3787f06506bbc98160"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"70bdf257452fcab2832be5fd98474364969ecd0d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import types"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_02e18afe","line":15,"in_reply_to":"da85f559_ccff5064","updated":"2015-11-13 03:44:21.000000000","message":"connector.py (168 lines) is more like that; building xml requests (about 80 lines) in object_manager.py are derived from the previous; fake data (about 1000+ lines) in fakes.py are mostly from the previous. tests/share/drivers/emc/plugins/vnx/utils.py (about 100 lines) is also the similar case. So in general, it is about 7500 added code lines, including unit test coverage enhancement. \n\nRemoving the unit test code, it is about 2500 added code lines. Indeed, it is a big change, for sure.","commit_id":"5ac332346ce6bfca65c1fc3787f06506bbc98160"}],"manila/share/drivers/emc/plugins/vnx/xml_api_parser.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b1c78811","line":1,"updated":"2015-11-04 13:10:43.000000000","message":"Any copyright should contain only one year - year of \"first\" appearance.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014-2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_9cee188a","line":1,"in_reply_to":"fa80f949_b1c78811","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                else:"},{"line_number":99,"context_line":"                    obj[self.tag] \u003d [sub_elm]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def start_TaskResponse(self, elm, result):"},{"line_number":102,"context_line":"        self.is_TaskResponse \u003d True"},{"line_number":103,"context_line":"        result[\u0027type\u0027] \u003d \u0027TaskResponse\u0027"},{"line_number":104,"context_line":"        self._copy_property(elm.attrib, result, [\u0027taskId\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b1eea889","line":101,"updated":"2015-11-04 13:10:43.000000000","message":"It is not pythonic way of method naming.See http://docs.openstack.org/developer/hacking/#calling-methods\n\nSame for all other such occurrences.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                else:"},{"line_number":99,"context_line":"                    obj[self.tag] \u003d [sub_elm]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def start_TaskResponse(self, elm, result):"},{"line_number":102,"context_line":"        self.is_TaskResponse \u003d True"},{"line_number":103,"context_line":"        result[\u0027type\u0027] \u003d \u0027TaskResponse\u0027"},{"line_number":104,"context_line":"        self._copy_property(elm.attrib, result, [\u0027taskId\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_edef6cae","line":101,"in_reply_to":"fa80f949_b1eea889","updated":"2015-11-04 16:14:56.000000000","message":"I‘ll change to start_task_response(). The same as the other methods.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def start_Problem(self, elm, result):"},{"line_number":127,"context_line":"        self.elt \u003d {}"},{"line_number":128,"context_line":"        properties \u003d [\u0027message\u0027, \u0027messageCode\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self._copy_property(elm.attrib, self.elt, properties)"},{"line_number":131,"context_line":"        result[\u0027problems\u0027].append(self.elt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_51ae5c2f","line":128,"updated":"2015-11-04 13:10:43.000000000","message":"Is there any reason to define it as \"list\" and not \"tuple\"? \"tuple\" is 10 times faster.\n\nSame for all other such occurrences.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def start_Problem(self, elm, result):"},{"line_number":127,"context_line":"        self.elt \u003d {}"},{"line_number":128,"context_line":"        properties \u003d [\u0027message\u0027, \u0027messageCode\u0027]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        self._copy_property(elm.attrib, self.elt, properties)"},{"line_number":131,"context_line":"        result[\u0027problems\u0027].append(self.elt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c84e16c1","line":128,"in_reply_to":"fa80f949_51ae5c2f","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ddc05d88953e5cebdfa3e4c0b017f2e894d7815a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        result[\u0027objects\u0027].append(self.elt)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def start_file_system_capacity_info(self, elm, result):"},{"line_number":173,"context_line":"        property \u003d (\u0027volumeSize\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        identifier \u003d \u0027fileSystem\u0027"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_fe7f1164","line":173,"updated":"2015-11-04 17:15:17.000000000","message":"this one is string, is it ok?","commit_id":"3ccef5f0bd0fb091465debed64993a1d0e040b72"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"7ee9a503451e2cdaa7298c04c78c57d6db124c40","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        result[\u0027objects\u0027].append(self.elt)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def start_file_system_capacity_info(self, elm, result):"},{"line_number":173,"context_line":"        property \u003d (\u0027volumeSize\u0027)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        identifier \u003d \u0027fileSystem\u0027"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_272b3a96","line":173,"in_reply_to":"fa80f949_fe7f1164","updated":"2015-11-05 04:07:13.000000000","message":"Done","commit_id":"3ccef5f0bd0fb091465debed64993a1d0e040b72"}],"manila/tests/share/drivers/emc/plugins/vnx/test_object_manager.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import ddt"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_concurrency import processutils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c39a7f14","line":18,"updated":"2015-11-04 13:10:43.000000000","message":"You do not use ddt in tests, why do you import it and wrap test classes with it?","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import ddt"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_concurrency import processutils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_08b17e8f","line":18,"in_reply_to":"fa80f949_c39a7f14","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"@ddt.ddt"},{"line_number":100,"context_line":"class FileSystemTestCase(StorageObjectTestCase):"},{"line_number":101,"context_line":"    def setUp(self):"},{"line_number":102,"context_line":"        super(FileSystemTestCase, self).setUp()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_create_file_system_on_vdm(self):"},{"line_number":105,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_8311d7ae","line":102,"updated":"2015-11-04 13:10:43.000000000","message":"Lines 101 and 102 are redundant.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":99,"context_line":"@ddt.ddt"},{"line_number":100,"context_line":"class FileSystemTestCase(StorageObjectTestCase):"},{"line_number":101,"context_line":"    def setUp(self):"},{"line_number":102,"context_line":"        super(FileSystemTestCase, self).setUp()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_create_file_system_on_vdm(self):"},{"line_number":105,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2a9f97b5","line":102,"in_reply_to":"fa80f949_8311d7ae","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":530,"context_line":"@ddt.ddt"},{"line_number":531,"context_line":"class MountPointTestCase(StorageObjectTestCase):"},{"line_number":532,"context_line":"    def setUp(self):"},{"line_number":533,"context_line":"        super(MountPointTestCase, self).setUp()"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_create_mount_point_on_vdm(self):"},{"line_number":536,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_e3778300","line":533,"updated":"2015-11-04 13:10:43.000000000","message":"ditto, BUT\n\nyou can place here code \"hook \u003d utils.RequestSideEffect()\" that you define in each test.","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3bb594d7512076a6795c4a41d6ea9ed8b4788744","unresolved":false,"context_lines":[{"line_number":530,"context_line":"@ddt.ddt"},{"line_number":531,"context_line":"class MountPointTestCase(StorageObjectTestCase):"},{"line_number":532,"context_line":"    def setUp(self):"},{"line_number":533,"context_line":"        super(MountPointTestCase, self).setUp()"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_create_mount_point_on_vdm(self):"},{"line_number":536,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_deca4da1","line":533,"in_reply_to":"fa80f949_0aead30f","updated":"2015-11-04 17:12:45.000000000","message":"def setUp(self):\n\n    super(self.__class__, self).setUp()\n\n    self.hook \u003d utils.RequestSideEffect()\n\ndef test_foo(self):\n\n    self.hook.append(...)","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"ded4ff3c32e7aba18b8e79da83a168d1c35a49cb","unresolved":false,"context_lines":[{"line_number":530,"context_line":"@ddt.ddt"},{"line_number":531,"context_line":"class MountPointTestCase(StorageObjectTestCase):"},{"line_number":532,"context_line":"    def setUp(self):"},{"line_number":533,"context_line":"        super(MountPointTestCase, self).setUp()"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_create_mount_point_on_vdm(self):"},{"line_number":536,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_8d20079d","line":533,"in_reply_to":"fa80f949_deca4da1","updated":"2015-11-05 04:06:58.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":530,"context_line":"@ddt.ddt"},{"line_number":531,"context_line":"class MountPointTestCase(StorageObjectTestCase):"},{"line_number":532,"context_line":"    def setUp(self):"},{"line_number":533,"context_line":"        super(MountPointTestCase, self).setUp()"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_create_mount_point_on_vdm(self):"},{"line_number":536,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_0aead30f","line":533,"in_reply_to":"fa80f949_e3778300","updated":"2015-11-04 16:14:56.000000000","message":"hook \u003d utils.RequestSideEffect() is local variable. could it be in setUp()?","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":859,"context_line":"@ddt.ddt"},{"line_number":860,"context_line":"class VDMTestCase(StorageObjectTestCase):"},{"line_number":861,"context_line":"    def setUp(self):"},{"line_number":862,"context_line":"        super(VDMTestCase, self).setUp()"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"    def test_create_vdm(self):"},{"line_number":865,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_a3c73b11","line":862,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":859,"context_line":"@ddt.ddt"},{"line_number":860,"context_line":"class VDMTestCase(StorageObjectTestCase):"},{"line_number":861,"context_line":"    def setUp(self):"},{"line_number":862,"context_line":"        super(VDMTestCase, self).setUp()"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"    def test_create_vdm(self):"},{"line_number":865,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2ad47745","line":862,"in_reply_to":"fa80f949_a3c73b11","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"@ddt.ddt"},{"line_number":1138,"context_line":"class StoragePoolTestCase(StorageObjectTestCase):"},{"line_number":1139,"context_line":"    def setUp(self):"},{"line_number":1140,"context_line":"        super(StoragePoolTestCase, self).setUp()"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    def test_get_pool(self):"},{"line_number":1143,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c3f35f72","line":1140,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"@ddt.ddt"},{"line_number":1138,"context_line":"class StoragePoolTestCase(StorageObjectTestCase):"},{"line_number":1139,"context_line":"    def setUp(self):"},{"line_number":1140,"context_line":"        super(StoragePoolTestCase, self).setUp()"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":"    def test_get_pool(self):"},{"line_number":1143,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_aa6e2794","line":1140,"in_reply_to":"fa80f949_c3f35f72","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"@ddt.ddt"},{"line_number":1208,"context_line":"class MoverTestCase(StorageObjectTestCase):"},{"line_number":1209,"context_line":"    def setUp(self):"},{"line_number":1210,"context_line":"        super(MoverTestCase, self).setUp()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def test_get_mover(self):"},{"line_number":1213,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_a3317b0d","line":1210,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"@ddt.ddt"},{"line_number":1208,"context_line":"class MoverTestCase(StorageObjectTestCase):"},{"line_number":1209,"context_line":"    def setUp(self):"},{"line_number":1210,"context_line":"        super(MoverTestCase, self).setUp()"},{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"    def test_get_mover(self):"},{"line_number":1213,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_caca8ba1","line":1210,"in_reply_to":"fa80f949_a3317b0d","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1392,"context_line":"@ddt.ddt"},{"line_number":1393,"context_line":"class SnapshotTestCase(StorageObjectTestCase):"},{"line_number":1394,"context_line":"    def setUp(self):"},{"line_number":1395,"context_line":"        super(SnapshotTestCase, self).setUp()"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def test_create_snapshot(self):"},{"line_number":1398,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c34fdf90","line":1395,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1392,"context_line":"@ddt.ddt"},{"line_number":1393,"context_line":"class SnapshotTestCase(StorageObjectTestCase):"},{"line_number":1394,"context_line":"    def setUp(self):"},{"line_number":1395,"context_line":"        super(SnapshotTestCase, self).setUp()"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"    def test_create_snapshot(self):"},{"line_number":1398,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_eacd0fb8","line":1395,"in_reply_to":"fa80f949_c34fdf90","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1599,"context_line":"@ddt.ddt"},{"line_number":1600,"context_line":"class MoverInterfaceTestCase(StorageObjectTestCase):"},{"line_number":1601,"context_line":"    def setUp(self):"},{"line_number":1602,"context_line":"        super(MoverInterfaceTestCase, self).setUp()"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    def test_create_mover_interface(self):"},{"line_number":1605,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_a34adb81","line":1602,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1599,"context_line":"@ddt.ddt"},{"line_number":1600,"context_line":"class MoverInterfaceTestCase(StorageObjectTestCase):"},{"line_number":1601,"context_line":"    def setUp(self):"},{"line_number":1602,"context_line":"        super(MoverInterfaceTestCase, self).setUp()"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    def test_create_mover_interface(self):"},{"line_number":1605,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_aac0677d","line":1602,"in_reply_to":"fa80f949_a34adb81","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1871,"context_line":"@ddt.ddt"},{"line_number":1872,"context_line":"class DNSDomainTestCase(StorageObjectTestCase):"},{"line_number":1873,"context_line":"    def setUp(self):"},{"line_number":1874,"context_line":"        super(DNSDomainTestCase, self).setUp()"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"    def test_create_dns_domain(self):"},{"line_number":1877,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_43752fc9","line":1874,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1871,"context_line":"@ddt.ddt"},{"line_number":1872,"context_line":"class DNSDomainTestCase(StorageObjectTestCase):"},{"line_number":1873,"context_line":"    def setUp(self):"},{"line_number":1874,"context_line":"        super(DNSDomainTestCase, self).setUp()"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"    def test_create_dns_domain(self):"},{"line_number":1877,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_4abf7bfb","line":1874,"in_reply_to":"fa80f949_43752fc9","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":1986,"context_line":"@ddt.ddt"},{"line_number":1987,"context_line":"class CIFSServerTestCase(StorageObjectTestCase):"},{"line_number":1988,"context_line":"    def setUp(self):"},{"line_number":1989,"context_line":"        super(CIFSServerTestCase, self).setUp()"},{"line_number":1990,"context_line":""},{"line_number":1991,"context_line":"    def test_create_cifs_server(self):"},{"line_number":1992,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_837237e4","line":1989,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":1986,"context_line":"@ddt.ddt"},{"line_number":1987,"context_line":"class CIFSServerTestCase(StorageObjectTestCase):"},{"line_number":1988,"context_line":"    def setUp(self):"},{"line_number":1989,"context_line":"        super(CIFSServerTestCase, self).setUp()"},{"line_number":1990,"context_line":""},{"line_number":1991,"context_line":"    def test_create_cifs_server(self):"},{"line_number":1992,"context_line":"        hook \u003d utils.RequestSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_6aba7f0c","line":1989,"in_reply_to":"fa80f949_837237e4","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9798425f499da4646671ecac122976cf04f59e4c","unresolved":false,"context_lines":[{"line_number":2803,"context_line":"@ddt.ddt"},{"line_number":2804,"context_line":"class NFSShareTestCase(StorageObjectTestCase):"},{"line_number":2805,"context_line":"    def setUp(self):"},{"line_number":2806,"context_line":"        super(NFSShareTestCase, self).setUp()"},{"line_number":2807,"context_line":""},{"line_number":2808,"context_line":"    def test_create_nfs_share(self):"},{"line_number":2809,"context_line":"        ssh_hook \u003d utils.SSHSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_83bb1772","line":2806,"updated":"2015-11-04 13:10:43.000000000","message":"ditto","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"f1dc3d30ba45b1d9e8c16f88467727834a3123db","unresolved":false,"context_lines":[{"line_number":2803,"context_line":"@ddt.ddt"},{"line_number":2804,"context_line":"class NFSShareTestCase(StorageObjectTestCase):"},{"line_number":2805,"context_line":"    def setUp(self):"},{"line_number":2806,"context_line":"        super(NFSShareTestCase, self).setUp()"},{"line_number":2807,"context_line":""},{"line_number":2808,"context_line":"    def test_create_nfs_share(self):"},{"line_number":2809,"context_line":"        ssh_hook \u003d utils.SSHSideEffect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2a3b179e","line":2806,"in_reply_to":"fa80f949_83bb1772","updated":"2015-11-04 16:14:56.000000000","message":"Done","commit_id":"6c5dfbb59a81c34bf70bb758db2b8b856f33e90e"}]}
