)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Goutham Pacha Ravi \u003cgouthamr@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-03 01:32:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for Manila DR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add tempest functional tests for Manila share replication"},{"line_number":10,"context_line":"actions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a5ae5dd_2fea4010","line":7,"updated":"2016-02-04 06:38:37.000000000","message":"\"DR\"? What does that mean? Should it be \"SR\" for share replication?","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Goutham Pacha Ravi \u003cgouthamr@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-03 01:32:16 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for Manila DR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add tempest functional tests for Manila share replication"},{"line_number":10,"context_line":"actions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a57f1b5_781b1e1c","line":7,"in_reply_to":"5a5ae5dd_2fea4010","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4aceb157bf82a66f7e474333837c8f2b4ad6be75","unresolved":false,"context_lines":[{"line_number":12,"context_line":"By default, these tests are disabled; 3rd party CI systems"},{"line_number":13,"context_line":"should enable these tests through the"},{"line_number":14,"context_line":"RUN_MANILA_REPLICATION_TESTS environment variable"},{"line_number":15,"context_line":"if their driver supports share replication."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements: blueprint manila-share-replication"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a5ae5dd_282b4d84","line":15,"updated":"2016-02-03 10:39:11.000000000","message":"Can you add some information which 3rd party CI system actually executes the test currently? I would really like to see it passing.","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50ad9d39d2b640b71015935b4aee5e00a5512939","unresolved":false,"context_lines":[{"line_number":12,"context_line":"By default, these tests are disabled; 3rd party CI systems"},{"line_number":13,"context_line":"should enable these tests through the"},{"line_number":14,"context_line":"RUN_MANILA_REPLICATION_TESTS environment variable"},{"line_number":15,"context_line":"if their driver supports share replication."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements: blueprint manila-share-replication"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a5ae5dd_cfee35ec","line":15,"in_reply_to":"5a5ae5dd_282b4d84","updated":"2016-02-03 14:13:17.000000000","message":"Hi Marc, no third party drivers support replication yet.\nThis experimental feature is yet to merge:\n \nCode: https://review.openstack.org/#/c/238572/\nClient: https://review.openstack.org/#/c/235448/\n \nProposed NetApp impl: https://review.openstack.org/#/c/275416/\n \nDesign Document: https://wiki.openstack.org/wiki/Manila/design/manila-mitaka-data-replication","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Co-Authored-By: Goutham Pacha Ravi \u003cgouthamr@netapp.com\u003e"},{"line_number":16,"context_line":"Co-Authored-By: Andrew Kerr \u003candrew.kerr@netapp.com\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: I3ddd3767184e4843037de0ac75ff18dce709b6dc"},{"line_number":19,"context_line":"Change-Id: Idaf3c61600337cc30568b982dfb23948209c1d6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5aef4532_70f767f5","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"updated":"2016-03-09 06:49:31.000000000","message":"Please, remove it with next patch-set.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Co-Authored-By: Goutham Pacha Ravi \u003cgouthamr@netapp.com\u003e"},{"line_number":16,"context_line":"Co-Authored-By: Andrew Kerr \u003candrew.kerr@netapp.com\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: I3ddd3767184e4843037de0ac75ff18dce709b6dc"},{"line_number":19,"context_line":"Change-Id: Idaf3c61600337cc30568b982dfb23948209c1d6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5aef4532_da4fff68","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"in_reply_to":"5aef4532_70f767f5","updated":"2016-03-10 20:24:58.000000000","message":"Done.\n\nAdded new for Bug #1554282","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"}],"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":61,"context_line":"    # Define whether share drivers handle share servers or not."},{"line_number":62,"context_line":"    # Requires defined config option \u0027driver_handles_share_servers\u0027."},{"line_number":63,"context_line":"    MANILA_CONF\u003d${MANILA_CONF:-/etc/manila/manila.conf}"},{"line_number":64,"context_line":"    NO_SHARE_SERVER_HANDLING_MODES\u003d0"},{"line_number":65,"context_line":"    WITH_SHARE_SERVER_HANDLING_MODES\u003d0"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba8a016a_e601ff6b","line":63,"updated":"2015-11-20 14:53:34.000000000","message":"Duplication of line 54.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4aceb157bf82a66f7e474333837c8f2b4ad6be75","unresolved":false,"context_lines":[{"line_number":76,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":77,"context_line":"    # Define whether share drivers handle share servers or not."},{"line_number":78,"context_line":"    # Requires defined config option \u0027driver_handles_share_servers\u0027."},{"line_number":79,"context_line":"    MANILA_CONF\u003d${MANILA_CONF:-/etc/manila/manila.conf}"},{"line_number":80,"context_line":"    NO_SHARE_SERVER_HANDLING_MODES\u003d0"},{"line_number":81,"context_line":"    WITH_SHARE_SERVER_HANDLING_MODES\u003d0"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_6d1dd7bc","line":79,"updated":"2016-02-03 10:39:11.000000000","message":"How is this line related to the change?","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50ad9d39d2b640b71015935b4aee5e00a5512939","unresolved":false,"context_lines":[{"line_number":76,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":77,"context_line":"    # Define whether share drivers handle share servers or not."},{"line_number":78,"context_line":"    # Requires defined config option \u0027driver_handles_share_servers\u0027."},{"line_number":79,"context_line":"    MANILA_CONF\u003d${MANILA_CONF:-/etc/manila/manila.conf}"},{"line_number":80,"context_line":"    NO_SHARE_SERVER_HANDLING_MODES\u003d0"},{"line_number":81,"context_line":"    WITH_SHARE_SERVER_HANDLING_MODES\u003d0"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_efa3f19c","line":79,"in_reply_to":"5a5ae5dd_6d1dd7bc","updated":"2016-02-03 14:13:17.000000000","message":"Thanks for pointing it out. Will remove this.","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Enable replication tests"},{"line_number":73,"context_line":"RUN_MANILA_REPLICATION_TESTS\u003d${RUN_MANILA_REPLICATION_TESTS:-False}"},{"line_number":74,"context_line":"iniset $BASE/new/tempest/etc/tempest.conf share run_replication_tests $RUN_MANILA_REPLICATION_TESTS"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":77,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":8,"id":"bae84128_9ce37605","line":74,"updated":"2016-02-25 10:30:35.000000000","message":"Please use $TEMPEST_CONFIG instead of $BASE/new/tempest/etc/tempest.conf","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Enable replication tests"},{"line_number":73,"context_line":"RUN_MANILA_REPLICATION_TESTS\u003d${RUN_MANILA_REPLICATION_TESTS:-False}"},{"line_number":74,"context_line":"iniset $BASE/new/tempest/etc/tempest.conf share run_replication_tests $RUN_MANILA_REPLICATION_TESTS"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"if [[ -z \"$MULTITENANCY_ENABLED\" ]]; then"},{"line_number":77,"context_line":"    # Define whether share drivers handle share servers or not."}],"source_content_type":"text/x-sh","patch_set":8,"id":"9aed3d3a_2ecb3774","line":74,"in_reply_to":"bae84128_9ce37605","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"}],"manila_tempest_tests/common/constants.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_70ce47b5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2016-03-09 06:49:31.000000000","message":"Whose rights?","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_ba87935f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"5aef4532_35ac928b","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4b4fb2b4fe7ebd9da31c3182006bf2dd2f905723","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_35ac928b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"5aef4532_70ce47b5","updated":"2016-03-09 14:42:46.000000000","message":"No one\u0027s. we should remove this.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":549,"context_line":"        return self._parse_resp(body)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"    def list_replicas_for_share(self, share_id, version\u003dLATEST_MICROVERSION):"},{"line_number":552,"context_line":"        \"\"\"Get list of replicas for specified share.\"\"\""},{"line_number":553,"context_line":"        resp, body \u003d self.get(\"share-replicas/detail?share_id\u003d%s\" % share_id,"},{"line_number":554,"context_line":"                              headers\u003dEXPERIMENTAL,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_26994720","line":551,"updated":"2015-11-20 14:53:34.000000000","message":"this","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":558,"context_line":"        return self._parse_resp(body)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def list_replicas(self, version\u003dLATEST_MICROVERSION):"},{"line_number":561,"context_line":"        \"\"\"Get list of all replicas.\"\"\""},{"line_number":562,"context_line":"        resp, body \u003d self.get(\"share-replicas/detail\","},{"line_number":563,"context_line":"                              headers\u003dEXPERIMENTAL,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_46924bf8","line":560,"updated":"2015-11-20 14:53:34.000000000","message":"and this should be combined into one method.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":567,"context_line":"        return self._parse_resp(body)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def list_replicas_summary_for_share(self, share_id,"},{"line_number":570,"context_line":"                                        version\u003dLATEST_MICROVERSION):"},{"line_number":571,"context_line":"        \"\"\"Get summary list of replicas for specified share.\"\"\""},{"line_number":572,"context_line":"        resp, body \u003d self.get(\"share-replicas?share_id\u003d%s\" % share_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_26c067e0","line":569,"updated":"2015-11-20 14:53:34.000000000","message":"ditto","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":906,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":907,"context_line":"        return self._parse_resp(body)"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"    def list_replicas(self, for_share\u003dFalse,"},{"line_number":910,"context_line":"                      share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":911,"context_line":"        \"\"\"Get list of replicas.\"\"\""},{"line_number":912,"context_line":"        uri \u003d \"share-replicas/detail\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_6f56f8d3","line":909,"updated":"2016-02-04 06:38:37.000000000","message":"for_share is not neeeded. just check for \"share_id is None\"","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":906,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":907,"context_line":"        return self._parse_resp(body)"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"    def list_replicas(self, for_share\u003dFalse,"},{"line_number":910,"context_line":"                      share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":911,"context_line":"        \"\"\"Get list of replicas.\"\"\""},{"line_number":912,"context_line":"        uri \u003d \"share-replicas/detail\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_c1e34804","line":909,"in_reply_to":"5a5ae5dd_6f56f8d3","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":917,"context_line":"        return self._parse_resp(body)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def list_replicas_summary(self, for_share\u003dFalse,"},{"line_number":920,"context_line":"                              share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":921,"context_line":"        \"\"\"Get summary list of replicas.\"\"\""},{"line_number":922,"context_line":"        uri \u003d \"share-replicas\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_ef58a8fc","line":919,"updated":"2016-02-04 06:38:37.000000000","message":"same here","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":917,"context_line":"        return self._parse_resp(body)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def list_replicas_summary(self, for_share\u003dFalse,"},{"line_number":920,"context_line":"                              share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":921,"context_line":"        \"\"\"Get summary list of replicas.\"\"\""},{"line_number":922,"context_line":"        uri \u003d \"share-replicas\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_61f294d4","line":919,"in_reply_to":"5a5ae5dd_ef58a8fc","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"            if int(time.time()) - start \u003e\u003d self.build_timeout:"},{"line_number":971,"context_line":"                message \u003d (\u0027Replica %s failed to reach %s status \u0027"},{"line_number":972,"context_line":"                           \u0027within the required time (%s s).\u0027 %"},{"line_number":973,"context_line":"                           (replica_id, status, self.build_timeout))"},{"line_number":974,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":975,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_0fe184fe","line":972,"updated":"2016-02-04 06:38:37.000000000","message":"nit: maybe also print the current status.","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":"            if int(time.time()) - start \u003e\u003d self.build_timeout:"},{"line_number":971,"context_line":"                message \u003d (\u0027Replica %s failed to reach %s status \u0027"},{"line_number":972,"context_line":"                           \u0027within the required time (%s s).\u0027 %"},{"line_number":973,"context_line":"                           (replica_id, status, self.build_timeout))"},{"line_number":974,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":975,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_a1b16c91","line":972,"in_reply_to":"5a5ae5dd_0fe184fe","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                           (replica_id, status, self.build_timeout))"},{"line_number":974,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    def wait_for_replica_state(self, replica_id, r_state):"},{"line_number":977,"context_line":"        \"\"\"Waits for a replica to reach a given replica_state.\"\"\""},{"line_number":978,"context_line":"        body \u003d self.get_share_replica(replica_id)"},{"line_number":979,"context_line":"        replica_state \u003d body[\u0027replica_state\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_4fa53cb3","line":976,"updated":"2016-02-04 06:38:37.000000000","message":"hm. this method looks very similar to wait_for_replica_status() . can you extract the common pieces and reuse the code in both functions?","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                           (replica_id, status, self.build_timeout))"},{"line_number":974,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    def wait_for_replica_state(self, replica_id, r_state):"},{"line_number":977,"context_line":"        \"\"\"Waits for a replica to reach a given replica_state.\"\"\""},{"line_number":978,"context_line":"        body \u003d self.get_share_replica(replica_id)"},{"line_number":979,"context_line":"        replica_state \u003d body[\u0027replica_state\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_c1aca837","line":976,"in_reply_to":"5a5ae5dd_4fa53cb3","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":908,"context_line":"        return self._parse_resp(body)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    def list_replicas(self, share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":911,"context_line":"        \"\"\"Get list of replicas.\"\"\""},{"line_number":912,"context_line":"        uri \u003d \"share-replicas/detail\""},{"line_number":913,"context_line":"        uri +\u003d (\"?share_id\u003d%s\" % share_id) if share_id is not None else \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_7c0b127e","line":910,"updated":"2016-02-25 10:30:35.000000000","message":"nit: for consitency, can you rename to \"list_share_replicas\" ?","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":908,"context_line":"        return self._parse_resp(body)"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    def list_replicas(self, share_id\u003dNone, version\u003dLATEST_MICROVERSION):"},{"line_number":911,"context_line":"        \"\"\"Get list of replicas.\"\"\""},{"line_number":912,"context_line":"        uri \u003d \"share-replicas/detail\""},{"line_number":913,"context_line":"        uri +\u003d (\"?share_id\u003d%s\" % share_id) if share_id is not None else \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_6eaa5f72","line":910,"in_reply_to":"bae84128_7c0b127e","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":917,"context_line":"        return self._parse_resp(body)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def list_replicas_summary(self, share_id\u003dNone,"},{"line_number":920,"context_line":"                              version\u003dLATEST_MICROVERSION):"},{"line_number":921,"context_line":"        \"\"\"Get summary list of replicas.\"\"\""},{"line_number":922,"context_line":"        uri \u003d \"share-replicas\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_9c225600","line":919,"updated":"2016-02-25 10:30:35.000000000","message":"imo same here: \"list_share_replicas_summary\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":916,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":917,"context_line":"        return self._parse_resp(body)"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"    def list_replicas_summary(self, share_id\u003dNone,"},{"line_number":920,"context_line":"                              version\u003dLATEST_MICROVERSION):"},{"line_number":921,"context_line":"        \"\"\"Get summary list of replicas.\"\"\""},{"line_number":922,"context_line":"        uri \u003d \"share-replicas\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_2e921758","line":919,"in_reply_to":"bae84128_9c225600","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        self.expected_success(expected_status, resp.status)"},{"line_number":952,"context_line":"        return self._parse_resp(body)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"    def wait_for_replica_status(self, replica_id, expected_status,"},{"line_number":955,"context_line":"                                status_attr\u003d\u0027status\u0027):"},{"line_number":956,"context_line":"        \"\"\"Waits for a replica\u0027s status_attr to reach a given status.\"\"\""},{"line_number":957,"context_line":"        body \u003d self.get_share_replica(replica_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_1c7da6e7","line":954,"updated":"2016-02-25 10:30:35.000000000","message":"imo same here: \"wait_for_share_replica_status\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        self.expected_success(expected_status, resp.status)"},{"line_number":952,"context_line":"        return self._parse_resp(body)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"    def wait_for_replica_status(self, replica_id, expected_status,"},{"line_number":955,"context_line":"                                status_attr\u003d\u0027status\u0027):"},{"line_number":956,"context_line":"        \"\"\"Waits for a replica\u0027s status_attr to reach a given status.\"\"\""},{"line_number":957,"context_line":"        body \u003d self.get_share_replica(replica_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_0e82b300","line":954,"in_reply_to":"bae84128_1c7da6e7","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                           })"},{"line_number":984,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    def reset_replica_status(self, replica_id,"},{"line_number":987,"context_line":"                             status\u003dconstants.STATUS_AVAILABLE,"},{"line_number":988,"context_line":"                             version\u003dLATEST_MICROVERSION):"},{"line_number":989,"context_line":"        \"\"\"Reset the status.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_9c69b628","line":986,"updated":"2016-02-25 10:30:35.000000000","message":"imo same here: \"reset_share_replica_status\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                           })"},{"line_number":984,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    def reset_replica_status(self, replica_id,"},{"line_number":987,"context_line":"                             status\u003dconstants.STATUS_AVAILABLE,"},{"line_number":988,"context_line":"                             version\u003dLATEST_MICROVERSION):"},{"line_number":989,"context_line":"        \"\"\"Reset the status.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_0e99136f","line":986,"in_reply_to":"bae84128_9c69b628","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1002,"context_line":"        return self._parse_resp(body)"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    def reset_replication_state(self, replica_id,"},{"line_number":1005,"context_line":"                                state\u003dconstants.REPLICATION_STATE_ACTIVE,"},{"line_number":1006,"context_line":"                                version\u003dLATEST_MICROVERSION):"},{"line_number":1007,"context_line":"        \"\"\"Reset the replication state of a replica.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_bc53da6b","line":1004,"updated":"2016-02-25 10:30:35.000000000","message":"imo same here: \"reset_share_replica_state\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1002,"context_line":"        return self._parse_resp(body)"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    def reset_replication_state(self, replica_id,"},{"line_number":1005,"context_line":"                                state\u003dconstants.REPLICATION_STATE_ACTIVE,"},{"line_number":1006,"context_line":"                                version\u003dLATEST_MICROVERSION):"},{"line_number":1007,"context_line":"        \"\"\"Reset the replication state of a replica.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_ee866f12","line":1004,"in_reply_to":"bae84128_bc53da6b","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1020,"context_line":"        return self._parse_resp(body)"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    def resync_replica(self, replica_id, expected_result\u003d202,"},{"line_number":1023,"context_line":"                       version\u003dLATEST_MICROVERSION):"},{"line_number":1024,"context_line":"        \"\"\"Force an immediate resync of the replica.\"\"\""},{"line_number":1025,"context_line":"        uri \u003d \u0027share-replicas/%s/action\u0027 % replica_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_dc4a1eac","line":1022,"updated":"2016-02-25 10:30:35.000000000","message":"imo same here: \"resync_share_replica\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":1020,"context_line":"        return self._parse_resp(body)"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    def resync_replica(self, replica_id, expected_result\u003d202,"},{"line_number":1023,"context_line":"                       version\u003dLATEST_MICROVERSION):"},{"line_number":1024,"context_line":"        \"\"\"Force an immediate resync of the replica.\"\"\""},{"line_number":1025,"context_line":"        uri \u003d \u0027share-replicas/%s/action\u0027 % replica_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_8e76c33c","line":1022,"in_reply_to":"bae84128_dc4a1eac","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        self.expected_success(expected_result, resp.status)"},{"line_number":1035,"context_line":"        return self._parse_resp(body)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    def force_delete_replica(self, replica_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1038,"context_line":"        \"\"\"Force delete a replica.\"\"\""},{"line_number":1039,"context_line":"        uri \u003d \u0027share-replicas/%s/action\u0027 % replica_id"},{"line_number":1040,"context_line":"        post_body \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_1ccbe61f","line":1037,"updated":"2016-02-25 10:30:35.000000000","message":"imo same here: \"force_delete_share_replica\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        self.expected_success(expected_result, resp.status)"},{"line_number":1035,"context_line":"        return self._parse_resp(body)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    def force_delete_replica(self, replica_id, version\u003dLATEST_MICROVERSION):"},{"line_number":1038,"context_line":"        \"\"\"Force delete a replica.\"\"\""},{"line_number":1039,"context_line":"        uri \u003d \u0027share-replicas/%s/action\u0027 % replica_id"},{"line_number":1040,"context_line":"        post_body \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_4e7cbb20","line":1037,"in_reply_to":"bae84128_1ccbe61f","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"}],"manila_tempest_tests/tests/api/admin/test_replication.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools  # noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest import test"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_a621b7b6","line":16,"updated":"2015-11-20 14:53:34.000000000","message":"Why noqa?","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools  # noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest import test"},{"line_number":20,"context_line":"from tempest_lib.common.utils import data_utils"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_261ce776","line":17,"updated":"2015-11-20 14:53:34.000000000","message":"Empty line should be removed.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertEqual(\u0027active\u0027, replica[\"replica_state\"])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Delete the demoted active replica so promoted replica can be"},{"line_number":127,"context_line":"        # cleaned during the cleanup"},{"line_number":128,"context_line":"        self.delete_replica(self.instance_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_019aedc5","line":127,"updated":"2015-11-20 14:53:34.000000000","message":"If test fails above then garbage will be left. It should be removed in any case.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"f492c0b01d993bc433798b831a016f450d3d99fe","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertEqual(\u0027active\u0027, replica[\"replica_state\"])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Delete the demoted active replica so promoted replica can be"},{"line_number":127,"context_line":"        # cleaned during the cleanup"},{"line_number":128,"context_line":"        self.delete_replica(self.instance_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_d101f73a","line":127,"in_reply_to":"ba8a016a_019aedc5","updated":"2016-02-02 21:17:15.000000000","message":"If I remove the delete code, the test fails on cleanup because it is trying to cleanup the newly promoted replica before the demoted one(since the cleanup process is sequential) and will fail complaining that share still has a replica.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if self.replication_type not in REPLICATION_PROMOTION_CHOICES:"},{"line_number":89,"context_line":"            raise self.skipException(\"Option backend_replication_type \""},{"line_number":90,"context_line":"                                     \"should either be readable or dr!\")"},{"line_number":91,"context_line":"        replica \u003d self.create_replica(self.share[\"id\"], self.zone,"},{"line_number":92,"context_line":"                                      self.admin_client, cleanup\u003dFalse)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_2fdec011","line":90,"updated":"2016-02-04 06:38:37.000000000","message":"replace \"readable or dr!\" with \"%s!\" % \" or \".join(REPLICATION_PROMOTION_CHOICES)","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if self.replication_type not in REPLICATION_PROMOTION_CHOICES:"},{"line_number":89,"context_line":"            raise self.skipException(\"Option backend_replication_type \""},{"line_number":90,"context_line":"                                     \"should either be readable or dr!\")"},{"line_number":91,"context_line":"        replica \u003d self.create_replica(self.share[\"id\"], self.zone,"},{"line_number":92,"context_line":"                                      self.admin_client, cleanup\u003dFalse)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_e13be4e9","line":90,"in_reply_to":"5a5ae5dd_2fdec011","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            cls.share[\"id\"])[0]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def _filter_replica_list(replica_list, r_state):"},{"line_number":67,"context_line":"        # Iterate through replica list to filter based on replica_state"},{"line_number":68,"context_line":"        return [replica[\u0027id\u0027] for replica in replica_list"},{"line_number":69,"context_line":"                if replica[\u0027replica_state\u0027] \u003d\u003d r_state]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_dc7dfeb2","line":66,"updated":"2016-02-25 10:30:35.000000000","message":"nit: \"_filter_share_replica_list\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            cls.share[\"id\"])[0]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def _filter_replica_list(replica_list, r_state):"},{"line_number":67,"context_line":"        # Iterate through replica list to filter based on replica_state"},{"line_number":68,"context_line":"        return [replica[\u0027id\u0027] for replica in replica_list"},{"line_number":69,"context_line":"                if replica[\u0027replica_state\u0027] \u003d\u003d r_state]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_0eb0f3dc","line":66,"in_reply_to":"bae84128_dc7dfeb2","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            replica_id\u003dreplica[\u0027id\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":138,"context_line":"    def test_reset_replica_status(self):"},{"line_number":139,"context_line":"        \"\"\"Test resetting a replica status.\"\"\""},{"line_number":140,"context_line":"        replica \u003d self.create_replica(self.share[\u0027id\u0027], self.zone)"},{"line_number":141,"context_line":"        self.admin_client.reset_replica_status(replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_1c1c8676","line":138,"updated":"2016-02-25 10:30:35.000000000","message":"imo \"test_reset_share_replica_status\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            replica_id\u003dreplica[\u0027id\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":138,"context_line":"    def test_reset_replica_status(self):"},{"line_number":139,"context_line":"        \"\"\"Test resetting a replica status.\"\"\""},{"line_number":140,"context_line":"        replica \u003d self.create_replica(self.share[\u0027id\u0027], self.zone)"},{"line_number":141,"context_line":"        self.admin_client.reset_replica_status(replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_4ecafb50","line":138,"in_reply_to":"bae84128_1c1c8676","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            replica[\u0027id\u0027], constants.STATUS_ERROR)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":147,"context_line":"    def test_reset_replica_state(self):"},{"line_number":148,"context_line":"        \"\"\"Test resetting a replica state.\"\"\""},{"line_number":149,"context_line":"        replica \u003d self.create_replica(self.share[\u0027id\u0027], self.zone)"},{"line_number":150,"context_line":"        self.admin_client.reset_replication_state(replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_bc0bda2a","line":147,"updated":"2016-02-25 10:30:35.000000000","message":"imo \"test_reset_share_replica_state\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            replica[\u0027id\u0027], constants.STATUS_ERROR)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":147,"context_line":"    def test_reset_replica_state(self):"},{"line_number":148,"context_line":"        \"\"\"Test resetting a replica state.\"\"\""},{"line_number":149,"context_line":"        replica \u003d self.create_replica(self.share[\u0027id\u0027], self.zone)"},{"line_number":150,"context_line":"        self.admin_client.reset_replication_state(replica[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_2ec7b746","line":147,"in_reply_to":"bae84128_bc0bda2a","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            replica[\u0027id\u0027], constants.STATUS_ERROR, status_attr\u003d\u0027replica_state\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":156,"context_line":"    def test_resync_replica(self):"},{"line_number":157,"context_line":"        \"\"\"Test resyncing a replica.\"\"\""},{"line_number":158,"context_line":"        replica \u003d self.create_replica(self.share[\u0027id\u0027], self.zone)"},{"line_number":159,"context_line":"        self.shares_v2_client.wait_for_replica_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_dc021e0b","line":156,"updated":"2016-02-25 10:30:35.000000000","message":"imo \"test_resync_share_replica\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            replica[\u0027id\u0027], constants.STATUS_ERROR, status_attr\u003d\u0027replica_state\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":156,"context_line":"    def test_resync_replica(self):"},{"line_number":157,"context_line":"        \"\"\"Test resyncing a replica.\"\"\""},{"line_number":158,"context_line":"        replica \u003d self.create_replica(self.share[\u0027id\u0027], self.zone)"},{"line_number":159,"context_line":"        self.shares_v2_client.wait_for_replica_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_8ec40341","line":156,"in_reply_to":"bae84128_dc021e0b","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"},{"line_number":31,"context_line":"                      \u0027Replication tests disabled.\u0027)"},{"line_number":32,"context_line":"@testtools.skipIf("},{"line_number":33,"context_line":"    CONF.share.max_api_microversion \u003c _MIN_SUPPORTED_MICROVERSION,"},{"line_number":34,"context_line":"    \u0027Max API microversion should be at least %s.\u0027"},{"line_number":35,"context_line":"    % _MIN_SUPPORTED_MICROVERSION)"},{"line_number":36,"context_line":"class ReplicationAdminTest(base.BaseSharesAdminTest):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_53751596","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":34},"updated":"2016-03-09 06:49:31.000000000","message":"Same as in https://review.openstack.org/#/c/244843/14/manila_tempest_tests/tests/api/test_replication.py","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"},{"line_number":31,"context_line":"                      \u0027Replication tests disabled.\u0027)"},{"line_number":32,"context_line":"@testtools.skipIf("},{"line_number":33,"context_line":"    CONF.share.max_api_microversion \u003c _MIN_SUPPORTED_MICROVERSION,"},{"line_number":34,"context_line":"    \u0027Max API microversion should be at least %s.\u0027"},{"line_number":35,"context_line":"    % _MIN_SUPPORTED_MICROVERSION)"},{"line_number":36,"context_line":"class ReplicationAdminTest(base.BaseSharesAdminTest):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_1a404706","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":34},"in_reply_to":"5aef4532_53751596","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        return cgsnapshot"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @classmethod"},{"line_number":492,"context_line":"    def create_replica(cls, share_id, zone, client\u003dNone,"},{"line_number":493,"context_line":"                       cleanup\u003dTrue):"},{"line_number":494,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":495,"context_line":"        replica \u003d client.create_share_replica(share_id, zone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_8f1c94c2","line":492,"updated":"2016-02-04 06:38:37.000000000","message":"nit: can you name it \"availability_zone\" instead of \"zone\" so it\u0027s clear that this isn\u0027t anything new","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        return cgsnapshot"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    @classmethod"},{"line_number":492,"context_line":"    def create_replica(cls, share_id, zone, client\u003dNone,"},{"line_number":493,"context_line":"                       cleanup\u003dTrue):"},{"line_number":494,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":495,"context_line":"        replica \u003d client.create_share_replica(share_id, zone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_b369bfc0","line":492,"in_reply_to":"5a5ae5dd_8f1c94c2","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        return cgsnapshot"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    @classmethod"},{"line_number":493,"context_line":"    def create_replica(cls, share_id, availability_zone, client\u003dNone,"},{"line_number":494,"context_line":"                       cleanup\u003dTrue):"},{"line_number":495,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":496,"context_line":"        replica \u003d client.create_share_replica(share_id, availability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_b73653e5","line":493,"updated":"2016-02-25 10:30:35.000000000","message":"imo \"create_share_replica\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        return cgsnapshot"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    @classmethod"},{"line_number":493,"context_line":"    def create_replica(cls, share_id, availability_zone, client\u003dNone,"},{"line_number":494,"context_line":"                       cleanup\u003dTrue):"},{"line_number":495,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":496,"context_line":"        replica \u003d client.create_share_replica(share_id, availability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_aee107d3","line":493,"in_reply_to":"bae84128_b73653e5","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fcbaaa921b03bf46ac225bc940e5f6bc8ef1f90f","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        return replica"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    @classmethod"},{"line_number":510,"context_line":"    def delete_replica(cls, replica_id, client\u003dNone):"},{"line_number":511,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":512,"context_line":"        client.delete_share_replica(replica_id)"},{"line_number":513,"context_line":"        client.wait_for_resource_deletion(replica_id\u003dreplica_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_9756af04","line":510,"updated":"2016-02-25 10:30:35.000000000","message":"imo \"delete_share_replica\"","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"37e0626cac34ffdd404e5dffa1955fa769dcdaad","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        return replica"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    @classmethod"},{"line_number":510,"context_line":"    def delete_replica(cls, replica_id, client\u003dNone):"},{"line_number":511,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":512,"context_line":"        client.delete_share_replica(replica_id)"},{"line_number":513,"context_line":"        client.wait_for_resource_deletion(replica_id\u003dreplica_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_4ed15bfb","line":510,"in_reply_to":"bae84128_9756af04","updated":"2016-02-25 18:11:07.000000000","message":"Done","commit_id":"8bc4fae0bb5c6104cc08c8f5a40a66526aa4d0fd"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"11ba37e843598e83befb67caa515b891148b7373","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    @classmethod"},{"line_number":493,"context_line":"    def get_availability_zones(cls):"},{"line_number":494,"context_line":"        cls.services \u003d cls.admin_client.list_services()"},{"line_number":495,"context_line":"        zones \u003d [service[\u0027zone\u0027] for service in cls.services if"},{"line_number":496,"context_line":"                 service[\u0027binary\u0027] \u003d\u003d \"manila-share\" and"},{"line_number":497,"context_line":"                 service[\u0027state\u0027] \u003d\u003d \u0027up\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"7af24918_51528214","line":494,"updated":"2016-03-01 19:02:50.000000000","message":"This function should take in the client as a kwarg (defaulting to the standard client) and not assume the presence of an \"admin_client\" object.  See \"create_share_replica\" below as an example.","commit_id":"ccee34e204d8a9b34080de1028268b287b5704c2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        return cgsnapshot"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    @classmethod"},{"line_number":512,"context_line":"    def get_availability_zones(cls, client\u003dNone):"},{"line_number":513,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":514,"context_line":"        cls.services \u003d client.list_services()"},{"line_number":515,"context_line":"        zones \u003d [service[\u0027zone\u0027] for service in cls.services if"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_f09b7770","line":512,"range":{"start_line":512,"start_character":8,"end_line":512,"end_character":30},"updated":"2016-03-09 06:49:31.000000000","message":"Name of method says get list of zones without regard to its state, but you filter \u0027down\u0027 services. So, it is incorrect from expectation point based on name.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1c71a135b7ddda4d43da2e1eead3fd3c5a25b6b","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    @classmethod"},{"line_number":525,"context_line":"    def create_share_replica(cls, share_id, availability_zone, client\u003dNone,"},{"line_number":526,"context_line":"                             cleanup\u003dTrue):"},{"line_number":527,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":528,"context_line":"        replica \u003d client.create_share_replica(share_id, availability_zone)"},{"line_number":529,"context_line":"        resource \u003d {"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_6851a162","line":526,"range":{"start_line":526,"start_character":29,"end_line":526,"end_character":41},"updated":"2016-03-11 17:29:16.000000000","message":"s/cleanup\u003dTrue/cleanup_in_class\u003dTrue/","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"8f242b4ce3b608bca2e819cdd0209abb1ce21e4e","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    @classmethod"},{"line_number":525,"context_line":"    def create_share_replica(cls, share_id, availability_zone, client\u003dNone,"},{"line_number":526,"context_line":"                             cleanup\u003dTrue):"},{"line_number":527,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":528,"context_line":"        replica \u003d client.create_share_replica(share_id, availability_zone)"},{"line_number":529,"context_line":"        resource \u003d {"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_140108af","line":526,"range":{"start_line":526,"start_character":29,"end_line":526,"end_character":41},"in_reply_to":"3afc51ec_6851a162","updated":"2016-03-11 23:07:30.000000000","message":"Using this option alone would not be sufficient since we have promote replica tests where the replica becomes primary. The primary replica cannot be deleted by using delete_replica.","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b1c71a135b7ddda4d43da2e1eead3fd3c5a25b6b","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            \"client\": client,"},{"line_number":533,"context_line":"            \"share_id\": share_id,"},{"line_number":534,"context_line":"        }"},{"line_number":535,"context_line":"        if cleanup:"},{"line_number":536,"context_line":"            cls.method_resources.insert(0, resource)"},{"line_number":537,"context_line":"        client.wait_for_share_replica_status("},{"line_number":538,"context_line":"            replica[\"id\"], constants.STATUS_AVAILABLE)"},{"line_number":539,"context_line":"        return replica"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_c8e555a9","line":536,"range":{"start_line":535,"start_character":8,"end_line":536,"end_character":52},"updated":"2016-03-11 17:29:16.000000000","message":"if cleanup_in_class:\n            cls.class_resources.insert(0, resource)\n        else:\n            cls.method_resources.insert(0, resource)\n\nIt will allow you to not add redundant \"delete\" calls where you create replicas for whole test suite.","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"8f242b4ce3b608bca2e819cdd0209abb1ce21e4e","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            \"client\": client,"},{"line_number":533,"context_line":"            \"share_id\": share_id,"},{"line_number":534,"context_line":"        }"},{"line_number":535,"context_line":"        if cleanup:"},{"line_number":536,"context_line":"            cls.method_resources.insert(0, resource)"},{"line_number":537,"context_line":"        client.wait_for_share_replica_status("},{"line_number":538,"context_line":"            replica[\"id\"], constants.STATUS_AVAILABLE)"},{"line_number":539,"context_line":"        return replica"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_742ccc4a","line":536,"range":{"start_line":535,"start_character":8,"end_line":536,"end_character":52},"in_reply_to":"3afc51ec_c8e555a9","updated":"2016-03-11 23:07:30.000000000","message":"Done","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"}],"manila_tempest_tests/tests/api/test_replication.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools  # noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":"from tempest import test  # noqa"},{"line_number":20,"context_line":"from tempest_lib.common.utils import data_utils  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_61e3b934","line":17,"updated":"2015-11-20 14:53:34.000000000","message":"Remove empty line.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools  # noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":"from tempest import test  # noqa"},{"line_number":20,"context_line":"from tempest_lib.common.utils import data_utils  # noqa"},{"line_number":21,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_a1d9a185","line":18,"updated":"2015-11-20 14:53:34.000000000","message":"All noqa\u0027s should be removed.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"0ece8b272b3fad21f9f3ac526b785db8c1fa5f2c","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools  # noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":"from tempest import test  # noqa"},{"line_number":20,"context_line":"from tempest_lib.common.utils import data_utils  # noqa"},{"line_number":21,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c93599f7","line":18,"in_reply_to":"ba8a016a_a1d9a185","updated":"2015-11-25 19:26:05.000000000","message":"I can surely remove the noqa from all places but why do you have them in several other test files? What\u0027s a difference?","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            client\u003dcls.admin_client)"},{"line_number":61,"context_line":"        cls.share_type \u003d share_type[\"share_type\"]"},{"line_number":62,"context_line":"        # Create share with above share_type"},{"line_number":63,"context_line":"        cls.share1, cls.instance_id1 \u003d cls._create_share_get_instance()"},{"line_number":64,"context_line":"        cls.share2, cls.instance_id2 \u003d cls._create_share_get_instance()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        cls.replica1_zone \u003d cls._get_availability_zones_for_share_replica("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_c1db854e","line":63,"updated":"2015-11-20 14:53:34.000000000","message":"It will wait until creation of first share before creation of second. It can be created in parallel. See examples [1] and [2]. \n\n[1] https://review.openstack.org/#/c/247052/\n\n[2] https://github.com/openstack/manila/blob/master/manila_tempest_tests/tests/api/admin/test_share_manage.py","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        self.assertEqual(\u0027active\u0027, replica[\"replica_state\"])"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Delete the demoted replica so promoted replica can be cleaned"},{"line_number":266,"context_line":"        # during the cleanup"},{"line_number":267,"context_line":"        self.delete_replica(instance_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @test.attr(type\u003d[\"gate\", ])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_5ca9ba7a","line":266,"updated":"2015-11-20 14:53:34.000000000","message":"Same here, in case test fails earlier it will not be cleaned up.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"f492c0b01d993bc433798b831a016f450d3d99fe","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        self.assertEqual(\u0027active\u0027, replica[\"replica_state\"])"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # Delete the demoted replica so promoted replica can be cleaned"},{"line_number":266,"context_line":"        # during the cleanup"},{"line_number":267,"context_line":"        self.delete_replica(instance_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    @test.attr(type\u003d[\"gate\", ])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_31bacb6f","line":266,"in_reply_to":"ba8a016a_5ca9ba7a","updated":"2016-02-02 21:17:15.000000000","message":"See the response on the other test. Let me know if you think any other way to achieve clean run here in both cases(when the test pass/fail).","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila_tempest_tests import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":30,"context_line":"SUMMARY_KEYS \u003d [\u0027share_id\u0027, \u0027id\u0027, \u0027replica_state\u0027, \u0027status\u0027]"},{"line_number":31,"context_line":"DETAIL_KEYS \u003d SUMMARY_KEYS + [\u0027availability_zone\u0027, \u0027host\u0027, \u0027share_server_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_cfd7ecbd","line":28,"updated":"2016-02-04 06:38:37.000000000","message":"Already defined in manila_tempest_tests/tests/api/admin/test_replication.py . Can you move it to a common place?","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila_tempest_tests import utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":30,"context_line":"SUMMARY_KEYS \u003d [\u0027share_id\u0027, \u0027id\u0027, \u0027replica_state\u0027, \u0027status\u0027]"},{"line_number":31,"context_line":"DETAIL_KEYS \u003d SUMMARY_KEYS + [\u0027availability_zone\u0027, \u0027host\u0027, \u0027share_server_id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_935e0311","line":28,"in_reply_to":"5a5ae5dd_cfd7ecbd","updated":"2016-02-11 03:52:02.000000000","message":"added a constants file and moved it into that file","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":30,"context_line":"SUMMARY_KEYS \u003d [\u0027share_id\u0027, \u0027id\u0027, \u0027replica_state\u0027, \u0027status\u0027]"},{"line_number":31,"context_line":"DETAIL_KEYS \u003d SUMMARY_KEYS + [\u0027availability_zone\u0027, \u0027host\u0027, \u0027share_server_id\u0027,"},{"line_number":32,"context_line":"                              \u0027share_network_id\u0027, \u0027created_at\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_6fe6f8b5","line":29,"updated":"2016-02-04 06:38:37.000000000","message":"same here","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":30,"context_line":"SUMMARY_KEYS \u003d [\u0027share_id\u0027, \u0027id\u0027, \u0027replica_state\u0027, \u0027status\u0027]"},{"line_number":31,"context_line":"DETAIL_KEYS \u003d SUMMARY_KEYS + [\u0027availability_zone\u0027, \u0027host\u0027, \u0027share_server_id\u0027,"},{"line_number":32,"context_line":"                              \u0027share_network_id\u0027, \u0027created_at\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_339cefbf","line":29,"in_reply_to":"5a5ae5dd_6fe6f8b5","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4aceb157bf82a66f7e474333837c8f2b4ad6be75","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            for_share\u003dTrue, share_id\u003dself.shares[0][\"id\"])"},{"line_number":104,"context_line":"        # Ensure replica is created successfully"},{"line_number":105,"context_line":"        replica_ids \u003d [replica[\"id\"] for replica in share_replicas]"},{"line_number":106,"context_line":"        self.assertIn(share_replica[\"id\"], replica_ids)"},{"line_number":107,"context_line":"        return share_replica"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _verify_delete_replica(self, replica_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_88dda172","line":106,"updated":"2016-02-03 10:39:11.000000000","message":"shouldn\u0027t it also wait unitl the replica state is on a defined status?","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50ad9d39d2b640b71015935b4aee5e00a5512939","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            for_share\u003dTrue, share_id\u003dself.shares[0][\"id\"])"},{"line_number":104,"context_line":"        # Ensure replica is created successfully"},{"line_number":105,"context_line":"        replica_ids \u003d [replica[\"id\"] for replica in share_replicas]"},{"line_number":106,"context_line":"        self.assertIn(share_replica[\"id\"], replica_ids)"},{"line_number":107,"context_line":"        return share_replica"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _verify_delete_replica(self, replica_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_6f7941fc","line":106,"in_reply_to":"5a5ae5dd_88dda172","updated":"2016-02-03 14:13:17.000000000","message":"We\u0027ve a separate method for that: \n\nhttps://review.openstack.org/#/c/244843/5/manila_tempest_tests/services/share/v2/json/shares_client.py L#954","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"bbffbcd3c69e8d863282237b84f15136de7a5d4d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":114,"context_line":"                          self.shares_v2_client.get_share_replica,"},{"line_number":115,"context_line":"                          replica_id,"},{"line_number":116,"context_line":"                          version\u003d_MIN_SUPPORTED_MICRVERSION)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _verify_active_replica_count(self, share_id):"},{"line_number":119,"context_line":"        # List replicas"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_d2d2c9d1","line":116,"range":{"start_line":116,"start_character":26,"end_line":116,"end_character":33},"updated":"2016-02-16 21:16:22.000000000","message":"This assert is redundant.  The self.delete_replica() method calls wait_for_resource_deletion in the client which itself waits for a 404 return from get_share_replica.  That makes this whole method unnecessary, the tests could just call self.delete_replica directly","commit_id":"7806634e330ec28c1c2a36815938f203d7655519"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"bbffbcd3c69e8d863282237b84f15136de7a5d4d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":161,"context_line":"            self.shares[0][\"id\"], self.access_type, self.access_to, \u0027ro\u0027)"},{"line_number":162,"context_line":"        self.shares_v2_client.wait_for_access_rule_status("},{"line_number":163,"context_line":"            self.shares[0][\"id\"], rule[\"id\"], constants.REPLICA_STATE_ACTIVE)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # Create the replica"},{"line_number":166,"context_line":"        self._verify_create_replica()"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_2de2b49f","line":163,"range":{"start_line":163,"start_character":56,"end_line":163,"end_character":76},"updated":"2016-02-16 21:16:22.000000000","message":"use constants.RULE_STATE_ACTIVE","commit_id":"7806634e330ec28c1c2a36815938f203d7655519"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"bbffbcd3c69e8d863282237b84f15136de7a5d4d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            self.shares[0][\"id\"], rule[\"id\"], constants.REPLICA_STATE_ACTIVE)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # Create the replica"},{"line_number":166,"context_line":"        self._verify_create_replica()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        # delete rule and wait for deletion"},{"line_number":169,"context_line":"        self.shares_v2_client.delete_access_rule(self.shares[0][\"id\"],"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_cde98882","line":166,"range":{"start_line":166,"start_character":13,"end_line":166,"end_character":35},"updated":"2016-02-16 21:16:22.000000000","message":"This test should also verify that the rule state returns to active after the replica is created","commit_id":"7806634e330ec28c1c2a36815938f203d7655519"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"},{"line_number":35,"context_line":"                      \u0027Replication tests disabled.\u0027)"},{"line_number":36,"context_line":"@testtools.skipIf("},{"line_number":37,"context_line":"    CONF.share.max_api_microversion \u003c _MIN_SUPPORTED_MICROVERSION,"},{"line_number":38,"context_line":"    \u0027Max API microversion should be at least %s.\u0027"},{"line_number":39,"context_line":"    % _MIN_SUPPORTED_MICROVERSION)"},{"line_number":40,"context_line":"class ReplicationTest(base.BaseSharesTest):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_f0eed7b2","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":34},"updated":"2016-03-09 06:49:31.000000000","message":"It is incorrect comparison. Use following:\n\n\"\"\"\n\n@base.skip_if_microversion_lt(_MIN_SUPPORTED_MICROVERSION)\n\n\"\"\"\n\nor\n\n\"\"\"\n\n@utils.skip_if_microversion_lt(_MIN_SUPPORTED_MICROVERSION)\n\n\"\"\"","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"},{"line_number":35,"context_line":"                      \u0027Replication tests disabled.\u0027)"},{"line_number":36,"context_line":"@testtools.skipIf("},{"line_number":37,"context_line":"    CONF.share.max_api_microversion \u003c _MIN_SUPPORTED_MICROVERSION,"},{"line_number":38,"context_line":"    \u0027Max API microversion should be at least %s.\u0027"},{"line_number":39,"context_line":"    % _MIN_SUPPORTED_MICROVERSION)"},{"line_number":40,"context_line":"class ReplicationTest(base.BaseSharesTest):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_5a75af61","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":34},"in_reply_to":"5aef4532_f0eed7b2","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        cls.instance_id1 \u003d cls._get_instance(cls.shares[0])"},{"line_number":75,"context_line":"        cls.instance_id2 \u003d cls._get_instance(cls.shares[1])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        cls.access_type \u003d \"ip\""},{"line_number":78,"context_line":"        cls.access_to \u003d utils.rand_ip()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def _get_instance(cls, share):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_d0dc7be6","line":78,"range":{"start_line":77,"start_character":8,"end_line":78,"end_character":39},"updated":"2016-03-09 06:49:31.000000000","message":"Doing \"IP\" access you  should consider \"disable config option\" for IP rules and drivers that do not support it.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        cls.instance_id1 \u003d cls._get_instance(cls.shares[0])"},{"line_number":75,"context_line":"        cls.instance_id2 \u003d cls._get_instance(cls.shares[1])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        cls.access_type \u003d \"ip\""},{"line_number":78,"context_line":"        cls.access_to \u003d utils.rand_ip()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def _get_instance(cls, share):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_baa673be","line":78,"range":{"start_line":77,"start_character":8,"end_line":78,"end_character":39},"in_reply_to":"5aef4532_d0dc7be6","updated":"2016-03-10 20:24:58.000000000","message":"For now, the access rules tests are limited to \u0027NFS IP\u0027 rule. We will increase the coverage when other drivers are available.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.delete_share_replica(share_replica[\"id\"])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":136,"context_line":"    def test_add_access_rule_create_replica_delete_rule(self):"},{"line_number":137,"context_line":"        # Add access rule to the share"},{"line_number":138,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":139,"context_line":"            self.shares[0][\"id\"], self.access_type, self.access_to, \u0027ro\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_d08abbbe","line":136,"range":{"start_line":136,"start_character":4,"end_line":136,"end_character":62},"updated":"2016-03-09 06:49:31.000000000","message":"Such test should be \"access-rules type\" agnostic. Same below.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.delete_share_replica(share_replica[\"id\"])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":136,"context_line":"    def test_add_access_rule_create_replica_delete_rule(self):"},{"line_number":137,"context_line":"        # Add access rule to the share"},{"line_number":138,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":139,"context_line":"            self.shares[0][\"id\"], self.access_type, self.access_to, \u0027ro\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_9a9e1761","line":136,"range":{"start_line":136,"start_character":4,"end_line":136,"end_character":62},"in_reply_to":"5aef4532_d08abbbe","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":185,"context_line":"    def test_show_share_replica(self):"},{"line_number":186,"context_line":"        # Add the replica"},{"line_number":187,"context_line":"        share_replica \u003d self.create_share_replica(self.shares[0][\u0027id\u0027],"},{"line_number":188,"context_line":"                                                  self.replica_zone)"},{"line_number":189,"context_line":"        replica \u003d self.shares_v2_client.get_share_replica(share_replica[\"id\"])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        actual_keys \u003d replica.keys()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_906e73ff","line":188,"range":{"start_line":187,"start_character":8,"end_line":188,"end_character":68},"updated":"2016-03-09 06:49:31.000000000","message":"It is too heavy tests that create and delete replicas all the time. It is too heavy approach.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":185,"context_line":"    def test_show_share_replica(self):"},{"line_number":186,"context_line":"        # Add the replica"},{"line_number":187,"context_line":"        share_replica \u003d self.create_share_replica(self.shares[0][\u0027id\u0027],"},{"line_number":188,"context_line":"                                                  self.replica_zone)"},{"line_number":189,"context_line":"        replica \u003d self.shares_v2_client.get_share_replica(share_replica[\"id\"])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        actual_keys \u003d replica.keys()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_7a998b78","line":188,"range":{"start_line":187,"start_character":8,"end_line":188,"end_character":68},"in_reply_to":"5aef4532_906e73ff","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                                  self.replica_zone)"},{"line_number":189,"context_line":"        replica \u003d self.shares_v2_client.get_share_replica(share_replica[\"id\"])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        actual_keys \u003d replica.keys()"},{"line_number":192,"context_line":"        self.assertEqual(sorted(DETAIL_KEYS), sorted(actual_keys),"},{"line_number":193,"context_line":"                         \u0027Share Replica %s has incorrect keys; \u0027"},{"line_number":194,"context_line":"                         \u0027expected %s, got %s.\u0027 % (share_replica[\"id\"],"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_10838399","line":191,"range":{"start_line":191,"start_character":22,"end_line":191,"end_character":36},"updated":"2016-03-09 06:49:31.000000000","message":"Should be wrapped to \"list()\" for py3 compatibility.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                                  self.replica_zone)"},{"line_number":189,"context_line":"        replica \u003d self.shares_v2_client.get_share_replica(share_replica[\"id\"])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        actual_keys \u003d replica.keys()"},{"line_number":192,"context_line":"        self.assertEqual(sorted(DETAIL_KEYS), sorted(actual_keys),"},{"line_number":193,"context_line":"                         \u0027Share Replica %s has incorrect keys; \u0027"},{"line_number":194,"context_line":"                         \u0027expected %s, got %s.\u0027 % (share_replica[\"id\"],"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_da8a5f1a","line":191,"range":{"start_line":191,"start_character":22,"end_line":191,"end_character":36},"in_reply_to":"5aef4532_10838399","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        replica \u003d self.shares_v2_client.get_share_replica(share_replica[\"id\"])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        actual_keys \u003d replica.keys()"},{"line_number":192,"context_line":"        self.assertEqual(sorted(DETAIL_KEYS), sorted(actual_keys),"},{"line_number":193,"context_line":"                         \u0027Share Replica %s has incorrect keys; \u0027"},{"line_number":194,"context_line":"                         \u0027expected %s, got %s.\u0027 % (share_replica[\"id\"],"},{"line_number":195,"context_line":"                                                   sorted(DETAIL_KEYS),"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_105a634f","line":192,"range":{"start_line":192,"start_character":25,"end_line":192,"end_character":44},"updated":"2016-03-09 06:49:31.000000000","message":"\"sorted\" operation should be performed only once.","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        replica \u003d self.shares_v2_client.get_share_replica(share_replica[\"id\"])"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        actual_keys \u003d replica.keys()"},{"line_number":192,"context_line":"        self.assertEqual(sorted(DETAIL_KEYS), sorted(actual_keys),"},{"line_number":193,"context_line":"                         \u0027Share Replica %s has incorrect keys; \u0027"},{"line_number":194,"context_line":"                         \u0027expected %s, got %s.\u0027 % (share_replica[\"id\"],"},{"line_number":195,"context_line":"                                                   sorted(DETAIL_KEYS),"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_ba8dd332","line":192,"range":{"start_line":192,"start_character":25,"end_line":192,"end_character":44},"in_reply_to":"5aef4532_105a634f","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        # Promote the original replica back to active"},{"line_number":307,"context_line":"        self.promote_share_replica(original_replica[\u0027id\u0027])"},{"line_number":308,"context_line":"        self._verify_active_replica_count(share[\"id\"])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":311,"context_line":"    def test_active_replication_state(self):"},{"line_number":312,"context_line":"        # Verify the replica_state of first instance is set to active."}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_930afd1f","line":309,"updated":"2016-03-09 06:49:31.000000000","message":"self.shares_v2_client.wait_for_share_replica_status(\n            new_replica[\u0027id\u0027], constants.REPLICATION_STATE_IN_SYNC,\n            status_attr\u003d\u0027replica_state\u0027)","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        # Promote the original replica back to active"},{"line_number":307,"context_line":"        self.promote_share_replica(original_replica[\u0027id\u0027])"},{"line_number":308,"context_line":"        self._verify_active_replica_count(share[\"id\"])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":311,"context_line":"    def test_active_replication_state(self):"},{"line_number":312,"context_line":"        # Verify the replica_state of first instance is set to active."}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_5a7f6f14","line":309,"in_reply_to":"5aef4532_930afd1f","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e8361909e196f5c1d647395f664f3ea66d9b4759","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @classmethod"},{"line_number":339,"context_line":"    def resource_cleanup(cls):"},{"line_number":340,"context_line":"        # Delete replicas created in resource setup"},{"line_number":341,"context_line":"        cls.delete_share_replica(cls.replica1[\u0027id\u0027])"},{"line_number":342,"context_line":"        cls.delete_share_replica(cls.replica2[\u0027id\u0027])"},{"line_number":343,"context_line":"        super(ReplicationActionsTest, cls).resource_cleanup()"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_fdc61115","line":342,"range":{"start_line":341,"start_character":8,"end_line":342,"end_character":52},"updated":"2016-03-11 17:15:11.000000000","message":"Why do you need it when \"cls.create_share_replica\" already added it to \"delete\" queue?","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"8f242b4ce3b608bca2e819cdd0209abb1ce21e4e","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @classmethod"},{"line_number":339,"context_line":"    def resource_cleanup(cls):"},{"line_number":340,"context_line":"        # Delete replicas created in resource setup"},{"line_number":341,"context_line":"        cls.delete_share_replica(cls.replica1[\u0027id\u0027])"},{"line_number":342,"context_line":"        cls.delete_share_replica(cls.replica2[\u0027id\u0027])"},{"line_number":343,"context_line":"        super(ReplicationActionsTest, cls).resource_cleanup()"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_1418e81c","line":342,"range":{"start_line":341,"start_character":8,"end_line":342,"end_character":52},"in_reply_to":"3afc51ec_e8a5b1b5","updated":"2016-03-11 23:07:30.000000000","message":"Done","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"8f242b4ce3b608bca2e819cdd0209abb1ce21e4e","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @classmethod"},{"line_number":339,"context_line":"    def resource_cleanup(cls):"},{"line_number":340,"context_line":"        # Delete replicas created in resource setup"},{"line_number":341,"context_line":"        cls.delete_share_replica(cls.replica1[\u0027id\u0027])"},{"line_number":342,"context_line":"        cls.delete_share_replica(cls.replica2[\u0027id\u0027])"},{"line_number":343,"context_line":"        super(ReplicationActionsTest, cls).resource_cleanup()"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_341b641d","line":342,"range":{"start_line":341,"start_character":8,"end_line":342,"end_character":52},"in_reply_to":"3afc51ec_fdc61115","updated":"2016-03-11 23:07:30.000000000","message":"Done","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f1f9e10c70237383174c1874994b2ea1a4fc6e4c","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    @classmethod"},{"line_number":339,"context_line":"    def resource_cleanup(cls):"},{"line_number":340,"context_line":"        # Delete replicas created in resource setup"},{"line_number":341,"context_line":"        cls.delete_share_replica(cls.replica1[\u0027id\u0027])"},{"line_number":342,"context_line":"        cls.delete_share_replica(cls.replica2[\u0027id\u0027])"},{"line_number":343,"context_line":"        super(ReplicationActionsTest, cls).resource_cleanup()"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"3afc51ec_e8a5b1b5","line":342,"range":{"start_line":341,"start_character":8,"end_line":342,"end_character":52},"in_reply_to":"3afc51ec_fdc61115","updated":"2016-03-11 17:23:56.000000000","message":"Oh, I see. You added \"cleanup\" thing for some reason...\n\nLines 338-343 say that it was incorrect decision.\n\nBetter to follow same approach as all other \"create\" methods in base class - using class/method cleanups.","commit_id":"701ea9c938d3c28646ddca7d65bd9d9cf1418bb4"}],"manila_tempest_tests/tests/api/test_replication_negative.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools  # noqa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":"from tempest import test  # noqa"},{"line_number":20,"context_line":"from tempest_lib.common.utils import data_utils  # noqa"},{"line_number":21,"context_line":"from tempest_lib import exceptions as lib_exc  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_fc298ef3","line":18,"updated":"2015-11-20 14:53:34.000000000","message":"Same here as in other modules.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b773720e0272f78a943cfb8c271d874c81c5693a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            cls.share1[\"id\"])[0]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def _create_share_get_instance(cls):"},{"line_number":65,"context_line":"        share \u003d cls.create_share(share_type_id\u003dcls.share_type[\"id\"])"},{"line_number":66,"context_line":"        share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":67,"context_line":"            share[\"id\"], version\u003d\u00272.7\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_bcfc6673","line":64,"updated":"2015-11-20 14:53:34.000000000","message":"This is duplicated among several modules.","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"0ece8b272b3fad21f9f3ac526b785db8c1fa5f2c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            cls.share1[\"id\"])[0]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def _create_share_get_instance(cls):"},{"line_number":65,"context_line":"        share \u003d cls.create_share(share_type_id\u003dcls.share_type[\"id\"])"},{"line_number":66,"context_line":"        share_instances \u003d cls.admin_client.get_instances_of_share("},{"line_number":67,"context_line":"            share[\"id\"], version\u003d\u00272.7\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_2c223353","line":64,"in_reply_to":"ba8a016a_bcfc6673","updated":"2015-11-25 19:26:05.000000000","message":"What do you suggest?","commit_id":"6049b364a229d6f8f1b5ff1379b24a92dab20367"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":28,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_af7870c5","line":27,"updated":"2016-02-04 06:38:37.000000000","message":"already defined","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila_tempest_tests.tests.api import base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":28,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_3b64cb47","line":27,"in_reply_to":"5a5ae5dd_af7870c5","updated":"2016-02-11 03:52:02.000000000","message":"manila_tempest_tests lack a constants file.. I will add one and start with these constants..","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"d916149e9e97e1057a6d1f1ca47afcd31a164aa9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":28,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_6f827896","line":28,"updated":"2016-02-04 06:38:37.000000000","message":"already defined","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d740e703994bc92c5d825c937e93b943b568159","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"},{"line_number":27,"context_line":"REPLICATION_TYPE_CHOICES \u003d [\u0027writable\u0027, \u0027readable\u0027, \u0027dr\u0027]"},{"line_number":28,"context_line":"REPLICATION_PROMOTION_CHOICES \u003d [\u0027readable\u0027, \u0027dr\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_5b82e795","line":28,"in_reply_to":"5a5ae5dd_6f827896","updated":"2016-02-11 03:52:02.000000000","message":"Done","commit_id":"ac0ef30ae2fdd1374fe278ab2014ad9a29ee7ed8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"75cb0984b7c41d9d383c51784d50f3bb686fe325","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"},{"line_number":32,"context_line":"                      \u0027Replication tests disabled.\u0027)"},{"line_number":33,"context_line":"@testtools.skipIf("},{"line_number":34,"context_line":"    CONF.share.max_api_microversion \u003c _MIN_SUPPORTED_MICROVERSION,"},{"line_number":35,"context_line":"    \u0027Max API microversion should be at least %s.\u0027"},{"line_number":36,"context_line":"    % _MIN_SUPPORTED_MICROVERSION)"},{"line_number":37,"context_line":"class ReplicationNegativeTest(base.BaseSharesTest):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_5327d5b5","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":34},"updated":"2016-03-09 06:49:31.000000000","message":"Same as in https://review.openstack.org/#/c/244843/14/manila_tempest_tests/tests/api/test_replication.py","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"a562c3e430340f612b591b1a44314fa94c0a00f2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@testtools.skipUnless(CONF.share.run_replication_tests,"},{"line_number":32,"context_line":"                      \u0027Replication tests disabled.\u0027)"},{"line_number":33,"context_line":"@testtools.skipIf("},{"line_number":34,"context_line":"    CONF.share.max_api_microversion \u003c _MIN_SUPPORTED_MICROVERSION,"},{"line_number":35,"context_line":"    \u0027Max API microversion should be at least %s.\u0027"},{"line_number":36,"context_line":"    % _MIN_SUPPORTED_MICROVERSION)"},{"line_number":37,"context_line":"class ReplicationNegativeTest(base.BaseSharesTest):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_ba94b336","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":34},"in_reply_to":"5aef4532_5327d5b5","updated":"2016-03-10 20:24:58.000000000","message":"Done","commit_id":"58e64390cf5787e36618c77f7c5ae42ff8eb5685"}]}
