)]}'
{"manila_tempest_tests/tests/api/admin/test_consistency_group_actions.py":[{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"f1ecca886e8f5d0634ede819971f6ab4e4e73cc5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                \u0027consistency_group_id\u0027: self.consistency_group[\u0027id\u0027],"},{"line_number":80,"context_line":"                \u0027share_type_id\u0027: st_id,"},{"line_number":81,"context_line":"                \u0027version\u0027: v,"},{"line_number":82,"context_line":"            }} for st_id, v in ((self.share_type[\u0027id\u0027], \u00272.6\u0027),"},{"line_number":83,"context_line":"                                (self.share_type2[\u0027id\u0027],"},{"line_number":84,"context_line":"                                 CONF.share.max_api_microversion))"},{"line_number":85,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_58e6ea15","line":82,"updated":"2015-11-19 13:54:35.000000000","message":"This test is specifically 2.4 related, please do not use 2.6","commit_id":"9c240be12460b03a03f7a133fe8e01e8ed2c386e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"888e4a09410b9c27cfe8764ac23286e7429893d5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                \u0027consistency_group_id\u0027: self.consistency_group[\u0027id\u0027],"},{"line_number":80,"context_line":"                \u0027share_type_id\u0027: st_id,"},{"line_number":81,"context_line":"                \u0027version\u0027: v,"},{"line_number":82,"context_line":"            }} for st_id, v in ((self.share_type[\u0027id\u0027], \u00272.6\u0027),"},{"line_number":83,"context_line":"                                (self.share_type2[\u0027id\u0027],"},{"line_number":84,"context_line":"                                 CONF.share.max_api_microversion))"},{"line_number":85,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_38068652","line":82,"in_reply_to":"ba8a016a_58e6ea15","updated":"2015-11-19 14:01:33.000000000","message":"It is \"shares\" API, not CG. CG APIs use 2.4 as expected. The reason I use 2.6 here is in addressing your TODO. So, it is intentional change that does not contradict idea of CG testing.","commit_id":"9c240be12460b03a03f7a133fe8e01e8ed2c386e"},{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"c5a1bfde80f83e8d6ef27ab02bfef5683ac03523","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cg_shares \u003d self.shares_v2_client.list_shares("},{"line_number":88,"context_line":"            detailed\u003dTrue,"},{"line_number":89,"context_line":"            params\u003d{\u0027consistency_group_id\u0027: self.consistency_group[\u0027id\u0027]},"},{"line_number":90,"context_line":"            version\u003d\u00272.6\u0027,"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        cg_share_ids \u003d [s[\u0027id\u0027] for s in cg_shares]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_38ce8663","line":90,"updated":"2015-11-19 13:56:07.000000000","message":"same here, should be 2.4","commit_id":"9c240be12460b03a03f7a133fe8e01e8ed2c386e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"888e4a09410b9c27cfe8764ac23286e7429893d5","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cg_shares \u003d self.shares_v2_client.list_shares("},{"line_number":88,"context_line":"            detailed\u003dTrue,"},{"line_number":89,"context_line":"            params\u003d{\u0027consistency_group_id\u0027: self.consistency_group[\u0027id\u0027]},"},{"line_number":90,"context_line":"            version\u003d\u00272.6\u0027,"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        cg_share_ids \u003d [s[\u0027id\u0027] for s in cg_shares]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_f8fb1e45","line":90,"in_reply_to":"ba8a016a_38ce8663","updated":"2015-11-19 14:01:33.000000000","message":"see above.","commit_id":"9c240be12460b03a03f7a133fe8e01e8ed2c386e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f67608230eecaa2365af12f6aa22083896c42843","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                      source_cgsnapshot_id\u003dcgsnapshot[\u0027id\u0027],"},{"line_number":108,"context_line":"                                      version\u003d\u00272.4\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(akerr): Skip until bug 1483886 is resolved"},{"line_number":111,"context_line":"        # Verify that the new shares correspond to correct share types"},{"line_number":112,"context_line":"        # expected_share_types \u003d [self.share_type[\u0027id\u0027], self.share_type2["},{"line_number":113,"context_line":"        # \u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_ffbc9007","line":110,"updated":"2015-11-26 17:59:24.000000000","message":"AFAI understand this, a part of this test was commented for some expected behavior in the shares api.. and the API was changed to facilitate this in 2.6. \n\nInstead of this remaining commented, as you are refactoring this file anyway, would it make sense to either:\n\n1) Change the name of the test (remove _v2_4) and list shares again with 2.6 and uncomment these lines, or,\n\n2) Create a new _v2_6 test so we test this behavior?","commit_id":"429bd1fec6eeb2bbeed24fef6574aec5ee1b21ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0843860cb2b5ce869516595f07434a60e6574d57","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                      source_cgsnapshot_id\u003dcgsnapshot[\u0027id\u0027],"},{"line_number":108,"context_line":"                                      version\u003d\u00272.4\u0027)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(akerr): Skip until bug 1483886 is resolved"},{"line_number":111,"context_line":"        # Verify that the new shares correspond to correct share types"},{"line_number":112,"context_line":"        # expected_share_types \u003d [self.share_type[\u0027id\u0027], self.share_type2["},{"line_number":113,"context_line":"        # \u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_5e8efdd0","line":110,"in_reply_to":"9a8ffd7b_ffbc9007","updated":"2015-11-26 18:58:57.000000000","message":"Not related to the goal of commit.","commit_id":"429bd1fec6eeb2bbeed24fef6574aec5ee1b21ae"}],"manila_tempest_tests/tests/api/test_consistency_group_actions.py":[{"author":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"change_message_id":"f1ecca886e8f5d0634ede819971f6ab4e4e73cc5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        cls.share_size \u003d 1"},{"line_number":58,"context_line":"        cls.share_size2 \u003d 2"},{"line_number":59,"context_line":"        # NOTE(vponomaryov): shares should be created using 2.6+ versions"},{"line_number":60,"context_line":"        # to have all required keys in created objects."},{"line_number":61,"context_line":"        cls.shares \u003d cls.create_shares(["},{"line_number":62,"context_line":"            {\u0027kwargs\u0027: {"},{"line_number":63,"context_line":"                \u0027name\u0027: cls.share_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_38b3e651","line":60,"updated":"2015-11-19 13:54:35.000000000","message":"If you don\u0027t request a version it will use the latest by default.  It would probably be best not to force the resource setup methods into a specific version whenever possible.","commit_id":"9c240be12460b03a03f7a133fe8e01e8ed2c386e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"888e4a09410b9c27cfe8764ac23286e7429893d5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        cls.share_size \u003d 1"},{"line_number":58,"context_line":"        cls.share_size2 \u003d 2"},{"line_number":59,"context_line":"        # NOTE(vponomaryov): shares should be created using 2.6+ versions"},{"line_number":60,"context_line":"        # to have all required keys in created objects."},{"line_number":61,"context_line":"        cls.shares \u003d cls.create_shares(["},{"line_number":62,"context_line":"            {\u0027kwargs\u0027: {"},{"line_number":63,"context_line":"                \u0027name\u0027: cls.share_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_1872a211","line":60,"in_reply_to":"ba8a016a_38b3e651","updated":"2015-11-19 14:01:33.000000000","message":"It is intentional. After addon of one more microversion, we will cover more than one microversion here not implementing additional test coverage.","commit_id":"9c240be12460b03a03f7a133fe8e01e8ed2c386e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f67608230eecaa2365af12f6aa22083896c42843","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                    self.assertEqual(share[\u0027size\u0027], member[\u0027size\u0027])"},{"line_number":248,"context_line":"                    self.assertEqual(share[\u0027share_proto\u0027],"},{"line_number":249,"context_line":"                                     member[\u0027share_protocol\u0027])"},{"line_number":250,"context_line":"                    # TODO(akerr): Add back assert when bug 1483886 is fixed"},{"line_number":251,"context_line":"                    # self.assertEqual(share[\u0027share_type\u0027],"},{"line_number":252,"context_line":"                    #                  member[\u0027share_type_id\u0027])"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_bf3928a6","line":250,"updated":"2015-11-26 17:59:24.000000000","message":"Same here.","commit_id":"429bd1fec6eeb2bbeed24fef6574aec5ee1b21ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0843860cb2b5ce869516595f07434a60e6574d57","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                    self.assertEqual(share[\u0027size\u0027], member[\u0027size\u0027])"},{"line_number":248,"context_line":"                    self.assertEqual(share[\u0027share_proto\u0027],"},{"line_number":249,"context_line":"                                     member[\u0027share_protocol\u0027])"},{"line_number":250,"context_line":"                    # TODO(akerr): Add back assert when bug 1483886 is fixed"},{"line_number":251,"context_line":"                    # self.assertEqual(share[\u0027share_type\u0027],"},{"line_number":252,"context_line":"                    #                  member[\u0027share_type_id\u0027])"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_febd7168","line":250,"in_reply_to":"9a8ffd7b_bf3928a6","updated":"2015-11-26 18:58:57.000000000","message":"Not related to the goal of commit.","commit_id":"429bd1fec6eeb2bbeed24fef6574aec5ee1b21ae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f67608230eecaa2365af12f6aa22083896c42843","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                    self.assertEqual(member[\u0027size\u0027], share[\u0027size\u0027])"},{"line_number":290,"context_line":"                    self.assertEqual(member[\u0027share_protocol\u0027],"},{"line_number":291,"context_line":"                                     share[\u0027share_proto\u0027])"},{"line_number":292,"context_line":"                    # TODO(akerr): Add back assert when bug 1483886 is fixed"},{"line_number":293,"context_line":"                    # self.assertEqual(member[\u0027share_type_id\u0027],"},{"line_number":294,"context_line":"                    #                  share[\u0027share_type\u0027])"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_5f5efc44","line":292,"updated":"2015-11-26 17:59:24.000000000","message":"and here","commit_id":"429bd1fec6eeb2bbeed24fef6574aec5ee1b21ae"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0843860cb2b5ce869516595f07434a60e6574d57","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                    self.assertEqual(member[\u0027size\u0027], share[\u0027size\u0027])"},{"line_number":290,"context_line":"                    self.assertEqual(member[\u0027share_protocol\u0027],"},{"line_number":291,"context_line":"                                     share[\u0027share_proto\u0027])"},{"line_number":292,"context_line":"                    # TODO(akerr): Add back assert when bug 1483886 is fixed"},{"line_number":293,"context_line":"                    # self.assertEqual(member[\u0027share_type_id\u0027],"},{"line_number":294,"context_line":"                    #                  share[\u0027share_type\u0027])"},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a8ffd7b_1ec395ee","line":292,"in_reply_to":"9a8ffd7b_5f5efc44","updated":"2015-11-26 18:58:57.000000000","message":"Not related to the goal of commit.","commit_id":"429bd1fec6eeb2bbeed24fef6574aec5ee1b21ae"}]}