)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS support for shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Qos is a common attribute, so add the Qos"},{"line_number":10,"context_line":"capability in common capabilities doc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp manila-support-qos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_0d70aadb","line":9,"updated":"2015-12-10 13:30:01.000000000","message":"s/Qos/QoS","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS support for shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Qos is a common attribute, so add the Qos"},{"line_number":10,"context_line":"capability in common capabilities doc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp manila-support-qos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_f83a8c33","line":9,"in_reply_to":"7a740942_0d70aadb","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e2cce03f6d190284cdadd34f9c432802616ae15d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS support for shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Qos is a common attribute, so add the Qos"},{"line_number":10,"context_line":"capability in common capabilities doc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp manila-support-qos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_32e588a3","line":9,"updated":"2015-12-11 11:57:41.000000000","message":"s/Qos/QoS","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca12c0caa61a67cbb70568b33036a930eebacea9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS support for shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Qos is a common attribute, so add the Qos"},{"line_number":10,"context_line":"capability in common capabilities doc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp manila-support-qos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_469b7d18","line":9,"in_reply_to":"7a740942_32e588a3","updated":"2015-12-13 13:59:03.000000000","message":"Done","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a84382fe48c1fe4134f63f7ac0c66bcac5bb5f5c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"QoS is a common attribute, so add the QoS"},{"line_number":10,"context_line":"capability in common capabilities doc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp manila-support-qos"},{"line_number":13,"context_line":"Change-Id: I377bf0abcc62239c9a1a5ee5c28c336b2b6c410a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a740942_73874461","line":12,"updated":"2015-12-14 10:43:50.000000000","message":"I recommend either changing this to \"partially implements\" and change the respective blueprint to say something that this is a simple first step towards what the blueprints proposes, or just remove the blueprint entry in the commit message.","commit_id":"dde8aa4f61b274054d68169c339a3f97bd1afe40"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b0649dcc97279ee8818d975b98bb93911bc46371","unresolved":false,"context_lines":[{"line_number":9,"context_line":"QoS is a common attribute, so add the QoS"},{"line_number":10,"context_line":"capability in common capabilities doc."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: bp manila-support-qos"},{"line_number":13,"context_line":"Change-Id: I377bf0abcc62239c9a1a5ee5c28c336b2b6c410a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a710552_d19028ef","line":12,"in_reply_to":"7a740942_73874461","updated":"2015-12-15 07:30:56.000000000","message":"Done","commit_id":"dde8aa4f61b274054d68169c339a3f97bd1afe40"}],"doc/source/devref/capabilities_and_extra_specs.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0d5191ba194dfa1d9b126ef64f8fb5ffcee71ee8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `qos` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_d8050514","line":88,"updated":"2015-11-19 11:13:38.000000000","message":"Please make changes to the minimum driver requirements document as well.","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"84eb92702e4712848b3f8c35f55b0039957479d2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `qos` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_c1d6704e","line":88,"in_reply_to":"ba8a016a_d8050514","updated":"2015-11-19 11:51:38.000000000","message":"Done","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0d5191ba194dfa1d9b126ef64f8fb5ffcee71ee8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Administrators can setting common qos attributes in share type:"},{"line_number":99,"context_line":"        `qos:max_iops` is the max iops value can not be exceed."},{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_18062d52","line":99,"updated":"2015-11-19 11:13:38.000000000","message":"s/exceed/exceeded. Needs a conjunction here, such as \"that can not be exceeded\", or \"value, and can not be exceeded\".","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"84eb92702e4712848b3f8c35f55b0039957479d2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Administrators can setting common qos attributes in share type:"},{"line_number":99,"context_line":"        `qos:max_iops` is the max iops value can not be exceed."},{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_41dcc072","line":99,"in_reply_to":"ba8a016a_18062d52","updated":"2015-11-19 11:51:38.000000000","message":"Done","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0d5191ba194dfa1d9b126ef64f8fb5ffcee71ee8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 is means the max value can not be exceed."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 is means the min value is a soft limit, that"},{"line_number":105,"context_line":"        make the current value is larger than the minimum value as large as"},{"line_number":106,"context_line":"        possible."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_f8f6c95b","line":103,"updated":"2015-11-19 11:13:38.000000000","message":"s/is means/means. s/exceed/exceeded.","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"84eb92702e4712848b3f8c35f55b0039957479d2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 is means the max value can not be exceed."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 is means the min value is a soft limit, that"},{"line_number":105,"context_line":"        make the current value is larger than the minimum value as large as"},{"line_number":106,"context_line":"        possible."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_c13d1090","line":103,"in_reply_to":"ba8a016a_f8f6c95b","updated":"2015-11-19 11:51:38.000000000","message":"Done","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0d5191ba194dfa1d9b126ef64f8fb5ffcee71ee8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 is means the max value can not be exceed."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 is means the min value is a soft limit, that"},{"line_number":105,"context_line":"        make the current value is larger than the minimum value as large as"},{"line_number":106,"context_line":"        possible."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_583a75e8","line":104,"updated":"2015-11-19 11:13:38.000000000","message":"s/is means/means. s/make/makes. Also, I am having a hard time understanding this description. Could you please re-phrase?","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"84eb92702e4712848b3f8c35f55b0039957479d2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 is means the max value can not be exceed."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 is means the min value is a soft limit, that"},{"line_number":105,"context_line":"        make the current value is larger than the minimum value as large as"},{"line_number":106,"context_line":"        possible."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_414a8027","line":104,"in_reply_to":"ba8a016a_583a75e8","updated":"2015-11-19 11:51:38.000000000","message":"Done","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"0d5191ba194dfa1d9b126ef64f8fb5ffcee71ee8","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        make the current value is larger than the minimum value as large as"},{"line_number":106,"context_line":"        possible."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Administrators can also setting there own qos attributes."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Reporting Capabilities"},{"line_number":111,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_98669d28","line":108,"updated":"2015-11-19 11:13:38.000000000","message":"s/there/their","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"84eb92702e4712848b3f8c35f55b0039957479d2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        make the current value is larger than the minimum value as large as"},{"line_number":106,"context_line":"        possible."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Administrators can also setting there own qos attributes."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Reporting Capabilities"},{"line_number":111,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba8a016a_a1d32c5f","line":108,"in_reply_to":"ba8a016a_98669d28","updated":"2015-11-19 11:51:38.000000000","message":"Done","commit_id":"ef2f5fca0dc6b549997d75f0e50fcc83b16e6db9"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cdc37383e56aa9b5a52dde7506217bb791dbe7ae","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `qos` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_477b7028","line":88,"updated":"2015-11-19 12:31:09.000000000","message":"According to our latest meeting, which we did not decide on any specific approach, we talked about having something like \"huawei_qos\u003dTrue, huawei_min_iops\u003d10000, netapp_qos\u003dFalse\" etc. What you are proposing in this spec is the standard extra specs that would be the same for all vendors, I am not sure if I agree on this approach yet.","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa3686c343ccb10f944486cbbde88f615311d4de","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `qos` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a740942_c0d6eac2","line":88,"in_reply_to":"ba8a016a_477b7028","updated":"2015-12-10 12:49:15.000000000","message":"Just add the already exist QoS_support flag. :)\nhttps://github.com/openstack/manila/blob/master/manila/scheduler/host_manager.py#L111\n\n##https://github.com/openstack/manila/blob/master/manila/share/drivers/hpe/hpe_3par_driver.py#L391\n##https://github.com/openstack/manila/blob/master/manila/share/drivers/hitachi/hds_hnas.py#L354\n##https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L257","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1169062904c547032a29096e34a2a8f04a784650","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"  ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Administrators can setting common qos attributes in share type:"},{"line_number":99,"context_line":"        `qos:max_iops` is the max iops value that can not be exceeded. "},{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_912f413e","line":98,"updated":"2015-11-19 16:44:22.000000000","message":"s/setting/set/","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1169062904c547032a29096e34a2a8f04a784650","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Administrators can setting common qos attributes in share type:"},{"line_number":99,"context_line":"        `qos:max_iops` is the max iops value that can not be exceeded. "},{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_311f7509","line":99,"updated":"2015-11-19 16:44:22.000000000","message":"s/can not/cannot/","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cdc37383e56aa9b5a52dde7506217bb791dbe7ae","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  ::"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Administrators can setting common qos attributes in share type:"},{"line_number":99,"context_line":"        `qos:max_iops` is the max iops value that can not be exceeded. "},{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_acbd63d9","line":99,"updated":"2015-11-19 12:31:09.000000000","message":"trailing whitespace","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1169062904c547032a29096e34a2a8f04a784650","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        `qos:max_iops` is the max iops value that can not be exceeded. "},{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 means the max value can not be exceeded."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 means the min value is a soft limit, that"},{"line_number":105,"context_line":"        makes the actual value is larger than the min value as large as"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_d1f069cb","line":102,"updated":"2015-11-19 16:44:22.000000000","message":"s/. the/. The/   (above 2 lines)","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cdc37383e56aa9b5a52dde7506217bb791dbe7ae","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        `qos:min_iops` is the min iops value."},{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 means the max value can not be exceeded."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 means the min value is a soft limit, that"},{"line_number":105,"context_line":"        makes the actual value is larger than the min value as large as"},{"line_number":106,"context_line":"        possible."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_6c0bfb7d","line":103,"updated":"2015-11-19 12:31:09.000000000","message":"s/\u0027Max_\u0027/\u0027max_\u0027","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cdc37383e56aa9b5a52dde7506217bb791dbe7ae","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        `qos:max_bandwith` is the max bandwith value. the unit is in MB/s."},{"line_number":102,"context_line":"        `qos:min_bandwith` is the min bandwith value. the unit is in MB/s."},{"line_number":103,"context_line":"        max: The prefix \u0027Max_\u0027 means the max value can not be exceeded."},{"line_number":104,"context_line":"        min: The prefix \u0027min_\u0027 means the min value is a soft limit, that"},{"line_number":105,"context_line":"        makes the actual value is larger than the min value as large as"},{"line_number":106,"context_line":"        possible."},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_8722b8a1","line":104,"updated":"2015-11-19 12:31:09.000000000","message":"Sorry but it is still not clear to me. As far as I understand about QoS, if the driver/administrator specifies a minimum IOPS of 30k, the user will have guaranteed minimum of 30k, he should never see a throughput lower than 30k IOPS. I would use these words in order to avoid confusion. Something like:\n\n\"min: The prefix \u0027min_\u0027 means the min value is the minimum guaranteed value.\"","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cdc37383e56aa9b5a52dde7506217bb791dbe7ae","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        makes the actual value is larger than the min value as large as"},{"line_number":106,"context_line":"        possible."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        Administrators can also setting their own qos attributes."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Reporting Capabilities"},{"line_number":111,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba8a016a_4c94f741","line":108,"updated":"2015-11-19 12:31:09.000000000","message":"s/setting/set. Sorry about not pointing this out on earlier patch.","commit_id":"912000575b909238d1b6a7e6ac0552080bcc1643"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_4d3472fa","line":89,"updated":"2015-12-10 13:30:01.000000000","message":"s/qos(Quality of service)/QoS(Quality of Service)\n\ns/qos/QoS_support","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_7231de0a","line":89,"in_reply_to":"7a740942_4d3472fa","updated":"2015-12-11 06:57:13.000000000","message":"+1 and add a space before the (","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_7863fc41","line":89,"in_reply_to":"7a740942_4d3472fa","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_185af883","line":89,"in_reply_to":"7a740942_7231de0a","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_30d05d53","line":91,"updated":"2015-12-10 13:30:01.000000000","message":"I am not sure this is not true at this moment, drivers cannot report both true and false for this capability as far as I know, something like [True, False]. I think Clinton implemented this but I don\u0027t know if this applies to QoS.","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_d22a1290","line":91,"in_reply_to":"7a740942_30d05d53","updated":"2015-12-11 06:57:13.000000000","message":"+1  The current wording makes is sound like it can be both.  Please clarify because I think it is only true or false for now.  When set to True the driver might still do no QoS because of what the scoped extra-specs say.","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_13a5f902","line":91,"in_reply_to":"7a740942_30d05d53","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_539b81c9","line":91,"in_reply_to":"7a740942_d22a1290","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_d0bf99fa","line":92,"updated":"2015-12-10 13:30:01.000000000","message":"s/qos/QoS","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_136e59c9","line":92,"in_reply_to":"7a740942_cd183378","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_f3638ddb","line":92,"in_reply_to":"7a740942_d0bf99fa","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  qos(Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_cd183378","line":92,"in_reply_to":"7a740942_d0bf99fa","updated":"2015-12-11 06:57:13.000000000","message":"s/use qos/use a backend that has QoS support/","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_d046b920","line":93,"updated":"2015-12-10 13:30:01.000000000","message":"s/qos/QoS","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_934b2959","line":93,"in_reply_to":"7a740942_0d363be7","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_b346654d","line":93,"in_reply_to":"7a740942_d046b920","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Drivers can report"},{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_0d363be7","line":93,"in_reply_to":"7a740942_d046b920","updated":"2015-12-11 06:57:13.000000000","message":"s/using qos/using a backend that has QoS support/","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"289287a0c39f41a13081e0caa59905c050efe023","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_5bfe5eaf","line":94,"updated":"2015-12-10 17:06:20.000000000","message":"My proposal (including Rodrigo\u0027s suggestions)\n\n `QoS_support` - indicates that a backend/pool can provide shares using some\n QoS (Quality of service) specification. The default value of the QoS_support\n capability (if a driver doesn\u0027t report it) is False. Administrators\n can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and\n also setting the relevant QoS-related extra specs for the drivers being used.\n Administrators can prevent a share type from using QoS by setting this\n extra-spec to \u0027\u003cis\u003e False\u0027. Different drivers have different ways to specifying\n QoS limits (or guarantees) and this extra spec merely allows the scheduler to\n filter by pools that either have or don\u0027t have QoS support enabled. Added in\n Mitaka (although exists undocumented in earlier releases).","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_506169a7","line":94,"updated":"2015-12-10 13:30:01.000000000","message":"Not really added in Mitaka... just documented in Mitaka.","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_534dc170","line":94,"in_reply_to":"7a740942_0d92bb9f","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_73e0fdcc","line":94,"in_reply_to":"7a740942_2da53703","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_f33cedc0","line":94,"in_reply_to":"7a740942_506169a7","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"edf7808fa130c4e87e961dd9a0b2d5696d54b019","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_972fc387","line":94,"in_reply_to":"7a740942_506169a7","updated":"2015-12-10 14:37:13.000000000","message":"Sorry, I meant it has been around before Mitaka. I suggest removing \"Added in Mitaka.\"","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_7350fd0a","line":94,"in_reply_to":"7a740942_5bfe5eaf","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_0d92bb9f","line":94,"in_reply_to":"7a740942_5bfe5eaf","updated":"2015-12-11 06:57:13.000000000","message":"s/to specifying/of specifying/","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_335a752b","line":94,"in_reply_to":"7a740942_972fc387","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  to the scheduler that they support both qos and non-qos. Administrators"},{"line_number":92,"context_line":"  can make a share type use qos by setting this extra-spec to \u0027\u003cis\u003e True\u0027."},{"line_number":93,"context_line":"  Administrators can prevent a share type from using qos by setting this"},{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Added in Mitaka."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Reporting Capabilities"},{"line_number":97,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_2da53703","line":94,"in_reply_to":"7a740942_972fc387","updated":"2015-12-11 06:57:13.000000000","message":"Maybe double check. I didn\u0027t think it was really used. If it is only set to false in drivers (copied from Cinder and from each other) then it would be good to say Added in Mitaka.  If anyone really used it, then I agree with Rodrigo.","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":132,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":133,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":134,"context_line":"             \u0027qos\u0027: True,                        #"},{"line_number":135,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":136,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"},{"line_number":137,"context_line":"                                                 #/"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_ade7e73e","line":134,"updated":"2015-12-11 06:57:13.000000000","message":"remove this.  QoS_support is above.  I haven\u0027t seen a proposal to change that name yet.","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":131,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":132,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":133,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":134,"context_line":"             \u0027qos\u0027: True,                        #"},{"line_number":135,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":136,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"},{"line_number":137,"context_line":"                                                 #/"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_b31505e6","line":134,"in_reply_to":"7a740942_ade7e73e","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            {\u0027pool_name\u0027: \u0027thick pool\u0027,"},{"line_number":144,"context_line":"             \u0027total_capacity_gb\u0027: 1024,"},{"line_number":145,"context_line":"             \u0027free_capacity_gb\u0027: 1024,"},{"line_number":146,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,"},{"line_number":147,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":148,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":149,"context_line":"             \u0027compression\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_0dc07b7b","line":146,"updated":"2015-12-11 06:57:13.000000000","message":"Maybe make this one \u0027True\u0027 and # this backend support QoS","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            {\u0027pool_name\u0027: \u0027thick pool\u0027,"},{"line_number":144,"context_line":"             \u0027total_capacity_gb\u0027: 1024,"},{"line_number":145,"context_line":"             \u0027free_capacity_gb\u0027: 1024,"},{"line_number":146,"context_line":"             \u0027QoS_support\u0027: \u0027False\u0027,"},{"line_number":147,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":148,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":149,"context_line":"             \u0027compression\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_13b099dc","line":146,"in_reply_to":"7a740942_0dc07b7b","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"d9d3a223a2be789f4598e6feb1c06d83a1bcc2fd","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":149,"context_line":"             \u0027compression\u0027: False,"},{"line_number":150,"context_line":"             \u0027thin_provisioning\u0027: False,"},{"line_number":151,"context_line":"             \u0027qos\u0027: False,"},{"line_number":152,"context_line":"             \u0027my_dying_disks\u0027: 200,"},{"line_number":153,"context_line":"             \u0027my_super_hero_1\u0027: \u0027Batman\u0027,"},{"line_number":154,"context_line":"             \u0027my_super_hero_2\u0027: \u0027Robin\u0027,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_cde2732f","line":151,"updated":"2015-12-11 06:57:13.000000000","message":"same here","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":148,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":149,"context_line":"             \u0027compression\u0027: False,"},{"line_number":150,"context_line":"             \u0027thin_provisioning\u0027: False,"},{"line_number":151,"context_line":"             \u0027qos\u0027: False,"},{"line_number":152,"context_line":"             \u0027my_dying_disks\u0027: 200,"},{"line_number":153,"context_line":"             \u0027my_super_hero_1\u0027: \u0027Batman\u0027,"},{"line_number":154,"context_line":"             \u0027my_super_hero_2\u0027: \u0027Robin\u0027,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_53baa1e2","line":151,"in_reply_to":"7a740942_cde2732f","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bcca4a44c12052d48c08491620a7388e729cd905","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                                 #\\"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":134,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":135,"context_line":"             \u0027QoS_support\u0027: True                 # this backend support QoS"},{"line_number":136,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":137,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":138,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_81cc16bc","line":135,"updated":"2015-12-11 17:18:37.000000000","message":"s/support/supports/","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca12c0caa61a67cbb70568b33036a930eebacea9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                                 #\\"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":134,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":135,"context_line":"             \u0027QoS_support\u0027: True                 # this backend support QoS"},{"line_number":136,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":137,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":138,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_66e239a2","line":135,"in_reply_to":"7a740942_81cc16bc","updated":"2015-12-13 13:59:03.000000000","message":"But in our code, the flag is QoS_support.(link: https://github.com/openstack/manila/blob/master/manila/scheduler/host_manager.py#L111) \nIf it will be changed in Manila code, I will open another bug to change all of the QoS flag in Manila code.","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"feb4991d05f6b2dc902c7c703f87c807475af82f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                                 #\\"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":134,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":135,"context_line":"             \u0027QoS_support\u0027: True                 # this backend support QoS"},{"line_number":136,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":137,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":138,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_c11e770b","line":135,"in_reply_to":"7a740942_81cc16bc","updated":"2015-12-13 14:50:49.000000000","message":"Sorry, I misunderstood what you mean， I have been addressed in patch #8.","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"19f48f4b98bba1d38d873aaad90d6a5d2427e06d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                                 #\\"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":134,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":135,"context_line":"             \u0027QoS_support\u0027: True                 # this backend support QoS"},{"line_number":136,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":137,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":138,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_0599e478","line":135,"in_reply_to":"7a740942_c11e770b","updated":"2015-12-14 02:52:18.000000000","message":"Oops. I\u0027m sorry about that. I should have been more clear.","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7fa1d6c115a941fe2326e1e660f10b7c5bf9916d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                                 #\\"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":134,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":135,"context_line":"             \u0027QoS_support\u0027: True                 # this backend supports QoS"},{"line_number":136,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":137,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":138,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a710552_26a9cc90","line":135,"updated":"2015-12-16 16:43:47.000000000","message":"missing trailing comma","commit_id":"2b19d2975f87345da046064a88a8f58996a21310"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8e38b8a9f613564acb857ef65e77e80b91a8d858","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the QoS_support"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a7b0d38_79ddaa6f","line":88,"range":{"start_line":88,"start_character":3,"end_line":88,"end_character":14},"updated":"2015-12-22 20:07:28.000000000","message":"Having \u0027support\u0027 in this flag name is redundant, and not everyone understands what \u0027QoS\u0027 is, so can we just make it self-documenting by calling it \u0027quality_of_service\u0027.","commit_id":"0ba5ddb58af28f79498add59dc18ea4af0836d7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fd620282f84c354cff1612152a9572ff9660e017","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the QoS_support"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a7b0d38_bca3f69d","line":88,"range":{"start_line":88,"start_character":3,"end_line":88,"end_character":14},"in_reply_to":"1a7b0d38_79ddaa6f","updated":"2015-12-23 03:16:29.000000000","message":"@Clinton Knight: Thanks for your review. \n\nI just want to remain consistent with the code name. If change QoS_support to quality_of_service, I am not sure whether the other guys know quality_of_service is correspond to QoS_support(In the code). May be it will be not consistent with the other capabilities that just use the code name.(such as thin_provisioning, compression)\n\nIs it ok? I explained what is QoS in line 89(Quality of service).","commit_id":"0ba5ddb58af28f79498add59dc18ea4af0836d7f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f0d09285dc2463a9c1bd0d87f040ad4fa1f222d8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  thick. So, a Manila pool will always report thin_provisioning as True or"},{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `QoS_support` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the QoS_support"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a7b0d38_bf20c84a","line":88,"range":{"start_line":88,"start_character":3,"end_line":88,"end_character":14},"in_reply_to":"1a7b0d38_79ddaa6f","updated":"2015-12-23 03:29:17.000000000","message":"Done","commit_id":"0ba5ddb58af28f79498add59dc18ea4af0836d7f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"3c2e3e066078db8a6c0d14b5ebb6fcfbbe4d690e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `quality_of_service` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the QoS_support"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"},{"line_number":92,"context_line":"  also setting the relevant QoS-related extra specs for the drivers being used."}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a7b0d38_7f1a6019","line":89,"range":{"start_line":89,"start_character":67,"end_line":89,"end_character":78},"updated":"2015-12-23 03:32:18.000000000","message":"s/Quality/quality/  s/QoS_support/quality_of_service/","commit_id":"be70542056c9ac68bc44f445156f158470fde48a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4f97296c40da00d4624b588d506f43578640c14d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `quality_of_service` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the QoS_support"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"},{"line_number":92,"context_line":"  also setting the relevant QoS-related extra specs for the drivers being used."}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a7b0d38_dfc7d443","line":89,"range":{"start_line":89,"start_character":67,"end_line":89,"end_character":78},"in_reply_to":"1a7b0d38_7f1a6019","updated":"2015-12-23 03:37:43.000000000","message":"Can we just use the QoS_support(In the code). Then we will discuss the name in the next IRC meeting. and open a bug to change the all of the name in Manila code and doc?","commit_id":"be70542056c9ac68bc44f445156f158470fde48a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"3c2e3e066078db8a6c0d14b5ebb6fcfbbe4d690e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                                                 #\\"},{"line_number":133,"context_line":"             \u0027dedupe\u0027: True,                     # common capabilities"},{"line_number":134,"context_line":"             \u0027compression\u0027: True,                #"},{"line_number":135,"context_line":"             \u0027QoS_support\u0027: True,                # this backend supports QoS"},{"line_number":136,"context_line":"             \u0027thin_provisioning\u0027: True,          #"},{"line_number":137,"context_line":"             \u0027max_over_subscription_ratio\u0027: 10,  # (mandatory for thin)"},{"line_number":138,"context_line":"             \u0027provisioned_capacity_gb\u0027: 270,     # (mandatory for thin)"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a7b0d38_5fd8c453","line":135,"range":{"start_line":135,"start_character":14,"end_line":135,"end_character":25},"updated":"2015-12-23 03:32:18.000000000","message":"s/QoS_support/quality_of_service/","commit_id":"be70542056c9ac68bc44f445156f158470fde48a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"3c2e3e066078db8a6c0d14b5ebb6fcfbbe4d690e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            {\u0027pool_name\u0027: \u0027thick pool\u0027,"},{"line_number":146,"context_line":"             \u0027total_capacity_gb\u0027: 1024,"},{"line_number":147,"context_line":"             \u0027free_capacity_gb\u0027: 1024,"},{"line_number":148,"context_line":"             \u0027QoS_support\u0027: False,"},{"line_number":149,"context_line":"             \u0027reserved_percentage\u0027: 0,"},{"line_number":150,"context_line":"             \u0027dedupe\u0027: False,"},{"line_number":151,"context_line":"             \u0027compression\u0027: False,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a7b0d38_ffdc1048","line":148,"updated":"2015-12-23 03:32:18.000000000","message":"same","commit_id":"be70542056c9ac68bc44f445156f158470fde48a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"757584c64b6569d66758f586e86f63c5bf9f04f0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Different drivers have different ways of specifying"},{"line_number":95,"context_line":"  QoS limits (or guarantees) and this extra spec merely allows the scheduler to"},{"line_number":96,"context_line":"  filter by pools that either have or don\u0027t have QoS support enabled. Added in"},{"line_number":97,"context_line":"  Mitaka (although exists undocumented in earlier releases)."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Reporting Capabilities"},{"line_number":100,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa69d971_fe6bedee","line":97,"updated":"2016-01-06 19:06:49.000000000","message":"s/exists/existed","commit_id":"457693726a64d060fd5555b014a629cb39c7a7d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"37c4679149c8005faa2aac8fb8be32da32b9f15a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `qos` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"},{"line_number":92,"context_line":"  also setting the relevant QoS-related extra specs for the drivers being used."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_c450b834","line":89,"range":{"start_line":89,"start_character":18,"end_line":89,"end_character":19},"updated":"2016-01-14 20:11:31.000000000","message":"capitalize S","commit_id":"68070b86657cfc8179f42b73d1653f9c836c216f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"22f7a20fee0c0573a01b8123b7e270f44af33b8f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  False. Added in Liberty."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* `qos` - indicates that a backend/pool can provide shares using some"},{"line_number":89,"context_line":"  QoS (Quality of service) specification. The default value of the qos"},{"line_number":90,"context_line":"  capability (if a driver doesn\u0027t report it) is False. Administrators"},{"line_number":91,"context_line":"  can make a share type use QoS by setting this extra-spec to \u0027\u003cis\u003e True\u0027 and"},{"line_number":92,"context_line":"  also setting the relevant QoS-related extra specs for the drivers being used."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_543eadc1","line":89,"range":{"start_line":89,"start_character":18,"end_line":89,"end_character":19},"in_reply_to":"da6ed579_c450b834","updated":"2016-01-15 01:40:57.000000000","message":"Done","commit_id":"68070b86657cfc8179f42b73d1653f9c836c216f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"90719b9ffd5ab879331f6f82a402678d1f64c027","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Different drivers have different ways of specifying"},{"line_number":95,"context_line":"  QoS limits (or guarantees) and this extra spec merely allows the scheduler to"},{"line_number":96,"context_line":"  filter by pools that either have or don\u0027t have QoS support enabled. Added in"},{"line_number":97,"context_line":"  Mitaka (although exists undocumented in earlier releases)."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Reporting Capabilities"},{"line_number":100,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_f02ed6a3","line":97,"range":{"start_line":97,"start_character":10,"end_line":97,"end_character":18},"updated":"2016-01-14 21:34:15.000000000","message":"Since we changed \u0027QoS_support\u0027 to \u0027qos\u0027, we shouldn\u0027t say it exists in earlier releases.  I guess using \u0027qos\u0027 lets us make a clean break with the past.","commit_id":"68070b86657cfc8179f42b73d1653f9c836c216f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"22f7a20fee0c0573a01b8123b7e270f44af33b8f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  extra-spec to \u0027\u003cis\u003e False\u0027. Different drivers have different ways of specifying"},{"line_number":95,"context_line":"  QoS limits (or guarantees) and this extra spec merely allows the scheduler to"},{"line_number":96,"context_line":"  filter by pools that either have or don\u0027t have QoS support enabled. Added in"},{"line_number":97,"context_line":"  Mitaka (although exists undocumented in earlier releases)."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Reporting Capabilities"},{"line_number":100,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da6ed579_b42289a1","line":97,"range":{"start_line":97,"start_character":10,"end_line":97,"end_character":18},"in_reply_to":"da6ed579_f02ed6a3","updated":"2016-01-15 01:40:57.000000000","message":"Done","commit_id":"68070b86657cfc8179f42b73d1653f9c836c216f"}],"doc/source/devref/driver_requirements.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"86848eec0db13154f1f8bcdde635f4ece3756392","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of services for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_1012010a","line":97,"updated":"2015-12-10 13:30:01.000000000","message":"s/qos/QoS_support","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"289287a0c39f41a13081e0caa59905c050efe023","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of services for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_5bd65ef2","line":97,"in_reply_to":"7a740942_1012010a","updated":"2015-12-10 17:06:20.000000000","message":"+1","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of services for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_737c7deb","line":97,"in_reply_to":"7a740942_1012010a","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2eb115f17aa63a6ffd67d0e03db18ea030048208","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- qos: whether the backend supports quality of services for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a740942_1383b9cd","line":97,"in_reply_to":"7a740942_5bd65ef2","updated":"2015-12-11 10:18:07.000000000","message":"Done","commit_id":"c387336f9bff0e30b24fda4768d94c0df96c494d"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bcca4a44c12052d48c08491620a7388e729cd905","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- QoS_support: whether the backend supports quality of services for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_a106f2cb","line":97,"updated":"2015-12-11 17:18:37.000000000","message":"I think \"service\" instead of \"services\" would be more common here.","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ca12c0caa61a67cbb70568b33036a930eebacea9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- QoS_support: whether the backend supports quality of services for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_86f6455b","line":97,"in_reply_to":"7a740942_a106f2cb","updated":"2015-12-13 13:59:03.000000000","message":"Done","commit_id":"1afc4048aef0843eeb088a927cefade28e949ea5"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"3c2e3e066078db8a6c0d14b5ebb6fcfbbe4d690e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"- compression: whether the backend supports compressed shares;"},{"line_number":95,"context_line":"- thin_provisioning: whether the backend is overprovisioning shares;"},{"line_number":96,"context_line":"- pools: list of storage pools managed by this driver instance;"},{"line_number":97,"context_line":"- QoS_support: whether the backend supports quality of service for shares."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. note:: for more information please see http://docs.openstack.org/developer/manila/devref/capabilities_and_extra_specs.html"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a7b0d38_bfe76811","line":97,"updated":"2015-12-23 03:32:18.000000000","message":"same","commit_id":"be70542056c9ac68bc44f445156f158470fde48a"}]}
