)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0bc26d1ae984381b2dbec7b82fd39d75944bc76c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update help text for some service instance config opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clarifiy that some options for the service instance are only needed"},{"line_number":10,"context_line":"if DHSS is set to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11638a84905e3d0e0b891c909a033eceec72087b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_058bf81f","line":9,"updated":"2015-11-30 08:01:00.000000000","message":"s/Clarifiy/Clarify","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"19fbe8b77c59d5e9a1541f7f3f4c4d40dc712dd0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update help text for some service instance config opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clarifiy that some options for the service instance are only needed"},{"line_number":10,"context_line":"if DHSS is set to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11638a84905e3d0e0b891c909a033eceec72087b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_4020c649","line":9,"in_reply_to":"9a8ffd7b_058bf81f","updated":"2016-02-09 16:35:28.000000000","message":"Done","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"9a6c47b6a869cf6569c7ffa2639dd5ee0fce5a48","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update help text for some service instance config opts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clarify that some options for the service instance are only needed"},{"line_number":10,"context_line":"if DHSS is set to true."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11638a84905e3d0e0b891c909a033eceec72087b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a5ae5dd_f1e66643","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":22},"updated":"2016-02-09 19:07:16.000000000","message":"s/true/True","commit_id":"a10ef2a423ed0085792823c0b7b3ba40635506aa"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ba784894ec5fe12e3df9748eaa4069cb5bb10342","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"service_image_name\","},{"line_number":47,"context_line":"        default\u003d\"manila-service-image\","},{"line_number":48,"context_line":"        help\u003d\"Name of image in Glance, that will be used for service instance \""},{"line_number":49,"context_line":"             \"creation. Used only when share servers handling is enabled.\"),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_97d53f1d","line":49,"updated":"2015-11-26 13:20:54.000000000","message":"All opts in \"share_servers_handling_mode_opts\" var are related to DHSS\u003dTrue mode only.","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"19fbe8b77c59d5e9a1541f7f3f4c4d40dc712dd0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"service_image_name\","},{"line_number":47,"context_line":"        default\u003d\"manila-service-image\","},{"line_number":48,"context_line":"        help\u003d\"Name of image in Glance, that will be used for service instance \""},{"line_number":49,"context_line":"             \"creation. Used only when share servers handling is enabled.\"),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_c02b5632","line":49,"in_reply_to":"9a8ffd7b_47c25b54","updated":"2016-02-09 16:35:28.000000000","message":"Done","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1eeea886bbb41faf666b8428e9b55120bdf8a348","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"service_image_name\","},{"line_number":47,"context_line":"        default\u003d\"manila-service-image\","},{"line_number":48,"context_line":"        help\u003d\"Name of image in Glance, that will be used for service instance \""},{"line_number":49,"context_line":"             \"creation. Used only when share servers handling is enabled.\"),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c779b0c9","line":49,"in_reply_to":"9a8ffd7b_5039fca2","updated":"2015-11-27 10:56:02.000000000","message":"Yes, if change, then change all opts in this \"share_servers_handling_mode_opts\" list consistently.","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6fd623e73d80cd0a09562e968ea0f4c7542f21c2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"service_image_name\","},{"line_number":47,"context_line":"        default\u003d\"manila-service-image\","},{"line_number":48,"context_line":"        help\u003d\"Name of image in Glance, that will be used for service instance \""},{"line_number":49,"context_line":"             \"creation. Used only when share servers handling is enabled.\"),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_5039fca2","line":49,"in_reply_to":"9a8ffd7b_97d53f1d","updated":"2015-11-27 09:02:18.000000000","message":"@Valeriy: So should I add this comment to all opts? The thing is that it\u0027s not clear what options are used in which mode when you just have a manila.conf . Or should I fix all comments (DHSS\u003dtrue and false) and just add (\"only for DHSS\u003dtrue\" or \"only for DHSS\u003dfalse\" )","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"19fbe8b77c59d5e9a1541f7f3f4c4d40dc712dd0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"service_image_name\","},{"line_number":47,"context_line":"        default\u003d\"manila-service-image\","},{"line_number":48,"context_line":"        help\u003d\"Name of image in Glance, that will be used for service instance \""},{"line_number":49,"context_line":"             \"creation. Used only when share servers handling is enabled.\"),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_e030d2a0","line":49,"in_reply_to":"9a8ffd7b_97d53f1d","updated":"2016-02-09 16:35:28.000000000","message":"Done","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c318a8b91910521cbc86f6bb24562590aa3886e8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"service_image_name\","},{"line_number":47,"context_line":"        default\u003d\"manila-service-image\","},{"line_number":48,"context_line":"        help\u003d\"Name of image in Glance, that will be used for service instance \""},{"line_number":49,"context_line":"             \"creation. Used only when share servers handling is enabled.\"),"},{"line_number":50,"context_line":"    cfg.StrOpt("},{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_47c25b54","line":49,"in_reply_to":"9a8ffd7b_c779b0c9","updated":"2015-11-30 11:43:31.000000000","message":"Also, would be better to say about config option \"driver_handles_share_servers\" here explicitly, so admin/deployer will get know for sure. When \"Used only when share servers handling is enabled.\" can be not clear for him.","commit_id":"9b186058c458cbb6681bb74bb603127a28617929"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f699c2a08d2d33182dd1aaacf1a032874256f12b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","},{"line_number":53,"context_line":"        help\u003d\"Name of service instance.\""},{"line_number":54,"context_line":"             \"Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \"manila_service_keypair_name\","},{"line_number":57,"context_line":"        default\u003d\"manila-service\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_fe433e40","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":26},"updated":"2016-02-11 19:16:42.000000000","message":"I think you have several cases here where a space is needed before a line break in the help text.","commit_id":"a10ef2a423ed0085792823c0b7b3ba40635506aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c1b88b9f95f13c2929950f380aa7ca36d84d32a6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","},{"line_number":53,"context_line":"        help\u003d\"Name of service instance.\""},{"line_number":54,"context_line":"             \"Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \"manila_service_keypair_name\","},{"line_number":57,"context_line":"        default\u003d\"manila-service\","}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_b974619c","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":26},"in_reply_to":"3a57f1b5_fe433e40","updated":"2016-02-21 23:11:18.000000000","message":"+1","commit_id":"a10ef2a423ed0085792823c0b7b3ba40635506aa"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"5060e65546ebd1feedf9321d88bde74ab2cdb697","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"service_instance_name_template\","},{"line_number":52,"context_line":"        default\u003d\"manila_service_instance_%s\","},{"line_number":53,"context_line":"        help\u003d\"Name of service instance.\""},{"line_number":54,"context_line":"             \"Only used if driver_handles_share_servers\u003dTrue.\"),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \"manila_service_keypair_name\","},{"line_number":57,"context_line":"        default\u003d\"manila-service\","}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1a2731cb","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":26},"in_reply_to":"3a57f1b5_fe433e40","updated":"2016-02-22 09:15:32.000000000","message":"Done","commit_id":"a10ef2a423ed0085792823c0b7b3ba40635506aa"}]}
