)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liucheng \u003cliucheng20@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-28 09:13:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: add manage share support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manage share that is already on arrary,"},{"line_number":10,"context_line":"before this time we just change share\u0027s name,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_15fd7db3","line":7,"updated":"2015-11-28 10:09:13.000000000","message":":s/add/Add","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"20871132cf2b6b7f1eff9828420ed8cc23b5c9ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liucheng \u003cliucheng20@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-28 09:13:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: add manage share support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manage share that is already on arrary,"},{"line_number":10,"context_line":"before this time we just change share\u0027s name,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_19d6fd4e","line":7,"updated":"2015-11-30 12:49:54.000000000","message":"Huawei has already support manage share. It is better change to \"Add manage share with share type in Huawei driver\".","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: add manage share support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manage share that is already on arrary,"},{"line_number":10,"context_line":"before this time we just change share\u0027s name,"},{"line_number":11,"context_line":"now we import it with share_type and retype it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_952f2d3e","line":9,"updated":"2015-11-28 10:09:13.000000000","message":":s/arrary/array","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2e806cf18bf03e901143fcd941bdde6b061eed8c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: add manage share support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manage share that is already on arrary,"},{"line_number":10,"context_line":"before this time we just change share\u0027s name,"},{"line_number":11,"context_line":"now we import it with share_type and retype it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint manage-share-on-array"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_ee2ecc41","line":10,"updated":"2015-12-01 10:37:34.000000000","message":"s/change/changed","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"}],"manila/share/drivers/huawei/constants.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"ERROR_UNAUTHORIZED_TO_SERVER \u003d -401"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"THIN_FS_ALLOCTYPE \u003d \"1\""},{"line_number":35,"context_line":"THIN_ALLOCTYPE \u003d \"Thin\""},{"line_number":36,"context_line":"THICK_ALLOCTYPE \u003d \"Thick\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"OPTS_CAPABILITIES \u003d {"},{"line_number":39,"context_line":"    \u0027dedupe\u0027: False,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_2c0c1d3a","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":25},"updated":"2015-12-21 02:14:09.000000000","message":"Just suggest to modify like this:\nALLOC_TYPE_THIN_FLAG \u003d \"1\"\nALLOC_TYPE_THIN \u003d \"Thin\"\nALLOC_TYPE_THICK \u003d \"Thick\"\n\nALLOC_TYPES \u003d (\n    ALLOC_TYPE_THIN,\n    ALLOC_TYPE_THICK,\n)","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":511,"context_line":"        poolinfo \u003d self.helper._find_pool_info(pool_name, result)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        change_opts \u003d self.check_retype_change_opts(opts, poolinfo, fs)"},{"line_number":514,"context_line":"        LOG.info(_LI(\u0027Retype share (%(share)s), change_opts is : \u0027"},{"line_number":515,"context_line":"                     \u0027(%(change_opts)s). \u0027),"},{"line_number":516,"context_line":"                 {\u0027share\u0027: old_share_name, \u0027change_opts\u0027: change_opts})"},{"line_number":517,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2812a857","line":514,"updated":"2015-11-28 10:09:13.000000000","message":":s/Retype/Retyping\n\n\n:s/chage_opts is/changed options are","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                 {\u0027share\u0027: old_share_name, \u0027change_opts\u0027: change_opts})"},{"line_number":517,"context_line":"        try:"},{"line_number":518,"context_line":"            self.retype_share(change_opts, fs_id)"},{"line_number":519,"context_line":"        except exception.ShareBackendAPIException:"},{"line_number":520,"context_line":"            LOG.exception(_LE(\u0027Retype share error.\u0027))"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e82ee08a","line":519,"updated":"2015-11-28 10:09:13.000000000","message":"Is this a new kind of exception? Where is it raised? It isn\u0027t defined in manila/exception.py.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"20871132cf2b6b7f1eff9828420ed8cc23b5c9ec","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                 {\u0027share\u0027: old_share_name, \u0027change_opts\u0027: change_opts})"},{"line_number":517,"context_line":"        try:"},{"line_number":518,"context_line":"            self.retype_share(change_opts, fs_id)"},{"line_number":519,"context_line":"        except exception.ShareBackendAPIException:"},{"line_number":520,"context_line":"            LOG.exception(_LE(\u0027Retype share error.\u0027))"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_59fd65af","line":519,"in_reply_to":"9a8ffd7b_e82ee08a","updated":"2015-11-30 12:49:54.000000000","message":"+1","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        try:"},{"line_number":518,"context_line":"            self.retype_share(change_opts, fs_id)"},{"line_number":519,"context_line":"        except exception.ShareBackendAPIException:"},{"line_number":520,"context_line":"            LOG.exception(_LE(\u0027Retype share error.\u0027))"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"},{"line_number":523,"context_line":"        self.helper._change_fs_name(fs_id, share_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_68599034","line":520,"updated":"2015-11-28 10:09:13.000000000","message":"If you were to define that exception, please log that exception as well if you want to use LOG.exception here. \n    \n    except exception.ShareBackendAPIException as e:\n           LOG.exception(_LE(\u0027Unable to retype share. Reason: %s.\u0027), e.message)\n\nor something along those lines.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"20871132cf2b6b7f1eff9828420ed8cc23b5c9ec","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        old_partition_name \u003d None"},{"line_number":537,"context_line":"        new_partition_id \u003d None"},{"line_number":538,"context_line":"        new_partition_name \u003d None"},{"line_number":539,"context_line":"        if strutils.bool_from_string(opts[\u0027huawei_smartpartition\u0027]):"},{"line_number":540,"context_line":"            if opts[\u0027partitionname\u0027]:"},{"line_number":541,"context_line":"                new_partition_name \u003d opts[\u0027partitionname\u0027]"},{"line_number":542,"context_line":"                new_partition_id \u003d self.helper._get_partition_id_by_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_f379cd93","line":539,"updated":"2015-11-30 12:49:54.000000000","message":"If opts[\u0027huawei_smartpartition\u0027] is true or false, it can not effect the opts[\u0027partitionname\u0027].\nSo you not need to add \"if strutils.bool_from_string(opts[\u0027huawei_smartpartition\u0027]):\"","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            if opts[\u0027partitionname\u0027]:"},{"line_number":541,"context_line":"                new_partition_name \u003d opts[\u0027partitionname\u0027]"},{"line_number":542,"context_line":"                new_partition_id \u003d self.helper._get_partition_id_by_name("},{"line_number":543,"context_line":"                    opts[\u0027partitionname\u0027])"},{"line_number":544,"context_line":"                if new_partition_id is None:"},{"line_number":545,"context_line":"                    raise exception.InvalidInput("},{"line_number":546,"context_line":"                        reason\u003d(_(\"Can\u0027t find partition name on the array, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_15625d0a","line":543,"updated":"2015-11-28 10:09:13.000000000","message":"opts[\u0027partitionname\u0027] has been assigned to new_partition_name above, please use that on this line.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2e806cf18bf03e901143fcd941bdde6b061eed8c","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                                % {\"name\": new_partition_name}))"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        if old_partition_id !\u003d new_partition_id:"},{"line_number":551,"context_line":"            if old_partition_id:"},{"line_number":552,"context_line":"                partition_info \u003d self.helper.get_partition_info_by_id("},{"line_number":553,"context_line":"                    old_partition_id)"},{"line_number":554,"context_line":"                old_partition_name \u003d partition_info[\u0027NAME\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b107c516","line":551,"updated":"2015-12-01 10:37:34.000000000","message":"This can be a single condition:\n\n\"if old_partition_id and old_partition_id !\u003d new_partition_id:\"","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"20871132cf2b6b7f1eff9828420ed8cc23b5c9ec","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        old_cache_name \u003d None"},{"line_number":563,"context_line":"        new_cache_id \u003d None"},{"line_number":564,"context_line":"        new_cache_name \u003d None"},{"line_number":565,"context_line":"        if strutils.bool_from_string(opts[\u0027huawei_smartcache\u0027]):"},{"line_number":566,"context_line":"            if opts[\u0027cachename\u0027]:"},{"line_number":567,"context_line":"                new_cache_name \u003d opts[\u0027cachename\u0027]"},{"line_number":568,"context_line":"                new_cache_id \u003d self.helper._get_cache_id_by_name("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b36fc5c2","line":565,"updated":"2015-11-30 12:49:54.000000000","message":"same","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":566,"context_line":"            if opts[\u0027cachename\u0027]:"},{"line_number":567,"context_line":"                new_cache_name \u003d opts[\u0027cachename\u0027]"},{"line_number":568,"context_line":"                new_cache_id \u003d self.helper._get_cache_id_by_name("},{"line_number":569,"context_line":"                    opts[\u0027cachename\u0027])"},{"line_number":570,"context_line":"                if new_cache_id is None:"},{"line_number":571,"context_line":"                    raise exception.InvalidInput("},{"line_number":572,"context_line":"                        reason\u003d(_(\"Can\u0027t find cache name on the array, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d557f523","line":569,"updated":"2015-11-28 10:09:13.000000000","message":"opts[\u0027cachename\u0027] has been assigned to new_cache_name above. Please use that  here..","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        new_dedupe \u003d smartx_opts[\u0027dedupe\u0027]"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d \u00271\u0027:"},{"line_number":596,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thin\u0027"},{"line_number":597,"context_line":"        else:"},{"line_number":598,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thick\u0027"},{"line_number":599,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b51ef16d","line":596,"updated":"2015-11-28 10:09:13.000000000","message":"Suggestion: Please use constants defined in a common place for these strings, \u0027Thin\u0027, \u0027Thick\u0027 etc.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thick\u0027"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if ((fs[\u0027ALLOCTYPE\u0027] !\u003d poolinfo[\u0027type\u0027])"},{"line_number":606,"context_line":"                or (fs[\u0027ALLOCTYPE\u0027] !\u003d opts[\u0027thin_provisioning\u0027])):"},{"line_number":607,"context_line":"            raise exception.InvalidHost("},{"line_number":608,"context_line":"                reason\u003d(_(\"Manage existing share fs type and pool type \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_28406833","line":605,"updated":"2015-11-28 10:09:13.000000000","message":"Redundant parenthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thick\u0027"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if ((fs[\u0027ALLOCTYPE\u0027] !\u003d poolinfo[\u0027type\u0027])"},{"line_number":606,"context_line":"                or (fs[\u0027ALLOCTYPE\u0027] !\u003d opts[\u0027thin_provisioning\u0027])):"},{"line_number":607,"context_line":"            raise exception.InvalidHost("},{"line_number":608,"context_line":"                reason\u003d(_(\"Manage existing share fs type and pool type \""},{"line_number":609,"context_line":"                          \"or fs type and new_share_type mismatch. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c84afc54","line":606,"updated":"2015-11-28 10:09:13.000000000","message":"Redundant parenthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        if ((fs[\u0027ALLOCTYPE\u0027] !\u003d poolinfo[\u0027type\u0027])"},{"line_number":606,"context_line":"                or (fs[\u0027ALLOCTYPE\u0027] !\u003d opts[\u0027thin_provisioning\u0027])):"},{"line_number":607,"context_line":"            raise exception.InvalidHost("},{"line_number":608,"context_line":"                reason\u003d(_(\"Manage existing share fs type and pool type \""},{"line_number":609,"context_line":"                          \"or fs type and new_share_type mismatch. \""},{"line_number":610,"context_line":"                          \"fs type is: %(fs_type)s, pool type is:\""},{"line_number":611,"context_line":"                          \"%(pool_type)s, new_share type is:\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8802b408","line":608,"updated":"2015-11-28 10:09:13.000000000","message":"please assign a variable for long exception messages:\n\n    msg \u003d _(\"Manage existing share fs type and pool type or fs type and \"\n        \"new_share_type mismatch. \"fs type is: %(fs_type)s, pool type \"\n        \"is: %(pool_type)s, new_share type is: (new_share type)s.\")\n\n    raise exception.InvalidHost(reason\u003dmsg % {\"fs_type\": fs[\u0027ALLOCTYPE\u0027], \u0027pool_type\u0027: poolinfo[\u0027type\u0027], \u0027new_share type\u0027: opts[\u0027thin_provisioning\u0027]})","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                        \u0027new_share type\u0027: opts[\u0027thin_provisioning\u0027]}))"},{"line_number":616,"context_line":"        else:"},{"line_number":617,"context_line":"            if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d \u0027Thick\u0027:"},{"line_number":618,"context_line":"                if (new_compression or new_dedupe):"},{"line_number":619,"context_line":"                    raise exception.InvalidInput("},{"line_number":620,"context_line":"                        reason\u003d(_(\"Dedupe or compression cannot be set for\""},{"line_number":621,"context_line":"                                  \"thick filesystem.\")))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8877149f","line":618,"updated":"2015-11-28 10:09:13.000000000","message":"redundant paranthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":618,"context_line":"                if (new_compression or new_dedupe):"},{"line_number":619,"context_line":"                    raise exception.InvalidInput("},{"line_number":620,"context_line":"                        reason\u003d(_(\"Dedupe or compression cannot be set for\""},{"line_number":621,"context_line":"                                  \"thick filesystem.\")))"},{"line_number":622,"context_line":"            else:"},{"line_number":623,"context_line":"                if ((old_dedupe !\u003d new_dedupe)"},{"line_number":624,"context_line":"                        or (old_compression !\u003d new_compression)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a8053811","line":621,"updated":"2015-11-28 10:09:13.000000000","message":"missing space between \u0027for\u0027 and \u0027thick\u0027.\n\nAlso, redundant parenthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                        reason\u003d(_(\"Dedupe or compression cannot be set for\""},{"line_number":621,"context_line":"                                  \"thick filesystem.\")))"},{"line_number":622,"context_line":"            else:"},{"line_number":623,"context_line":"                if ((old_dedupe !\u003d new_dedupe)"},{"line_number":624,"context_line":"                        or (old_compression !\u003d new_compression)):"},{"line_number":625,"context_line":"                    change_opts[\"dedupe\u0026compression\"] \u003d ([old_dedupe,"},{"line_number":626,"context_line":"                                                          old_compression],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a87a1886","line":623,"updated":"2015-11-28 10:09:13.000000000","message":"redundant paranthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                                  \"thick filesystem.\")))"},{"line_number":622,"context_line":"            else:"},{"line_number":623,"context_line":"                if ((old_dedupe !\u003d new_dedupe)"},{"line_number":624,"context_line":"                        or (old_compression !\u003d new_compression)):"},{"line_number":625,"context_line":"                    change_opts[\"dedupe\u0026compression\"] \u003d ([old_dedupe,"},{"line_number":626,"context_line":"                                                          old_compression],"},{"line_number":627,"context_line":"                                                         [new_dedupe,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_6870b0a4","line":624,"updated":"2015-11-28 10:09:13.000000000","message":"redundant paranthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        return change_opts"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def retype_share(self, change_opts, fs_id):"},{"line_number":632,"context_line":"        if change_opts.get(\u0027partitionid\u0027, None):"},{"line_number":633,"context_line":"            old, new \u003d change_opts[\u0027partitionid\u0027]"},{"line_number":634,"context_line":"            old_id \u003d old[0]"},{"line_number":635,"context_line":"            old_name \u003d old[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c88f5c73","line":632,"updated":"2015-11-28 10:09:13.000000000","message":"None is the default for dict\u0027s get method:\n\nhttps://docs.python.org/2/library/stdtypes.html#dict.get","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                self.helper._remove_fs_from_partition(fs_id, old_id)"},{"line_number":641,"context_line":"            if new_id:"},{"line_number":642,"context_line":"                self.helper._add_fs_to_partition(fs_id, new_id)"},{"line_number":643,"context_line":"                LOG.info(_LI(\"Retype FS(id: %(fs_id)s) smartpartition from \""},{"line_number":644,"context_line":"                         \"(name: %(old_name)s, id: %(old_id)s) to \""},{"line_number":645,"context_line":"                             \"(name: %(new_name)s, id: %(new_id)s) \""},{"line_number":646,"context_line":"                             \"successfully.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_48a4cc06","line":643,"updated":"2015-11-28 10:09:13.000000000","message":"Please define the message in a variable and use in LOG.info.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                LOG.info(_LI(\"Retype FS(id: %(fs_id)s) smartpartition from \""},{"line_number":644,"context_line":"                         \"(name: %(old_name)s, id: %(old_id)s) to \""},{"line_number":645,"context_line":"                             \"(name: %(new_name)s, id: %(new_id)s) \""},{"line_number":646,"context_line":"                             \"successfully.\"),"},{"line_number":647,"context_line":"                         {\"lun_id\": fs_id,"},{"line_number":648,"context_line":"                          \"old_id\": old_id, \"old_name\": old_name,"},{"line_number":649,"context_line":"                          \"new_id\": new_id, \"new_name\": new_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a888d871","line":646,"updated":"2015-11-28 10:09:13.000000000","message":"missing verb. \n\ncompleted successfully? performed successfully?\n\nOr \"x has been retyped to y successfully.\"","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                          \"old_id\": old_id, \"old_name\": old_name,"},{"line_number":649,"context_line":"                          \"new_id\": new_id, \"new_name\": new_name})"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"        if change_opts.get(\u0027cacheid\u0027, None):"},{"line_number":652,"context_line":"            old, new \u003d change_opts[\u0027cacheid\u0027]"},{"line_number":653,"context_line":"            old_id \u003d old[0]"},{"line_number":654,"context_line":"            old_name \u003d old[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_88ecf42a","line":651,"updated":"2015-11-28 10:09:13.000000000","message":"same as above","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":661,"context_line":"                LOG.info(_LI(\"Retype FS(id: %(fs_id)s) smartcache from \""},{"line_number":662,"context_line":"                             \"(name: %(old_name)s, id: %(old_id)s) to \""},{"line_number":663,"context_line":"                             \"(name: %(new_name)s, id: %(new_id)s) \""},{"line_number":664,"context_line":"                             \"successfully.\"),"},{"line_number":665,"context_line":"                         {\u0027fs_id\u0027: fs_id,"},{"line_number":666,"context_line":"                          \u0027old_id\u0027: old_id, \"old_name\": old_name,"},{"line_number":667,"context_line":"                          \u0027new_id\u0027: new_id, \"new_name\": new_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_68f510eb","line":664,"updated":"2015-11-28 10:09:13.000000000","message":"Missing verb, same as above.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                          \u0027old_id\u0027: old_id, \"old_name\": old_name,"},{"line_number":667,"context_line":"                          \u0027new_id\u0027: new_id, \"new_name\": new_name})"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        if change_opts.get(\u0027dedupe\u0026compression\u0027, None):"},{"line_number":670,"context_line":"            old, new \u003d change_opts[\u0027dedupe\u0026compression\u0027]"},{"line_number":671,"context_line":"            old_dedupe \u003d old[0]"},{"line_number":672,"context_line":"            old_compression \u003d old[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_28dce871","line":669,"updated":"2015-11-28 10:09:13.000000000","message":"same as above.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":672,"context_line":"            old_compression \u003d old[1]"},{"line_number":673,"context_line":"            new_dedupe \u003d new[0]"},{"line_number":674,"context_line":"            new_compression \u003d new[1]"},{"line_number":675,"context_line":"            if ((old_dedupe !\u003d new_dedupe)"},{"line_number":676,"context_line":"                    or (old_compression !\u003d new_compression)):"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"                new_smartx_opts \u003d {\"dedupe\": new_dedupe,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c8e67c43","line":675,"updated":"2015-11-28 10:09:13.000000000","message":"redundant paranthesis.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":673,"context_line":"            new_dedupe \u003d new[0]"},{"line_number":674,"context_line":"            new_compression \u003d new[1]"},{"line_number":675,"context_line":"            if ((old_dedupe !\u003d new_dedupe)"},{"line_number":676,"context_line":"                    or (old_compression !\u003d new_compression)):"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"                new_smartx_opts \u003d {\"dedupe\": new_dedupe,"},{"line_number":679,"context_line":"                                   \"compression\": new_compression}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e8e1002b","line":676,"updated":"2015-11-28 10:09:13.000000000","message":"redundant paranthesis","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                                   \"compression\": new_compression}"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"                self.helper._change_extra_specs(fs_id, new_smartx_opts)"},{"line_number":682,"context_line":"                LOG.info(_LI(\"Retype FS(id: %(fs_id)s) dedupe from \""},{"line_number":683,"context_line":"                         \"%(old_dedupe)s to %(new_dedupe)s successfully,\""},{"line_number":684,"context_line":"                             \"compression from \""},{"line_number":685,"context_line":"                             \"%(old_compression)s to %(new_compression)s\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_08c804a5","line":682,"updated":"2015-11-28 10:09:13.000000000","message":"Please store message in a separate variable if it is long. Also, missing verb like above.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"096a2e6a9455cd9255adb5c4a4c5b9464beb8398","unresolved":false,"context_lines":[{"line_number":688,"context_line":"                          \u0027old_dedupe\u0027: old_dedupe,"},{"line_number":689,"context_line":"                          \u0027new_dedupe\u0027: new_dedupe,"},{"line_number":690,"context_line":"                          \u0027old_compression\u0027: old_compression,"},{"line_number":691,"context_line":"                          \u0027new_compression\u0027: new_compression})"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def _get_location_path(self, share_name, share_proto):"},{"line_number":694,"context_line":"        root \u003d self.helper._read_xml()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a83d3890","line":691,"updated":"2015-11-28 10:09:13.000000000","message":"Not sure which method call throws the exception.ShareBackendAPIException here..\n\nI see all the REST APIs could throw an InvalidShare exception.","commit_id":"73ab3db13936e56ceee21cd20d2fe5aa597e95bd"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"43bffae010606d43dbb94580cf3ca3e093515342","unresolved":false,"context_lines":[{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        change_opts \u003d self.check_retype_change_opts(opts, poolinfo, fs)"},{"line_number":514,"context_line":"        LOG.info(_LI(\u0027Retyping share (%(share)s), changed options are : \u0027"},{"line_number":515,"context_line":"                     \u0027(%(change_opts)s). \u0027),"},{"line_number":516,"context_line":"                 {\u0027share\u0027: old_share_name, \u0027change_opts\u0027: change_opts})"},{"line_number":517,"context_line":"        try:"},{"line_number":518,"context_line":"            self.retype_share(change_opts, fs_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_1bc5208d","line":515,"updated":"2015-12-11 01:35:35.000000000","message":"Extra blank space after (%(change_opts)s).","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"43bffae010606d43dbb94580cf3ca3e093515342","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        if strutils.bool_from_string(opts[\u0027huawei_smartcache\u0027]):"},{"line_number":569,"context_line":"            if not opts[\u0027cachename\u0027]:"},{"line_number":570,"context_line":"                raise exception.InvalidInput("},{"line_number":571,"context_line":"                    reason\u003d_(\u0027Illegal value specified for cache.\u0027))"},{"line_number":572,"context_line":"            new_cache_name \u003d opts[\u0027cachename\u0027]"},{"line_number":573,"context_line":"            new_cache_id \u003d self.helper._get_cache_id_by_name("},{"line_number":574,"context_line":"                new_cache_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3bca5c6f","line":571,"updated":"2015-12-11 01:35:35.000000000","message":"Suggest using change the reason description like SmartPartition.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"51cd7e35268daa227788943ef1e58654f7fcfdc4","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        if strutils.bool_from_string(opts[\u0027huawei_smartcache\u0027]):"},{"line_number":569,"context_line":"            if not opts[\u0027cachename\u0027]:"},{"line_number":570,"context_line":"                raise exception.InvalidInput("},{"line_number":571,"context_line":"                    reason\u003d_(\u0027Illegal value specified for cache.\u0027))"},{"line_number":572,"context_line":"            new_cache_name \u003d opts[\u0027cachename\u0027]"},{"line_number":573,"context_line":"            new_cache_id \u003d self.helper._get_cache_id_by_name("},{"line_number":574,"context_line":"                new_cache_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ed3f2f23","line":571,"in_reply_to":"7a740942_3bca5c6f","updated":"2015-12-11 07:11:37.000000000","message":"+1","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"51cd7e35268daa227788943ef1e58654f7fcfdc4","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        old_dedupe \u003d fs[\u0027DEDUP\u0027]"},{"line_number":598,"context_line":"        new_dedupe \u003d smartx_opts[\u0027dedupe\u0027]"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d \u00271\u0027:"},{"line_number":601,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thin\u0027"},{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thick\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ed6def32","line":600,"updated":"2015-12-11 07:11:37.000000000","message":"Please, use constants here instead of number, Because the number is used in many place.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fde36f335580c4b442f417a7d785cb14ef3c0741","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        new_dedupe \u003d smartx_opts[\u0027dedupe\u0027]"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d \u00271\u0027:"},{"line_number":601,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thin\u0027"},{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thick\u0027"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_e721804e","line":601,"updated":"2015-12-11 11:47:20.000000000","message":"Please use a constant here as well, declare it in your driver class.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fde36f335580c4b442f417a7d785cb14ef3c0741","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d \u00271\u0027:"},{"line_number":601,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thin\u0027"},{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thick\u0027"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if opts[\u0027thin_provisioning\u0027] \u003d\u003d \u0027true\u0027:"},{"line_number":606,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thin\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a717f8ec","line":603,"updated":"2015-12-11 11:47:20.000000000","message":"same as above.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"51cd7e35268daa227788943ef1e58654f7fcfdc4","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        else:"},{"line_number":603,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thick\u0027"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if opts[\u0027thin_provisioning\u0027] \u003d\u003d \u0027true\u0027:"},{"line_number":606,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thin\u0027"},{"line_number":607,"context_line":"        else:"},{"line_number":608,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thick\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_9bb90dce","line":605,"updated":"2015-12-11 07:11:37.000000000","message":"Please use strutils.bool_from_string to check opts[\u0027thin_provisioning\u0027].","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fde36f335580c4b442f417a7d785cb14ef3c0741","unresolved":false,"context_lines":[{"line_number":603,"context_line":"            fs[\u0027ALLOCTYPE\u0027] \u003d \u0027Thick\u0027"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if opts[\u0027thin_provisioning\u0027] \u003d\u003d \u0027true\u0027:"},{"line_number":606,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thin\u0027"},{"line_number":607,"context_line":"        else:"},{"line_number":608,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thick\u0027"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_a7ee18eb","line":606,"updated":"2015-12-11 11:47:20.000000000","message":"Please use a constant here as well, declare it in your driver class.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fde36f335580c4b442f417a7d785cb14ef3c0741","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        if opts[\u0027thin_provisioning\u0027] \u003d\u003d \u0027true\u0027:"},{"line_number":606,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thin\u0027"},{"line_number":607,"context_line":"        else:"},{"line_number":608,"context_line":"            opts[\u0027thin_provisioning\u0027] \u003d \u0027Thick\u0027"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        if (fs[\u0027ALLOCTYPE\u0027] !\u003d poolinfo[\u0027type\u0027]"},{"line_number":611,"context_line":"                or fs[\u0027ALLOCTYPE\u0027] !\u003d opts[\u0027thin_provisioning\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_c7eb24db","line":608,"updated":"2015-12-11 11:47:20.000000000","message":"same as above.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"43bffae010606d43dbb94580cf3ca3e093515342","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                or fs[\u0027ALLOCTYPE\u0027] !\u003d opts[\u0027thin_provisioning\u0027]):"},{"line_number":612,"context_line":"            msg \u003d (_(\"Manage existing share fs type and pool type \""},{"line_number":613,"context_line":"                     \"or fs type and new_share_type mismatch. \""},{"line_number":614,"context_line":"                     \"fs type is: %(fs_type)s, pool type is:\""},{"line_number":615,"context_line":"                     \"%(pool_type)s, new_share type is:\""},{"line_number":616,"context_line":"                     \"%(new_share type)s\")"},{"line_number":617,"context_line":"                   % {\"fs_type\": fs[\u0027ALLOCTYPE\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_9b0590c3","line":614,"updated":"2015-12-11 01:35:35.000000000","message":"Missing blank space EOL.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"43bffae010606d43dbb94580cf3ca3e093515342","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            msg \u003d (_(\"Manage existing share fs type and pool type \""},{"line_number":613,"context_line":"                     \"or fs type and new_share_type mismatch. \""},{"line_number":614,"context_line":"                     \"fs type is: %(fs_type)s, pool type is:\""},{"line_number":615,"context_line":"                     \"%(pool_type)s, new_share type is:\""},{"line_number":616,"context_line":"                     \"%(new_share type)s\")"},{"line_number":617,"context_line":"                   % {\"fs_type\": fs[\u0027ALLOCTYPE\u0027],"},{"line_number":618,"context_line":"                      \"pool_type\": poolinfo[\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_5b0f28e1","line":615,"updated":"2015-12-11 01:35:35.000000000","message":"Missing blank space EOL.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fde36f335580c4b442f417a7d785cb14ef3c0741","unresolved":false,"context_lines":[{"line_number":619,"context_line":"                      \"new_share type\": opts[\u0027thin_provisioning\u0027]})"},{"line_number":620,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":621,"context_line":"        else:"},{"line_number":622,"context_line":"            if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d \u0027Thick\u0027:"},{"line_number":623,"context_line":"                if new_compression or new_dedupe:"},{"line_number":624,"context_line":"                    raise exception.InvalidInput("},{"line_number":625,"context_line":"                        reason\u003d_(\"Dedupe or compression cannot be set for \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_07cdac84","line":622,"updated":"2015-12-11 11:47:20.000000000","message":"Please use a constant here as well, declare it in your driver class.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"51cd7e35268daa227788943ef1e58654f7fcfdc4","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                if new_compression or new_dedupe:"},{"line_number":624,"context_line":"                    raise exception.InvalidInput("},{"line_number":625,"context_line":"                        reason\u003d_(\"Dedupe or compression cannot be set for \""},{"line_number":626,"context_line":"                                           \"thick filesystem.\"))"},{"line_number":627,"context_line":"            else:"},{"line_number":628,"context_line":"                if (old_dedupe !\u003d new_dedupe"},{"line_number":629,"context_line":"                        or old_compression !\u003d new_compression):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8d078b80","line":626,"updated":"2015-12-11 07:11:37.000000000","message":"continuation line over-indented for visual indent","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            LOG.error(err_msg)"},{"line_number":174,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        if fs_info[\u0027ALLOCTYPE\u0027] !\u003d \u00271\u0027:"},{"line_number":177,"context_line":"            err_msg \u003d (_(\"Share (%s) can not be shrunk. only \u0027Thin\u0027 shares \""},{"line_number":178,"context_line":"                         \"support shrink.\")"},{"line_number":179,"context_line":"                       % share_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_41be1266","line":176,"range":{"start_line":176,"start_character":35,"end_line":176,"end_character":38},"updated":"2015-12-21 02:14:09.000000000","message":"Please, use constants here instead of literals. (THIN_FS_ALLOCTYPE)","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        all_pool_info \u003d self.helper._find_all_pool_info()"},{"line_number":237,"context_line":"        stats_dict[\"pools\"] \u003d []"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        for pool_type in (\u0027Thin\u0027, \u0027Thick\u0027):"},{"line_number":240,"context_line":"            pool_name_list \u003d root.findtext((\u0027Filesystem/%s_StoragePool\u0027"},{"line_number":241,"context_line":"                                            % pool_type))"},{"line_number":242,"context_line":"            pool_name_list \u003d pool_name_list.split(\";\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_21b98679","line":239,"range":{"start_line":239,"start_character":25,"end_line":239,"end_character":41},"updated":"2015-12-21 02:14:09.000000000","message":"Please, use constants here instead of literals:\nhttps://review.openstack.org/#/c/250995/3/manila/share/drivers/huawei/constants.py","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                        allocated_capacity_gb\u003dcapacity[\u0027CONSUMEDCAPACITY\u0027],"},{"line_number":257,"context_line":"                        QoS_support\u003dFalse,"},{"line_number":258,"context_line":"                        reserved_percentage\u003d0,"},{"line_number":259,"context_line":"                        thin_provisioning\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":260,"context_line":"                        dedupe\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":261,"context_line":"                        compression\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":262,"context_line":"                        huawei_smartcache\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_c1b20294","line":259,"range":{"start_line":259,"start_character":56,"end_line":259,"end_character":62},"updated":"2015-12-21 02:14:09.000000000","message":"same","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                        QoS_support\u003dFalse,"},{"line_number":258,"context_line":"                        reserved_percentage\u003d0,"},{"line_number":259,"context_line":"                        thin_provisioning\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":260,"context_line":"                        dedupe\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":261,"context_line":"                        compression\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":262,"context_line":"                        huawei_smartcache\u003dTrue,"},{"line_number":263,"context_line":"                        huawei_smartpartition\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_e1affe27","line":260,"range":{"start_line":260,"start_character":45,"end_line":260,"end_character":51},"updated":"2015-12-21 02:14:09.000000000","message":"same","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                        reserved_percentage\u003d0,"},{"line_number":259,"context_line":"                        thin_provisioning\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":260,"context_line":"                        dedupe\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":261,"context_line":"                        compression\u003d(pool_type \u003d\u003d \u0027Thin\u0027),"},{"line_number":262,"context_line":"                        huawei_smartcache\u003dTrue,"},{"line_number":263,"context_line":"                        huawei_smartpartition\u003dTrue,"},{"line_number":264,"context_line":"                    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_81a87a21","line":261,"range":{"start_line":261,"start_character":50,"end_line":261,"end_character":56},"updated":"2015-12-21 02:14:09.000000000","message":"same","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97c67a7fe60e0fd4d53874204b41c4b4e5e69ff9","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        fileparam \u003d {"},{"line_number":324,"context_line":"            \"NAME\": name.replace(\"-\", \"_\"),"},{"line_number":325,"context_line":"            \"DESCRIPTION\": \"\","},{"line_number":326,"context_line":"            \"ALLOCTYPE\": (1 if poolinfo[\u0027type\u0027] \u003d\u003d \u0027Thin\u0027"},{"line_number":327,"context_line":"                          else 0),"},{"line_number":328,"context_line":"            \"CAPACITY\": size,"},{"line_number":329,"context_line":"            \"PARENTID\": poolinfo[\u0027ID\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_4165b21b","line":326,"range":{"start_line":326,"start_character":51,"end_line":326,"end_character":57},"updated":"2015-12-21 02:14:09.000000000","message":"Please, use constants here instead of literals:\nhttps://review.openstack.org/#/c/250995/3/manila/share/drivers/huawei/constants.py","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"55a0947ebd0881c414631c92cf3be3c5feafd4e3","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            msg \u003d (_(\"Manage existing share fs type and pool type \""},{"line_number":613,"context_line":"                     \"or fs type and new_share_type mismatch. \""},{"line_number":614,"context_line":"                     \"fs type is: %(fs_type)s, pool type is: \""},{"line_number":615,"context_line":"                     \"%(pool_type)s, new_share type is: \""},{"line_number":616,"context_line":"                     \"%(new_share type)s\")"},{"line_number":617,"context_line":"                   % {\"fs_type\": fs[\u0027ALLOCTYPE\u0027],"},{"line_number":618,"context_line":"                      \"pool_type\": poolinfo[\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7fe04529","line":615,"range":{"start_line":615,"start_character":37,"end_line":615,"end_character":51},"updated":"2015-12-22 09:53:03.000000000","message":"new_share_type, not new_share type.","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"55a0947ebd0881c414631c92cf3be3c5feafd4e3","unresolved":false,"context_lines":[{"line_number":613,"context_line":"                     \"or fs type and new_share_type mismatch. \""},{"line_number":614,"context_line":"                     \"fs type is: %(fs_type)s, pool type is: \""},{"line_number":615,"context_line":"                     \"%(pool_type)s, new_share type is: \""},{"line_number":616,"context_line":"                     \"%(new_share type)s\")"},{"line_number":617,"context_line":"                   % {\"fs_type\": fs[\u0027ALLOCTYPE\u0027],"},{"line_number":618,"context_line":"                      \"pool_type\": poolinfo[\u0027type\u0027],"},{"line_number":619,"context_line":"                      \"new_share type\": opts[\u0027thin_provisioning\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_1fd6e14e","line":616,"range":{"start_line":616,"start_character":24,"end_line":616,"end_character":38},"updated":"2015-12-22 09:53:03.000000000","message":"same","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"55a0947ebd0881c414631c92cf3be3c5feafd4e3","unresolved":false,"context_lines":[{"line_number":616,"context_line":"                     \"%(new_share type)s\")"},{"line_number":617,"context_line":"                   % {\"fs_type\": fs[\u0027ALLOCTYPE\u0027],"},{"line_number":618,"context_line":"                      \"pool_type\": poolinfo[\u0027type\u0027],"},{"line_number":619,"context_line":"                      \"new_share type\": opts[\u0027thin_provisioning\u0027]})"},{"line_number":620,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"},{"line_number":621,"context_line":"        else:"},{"line_number":622,"context_line":"            if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d constants.THICK_ALLOCTYPE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7fc7e595","line":619,"range":{"start_line":619,"start_character":23,"end_line":619,"end_character":36},"updated":"2015-12-22 09:53:03.000000000","message":"same","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"162224dc11061d45445b3c4d6af859d9c4f06b49","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        old_share_name \u003d self.helper._get_share_name_by_export_location("},{"line_number":481,"context_line":"            old_export_location, share_proto)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_ea98951d","line":483,"range":{"start_line":483,"start_character":19,"end_line":483,"end_character":24},"updated":"2015-12-24 14:26:43.000000000","message":"\"flage\"? Maybe you meant flag? Same below.","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"e59dff7f5364fc317b469911f6e2fb160fc37518","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        old_share_name \u003d self.helper._get_share_name_by_export_location("},{"line_number":481,"context_line":"            old_export_location, share_proto)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_8d0d6139","line":483,"range":{"start_line":483,"start_character":19,"end_line":483,"end_character":24},"in_reply_to":"1a7b0d38_ea98951d","updated":"2015-12-25 06:30:28.000000000","message":"Done","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b0ea20444272b0466cc9a77dca076a891429f1d0","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        old_share_name \u003d self.helper._get_share_name_by_export_location("},{"line_number":481,"context_line":"            old_export_location, share_proto)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"},{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_fb35d245","line":485,"range":{"start_line":483,"start_character":7,"end_line":485,"end_character":60},"updated":"2015-12-24 09:33:03.000000000","message":"Just use it in line 517. Why don\u0027t you move it to line 517. and you can remove the flag \u0027share_type_flage\u0027.","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b0ea20444272b0466cc9a77dca076a891429f1d0","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"},{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_bbe8aae3","line":485,"range":{"start_line":485,"start_character":11,"end_line":485,"end_character":43},"updated":"2015-12-24 09:33:03.000000000","message":"The \u0027thin_provisioning\u0027 and \u0027capabilities:thin_provisioning\u0027 A and B are the same meaning. so please add \u0027thin_provisioning\u0027","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"e59dff7f5364fc317b469911f6e2fb160fc37518","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        old_share_name \u003d self.helper._get_share_name_by_export_location("},{"line_number":481,"context_line":"            old_export_location, share_proto)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"},{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_d099be20","line":485,"range":{"start_line":483,"start_character":7,"end_line":485,"end_character":60},"in_reply_to":"1a7b0d38_2a8f7dcd","updated":"2015-12-25 06:30:28.000000000","message":"Done","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"e59dff7f5364fc317b469911f6e2fb160fc37518","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"},{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_ed0425c1","line":485,"range":{"start_line":485,"start_character":11,"end_line":485,"end_character":43},"in_reply_to":"1a7b0d38_bbe8aae3","updated":"2015-12-25 06:30:28.000000000","message":"Done","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"162224dc11061d45445b3c4d6af859d9c4f06b49","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        old_share_name \u003d self.helper._get_share_name_by_export_location("},{"line_number":481,"context_line":"            old_export_location, share_proto)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"},{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_2a8f7dcd","line":485,"range":{"start_line":483,"start_character":7,"end_line":485,"end_character":60},"in_reply_to":"1a7b0d38_fb35d245","updated":"2015-12-24 14:26:43.000000000","message":"+1","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"e59dff7f5364fc317b469911f6e2fb160fc37518","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        old_share_name \u003d self.helper._get_share_name_by_export_location("},{"line_number":481,"context_line":"            old_export_location, share_proto)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        share_type_flage \u003d True"},{"line_number":484,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":485,"context_line":"        if \u0027capabilities:thin_provisioning\u0027 in specs.keys():"},{"line_number":486,"context_line":"            share_type_flage \u003d False"},{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_70a00a44","line":485,"range":{"start_line":483,"start_character":7,"end_line":485,"end_character":60},"in_reply_to":"1a7b0d38_fb35d245","updated":"2015-12-25 06:30:28.000000000","message":"Done","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"f6855db28c13399361bc3ad9422e8c7708f90a6d","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        share \u003d self.helper._get_share_by_name(old_share_name,"},{"line_number":491,"context_line":"                                               share_url_type)"},{"line_number":492,"context_line":"        if not share:"},{"line_number":493,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_2d6a2db4","line":490,"range":{"start_line":490,"start_character":8,"end_line":490,"end_character":13},"updated":"2015-12-25 03:22:28.000000000","message":"Please do not use the same word as the input parameter","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"e59dff7f5364fc317b469911f6e2fb160fc37518","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":488,"context_line":"            share[\u0027share_type_id\u0027])"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        share \u003d self.helper._get_share_by_name(old_share_name,"},{"line_number":491,"context_line":"                                               share_url_type)"},{"line_number":492,"context_line":"        if not share:"},{"line_number":493,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_edf2e5d1","line":490,"range":{"start_line":490,"start_character":8,"end_line":490,"end_character":13},"in_reply_to":"1a7b0d38_2d6a2db4","updated":"2015-12-25 06:30:28.000000000","message":"Done","commit_id":"900d4403413d75a42cf6b32a72e15f49ed6d74ac"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"845cc03dbd8ecd02ef7cbce74bed067bc46cc852","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        share_type_flag \u003d True"},{"line_number":512,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":513,"context_line":"        if (\u0027capabilities:thin_provisioning\u0027 in specs.keys() or"},{"line_number":514,"context_line":"                \u0027thin_provisioning\u0027 in specs.keys()):"},{"line_number":515,"context_line":"            share_type_flag \u003d False"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_22c78a46","line":514,"range":{"start_line":513,"start_character":0,"end_line":514,"end_character":53},"updated":"2015-12-25 16:53:33.000000000","message":"if ((\u0027capabilities:thin_provisioning\u0027 or\n                \u0027thin_provisioning\u0027) in specs.keys())","commit_id":"51211769a98c21effa6930fb73bdc8d810c8e511"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"6a6f77979aba2bbbb6109725e5d7315ccce480d4","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        share_type_flag \u003d True"},{"line_number":512,"context_line":"        specs \u003d share_types.get_share_type_extra_specs(share[\u0027share_type_id\u0027])"},{"line_number":513,"context_line":"        if (\u0027capabilities:thin_provisioning\u0027 in specs.keys() or"},{"line_number":514,"context_line":"                \u0027thin_provisioning\u0027 in specs.keys()):"},{"line_number":515,"context_line":"            share_type_flag \u003d False"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_ceed8df0","line":514,"range":{"start_line":513,"start_character":0,"end_line":514,"end_character":53},"in_reply_to":"1a7b0d38_22c78a46","updated":"2015-12-26 01:25:35.000000000","message":"Done","commit_id":"51211769a98c21effa6930fb73bdc8d810c8e511"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"845cc03dbd8ecd02ef7cbce74bed067bc46cc852","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":518,"context_line":"            share[\u0027share_type_id\u0027])"},{"line_number":519,"context_line":"        if share_type_flag:"},{"line_number":520,"context_line":"            if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d constants.ALLOC_TYPE_THIN_FLAG:"},{"line_number":521,"context_line":"                opts[\u0027thin_provisioning\u0027] \u003d constants.THIN_PROVISIONING"},{"line_number":522,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_c2dc8614","line":519,"range":{"start_line":519,"start_character":8,"end_line":519,"end_character":27},"updated":"2015-12-25 16:53:33.000000000","message":"You can just remove the flag.\n\nif ((\u0027capabilities:thin_provisioning\u0027  \n        and \u0027thin_provisioning\u0027) not in specs.keys()):\n  if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d constants.ALLOC_TYPE_THIN_FLAG:\n                opts[\u0027thin_provisioning\u0027] \u003d \n                    constants.THIN_PROVISIONING\n            else:\n                opts[\u0027thin_provisioning\u0027] \u003d\n                    constants.THICK_PROVISIONING","commit_id":"51211769a98c21effa6930fb73bdc8d810c8e511"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"6a6f77979aba2bbbb6109725e5d7315ccce480d4","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        opts \u003d huawei_utils.get_share_extra_specs_params("},{"line_number":518,"context_line":"            share[\u0027share_type_id\u0027])"},{"line_number":519,"context_line":"        if share_type_flag:"},{"line_number":520,"context_line":"            if fs[\u0027ALLOCTYPE\u0027] \u003d\u003d constants.ALLOC_TYPE_THIN_FLAG:"},{"line_number":521,"context_line":"                opts[\u0027thin_provisioning\u0027] \u003d constants.THIN_PROVISIONING"},{"line_number":522,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_6ebb39e6","line":519,"range":{"start_line":519,"start_character":8,"end_line":519,"end_character":27},"in_reply_to":"1a7b0d38_c2dc8614","updated":"2015-12-26 01:25:35.000000000","message":"Done","commit_id":"51211769a98c21effa6930fb73bdc8d810c8e511"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5998d19007d30f51eba992a150894618a37506d5","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        try:"},{"line_number":526,"context_line":"            self.retype_share(change_opts, fs_id)"},{"line_number":527,"context_line":"        except exception.InvalidShare:"},{"line_number":528,"context_line":"            LOG.exception(_LE(\u0027Retype share error.\u0027))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"},{"line_number":531,"context_line":"        self.helper._change_fs_name(fs_id, share_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_e0a8718f","line":528,"range":{"start_line":528,"start_character":12,"end_line":528,"end_character":53},"updated":"2015-12-28 16:35:59.000000000","message":"Shouldn\u0027t this except block raise the exception and abort this method? I don\u0027t see any raise inside \"retype_share\" so if this throws exception it is possibly because something failed.\n\nAlso, you could include more information in the message, such as \"old_share_name\".","commit_id":"5a2c2dbf4912f577ba8893a3e8ec2c7e594e1266"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"c91d9cee956451b7293c07307e776000c2ddd69a","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        try:"},{"line_number":526,"context_line":"            self.retype_share(change_opts, fs_id)"},{"line_number":527,"context_line":"        except exception.InvalidShare:"},{"line_number":528,"context_line":"            LOG.exception(_LE(\u0027Retype share error.\u0027))"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        share_size \u003d int(fs[\u0027CAPACITY\u0027]) / units.Mi / 2"},{"line_number":531,"context_line":"        self.helper._change_fs_name(fs_id, share_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_cb0eac8b","line":528,"range":{"start_line":528,"start_character":12,"end_line":528,"end_character":53},"in_reply_to":"1a7b0d38_e0a8718f","updated":"2015-12-29 07:49:40.000000000","message":"Done","commit_id":"5a2c2dbf4912f577ba8893a3e8ec2c7e594e1266"}],"manila/share/drivers/huawei/v3/helper.py":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"55a0947ebd0881c414631c92cf3be3c5feafd4e3","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        data \u003d jsonutils.dumps(fs_param)"},{"line_number":693,"context_line":"        result \u003d self.call(url, data, \"PUT\")"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        msg \u003d _(\"Change share-type error.\")"},{"line_number":696,"context_line":"        self._assert_rest_result(result, msg)"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def _get_partition_id_by_name(self, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_f3247b60","line":695,"range":{"start_line":695,"start_character":24,"end_line":695,"end_character":34},"updated":"2015-12-22 09:53:03.000000000","message":"It\u0027s better to use \"Change extra _epecs\". There\u0027s no share-type on array.","commit_id":"9bc61dc5ac88fb4e73d8546b99e3c56f5d19f079"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    if method \u003d\u003d \"PUT\":"},{"line_number":113,"context_line":"        if data \u003d\u003d \"\"\"{\"CAPACITY\": 10485760}\"\"\":"},{"line_number":114,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":115,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":116,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":117,"context_line":"            extend_share_flag \u003d True"},{"line_number":118,"context_line":"        elif data \u003d\u003d \"\"\"{\"CAPACITY\": 2097152}\"\"\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f8db77eb","line":115,"updated":"2015-12-11 02:52:18.000000000","message":"This function is used when url \u003d\u003d \"/filesystem/5\"（see line 498）but retured ID is 4. Is this you want?","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            extend_share_flag \u003d True"},{"line_number":118,"context_line":"        elif data \u003d\u003d \"\"\"{\"CAPACITY\": 2097152}\"\"\":"},{"line_number":119,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":120,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":121,"context_line":"                \"CAPACITY\":\"2097152\"}}\"\"\""},{"line_number":122,"context_line":"            shrink_share_flag \u003d True"},{"line_number":123,"context_line":"        elif data \u003d\u003d \"\"\"{\"NAME\": \"share_fake_manage_uuid\"}\"\"\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_389fbf04","line":120,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            shrink_share_flag \u003d True"},{"line_number":123,"context_line":"        elif data \u003d\u003d \"\"\"{\"NAME\": \"share_fake_manage_uuid\"}\"\"\":"},{"line_number":124,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":125,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":126,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":127,"context_line":"    elif method \u003d\u003d \"DELETE\":"},{"line_number":128,"context_line":"        data \u003d \"\"\"{\"error\":{\"code\":0}}\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f88937cb","line":125,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    if method \u003d\u003d \"PUT\":"},{"line_number":162,"context_line":"        if data \u003d\u003d \"\"\"{\"CAPACITY\": 10485760}\"\"\":"},{"line_number":163,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":164,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":165,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":166,"context_line":"            extend_share_flag \u003d True"},{"line_number":167,"context_line":"        elif data \u003d\u003d \"\"\"{\"CAPACITY\": 2097152}\"\"\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d88ebbcf","line":164,"updated":"2015-12-11 02:52:18.000000000","message":"Maybe 6","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            extend_share_flag \u003d True"},{"line_number":167,"context_line":"        elif data \u003d\u003d \"\"\"{\"CAPACITY\": 2097152}\"\"\":"},{"line_number":168,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":169,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":170,"context_line":"                \"CAPACITY\":\"2097152\"}}\"\"\""},{"line_number":171,"context_line":"            shrink_share_flag \u003d True"},{"line_number":172,"context_line":"        elif data \u003d\u003d \"\"\"{\"NAME\": \"share_fake_manage_uuid\"}\"\"\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_78bc676c","line":169,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            shrink_share_flag \u003d True"},{"line_number":172,"context_line":"        elif data \u003d\u003d \"\"\"{\"NAME\": \"share_fake_manage_uuid\"}\"\"\":"},{"line_number":173,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":174,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":175,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":176,"context_line":"        elif data \u003d\u003d \"\"\"{\"NAME\": \"share_fake_uuid_inpartition\"}\"\"\":"},{"line_number":177,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f8b0578d","line":174,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":176,"context_line":"        elif data \u003d\u003d \"\"\"{\"NAME\": \"share_fake_uuid_inpartition\"}\"\"\":"},{"line_number":177,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":178,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":179,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":180,"context_line":"        elif data \u003d\u003d \"\"\"{\"ENABLECOMPRESSION\": true, \"ENABLEDEDUP\": true}\"\"\":"},{"line_number":181,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_18ac4334","line":178,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":180,"context_line":"        elif data \u003d\u003d \"\"\"{\"ENABLECOMPRESSION\": true, \"ENABLEDEDUP\": true}\"\"\":"},{"line_number":181,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":182,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":183,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":184,"context_line":"        elif data \u003d\u003d \"\"\"{\"ENABLECOMPRESSION\": false, \"ENABLEDEDUP\": false}\"\"\":"},{"line_number":185,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_b8aacf17","line":182,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"5a3b044da93dd88ec80826adecb2c17145c6c938","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":184,"context_line":"        elif data \u003d\u003d \"\"\"{\"ENABLECOMPRESSION\": false, \"ENABLEDEDUP\": false}\"\"\":"},{"line_number":185,"context_line":"            data \u003d \"\"\"{\"error\":{\"code\":0},"},{"line_number":186,"context_line":"                \"data\":{\"ID\":\"4\","},{"line_number":187,"context_line":"                \"CAPACITY\":\"8388608\"}}\"\"\""},{"line_number":188,"context_line":"    elif method \u003d\u003d \"DELETE\":"},{"line_number":189,"context_line":"        data \u003d \"\"\"{\"error\":{\"code\":0}}\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d8a55b47","line":186,"updated":"2015-12-11 02:52:18.000000000","message":"see above","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fde36f335580c4b442f417a7d785cb14ef3c0741","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"        share_info \u003d self.driver.manage_existing(share,"},{"line_number":1679,"context_line":"                                                 self.driver_options)"},{"line_number":1680,"context_line":"        self.assertEqual(4, share_info[\"size\"])"},{"line_number":1681,"context_line":"        self.assertEqual(path,"},{"line_number":1682,"context_line":"                         share_info[\"export_locations\"])"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    @ddt.data({\"path\": [\"100.115.10.68:/share_fake_uuid_inpartition\"]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_3206e81c","line":1681,"updated":"2015-12-11 11:47:20.000000000","message":"This fits in 1 line.","commit_id":"f5a27ae8cef49e816e21417bfe0ffbb905d8957d"}]}