)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"baafff86866c45ccefee98a4a6ea7c98cc6c12b4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"possibility to mark them with specific labels like fast/slow or"},{"line_number":11,"context_line":"rw/ro."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So, implement \u0027export locations metadata\u0027 feature:"},{"line_number":14,"context_line":"- It allows to set any key-value pairs for each export location."},{"line_number":15,"context_line":"- These key-value pairs can be set only by share manager using"},{"line_number":16,"context_line":"  response from various share driver methods."},{"line_number":17,"context_line":"- Example of update is implemented using Generic driver"},{"line_number":18,"context_line":"  \"create_instance\" method."},{"line_number":19,"context_line":"- Metadata can be updated for any export location in any place"},{"line_number":20,"context_line":"  of share manager where db function \"share_export_locations_update\""},{"line_number":21,"context_line":"  is called."},{"line_number":22,"context_line":"- Keys from export location metadata table will be added to \u0027share\u0027 and"},{"line_number":23,"context_line":"  \u0027share instances\u0027 views as export location attributes."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Also:"},{"line_number":26,"context_line":"- Add new attr \u0027is_admin_only\u0027 for existing export locations model."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"1a7b0d38_82f2f96d","line":23,"range":{"start_line":13,"start_character":0,"end_line":23,"end_character":56},"updated":"2015-12-26 03:54:54.000000000","message":"Is this still WIP?","commit_id":"fac86860a8bb26b34766281754f27d45c5262a43"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"37503fed680b0b360b54d836ae87ee08e7a27801","unresolved":false,"context_lines":[{"line_number":10,"context_line":"possibility to mark them with specific labels like fast/slow or"},{"line_number":11,"context_line":"rw/ro."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So, implement \u0027export locations metadata\u0027 feature:"},{"line_number":14,"context_line":"- It allows to set any key-value pairs for each export location."},{"line_number":15,"context_line":"- These key-value pairs can be set only by share manager using"},{"line_number":16,"context_line":"  response from various share driver methods."},{"line_number":17,"context_line":"- Example of update is implemented using Generic driver"},{"line_number":18,"context_line":"  \"create_instance\" method."},{"line_number":19,"context_line":"- Metadata can be updated for any export location in any place"},{"line_number":20,"context_line":"  of share manager where db function \"share_export_locations_update\""},{"line_number":21,"context_line":"  is called."},{"line_number":22,"context_line":"- Keys from export location metadata table will be added to \u0027share\u0027 and"},{"line_number":23,"context_line":"  \u0027share instances\u0027 views as export location attributes."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Also:"},{"line_number":26,"context_line":"- Add new attr \u0027is_admin_only\u0027 for existing export locations model."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"1a7b0d38_db030841","line":23,"range":{"start_line":13,"start_character":0,"end_line":23,"end_character":56},"in_reply_to":"1a7b0d38_82f2f96d","updated":"2015-12-26 09:02:31.000000000","message":"O.o \n\n\nNo. Why?","commit_id":"fac86860a8bb26b34766281754f27d45c5262a43"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bbf7445068168c1156686cbb59a20e48c25b21a5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"possibility to mark them with specific labels like fast/slow or"},{"line_number":11,"context_line":"rw/ro."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So, implement \u0027export locations metadata\u0027 feature:"},{"line_number":14,"context_line":"- It allows to set any key-value pairs for each export location."},{"line_number":15,"context_line":"- These key-value pairs can be set only by share manager using"},{"line_number":16,"context_line":"  response from various share driver methods."},{"line_number":17,"context_line":"- Example of update is implemented using Generic driver"},{"line_number":18,"context_line":"  \"create_instance\" method."},{"line_number":19,"context_line":"- Metadata can be updated for any export location in any place"},{"line_number":20,"context_line":"  of share manager where db function \"share_export_locations_update\""},{"line_number":21,"context_line":"  is called."},{"line_number":22,"context_line":"- Keys from export location metadata table will be added to \u0027share\u0027 and"},{"line_number":23,"context_line":"  \u0027share instances\u0027 views as export location attributes."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Also:"},{"line_number":26,"context_line":"- Add new attr \u0027is_admin_only\u0027 for existing export locations model."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"1a7b0d38_91aec183","line":23,"range":{"start_line":13,"start_character":0,"end_line":23,"end_character":56},"in_reply_to":"1a7b0d38_d1c5298e","updated":"2015-12-26 11:29:48.000000000","message":"Design was changed. Existing share metadata and this one are different things. So, should not be used in the same way. Lines 22-23 describe how it will be viewed using export location API.","commit_id":"fac86860a8bb26b34766281754f27d45c5262a43"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5f334ff552b5b16a6fe9e08d708d411f16c1dd60","unresolved":false,"context_lines":[{"line_number":10,"context_line":"possibility to mark them with specific labels like fast/slow or"},{"line_number":11,"context_line":"rw/ro."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"So, implement \u0027export locations metadata\u0027 feature:"},{"line_number":14,"context_line":"- It allows to set any key-value pairs for each export location."},{"line_number":15,"context_line":"- These key-value pairs can be set only by share manager using"},{"line_number":16,"context_line":"  response from various share driver methods."},{"line_number":17,"context_line":"- Example of update is implemented using Generic driver"},{"line_number":18,"context_line":"  \"create_instance\" method."},{"line_number":19,"context_line":"- Metadata can be updated for any export location in any place"},{"line_number":20,"context_line":"  of share manager where db function \"share_export_locations_update\""},{"line_number":21,"context_line":"  is called."},{"line_number":22,"context_line":"- Keys from export location metadata table will be added to \u0027share\u0027 and"},{"line_number":23,"context_line":"  \u0027share instances\u0027 views as export location attributes."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Also:"},{"line_number":26,"context_line":"- Add new attr \u0027is_admin_only\u0027 for existing export locations model."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"1a7b0d38_d1c5298e","line":23,"range":{"start_line":13,"start_character":0,"end_line":23,"end_character":56},"in_reply_to":"1a7b0d38_db030841","updated":"2015-12-26 10:27:37.000000000","message":"you previously had APIs to get this metadata..","commit_id":"fac86860a8bb26b34766281754f27d45c5262a43"}],"etc/manila/policy.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":"    \"share_export_location:index\": \"rule:default\","},{"line_number":41,"context_line":"    \"share_export_location:show\": \"rule:default\","},{"line_number":42,"context_line":"    \"share_export_location:get_share_export_location_metadata\": \"rule:default\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_aa5a9128","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":61},"updated":"2015-12-18 08:53:26.000000000","message":"The scope of this policy already exists, so don\u0027t need \u0027share\u0027 in the policy name\n\n\ns/get_share_export_location_metadata/get_export_location_metadata\n\n\nfor consistency and to reduce the length, enhancing readability. \n\n\nExamples: bunch of \u0027create\u0027, \u0027delete\u0027, \u0027show\u0027, \u0027get\u0027, \u0027get_all\u0027 etc","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":"    \"share_export_location:index\": \"rule:default\","},{"line_number":41,"context_line":"    \"share_export_location:show\": \"rule:default\","},{"line_number":42,"context_line":"    \"share_export_location:get_share_export_location_metadata\": \"rule:default\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_8f8c6336","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":61},"in_reply_to":"3a7e1126_0e8639b9","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0429a16589eb8006e1670bf78ed55a5599e3b495","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":"    \"share_export_location:index\": \"rule:default\","},{"line_number":41,"context_line":"    \"share_export_location:show\": \"rule:default\","},{"line_number":42,"context_line":"    \"share_export_location:get_share_export_location_metadata\": \"rule:default\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_0e8639b9","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":61},"in_reply_to":"3a7e1126_6e89fd25","updated":"2015-12-18 09:07:47.000000000","message":"The same could be said about:\n\n\n\"share:show\"\n\n\nand \n\n\n\"share_instance:show\"\n\n\nboth have different policies, \"rule:default\" vs \"rule:admin_api\"\n\n\n?\n\nso, using:\n\n\n\"share_export_location:get_share_export_location_metadata\"\n\n\ncan be simplified to:\n\n\n\"share_export_location:get_export_location_metadata\"\n\n\nor even just\n\n\n\"share_export_location:get_metadata\"\n\n\nIt\u0027s definitely readable and understandable!","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fcb9ac04f952fca5a181fbbab8f6063b8d10e6ea","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"share:reset_status\": \"rule:admin_api\","},{"line_number":40,"context_line":"    \"share_export_location:index\": \"rule:default\","},{"line_number":41,"context_line":"    \"share_export_location:show\": \"rule:default\","},{"line_number":42,"context_line":"    \"share_export_location:get_share_export_location_metadata\": \"rule:default\","},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    \"share_instance:index\": \"rule:admin_api\","},{"line_number":45,"context_line":"    \"share_instance:show\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_6e89fd25","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":61},"in_reply_to":"3a7e1126_aa5a9128","updated":"2015-12-18 09:00:02.000000000","message":"It is related to two differnt APIs that can have different policies. It exactly should have \"share\" here and \"share_instance\" in second case.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"share_instance:reset_status\": \"rule:admin_api\","},{"line_number":48,"context_line":"    \"share_instance_export_location:index\": \"rule:admin_api\","},{"line_number":49,"context_line":"    \"share_instance_export_location:show\": \"rule:admin_api\","},{"line_number":50,"context_line":"    \"share_instance_export_location:get_share_instance_export_location_metadata\": \"rule:admin_api\","},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"share_snapshot:create_snapshot\": \"rule:default\","},{"line_number":53,"context_line":"    \"share_snapshot:delete_snapshot\": \"rule:default\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_4a420d40","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":99},"updated":"2015-12-18 08:53:26.000000000","message":"same","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fcb9ac04f952fca5a181fbbab8f6063b8d10e6ea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"share_instance:reset_status\": \"rule:admin_api\","},{"line_number":48,"context_line":"    \"share_instance_export_location:index\": \"rule:admin_api\","},{"line_number":49,"context_line":"    \"share_instance_export_location:show\": \"rule:admin_api\","},{"line_number":50,"context_line":"    \"share_instance_export_location:get_share_instance_export_location_metadata\": \"rule:admin_api\","},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"share_snapshot:create_snapshot\": \"rule:default\","},{"line_number":53,"context_line":"    \"share_snapshot:delete_snapshot\": \"rule:default\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_ce727149","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":99},"in_reply_to":"3a7e1126_4a420d40","updated":"2015-12-18 09:00:02.000000000","message":"answer is above.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"share_instance:reset_status\": \"rule:admin_api\","},{"line_number":48,"context_line":"    \"share_instance_export_location:index\": \"rule:admin_api\","},{"line_number":49,"context_line":"    \"share_instance_export_location:show\": \"rule:admin_api\","},{"line_number":50,"context_line":"    \"share_instance_export_location:get_share_instance_export_location_metadata\": \"rule:admin_api\","},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    \"share_snapshot:create_snapshot\": \"rule:default\","},{"line_number":53,"context_line":"    \"share_snapshot:delete_snapshot\": \"rule:default\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_2f83ef05","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":99},"in_reply_to":"3a7e1126_ce727149","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/api/v2/router.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        \"export_locations/{export_location_uuid}/metadata\"),"},{"line_number":181,"context_line":"                       controller\u003dself.resources["},{"line_number":182,"context_line":"                           \"share_instance_export_locations\"],"},{"line_number":183,"context_line":"                       action\u003d\"get_share_instance_export_location_metadata\","},{"line_number":184,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        mapper.connect(\"share_instance\","}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_0a1ba51c","line":183,"range":{"start_line":183,"start_character":31,"end_line":183,"end_character":74},"updated":"2015-12-18 08:53:26.000000000","message":"same concern here. a rather long name for a getter api","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                        \"export_locations/{export_location_uuid}/metadata\"),"},{"line_number":181,"context_line":"                       controller\u003dself.resources["},{"line_number":182,"context_line":"                           \"share_instance_export_locations\"],"},{"line_number":183,"context_line":"                       action\u003d\"get_share_instance_export_location_metadata\","},{"line_number":184,"context_line":"                       conditions\u003d{\"method\": [\"GET\"]})"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        mapper.connect(\"share_instance\","}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_01512762","line":183,"range":{"start_line":183,"start_character":31,"end_line":183,"end_character":74},"in_reply_to":"3a7e1126_0a1ba51c","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/api/v2/share_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def index(self, req, share_id):"},{"line_number":37,"context_line":"        \"\"\"Return a list of export locations for share.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":40,"context_line":"        if context.is_admin:"},{"line_number":41,"context_line":"            export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":42,"context_line":"                context, share_id, include_admin_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_aa5db17a","line":39,"range":{"start_line":39,"start_character":45,"end_line":39,"end_character":47},"updated":"2015-12-18 08:53:26.000000000","message":"Add validation for the share_id...\nThe user would expect a relevant message, not just a 404, or 500..","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def index(self, req, share_id):"},{"line_number":37,"context_line":"        \"\"\"Return a list of export locations for share.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":40,"context_line":"        if context.is_admin:"},{"line_number":41,"context_line":"            export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":42,"context_line":"                context, share_id, include_admin_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_3aa32851","line":39,"range":{"start_line":39,"start_character":45,"end_line":39,"end_character":47},"in_reply_to":"3a7e1126_aa5db17a","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def index(self, req, share_id):"},{"line_number":37,"context_line":"        \"\"\"Return a list of export locations for share.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":40,"context_line":"        if context.is_admin:"},{"line_number":41,"context_line":"            export_locations \u003d db_api.share_export_locations_get_by_share_id("},{"line_number":42,"context_line":"                context, share_id, include_admin_only\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_7ad77023","line":39,"range":{"start_line":39,"start_character":45,"end_line":39,"end_character":47},"in_reply_to":"3a7e1126_aa5db17a","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Return data about the requested export location.\"\"\""},{"line_number":53,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            el \u003d db_api.share_export_location_get_by_uuid("},{"line_number":57,"context_line":"                context, export_location_uuid)"},{"line_number":58,"context_line":"        except exception.ExportLocationNotFound as e:"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_f015e69a","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":12},"updated":"2015-12-18 08:53:26.000000000","message":"Add validation for the share_id","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Return data about the requested export location.\"\"\""},{"line_number":53,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            el \u003d db_api.share_export_location_get_by_uuid("},{"line_number":57,"context_line":"                context, export_location_uuid)"},{"line_number":58,"context_line":"        except exception.ExportLocationNotFound as e:"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_da8a24bf","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":12},"in_reply_to":"3a7e1126_f015e69a","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Return data about the requested export location.\"\"\""},{"line_number":53,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            el \u003d db_api.share_export_location_get_by_uuid("},{"line_number":57,"context_line":"                context, export_location_uuid)"},{"line_number":58,"context_line":"        except exception.ExportLocationNotFound as e:"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_dae8e4e4","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":12},"in_reply_to":"3a7e1126_f015e69a","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            if not el.is_admin_only:"},{"line_number":65,"context_line":"                return self._view_builder.summary(el)"},{"line_number":66,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":67,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":70,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_2516d2f1","line":67,"range":{"start_line":67,"start_character":22,"end_line":67,"end_character":34},"updated":"2015-12-18 08:53:26.000000000","message":"apt response is HTTPForbidden... \n\nIf the user has access to an export location uuid, this message would be very confusing!","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            if not el.is_admin_only:"},{"line_number":65,"context_line":"                return self._view_builder.summary(el)"},{"line_number":66,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":67,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":70,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_c12b1f93","line":67,"range":{"start_line":67,"start_character":22,"end_line":67,"end_character":34},"in_reply_to":"3a7e1126_2516d2f1","updated":"2015-12-18 11:18:44.000000000","message":"What do you mean by \"if\"? Admin-only export locations not for users by design. So, it is exactly \"NotFound\". \"Forbidden\" would be if user not allowed to perform such request in general.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            metadata \u003d db_api.export_location_metadata_get("},{"line_number":78,"context_line":"                context, export_location_uuid)"},{"line_number":79,"context_line":"            return {\"metadata\": metadata}"},{"line_number":80,"context_line":"        except exception.ExportLocationNotFound as e:"},{"line_number":81,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_506e3a30","line":79,"range":{"start_line":79,"start_character":19,"end_line":79,"end_character":21},"updated":"2015-12-18 08:53:26.000000000","message":"Please delegate to view builder , we *may* need to filter/customize this metadata dict in the future","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            metadata \u003d db_api.export_location_metadata_get("},{"line_number":78,"context_line":"                context, export_location_uuid)"},{"line_number":79,"context_line":"            return {\"metadata\": metadata}"},{"line_number":80,"context_line":"        except exception.ExportLocationNotFound as e:"},{"line_number":81,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_24a6b110","line":79,"range":{"start_line":79,"start_character":19,"end_line":79,"end_character":21},"in_reply_to":"3a7e1126_506e3a30","updated":"2015-12-18 11:18:44.000000000","message":"Right now there is nothing to do in view builder. I would like to leave it as is.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91035327e28d4382fba9104bd8415cb596b1b6d1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_089b6d73","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"updated":"2015-12-18 19:31:05.000000000","message":"Response to your response on Patchset 27.. \n\nhttps://review.openstack.org/#/c/251930/27..31/manila/api/v2/share_export_locations.py\n\n\nNorman Doors problem. \n\nAs a user, if i see an export location UUID *somehow* and would like to request information about it, and i receive a NotFound exception; and I continue to see the export location UUID in the place I first found it, I would go bonkers assuming Manila is somehow crazy. \n\nSo, acceptable behavior would be:\n\n - Either, as a user, I should never see the UUID of an *admin_only* \n    export location in the first place ...  or,\n - If I\u0027m allowed to see and grab the UUID, and request\n    its information: I should be told that I have no permission \n    to see the details. It\u0027s like policy not authorized, isn\u0027t it?\n\n\n\nReceiving a NotFound on a UUID that exists someplace else is truly bad user experience. If you tell me there\u0027s no way a user will see an admin_only export location, then this check shouldn\u0027t exist, right? :)","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"f18510baa259a859d3ff70a1936b056504af48e5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_95b21105","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"in_reply_to":"3a7e1126_089b6d73","updated":"2015-12-18 20:10:05.000000000","message":"I think I agree, if a user tries to perform an action they are not allowed to and never will be, its a Forbidden.","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1adfdb9e6f3cb1879f82a35d2f46f66137f198d8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_e9b85977","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"in_reply_to":"3a7e1126_665d7614","updated":"2015-12-19 08:51:47.000000000","message":"You propose to violate security. Stating \"403\" you say \"yes, it exists, but I will not provide you information\". Stating \"404\" we say \"this resource is absent in your context\". And the latter is completely valid. It makes no value where did you get know the UUID, at all. Your context does not have it. 404.\n\nThe only thing I would agree to change - it is provide same message for both 404 places. Now it is different we are able to calculate the situation by message.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nAbout quote\n\n\"I *know* the resource exists because I somehow got access to its UUID.\" \n\n- false statement. You cannot know that it exist getting 404. But you can if you get 403. The only thing you can be sure about is \"it is proper UUID-like string\", no more.","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b9677355c6229300256b9dd785e4d2a9649320c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_665d7614","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"in_reply_to":"3a7e1126_9580d1f8","updated":"2015-12-19 05:15:49.000000000","message":"Yes, I understand enforcing policy based on project_id to restrict actions. That\u0027s how we\u0027re \u0027hiding\u0027 resources between tenants. This isn\u0027t the same.. If you were to draw the sequence of actions to end up here:\n\n\n1) Call action \"show\" on share_export_locations with a UUID\n2) Server retrieves export location data from the DB and validates if the caller has access to the resource.\n\n\nSo, since 1) has occurred, I have a problem with seeing a 404, HTTPNotFound. I *know* the resource exists because I somehow got access to its UUID. \n\n\nIf you\u0027re saying a normal user can/never will get access to the UUID, then this check also shouldn\u0027t be done? \n\n\nadmin_only resources and admin_only actions should be treated the same.. policy gating restricts admin_only actions with 403 Forbidden; APIs should do the same thing with admin_only resources..","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"881071a3ad02a998f053a277974064531b246377","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_9580d1f8","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"in_reply_to":"3a7e1126_95b21105","updated":"2015-12-18 20:12:57.000000000","message":"\"Action\" is allowed. Resource is \"hidden\". Completely same approach as ID of share from another tenant.\n\nGoutham, there is no user API to see admin export location. So, if you don\u0027t have any admin creds you will never know that it even exists.","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1b4fa8bda227f0e85bf33eb6d14109de1f9bf9fb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_343314ad","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"in_reply_to":"3a7e1126_d43e508a","updated":"2015-12-19 09:43:38.000000000","message":"Goutham, \"looking over admin\u0027s shoulder\" and \"get know somehow\" are not arguments. Here, we have \"technical\" approach. And here is no shoulders, only \"user context\".\n\nIn new patch-set imrpvode logic of \"get_metadata\" to be consistent as \"show\" and added unit tests to all not covered cases of NotFound.","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc2d980881b4d00cf489323844e2bb2d31d0b687","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if not el.is_admin_only:"},{"line_number":73,"context_line":"                return self._view_builder.summary(el)"},{"line_number":74,"context_line":"            msg \u003d _(\"Export location \u0027%s\u0027 not found.\") % export_location_uuid"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_d43e508a","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"in_reply_to":"3a7e1126_e9b85977","updated":"2015-12-19 09:34:55.000000000","message":"I apologize for not being clear; what i meant was:\n\nIf you are gating against this resource being divulged, you have assumed that the request has come from a person who has access to the UUID and knows the exact endpoint to hit \"/{project_id}/shares/{share_id}/export_locations/{export_location_uuid}\"\n\n\n\nSo, the caller knows more than its just a UUID. He/she knows that its an export location UUID, because wouldn\u0027t randomly make a CLI or CURL request to that endpoint. \n\n\n\nAnother way of stating my point is, if we assume that the user is hitting the right endpoint, but we know they shouldn\u0027t see the resource, we should return HTTPForbidden. \n\n\n\nHow is this a violation of security?\n\n\n\nThis is not equivalent to website login forms where the error messages do not disclose exactly what is wrong, they say \"Either the username or your password does not match our records\" or the like. \n\n\n\nThis should be equivalent to saying:\n1) I know who you are, I understand your request... but I cannot comply because you do not have access to this resource. \n\n\n\nIf you look at the index call above, you have ensured that admin context is required to list admin_only export locations. However, you have this condition for the \u0027show\u0027 call. The condition itself is perfectly valid, what if there is a user, leaning over the admin\u0027s shoulder looks at the export locations, notes down the UUID and then logs in as himself and attempts to get the details of it. Perfectly possible :) So, I agree with having the condition; but I feel, from an APIImpact point of view, I want to ensure we are providing a consistent, sensible user experience.","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1033aa223fd8f34cfb499c5a5ee17a66de7cbb38","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            if not el.is_admin_only:"},{"line_number":74,"context_line":"                return self._view_builder.summary(el)"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dnot_found_msg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\u00272.9\u0027)"},{"line_number":78,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":32,"id":"3a7e1126_faa7b508","line":75,"range":{"start_line":75,"start_character":18,"end_line":75,"end_character":34},"updated":"2015-12-19 14:01:31.000000000","message":"Pursuant to our discussion on patchset 31, \n\nhttps://review.openstack.org/#/c/251930/31..31/manila/api/v2/share_export_locations.py\n\n\nValeriy, I still strongly think that this hurts user experience.. You are saying the user has no way of finding the UUID or knowing for sure if the UUID is an export location; while that may be true, the purpose of this step should be verifying the resource against an established policy and raising NotAuthorized, i.e HTTPForbidden. This is a wrong response. So is the change you made below on line 96. \n\nYour objective about hiding resources is met in the index call above where you are filtering out admin_only export locations for a normal user. Once a UUID is acquired, the response should be Forbidden, and nothing else. It is NOT a security violation to admit that an admin only export location exists. \n\nCould you point me to an example of a similar behavior?\n\nI can recall one, right here in Manila: quota_class_sets and quota_sets:\n\nCheck what we\u0027re doing in the DB here:\nhttps://github.com/openstack/manila/blob/51069d5/manila/db/sqlalchemy/api.py#L127\n\nand in the show methods here:\nhttps://github.com/openstack/manila/blob/51069d5/manila/api/v2/quota_class_sets.py#L42\n\nand here:\nhttps://github.com/openstack/manila/blob/51069d5/manila/api/v2/quota_sets.py#L74\n\n\nIn these, we\u0027re allowing the action (policy check occurs prior) but restricting the resource. I think the case here is exactly the same. For consistency, please change the behavior. :)","commit_id":"4c05e357797df52f125c229b0117e2051e34ed82"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bf9579e5d192ba86b6e0fd280200dc695848a675","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            if not el.is_admin_only:"},{"line_number":74,"context_line":"                return self._view_builder.summary(el)"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dnot_found_msg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a7b0d38_084e4496","line":75,"updated":"2015-12-24 20:41:56.000000000","message":"Why is this a HTTPNotFound?  This is a permission issue.  Should not be not found.  I see a comment from Goutham on this as well.","commit_id":"dc77edba2fad0ced7bef70a1a317aa048cd0e106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3d525d6362b700f0b2518e35b94fa24a81cb0986","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            if not el.is_admin_only:"},{"line_number":74,"context_line":"                return self._view_builder.summary(el)"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dnot_found_msg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a7b0d38_84453318","line":75,"in_reply_to":"1a7b0d38_084e4496","updated":"2015-12-25 12:22:32.000000000","message":"+1\n\nThe only other case i\u0027ve seen for this sort of behavior is Cinder, and they\u0027re doing it only to maintain backwards compatibility.\n\nhttps://github.com/openstack/cinder/blob/64c0b7738c1fd91c24a13d5e7dd5b826aecd9193/cinder/volume/api.py#L485\n\nI feel since the user and admin are of the same tenant, like all other resources and actions, we should return HTTPForbidden for consistency. \n\nOf course, across tenants, this security by obscurity approach may be valid..","commit_id":"dc77edba2fad0ced7bef70a1a317aa048cd0e106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b72bc7b6ba7fe1fa0373fa4a027be3b49ceffb0d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            if not el.is_admin_only:"},{"line_number":74,"context_line":"                return self._view_builder.summary(el)"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound(explanation\u003dnot_found_msg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a7b0d38_24223f53","line":75,"in_reply_to":"1a7b0d38_84453318","updated":"2015-12-25 12:24:45.000000000","message":"I agree with the approach to \"hide\" the resources in the first place.. but then, if they are always hidden and this check is necessary, it should be a HTTPForbidden for consistency.","commit_id":"dc77edba2fad0ced7bef70a1a317aa048cd0e106"}],"manila/api/v2/share_instance_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @wsgi.Controller.authorize"},{"line_number":35,"context_line":"    def index(self, req, share_instance_id):"},{"line_number":36,"context_line":"        \"\"\"Return a list of export locations for the share instance.\"\"\""},{"line_number":37,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":38,"context_line":"        export_locations \u003d ("},{"line_number":39,"context_line":"            db_api.share_export_locations_get_by_share_instance_id("},{"line_number":40,"context_line":"                context, share_instance_id))"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_b03e7ed8","line":37,"range":{"start_line":37,"start_character":45,"end_line":37,"end_character":47},"updated":"2015-12-18 08:53:26.000000000","message":"Validate share_instance id here","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @wsgi.Controller.authorize"},{"line_number":45,"context_line":"    def show(self, req, share_instance_id, export_location_uuid):"},{"line_number":46,"context_line":"        \"\"\"Return data about the requested export location.\"\"\""},{"line_number":47,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            el \u003d db_api.share_export_location_get_by_uuid("},{"line_number":50,"context_line":"                context, export_location_uuid)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_6b6eeb97","line":47,"range":{"start_line":47,"start_character":45,"end_line":47,"end_character":47},"updated":"2015-12-18 08:53:26.000000000","message":"validate share_instance_id here","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            metadata \u003d db_api.export_location_metadata_get("},{"line_number":64,"context_line":"                context, export_location_uuid)"},{"line_number":65,"context_line":"            return {\"metadata\": metadata}"},{"line_number":66,"context_line":"        except exception.ExportLocationNotFound as e:"},{"line_number":67,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_cbd35f37","line":65,"range":{"start_line":65,"start_character":21,"end_line":65,"end_character":29},"updated":"2015-12-18 08:53:26.000000000","message":"same concern here: please delegate to view builder","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        try:"},{"line_number":63,"context_line":"            metadata \u003d db_api.export_location_metadata_get("},{"line_number":64,"context_line":"                context, export_location_uuid)"},{"line_number":65,"context_line":"            return {\"metadata\": metadata}"},{"line_number":66,"context_line":"        except exception.ExportLocationNotFound as e:"},{"line_number":67,"context_line":"            raise exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_848c4536","line":65,"range":{"start_line":65,"start_character":21,"end_line":65,"end_character":29},"in_reply_to":"3a7e1126_cbd35f37","updated":"2015-12-18 11:18:44.000000000","message":"Right now there is nothing to do in view builder. I would like to leave it as is.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/api/views/export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67186c535fcf6f22fe677fd18143cf6873d597c3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":20,"context_line":"    \"\"\"Model export-locations API responses as a python dictionary.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    _collection_name \u003d \"export-locations\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _get_export_location_view(self, export_location, detail\u003dFalse):"},{"line_number":25,"context_line":"        view \u003d {"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_0198e068","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":40},"updated":"2016-01-06 21:41:08.000000000","message":"for consistency, this should be \"export_locations\", as below and\n\nlike \"consistency_groups\" and \"quota_class_set\" or \"security_services\" or share_instances, share_networks, share_servers.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"015303946b5780bbc4048886acc0954ff0c57ae0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":20,"context_line":"    \"\"\"Model export-locations API responses as a python dictionary.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    _collection_name \u003d \"export-locations\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _get_export_location_view(self, export_location, detail\u003dFalse):"},{"line_number":25,"context_line":"        view \u003d {"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_66b5f2ce","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":40},"in_reply_to":"fa69d971_0198e068","updated":"2016-01-07 22:13:49.000000000","message":"https://github.com/openstack/manila/blob/master/manila/api/views/scheduler_stats.py","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8504bb8148bab4afdb6823fa62ae453b8d347dde","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":20,"context_line":"    \"\"\"Model export-locations API responses as a python dictionary.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    _collection_name \u003d \"export-locations\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _get_export_location_view(self, export_location, detail\u003dFalse):"},{"line_number":25,"context_line":"        view \u003d {"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_4cec52f3","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":40},"in_reply_to":"fa69d971_09f689d7","updated":"2016-01-08 13:14:11.000000000","message":"It did not make any influence, but renamed it and reused on line 60.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5eadcb2835a05d3e100f1217606928f78d6ebb49","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class ViewBuilder(common.ViewBuilder):"},{"line_number":20,"context_line":"    \"\"\"Model export-locations API responses as a python dictionary.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    _collection_name \u003d \"export-locations\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _get_export_location_view(self, export_location, detail\u003dFalse):"},{"line_number":25,"context_line":"        view \u003d {"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_09f689d7","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":40},"in_reply_to":"fa69d971_66b5f2ce","updated":"2016-01-07 22:30:33.000000000","message":"That seems to be the only one that is a mismatch.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67186c535fcf6f22fe677fd18143cf6873d597c3","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def summary(self, export_location):"},{"line_number":50,"context_line":"        \"\"\"Summary view of a single export location.\"\"\""},{"line_number":51,"context_line":"        return self._get_export_location_view(export_location, detail\u003dFalse)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def detail(self, export_location):"},{"line_number":54,"context_line":"        \"\"\"Detailed view of a single export location.\"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_e1c26c84","line":51,"range":{"start_line":51,"start_character":61,"end_line":51,"end_character":75},"updated":"2016-01-06 21:41:08.000000000","message":"already set as default above.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"015303946b5780bbc4048886acc0954ff0c57ae0","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def summary(self, export_location):"},{"line_number":50,"context_line":"        \"\"\"Summary view of a single export location.\"\"\""},{"line_number":51,"context_line":"        return self._get_export_location_view(export_location, detail\u003dFalse)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def detail(self, export_location):"},{"line_number":54,"context_line":"        \"\"\"Detailed view of a single export location.\"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_0679962f","line":51,"range":{"start_line":51,"start_character":61,"end_line":51,"end_character":75},"in_reply_to":"fa69d971_e1c26c84","updated":"2016-01-07 22:13:49.000000000","message":"And?","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67186c535fcf6f22fe677fd18143cf6873d597c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def summary_list(self, export_locations):"},{"line_number":70,"context_line":"        \"\"\"Summary View of export locations list.\"\"\""},{"line_number":71,"context_line":"        return self._list_export_locations(export_locations, detail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_4161f8a7","line":71,"range":{"start_line":71,"start_character":59,"end_line":71,"end_character":73},"updated":"2016-01-06 21:41:08.000000000","message":"same","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"}],"manila/api/views/share_instance.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    _collection_name \u003d \u0027share_instances\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":22,"context_line":"        \"remove_export_locations_from_view\","},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def detail_list(self, request, instances):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_cb2b5fea","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":42},"updated":"2015-12-18 08:53:26.000000000","message":"s/remove_export_locations_from_view/remove_export_locations","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    _collection_name \u003d \u0027share_instances\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":22,"context_line":"        \"remove_export_locations_from_view\","},{"line_number":23,"context_line":"    ]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def detail_list(self, request, instances):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_4fce7bb5","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":42},"in_reply_to":"3a7e1126_cb2b5fea","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return instances_dict"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @common.ViewBuilder.versioned_method(\"2.9\")"},{"line_number":64,"context_line":"    def remove_export_locations_from_view(self, share_instance_dict,"},{"line_number":65,"context_line":"                                          share_instance):"},{"line_number":66,"context_line":"        share_instance_dict.pop(\u0027export_location\u0027)"},{"line_number":67,"context_line":"        share_instance_dict.pop(\u0027export_locations\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_8b0c7795","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":41},"updated":"2015-12-18 08:53:26.000000000","message":"s/remove_export_locations_from_view/remove_export_locations\n\n\n\nconsistency nit","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return instances_dict"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @common.ViewBuilder.versioned_method(\"2.9\")"},{"line_number":64,"context_line":"    def remove_export_locations_from_view(self, share_instance_dict,"},{"line_number":65,"context_line":"                                          share_instance):"},{"line_number":66,"context_line":"        share_instance_dict.pop(\u0027export_location\u0027)"},{"line_number":67,"context_line":"        share_instance_dict.pop(\u0027export_locations\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_efc5e78d","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":41},"in_reply_to":"3a7e1126_8b0c7795","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/api/views/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"add_consistency_group_fields\","},{"line_number":26,"context_line":"        \"add_task_state_field\","},{"line_number":27,"context_line":"        \"modify_share_type_field\","},{"line_number":28,"context_line":"        \"remove_export_locations_from_view\","},{"line_number":29,"context_line":"    ]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def summary_list(self, request, shares):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_2ba9c37b","line":28,"range":{"start_line":28,"start_character":9,"end_line":28,"end_character":42},"updated":"2015-12-18 08:53:26.000000000","message":"s/remove_export_locations_from_view/remove_export_locations","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"add_consistency_group_fields\","},{"line_number":26,"context_line":"        \"add_task_state_field\","},{"line_number":27,"context_line":"        \"modify_share_type_field\","},{"line_number":28,"context_line":"        \"remove_export_locations_from_view\","},{"line_number":29,"context_line":"    ]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def summary_list(self, request, shares):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_0f9393a4","line":28,"range":{"start_line":28,"start_character":9,"end_line":28,"end_character":42},"in_reply_to":"3a7e1126_2ba9c37b","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        })"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @common.ViewBuilder.versioned_method(\"2.9\")"},{"line_number":122,"context_line":"    def remove_export_locations_from_view(self, share_dict, share):"},{"line_number":123,"context_line":"        share_dict.pop(\u0027export_location\u0027)"},{"line_number":124,"context_line":"        share_dict.pop(\u0027export_locations\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_8bb0f7de","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":41},"updated":"2015-12-18 08:53:26.000000000","message":"s/remove_export_locations_from_view/remove_export_locations","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        })"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @common.ViewBuilder.versioned_method(\"2.9\")"},{"line_number":122,"context_line":"    def remove_export_locations_from_view(self, share_dict, share):"},{"line_number":123,"context_line":"        share_dict.pop(\u0027export_location\u0027)"},{"line_number":124,"context_line":"        share_dict.pop(\u0027export_locations\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_af911f9b","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":41},"in_reply_to":"3a7e1126_8bb0f7de","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/db/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":607,"context_line":"    \"\"\"Get all exports locations of a share.\"\"\""},{"line_number":608,"context_line":"    return IMPL.share_export_locations_get(context, share_id)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_5ea07643","line":607,"range":{"start_line":607,"start_character":15,"end_line":607,"end_character":22},"updated":"2015-12-18 08:53:26.000000000","message":"s/exports/export","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":604,"context_line":""},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":607,"context_line":"    \"\"\"Get all exports locations of a share.\"\"\""},{"line_number":608,"context_line":"    return IMPL.share_export_locations_get(context, share_id)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_cf190b7b","line":607,"range":{"start_line":607,"start_character":15,"end_line":607,"end_character":22},"in_reply_to":"3a7e1126_5ea07643","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":610,"context_line":""},{"line_number":611,"context_line":"def share_export_locations_get_by_share_id(context, share_id,"},{"line_number":612,"context_line":"                                           include_admin_only\u003dTrue):"},{"line_number":613,"context_line":"    \"\"\"Get all exports locations of a share by its ID.\"\"\""},{"line_number":614,"context_line":"    return IMPL.share_export_locations_get_by_share_id("},{"line_number":615,"context_line":"        context, share_id, include_admin_only\u003dinclude_admin_only)"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_7ea3f24f","line":613,"range":{"start_line":613,"start_character":15,"end_line":613,"end_character":22},"updated":"2015-12-18 08:53:26.000000000","message":"same","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":610,"context_line":""},{"line_number":611,"context_line":"def share_export_locations_get_by_share_id(context, share_id,"},{"line_number":612,"context_line":"                                           include_admin_only\u003dTrue):"},{"line_number":613,"context_line":"    \"\"\"Get all exports locations of a share by its ID.\"\"\""},{"line_number":614,"context_line":"    return IMPL.share_export_locations_get_by_share_id("},{"line_number":615,"context_line":"        context, share_id, include_admin_only\u003dinclude_admin_only)"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_6f4ed770","line":613,"range":{"start_line":613,"start_character":15,"end_line":613,"end_character":22},"in_reply_to":"3a7e1126_7ea3f24f","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def share_export_locations_update(context, share_instance_id, export_locations,"},{"line_number":626,"context_line":"                                  delete\u003dTrue):"},{"line_number":627,"context_line":"    \"\"\"Update export locations of share instance.\"\"\""},{"line_number":628,"context_line":"    return IMPL.share_export_locations_update("},{"line_number":629,"context_line":"        context, share_instance_id, export_locations, delete)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_9ebd7e6a","line":627,"range":{"start_line":627,"start_character":34,"end_line":627,"end_character":39},"updated":"2015-12-18 08:53:26.000000000","message":"a share instance","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":624,"context_line":""},{"line_number":625,"context_line":"def share_export_locations_update(context, share_instance_id, export_locations,"},{"line_number":626,"context_line":"                                  delete\u003dTrue):"},{"line_number":627,"context_line":"    \"\"\"Update export locations of share instance.\"\"\""},{"line_number":628,"context_line":"    return IMPL.share_export_locations_update("},{"line_number":629,"context_line":"        context, share_instance_id, export_locations, delete)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_cf302beb","line":627,"range":{"start_line":627,"start_character":34,"end_line":627,"end_character":39},"in_reply_to":"3a7e1126_9ebd7e6a","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/db/migrations/alembic/versions/dda6de06349_add_export_locations_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # Generate UUID for each existing export location."},{"line_number":60,"context_line":"        el_table \u003d sa.Table("},{"line_number":61,"context_line":"            EL_TABLE_NAME, meta,"},{"line_number":62,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer),"},{"line_number":63,"context_line":"            sa.Column(\u0027uuid\u0027, sa.String(36)),"},{"line_number":64,"context_line":"            sa.Column(\u0027is_admin_only\u0027, sa.Boolean),"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        for record in el_table.select().execute():"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_1e042e48","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":45},"updated":"2015-12-18 08:53:26.000000000","message":"any particular reason why id and uuid?","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # Generate UUID for each existing export location."},{"line_number":60,"context_line":"        el_table \u003d sa.Table("},{"line_number":61,"context_line":"            EL_TABLE_NAME, meta,"},{"line_number":62,"context_line":"            sa.Column(\u0027id\u0027, sa.Integer),"},{"line_number":63,"context_line":"            sa.Column(\u0027uuid\u0027, sa.String(36)),"},{"line_number":64,"context_line":"            sa.Column(\u0027is_admin_only\u0027, sa.Boolean),"},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        for record in el_table.select().execute():"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_54712edf","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":45},"in_reply_to":"3a7e1126_1e042e48","updated":"2015-12-18 11:18:44.000000000","message":"\"ID\" already exist and it is integer primary key. For API facing we need add UUID-like. \"ID\" is left as primary key to reduce amount of changes, also it leaves better compatibility with previous approach.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                el_table.c.id \u003d\u003d record.id,"},{"line_number":72,"context_line":"            ).execute()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Make new \u0027uuid\u0027 column in export locations table not nullable."},{"line_number":75,"context_line":"        op.alter_column("},{"line_number":76,"context_line":"            EL_TABLE_NAME,"},{"line_number":77,"context_line":"            \u0027uuid\u0027,"},{"line_number":78,"context_line":"            existing_type\u003dsa.String(length\u003d36),"},{"line_number":79,"context_line":"            nullable\u003dFalse,"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"    except Exception:"},{"line_number":82,"context_line":"        LOG.error(_LE(\"Failed to update \u0027%s\u0027 table!\"),"},{"line_number":83,"context_line":"                  EL_TABLE_NAME)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_63459d6e","line":80,"range":{"start_line":74,"start_character":8,"end_line":80,"end_character":9},"updated":"2015-12-18 08:53:26.000000000","message":"Could this be added directly on line 63?\n\nsa.Column(\u0027uuid\u0027, sa.String(36), nullable\u003dFalse)","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                el_table.c.id \u003d\u003d record.id,"},{"line_number":72,"context_line":"            ).execute()"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # Make new \u0027uuid\u0027 column in export locations table not nullable."},{"line_number":75,"context_line":"        op.alter_column("},{"line_number":76,"context_line":"            EL_TABLE_NAME,"},{"line_number":77,"context_line":"            \u0027uuid\u0027,"},{"line_number":78,"context_line":"            existing_type\u003dsa.String(length\u003d36),"},{"line_number":79,"context_line":"            nullable\u003dFalse,"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"    except Exception:"},{"line_number":82,"context_line":"        LOG.error(_LE(\"Failed to update \u0027%s\u0027 table!\"),"},{"line_number":83,"context_line":"                  EL_TABLE_NAME)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_4e020171","line":80,"range":{"start_line":74,"start_character":8,"end_line":80,"end_character":9},"in_reply_to":"3a7e1126_63459d6e","updated":"2015-12-18 11:18:44.000000000","message":"It is migration code. Columns already will exist for moment of addon of column. So, we first add nullable column, write data, then make it not nullable.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        op.drop_column(EL_TABLE_NAME, \u0027is_admin_only\u0027)"},{"line_number":117,"context_line":"        op.drop_column(EL_TABLE_NAME, \u0027uuid\u0027)"},{"line_number":118,"context_line":"    except Exception:"},{"line_number":119,"context_line":"        LOG.error(_LE(\"Failed to update \u0027%s\u0027 table.\"), EL_TABLE_NAME)"},{"line_number":120,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_c367b123","line":119,"range":{"start_line":119,"start_character":50,"end_line":119,"end_character":54},"updated":"2015-12-18 08:53:26.000000000","message":"nit: exclamation everywhere else above, period here.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        op.drop_column(EL_TABLE_NAME, \u0027is_admin_only\u0027)"},{"line_number":117,"context_line":"        op.drop_column(EL_TABLE_NAME, \u0027uuid\u0027)"},{"line_number":118,"context_line":"    except Exception:"},{"line_number":119,"context_line":"        LOG.error(_LE(\"Failed to update \u0027%s\u0027 table.\"), EL_TABLE_NAME)"},{"line_number":120,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_941c7678","line":119,"range":{"start_line":119,"start_character":50,"end_line":119,"end_character":54},"in_reply_to":"3a7e1126_c367b123","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":36,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def to_dict(model):"},{"line_number":40,"context_line":"    \"\"\"Transforms some model instance to dict."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Each attribute that is in orm.relationship will be transformed too,"},{"line_number":43,"context_line":"    so, result dictionary will not contain any detached model objects."},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":"    model_dict \u003d {}"},{"line_number":46,"context_line":"    if not hasattr(model, \u0027_met_ancestors\u0027):"},{"line_number":47,"context_line":"        model._met_ancestors \u003d [model]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_single_primitive(value):"},{"line_number":50,"context_line":"        setattr(value, \u0027_met_ancestors\u0027, model._met_ancestors)"},{"line_number":51,"context_line":"        if value not in value._met_ancestors:"},{"line_number":52,"context_line":"            model._met_ancestors.append(value)"},{"line_number":53,"context_line":"            return to_dict(value)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    for k, v in six.iteritems(model):"},{"line_number":56,"context_line":"        # NOTE(vponomaryov): exclude private and reserved attributes"},{"line_number":57,"context_line":"        # and circularly referenced attrs from addition to dict view."},{"line_number":58,"context_line":"        if k[0] \u003d\u003d \"_\" or v in model._met_ancestors:"},{"line_number":59,"context_line":"            continue"},{"line_number":60,"context_line":"        elif isinstance(v, (six.string_types, six.integer_types, bool, dict)):"},{"line_number":61,"context_line":"            model_dict[k] \u003d v"},{"line_number":62,"context_line":"        elif issubclass(type(v), ManilaBase):"},{"line_number":63,"context_line":"            model_dict[k] \u003d get_single_primitive(v)"},{"line_number":64,"context_line":"        elif isinstance(v, list):"},{"line_number":65,"context_line":"            v_list \u003d []"},{"line_number":66,"context_line":"            # NOTE(vponomaryov): iterate all elements of list"},{"line_number":67,"context_line":"            # that can be either some model instances or common primitives."},{"line_number":68,"context_line":"            for list_element in v:"},{"line_number":69,"context_line":"                # NOTE(vponomaryov): case when we have list of lists"},{"line_number":70,"context_line":"                # is not expected."},{"line_number":71,"context_line":"                if issubclass(type(list_element), ManilaBase):"},{"line_number":72,"context_line":"                    list_element \u003d get_single_primitive(list_element)"},{"line_number":73,"context_line":"                v_list.append(list_element)"},{"line_number":74,"context_line":"            model_dict[k] \u003d v_list"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    return model_dict"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ManilaBase(models.ModelBase,"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_00ccc868","line":76,"range":{"start_line":39,"start_character":0,"end_line":76,"end_character":21},"updated":"2015-12-18 08:53:26.000000000","message":"Needs unit tests in manila/tests/db/sqlalchemy/test_models.py","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            el_metadata[meta[\u0027key\u0027]] \u003d meta[\u0027value\u0027]"},{"line_number":412,"context_line":"        return el_metadata"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":415,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":416,"context_line":"    share_instance_id \u003d Column("},{"line_number":417,"context_line":"        String(36), ForeignKey(\u0027share_instances.id\u0027), nullable\u003dFalse)"},{"line_number":418,"context_line":"    path \u003d Column(String(2000))"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_1a92f757","line":415,"range":{"start_line":414,"start_character":4,"end_line":415,"end_character":58},"updated":"2015-12-18 08:53:26.000000000","message":"Why would we need id and uuid, i\u0027m confused with this since both are unique, but now that we\u0027re introducing uuid, couldn\u0027t we migrate all previous ids to String(36) format?\n\n\nid can still remain the primary key, except its new datatype is String(36) instead of an auto incrementing integer.. \n\n\nam i missing something here?","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            el_metadata[meta[\u0027key\u0027]] \u003d meta[\u0027value\u0027]"},{"line_number":412,"context_line":"        return el_metadata"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":415,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse, unique\u003dTrue)"},{"line_number":416,"context_line":"    share_instance_id \u003d Column("},{"line_number":417,"context_line":"        String(36), ForeignKey(\u0027share_instances.id\u0027), nullable\u003dFalse)"},{"line_number":418,"context_line":"    path \u003d Column(String(2000))"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_af4a7fc3","line":415,"range":{"start_line":414,"start_character":4,"end_line":415,"end_character":58},"in_reply_to":"3a7e1126_1a92f757","updated":"2015-12-18 11:18:44.000000000","message":"No need to do what you are proposing. We need unique UUID key, we defined it. That\u0027s all. Update of existing primary key is overhead.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    _extra_keys \u003d [\u0027export_location_uuid\u0027, ]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":429,"context_line":"    export_location_id \u003d Column("},{"line_number":430,"context_line":"        Integer,"},{"line_number":431,"context_line":"        ForeignKey(\"share_instance_export_locations.id\"), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_5a9ddf57","line":428,"range":{"start_line":428,"start_character":4,"end_line":428,"end_character":6},"updated":"2015-12-18 08:53:26.000000000","message":"I understand why we need an id here...","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"class ExportLocationNotFound(NotFound):"},{"line_number":426,"context_line":"    message \u003d _(\"Export location %(uuid)s could not be found.\")"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"class ShareSnapshotNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_9a082793","line":426,"range":{"start_line":426,"start_character":35,"end_line":426,"end_character":39},"updated":"2015-12-18 08:53:26.000000000","message":"s/uuid/export_location_id","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"class ExportLocationNotFound(NotFound):"},{"line_number":426,"context_line":"    message \u003d _(\"Export location %(uuid)s could not be found.\")"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"class ShareSnapshotNotFound(NotFound):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_4f719bdf","line":426,"range":{"start_line":426,"start_character":35,"end_line":426,"end_character":39},"in_reply_to":"3a7e1126_9a082793","updated":"2015-12-18 11:18:44.000000000","message":"Wrong proposal. It has both ID and UUID and it is not required to make name of mapping key contain \"export_location_\" prefix.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/share/manager.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67186c535fcf6f22fe677fd18143cf6873d597c3","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                    \u0027host\u0027: share_server[\u0027host\u0027],"},{"line_number":580,"context_line":"                    \u0027status\u0027: share_server[\u0027status\u0027],"},{"line_number":581,"context_line":"                    \u0027backend_details\u0027: share_server[\u0027backend_details\u0027],"},{"line_number":582,"context_line":"                } if share_server else share_server"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"                dest_driver_migration_info \u003d rpcapi.get_driver_migration_info("},{"line_number":585,"context_line":"                    ctxt, share_instance, share_server)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_78314d59","line":582,"range":{"start_line":582,"start_character":34,"end_line":582,"end_character":51},"updated":"2016-01-06 21:41:08.000000000","message":"this is redundant..","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8504bb8148bab4afdb6823fa62ae453b8d347dde","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                    \u0027host\u0027: share_server[\u0027host\u0027],"},{"line_number":580,"context_line":"                    \u0027status\u0027: share_server[\u0027status\u0027],"},{"line_number":581,"context_line":"                    \u0027backend_details\u0027: share_server[\u0027backend_details\u0027],"},{"line_number":582,"context_line":"                } if share_server else share_server"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"                dest_driver_migration_info \u003d rpcapi.get_driver_migration_info("},{"line_number":585,"context_line":"                    ctxt, share_instance, share_server)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_71549153","line":582,"range":{"start_line":582,"start_character":34,"end_line":582,"end_character":51},"in_reply_to":"fa69d971_093c492e","updated":"2016-01-08 13:14:11.000000000","message":"It does not suffer and, IMHO, it is correct to leave original value instead of setting our own.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5eadcb2835a05d3e100f1217606928f78d6ebb49","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                    \u0027host\u0027: share_server[\u0027host\u0027],"},{"line_number":580,"context_line":"                    \u0027status\u0027: share_server[\u0027status\u0027],"},{"line_number":581,"context_line":"                    \u0027backend_details\u0027: share_server[\u0027backend_details\u0027],"},{"line_number":582,"context_line":"                } if share_server else share_server"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"                dest_driver_migration_info \u003d rpcapi.get_driver_migration_info("},{"line_number":585,"context_line":"                    ctxt, share_instance, share_server)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_093c492e","line":582,"range":{"start_line":582,"start_character":34,"end_line":582,"end_character":51},"in_reply_to":"fa69d971_26c93aad","updated":"2016-01-07 22:30:33.000000000","message":"This was the bug i had with the share replication patch... In some databases, if some attributes are set to \u0027None\u0027, it will try lazy loading again; and since the session doesn\u0027t exist anymore, it will throw an exception. \n\nmaybe:\n\n     if share_server else None\n\n\n\n\nwould be more descriptive, even if this doesn\u0027t suffer from the same problem. \n\nhttps://review.openstack.org/#/c/238572/14/manila/db/api.py","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"015303946b5780bbc4048886acc0954ff0c57ae0","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                    \u0027host\u0027: share_server[\u0027host\u0027],"},{"line_number":580,"context_line":"                    \u0027status\u0027: share_server[\u0027status\u0027],"},{"line_number":581,"context_line":"                    \u0027backend_details\u0027: share_server[\u0027backend_details\u0027],"},{"line_number":582,"context_line":"                } if share_server else share_server"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"                dest_driver_migration_info \u003d rpcapi.get_driver_migration_info("},{"line_number":585,"context_line":"                    ctxt, share_instance, share_server)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_26c93aad","line":582,"range":{"start_line":582,"start_character":34,"end_line":582,"end_character":51},"in_reply_to":"fa69d971_78314d59","updated":"2016-01-07 22:13:49.000000000","message":"No, it is not. It is None with DHSS\u003dFalse mode.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67186c535fcf6f22fe677fd18143cf6873d597c3","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                \u0027host\u0027: new_share_server[\u0027host\u0027],"},{"line_number":677,"context_line":"                \u0027status\u0027: new_share_server[\u0027status\u0027],"},{"line_number":678,"context_line":"                \u0027backend_details\u0027: new_share_server[\u0027backend_details\u0027],"},{"line_number":679,"context_line":"            } if new_share_server else new_share_server"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"            src_migration_info \u003d self.driver.get_migration_info("},{"line_number":682,"context_line":"                context, share_instance, share_server)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_9848c1cd","line":679,"range":{"start_line":679,"start_character":33,"end_line":679,"end_character":55},"updated":"2016-01-06 21:41:08.000000000","message":"same.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"015303946b5780bbc4048886acc0954ff0c57ae0","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                \u0027host\u0027: new_share_server[\u0027host\u0027],"},{"line_number":677,"context_line":"                \u0027status\u0027: new_share_server[\u0027status\u0027],"},{"line_number":678,"context_line":"                \u0027backend_details\u0027: new_share_server[\u0027backend_details\u0027],"},{"line_number":679,"context_line":"            } if new_share_server else new_share_server"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"            src_migration_info \u003d self.driver.get_migration_info("},{"line_number":682,"context_line":"                context, share_instance, share_server)"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_863026a0","line":679,"range":{"start_line":679,"start_character":33,"end_line":679,"end_character":55},"in_reply_to":"fa69d971_9848c1cd","updated":"2016-01-07 22:13:49.000000000","message":"See above.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"}],"manila/tests/api/v2/test_share_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.req, self.share[\u0027id\u0027], el_uuid)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(expected_metadata, metadata.get(\u0027metadata\u0027, \u0027fake\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":108,"context_line":"    def test_list_with_unsupported_version(self, version):"},{"line_number":109,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_0e65d9df","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":0},"updated":"2015-12-18 08:53:26.000000000","message":"Please add tests for HTTPNotFound cases","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.req, self.share[\u0027id\u0027], el_uuid)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(expected_metadata, metadata.get(\u0027metadata\u0027, \u0027fake\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":108,"context_line":"    def test_list_with_unsupported_version(self, version):"},{"line_number":109,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_9a1b3c1b","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":0},"in_reply_to":"3a7e1126_0e65d9df","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91035327e28d4382fba9104bd8415cb596b1b6d1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            self.req, \u0027inexistent_share_id\u0027, el_uuid,"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_show_export_location_metadata_share_not_found(self):"},{"line_number":125,"context_line":"        index_result \u003d self.controller.index(self.req, self.share[\u0027id\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.assertIn(\u0027export_locations\u0027, index_result)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_43ddd66d","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":33},"updated":"2015-12-18 19:31:05.000000000","message":"you mean\n\n    test_get_metadata_share_not_found","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1b4fa8bda227f0e85bf33eb6d14109de1f9bf9fb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            self.req, \u0027inexistent_share_id\u0027, el_uuid,"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_show_export_location_metadata_share_not_found(self):"},{"line_number":125,"context_line":"        index_result \u003d self.controller.index(self.req, self.share[\u0027id\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        self.assertIn(\u0027export_locations\u0027, index_result)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_14285885","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":33},"in_reply_to":"3a7e1126_43ddd66d","updated":"2015-12-19 09:43:38.000000000","message":"Done","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"}],"manila/tests/api/v2/test_share_instance_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.req, self.share_instance_id, el_uuid)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(expected_metadata, metadata.get(\u0027metadata\u0027, \u0027fake\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":108,"context_line":"    def test_list_with_unsupported_version(self, version):"},{"line_number":109,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_e0e17c9b","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":0},"updated":"2015-12-18 08:53:26.000000000","message":"Needs tests for HTTPNotFound in both show, get_export_locations_metadata calls","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.req, self.share_instance_id, el_uuid)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.assertEqual(expected_metadata, metadata.get(\u0027metadata\u0027, \u0027fake\u0027))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":108,"context_line":"    def test_list_with_unsupported_version(self, version):"},{"line_number":109,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_ba8f18cb","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":0},"in_reply_to":"3a7e1126_e0e17c9b","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91035327e28d4382fba9104bd8415cb596b1b6d1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.req, \u0027inexistent_share_id\u0027, el_uuid,"},{"line_number":123,"context_line":"        )"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_show_export_location_metadata_share_not_found(self):"},{"line_number":126,"context_line":"        index_result \u003d self.controller.index(self.req, self.share_instance_id)"},{"line_number":127,"context_line":"        el_uuid \u003d index_result[\u0027export_locations\u0027][0][\u0027uuid\u0027]"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_03e34e34","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":58},"updated":"2015-12-18 19:31:05.000000000","message":"same","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1b4fa8bda227f0e85bf33eb6d14109de1f9bf9fb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.req, \u0027inexistent_share_id\u0027, el_uuid,"},{"line_number":123,"context_line":"        )"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_show_export_location_metadata_share_not_found(self):"},{"line_number":126,"context_line":"        index_result \u003d self.controller.index(self.req, self.share_instance_id)"},{"line_number":127,"context_line":"        el_uuid \u003d index_result[\u0027export_locations\u0027][0][\u0027uuid\u0027]"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"3a7e1126_7418bc75","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":58},"in_reply_to":"3a7e1126_03e34e34","updated":"2015-12-19 09:43:38.000000000","message":"Done","commit_id":"6b3f5bddb2e7faa62a88b480510b822dfe02bc81"}],"manila/tests/api/v2/test_share_instances.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        self.assertEqual(1, len(actual_result.get(\"share_instances\", 0)))"},{"line_number":141,"context_line":"        for instance in actual_result[\"share_instances\"]:"},{"line_number":142,"context_line":"            if float(version) \u003e 2.8:"},{"line_number":143,"context_line":"                assert_method \u003d self.assertNotIn"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                assert_method \u003d self.assertIn"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_205b0456","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":35},"updated":"2015-12-18 08:53:26.000000000","message":"use micro version comparison functions here.. 2.10 !\u003e 2.8 as corrected by your recent bug fix in manila_tempest_tests","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0429a16589eb8006e1670bf78ed55a5599e3b495","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        self.assertEqual(1, len(actual_result.get(\"share_instances\", 0)))"},{"line_number":141,"context_line":"        for instance in actual_result[\"share_instances\"]:"},{"line_number":142,"context_line":"            if float(version) \u003e 2.8:"},{"line_number":143,"context_line":"                assert_method \u003d self.assertNotIn"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                assert_method \u003d self.assertIn"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_8e2f89f5","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":35},"in_reply_to":"3a7e1126_0ee4f90a","updated":"2015-12-18 09:07:47.000000000","message":"It is, as long as someone doesn\u0027t decide to add something to this test with a version \u003e\u003d2.10","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fcb9ac04f952fca5a181fbbab8f6063b8d10e6ea","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        self.assertEqual(1, len(actual_result.get(\"share_instances\", 0)))"},{"line_number":141,"context_line":"        for instance in actual_result[\"share_instances\"]:"},{"line_number":142,"context_line":"            if float(version) \u003e 2.8:"},{"line_number":143,"context_line":"                assert_method \u003d self.assertNotIn"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                assert_method \u003d self.assertIn"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_0ee4f90a","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":35},"in_reply_to":"3a7e1126_205b0456","updated":"2015-12-18 09:00:02.000000000","message":"There is no such argument. Float transformation is suitable here.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        self.assertEqual(1, len(actual_result.get(\"share_instances\", 0)))"},{"line_number":141,"context_line":"        for instance in actual_result[\"share_instances\"]:"},{"line_number":142,"context_line":"            if float(version) \u003e 2.8:"},{"line_number":143,"context_line":"                assert_method \u003d self.assertNotIn"},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                assert_method \u003d self.assertIn"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_41f72ff5","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":35},"in_reply_to":"3a7e1126_8e2f89f5","updated":"2015-12-18 11:18:44.000000000","message":"Done","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila/tests/policy.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"share_export_location:index\": \"rule:default\","},{"line_number":37,"context_line":"    \"share_export_location:show\": \"rule:default\","},{"line_number":38,"context_line":"    \"share_export_location:get_share_export_location_metadata\": \"rule:default\","},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"share_type:index\": \"rule:default\","},{"line_number":41,"context_line":"    \"share_type:show\": \"rule:default\","},{"line_number":42,"context_line":"    \"share_type:default\": \"rule:default\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_c3ba4a23","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":0},"updated":"2015-12-18 08:53:26.000000000","message":"Why are these required if all the policy checks have been mocked in unit tests?","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"135196dd4d3e9a1b5ab2281c13392ca69839e6bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \"share_export_location:index\": \"rule:default\","},{"line_number":37,"context_line":"    \"share_export_location:show\": \"rule:default\","},{"line_number":38,"context_line":"    \"share_export_location:get_share_export_location_metadata\": \"rule:default\","},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"share_type:index\": \"rule:default\","},{"line_number":41,"context_line":"    \"share_type:show\": \"rule:default\","},{"line_number":42,"context_line":"    \"share_type:default\": \"rule:default\","}],"source_content_type":"application/json","patch_set":27,"id":"3a7e1126_ba54f820","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":0},"in_reply_to":"3a7e1126_c3ba4a23","updated":"2015-12-18 11:18:44.000000000","message":"To be able to change policy mock logic anytime not changing this file.","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila_tempest_tests/tests/api/admin/test_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"374fc7e0f37211680740e821fd7e512358af8860","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                isinstance(export_location[\u0027path\u0027], six.string_types))"},{"line_number":64,"context_line":"            for time in (export_location[\u0027created_at\u0027],"},{"line_number":65,"context_line":"                         export_location[\u0027updated_at\u0027]):"},{"line_number":66,"context_line":"                # If var \u0027time\u0027 has incorrect value then ValueError exception"},{"line_number":67,"context_line":"                # is expected to be raised. So, just try parse it making"},{"line_number":68,"context_line":"                # assertion that it has proper date value."},{"line_number":69,"context_line":"                timeutils.parse_strtime(time)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.attr(type\u003d[\"gate\", ])"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a7e1126_2348ee2c","line":68,"range":{"start_line":66,"start_character":16,"end_line":68,"end_character":58},"updated":"2015-12-18 08:53:26.000000000","message":"+1","commit_id":"2337581842c98fbf92cd28b71839ff746281fd5a"}],"manila_tempest_tests/tests/api/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67186c535fcf6f22fe677fd18143cf6873d597c3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertFalse(share[\u0027is_public\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Get share using v 2.1 - we expect key \u0027snapshot_support\u0027 to be absent"},{"line_number":60,"context_line":"        detailed_elements.add(\u0027export_location\u0027)"},{"line_number":61,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\u00272.1\u0027)"},{"line_number":62,"context_line":"        self.assertTrue(detailed_elements.issubset(share_get.keys()), msg)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_d3429aad","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":48},"updated":"2016-01-06 21:41:08.000000000","message":"I think this could be avoided. We should not remove the key from detailed_elements above until we want to test 2.9 in lines 69-75\n\n\nWe\u0027re making the change in 2.9 and for micro versions beyond.. This makes it look like we\u0027re expecting 2.1 to \"add\" a new key called export_location.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5eadcb2835a05d3e100f1217606928f78d6ebb49","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertFalse(share[\u0027is_public\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Get share using v 2.1 - we expect key \u0027snapshot_support\u0027 to be absent"},{"line_number":60,"context_line":"        detailed_elements.add(\u0027export_location\u0027)"},{"line_number":61,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\u00272.1\u0027)"},{"line_number":62,"context_line":"        self.assertTrue(detailed_elements.issubset(share_get.keys()), msg)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_c91631f1","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":48},"in_reply_to":"fa69d971_c6c4de60","updated":"2016-01-07 22:30:33.000000000","message":"Ah. yes; the comment above does not make very good sense to this line, still. I would at least remove the comment above since it\u0027s explained on line 64.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8504bb8148bab4afdb6823fa62ae453b8d347dde","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertFalse(share[\u0027is_public\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Get share using v 2.1 - we expect key \u0027snapshot_support\u0027 to be absent"},{"line_number":60,"context_line":"        detailed_elements.add(\u0027export_location\u0027)"},{"line_number":61,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\u00272.1\u0027)"},{"line_number":62,"context_line":"        self.assertTrue(detailed_elements.issubset(share_get.keys()), msg)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_f11161b0","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":48},"in_reply_to":"fa69d971_c91631f1","updated":"2016-01-08 13:14:11.000000000","message":"switched lines 60 and 61, so comment stay before proper code line.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"015303946b5780bbc4048886acc0954ff0c57ae0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertFalse(share[\u0027is_public\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Get share using v 2.1 - we expect key \u0027snapshot_support\u0027 to be absent"},{"line_number":60,"context_line":"        detailed_elements.add(\u0027export_location\u0027)"},{"line_number":61,"context_line":"        share_get \u003d self.shares_v2_client.get_share(share[\u0027id\u0027], version\u003d\u00272.1\u0027)"},{"line_number":62,"context_line":"        self.assertTrue(detailed_elements.issubset(share_get.keys()), msg)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa69d971_c6c4de60","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":48},"in_reply_to":"fa69d971_d3429aad","updated":"2016-01-07 22:13:49.000000000","message":"It is done because of line 56. There we assert that these keys always exist, and then, for specific versions, we assert different cases. Leaving as is.","commit_id":"dd07dd090f3f5a90e43489ce0c9d9515446f0368"}]}
