)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60bc4122d1c855c768c4887e8d896007e2eb0b99","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode."},{"line_number":10,"context_line":"But in Manila-ui can check the share network when you create a share."},{"line_number":11,"context_line":"So add the check, when I creat a share with no share network in"},{"line_number":12,"context_line":"DHSS\u003dtrue mode, it will return false."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1525125"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_a5cdad32","line":11,"updated":"2015-12-11 13:27:48.000000000","message":"s/creat/create","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ceab0128fd8b01ed0de3705cff401c9095fc59f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-15 15:10:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode."},{"line_number":10,"context_line":"But in Manila-ui can check the share network when you create a share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3afc51ec_2c6578b4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"updated":"2016-03-15 11:04:22.000000000","message":"This topic makes me think that you create some API.\n\nbetter to reword it to something like following:\n\n\"\"\"\nCheck share-network in \u0027share create\u0027 API\n\"\"\"","commit_id":"dc53a7a958564eee94c1be1daeb20a0a82bbd5eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c5e20fcc0d5c13cde40336dd9b754cf150075a4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-15 15:10:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode."},{"line_number":10,"context_line":"But in Manila-ui can check the share network when you create a share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3afc51ec_6c8660dc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"in_reply_to":"3afc51ec_2c6578b4","updated":"2016-03-15 11:08:57.000000000","message":"Done","commit_id":"dc53a7a958564eee94c1be1daeb20a0a82bbd5eb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ceab0128fd8b01ed0de3705cff401c9095fc59f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode."},{"line_number":10,"context_line":"But in Manila-ui can check the share network when you create a share."},{"line_number":11,"context_line":"So add the check, when I create a share with no share network in"},{"line_number":12,"context_line":"DHSS\u003dtrue mode, it will return false."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"When create share with share type(DHSS\u003dtrue) and not input share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3afc51ec_accd0887","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":37},"updated":"2016-03-15 11:04:22.000000000","message":"And here for following:\n\n\"\"\"\nFor the moment it is possible to schedule share creation with DHSS\u003dtrue share type but without share network. But it makes no sense, and expected to fail. So, perform check on API level.\n\"\"\"","commit_id":"dc53a7a958564eee94c1be1daeb20a0a82bbd5eb"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c5e20fcc0d5c13cde40336dd9b754cf150075a4d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create share API without checking share network in DHSS\u003dtrue mode."},{"line_number":10,"context_line":"But in Manila-ui can check the share network when you create a share."},{"line_number":11,"context_line":"So add the check, when I create a share with no share network in"},{"line_number":12,"context_line":"DHSS\u003dtrue mode, it will return false."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"When create share with share type(DHSS\u003dtrue) and not input share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3afc51ec_cc6fb429","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":37},"in_reply_to":"3afc51ec_accd0887","updated":"2016-03-15 11:08:57.000000000","message":"Done","commit_id":"dc53a7a958564eee94c1be1daeb20a0a82bbd5eb"}],"manila/api/v1/shares.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60bc4122d1c855c768c4887e8d896007e2eb0b99","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        if req_share_type:"},{"line_number":304,"context_line":"            try:"},{"line_number":305,"context_line":"                if not uuidutils.is_uuid_like(req_share_type):"},{"line_number":306,"context_line":"                    share_type \u003d \\"},{"line_number":307,"context_line":"                        share_types.get_share_type_by_name("},{"line_number":308,"context_line":"                            context, req_share_type)"},{"line_number":309,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_45e5e9a1","line":306,"updated":"2015-12-11 13:27:48.000000000","message":"use parenthesis instead of backslash","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bca561ac2193ae6e26e34a4c4a64b56392f677ca","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        if req_share_type:"},{"line_number":304,"context_line":"            try:"},{"line_number":305,"context_line":"                if not uuidutils.is_uuid_like(req_share_type):"},{"line_number":306,"context_line":"                    share_type \u003d \\"},{"line_number":307,"context_line":"                        share_types.get_share_type_by_name("},{"line_number":308,"context_line":"                            context, req_share_type)"},{"line_number":309,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_ec216cb5","line":306,"in_reply_to":"7a740942_45e5e9a1","updated":"2016-03-11 01:30:31.000000000","message":"Done","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60bc4122d1c855c768c4887e8d896007e2eb0b99","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            if def_share_type:"},{"line_number":318,"context_line":"                share_type \u003d def_share_type"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if (share_type.get(\u0027exta_specs\u0027).get(\u0027driver_handles_share_servers\u0027)"},{"line_number":321,"context_line":"           and no (share_network_id and snapshot)):"},{"line_number":322,"context_line":"           msg \u003d _(\u0027Share network must be set when the \u0027"},{"line_number":323,"context_line":"                 \u0027driver_handles_share_servers is true\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_a537edfd","line":320,"updated":"2015-12-11 13:27:48.000000000","message":"s/exta_specs/extra_specs","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bca561ac2193ae6e26e34a4c4a64b56392f677ca","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            if def_share_type:"},{"line_number":318,"context_line":"                share_type \u003d def_share_type"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if (share_type.get(\u0027exta_specs\u0027).get(\u0027driver_handles_share_servers\u0027)"},{"line_number":321,"context_line":"           and no (share_network_id and snapshot)):"},{"line_number":322,"context_line":"           msg \u003d _(\u0027Share network must be set when the \u0027"},{"line_number":323,"context_line":"                 \u0027driver_handles_share_servers is true\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_8c30e802","line":320,"in_reply_to":"7a740942_a537edfd","updated":"2016-03-11 01:30:31.000000000","message":"Done","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60bc4122d1c855c768c4887e8d896007e2eb0b99","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                share_type \u003d def_share_type"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if (share_type.get(\u0027exta_specs\u0027).get(\u0027driver_handles_share_servers\u0027)"},{"line_number":321,"context_line":"           and no (share_network_id and snapshot)):"},{"line_number":322,"context_line":"           msg \u003d _(\u0027Share network must be set when the \u0027"},{"line_number":323,"context_line":"                 \u0027driver_handles_share_servers is true\u0027)"},{"line_number":324,"context_line":"           raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e8170c43","line":321,"updated":"2015-12-11 13:27:48.000000000","message":"/s/no/not","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"251aad0996feea7ec00064b7a27acc0667a95d6d","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                share_type \u003d def_share_type"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if (share_type.get(\u0027exta_specs\u0027).get(\u0027driver_handles_share_servers\u0027)"},{"line_number":321,"context_line":"           and no (share_network_id and snapshot)):"},{"line_number":322,"context_line":"           msg \u003d _(\u0027Share network must be set when the \u0027"},{"line_number":323,"context_line":"                 \u0027driver_handles_share_servers is true\u0027)"},{"line_number":324,"context_line":"           raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_b2779a01","line":321,"range":{"start_line":321,"start_character":40,"end_line":321,"end_character":48},"updated":"2015-12-23 08:33:01.000000000","message":"why snapshot?\n\nThis should just be:\n\n\n\n    and not share_network_id","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bca561ac2193ae6e26e34a4c4a64b56392f677ca","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                share_type \u003d def_share_type"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if (share_type.get(\u0027exta_specs\u0027).get(\u0027driver_handles_share_servers\u0027)"},{"line_number":321,"context_line":"           and no (share_network_id and snapshot)):"},{"line_number":322,"context_line":"           msg \u003d _(\u0027Share network must be set when the \u0027"},{"line_number":323,"context_line":"                 \u0027driver_handles_share_servers is true\u0027)"},{"line_number":324,"context_line":"           raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_ac2b6493","line":321,"in_reply_to":"7a740942_e8170c43","updated":"2016-03-11 01:30:31.000000000","message":"Done","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"60bc4122d1c855c768c4887e8d896007e2eb0b99","unresolved":false,"context_lines":[{"line_number":324,"context_line":"           raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        kwargs[\u0027share_type\u0027] \u003d share_type"},{"line_number":327,"context_line":"        "},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        new_share \u003d self.share_api.create(context,"},{"line_number":330,"context_line":"                                          share_proto,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_05dda1df","line":327,"updated":"2015-12-11 13:27:48.000000000","message":"trailing whitespace","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bca561ac2193ae6e26e34a4c4a64b56392f677ca","unresolved":false,"context_lines":[{"line_number":324,"context_line":"           raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        kwargs[\u0027share_type\u0027] \u003d share_type"},{"line_number":327,"context_line":"        "},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        new_share \u003d self.share_api.create(context,"},{"line_number":330,"context_line":"                                          share_proto,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_4c19a087","line":327,"in_reply_to":"7a740942_05dda1df","updated":"2016-03-11 01:30:31.000000000","message":"Done","commit_id":"57b2fb631926278a795d8cbb0d7b2937470cdb7d"}],"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f29b72bd6a9ed65a8ea3f1a328a5b22b288c6572","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        if share_network_id:"},{"line_number":76,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d share_network_id"},{"line_number":77,"context_line":"        elif CONF.share.multitenancy_enabled:"},{"line_number":78,"context_line":"            sn \u003d self.get_share_network(self.share_network_id)"},{"line_number":79,"context_line":"            fresh_sn \u003d self.create_share_network("},{"line_number":80,"context_line":"                neutron_net_id\u003dsn[\"neutron_net_id\"],"},{"line_number":81,"context_line":"                neutron_subnet_id\u003dsn[\"neutron_subnet_id\"])"},{"line_number":82,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d fresh_sn[\"id\"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if share_type_id:"},{"line_number":85,"context_line":"            post_body[\"share\"][\"share_type\"] \u003d share_type_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_58fee937","line":82,"range":{"start_line":77,"start_character":8,"end_line":82,"end_character":67},"updated":"2016-03-14 15:15:58.000000000","message":"Why it is added?\n\nAlso, if you do so, then should consider all possible Network plugin approaches. We have \"single network plugins\" that do not required values for \"net_id\" and \"subnet_id\".","commit_id":"d006abaabcf3aa64090e35025fa4dfd5275ad96b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3ab451014c4f40d99dcab3eb70186a12ed8a2f35","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        if share_network_id:"},{"line_number":76,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d share_network_id"},{"line_number":77,"context_line":"        elif CONF.share.multitenancy_enabled:"},{"line_number":78,"context_line":"            sn \u003d self.get_share_network(self.share_network_id)"},{"line_number":79,"context_line":"            fresh_sn \u003d self.create_share_network("},{"line_number":80,"context_line":"                neutron_net_id\u003dsn[\"neutron_net_id\"],"},{"line_number":81,"context_line":"                neutron_subnet_id\u003dsn[\"neutron_subnet_id\"])"},{"line_number":82,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d fresh_sn[\"id\"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if share_type_id:"},{"line_number":85,"context_line":"            post_body[\"share\"][\"share_type\"] \u003d share_type_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_61e02cfb","line":82,"range":{"start_line":77,"start_character":8,"end_line":82,"end_character":67},"in_reply_to":"3afc51ec_12a89c8c","updated":"2016-03-15 09:06:52.000000000","message":"Done, Thanks Valeriy Ponomaryov.","commit_id":"d006abaabcf3aa64090e35025fa4dfd5275ad96b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c404f6e4a46b9ef29589e5a0d77aa4fc013bf1e8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        if share_network_id:"},{"line_number":76,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d share_network_id"},{"line_number":77,"context_line":"        elif CONF.share.multitenancy_enabled:"},{"line_number":78,"context_line":"            sn \u003d self.get_share_network(self.share_network_id)"},{"line_number":79,"context_line":"            fresh_sn \u003d self.create_share_network("},{"line_number":80,"context_line":"                neutron_net_id\u003dsn[\"neutron_net_id\"],"},{"line_number":81,"context_line":"                neutron_subnet_id\u003dsn[\"neutron_subnet_id\"])"},{"line_number":82,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d fresh_sn[\"id\"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if share_type_id:"},{"line_number":85,"context_line":"            post_body[\"share\"][\"share_type\"] \u003d share_type_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_12a89c8c","line":82,"range":{"start_line":77,"start_character":8,"end_line":82,"end_character":67},"in_reply_to":"3afc51ec_257d9be7","updated":"2016-03-15 06:30:50.000000000","message":"It is easier to use \"self.create_share\" instead of \"self.shares_client.create_share\" in that particular test. It will autoadd share-network if it is set for tests.","commit_id":"d006abaabcf3aa64090e35025fa4dfd5275ad96b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6c7c75cc359d77354a46b0c012fd4baf726aa966","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        }"},{"line_number":75,"context_line":"        if share_network_id:"},{"line_number":76,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d share_network_id"},{"line_number":77,"context_line":"        elif CONF.share.multitenancy_enabled:"},{"line_number":78,"context_line":"            sn \u003d self.get_share_network(self.share_network_id)"},{"line_number":79,"context_line":"            fresh_sn \u003d self.create_share_network("},{"line_number":80,"context_line":"                neutron_net_id\u003dsn[\"neutron_net_id\"],"},{"line_number":81,"context_line":"                neutron_subnet_id\u003dsn[\"neutron_subnet_id\"])"},{"line_number":82,"context_line":"            post_body[\"share\"][\"share_network_id\"] \u003d fresh_sn[\"id\"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if share_type_id:"},{"line_number":85,"context_line":"            post_body[\"share\"][\"share_type\"] \u003d share_type_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_257d9be7","line":82,"range":{"start_line":77,"start_character":8,"end_line":82,"end_character":67},"in_reply_to":"3afc51ec_58fee937","updated":"2016-03-15 02:39:44.000000000","message":"Because when I run test_create_share_with_size_bigger_than_quota test. It will go to \"https://review.openstack.org/#/c/256353/7/manila/api/v1/shares.py#386\" and return \"lib_exc.BadRequest\" when share_network_id is None, not go to next to return the value of real want \"lib_exc.OverLimit\". \n\nSo I add the share_network_id here.\n\nIn https://github.com/openstack/manila/blob/master/manila_tempest_tests/tests/api/admin/test_quotas_negative.py#L99","commit_id":"d006abaabcf3aa64090e35025fa4dfd5275ad96b"}]}