)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huyang \u003chuyang1@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-20 08:38:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: add share server support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add share server support for Huawei driver."},{"line_number":10,"context_line":"Also implement the required setup_server"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_a096db3b","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":11},"updated":"2015-12-20 07:29:09.000000000","message":"s/add/Add","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"}],"doc/source/devref/huawei_nas_driver.rst":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"06e85263a96bcfed1ada5a2add04fa2664aee088","unresolved":false,"context_lines":[{"line_number":40,"context_line":"- Delete CIFS/NFS Share"},{"line_number":41,"context_line":"- Allow CIFS/NFS Share access"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  * Only IP access type is supported for NFS(ro/rw)."},{"line_number":44,"context_line":"  * Only USER access type is supported for CIFS(ro/rw)."},{"line_number":45,"context_line":"- Deny CIFS/NFS Share access"},{"line_number":46,"context_line":"- Create snapshot"}],"source_content_type":"text/x-rst","patch_set":20,"id":"fa69d971_91ae972c","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":44},"updated":"2016-01-11 14:23:02.000000000","message":"Looks like it is not true anymore.","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"45e435ca23c7cdd453cc63b98d6975dce9fff94d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"- Delete CIFS/NFS Share"},{"line_number":41,"context_line":"- Allow CIFS/NFS Share access"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  * Only IP access type is supported for NFS(ro/rw)."},{"line_number":44,"context_line":"  * Only USER access type is supported for CIFS(ro/rw)."},{"line_number":45,"context_line":"- Deny CIFS/NFS Share access"},{"line_number":46,"context_line":"- Create snapshot"}],"source_content_type":"text/x-rst","patch_set":20,"id":"fa69d971_ea7595ca","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":44},"in_reply_to":"fa69d971_91ae972c","updated":"2016-01-11 15:55:55.000000000","message":"Done","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":115,"context_line":".. note::"},{"line_number":116,"context_line":"    - If `driver_handles_share_servers` is True, the driver will choose a port"},{"line_number":117,"context_line":"      in \u003cPort\u003e to create vlan and logical port for each tenant network."},{"line_number":118,"context_line":"      And the share type with the DHSS extra spec should set to True when"},{"line_number":119,"context_line":"      creating shares."},{"line_number":120,"context_line":"    - If `driver_handles_share_servers` is False, then will use the IP in"},{"line_number":121,"context_line":"      \u003cLogicalPortIP\u003e. Also the share type with the DHSS extra spec should set"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da6ed579_d37c9322","line":118,"range":{"start_line":118,"start_character":50,"end_line":118,"end_character":60},"updated":"2016-01-12 16:21:35.000000000","message":"s/should set/should be set","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":115,"context_line":".. note::"},{"line_number":116,"context_line":"    - If `driver_handles_share_servers` is True, the driver will choose a port"},{"line_number":117,"context_line":"      in \u003cPort\u003e to create vlan and logical port for each tenant network."},{"line_number":118,"context_line":"      And the share type with the DHSS extra spec should set to True when"},{"line_number":119,"context_line":"      creating shares."},{"line_number":120,"context_line":"    - If `driver_handles_share_servers` is False, then will use the IP in"},{"line_number":121,"context_line":"      \u003cLogicalPortIP\u003e. Also the share type with the DHSS extra spec should set"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da6ed579_a85aa581","line":118,"range":{"start_line":118,"start_character":50,"end_line":118,"end_character":60},"in_reply_to":"da6ed579_d37c9322","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      And the share type with the DHSS extra spec should set to True when"},{"line_number":119,"context_line":"      creating shares."},{"line_number":120,"context_line":"    - If `driver_handles_share_servers` is False, then will use the IP in"},{"line_number":121,"context_line":"      \u003cLogicalPortIP\u003e. Also the share type with the DHSS extra spec should set"},{"line_number":122,"context_line":"      to False when creating shares."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Restart of manila-share service is needed for the configuration changes to take"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da6ed579_538f4323","line":121,"range":{"start_line":121,"start_character":68,"end_line":121,"end_character":78},"updated":"2016-01-12 16:21:35.000000000","message":"s/should set/should be set","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      And the share type with the DHSS extra spec should set to True when"},{"line_number":119,"context_line":"      creating shares."},{"line_number":120,"context_line":"    - If `driver_handles_share_servers` is False, then will use the IP in"},{"line_number":121,"context_line":"      \u003cLogicalPortIP\u003e. Also the share type with the DHSS extra spec should set"},{"line_number":122,"context_line":"      to False when creating shares."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Restart of manila-share service is needed for the configuration changes to take"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da6ed579_c85d997a","line":121,"range":{"start_line":121,"start_character":68,"end_line":121,"end_character":78},"in_reply_to":"da6ed579_538f4323","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"}],"manila/share/drivers/huawei/constants.py":[{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"d23405f0039df52fa3ec31bc1f802b1a9518ea6b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DEFAULT_TIMEOUT \u003d 60"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MSG_SNAPSHOT_NOT_FOUND \u003d 1073754118"},{"line_number":24,"context_line":"IP_ALLOCATIONS \u003d 0"},{"line_number":25,"context_line":"SOCKET_TIMEOUT \u003d 52"},{"line_number":26,"context_line":"LOGIN_SOCKET_TIMEOUT \u003d 4"},{"line_number":27,"context_line":"SYSTEM_NAME_PREFIX \u003d \"Array-\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_ef9cc40f","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":18},"updated":"2015-12-21 06:54:14.000000000","message":"When driver_handle_share_server is true, the \u0027IP_ALLOCATIONS\u0027 should not be 0","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DEFAULT_TIMEOUT \u003d 60"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MSG_SNAPSHOT_NOT_FOUND \u003d 1073754118"},{"line_number":24,"context_line":"IP_ALLOCATIONS \u003d 0"},{"line_number":25,"context_line":"SOCKET_TIMEOUT \u003d 52"},{"line_number":26,"context_line":"LOGIN_SOCKET_TIMEOUT \u003d 4"},{"line_number":27,"context_line":"SYSTEM_NAME_PREFIX \u003d \"Array-\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_c80bfe28","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":18},"in_reply_to":"3a7e1126_b2437f41","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"84fc54194bc3461cebfb2673b407f7b076cb8848","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DEFAULT_TIMEOUT \u003d 60"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MSG_SNAPSHOT_NOT_FOUND \u003d 1073754118"},{"line_number":24,"context_line":"IP_ALLOCATIONS \u003d 0"},{"line_number":25,"context_line":"SOCKET_TIMEOUT \u003d 52"},{"line_number":26,"context_line":"LOGIN_SOCKET_TIMEOUT \u003d 4"},{"line_number":27,"context_line":"SYSTEM_NAME_PREFIX \u003d \"Array-\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b2437f41","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":18},"in_reply_to":"3a7e1126_ef9cc40f","updated":"2015-12-21 06:58:10.000000000","message":"+1 We should return the real ip number in get_network_allocations_number function.","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DEFAULT_TIMEOUT \u003d 60"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MSG_SNAPSHOT_NOT_FOUND \u003d 1073754118"},{"line_number":24,"context_line":"IP_ALLOCATIONS \u003d 0"},{"line_number":25,"context_line":"SOCKET_TIMEOUT \u003d 52"},{"line_number":26,"context_line":"LOGIN_SOCKET_TIMEOUT \u003d 4"},{"line_number":27,"context_line":"SYSTEM_NAME_PREFIX \u003d \"Array-\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_a80eb238","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":18},"in_reply_to":"3a7e1126_ef9cc40f","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5aea83390982ae04dff8814bc60f1425854a055e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    API version history:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        1.0 - Initial version."},{"line_number":49,"context_line":"        1.1 - Add shrink share."},{"line_number":50,"context_line":"              Add extend share."},{"line_number":51,"context_line":"              Add manage share."},{"line_number":52,"context_line":"              Add share level(ro)."},{"line_number":53,"context_line":"              Add smartx capabilities."},{"line_number":54,"context_line":"              Support multi pools in one backend."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":58,"context_line":"        \"\"\"Do initialization.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"da6ed579_76e0d9fa","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":7},"updated":"2016-01-14 02:23:22.000000000","message":"Please add the feature description in this.\nMay be add \"1.2 - Add share server support\".","commit_id":"fc5a494935727fe770db15b739cf0a12e5a50d05"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"49a8dbfba321c9d318cef1c3f5edcd38723343a9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    API version history:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        1.0 - Initial version."},{"line_number":49,"context_line":"        1.1 - Add shrink share."},{"line_number":50,"context_line":"              Add extend share."},{"line_number":51,"context_line":"              Add manage share."},{"line_number":52,"context_line":"              Add share level(ro)."},{"line_number":53,"context_line":"              Add smartx capabilities."},{"line_number":54,"context_line":"              Support multi pools in one backend."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":58,"context_line":"        \"\"\"Do initialization.\"\"\""}],"source_content_type":"text/x-python","patch_set":25,"id":"da6ed579_96df8d0c","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":7},"in_reply_to":"da6ed579_76e0d9fa","updated":"2016-01-14 02:31:01.000000000","message":"Good catch! Thanks zhongjun.","commit_id":"fc5a494935727fe770db15b739cf0a12e5a50d05"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return location"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_share_ip(self, share_server):"},{"line_number":119,"context_line":"        \"\"\"\"Get share logic ip.\"\"\""},{"line_number":120,"context_line":"        if share_server:"},{"line_number":121,"context_line":"            ip \u003d share_server[\u0027backend_details\u0027].get(\u0027ip\u0027)"},{"line_number":122,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a009fb85","line":119,"range":{"start_line":119,"start_character":22,"end_line":119,"end_character":27},"updated":"2015-12-20 07:29:09.000000000","message":"logical?","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":413,"context_line":"            if access_type \u003d\u003d \u0027user\u0027:"},{"line_number":414,"context_line":"                #use \u0027user\u0027 as \u0027netgroup\u0027 for NFS"},{"line_number":415,"context_line":"                #a group name is start with @"},{"line_number":416,"context_line":"                access_to \u003d \u0027@\u0027 + access_to"},{"line_number":417,"context_line":"            elif access_type !\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a0801bc0","line":414,"range":{"start_line":414,"start_character":17,"end_line":414,"end_character":20},"updated":"2015-12-20 07:29:09.000000000","message":"Space after #, \n\nhttps://www.python.org/dev/peps/pep-0008/#inline-comments\n\n\nAlso, s/use/Use\nand end with a period..","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":413,"context_line":"            if access_type \u003d\u003d \u0027user\u0027:"},{"line_number":414,"context_line":"                #use \u0027user\u0027 as \u0027netgroup\u0027 for NFS"},{"line_number":415,"context_line":"                #a group name is start with @"},{"line_number":416,"context_line":"                access_to \u003d \u0027@\u0027 + access_to"},{"line_number":417,"context_line":"            elif access_type !\u003d \u0027ip\u0027:"},{"line_number":418,"context_line":"                message \u003d _(\u0027Only IP or USER access type is allowed for NFS shares.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_c08527cf","line":415,"range":{"start_line":415,"start_character":17,"end_line":415,"end_character":18},"updated":"2015-12-20 07:29:09.000000000","message":"same here\n\nDo you mean, \"Group names start with \u0027@\u0027.\"","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":638,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":639,"context_line":"        if not netaddr.valid_ipv4(ip):"},{"line_number":640,"context_line":"            err_msg \u003d _(\"IP is invalid. Only support ipv4.\")"},{"line_number":641,"context_line":"            LOG.error(err_msg)"},{"line_number":642,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a057bb58","line":640,"range":{"start_line":640,"start_character":40,"end_line":640,"end_character":57},"updated":"2015-12-20 07:29:09.000000000","message":"Only IPv4 addresses are supported.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    def _get_valid_security_service(self, security_services):"},{"line_number":675,"context_line":"        \"\"\"Validate security services and return AD/LDAP config.\"\"\""},{"line_number":676,"context_line":"        service_number \u003d len(security_services)"},{"line_number":677,"context_line":"        err_msg \u003d _(\"Unsupported security services. Only support AD and LDAP.\")"},{"line_number":678,"context_line":"        if service_number \u003e 2:"},{"line_number":679,"context_line":"            LOG.error(err_msg)"},{"line_number":680,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_c05c477f","line":677,"range":{"start_line":677,"start_character":52,"end_line":677,"end_character":76},"updated":"2015-12-20 07:29:09.000000000","message":"Only AD and LDAP are supported.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":706,"context_line":"        if ip_address:"},{"line_number":707,"context_line":"            if ip_address[0]:"},{"line_number":708,"context_line":"                err_msg \u003d _(\"DNS server has already configured.\")"},{"line_number":709,"context_line":"                LOG.error(err_msg)"},{"line_number":710,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":711,"context_line":"        "}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_80539f6a","line":708,"range":{"start_line":708,"start_character":44,"end_line":708,"end_character":51},"updated":"2015-12-20 07:29:09.000000000","message":"DNS server has already been configured.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                err_msg \u003d _(\"DNS server has already configured.\")"},{"line_number":709,"context_line":"                LOG.error(err_msg)"},{"line_number":710,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":711,"context_line":"        "},{"line_number":712,"context_line":"        # Check AD config exist or not."},{"line_number":713,"context_line":"        is_exist \u003d self.helper._check_AD_config_exist()"},{"line_number":714,"context_line":"        if is_exist:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_6056b35d","line":711,"range":{"start_line":711,"start_character":0,"end_line":711,"end_character":8},"updated":"2015-12-20 07:29:09.000000000","message":"Stray whitespace. Please remove.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        # Check AD config exist or not."},{"line_number":713,"context_line":"        is_exist \u003d self.helper._check_AD_config_exist()"},{"line_number":714,"context_line":"        if is_exist:"},{"line_number":715,"context_line":"            err_msg \u003d _(\"AD domain has already configured.\")"},{"line_number":716,"context_line":"            LOG.error(err_msg)"},{"line_number":717,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":718,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_404937b6","line":715,"range":{"start_line":715,"start_character":25,"end_line":715,"end_character":57},"updated":"2015-12-20 07:29:09.000000000","message":"AD domain has already been configured.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        # Set AD config."},{"line_number":725,"context_line":"        digits \u003d string.digits"},{"line_number":726,"context_line":"        random_id \u003d \u0027\u0027.join([random.choice(digits) for i in range(9)])"},{"line_number":727,"context_line":"        system_name \u003d constants.SYSTEM_NAME_PREFIX + random_id "},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        try:"},{"line_number":730,"context_line":"            self.helper._add_AD_config(user, password, domain, system_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_e0c86324","line":727,"range":{"start_line":727,"start_character":62,"end_line":727,"end_character":63},"updated":"2015-12-20 07:29:09.000000000","message":"Trailing whitespace, please remove.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            return False"},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        return True"},{"line_number":758,"context_line":"                "},{"line_number":759,"context_line":"    def _check_AD_status(self, ad_status, expect_status):"},{"line_number":760,"context_line":"        if ad_status \u003d\u003d expect_status:"},{"line_number":761,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_c0d3e7d3","line":758,"range":{"start_line":758,"start_character":0,"end_line":758,"end_character":16},"updated":"2015-12-20 07:29:09.000000000","message":"same as above\n\nIf you are using pycharm, try setting the \"strip whitespace\" option\n\nSettings | Editor | General | \"Strip trailing spaces on save\"","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"        return True"},{"line_number":758,"context_line":"                "},{"line_number":759,"context_line":"    def _check_AD_status(self, ad_status, expect_status):"},{"line_number":760,"context_line":"        if ad_status \u003d\u003d expect_status:"},{"line_number":761,"context_line":"            return True"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_80dabfe6","line":759,"range":{"start_line":759,"start_character":42,"end_line":759,"end_character":55},"updated":"2015-12-20 07:29:09.000000000","message":"nit: expect_status can be expected_status","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":757,"context_line":"        return True"},{"line_number":758,"context_line":"                "},{"line_number":759,"context_line":"    def _check_AD_status(self, ad_status, expect_status):"},{"line_number":760,"context_line":"        if ad_status \u003d\u003d expect_status:"},{"line_number":761,"context_line":"            return True"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        return False"},{"line_number":764,"context_line":"        "},{"line_number":765,"context_line":"    def _configure_LDAP_domain(self, ldap):"},{"line_number":766,"context_line":"        server \u003d ldap[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_20e3cba5","line":763,"range":{"start_line":760,"start_character":8,"end_line":763,"end_character":20},"updated":"2015-12-20 07:29:09.000000000","message":"Can be done in one line\n\n    return ad_status \u003d\u003d expected_status","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":761,"context_line":"            return True"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        return False"},{"line_number":764,"context_line":"        "},{"line_number":765,"context_line":"    def _configure_LDAP_domain(self, ldap):"},{"line_number":766,"context_line":"        server \u003d ldap[\u0027server\u0027]"},{"line_number":767,"context_line":"        domain \u003d ldap[\u0027domain\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_60dd53df","line":764,"range":{"start_line":764,"start_character":0,"end_line":764,"end_character":8},"updated":"2015-12-20 07:29:09.000000000","message":"same","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        # Check LDAP config exist or not."},{"line_number":772,"context_line":"        is_exist \u003d self.helper._check_LDAP_config_exist()"},{"line_number":773,"context_line":"        if is_exist:"},{"line_number":774,"context_line":"            err_msg \u003d _(\"LDAP domain has already configured.\")"},{"line_number":775,"context_line":"            LOG.error(err_msg)"},{"line_number":776,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":777,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_40e05796","line":774,"range":{"start_line":774,"start_character":25,"end_line":774,"end_character":60},"updated":"2015-12-20 07:29:09.000000000","message":"LDAP domain has already been configured.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        elif server_number \u003d\u003d 2:"},{"line_number":783,"context_line":"            server \u003d server + \",\""},{"line_number":784,"context_line":"        elif server_number \u003e 3:"},{"line_number":785,"context_line":"            raise exception.InvalidInput(_(\"Only support three ldap servers.\"))"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"        self.helper._add_LDAP_config(server, domain)"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_a0e57ba4","line":785,"range":{"start_line":785,"start_character":44,"end_line":785,"end_character":76},"updated":"2015-12-20 07:29:09.000000000","message":"Cannot support more than three LDAP servers.\n\nor\n\nOnly upto three LDAP servers are supported.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":786,"context_line":""},{"line_number":787,"context_line":"        self.helper._add_LDAP_config(server, domain)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"    def _create_vlan_and_logic_port(self, vlan_tag, ip, subnet):"},{"line_number":790,"context_line":"        optimal_port, port_type \u003d self._get_optimal_port()"},{"line_number":791,"context_line":"        port_id \u003d self.helper._get_port_id(optimal_port, port_type)"},{"line_number":792,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fb001403","line":789,"range":{"start_line":789,"start_character":25,"end_line":789,"end_character":35},"updated":"2015-12-20 07:29:09.000000000","message":"s/_create_vlan_and_logic_port/_create_vlan_and_logical_port","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":800,"context_line":"            # create vlan"},{"line_number":801,"context_line":"            vlan_id \u003d self.helper._create_vlan(port_id, port_type, vlan_tag)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        logic_exist, logic_port_id \u003d ("},{"line_number":804,"context_line":"            self.helper._check_logic_port_exist(vlan_id, ip, subnet))"},{"line_number":805,"context_line":"        if not logic_exist:"},{"line_number":806,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_bb060c1a","line":803,"range":{"start_line":803,"start_character":8,"end_line":803,"end_character":19},"updated":"2015-12-20 07:29:09.000000000","message":"s/logic_exist/logical_port_exists","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":800,"context_line":"            # create vlan"},{"line_number":801,"context_line":"            vlan_id \u003d self.helper._create_vlan(port_id, port_type, vlan_tag)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        logic_exist, logic_port_id \u003d ("},{"line_number":804,"context_line":"            self.helper._check_logic_port_exist(vlan_id, ip, subnet))"},{"line_number":805,"context_line":"        if not logic_exist:"},{"line_number":806,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_1b06401d","line":803,"range":{"start_line":803,"start_character":21,"end_line":803,"end_character":34},"updated":"2015-12-20 07:29:09.000000000","message":"s/logic_port_id/logical_port_id","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                port_info.append(port)"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        if not port_info:"},{"line_number":831,"context_line":"            err_msg \u003d _(\"Can not find port info in config file.\")"},{"line_number":832,"context_line":"            LOG.error(err_msg)"},{"line_number":833,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":834,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_c0ea0774","line":831,"range":{"start_line":831,"start_character":25,"end_line":831,"end_character":32},"updated":"2015-12-20 07:29:09.000000000","message":"s/Can not/Cannot","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        optimal_port, type \u003d self._get_least_vlan_port(eth_port, bond_port)"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"        if not optimal_port:"},{"line_number":839,"context_line":"            err_msg \u003d _(\"Can not find optimal port.\")"},{"line_number":840,"context_line":"            LOG.error(err_msg)"},{"line_number":841,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_60047349","line":839,"range":{"start_line":839,"start_character":25,"end_line":839,"end_character":32},"updated":"2015-12-20 07:29:09.000000000","message":"same","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        return optimal_port, type"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def _get_online_port(self, all_port_list):"},{"line_number":846,"context_line":"        all_port_list \u003d list(set(all_port_list))"},{"line_number":847,"context_line":"        eth_port \u003d self.helper._get_all_eth_port()"},{"line_number":848,"context_line":"        bond_port \u003d self.helper._get_all_bond_port()"},{"line_number":849,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_20faeb43","line":846,"range":{"start_line":846,"start_character":24,"end_line":846,"end_character":48},"updated":"2015-12-20 07:29:09.000000000","message":"interesting, any reason why you\u0027re converting a list to a set and back to a list?","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":917,"context_line":"            return"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        logic_port_id \u003d server_details.get(\u0027logic_port_id\u0027)"},{"line_number":920,"context_line":"        vlan_id \u003d server_details.get(\u0027vlan_id\u0027)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        # Delete logic_port."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_6060f301","line":919,"range":{"start_line":919,"start_character":24,"end_line":919,"end_character":59},"updated":"2015-12-20 07:29:09.000000000","message":"logic_port_ip isn\u0027t there in the share_server[\u0027backend_details\u0027] dictionary.. \n\nDid you mean to set it somewhere in your code?","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        vlan_id \u003d server_details.get(\u0027vlan_id\u0027)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"        # Delete logic_port."},{"line_number":923,"context_line":"        if logic_port_id:"},{"line_number":924,"context_line":"            logic_port \u003d self.helper._get_logic_port_by_id(logic_port_id)"},{"line_number":925,"context_line":"            if logic_port:"},{"line_number":926,"context_line":"                self.helper._delete_logic_port(logic_port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_20566b2a","line":923,"range":{"start_line":923,"start_character":11,"end_line":923,"end_character":24},"updated":"2015-12-20 07:29:09.000000000","message":"please update names to\n\nlogical_port_id and logical_port","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1960857b3169c4562a06ecc92d916cf869852439","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.common import constants as common_constants"},{"line_number":25,"context_line":"from manila import exception"},{"line_number":26,"context_line":"from manila.i18n import _"},{"line_number":27,"context_line":"from manila.i18n import _LE"},{"line_number":28,"context_line":"from manila.i18n import _LW"},{"line_number":29,"context_line":"from manila.share.drivers.huawei import base as driver"},{"line_number":30,"context_line":"from manila.share.drivers.huawei import constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_9949ceb9","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":27},"updated":"2015-12-21 05:10:01.000000000","message":"Add from manila.i18n import _LI","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1960857b3169c4562a06ecc92d916cf869852439","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.common import constants as common_constants"},{"line_number":25,"context_line":"from manila import exception"},{"line_number":26,"context_line":"from manila.i18n import _"},{"line_number":27,"context_line":"from manila.i18n import _LE"},{"line_number":28,"context_line":"from manila.i18n import _LW"},{"line_number":29,"context_line":"from manila.share.drivers.huawei import base as driver"},{"line_number":30,"context_line":"from manila.share.drivers.huawei import constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b997ea46","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":27},"updated":"2015-12-21 05:10:01.000000000","message":"The \u0027_LE\u0027 imported but unused.","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.common import constants as common_constants"},{"line_number":25,"context_line":"from manila import exception"},{"line_number":26,"context_line":"from manila.i18n import _"},{"line_number":27,"context_line":"from manila.i18n import _LE"},{"line_number":28,"context_line":"from manila.i18n import _LW"},{"line_number":29,"context_line":"from manila.share.drivers.huawei import base as driver"},{"line_number":30,"context_line":"from manila.share.drivers.huawei import constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_23018305","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":27},"in_reply_to":"3a7e1126_9949ceb9","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.common import constants as common_constants"},{"line_number":25,"context_line":"from manila import exception"},{"line_number":26,"context_line":"from manila.i18n import _"},{"line_number":27,"context_line":"from manila.i18n import _LE"},{"line_number":28,"context_line":"from manila.i18n import _LW"},{"line_number":29,"context_line":"from manila.share.drivers.huawei import base as driver"},{"line_number":30,"context_line":"from manila.share.drivers.huawei import constants"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_030c8739","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":27},"in_reply_to":"3a7e1126_b997ea46","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1960857b3169c4562a06ecc92d916cf869852439","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        else:"},{"line_number":615,"context_line":"            if not logical_port_ip:"},{"line_number":616,"context_line":"                err_msg \u003d (_("},{"line_number":617,"context_line":"                    \u0027check_conf_file: Config file invalid. Logical ip \u0027"},{"line_number":618,"context_line":"                    \u0027must be set when driver_handles_share_servers is False.\u0027))"},{"line_number":619,"context_line":"                LOG.error(err_msg)"},{"line_number":620,"context_line":"                raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_79742235","line":617,"range":{"start_line":617,"start_character":59,"end_line":617,"end_character":69},"updated":"2015-12-21 05:10:01.000000000","message":"It is better to use the real name in xml file, s/ Logical ip/ LogicalPortIP","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        else:"},{"line_number":615,"context_line":"            if not logical_port_ip:"},{"line_number":616,"context_line":"                err_msg \u003d (_("},{"line_number":617,"context_line":"                    \u0027check_conf_file: Config file invalid. Logical ip \u0027"},{"line_number":618,"context_line":"                    \u0027must be set when driver_handles_share_servers is False.\u0027))"},{"line_number":619,"context_line":"                LOG.error(err_msg)"},{"line_number":620,"context_line":"                raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_c312ff56","line":617,"range":{"start_line":617,"start_character":59,"end_line":617,"end_character":69},"in_reply_to":"3a7e1126_79742235","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1960857b3169c4562a06ecc92d916cf869852439","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        domain \u003d active_directory[\u0027domain\u0027]"},{"line_number":702,"context_line":"        if not (dns_ip and user and password and domain):"},{"line_number":703,"context_line":"            raise exception.InvalidInput("},{"line_number":704,"context_line":"                _(\"dns_ip or user or password or domain is None.\"))"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        # Check DNS server exists or not."},{"line_number":707,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_f932525d","line":704,"range":{"start_line":704,"start_character":19,"end_line":704,"end_character":64},"updated":"2015-12-21 05:10:01.000000000","message":"Better to add more detail about dns_ip or user or password or domain .","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        domain \u003d active_directory[\u0027domain\u0027]"},{"line_number":702,"context_line":"        if not (dns_ip and user and password and domain):"},{"line_number":703,"context_line":"            raise exception.InvalidInput("},{"line_number":704,"context_line":"                _(\"dns_ip or user or password or domain is None.\"))"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        # Check DNS server exists or not."},{"line_number":707,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_e31dbb62","line":704,"range":{"start_line":704,"start_character":19,"end_line":704,"end_character":64},"in_reply_to":"3a7e1126_f932525d","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"d23405f0039df52fa3ec31bc1f802b1a9518ea6b","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                domain \u003d ldap[\u0027domain\u0027]"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"                # Check LDAP config exists or not."},{"line_number":967,"context_line":"                is_ldap_exists \u003d self.helper._check_LDAP_config_exist()"},{"line_number":968,"context_line":"                if is_ldap_exists:"},{"line_number":969,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"},{"line_number":970,"context_line":"                    if (LDAP_config[\u0027LDAPSERVER\u0027] \u003d\u003d server"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_8fed00b9","line":967,"range":{"start_line":967,"start_character":45,"end_line":967,"end_character":69},"updated":"2015-12-21 06:54:14.000000000","message":"s/_check_LDAP_config_exist/_check_LDAP_config_exist","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                domain \u003d ldap[\u0027domain\u0027]"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"                # Check LDAP config exists or not."},{"line_number":967,"context_line":"                is_ldap_exists \u003d self.helper._check_LDAP_config_exist()"},{"line_number":968,"context_line":"                if is_ldap_exists:"},{"line_number":969,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"},{"line_number":970,"context_line":"                    if (LDAP_config[\u0027LDAPSERVER\u0027] \u003d\u003d server"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_c3399fd8","line":967,"range":{"start_line":967,"start_character":45,"end_line":967,"end_character":69},"in_reply_to":"3a7e1126_8fed00b9","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"325da6e5ee874794365c17c83954ac688494cfaf","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                domain \u003d ldap[\u0027domain\u0027]"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"                # Check LDAP config exists or not."},{"line_number":967,"context_line":"                is_ldap_exists \u003d self.helper._check_LDAP_config_exist()"},{"line_number":968,"context_line":"                if is_ldap_exists:"},{"line_number":969,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"},{"line_number":970,"context_line":"                    if (LDAP_config[\u0027LDAPSERVER\u0027] \u003d\u003d server"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_f2790783","line":967,"range":{"start_line":967,"start_character":45,"end_line":967,"end_character":69},"in_reply_to":"3a7e1126_8fed00b9","updated":"2015-12-21 07:02:53.000000000","message":"s/_check_LDAP_config_exist/_check_LDAP_config_exists","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6a142a7062ca437a10411f5cdfb3100a60086e05","unresolved":false,"context_lines":[{"line_number":964,"context_line":"                domain \u003d ldap[\u0027domain\u0027]"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"                # Check LDAP config exists or not."},{"line_number":967,"context_line":"                is_ldap_exists \u003d self.helper._check_LDAP_config_exist()"},{"line_number":968,"context_line":"                if is_ldap_exists:"},{"line_number":969,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"},{"line_number":970,"context_line":"                    if (LDAP_config[\u0027LDAPSERVER\u0027] \u003d\u003d server"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_032327a8","line":967,"range":{"start_line":967,"start_character":45,"end_line":967,"end_character":69},"in_reply_to":"3a7e1126_f2790783","updated":"2015-12-21 08:37:48.000000000","message":"Done","commit_id":"926a1cff439e94edb687e3fe506d6b9973c9dd8d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"48984e4d0ba9a1d8cfb7d7c6166e5219ff93b3e6","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        share_client_type \u003d self.helper._get_share_client_type(share_proto)"},{"line_number":374,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":375,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":376,"context_line":"            LOG.warning(_LW(\u0027Only IP access type is allowed for NFS shares.\u0027))"},{"line_number":377,"context_line":"            return"},{"line_number":378,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"},{"line_number":379,"context_line":"            LOG.warning(_LW(\u0027Only USER access type is allowed for\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_fe5c707e","line":376,"range":{"start_line":376,"start_character":33,"end_line":376,"end_character":43},"updated":"2015-12-21 09:11:54.000000000","message":"Only IP and USER access type is allowed for NFS shares.","commit_id":"78db39abe331c84508b31fb55644397710bc0ed7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            self.helper._start_nfs_service_status()"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":638,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":639,"context_line":"        self._check_network_type_validate(network_info[\u0027network_type\u0027])"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"        vlan_tag \u003d network_info[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_a0d317d4","line":638,"range":{"start_line":638,"start_character":22,"end_line":638,"end_character":32},"updated":"2015-12-21 14:21:39.000000000","message":"Either \"sets up\" or \"configure\". Not consistent now.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            self.helper._start_nfs_service_status()"},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":638,"context_line":"        \"\"\"Set up and configures share server with given network parameters.\"\"\""},{"line_number":639,"context_line":"        self._check_network_type_validate(network_info[\u0027network_type\u0027])"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"        vlan_tag \u003d network_info[\u0027segmentation_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_7fbe14af","line":638,"range":{"start_line":638,"start_character":22,"end_line":638,"end_character":32},"in_reply_to":"3a7e1126_a0d317d4","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        vlan_tag \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":642,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":643,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":644,"context_line":"        if not netaddr.valid_ipv4(ip):"},{"line_number":645,"context_line":"            err_msg \u003d _(\"IP is invalid. Only IPv4 addresses are supported.\")"},{"line_number":646,"context_line":"            LOG.error(err_msg)"},{"line_number":647,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_00fc6b3c","line":644,"range":{"start_line":644,"start_character":23,"end_line":644,"end_character":33},"updated":"2015-12-21 14:21:39.000000000","message":"Please, use manila utils located at [1]\n\n[1] https://github.com/openstack/manila/blob/3155ca01/manila/utils.py#L500","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        vlan_tag \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":642,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":643,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":644,"context_line":"        if not netaddr.valid_ipv4(ip):"},{"line_number":645,"context_line":"            err_msg \u003d _(\"IP is invalid. Only IPv4 addresses are supported.\")"},{"line_number":646,"context_line":"            LOG.error(err_msg)"},{"line_number":647,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_df338860","line":644,"range":{"start_line":644,"start_character":23,"end_line":644,"end_character":33},"in_reply_to":"3a7e1126_00fc6b3c","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":643,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":644,"context_line":"        if not netaddr.valid_ipv4(ip):"},{"line_number":645,"context_line":"            err_msg \u003d _(\"IP is invalid. Only IPv4 addresses are supported.\")"},{"line_number":646,"context_line":"            LOG.error(err_msg)"},{"line_number":647,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_408d93d4","line":645,"range":{"start_line":645,"start_character":31,"end_line":645,"end_character":38},"updated":"2015-12-21 14:21:39.000000000","message":"Error message should contain value that is invalid.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":643,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":644,"context_line":"        if not netaddr.valid_ipv4(ip):"},{"line_number":645,"context_line":"            err_msg \u003d _(\"IP is invalid. Only IPv4 addresses are supported.\")"},{"line_number":646,"context_line":"            LOG.error(err_msg)"},{"line_number":647,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_ffd204d0","line":645,"range":{"start_line":645,"start_character":31,"end_line":645,"end_character":38},"in_reply_to":"3a7e1126_408d93d4","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"            # Configure AD or LDAP Domain."},{"line_number":654,"context_line":"            if active_directory:"},{"line_number":655,"context_line":"                self._configure_AD_domain(active_directory)"},{"line_number":656,"context_line":"            if ldap:"},{"line_number":657,"context_line":"                self._configure_LDAP_domain(ldap)"},{"line_number":658,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_c0bf435f","line":655,"range":{"start_line":655,"start_character":16,"end_line":655,"end_character":20},"updated":"2015-12-21 14:21:39.000000000","message":"Is it valid case to configure both at once?","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"            # Configure AD or LDAP Domain."},{"line_number":654,"context_line":"            if active_directory:"},{"line_number":655,"context_line":"                self._configure_AD_domain(active_directory)"},{"line_number":656,"context_line":"            if ldap:"},{"line_number":657,"context_line":"                self._configure_LDAP_domain(ldap)"},{"line_number":658,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_ffa0c443","line":655,"range":{"start_line":655,"start_character":16,"end_line":655,"end_character":20},"in_reply_to":"3a7e1126_c0bf435f","updated":"2015-12-22 02:58:35.000000000","message":"Yes, we can configure them both at one time. In Manila security_service, it also can configure AD and LDAP at once.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        return {"},{"line_number":664,"context_line":"            \u0027share_server_name\u0027: network_info[\u0027server_id\u0027],"},{"line_number":665,"context_line":"            \u0027share_server_id\u0027: network_info[\u0027server_id\u0027],"},{"line_number":666,"context_line":"            \u0027vlan_id\u0027: vlan_id,"},{"line_number":667,"context_line":"            \u0027logical_port_id\u0027: logical_port_id,"},{"line_number":668,"context_line":"            \u0027ip\u0027: ip,"},{"line_number":669,"context_line":"            \u0027subnet\u0027: subnet,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_0058eb54","line":666,"range":{"start_line":666,"start_character":23,"end_line":666,"end_character":30},"updated":"2015-12-21 14:21:39.000000000","message":"Is it OK to provide \"vlan_id\" using flat networking? Is it tested with flat networking?","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        return {"},{"line_number":664,"context_line":"            \u0027share_server_name\u0027: network_info[\u0027server_id\u0027],"},{"line_number":665,"context_line":"            \u0027share_server_id\u0027: network_info[\u0027server_id\u0027],"},{"line_number":666,"context_line":"            \u0027vlan_id\u0027: vlan_id,"},{"line_number":667,"context_line":"            \u0027logical_port_id\u0027: logical_port_id,"},{"line_number":668,"context_line":"            \u0027ip\u0027: ip,"},{"line_number":669,"context_line":"            \u0027subnet\u0027: subnet,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_d5cfe726","line":666,"range":{"start_line":666,"start_character":23,"end_line":666,"end_character":30},"in_reply_to":"3a7e1126_0058eb54","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        # Check AD config exists or not."},{"line_number":720,"context_line":"        is_exists \u003d self.helper._check_AD_config_exists()"},{"line_number":721,"context_line":"        if is_exists:"},{"line_number":722,"context_line":"            err_msg \u003d _(\"AD domain has already been configured.\")"},{"line_number":723,"context_line":"            LOG.error(err_msg)"},{"line_number":724,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":725,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_60244fc4","line":722,"range":{"start_line":722,"start_character":35,"end_line":722,"end_character":38},"updated":"2015-12-21 14:21:39.000000000","message":"Name of domain would be useful.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        # Check AD config exists or not."},{"line_number":720,"context_line":"        is_exists \u003d self.helper._check_AD_config_exists()"},{"line_number":721,"context_line":"        if is_exists:"},{"line_number":722,"context_line":"            err_msg \u003d _(\"AD domain has already been configured.\")"},{"line_number":723,"context_line":"            LOG.error(err_msg)"},{"line_number":724,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":725,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_22ecf328","line":722,"range":{"start_line":722,"start_character":35,"end_line":722,"end_character":38},"in_reply_to":"3a7e1126_60244fc4","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            result \u003d self._check_AD_expect_status(\u00271\u0027)"},{"line_number":739,"context_line":"            if not result:"},{"line_number":740,"context_line":"                raise exception.InvalidShare("},{"line_number":741,"context_line":"                    reason\u003d(_(\u0027Join AD domain error.\u0027)))"},{"line_number":742,"context_line":"        except Exception as err:"},{"line_number":743,"context_line":"            if DNS_config:"},{"line_number":744,"context_line":"                dns_ip_list \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_40103357","line":741,"range":{"start_line":741,"start_character":39,"end_line":741,"end_character":45},"updated":"2015-12-21 14:21:39.000000000","message":"Same here, need add name of domain.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            result \u003d self._check_AD_expect_status(\u00271\u0027)"},{"line_number":739,"context_line":"            if not result:"},{"line_number":740,"context_line":"                raise exception.InvalidShare("},{"line_number":741,"context_line":"                    reason\u003d(_(\u0027Join AD domain error.\u0027)))"},{"line_number":742,"context_line":"        except Exception as err:"},{"line_number":743,"context_line":"            if DNS_config:"},{"line_number":744,"context_line":"                dns_ip_list \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_42efbf1d","line":741,"range":{"start_line":741,"start_character":39,"end_line":741,"end_character":45},"in_reply_to":"3a7e1126_40103357","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6df57ad1eeb7c5682e079ab3ef63901bffdd8415","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            is_eth_port \u003d False"},{"line_number":860,"context_line":"            for eth in eth_port:"},{"line_number":861,"context_line":"                if (port \u003d\u003d eth[\u0027LOCATION\u0027]"},{"line_number":862,"context_line":"                   and not eth[\u0027IPV4ADDR\u0027] and not eth[\u0027BONDNAME\u0027]"},{"line_number":863,"context_line":"                   and constants.STATUS_ETH_RUNNING \u003d\u003d eth[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":864,"context_line":"                    online_eth_port.append(port)"},{"line_number":865,"context_line":"                    is_eth_port \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_46a7ec0a","line":862,"range":{"start_line":862,"start_character":23,"end_line":862,"end_character":26},"updated":"2015-12-21 14:21:39.000000000","message":"Continuation of condition should have indentation of 8 symbols. Also, please, place and/or operators on the end of previous line.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            is_eth_port \u003d False"},{"line_number":860,"context_line":"            for eth in eth_port:"},{"line_number":861,"context_line":"                if (port \u003d\u003d eth[\u0027LOCATION\u0027]"},{"line_number":862,"context_line":"                   and not eth[\u0027IPV4ADDR\u0027] and not eth[\u0027BONDNAME\u0027]"},{"line_number":863,"context_line":"                   and constants.STATUS_ETH_RUNNING \u003d\u003d eth[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":864,"context_line":"                    online_eth_port.append(port)"},{"line_number":865,"context_line":"                    is_eth_port \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_62c3db38","line":862,"range":{"start_line":862,"start_character":23,"end_line":862,"end_character":26},"in_reply_to":"3a7e1126_46a7ec0a","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"993ac8375dce52c6022489ba35d2b55a491f3095","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        if self.configuration.driver_handles_share_servers:"},{"line_number":610,"context_line":"            if not port:"},{"line_number":611,"context_line":"                err_msg \u003d (_("},{"line_number":612,"context_line":"                    \u0027check_conf_file: Config file invalid. Port must be set \u0027"},{"line_number":613,"context_line":"                    \u0027when driver_handles_share_servers is True.\u0027))"},{"line_number":614,"context_line":"                LOG.error(err_msg)"},{"line_number":615,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":616,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_f010ea01","line":613,"range":{"start_line":611,"start_character":0,"end_line":613,"end_character":66},"updated":"2015-12-22 10:18:04.000000000","message":"Redundant parentheses.","commit_id":"2151659881474e1743eed56b7519a2ff9def1c51"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f882050275807e765f9fbce857d2fd673f6d0a9f","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        if self.configuration.driver_handles_share_servers:"},{"line_number":610,"context_line":"            if not port:"},{"line_number":611,"context_line":"                err_msg \u003d (_("},{"line_number":612,"context_line":"                    \u0027check_conf_file: Config file invalid. Port must be set \u0027"},{"line_number":613,"context_line":"                    \u0027when driver_handles_share_servers is True.\u0027))"},{"line_number":614,"context_line":"                LOG.error(err_msg)"},{"line_number":615,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":616,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_72b612de","line":613,"range":{"start_line":611,"start_character":0,"end_line":613,"end_character":66},"in_reply_to":"3a7e1126_f010ea01","updated":"2015-12-23 08:23:25.000000000","message":"Keep consistent with before sentences.","commit_id":"2151659881474e1743eed56b7519a2ff9def1c51"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"993ac8375dce52c6022489ba35d2b55a491f3095","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":616,"context_line":"        else:"},{"line_number":617,"context_line":"            if not logical_port_ip:"},{"line_number":618,"context_line":"                err_msg \u003d (_("},{"line_number":619,"context_line":"                    \u0027check_conf_file: Config file invalid. LogicalPortIP \u0027"},{"line_number":620,"context_line":"                    \u0027must be set when driver_handles_share_servers is False.\u0027))"},{"line_number":621,"context_line":"                LOG.error(err_msg)"},{"line_number":622,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_d024ce60","line":620,"range":{"start_line":618,"start_character":0,"end_line":620,"end_character":79},"updated":"2015-12-22 10:18:04.000000000","message":"Same as above.","commit_id":"2151659881474e1743eed56b7519a2ff9def1c51"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f882050275807e765f9fbce857d2fd673f6d0a9f","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":616,"context_line":"        else:"},{"line_number":617,"context_line":"            if not logical_port_ip:"},{"line_number":618,"context_line":"                err_msg \u003d (_("},{"line_number":619,"context_line":"                    \u0027check_conf_file: Config file invalid. LogicalPortIP \u0027"},{"line_number":620,"context_line":"                    \u0027must be set when driver_handles_share_servers is False.\u0027))"},{"line_number":621,"context_line":"                LOG.error(err_msg)"},{"line_number":622,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":623,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_b2c47a40","line":620,"range":{"start_line":618,"start_character":0,"end_line":620,"end_character":79},"in_reply_to":"3a7e1126_d024ce60","updated":"2015-12-23 08:23:25.000000000","message":"Same as above.","commit_id":"2151659881474e1743eed56b7519a2ff9def1c51"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"993ac8375dce52c6022489ba35d2b55a491f3095","unresolved":false,"context_lines":[{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def _check_network_type_validate(self, network_type):"},{"line_number":673,"context_line":"        if network_type !\u003d \u0027vlan\u0027:"},{"line_number":674,"context_line":"            err_msg \u003d (_("},{"line_number":675,"context_line":"                \u0027Invalid network type. Network type must be vlan.\u0027))"},{"line_number":676,"context_line":"            raise exception.NetworkBadConfigurationException(reason\u003derr_msg)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def _get_valid_security_service(self, security_services):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_240ab48a","line":675,"range":{"start_line":674,"start_character":0,"end_line":675,"end_character":68},"updated":"2015-12-22 10:18:04.000000000","message":"Same as above.","commit_id":"2151659881474e1743eed56b7519a2ff9def1c51"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f882050275807e765f9fbce857d2fd673f6d0a9f","unresolved":false,"context_lines":[{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def _check_network_type_validate(self, network_type):"},{"line_number":673,"context_line":"        if network_type !\u003d \u0027vlan\u0027:"},{"line_number":674,"context_line":"            err_msg \u003d (_("},{"line_number":675,"context_line":"                \u0027Invalid network type. Network type must be vlan.\u0027))"},{"line_number":676,"context_line":"            raise exception.NetworkBadConfigurationException(reason\u003derr_msg)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def _get_valid_security_service(self, security_services):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_72ddb213","line":675,"range":{"start_line":674,"start_character":0,"end_line":675,"end_character":68},"in_reply_to":"3a7e1126_240ab48a","updated":"2015-12-23 08:23:25.000000000","message":"Same as above.","commit_id":"2151659881474e1743eed56b7519a2ff9def1c51"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"00282575a91f42094970708554116328199061fb","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        err_msg \u003d _(\"Unsupported security services. \""},{"line_number":682,"context_line":"                    \"Only AD and LDAP are supported.\")"},{"line_number":683,"context_line":"        if service_number \u003e 2:"},{"line_number":684,"context_line":"            LOG.error(err_msg)"},{"line_number":685,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        active_directory \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_764a59c7","line":684,"range":{"start_line":684,"start_character":0,"end_line":684,"end_character":30},"updated":"2015-12-24 10:07:05.000000000","message":"Please add unit test.","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        err_msg \u003d _(\"Unsupported security services. \""},{"line_number":682,"context_line":"                    \"Only AD and LDAP are supported.\")"},{"line_number":683,"context_line":"        if service_number \u003e 2:"},{"line_number":684,"context_line":"            LOG.error(err_msg)"},{"line_number":685,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"        active_directory \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_db8a28bf","line":684,"range":{"start_line":684,"start_character":0,"end_line":684,"end_character":30},"in_reply_to":"1a7b0d38_764a59c7","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"1c93253205771212518241d15fb4b48b918b3766","unresolved":false,"context_lines":[{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # Set DNS server ip."},{"line_number":727,"context_line":"        dns_ip_list \u003d []"},{"line_number":728,"context_line":"        dns_ip_list.append(dns_ip)"},{"line_number":729,"context_line":"        DNS_config \u003d self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        # Set AD config."}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_81b1aae3","line":728,"range":{"start_line":728,"start_character":33,"end_line":728,"end_character":34},"updated":"2015-12-25 09:10:10.000000000","message":"In _set_DNS_ip_address, you checked len() of dns_ip_list. But, it always be 1. It\u0027s may be a mistake.","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # Set DNS server ip."},{"line_number":727,"context_line":"        dns_ip_list \u003d []"},{"line_number":728,"context_line":"        dns_ip_list.append(dns_ip)"},{"line_number":729,"context_line":"        DNS_config \u003d self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        # Set AD config."}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_fb85a4ac","line":728,"range":{"start_line":728,"start_character":33,"end_line":728,"end_character":34},"in_reply_to":"1a7b0d38_81b1aae3","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"00282575a91f42094970708554116328199061fb","unresolved":false,"context_lines":[{"line_number":740,"context_line":"                raise exception.InvalidShare("},{"line_number":741,"context_line":"                    reason\u003d(_(\u0027Join AD domain(%s) error.\u0027) % domain))"},{"line_number":742,"context_line":"        except Exception as err:"},{"line_number":743,"context_line":"            if DNS_config:"},{"line_number":744,"context_line":"                dns_ip_list \u003d []"},{"line_number":745,"context_line":"                self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":746,"context_line":"            raise exception.InvalidShare("},{"line_number":747,"context_line":"                reason\u003d(_(\u0027Failed to add AD config. \u0027"},{"line_number":748,"context_line":"                          \u0027Reason: %s.\u0027) % err))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_36c85122","line":745,"range":{"start_line":743,"start_character":12,"end_line":745,"end_character":39},"updated":"2015-12-24 10:07:05.000000000","message":"Please add unit test.","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":740,"context_line":"                raise exception.InvalidShare("},{"line_number":741,"context_line":"                    reason\u003d(_(\u0027Join AD domain(%s) error.\u0027) % domain))"},{"line_number":742,"context_line":"        except Exception as err:"},{"line_number":743,"context_line":"            if DNS_config:"},{"line_number":744,"context_line":"                dns_ip_list \u003d []"},{"line_number":745,"context_line":"                self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":746,"context_line":"            raise exception.InvalidShare("},{"line_number":747,"context_line":"                reason\u003d(_(\u0027Failed to add AD config. \u0027"},{"line_number":748,"context_line":"                          \u0027Reason: %s.\u0027) % err))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_9b94a0e2","line":745,"range":{"start_line":743,"start_character":12,"end_line":745,"end_character":39},"in_reply_to":"1a7b0d38_36c85122","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"00282575a91f42094970708554116328199061fb","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        while not (self._check_AD_status(ad[\u0027DOMAINSTATUS\u0027], expected_status)"},{"line_number":757,"context_line":"                   or time.time() \u003e end_time):"},{"line_number":758,"context_line":"            time.sleep(wait_interval)"},{"line_number":759,"context_line":"            ad \u003d self.helper._get_AD_config()"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        if not self._check_AD_status(ad[\u0027DOMAINSTATUS\u0027], expected_status):"},{"line_number":762,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_36eff188","line":759,"range":{"start_line":759,"start_character":12,"end_line":759,"end_character":45},"updated":"2015-12-24 10:07:05.000000000","message":"same","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        while not (self._check_AD_status(ad[\u0027DOMAINSTATUS\u0027], expected_status)"},{"line_number":757,"context_line":"                   or time.time() \u003e end_time):"},{"line_number":758,"context_line":"            time.sleep(wait_interval)"},{"line_number":759,"context_line":"            ad \u003d self.helper._get_AD_config()"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"        if not self._check_AD_status(ad[\u0027DOMAINSTATUS\u0027], expected_status):"},{"line_number":762,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_bb8f1ccb","line":759,"range":{"start_line":759,"start_character":12,"end_line":759,"end_character":45},"in_reply_to":"1a7b0d38_36eff188","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"00282575a91f42094970708554116328199061fb","unresolved":false,"context_lines":[{"line_number":898,"context_line":"            sorted_bond \u003d self._get_sorted_least_port(bond_port)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        if sorted_eth and sorted_bond:"},{"line_number":901,"context_line":"            if sorted_eth[1] \u003e\u003d sorted_bond[1]:"},{"line_number":902,"context_line":"                return sorted_bond[0], constants.PORT_TYPE_BOND"},{"line_number":903,"context_line":"            elif sorted_eth[1] \u003c sorted_bond[1]:"},{"line_number":904,"context_line":"                return sorted_eth[0], constants.PORT_TYPE_ETH"},{"line_number":905,"context_line":"        elif sorted_eth and not sorted_bond:"},{"line_number":906,"context_line":"            return sorted_eth[0], constants.PORT_TYPE_ETH"},{"line_number":907,"context_line":"        elif not sorted_eth and sorted_bond:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_f6e8897e","line":904,"range":{"start_line":901,"start_character":11,"end_line":904,"end_character":61},"updated":"2015-12-24 10:07:05.000000000","message":"same","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":898,"context_line":"            sorted_bond \u003d self._get_sorted_least_port(bond_port)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        if sorted_eth and sorted_bond:"},{"line_number":901,"context_line":"            if sorted_eth[1] \u003e\u003d sorted_bond[1]:"},{"line_number":902,"context_line":"                return sorted_bond[0], constants.PORT_TYPE_BOND"},{"line_number":903,"context_line":"            elif sorted_eth[1] \u003c sorted_bond[1]:"},{"line_number":904,"context_line":"                return sorted_eth[0], constants.PORT_TYPE_ETH"},{"line_number":905,"context_line":"        elif sorted_eth and not sorted_bond:"},{"line_number":906,"context_line":"            return sorted_eth[0], constants.PORT_TYPE_ETH"},{"line_number":907,"context_line":"        elif not sorted_eth and sorted_bond:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_7bc0d4e0","line":904,"range":{"start_line":901,"start_character":11,"end_line":904,"end_character":61},"in_reply_to":"1a7b0d38_f6e8897e","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"00282575a91f42094970708554116328199061fb","unresolved":false,"context_lines":[{"line_number":922,"context_line":"            for vlan in vlan_list:"},{"line_number":923,"context_line":"                pos \u003d vlan[\u0027NAME\u0027].rfind(\u0027.\u0027)"},{"line_number":924,"context_line":"                if vlan[\u0027NAME\u0027][:pos] \u003d\u003d item:"},{"line_number":925,"context_line":"                    count[item] +\u003d 1"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        sort_port \u003d sorted(count.items(), key\u003dlambda count: count[1])"},{"line_number":928,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_76fd7939","line":925,"range":{"start_line":925,"start_character":21,"end_line":925,"end_character":36},"updated":"2015-12-24 10:07:05.000000000","message":"same","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":922,"context_line":"            for vlan in vlan_list:"},{"line_number":923,"context_line":"                pos \u003d vlan[\u0027NAME\u0027].rfind(\u0027.\u0027)"},{"line_number":924,"context_line":"                if vlan[\u0027NAME\u0027][:pos] \u003d\u003d item:"},{"line_number":925,"context_line":"                    count[item] +\u003d 1"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        sort_port \u003d sorted(count.items(), key\u003dlambda count: count[1])"},{"line_number":928,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_1bb75087","line":925,"range":{"start_line":925,"start_character":21,"end_line":925,"end_character":36},"in_reply_to":"1a7b0d38_76fd7939","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"00282575a91f42094970708554116328199061fb","unresolved":false,"context_lines":[{"line_number":961,"context_line":"                # Check DNS server exists or not."},{"line_number":962,"context_line":"                ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":963,"context_line":"                if ip_address and ip_address[0] and ip_address[0] \u003d\u003d dns_ip:"},{"line_number":964,"context_line":"                    dns_ip_list \u003d []"},{"line_number":965,"context_line":"                    self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"                # Check AD config exists or not."},{"line_number":968,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._check_AD_config_exists()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_369611f1","line":965,"range":{"start_line":964,"start_character":20,"end_line":965,"end_character":64},"updated":"2015-12-24 10:07:05.000000000","message":"same","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f2ddf87ea83cdeeb15691e7cf772dd5ef75eeda9","unresolved":false,"context_lines":[{"line_number":961,"context_line":"                # Check DNS server exists or not."},{"line_number":962,"context_line":"                ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":963,"context_line":"                if ip_address and ip_address[0] and ip_address[0] \u003d\u003d dns_ip:"},{"line_number":964,"context_line":"                    dns_ip_list \u003d []"},{"line_number":965,"context_line":"                    self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"                # Check AD config exists or not."},{"line_number":968,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._check_AD_config_exists()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_3bba4c6f","line":965,"range":{"start_line":964,"start_character":20,"end_line":965,"end_character":64},"in_reply_to":"1a7b0d38_369611f1","updated":"2015-12-26 10:04:51.000000000","message":"Done","commit_id":"5dd35ae76d017d10c1cdc27de6dffe7c967c8560"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4dedf8d50cc62cc3a51d3a67f569273594391ef1","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                (service[\u0027SUPPORTV4\u0027] \u003d\u003d \u0027false\u0027)):"},{"line_number":633,"context_line":"            self.helper._start_nfs_service_status()"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":636,"context_line":"        \"\"\"Set up share server with given network parameters.\"\"\""},{"line_number":637,"context_line":"        self._check_network_type_validate(network_info[\u0027network_type\u0027])"},{"line_number":638,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_f8f753f3","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":20},"updated":"2015-12-30 10:02:29.000000000","message":"Shouldn\u0027t this be _setup_server? since setup_server from ShareDriver seems find for me and don\u0027t have to be overwritten.","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"4318d269bc0d39d79ecdf3af1b28d219039b125d","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                (service[\u0027SUPPORTV4\u0027] \u003d\u003d \u0027false\u0027)):"},{"line_number":633,"context_line":"            self.helper._start_nfs_service_status()"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def setup_server(self, network_info, metadata\u003dNone):"},{"line_number":636,"context_line":"        \"\"\"Set up share server with given network parameters.\"\"\""},{"line_number":637,"context_line":"        self._check_network_type_validate(network_info[\u0027network_type\u0027])"},{"line_number":638,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_6e20559c","line":635,"range":{"start_line":635,"start_character":8,"end_line":635,"end_character":20},"in_reply_to":"fa69d971_f8f753f3","updated":"2015-12-31 10:01:31.000000000","message":"_setup_server is in huawei_nas.py","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4dedf8d50cc62cc3a51d3a67f569273594391ef1","unresolved":false,"context_lines":[{"line_number":735,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        # Check AD config exists or not."},{"line_number":738,"context_line":"        is_exists, AD_domain \u003d self.helper._check_AD_config_exists()"},{"line_number":739,"context_line":"        if is_exists:"},{"line_number":740,"context_line":"            err_msg \u003d (_(\"AD domain(%s) has already been configured.\")"},{"line_number":741,"context_line":"                       % AD_domain)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_fbe18dff","line":738,"range":{"start_line":738,"start_character":42,"end_line":738,"end_character":66},"updated":"2015-12-30 10:02:29.000000000","message":"I would rename this to \"get_AD_config\". If it doesn\u0027t exist it returns None.","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"4318d269bc0d39d79ecdf3af1b28d219039b125d","unresolved":false,"context_lines":[{"line_number":735,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        # Check AD config exists or not."},{"line_number":738,"context_line":"        is_exists, AD_domain \u003d self.helper._check_AD_config_exists()"},{"line_number":739,"context_line":"        if is_exists:"},{"line_number":740,"context_line":"            err_msg \u003d (_(\"AD domain(%s) has already been configured.\")"},{"line_number":741,"context_line":"                       % AD_domain)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_2e3b3dd3","line":738,"range":{"start_line":738,"start_character":42,"end_line":738,"end_character":66},"in_reply_to":"fa69d971_fbe18dff","updated":"2015-12-31 10:01:31.000000000","message":"Done","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4dedf8d50cc62cc3a51d3a67f569273594391ef1","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    def _check_AD_expected_status(self, expected_status):"},{"line_number":769,"context_line":"        wait_interval \u003d self._get_wait_interval()"},{"line_number":770,"context_line":"        timeout \u003d self._get_timeout()"},{"line_number":771,"context_line":"        end_time \u003d time.time() + timeout"},{"line_number":772,"context_line":"        ad \u003d self.helper._get_AD_config()"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"        while not (self._check_AD_status(ad[\u0027DOMAINSTATUS\u0027], expected_status)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_3b308556","line":771,"updated":"2015-12-30 10:02:29.000000000","message":"You might could use maila.util.retry here?","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"4318d269bc0d39d79ecdf3af1b28d219039b125d","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    def _check_AD_expected_status(self, expected_status):"},{"line_number":769,"context_line":"        wait_interval \u003d self._get_wait_interval()"},{"line_number":770,"context_line":"        timeout \u003d self._get_timeout()"},{"line_number":771,"context_line":"        end_time \u003d time.time() + timeout"},{"line_number":772,"context_line":"        ad \u003d self.helper._get_AD_config()"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"        while not (self._check_AD_status(ad[\u0027DOMAINSTATUS\u0027], expected_status)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_4e38f1d3","line":771,"in_reply_to":"fa69d971_3b308556","updated":"2015-12-31 10:01:31.000000000","message":"Done","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4dedf8d50cc62cc3a51d3a67f569273594391ef1","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            raise exception.InvalidInput(_(\"server or domain is None.\"))"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        # Check LDAP config exists or not."},{"line_number":794,"context_line":"        is_exists, LDAP_domain \u003d self.helper._check_LDAP_config_exists()"},{"line_number":795,"context_line":"        if is_exists:"},{"line_number":796,"context_line":"            err_msg \u003d (_(\"LDAP domain(%s) has already been configured.\")"},{"line_number":797,"context_line":"                       % LDAP_domain)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_5b81b98e","line":794,"range":{"start_line":794,"start_character":45,"end_line":794,"end_character":70},"updated":"2015-12-30 10:02:29.000000000","message":"Also see the function naming (see L738)","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4dedf8d50cc62cc3a51d3a67f569273594391ef1","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            raise exception.InvalidInput(_(\"server or domain is None.\"))"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        # Check LDAP config exists or not."},{"line_number":794,"context_line":"        is_exists, LDAP_domain \u003d self.helper._check_LDAP_config_exists()"},{"line_number":795,"context_line":"        if is_exists:"},{"line_number":796,"context_line":"            err_msg \u003d (_(\"LDAP domain(%s) has already been configured.\")"},{"line_number":797,"context_line":"                       % LDAP_domain)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_9bb0918d","line":794,"updated":"2015-12-30 10:02:29.000000000","message":"Seems to be a code dup to L738 (just LDAP instead of AD). I think you could deduplicate this into a helper function.","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"4318d269bc0d39d79ecdf3af1b28d219039b125d","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            raise exception.InvalidInput(_(\"server or domain is None.\"))"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        # Check LDAP config exists or not."},{"line_number":794,"context_line":"        is_exists, LDAP_domain \u003d self.helper._check_LDAP_config_exists()"},{"line_number":795,"context_line":"        if is_exists:"},{"line_number":796,"context_line":"            err_msg \u003d (_(\"LDAP domain(%s) has already been configured.\")"},{"line_number":797,"context_line":"                       % LDAP_domain)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_ee3445df","line":794,"range":{"start_line":794,"start_character":45,"end_line":794,"end_character":70},"in_reply_to":"fa69d971_5b81b98e","updated":"2015-12-31 10:01:31.000000000","message":"Done","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"4318d269bc0d39d79ecdf3af1b28d219039b125d","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            raise exception.InvalidInput(_(\"server or domain is None.\"))"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        # Check LDAP config exists or not."},{"line_number":794,"context_line":"        is_exists, LDAP_domain \u003d self.helper._check_LDAP_config_exists()"},{"line_number":795,"context_line":"        if is_exists:"},{"line_number":796,"context_line":"            err_msg \u003d (_(\"LDAP domain(%s) has already been configured.\")"},{"line_number":797,"context_line":"                       % LDAP_domain)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_4e3f91b4","line":794,"in_reply_to":"fa69d971_9bb0918d","updated":"2015-12-31 10:01:31.000000000","message":"The name is changed. Please recheck.","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        share_client_type \u003d self.helper._get_share_client_type(share_proto)"},{"line_number":375,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":376,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":377,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access type is allowed for \u0027"},{"line_number":378,"context_line":"                            \u0027NFS shares.\u0027))"},{"line_number":379,"context_line":"            return"},{"line_number":380,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_6567a4b7","line":377,"range":{"start_line":377,"start_character":45,"end_line":377,"end_character":60},"updated":"2016-01-05 16:15:13.000000000","message":"s/access type is/access types are/ allowed","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        share_client_type \u003d self.helper._get_share_client_type(share_proto)"},{"line_number":375,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":376,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027 and access_type not in (\u0027ip\u0027, \u0027user\u0027):"},{"line_number":377,"context_line":"            LOG.warning(_LW(\u0027Only IP or USER access type is allowed for \u0027"},{"line_number":378,"context_line":"                            \u0027NFS shares.\u0027))"},{"line_number":379,"context_line":"            return"},{"line_number":380,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027 and access_type !\u003d \u0027user\u0027:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_16ecc4f1","line":377,"range":{"start_line":377,"start_character":45,"end_line":377,"end_character":60},"in_reply_to":"fa69d971_6567a4b7","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                # A group name is start with @."},{"line_number":418,"context_line":"                access_to \u003d \u0027@\u0027 + access_to"},{"line_number":419,"context_line":"            elif access_type !\u003d \u0027ip\u0027:"},{"line_number":420,"context_line":"                message \u003d _(\u0027Only IP or USER access type \u0027"},{"line_number":421,"context_line":"                            \u0027is allowed for NFS shares.\u0027)"},{"line_number":422,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":423,"context_line":"            if access_level \u003d\u003d common_constants.ACCESS_LEVEL_RW:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_450140ae","line":420,"updated":"2016-01-05 16:15:13.000000000","message":"ditto","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                # A group name is start with @."},{"line_number":418,"context_line":"                access_to \u003d \u0027@\u0027 + access_to"},{"line_number":419,"context_line":"            elif access_type !\u003d \u0027ip\u0027:"},{"line_number":420,"context_line":"                message \u003d _(\u0027Only IP or USER access type \u0027"},{"line_number":421,"context_line":"                            \u0027is allowed for NFS shares.\u0027)"},{"line_number":422,"context_line":"                raise exception.InvalidShareAccess(reason\u003dmessage)"},{"line_number":423,"context_line":"            if access_level \u003d\u003d common_constants.ACCESS_LEVEL_RW:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_b6bdb8d9","line":420,"in_reply_to":"fa69d971_450140ae","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            LOG.error(err_msg)"},{"line_number":606,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        if (not self.configuration.driver_handles_share_servers"},{"line_number":609,"context_line":"                and not logical_port_ip):"},{"line_number":610,"context_line":"            err_msg \u003d (_("},{"line_number":611,"context_line":"                \u0027check_conf_file: Config file invalid. LogicalPortIP \u0027"},{"line_number":612,"context_line":"                \u0027must be set when driver_handles_share_servers is False.\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_6aa53345","line":609,"range":{"start_line":608,"start_character":11,"end_line":609,"end_character":40},"updated":"2016-01-05 16:15:13.000000000","message":"Instead of\n\n\"if (not a and not b)\"\n\nshould be:\n\n\"if not (a or b)\"","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            LOG.error(err_msg)"},{"line_number":606,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        if (not self.configuration.driver_handles_share_servers"},{"line_number":609,"context_line":"                and not logical_port_ip):"},{"line_number":610,"context_line":"            err_msg \u003d (_("},{"line_number":611,"context_line":"                \u0027check_conf_file: Config file invalid. LogicalPortIP \u0027"},{"line_number":612,"context_line":"                \u0027must be set when driver_handles_share_servers is False.\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_d6c06c52","line":609,"range":{"start_line":608,"start_character":11,"end_line":609,"end_character":40},"in_reply_to":"fa69d971_6aa53345","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"68e77f836c31729c21e81bb1f69420215da10472","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        self._check_network_type_validate(network_info[\u0027network_type\u0027])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        vlan_tag \u003d network_info[\u0027segmentation_id\u0027] or 0"},{"line_number":632,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":633,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":634,"context_line":"        if not utils.is_valid_ip_address(ip, \u00274\u0027):"},{"line_number":635,"context_line":"            err_msg \u003d (_("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_c4767dd6","line":632,"updated":"2016-01-06 01:08:22.000000000","message":"Can network_info[\u0027network_allocations\u0027] be None or []?","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        self._check_network_type_validate(network_info[\u0027network_type\u0027])"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        vlan_tag \u003d network_info[\u0027segmentation_id\u0027] or 0"},{"line_number":632,"context_line":"        ip \u003d network_info[\u0027network_allocations\u0027][0][\u0027ip_address\u0027]"},{"line_number":633,"context_line":"        subnet \u003d utils.cidr_to_netmask(network_info[\u0027cidr\u0027])"},{"line_number":634,"context_line":"        if not utils.is_valid_ip_address(ip, \u00274\u0027):"},{"line_number":635,"context_line":"            err_msg \u003d (_("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_f6c7b061","line":632,"in_reply_to":"fa69d971_c4767dd6","updated":"2016-01-06 07:10:53.000000000","message":"neutron_network_plugin will check it.","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"68e77f836c31729c21e81bb1f69420215da10472","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        # Check DNS server exists or not."},{"line_number":719,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":720,"context_line":"        if ip_address and ip_address[0]:"},{"line_number":721,"context_line":"            err_msg \u003d (_(\"DNS server(%s) has already been configured.\")"},{"line_number":722,"context_line":"                       % ip_address[0])"},{"line_number":723,"context_line":"            LOG.error(err_msg)"},{"line_number":724,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_e4414164","line":721,"updated":"2016-01-06 01:08:22.000000000","message":"Maybe should add a space after server: \"server (%s)\"?","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        # Check DNS server exists or not."},{"line_number":719,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":720,"context_line":"        if ip_address and ip_address[0]:"},{"line_number":721,"context_line":"            err_msg \u003d (_(\"DNS server(%s) has already been configured.\")"},{"line_number":722,"context_line":"                       % ip_address[0])"},{"line_number":723,"context_line":"            LOG.error(err_msg)"},{"line_number":724,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_f69ed061","line":721,"in_reply_to":"fa69d971_e4414164","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"68e77f836c31729c21e81bb1f69420215da10472","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        # Check AD config exists or not."},{"line_number":727,"context_line":"        is_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":728,"context_line":"        if is_exists:"},{"line_number":729,"context_line":"            err_msg \u003d (_(\"AD domain(%s) has already been configured.\")"},{"line_number":730,"context_line":"                       % AD_domain)"},{"line_number":731,"context_line":"            LOG.error(err_msg)"},{"line_number":732,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_c45d1d48","line":729,"updated":"2016-01-06 01:08:22.000000000","message":"Should we add a space after domain? You determine it, I\u0027m not sure.","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        # Check AD config exists or not."},{"line_number":727,"context_line":"        is_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":728,"context_line":"        if is_exists:"},{"line_number":729,"context_line":"            err_msg \u003d (_(\"AD domain(%s) has already been configured.\")"},{"line_number":730,"context_line":"                       % AD_domain)"},{"line_number":731,"context_line":"            LOG.error(err_msg)"},{"line_number":732,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_169a846e","line":729,"in_reply_to":"fa69d971_c45d1d48","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"68e77f836c31729c21e81bb1f69420215da10472","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        server \u003d ldap[\u0027server\u0027]"},{"line_number":776,"context_line":"        domain \u003d ldap[\u0027domain\u0027]"},{"line_number":777,"context_line":"        if not server or not domain:"},{"line_number":778,"context_line":"            raise exception.InvalidInput(_(\"server or domain is None.\"))"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Check LDAP config exists or not."},{"line_number":781,"context_line":"        is_exists, LDAP_domain \u003d self.helper._get_LDAP_domain_server()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_8453a538","line":778,"updated":"2016-01-06 01:08:22.000000000","message":"s/server/Server","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        server \u003d ldap[\u0027server\u0027]"},{"line_number":776,"context_line":"        domain \u003d ldap[\u0027domain\u0027]"},{"line_number":777,"context_line":"        if not server or not domain:"},{"line_number":778,"context_line":"            raise exception.InvalidInput(_(\"server or domain is None.\"))"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Check LDAP config exists or not."},{"line_number":781,"context_line":"        is_exists, LDAP_domain \u003d self.helper._get_LDAP_domain_server()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_b68b781e","line":778,"in_reply_to":"fa69d971_8453a538","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"68e77f836c31729c21e81bb1f69420215da10472","unresolved":false,"context_lines":[{"line_number":887,"context_line":"            for port in all_port_list:"},{"line_number":888,"context_line":"                is_eth_port \u003d False"},{"line_number":889,"context_line":"                for eth in online_eth_port:"},{"line_number":890,"context_line":"                    if (port \u003d\u003d eth):"},{"line_number":891,"context_line":"                        filtered_eth_port.append(port)"},{"line_number":892,"context_line":"                        is_eth_port \u003d True"},{"line_number":893,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_043ed5d9","line":890,"updated":"2016-01-06 01:08:22.000000000","message":"The \"()\" is no need.","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":887,"context_line":"            for port in all_port_list:"},{"line_number":888,"context_line":"                is_eth_port \u003d False"},{"line_number":889,"context_line":"                for eth in online_eth_port:"},{"line_number":890,"context_line":"                    if (port \u003d\u003d eth):"},{"line_number":891,"context_line":"                        filtered_eth_port.append(port)"},{"line_number":892,"context_line":"                        is_eth_port \u003d True"},{"line_number":893,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_d68e2c2d","line":890,"in_reply_to":"fa69d971_043ed5d9","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"68e77f836c31729c21e81bb1f69420215da10472","unresolved":false,"context_lines":[{"line_number":894,"context_line":"                if is_eth_port:"},{"line_number":895,"context_line":"                    continue"},{"line_number":896,"context_line":"                for bond in online_bond_port:"},{"line_number":897,"context_line":"                    if (port \u003d\u003d bond):"},{"line_number":898,"context_line":"                        filtered_bond_port.append(port)"},{"line_number":899,"context_line":"                        break"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_642d51a7","line":897,"updated":"2016-01-06 01:08:22.000000000","message":"The \"()\" is no need.","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":894,"context_line":"                if is_eth_port:"},{"line_number":895,"context_line":"                    continue"},{"line_number":896,"context_line":"                for bond in online_bond_port:"},{"line_number":897,"context_line":"                    if (port \u003d\u003d bond):"},{"line_number":898,"context_line":"                        filtered_bond_port.append(port)"},{"line_number":899,"context_line":"                        break"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_768180fa","line":897,"in_reply_to":"fa69d971_642d51a7","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0673fcf6677411f8ae2f60eaaed85a520b78583b","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":415,"context_line":"            if access_type \u003d\u003d \u0027user\u0027:"},{"line_number":416,"context_line":"                # Use \u0027user\u0027 as \u0027netgroup\u0027 for NFS."},{"line_number":417,"context_line":"                # A group name is start with @."},{"line_number":418,"context_line":"                access_to \u003d \u0027@\u0027 + access_to"},{"line_number":419,"context_line":"            elif access_type !\u003d \u0027ip\u0027:"},{"line_number":420,"context_line":"                message \u003d _(\u0027Only IP or USER access types \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_1402e00b","line":417,"range":{"start_line":417,"start_character":31,"end_line":417,"end_character":39},"updated":"2016-01-08 14:33:11.000000000","message":"\"A group name starts with \u0027@\u0027.\"?","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":415,"context_line":"            if access_type \u003d\u003d \u0027user\u0027:"},{"line_number":416,"context_line":"                # Use \u0027user\u0027 as \u0027netgroup\u0027 for NFS."},{"line_number":417,"context_line":"                # A group name is start with @."},{"line_number":418,"context_line":"                access_to \u003d \u0027@\u0027 + access_to"},{"line_number":419,"context_line":"            elif access_type !\u003d \u0027ip\u0027:"},{"line_number":420,"context_line":"                message \u003d _(\u0027Only IP or USER access types \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_3d3d6bdd","line":417,"range":{"start_line":417,"start_character":31,"end_line":417,"end_character":39},"in_reply_to":"fa69d971_1402e00b","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                \u0027check_conf_file: Config file invalid. LogicalPortIP \u0027"},{"line_number":612,"context_line":"                \u0027must be set when driver_handles_share_servers is False.\u0027))"},{"line_number":613,"context_line":"            LOG.error(err_msg)"},{"line_number":614,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def check_service(self):"},{"line_number":617,"context_line":"        running_status \u003d self.helper._get_cifs_service_status()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_e82e4bf9","line":614,"range":{"start_line":614,"start_character":18,"end_line":614,"end_character":49},"updated":"2016-01-08 15:04:59.000000000","message":"exception.InvalidInput(reason\u003derr_msg)","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                \u0027check_conf_file: Config file invalid. LogicalPortIP \u0027"},{"line_number":612,"context_line":"                \u0027must be set when driver_handles_share_servers is False.\u0027))"},{"line_number":613,"context_line":"            LOG.error(err_msg)"},{"line_number":614,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def check_service(self):"},{"line_number":617,"context_line":"        running_status \u003d self.helper._get_cifs_service_status()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_dd268fcd","line":614,"range":{"start_line":614,"start_character":18,"end_line":614,"end_character":49},"in_reply_to":"fa69d971_e82e4bf9","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            err_msg \u003d (_("},{"line_number":636,"context_line":"                \"IP (%s) is invalid. Only IPv4 addresses are supported.\") % ip)"},{"line_number":637,"context_line":"            LOG.error(err_msg)"},{"line_number":638,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"        ad_created \u003d False"},{"line_number":641,"context_line":"        ldap_created \u003d False"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_281c63c0","line":638,"updated":"2016-01-08 15:04:59.000000000","message":"Same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":635,"context_line":"            err_msg \u003d (_("},{"line_number":636,"context_line":"                \"IP (%s) is invalid. Only IPv4 addresses are supported.\") % ip)"},{"line_number":637,"context_line":"            LOG.error(err_msg)"},{"line_number":638,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":639,"context_line":""},{"line_number":640,"context_line":"        ad_created \u003d False"},{"line_number":641,"context_line":"        ldap_created \u003d False"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_fd2353bb","line":638,"in_reply_to":"fa69d971_281c63c0","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                    \"Only AD and LDAP are supported.\")"},{"line_number":691,"context_line":"        if service_number \u003e 2:"},{"line_number":692,"context_line":"            LOG.error(err_msg)"},{"line_number":693,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        active_directory \u003d None"},{"line_number":696,"context_line":"        ldap \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_68501b5f","line":693,"updated":"2016-01-08 15:04:59.000000000","message":"Same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                    \"Only AD and LDAP are supported.\")"},{"line_number":691,"context_line":"        if service_number \u003e 2:"},{"line_number":692,"context_line":"            LOG.error(err_msg)"},{"line_number":693,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        active_directory \u003d None"},{"line_number":696,"context_line":"        ldap \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_9d2c97ad","line":693,"in_reply_to":"fa69d971_68501b5f","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                ldap \u003d ss"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                LOG.error(err_msg)"},{"line_number":704,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        return active_directory, ldap"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_a8d4d3bc","line":704,"updated":"2016-01-08 15:04:59.000000000","message":"same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                ldap \u003d ss"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                LOG.error(err_msg)"},{"line_number":704,"context_line":"                raise exception.InvalidInput(err_msg)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        return active_directory, ldap"},{"line_number":707,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_bd295b9d","line":704,"in_reply_to":"fa69d971_a8d4d3bc","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        if not (dns_ip and user and password and domain):"},{"line_number":714,"context_line":"            raise exception.InvalidInput("},{"line_number":715,"context_line":"                _(\"dns_ip or user or password or domain \""},{"line_number":716,"context_line":"                  \"in security_services is None.\"))"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check DNS server exists or not."},{"line_number":719,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_68fedb39","line":716,"updated":"2016-01-08 15:04:59.000000000","message":"same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":713,"context_line":"        if not (dns_ip and user and password and domain):"},{"line_number":714,"context_line":"            raise exception.InvalidInput("},{"line_number":715,"context_line":"                _(\"dns_ip or user or password or domain \""},{"line_number":716,"context_line":"                  \"in security_services is None.\"))"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        # Check DNS server exists or not."},{"line_number":719,"context_line":"        ip_address \u003d self.helper._get_DNS_ip_address()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_5d193f87","line":716,"in_reply_to":"fa69d971_68fedb39","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":721,"context_line":"            err_msg \u003d (_(\"DNS server (%s) has already been configured.\")"},{"line_number":722,"context_line":"                       % ip_address[0])"},{"line_number":723,"context_line":"            LOG.error(err_msg)"},{"line_number":724,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # Check AD config exists or not."},{"line_number":727,"context_line":"        is_exists, AD_domain \u003d self.helper._get_AD_domain_name()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_a8a29349","line":724,"updated":"2016-01-08 15:04:59.000000000","message":"same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":721,"context_line":"            err_msg \u003d (_(\"DNS server (%s) has already been configured.\")"},{"line_number":722,"context_line":"                       % ip_address[0])"},{"line_number":723,"context_line":"            LOG.error(err_msg)"},{"line_number":724,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"        # Check AD config exists or not."},{"line_number":727,"context_line":"        is_exists, AD_domain \u003d self.helper._get_AD_domain_name()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_7d1e8371","line":724,"in_reply_to":"fa69d971_a8a29349","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":729,"context_line":"            err_msg \u003d (_(\"AD domain (%s) has already been configured.\")"},{"line_number":730,"context_line":"                       % AD_domain)"},{"line_number":731,"context_line":"            LOG.error(err_msg)"},{"line_number":732,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        # Set DNS server ip."},{"line_number":735,"context_line":"        dns_ip_list \u003d dns_ip.split(\",\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_0894ffdf","line":732,"updated":"2016-01-08 15:04:59.000000000","message":"same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":729,"context_line":"            err_msg \u003d (_(\"AD domain (%s) has already been configured.\")"},{"line_number":730,"context_line":"                       % AD_domain)"},{"line_number":731,"context_line":"            LOG.error(err_msg)"},{"line_number":732,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        # Set DNS server ip."},{"line_number":735,"context_line":"        dns_ip_list \u003d dns_ip.split(\",\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_1d0f473a","line":732,"in_reply_to":"fa69d971_0894ffdf","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        server \u003d ldap[\u0027server\u0027]"},{"line_number":776,"context_line":"        domain \u003d ldap[\u0027domain\u0027]"},{"line_number":777,"context_line":"        if not server or not domain:"},{"line_number":778,"context_line":"            raise exception.InvalidInput(_(\"Server or domain is None.\"))"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Check LDAP config exists or not."},{"line_number":781,"context_line":"        is_exists, LDAP_domain \u003d self.helper._get_LDAP_domain_server()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_68ac9b35","line":778,"updated":"2016-01-08 15:04:59.000000000","message":"same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        server \u003d ldap[\u0027server\u0027]"},{"line_number":776,"context_line":"        domain \u003d ldap[\u0027domain\u0027]"},{"line_number":777,"context_line":"        if not server or not domain:"},{"line_number":778,"context_line":"            raise exception.InvalidInput(_(\"Server or domain is None.\"))"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        # Check LDAP config exists or not."},{"line_number":781,"context_line":"        is_exists, LDAP_domain \u003d self.helper._get_LDAP_domain_server()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_3d148b4b","line":778,"in_reply_to":"fa69d971_68ac9b35","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":783,"context_line":"            err_msg \u003d (_(\"LDAP domain (%s) has already been configured.\")"},{"line_number":784,"context_line":"                       % LDAP_domain)"},{"line_number":785,"context_line":"            LOG.error(err_msg)"},{"line_number":786,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        # Set LDAP config."},{"line_number":789,"context_line":"        server_number \u003d len(server.split(\u0027,\u0027))"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_88446f74","line":786,"updated":"2016-01-08 15:04:59.000000000","message":"Please fix all InvalidInput.","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":783,"context_line":"            err_msg \u003d (_(\"LDAP domain (%s) has already been configured.\")"},{"line_number":784,"context_line":"                       % LDAP_domain)"},{"line_number":785,"context_line":"            LOG.error(err_msg)"},{"line_number":786,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        # Set LDAP config."},{"line_number":789,"context_line":"        server_number \u003d len(server.split(\u0027,\u0027))"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_dd0d2f3f","line":786,"in_reply_to":"fa69d971_88446f74","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0673fcf6677411f8ae2f60eaaed85a520b78583b","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            LOG.error(err_msg)"},{"line_number":811,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":812,"context_line":"        if vlan_tag:"},{"line_number":813,"context_line":"            vlan_exists, vlan_id \u003d self.helper._get_vlan(port_id, vlan_tag)"},{"line_number":814,"context_line":"            if not vlan_exists:"},{"line_number":815,"context_line":"                # Create vlan."},{"line_number":816,"context_line":"                vlan_id \u003d self.helper._create_vlan("},{"line_number":817,"context_line":"                    port_id, port_type, vlan_tag)"},{"line_number":818,"context_line":"            home_port_id \u003d vlan_id"},{"line_number":819,"context_line":"            home_port_type \u003d constants.PORT_TYPE_VLAN"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        logical_exists, logical_port_id \u003d ("},{"line_number":822,"context_line":"            self.helper._get_logical_port(home_port_id, ip, subnet))"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_02dcde10","line":819,"range":{"start_line":813,"start_character":0,"end_line":819,"end_character":53},"updated":"2016-01-08 14:33:11.000000000","message":"Not covered by unit tests\n\nhttp://logs.openstack.org/19/259719/17/check/manila-coverage/ccb19df/cover/manila_share_drivers_huawei_v3_connection_py.html#n812","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            LOG.error(err_msg)"},{"line_number":811,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":812,"context_line":"        if vlan_tag:"},{"line_number":813,"context_line":"            vlan_exists, vlan_id \u003d self.helper._get_vlan(port_id, vlan_tag)"},{"line_number":814,"context_line":"            if not vlan_exists:"},{"line_number":815,"context_line":"                # Create vlan."},{"line_number":816,"context_line":"                vlan_id \u003d self.helper._create_vlan("},{"line_number":817,"context_line":"                    port_id, port_type, vlan_tag)"},{"line_number":818,"context_line":"            home_port_id \u003d vlan_id"},{"line_number":819,"context_line":"            home_port_type \u003d constants.PORT_TYPE_VLAN"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        logical_exists, logical_port_id \u003d ("},{"line_number":822,"context_line":"            self.helper._get_logical_port(home_port_id, ip, subnet))"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_bd007b03","line":819,"range":{"start_line":813,"start_character":0,"end_line":819,"end_character":53},"in_reply_to":"fa69d971_02dcde10","updated":"2016-01-09 03:57:31.000000000","message":"This code is covered by unit tests, it\u0027s only not covered by \"else\" branch. Also the \"manila-coverage\" is SUCCESS.","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0673fcf6677411f8ae2f60eaaed85a520b78583b","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                        home_port_id, home_port_type, ip, subnet))"},{"line_number":829,"context_line":"            except Exception as err:"},{"line_number":830,"context_line":"                if not vlan_exists:"},{"line_number":831,"context_line":"                    self.helper._delete_vlan(vlan_id)"},{"line_number":832,"context_line":"                raise exception.InvalidShare("},{"line_number":833,"context_line":"                    reason\u003d(_(\u0027Failed to create logical port. \u0027"},{"line_number":834,"context_line":"                              \u0027Reason: %s.\u0027) % err))"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_c22b26ea","line":831,"range":{"start_line":831,"start_character":1,"end_line":831,"end_character":53},"updated":"2016-01-08 14:33:11.000000000","message":"Not covered with unit tests\n\nhttp://logs.openstack.org/19/259719/17/check/manila-coverage/ccb19df/cover/manila_share_drivers_huawei_v3_connection_py.html#n830","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                        home_port_id, home_port_type, ip, subnet))"},{"line_number":829,"context_line":"            except Exception as err:"},{"line_number":830,"context_line":"                if not vlan_exists:"},{"line_number":831,"context_line":"                    self.helper._delete_vlan(vlan_id)"},{"line_number":832,"context_line":"                raise exception.InvalidShare("},{"line_number":833,"context_line":"                    reason\u003d(_(\u0027Failed to create logical port. \u0027"},{"line_number":834,"context_line":"                              \u0027Reason: %s.\u0027) % err))"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_60001602","line":831,"range":{"start_line":831,"start_character":1,"end_line":831,"end_character":53},"in_reply_to":"fa69d971_c22b26ea","updated":"2016-01-09 03:57:31.000000000","message":"Same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8d5c3e979c43e4139ffdc3d10e0ca10a8c2fb3c4","unresolved":false,"context_lines":[{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":944,"context_line":"        if not server_details:"},{"line_number":945,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":946,"context_line":"            return"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"        logical_port_id \u003d server_details.get(\u0027logical_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_dbdf9e38","line":945,"range":{"start_line":945,"start_character":23,"end_line":945,"end_character":30},"updated":"2016-01-08 12:20:45.000000000","message":"Which server? It will be a problem when we delete several share servers at once.","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def teardown_server(self, server_details, security_services\u003dNone):"},{"line_number":944,"context_line":"        if not server_details:"},{"line_number":945,"context_line":"            LOG.debug(\u0027Server details are empty.\u0027)"},{"line_number":946,"context_line":"            return"},{"line_number":947,"context_line":""},{"line_number":948,"context_line":"        logical_port_id \u003d server_details.get(\u0027logical_port_id\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_4022b2a4","line":945,"range":{"start_line":945,"start_character":23,"end_line":945,"end_character":30},"in_reply_to":"fa69d971_dbdf9e38","updated":"2016-01-09 03:57:31.000000000","message":"There is no share_server_id in teardown_server\u0027s parameters. On the otherhand, _teardown_server in manila/share/manager.py print the share_server_id (https://github.com/openstack/manila/blob/master/manila/share/manager.py#L1353).","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0673fcf6677411f8ae2f60eaaed85a520b78583b","unresolved":false,"context_lines":[{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        # Delete logical_port."},{"line_number":954,"context_line":"        if logical_port_id:"},{"line_number":955,"context_line":"            logical_port_exists \u003d ("},{"line_number":956,"context_line":"                self.helper._check_logical_port_exists_by_id(logical_port_id))"},{"line_number":957,"context_line":"            if logical_port_exists:"},{"line_number":958,"context_line":"                self.helper._delete_logical_port(logical_port_id)"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        # Delete vlan."},{"line_number":961,"context_line":"        if vlan_id and vlan_id !\u003d \u00270\u0027:"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_02fdbe39","line":958,"range":{"start_line":955,"start_character":12,"end_line":958,"end_character":65},"updated":"2016-01-08 14:33:11.000000000","message":"No unit test coverage\n\nhttp://logs.openstack.org/19/259719/17/check/manila-coverage/ccb19df/cover/manila_share_drivers_huawei_v3_connection_py.html#n954","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        # Delete logical_port."},{"line_number":954,"context_line":"        if logical_port_id:"},{"line_number":955,"context_line":"            logical_port_exists \u003d ("},{"line_number":956,"context_line":"                self.helper._check_logical_port_exists_by_id(logical_port_id))"},{"line_number":957,"context_line":"            if logical_port_exists:"},{"line_number":958,"context_line":"                self.helper._delete_logical_port(logical_port_id)"},{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        # Delete vlan."},{"line_number":961,"context_line":"        if vlan_id and vlan_id !\u003d \u00270\u0027:"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_80050a12","line":958,"range":{"start_line":955,"start_character":12,"end_line":958,"end_character":65},"in_reply_to":"fa69d971_02fdbe39","updated":"2016-01-09 03:57:31.000000000","message":"Same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0673fcf6677411f8ae2f60eaaed85a520b78583b","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        # Delete vlan."},{"line_number":961,"context_line":"        if vlan_id and vlan_id !\u003d \u00270\u0027:"},{"line_number":962,"context_line":"            vlan_exists \u003d self.helper._check_vlan_exists_by_id(vlan_id)"},{"line_number":963,"context_line":"            if vlan_exists:"},{"line_number":964,"context_line":"                self.helper._delete_vlan(vlan_id)"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        if security_services:"},{"line_number":967,"context_line":"            active_directory, ldap \u003d ("}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_0294dedf","line":964,"range":{"start_line":962,"start_character":12,"end_line":964,"end_character":49},"updated":"2016-01-08 14:33:11.000000000","message":"same\n\nhttp://logs.openstack.org/19/259719/17/check/manila-coverage/ccb19df/cover/manila_share_drivers_huawei_v3_connection_py.html#n962","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":959,"context_line":""},{"line_number":960,"context_line":"        # Delete vlan."},{"line_number":961,"context_line":"        if vlan_id and vlan_id !\u003d \u00270\u0027:"},{"line_number":962,"context_line":"            vlan_exists \u003d self.helper._check_vlan_exists_by_id(vlan_id)"},{"line_number":963,"context_line":"            if vlan_exists:"},{"line_number":964,"context_line":"                self.helper._delete_vlan(vlan_id)"},{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        if security_services:"},{"line_number":967,"context_line":"            active_directory, ldap \u003d ("}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_20069e1c","line":964,"range":{"start_line":962,"start_character":12,"end_line":964,"end_character":49},"in_reply_to":"fa69d971_0294dedf","updated":"2016-01-09 03:57:31.000000000","message":"Same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0673fcf6677411f8ae2f60eaaed85a520b78583b","unresolved":false,"context_lines":[{"line_number":968,"context_line":"                self._get_valid_security_service(security_services))"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"            if ad_created and ad_created \u003d\u003d \u00271\u0027 and active_directory:"},{"line_number":971,"context_line":"                dns_ip \u003d active_directory[\u0027dns_ip\u0027]"},{"line_number":972,"context_line":"                user \u003d active_directory[\u0027user\u0027]"},{"line_number":973,"context_line":"                password \u003d active_directory[\u0027password\u0027]"},{"line_number":974,"context_line":"                domain \u003d active_directory[\u0027domain\u0027]"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"                # Check DNS server exists or not."},{"line_number":977,"context_line":"                ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":978,"context_line":"                if ip_address and ip_address[0] \u003d\u003d dns_ip:"},{"line_number":979,"context_line":"                    dns_ip_list \u003d []"},{"line_number":980,"context_line":"                    self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"                # Check AD config exists or not."},{"line_number":983,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":984,"context_line":"                if is_ad_exists and AD_domain \u003d\u003d domain:"},{"line_number":985,"context_line":"                    self.helper._delete_AD_config(user, password)"},{"line_number":986,"context_line":"                    self._check_AD_expected_status("},{"line_number":987,"context_line":"                        constants.STATUS_EXIT_DOMAIN)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"            if ldap_created and ldap_created \u003d\u003d \u00271\u0027 and ldap:"},{"line_number":990,"context_line":"                server \u003d ldap[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_42b1768e","line":987,"range":{"start_line":971,"start_character":3,"end_line":987,"end_character":53},"updated":"2016-01-08 14:33:11.000000000","message":"Not covered\n\nhttp://logs.openstack.org/19/259719/17/check/manila-coverage/ccb19df/cover/manila_share_drivers_huawei_v3_connection_py.html#n971","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":968,"context_line":"                self._get_valid_security_service(security_services))"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"            if ad_created and ad_created \u003d\u003d \u00271\u0027 and active_directory:"},{"line_number":971,"context_line":"                dns_ip \u003d active_directory[\u0027dns_ip\u0027]"},{"line_number":972,"context_line":"                user \u003d active_directory[\u0027user\u0027]"},{"line_number":973,"context_line":"                password \u003d active_directory[\u0027password\u0027]"},{"line_number":974,"context_line":"                domain \u003d active_directory[\u0027domain\u0027]"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"                # Check DNS server exists or not."},{"line_number":977,"context_line":"                ip_address \u003d self.helper._get_DNS_ip_address()"},{"line_number":978,"context_line":"                if ip_address and ip_address[0] \u003d\u003d dns_ip:"},{"line_number":979,"context_line":"                    dns_ip_list \u003d []"},{"line_number":980,"context_line":"                    self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"                # Check AD config exists or not."},{"line_number":983,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":984,"context_line":"                if is_ad_exists and AD_domain \u003d\u003d domain:"},{"line_number":985,"context_line":"                    self.helper._delete_AD_config(user, password)"},{"line_number":986,"context_line":"                    self._check_AD_expected_status("},{"line_number":987,"context_line":"                        constants.STATUS_EXIT_DOMAIN)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"            if ldap_created and ldap_created \u003d\u003d \u00271\u0027 and ldap:"},{"line_number":990,"context_line":"                server \u003d ldap[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_400b9224","line":987,"range":{"start_line":971,"start_character":3,"end_line":987,"end_character":53},"in_reply_to":"fa69d971_42b1768e","updated":"2016-01-09 03:57:31.000000000","message":"Same","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":856,"context_line":"            # Create vlan and logical_port."},{"line_number":857,"context_line":"            vlan_id, logical_port_id \u003d ("},{"line_number":858,"context_line":"                self._create_vlan_and_logical_port(vlan_tag, ip, subnet))"},{"line_number":859,"context_line":"        except Exception:"},{"line_number":860,"context_line":"            if ad_created:"},{"line_number":861,"context_line":"                dns_ip_list \u003d []"},{"line_number":862,"context_line":"                user \u003d active_directory[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_026bb71f","line":859,"range":{"start_line":859,"start_character":15,"end_line":859,"end_character":24},"updated":"2016-01-12 16:21:35.000000000","message":"Is this correct? Shouldn\u0027t you catch specific exceptions (or maybe ManilaException?)?","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":856,"context_line":"            # Create vlan and logical_port."},{"line_number":857,"context_line":"            vlan_id, logical_port_id \u003d ("},{"line_number":858,"context_line":"                self._create_vlan_and_logical_port(vlan_tag, ip, subnet))"},{"line_number":859,"context_line":"        except Exception:"},{"line_number":860,"context_line":"            if ad_created:"},{"line_number":861,"context_line":"                dns_ip_list \u003d []"},{"line_number":862,"context_line":"                user \u003d active_directory[\u0027user\u0027]"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_0835f1f5","line":859,"range":{"start_line":859,"start_character":15,"end_line":859,"end_character":24},"in_reply_to":"da6ed579_026bb71f","updated":"2016-01-13 08:09:27.000000000","message":"Here it catchs all exceptions, so \"except Exception\" is just ok. And our driver or manila project catch exception both like it. Thanks for your advice!","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":946,"context_line":"        try:"},{"line_number":947,"context_line":"            self.helper._add_AD_config(user, password, domain, system_name)"},{"line_number":948,"context_line":"            self._check_AD_expected_status(constants.STATUS_JOIN_DOMAIN)"},{"line_number":949,"context_line":"        except Exception as err:"},{"line_number":950,"context_line":"            if DNS_config:"},{"line_number":951,"context_line":"                dns_ip_list \u003d []"},{"line_number":952,"context_line":"                self.helper._set_DNS_ip_address(dns_ip_list)"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_223b5bed","line":949,"range":{"start_line":949,"start_character":15,"end_line":949,"end_character":24},"updated":"2016-01-12 16:21:35.000000000","message":"same here","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":946,"context_line":"        try:"},{"line_number":947,"context_line":"            self.helper._add_AD_config(user, password, domain, system_name)"},{"line_number":948,"context_line":"            self._check_AD_expected_status(constants.STATUS_JOIN_DOMAIN)"},{"line_number":949,"context_line":"        except Exception as err:"},{"line_number":950,"context_line":"            if DNS_config:"},{"line_number":951,"context_line":"                dns_ip_list \u003d []"},{"line_number":952,"context_line":"                self.helper._set_DNS_ip_address(dns_ip_list)"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_2830f500","line":949,"range":{"start_line":949,"start_character":15,"end_line":949,"end_character":24},"in_reply_to":"da6ed579_223b5bed","updated":"2016-01-13 08:09:27.000000000","message":"Same.","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":989,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"        # Set LDAP config."},{"line_number":992,"context_line":"        server_number \u003d len(server.split(\u0027,\u0027))"},{"line_number":993,"context_line":"        if server_number \u003d\u003d 1:"},{"line_number":994,"context_line":"            server \u003d server + \",,\""},{"line_number":995,"context_line":"        elif server_number \u003d\u003d 2:"},{"line_number":996,"context_line":"            server \u003d server + \",\""},{"line_number":997,"context_line":"        elif server_number \u003e 3:"},{"line_number":998,"context_line":"            raise exception.InvalidInput("},{"line_number":999,"context_line":"                reason\u003d_(\"Cannot support more than three LDAP servers.\"))"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        self.helper._add_LDAP_config(server, domain)"},{"line_number":1002,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_3db5becc","line":999,"range":{"start_line":992,"start_character":0,"end_line":999,"end_character":73},"updated":"2016-01-12 16:21:35.000000000","message":"server_number \u003d\u003d 3?","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":989,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"        # Set LDAP config."},{"line_number":992,"context_line":"        server_number \u003d len(server.split(\u0027,\u0027))"},{"line_number":993,"context_line":"        if server_number \u003d\u003d 1:"},{"line_number":994,"context_line":"            server \u003d server + \",,\""},{"line_number":995,"context_line":"        elif server_number \u003d\u003d 2:"},{"line_number":996,"context_line":"            server \u003d server + \",\""},{"line_number":997,"context_line":"        elif server_number \u003e 3:"},{"line_number":998,"context_line":"            raise exception.InvalidInput("},{"line_number":999,"context_line":"                reason\u003d_(\"Cannot support more than three LDAP servers.\"))"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        self.helper._add_LDAP_config(server, domain)"},{"line_number":1002,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_936ef6c7","line":999,"range":{"start_line":992,"start_character":0,"end_line":999,"end_character":73},"in_reply_to":"da6ed579_3db5becc","updated":"2016-01-13 08:09:27.000000000","message":"Because driver doesn\u0027t need to do anything when server_number \u003d\u003d 3. If add it just like:\n\nif server_number \u003d\u003d 1:\n    server \u003d server + \",,\"\nelif server_number \u003d\u003d 2:\n    server \u003d server + \",\"\nelif server_number \u003d\u003d 3:\n    server \u003d server\n\nSo, didn\u0027t add it. Thanks.","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"                logical_port_id \u003d ("},{"line_number":1030,"context_line":"                    self.helper._create_logical_port("},{"line_number":1031,"context_line":"                        home_port_id, home_port_type, ip, subnet))"},{"line_number":1032,"context_line":"            except Exception as err:"},{"line_number":1033,"context_line":"                if not vlan_exists:"},{"line_number":1034,"context_line":"                    self.helper._delete_vlan(vlan_id)"},{"line_number":1035,"context_line":"                raise exception.InvalidShare("}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_5d04327d","line":1032,"range":{"start_line":1032,"start_character":19,"end_line":1032,"end_character":29},"updated":"2016-01-12 16:21:35.000000000","message":"same","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"                logical_port_id \u003d ("},{"line_number":1030,"context_line":"                    self.helper._create_logical_port("},{"line_number":1031,"context_line":"                        home_port_id, home_port_type, ip, subnet))"},{"line_number":1032,"context_line":"            except Exception as err:"},{"line_number":1033,"context_line":"                if not vlan_exists:"},{"line_number":1034,"context_line":"                    self.helper._delete_vlan(vlan_id)"},{"line_number":1035,"context_line":"                raise exception.InvalidShare("}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_7364a2e4","line":1032,"range":{"start_line":1032,"start_character":19,"end_line":1032,"end_character":29},"in_reply_to":"da6ed579_5d04327d","updated":"2016-01-13 08:09:27.000000000","message":"Same","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"                    port_info.append(port)"},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"        eth_port, bond_port \u003d self._get_online_port(port_info)"},{"line_number":1054,"context_line":"        optimal_port, type \u003d self._get_least_vlan_port(eth_port, bond_port)"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        if not optimal_port:"},{"line_number":1057,"context_line":"            err_msg \u003d (_(\"Cannot find optimal port. port_info: %s.\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_dd02623e","line":1054,"range":{"start_line":1054,"start_character":22,"end_line":1054,"end_character":26},"updated":"2016-01-12 16:21:35.000000000","message":"type is a python built-in function. Please rename this variable","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"                    port_info.append(port)"},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"        eth_port, bond_port \u003d self._get_online_port(port_info)"},{"line_number":1054,"context_line":"        optimal_port, type \u003d self._get_least_vlan_port(eth_port, bond_port)"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"        if not optimal_port:"},{"line_number":1057,"context_line":"            err_msg \u003d (_(\"Cannot find optimal port. port_info: %s.\")"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_f39e52b7","line":1054,"range":{"start_line":1054,"start_character":22,"end_line":1054,"end_character":26},"in_reply_to":"da6ed579_dd02623e","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            LOG.error(err_msg)"},{"line_number":1060,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"        return optimal_port, type"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"    def _get_online_port(self, all_port_list):"},{"line_number":1065,"context_line":"        eth_port \u003d self.helper._get_all_eth_port()"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_9dfcea3f","line":1062,"range":{"start_line":1062,"start_character":29,"end_line":1062,"end_character":33},"updated":"2016-01-12 16:21:35.000000000","message":"same","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"            LOG.error(err_msg)"},{"line_number":1060,"context_line":"            raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"        return optimal_port, type"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"    def _get_online_port(self, all_port_list):"},{"line_number":1065,"context_line":"        eth_port \u003d self.helper._get_all_eth_port()"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_b3a8dadc","line":1062,"range":{"start_line":1062,"start_character":29,"end_line":1062,"end_character":33},"in_reply_to":"da6ed579_9dfcea3f","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"                    self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"                # Check AD config exists or not."},{"line_number":1186,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":1187,"context_line":"                if is_ad_exists and AD_domain \u003d\u003d domain:"},{"line_number":1188,"context_line":"                    self.helper._delete_AD_config(user, password)"},{"line_number":1189,"context_line":"                    self._check_AD_expected_status("}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_b8c53c5c","line":1186,"range":{"start_line":1186,"start_character":16,"end_line":1186,"end_character":28},"updated":"2016-01-12 16:21:35.000000000","message":"s/is_ad_exists/ad_exists","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"                    self.helper._set_DNS_ip_address(dns_ip_list)"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"                # Check AD config exists or not."},{"line_number":1186,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":1187,"context_line":"                if is_ad_exists and AD_domain \u003d\u003d domain:"},{"line_number":1188,"context_line":"                    self.helper._delete_AD_config(user, password)"},{"line_number":1189,"context_line":"                    self._check_AD_expected_status("}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_73ab42d7","line":1186,"range":{"start_line":1186,"start_character":16,"end_line":1186,"end_character":28},"in_reply_to":"da6ed579_b8c53c5c","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"                # Check AD config exists or not."},{"line_number":1186,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":1187,"context_line":"                if is_ad_exists and AD_domain \u003d\u003d domain:"},{"line_number":1188,"context_line":"                    self.helper._delete_AD_config(user, password)"},{"line_number":1189,"context_line":"                    self._check_AD_expected_status("},{"line_number":1190,"context_line":"                        constants.STATUS_EXIT_DOMAIN)"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_58a1a0a8","line":1187,"range":{"start_line":1187,"start_character":19,"end_line":1187,"end_character":31},"updated":"2016-01-12 16:21:35.000000000","message":"same","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"                # Check AD config exists or not."},{"line_number":1186,"context_line":"                is_ad_exists, AD_domain \u003d self.helper._get_AD_domain_name()"},{"line_number":1187,"context_line":"                if is_ad_exists and AD_domain \u003d\u003d domain:"},{"line_number":1188,"context_line":"                    self.helper._delete_AD_config(user, password)"},{"line_number":1189,"context_line":"                    self._check_AD_expected_status("},{"line_number":1190,"context_line":"                        constants.STATUS_EXIT_DOMAIN)"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_33b5ca30","line":1187,"range":{"start_line":1187,"start_character":19,"end_line":1187,"end_character":31},"in_reply_to":"da6ed579_58a1a0a8","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"                domain \u003d ldap[\u0027domain\u0027]"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"                # Check LDAP config exists or not."},{"line_number":1197,"context_line":"                is_ldap_exists, LDAP_domain \u003d ("},{"line_number":1198,"context_line":"                    self.helper._get_LDAP_domain_server())"},{"line_number":1199,"context_line":"                if is_ldap_exists:"},{"line_number":1200,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_f892d456","line":1197,"range":{"start_line":1197,"start_character":16,"end_line":1197,"end_character":30},"updated":"2016-01-12 16:21:35.000000000","message":"s/is_ldap_exists/ldap_exists","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"                domain \u003d ldap[\u0027domain\u0027]"},{"line_number":1195,"context_line":""},{"line_number":1196,"context_line":"                # Check LDAP config exists or not."},{"line_number":1197,"context_line":"                is_ldap_exists, LDAP_domain \u003d ("},{"line_number":1198,"context_line":"                    self.helper._get_LDAP_domain_server())"},{"line_number":1199,"context_line":"                if is_ldap_exists:"},{"line_number":1200,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_937cb673","line":1197,"range":{"start_line":1197,"start_character":16,"end_line":1197,"end_character":30},"in_reply_to":"da6ed579_f892d456","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"                # Check LDAP config exists or not."},{"line_number":1197,"context_line":"                is_ldap_exists, LDAP_domain \u003d ("},{"line_number":1198,"context_line":"                    self.helper._get_LDAP_domain_server())"},{"line_number":1199,"context_line":"                if is_ldap_exists:"},{"line_number":1200,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"},{"line_number":1201,"context_line":"                    if (LDAP_config[\u0027LDAPSERVER\u0027] \u003d\u003d server"},{"line_number":1202,"context_line":"                            and LDAP_config[\u0027BASEDN\u0027] \u003d\u003d domain):"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_989f185f","line":1199,"range":{"start_line":1199,"start_character":19,"end_line":1199,"end_character":33},"updated":"2016-01-12 16:21:35.000000000","message":"same","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"                # Check LDAP config exists or not."},{"line_number":1197,"context_line":"                is_ldap_exists, LDAP_domain \u003d ("},{"line_number":1198,"context_line":"                    self.helper._get_LDAP_domain_server())"},{"line_number":1199,"context_line":"                if is_ldap_exists:"},{"line_number":1200,"context_line":"                    LDAP_config \u003d self.helper._get_LDAP_config()"},{"line_number":1201,"context_line":"                    if (LDAP_config[\u0027LDAPSERVER\u0027] \u003d\u003d server"},{"line_number":1202,"context_line":"                            and LDAP_config[\u0027BASEDN\u0027] \u003d\u003d domain):"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_b37f7a65","line":1199,"range":{"start_line":1199,"start_character":19,"end_line":1199,"end_character":33},"in_reply_to":"da6ed579_989f185f","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"78fc411563a2e03c80dff875ebaed642d121c3de","unresolved":false,"context_lines":[{"line_number":856,"context_line":"            # Create vlan and logical_port."},{"line_number":857,"context_line":"            vlan_id, logical_port_id \u003d ("},{"line_number":858,"context_line":"                self._create_vlan_and_logical_port(vlan_tag, ip, subnet))"},{"line_number":859,"context_line":"        except Exception:"},{"line_number":860,"context_line":"            if ad_created:"},{"line_number":861,"context_line":"                dns_ip_list \u003d []"},{"line_number":862,"context_line":"                user \u003d active_directory[\u0027user\u0027]"},{"line_number":863,"context_line":"                password \u003d active_directory[\u0027password\u0027]"},{"line_number":864,"context_line":"                self.helper.set_DNS_ip_address(dns_ip_list)"},{"line_number":865,"context_line":"                self.helper.delete_AD_config(user, password)"},{"line_number":866,"context_line":"                self._check_AD_expected_status(constants.STATUS_EXIT_DOMAIN)"},{"line_number":867,"context_line":"            if ldap_created:"},{"line_number":868,"context_line":"                self.helper.delete_LDAP_config()"},{"line_number":869,"context_line":"            raise"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        return {"},{"line_number":872,"context_line":"            \u0027share_server_name\u0027: network_info[\u0027server_id\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"da6ed579_5065c6de","line":869,"range":{"start_line":859,"start_character":0,"end_line":869,"end_character":17},"updated":"2016-01-13 12:23:30.000000000","message":"I understand what you said on the previous review and I agree with it, but my main concern on this specific statement is that you raise this exception without treating it. I don\u0027t see much problem catching the superclass, but maybe you should raise a specific ManilaException instead of raising whichever exception you catch, right?","commit_id":"b3a255af44b8def077f26add3131a5bba58914fd"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"cd9e033f09ed9ea89e593ae2e75f960660a3afc0","unresolved":false,"context_lines":[{"line_number":856,"context_line":"            # Create vlan and logical_port."},{"line_number":857,"context_line":"            vlan_id, logical_port_id \u003d ("},{"line_number":858,"context_line":"                self._create_vlan_and_logical_port(vlan_tag, ip, subnet))"},{"line_number":859,"context_line":"        except Exception:"},{"line_number":860,"context_line":"            if ad_created:"},{"line_number":861,"context_line":"                dns_ip_list \u003d []"},{"line_number":862,"context_line":"                user \u003d active_directory[\u0027user\u0027]"},{"line_number":863,"context_line":"                password \u003d active_directory[\u0027password\u0027]"},{"line_number":864,"context_line":"                self.helper.set_DNS_ip_address(dns_ip_list)"},{"line_number":865,"context_line":"                self.helper.delete_AD_config(user, password)"},{"line_number":866,"context_line":"                self._check_AD_expected_status(constants.STATUS_EXIT_DOMAIN)"},{"line_number":867,"context_line":"            if ldap_created:"},{"line_number":868,"context_line":"                self.helper.delete_LDAP_config()"},{"line_number":869,"context_line":"            raise"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        return {"},{"line_number":872,"context_line":"            \u0027share_server_name\u0027: network_info[\u0027server_id\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"da6ed579_b8f08092","line":869,"range":{"start_line":859,"start_character":0,"end_line":869,"end_character":17},"in_reply_to":"da6ed579_5065c6de","updated":"2016-01-14 01:31:12.000000000","message":"Got it, it\u0027s fixed in patch 25. Thanks!","commit_id":"b3a255af44b8def077f26add3131a5bba58914fd"}],"manila/share/drivers/huawei/v3/helper.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":478,"context_line":"            result \u003d self.call(url, data, \"POST\")"},{"line_number":479,"context_line":"            if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d 0:"},{"line_number":480,"context_line":"                return True"},{"line_number":481,"context_line":"            if result[\u0027error\u0027][\u0027code\u0027] !\u003d constants.ERROR_USER_OR_GROUP_NOT_EXIST:"},{"line_number":482,"context_line":"                self._assert_rest_result(result, error_msg)"},{"line_number":483,"context_line":"            return False"},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fd1ecc6e","line":481,"range":{"start_line":481,"start_character":12,"end_line":481,"end_character":14},"updated":"2015-12-20 03:17:59.000000000","message":"elif","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            return False"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        if \u0027\\\\\u0027 not in access_to:"},{"line_number":486,"context_line":"            #first, try to add user access"},{"line_number":487,"context_line":"            LOG.debug(\u0027Try to add user access\u0027)"},{"line_number":488,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":489,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_9d0f8838","line":486,"range":{"start_line":486,"start_character":12,"end_line":486,"end_character":18},"updated":"2015-12-20 03:17:59.000000000","message":"Add a space after #.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":483,"context_line":"            return False"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        if \u0027\\\\\u0027 not in access_to:"},{"line_number":486,"context_line":"            #first, try to add user access"},{"line_number":487,"context_line":"            LOG.debug(\u0027Try to add user access\u0027)"},{"line_number":488,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":489,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fd500c34","line":486,"range":{"start_line":486,"start_character":12,"end_line":486,"end_character":18},"updated":"2015-12-20 03:17:59.000000000","message":"Add a space after #.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            LOG.debug(\u0027Try to add user access\u0027)"},{"line_number":488,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":489,"context_line":"                return"},{"line_number":490,"context_line":"            #second, if add user access failed,"},{"line_number":491,"context_line":"            # try to add group access"},{"line_number":492,"context_line":"            LOG.debug(\u0027Try to add group access\u0027)"},{"line_number":493,"context_line":"            #group name start with @"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_dd32f00f","line":490,"range":{"start_line":490,"start_character":12,"end_line":490,"end_character":19},"updated":"2015-12-20 03:17:59.000000000","message":"same","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            #second, if add user access failed,"},{"line_number":491,"context_line":"            # try to add group access"},{"line_number":492,"context_line":"            LOG.debug(\u0027Try to add group access\u0027)"},{"line_number":493,"context_line":"            #group name start with @"},{"line_number":494,"context_line":"            if send_rest(\u0027@\u0027+access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_9d38e8ef","line":493,"range":{"start_line":493,"start_character":12,"end_line":493,"end_character":18},"updated":"2015-12-20 03:17:59.000000000","message":"same","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            # try to add group access"},{"line_number":492,"context_line":"            LOG.debug(\u0027Try to add group access\u0027)"},{"line_number":493,"context_line":"            #group name start with @"},{"line_number":494,"context_line":"            if send_rest(\u0027@\u0027+access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"        else:"},{"line_number":497,"context_line":"            LOG.debug(\u0027Try to add domain user access\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_5d27e0c9","line":494,"range":{"start_line":494,"start_character":25,"end_line":494,"end_character":38},"updated":"2015-12-20 03:17:59.000000000","message":"change \u0027@\u0027+access_to  to \u0027@\u0027 + access_to","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            if send_rest(\u0027@\u0027+access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"        else:"},{"line_number":497,"context_line":"            LOG.debug(\u0027Try to add domain user access\u0027)"},{"line_number":498,"context_line":"            if send_rest(access_to, domain_type[\u0027ad\u0027]):"},{"line_number":499,"context_line":"                return"},{"line_number":500,"context_line":"            #if add domain user access failed,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_3d2a1491","line":497,"range":{"start_line":497,"start_character":21,"end_line":497,"end_character":54},"updated":"2015-12-20 03:17:59.000000000","message":"It is better to add more details about domain.","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            LOG.debug(\u0027Try to add domain user access\u0027)"},{"line_number":498,"context_line":"            if send_rest(access_to, domain_type[\u0027ad\u0027]):"},{"line_number":499,"context_line":"                return"},{"line_number":500,"context_line":"            #if add domain user access failed,"},{"line_number":501,"context_line":"            # try to add domain group access"},{"line_number":502,"context_line":"            LOG.debug(\u0027Try to add domain group access\u0027)"},{"line_number":503,"context_line":"            #group name start with @"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_1d2dd8a7","line":500,"range":{"start_line":500,"start_character":12,"end_line":500,"end_character":15},"updated":"2015-12-20 03:17:59.000000000","message":"same","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"370d131d664e0918df02eefde26cb5575df39637","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            #if add domain user access failed,"},{"line_number":501,"context_line":"            # try to add domain group access"},{"line_number":502,"context_line":"            LOG.debug(\u0027Try to add domain group access\u0027)"},{"line_number":503,"context_line":"            #group name start with @"},{"line_number":504,"context_line":"            if send_rest(\u0027@\u0027+access_to, domain_type[\u0027ad\u0027]):"},{"line_number":505,"context_line":"                return"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_7d241cc4","line":503,"range":{"start_line":503,"start_character":12,"end_line":503,"end_character":18},"updated":"2015-12-20 03:17:59.000000000","message":"same","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"        return all_vlan"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def _check_vlan_exist(self, port_id, vlan_tag):"},{"line_number":825,"context_line":"        url \u003d \"/vlan\""},{"line_number":826,"context_line":"        result \u003d self.call(url, None, \u0027GET\u0027)"},{"line_number":827,"context_line":"        self._assert_rest_result(result, _(\u0027Get vlan error.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_9b123056","line":824,"range":{"start_line":824,"start_character":8,"end_line":824,"end_character":25},"updated":"2015-12-20 07:29:09.000000000","message":"s/_check_vlan_exist/_check_vlan_exists","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":861,"context_line":"        result \u003d self.call(url, None, \u0027DELETE\u0027)"},{"line_number":862,"context_line":"        if result[\u0027error\u0027][\u0027code\u0027] \u003d\u003d constants.ERROR_LOGICAL_PORT_EXIST:"},{"line_number":863,"context_line":"            LOG.warning(_LW(\u0027Can not delete vlan because there is \u0027"},{"line_number":864,"context_line":"                            \u0027logical port on vlan.\u0027))"},{"line_number":865,"context_line":"            return"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        self._assert_rest_result(result, _(\u0027Delete vlan error.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fb27b4b3","line":864,"range":{"start_line":864,"start_character":29,"end_line":864,"end_character":36},"updated":"2015-12-20 07:29:09.000000000","message":"a logical port","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        self._assert_rest_result(result, _(\u0027Delete vlan error.\u0027))"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def _check_logic_port_exist(self, vlan_id, ip, subnet):"},{"line_number":870,"context_line":"        url \u003d \"/LIF\""},{"line_number":871,"context_line":"        result \u003d self.call(url, None, \u0027GET\u0027)"},{"line_number":872,"context_line":"        self._assert_rest_result(result, _(\u0027Get logic port error.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_db22f8a2","line":869,"range":{"start_line":869,"start_character":8,"end_line":869,"end_character":31},"updated":"2015-12-20 07:29:09.000000000","message":"s/_check_logic_port_exist/_check_logical_port_exists","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                    return True, item[\u0027ID\u0027]"},{"line_number":881,"context_line":"        return False, None"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def _activate_logic_port(self, logic_port_id):"},{"line_number":884,"context_line":"        url \u003d \"/LIF/\" + logic_port_id"},{"line_number":885,"context_line":"        data \u003d jsonutils.dumps({\"OPERATIONALSTATUS\": \"true\"})"},{"line_number":886,"context_line":"        result \u003d self.call(url, data, \u0027PUT\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_7b3c24c8","line":883,"range":{"start_line":883,"start_character":8,"end_line":883,"end_character":28},"updated":"2015-12-20 07:29:09.000000000","message":"s/_activate_logic_port/_activate_logical_port","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":886,"context_line":"        result \u003d self.call(url, data, \u0027PUT\u0027)"},{"line_number":887,"context_line":"        self._assert_rest_result(result, _(\u0027Activate logic port error.\u0027))"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    def _create_logic_port(self, vlan_id, ip, subnet):"},{"line_number":890,"context_line":"        url \u003d \"/LIF\""},{"line_number":891,"context_line":"        info \u003d {"},{"line_number":892,"context_line":"            \"ADDRESSFAMILY\": 0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_9b39d0d9","line":889,"range":{"start_line":889,"start_character":8,"end_line":889,"end_character":26},"updated":"2015-12-20 07:29:09.000000000","message":"s/_create_logic_port/_create_logical_port","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"86e57538fb3e898cebee517830e5093868051ca7","unresolved":false,"context_lines":[{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        return None"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"    def _check_LDAP_config_exist(self):"},{"line_number":1033,"context_line":"        result \u003d self._get_LDAP_config()"},{"line_number":1034,"context_line":"        if result and (result[\u0027BASEDN\u0027] or result[\u0027LDAPSERVER\u0027]):"},{"line_number":1035,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_5b2fe887","line":1032,"range":{"start_line":1032,"start_character":27,"end_line":1032,"end_character":32},"updated":"2015-12-20 07:29:09.000000000","message":"exists","commit_id":"aa63b50661f113f67393092ebb3d0be5b8c6639c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f8d8a973d771051ab37c6ecc1afe5121bae7250","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        self._assert_rest_result(result, \u0027Get access id by share error!\u0027)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        for item in result.get(\u0027data\u0027, []):"},{"line_number":435,"context_line":"            if (access_to \u003d\u003d item[\u0027NAME\u0027]"},{"line_number":436,"context_line":"                    or \u0027@\u0027 + access_to \u003d\u003d item[\u0027NAME\u0027]):"},{"line_number":437,"context_line":"                return item[\u0027ID\u0027]"},{"line_number":438,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_86ef141d","line":435,"range":{"start_line":435,"start_character":25,"end_line":435,"end_character":26},"updated":"2015-12-21 14:26:41.000000000","message":"if item[\u0027NAME\u0027] in (access_to, \u0027@\u0027 + access_to):","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        self._assert_rest_result(result, \u0027Get access id by share error!\u0027)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"        for item in result.get(\u0027data\u0027, []):"},{"line_number":435,"context_line":"            if (access_to \u003d\u003d item[\u0027NAME\u0027]"},{"line_number":436,"context_line":"                    or \u0027@\u0027 + access_to \u003d\u003d item[\u0027NAME\u0027]):"},{"line_number":437,"context_line":"                return item[\u0027ID\u0027]"},{"line_number":438,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_9fd420ec","line":435,"range":{"start_line":435,"start_character":25,"end_line":435,"end_character":26},"in_reply_to":"3a7e1126_86ef141d","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f8d8a973d771051ab37c6ecc1afe5121bae7250","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":443,"context_line":"            self._allow_nfs_access_rest(share_id, access_to, access_level)"},{"line_number":444,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":445,"context_line":"            self._allow_cifs_access_rest(share_id, access_to, access_level)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _allow_nfs_access_rest(self, share_id, access_to, access_level):"},{"line_number":448,"context_line":"        url \u003d \"/NFS_SHARE_AUTH_CLIENT\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_26c980ac","line":445,"range":{"start_line":445,"start_character":17,"end_line":445,"end_character":40},"updated":"2015-12-21 14:26:41.000000000","message":"Better to have \"else\" clause for all unexpected cases.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":443,"context_line":"            self._allow_nfs_access_rest(share_id, access_to, access_level)"},{"line_number":444,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":445,"context_line":"            self._allow_cifs_access_rest(share_id, access_to, access_level)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    def _allow_nfs_access_rest(self, share_id, access_to, access_level):"},{"line_number":448,"context_line":"        url \u003d \"/NFS_SHARE_AUTH_CLIENT\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_bfcf9c54","line":445,"range":{"start_line":445,"start_character":17,"end_line":445,"end_character":40},"in_reply_to":"3a7e1126_26c980ac","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"4dedf8d50cc62cc3a51d3a67f569273594391ef1","unresolved":false,"context_lines":[{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        return None"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"    def _check_AD_config_exists(self):"},{"line_number":1011,"context_line":"        result \u003d self._get_AD_config()"},{"line_number":1012,"context_line":"        if result and result[\u0027DOMAINSTATUS\u0027] \u003d\u003d \u00271\u0027:"},{"line_number":1013,"context_line":"            return True, result[\u0027FULLDOMAINNAME\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_58ad3f87","line":1010,"updated":"2015-12-30 10:02:29.000000000","message":"for me this naming is a bit confusing. If it\u0027s only \"checks\" why does it return anything else than a bool?","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"4318d269bc0d39d79ecdf3af1b28d219039b125d","unresolved":false,"context_lines":[{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        return None"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"    def _check_AD_config_exists(self):"},{"line_number":1011,"context_line":"        result \u003d self._get_AD_config()"},{"line_number":1012,"context_line":"        if result and result[\u0027DOMAINSTATUS\u0027] \u003d\u003d \u00271\u0027:"},{"line_number":1013,"context_line":"            return True, result[\u0027FULLDOMAINNAME\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_6e09352c","line":1010,"in_reply_to":"fa69d971_58ad3f87","updated":"2015-12-31 10:01:31.000000000","message":"Done","commit_id":"0e0dccbf54ead411db4d320e0722092c57bf553f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        if \u0027\\\\\u0027 not in access_to:"},{"line_number":492,"context_line":"            # First, try to add user access."},{"line_number":493,"context_line":"            LOG.debug(\u0027Try to add user access.\u0027)"},{"line_number":494,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"            # Second, if add user access failed,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_50f02091","line":493,"range":{"start_line":493,"start_character":23,"end_line":493,"end_character":45},"updated":"2016-01-05 16:15:13.000000000","message":"It is not obvious what is being said. Add where? What level of access?","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        if \u0027\\\\\u0027 not in access_to:"},{"line_number":492,"context_line":"            # First, try to add user access."},{"line_number":493,"context_line":"            LOG.debug(\u0027Try to add user access.\u0027)"},{"line_number":494,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"            # Second, if add user access failed,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_1615a4e3","line":493,"range":{"start_line":493,"start_character":23,"end_line":493,"end_character":45},"in_reply_to":"fa69d971_50f02091","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            LOG.debug(\u0027Try to add user access.\u0027)"},{"line_number":494,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"            # Second, if add user access failed,"},{"line_number":497,"context_line":"            # try to add group access."},{"line_number":498,"context_line":"            LOG.debug(\u0027Try to add group access.\u0027)"},{"line_number":499,"context_line":"            # Group name start with @."},{"line_number":500,"context_line":"            if send_rest(\u0027@\u0027 + access_to, domain_type[\u0027local\u0027]):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_d0097085","line":497,"range":{"start_line":496,"start_character":14,"end_line":497,"end_character":38},"updated":"2016-01-05 16:15:13.000000000","message":"This should be said in logs - we failed with user, try group.","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            LOG.debug(\u0027Try to add user access.\u0027)"},{"line_number":494,"context_line":"            if send_rest(access_to, domain_type[\u0027local\u0027]):"},{"line_number":495,"context_line":"                return"},{"line_number":496,"context_line":"            # Second, if add user access failed,"},{"line_number":497,"context_line":"            # try to add group access."},{"line_number":498,"context_line":"            LOG.debug(\u0027Try to add group access.\u0027)"},{"line_number":499,"context_line":"            # Group name start with @."},{"line_number":500,"context_line":"            if send_rest(\u0027@\u0027 + access_to, domain_type[\u0027local\u0027]):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_b6d61826","line":497,"range":{"start_line":496,"start_character":14,"end_line":497,"end_character":38},"in_reply_to":"fa69d971_d0097085","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if send_rest(\u0027@\u0027 + access_to, domain_type[\u0027local\u0027]):"},{"line_number":501,"context_line":"                return"},{"line_number":502,"context_line":"        else:"},{"line_number":503,"context_line":"            LOG.debug(\u0027Try to add domain user access.\u0027)"},{"line_number":504,"context_line":"            if send_rest(access_to, domain_type[\u0027ad\u0027]):"},{"line_number":505,"context_line":"                return"},{"line_number":506,"context_line":"            # If add domain user access failed,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_b025dc09","line":503,"updated":"2016-01-05 16:15:13.000000000","message":"ditto","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            if send_rest(\u0027@\u0027 + access_to, domain_type[\u0027local\u0027]):"},{"line_number":501,"context_line":"                return"},{"line_number":502,"context_line":"        else:"},{"line_number":503,"context_line":"            LOG.debug(\u0027Try to add domain user access.\u0027)"},{"line_number":504,"context_line":"            if send_rest(access_to, domain_type[\u0027ad\u0027]):"},{"line_number":505,"context_line":"                return"},{"line_number":506,"context_line":"            # If add domain user access failed,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_d6d94c58","line":503,"in_reply_to":"fa69d971_b025dc09","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6366f2f271fcb716de773093fc4db2b40044cf9","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                return"},{"line_number":506,"context_line":"            # If add domain user access failed,"},{"line_number":507,"context_line":"            # try to add domain group access."},{"line_number":508,"context_line":"            LOG.debug(\u0027Try to add domain group access.\u0027)"},{"line_number":509,"context_line":"            # Group name start with @"},{"line_number":510,"context_line":"            if send_rest(\u0027@\u0027 + access_to, domain_type[\u0027ad\u0027]):"},{"line_number":511,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_107b88f6","line":508,"updated":"2016-01-05 16:15:13.000000000","message":"ditto","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"642cd6d276f96d7bd7902c0a02f283e3be723721","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                return"},{"line_number":506,"context_line":"            # If add domain user access failed,"},{"line_number":507,"context_line":"            # try to add domain group access."},{"line_number":508,"context_line":"            LOG.debug(\u0027Try to add domain group access.\u0027)"},{"line_number":509,"context_line":"            # Group name start with @"},{"line_number":510,"context_line":"            if send_rest(\u0027@\u0027 + access_to, domain_type[\u0027ad\u0027]):"},{"line_number":511,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_76dc2046","line":508,"in_reply_to":"fa69d971_107b88f6","updated":"2016-01-06 07:10:53.000000000","message":"Done","commit_id":"4e7a4959cb82fe0c9366bc19740e9e38fe73dc34"},{"author":{"_account_id":17444,"name":"Jay.Shen","email":"shenhong09@huawei.com","username":"Jay.Shen"},"change_message_id":"d3959124ebaac82b17f70a05f2f9f4efb476ede7","unresolved":false,"context_lines":[{"line_number":882,"context_line":"        result \u003d self.call(url, None, \u0027GET\u0027)"},{"line_number":883,"context_line":"        self._assert_rest_result(result, _(\u0027Get logical port error.\u0027))"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if \"data\" in result:"},{"line_number":886,"context_line":"            for item in result[\u0027data\u0027]:"},{"line_number":887,"context_line":"                if (home_port_id \u003d\u003d item[\u0027HOMEPORTID\u0027]"},{"line_number":888,"context_line":"                        and ip \u003d\u003d item[\u0027IPV4ADDR\u0027]"},{"line_number":889,"context_line":"                        and subnet \u003d\u003d item[\u0027IPV4MASK\u0027]):"},{"line_number":890,"context_line":"                    if item[\u0027OPERATIONALSTATUS\u0027] !\u003d \u0027true\u0027:"},{"line_number":891,"context_line":"                        self._activate_logical_port(item[\u0027ID\u0027])"},{"line_number":892,"context_line":"                    return True, item[\u0027ID\u0027]"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"        return False, None"},{"line_number":895,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa69d971_9f1e475e","line":892,"range":{"start_line":885,"start_character":8,"end_line":892,"end_character":43},"updated":"2016-01-07 12:42:18.000000000","message":"The function depth \n\nmay by like this is better:\n\nif \"data\" not in result:\n    return False, None\nfor item in result[\u0027data\u0027]:\n    if (home_port_id \u003d\u003d item[\u0027HOMEPORTID\u0027]\n        and ip \u003d\u003d item[\u0027IPV4ADDR\u0027]\n        and subnet \u003d\u003d item[\u0027IPV4MASK\u0027]):\n       if item[\u0027OPERATIONALSTATUS\u0027] !\u003d \u0027true\u0027:\n           self._activate_logical_port(item[\u0027ID\u0027])\n       return True, item[\u0027ID\u0027]","commit_id":"36e86610fdc6f76a371c5fefb8f04a067f97095b"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":883,"context_line":"    def _get_all_vlan(self):"},{"line_number":884,"context_line":"        url \u003d \"/vlan\""},{"line_number":885,"context_line":"        result \u003d self.call(url, None, \u0027GET\u0027)"},{"line_number":886,"context_line":"        self._assert_rest_result(result, _(\u0027Get vlan error.\u0027))"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        all_vlan \u003d {}"},{"line_number":889,"context_line":"        if \"data\" in result:"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_b84bfcaf","line":886,"range":{"start_line":886,"start_character":44,"end_line":886,"end_character":59},"updated":"2016-01-12 16:21:35.000000000","message":"s/Get vlan error./Get all vlan error.","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":883,"context_line":"    def _get_all_vlan(self):"},{"line_number":884,"context_line":"        url \u003d \"/vlan\""},{"line_number":885,"context_line":"        result \u003d self.call(url, None, \u0027GET\u0027)"},{"line_number":886,"context_line":"        self._assert_rest_result(result, _(\u0027Get vlan error.\u0027))"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        all_vlan \u003d {}"},{"line_number":889,"context_line":"        if \"data\" in result:"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_08cbb11f","line":886,"range":{"start_line":886,"start_character":44,"end_line":886,"end_character":59},"in_reply_to":"da6ed579_b84bfcaf","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":918,"context_line":"    def _check_vlan_exists_by_id(self, vlan_id):"},{"line_number":919,"context_line":"        all_vlan \u003d self._get_all_vlan()"},{"line_number":920,"context_line":"        if all_vlan:"},{"line_number":921,"context_line":"            for vlan in all_vlan:"},{"line_number":922,"context_line":"                if vlan[\u0027ID\u0027] \u003d\u003d vlan_id:"},{"line_number":923,"context_line":"                    return True"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        return False"},{"line_number":926,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_73d84754","line":923,"range":{"start_line":921,"start_character":0,"end_line":923,"end_character":31},"updated":"2016-01-12 16:21:35.000000000","message":"All these lines of code could be replaced for:\n\nany(vlan[\u0027ID\u0027] \u003d\u003d vlan_id for vlan in all_vlan)","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":918,"context_line":"    def _check_vlan_exists_by_id(self, vlan_id):"},{"line_number":919,"context_line":"        all_vlan \u003d self._get_all_vlan()"},{"line_number":920,"context_line":"        if all_vlan:"},{"line_number":921,"context_line":"            for vlan in all_vlan:"},{"line_number":922,"context_line":"                if vlan[\u0027ID\u0027] \u003d\u003d vlan_id:"},{"line_number":923,"context_line":"                    return True"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        return False"},{"line_number":926,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_c8d4b9be","line":923,"range":{"start_line":921,"start_character":0,"end_line":923,"end_character":31},"in_reply_to":"da6ed579_73d84754","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"7dfafe3d8166c3f0b41cfede18a0182ab38d3a87","unresolved":false,"context_lines":[{"line_number":982,"context_line":"    def _check_logical_port_exists_by_id(self, logical_port_id):"},{"line_number":983,"context_line":"        all_logical_port \u003d self._get_all_logical_port()"},{"line_number":984,"context_line":"        if all_logical_port:"},{"line_number":985,"context_line":"            for port in all_logical_port:"},{"line_number":986,"context_line":"                if port[\u0027ID\u0027] \u003d\u003d logical_port_id:"},{"line_number":987,"context_line":"                    return True"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        return False"},{"line_number":990,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_33e2cf04","line":987,"range":{"start_line":985,"start_character":0,"end_line":987,"end_character":31},"updated":"2016-01-12 16:21:35.000000000","message":"same","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"a2e0cb43e7b4e3808444bf1d495141e15dfeca48","unresolved":false,"context_lines":[{"line_number":982,"context_line":"    def _check_logical_port_exists_by_id(self, logical_port_id):"},{"line_number":983,"context_line":"        all_logical_port \u003d self._get_all_logical_port()"},{"line_number":984,"context_line":"        if all_logical_port:"},{"line_number":985,"context_line":"            for port in all_logical_port:"},{"line_number":986,"context_line":"                if port[\u0027ID\u0027] \u003d\u003d logical_port_id:"},{"line_number":987,"context_line":"                    return True"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        return False"},{"line_number":990,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"da6ed579_68dcade4","line":987,"range":{"start_line":985,"start_character":0,"end_line":987,"end_character":31},"in_reply_to":"da6ed579_33e2cf04","updated":"2016-01-13 08:09:27.000000000","message":"Done","commit_id":"182d87b9a81ecd54fadd1638b093050ec42a40f3"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f8d8a973d771051ab37c6ecc1afe5121bae7250","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                          self.share_nfs,"},{"line_number":1681,"context_line":"                          self.share_server)"},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"    def dec_driver_handles_share_servers(func):"},{"line_number":1684,"context_line":"        def wrapper(*args, **kw):"},{"line_number":1685,"context_line":"            self \u003d args[0]"},{"line_number":1686,"context_line":"            self.configuration.driver_handles_share_servers \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_e6237854","line":1683,"range":{"start_line":1683,"start_character":8,"end_line":1683,"end_character":40},"updated":"2015-12-21 14:26:41.000000000","message":"Please, define decorator as standalone function.","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ddba5c97097e31c941b9a6b5f73463ac32771e2c","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"                          self.share_nfs,"},{"line_number":1681,"context_line":"                          self.share_server)"},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"    def dec_driver_handles_share_servers(func):"},{"line_number":1684,"context_line":"        def wrapper(*args, **kw):"},{"line_number":1685,"context_line":"            self \u003d args[0]"},{"line_number":1686,"context_line":"            self.configuration.driver_handles_share_servers \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_f5d223d0","line":1683,"range":{"start_line":1683,"start_character":8,"end_line":1683,"end_character":40},"in_reply_to":"3a7e1126_e6237854","updated":"2015-12-22 02:58:35.000000000","message":"Done","commit_id":"7ac45ac05bee483975fc8795ebfc4c2cbfad03d0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"88eb3f0d1a691e34aa2ec3fc0cd6e359716419c1","unresolved":false,"context_lines":[{"line_number":2147,"context_line":"                               \u0027call\u0027) as mock_call:"},{"line_number":2148,"context_line":"            mock_call.side_effect \u003d fake_teardown_call"},{"line_number":2149,"context_line":"            self.driver._teardown_server(server_details, security_services)"},{"line_number":2150,"context_line":"            self.assertEqual(True, self.logical_port_deleted)"},{"line_number":2151,"context_line":"            self.assertEqual(True, self.vlan_deleted)"},{"line_number":2152,"context_line":"            self.assertEqual(True, self.ad_deleted)"},{"line_number":2153,"context_line":"            self.assertEqual(True, self.ldap_deleted)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_03bf00fc","line":2150,"updated":"2016-01-08 15:04:59.000000000","message":"Use assertTrue.  Same for all below.","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"405a96658baf70e8aed3f2b117cc19cc5cf2e18e","unresolved":false,"context_lines":[{"line_number":2147,"context_line":"                               \u0027call\u0027) as mock_call:"},{"line_number":2148,"context_line":"            mock_call.side_effect \u003d fake_teardown_call"},{"line_number":2149,"context_line":"            self.driver._teardown_server(server_details, security_services)"},{"line_number":2150,"context_line":"            self.assertEqual(True, self.logical_port_deleted)"},{"line_number":2151,"context_line":"            self.assertEqual(True, self.vlan_deleted)"},{"line_number":2152,"context_line":"            self.assertEqual(True, self.ad_deleted)"},{"line_number":2153,"context_line":"            self.assertEqual(True, self.ldap_deleted)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_1d38a7ed","line":2150,"in_reply_to":"fa69d971_03bf00fc","updated":"2016-01-09 03:57:31.000000000","message":"Done","commit_id":"5ceb8fa532da3b33e443c9d0a33a6900eacd0753"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"06e85263a96bcfed1ada5a2add04fa2664aee088","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self.fake_conf_file)"},{"line_number":135,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":136,"context_line":"        func(*args, **kw)"},{"line_number":137,"context_line":"        self.configuration.driver_handles_share_servers \u003d False"},{"line_number":138,"context_line":"    return wrapper"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_318d6b7c","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":63},"updated":"2016-01-11 14:23:02.000000000","message":"Line 137 is redundant, each new test will have data set up by new run of \"setUp\" method.\n\nAlso, correct approach for each decorator to return results of executed func instead of hiding it.","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"45e435ca23c7cdd453cc63b98d6975dce9fff94d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self.fake_conf_file)"},{"line_number":135,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":136,"context_line":"        func(*args, **kw)"},{"line_number":137,"context_line":"        self.configuration.driver_handles_share_servers \u003d False"},{"line_number":138,"context_line":"    return wrapper"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_0a410963","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":63},"in_reply_to":"fa69d971_318d6b7c","updated":"2016-01-11 15:55:55.000000000","message":"Done","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"06e85263a96bcfed1ada5a2add04fa2664aee088","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                         mock.Mock(return_value\u003dshare_type))"},{"line_number":1702,"context_line":"        location \u003d self.driver.create_share(self._context, self.share_nfs,"},{"line_number":1703,"context_line":"                                            fake_share_server)"},{"line_number":1704,"context_line":"        self.assertEqual((self.fake_network_allocations[0][\u0027ip_address\u0027]"},{"line_number":1705,"context_line":"                         + \":/share_fake_uuid\"), location)"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    @dec_driver_handles_share_servers"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_11a707be","line":1704,"range":{"start_line":1704,"start_character":8,"end_line":1704,"end_character":72},"updated":"2016-01-11 14:23:02.000000000","message":"More readable:\n\nself.assertEqual(\n    self.fake_network_allocations[0][\u0027ip_address\u0027] + \":/share_fake_uuid\",\n    location,\n)\n\nSame in other places.","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"45e435ca23c7cdd453cc63b98d6975dce9fff94d","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"                         mock.Mock(return_value\u003dshare_type))"},{"line_number":1702,"context_line":"        location \u003d self.driver.create_share(self._context, self.share_nfs,"},{"line_number":1703,"context_line":"                                            fake_share_server)"},{"line_number":1704,"context_line":"        self.assertEqual((self.fake_network_allocations[0][\u0027ip_address\u0027]"},{"line_number":1705,"context_line":"                         + \":/share_fake_uuid\"), location)"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    @dec_driver_handles_share_servers"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_2d22e7a3","line":1704,"range":{"start_line":1704,"start_character":8,"end_line":1704,"end_character":72},"in_reply_to":"fa69d971_11a707be","updated":"2016-01-11 15:55:55.000000000","message":"\"    self.fake_network_allocations[0][\u0027ip_address\u0027] + \":/share_fake_uuid\",\" is more than 80 characters, so keep this way.","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"06e85263a96bcfed1ada5a2add04fa2664aee088","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"    def test_setup_server_with_ad_domain_success(self):"},{"line_number":1924,"context_line":"        fake_network_info \u003d self.fake_network_info"},{"line_number":1925,"context_line":"        fake_network_info[\u0027security_services\u0027] \u003d [self.fake_active_directory]"},{"line_number":1926,"context_line":"        self.mock_object(self.driver.plugin.helper,"},{"line_number":1927,"context_line":"                         \"_get_AD_config\","},{"line_number":1928,"context_line":"                         mock.Mock("},{"line_number":1929,"context_line":"                             side_effect\u003d[None,"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_d1b16fe1","line":1926,"range":{"start_line":1926,"start_character":8,"end_line":1926,"end_character":51},"updated":"2016-01-11 14:23:02.000000000","message":"Would be safer to verify that mocked stuff were called indeed.","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"45e435ca23c7cdd453cc63b98d6975dce9fff94d","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"    def test_setup_server_with_ad_domain_success(self):"},{"line_number":1924,"context_line":"        fake_network_info \u003d self.fake_network_info"},{"line_number":1925,"context_line":"        fake_network_info[\u0027security_services\u0027] \u003d [self.fake_active_directory]"},{"line_number":1926,"context_line":"        self.mock_object(self.driver.plugin.helper,"},{"line_number":1927,"context_line":"                         \"_get_AD_config\","},{"line_number":1928,"context_line":"                         mock.Mock("},{"line_number":1929,"context_line":"                             side_effect\u003d[None,"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_ed94cf8b","line":1926,"range":{"start_line":1926,"start_character":8,"end_line":1926,"end_character":51},"in_reply_to":"fa69d971_d1b16fe1","updated":"2016-01-11 15:55:55.000000000","message":"_get_AD_config is actually called, so I think there\u0027s no need check it in every cases. Thanks!","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"06e85263a96bcfed1ada5a2add04fa2664aee088","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"            backend_details \u003d self.driver.setup_server(fake_network_info)"},{"line_number":1959,"context_line":"            self.assertEqual(self.fake_network_allocations[0][\u0027ip_address\u0027],"},{"line_number":1960,"context_line":"                             backend_details[\u0027ip\u0027])"},{"line_number":1961,"context_line":"        else:"},{"line_number":1962,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":1963,"context_line":"                              self.driver.setup_server,"},{"line_number":1964,"context_line":"                              fake_network_info)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_1131475a","line":1961,"range":{"start_line":1961,"start_character":7,"end_line":1961,"end_character":13},"updated":"2016-01-11 14:23:02.000000000","message":"Better to split all cases to \"positive\" and \"negative\" and reduce amount of conditions in tests.","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"45e435ca23c7cdd453cc63b98d6975dce9fff94d","unresolved":false,"context_lines":[{"line_number":1958,"context_line":"            backend_details \u003d self.driver.setup_server(fake_network_info)"},{"line_number":1959,"context_line":"            self.assertEqual(self.fake_network_allocations[0][\u0027ip_address\u0027],"},{"line_number":1960,"context_line":"                             backend_details[\u0027ip\u0027])"},{"line_number":1961,"context_line":"        else:"},{"line_number":1962,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":1963,"context_line":"                              self.driver.setup_server,"},{"line_number":1964,"context_line":"                              fake_network_info)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_2ddf473b","line":1961,"range":{"start_line":1961,"start_character":7,"end_line":1961,"end_character":13},"in_reply_to":"fa69d971_1131475a","updated":"2016-01-11 15:55:55.000000000","message":"This case is used to test number \u003c\u003d 3 or number \u003e 3. So \"positive\" and \"negative\" of number is not appropriate?","commit_id":"dca70d52820be0d78b9ec90de978b10de76bb3bc"}]}
