)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"004459426cab8ccd649e845af275331b874a3f81","unresolved":false,"context_lines":[{"line_number":15,"context_line":"places, we have to handle accessing the instance as a dict entry rather"},{"line_number":16,"context_line":"than an attribute on a sqlalchemy object."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1510507"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I114b67dfeef0f46022230f91c6807a69ea9175a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_fb553ff9","line":18,"updated":"2015-12-21 20:34:58.000000000","message":"There are still hits in the logs:\n\nhttp://logstash.openstack.org/#dashboard/file/logstash.json?query\u003dmessage:%5C%22is%20deprecated.%20Please%20use%20appropriate%20property%20from%20share%20instance%5C%22%20AND%20project:%5C%22openstack/manila%5C%22%20AND%20build_change:%5C%22260186%5C%22\n\nSo we should probably make this partial-bug or keep working on what ever is causing those warnings. A follow-on change to just remove the access in the db model would also show where they are getting used.","commit_id":"55c4f96aa90099644eabd19175c7eb48ff48a66d"}],"manila/api/v1/share_unmanage.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3325870daae2266722b1521577ebbf7cdc88ca8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":40,"context_line":"            # TODO(mriedem): make tests pass a db object rather than a dict"},{"line_number":41,"context_line":"            if hasattr(share, \u0027instance\u0027):"},{"line_number":42,"context_line":"                instance \u003d share.instance or {}"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                instance \u003d share.setdefault(\u0027instance\u0027, {}) or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_c1cdf466","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":23},"updated":"2015-12-21 22:07:02.000000000","message":"Following will work for both - DB model instance and dict.\n\n\"\"\"\n\ninstance \u003d share[\u0027instance\u0027]\n\n\"\"\"\n\nSame in other places.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"916fd6253d3971e4b77b8c9fbe76a8b8167fce1f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":40,"context_line":"            # TODO(mriedem): make tests pass a db object rather than a dict"},{"line_number":41,"context_line":"            if hasattr(share, \u0027instance\u0027):"},{"line_number":42,"context_line":"                instance \u003d share.instance or {}"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                instance \u003d share.setdefault(\u0027instance\u0027, {}) or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_411c6677","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":23},"in_reply_to":"3a7e1126_10bd76d7","updated":"2016-01-07 17:10:57.000000000","message":"Done","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d91692ed6fabcdc347ce3f67062c7b11d82ceedc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":40,"context_line":"            # TODO(mriedem): make tests pass a db object rather than a dict"},{"line_number":41,"context_line":"            if hasattr(share, \u0027instance\u0027):"},{"line_number":42,"context_line":"                instance \u003d share.instance or {}"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                instance \u003d share.setdefault(\u0027instance\u0027, {}) or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_f87d3a6d","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":23},"in_reply_to":"3a7e1126_c1cdf466","updated":"2015-12-22 03:18:52.000000000","message":"I\u0027m not sure it will work for Mock types though, which some of the tests are using. I\u0027ll try share[\u0027instance\u0027] though.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4fb68a5705790a9a671ed5a099a5d1e96d6c903f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            share \u003d self.share_api.get(context, id)"},{"line_number":40,"context_line":"            # TODO(mriedem): make tests pass a db object rather than a dict"},{"line_number":41,"context_line":"            if hasattr(share, \u0027instance\u0027):"},{"line_number":42,"context_line":"                instance \u003d share.instance or {}"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                instance \u003d share.setdefault(\u0027instance\u0027, {}) or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_10bd76d7","line":41,"range":{"start_line":41,"start_character":22,"end_line":41,"end_character":23},"in_reply_to":"3a7e1126_f87d3a6d","updated":"2015-12-22 08:20:33.000000000","message":"Then either mocking should be updated or reworked somehow else. Main code should not have \"such\" conditions.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"}],"manila/api/v1/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3325870daae2266722b1521577ebbf7cdc88ca8","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            # If share_network_id is empty than update it with"},{"line_number":275,"context_line":"            # share_network_id of parent share."},{"line_number":276,"context_line":"            parent_share \u003d self.share_api.get(context, snapshot[\u0027share_id\u0027])"},{"line_number":277,"context_line":"            parent_share_net_id \u003d parent_share.instance[\u0027share_network_id\u0027]"},{"line_number":278,"context_line":"            if share_network_id:"},{"line_number":279,"context_line":"                if share_network_id !\u003d parent_share_net_id:"},{"line_number":280,"context_line":"                    msg \u003d \"Share network ID should be the same as snapshot\u0027s\" \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_e1f6f08d","line":277,"range":{"start_line":277,"start_character":47,"end_line":277,"end_character":55},"updated":"2015-12-21 22:07:02.000000000","message":"parent_share[\u0027instance\u0027][\u0027share_network_id\u0027]","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d91692ed6fabcdc347ce3f67062c7b11d82ceedc","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            # If share_network_id is empty than update it with"},{"line_number":275,"context_line":"            # share_network_id of parent share."},{"line_number":276,"context_line":"            parent_share \u003d self.share_api.get(context, snapshot[\u0027share_id\u0027])"},{"line_number":277,"context_line":"            parent_share_net_id \u003d parent_share.instance[\u0027share_network_id\u0027]"},{"line_number":278,"context_line":"            if share_network_id:"},{"line_number":279,"context_line":"                if share_network_id !\u003d parent_share_net_id:"},{"line_number":280,"context_line":"                    msg \u003d \"Share network ID should be the same as snapshot\u0027s\" \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b894928a","line":277,"range":{"start_line":277,"start_character":47,"end_line":277,"end_character":55},"in_reply_to":"3a7e1126_e1f6f08d","updated":"2015-12-22 03:18:52.000000000","message":"This is actually fine, we don\u0027t have any conditional logic here, it just works with the DB object and what the tests are stubbing. I could change if you want, but this actually accesses the instance as an attribute on the db object, which is what it really is.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"10349f2a5307c59e27f76132645a73bf95caff7e","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                                          display_description,"},{"line_number":325,"context_line":"                                          **kwargs)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return self._view_builder.detail(req, new_share)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @staticmethod"},{"line_number":330,"context_line":"    def _validate_common_name(access):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_aa64f248","line":327,"range":{"start_line":327,"start_character":55,"end_line":327,"end_character":56},"updated":"2016-01-08 05:12:51.000000000","message":"unrelated change? Needed or not the extra wrapping was probably part of py3x support.","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8e66e786c22d85bf0423eab04c5246ddac44aa25","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                                          display_description,"},{"line_number":325,"context_line":"                                          **kwargs)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        return self._view_builder.detail(req, new_share)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    @staticmethod"},{"line_number":330,"context_line":"    def _validate_common_name(access):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_89478e76","line":327,"range":{"start_line":327,"start_character":55,"end_line":327,"end_character":56},"in_reply_to":"fa69d971_aa64f248","updated":"2016-01-08 16:25:07.000000000","message":"iteritems was causing issues in previous patch sets and I didn\u0027t think was necessary, I\u0027ll restore that and see if it\u0027s still a problem.","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"}],"manila/api/views/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3325870daae2266722b1521577ebbf7cdc88ca8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # NOTE(mriedem): The share parameter can be a sqlalchemy data model"},{"line_number":65,"context_line":"        # object or a dict, so we have to handle checking for the instance"},{"line_number":66,"context_line":"        # field appropriately."},{"line_number":67,"context_line":"        if hasattr(share, \u0027instance\u0027):"},{"line_number":68,"context_line":"            share_instance \u003d share.instance or {}"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            # TODO(mriedem): Long-term this should go away and we should only"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_2137184e","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":18},"updated":"2015-12-21 22:07:02.000000000","message":"share_instance \u003d share[\u0027instance\u0027]","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d91692ed6fabcdc347ce3f67062c7b11d82ceedc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # NOTE(mriedem): The share parameter can be a sqlalchemy data model"},{"line_number":65,"context_line":"        # object or a dict, so we have to handle checking for the instance"},{"line_number":66,"context_line":"        # field appropriately."},{"line_number":67,"context_line":"        if hasattr(share, \u0027instance\u0027):"},{"line_number":68,"context_line":"            share_instance \u003d share.instance or {}"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            # TODO(mriedem): Long-term this should go away and we should only"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_788aaa65","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":18},"in_reply_to":"3a7e1126_2137184e","updated":"2015-12-22 03:18:52.000000000","message":"I\u0027ll try it.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"86e3655d9dbd3fe5ffe1b87436251fbce59a58e0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # NOTE(mriedem): The share parameter can be a sqlalchemy data model"},{"line_number":65,"context_line":"        # object or a dict, so we have to handle checking for the instance"},{"line_number":66,"context_line":"        # field appropriately."},{"line_number":67,"context_line":"        if hasattr(share, \u0027instance\u0027):"},{"line_number":68,"context_line":"            share_instance \u003d share.instance or {}"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            # TODO(mriedem): Long-term this should go away and we should only"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_cc396df4","line":67,"range":{"start_line":67,"start_character":11,"end_line":67,"end_character":18},"in_reply_to":"3a7e1126_788aaa65","updated":"2016-01-07 17:30:13.000000000","message":"By tweaking the wrapper class in the stubs module I think I\u0027ve got this working with both the real DB objects and the stubbed out dicts that can be passed in from random unit tests.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3325870daae2266722b1521577ebbf7cdc88ca8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.update_versioned_resource_dict(request, share_dict, share)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if context.is_admin:"},{"line_number":99,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d \\"},{"line_number":100,"context_line":"                share_instance.get(\u0027share_server_id\u0027)"},{"line_number":101,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_210e388c","line":99,"updated":"2015-12-21 22:07:02.000000000","message":"share_dict[\u0027share_server_id\u0027] \u003d (\n\n    share_instance.get(\u0027share_server_id\u0027))","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d91692ed6fabcdc347ce3f67062c7b11d82ceedc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.update_versioned_resource_dict(request, share_dict, share)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if context.is_admin:"},{"line_number":99,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d \\"},{"line_number":100,"context_line":"                share_instance.get(\u0027share_server_id\u0027)"},{"line_number":101,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_f8f45af1","line":99,"in_reply_to":"3a7e1126_210e388c","updated":"2015-12-22 03:18:52.000000000","message":"Done","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"69a64b66c67352380f8ffe376676953c45b516db","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # NOTE(mriedem): The share parameter can be a sqlalchemy data model"},{"line_number":65,"context_line":"        # object or a dict, so we have to handle checking for the instance"},{"line_number":66,"context_line":"        # field appropriately."},{"line_number":67,"context_line":"        if hasattr(share, \u0027instance\u0027):"},{"line_number":68,"context_line":"            share_instance \u003d share.instance or {}"},{"line_number":69,"context_line":"        else:"},{"line_number":70,"context_line":"            # TODO(mriedem): Long-term this should go away and we should only"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_3fb94aed","line":67,"updated":"2016-01-07 18:42:52.000000000","message":"Hmm, I thought I had removed this locally, shouldn\u0027t need this anymore.","commit_id":"d1017d14296aa2d3f05359f88929024988876a9d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"},{"line_number":68,"context_line":"            \u0027availability_zone\u0027: share_instance.get(\u0027availability_zone\u0027),"},{"line_number":69,"context_line":"            \u0027created_at\u0027: share.get(\u0027created_at\u0027),"},{"line_number":70,"context_line":"            \u0027status\u0027: share.get(\u0027status\u0027),"},{"line_number":71,"context_line":"            \u0027name\u0027: share.get(\u0027display_name\u0027),"},{"line_number":72,"context_line":"            \u0027description\u0027: share.get(\u0027display_description\u0027),"},{"line_number":73,"context_line":"            \u0027project_id\u0027: share.get(\u0027project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_26b5ba7d","line":70,"updated":"2016-01-07 22:16:15.000000000","message":"\u0027status\u0027 is part of \"share_instance\" too.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"},{"line_number":68,"context_line":"            \u0027availability_zone\u0027: share_instance.get(\u0027availability_zone\u0027),"},{"line_number":69,"context_line":"            \u0027created_at\u0027: share.get(\u0027created_at\u0027),"},{"line_number":70,"context_line":"            \u0027status\u0027: share.get(\u0027status\u0027),"},{"line_number":71,"context_line":"            \u0027name\u0027: share.get(\u0027display_name\u0027),"},{"line_number":72,"context_line":"            \u0027description\u0027: share.get(\u0027display_description\u0027),"},{"line_number":73,"context_line":"            \u0027project_id\u0027: share.get(\u0027project_id\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_4ea0f190","line":70,"in_reply_to":"fa69d971_26b5ba7d","updated":"2016-01-08 03:36:46.000000000","message":"I was only working on cleaning up the usage of the deprecated proxy properties which is the 4 here:\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L224","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            \u0027snapshot_id\u0027: share.get(\u0027snapshot_id\u0027),"},{"line_number":76,"context_line":"            \u0027share_network_id\u0027: share_instance.get(\u0027share_network_id\u0027),"},{"line_number":77,"context_line":"            \u0027share_proto\u0027: share.get(\u0027share_proto\u0027),"},{"line_number":78,"context_line":"            \u0027export_location\u0027: share.get(\u0027export_location\u0027),"},{"line_number":79,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":80,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":81,"context_line":"            \u0027volume_type\u0027: share_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_66bbb276","line":78,"updated":"2016-01-07 22:16:15.000000000","message":"\u0027export_location\u0027 is part of \"share_instance\" too.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            \u0027snapshot_id\u0027: share.get(\u0027snapshot_id\u0027),"},{"line_number":76,"context_line":"            \u0027share_network_id\u0027: share_instance.get(\u0027share_network_id\u0027),"},{"line_number":77,"context_line":"            \u0027share_proto\u0027: share.get(\u0027share_proto\u0027),"},{"line_number":78,"context_line":"            \u0027export_location\u0027: share.get(\u0027export_location\u0027),"},{"line_number":79,"context_line":"            \u0027metadata\u0027: metadata,"},{"line_number":80,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":81,"context_line":"            \u0027volume_type\u0027: share_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_2eca5d50","line":78,"in_reply_to":"fa69d971_66bbb276","updated":"2016-01-08 03:36:46.000000000","message":"Again, it\u0027s not part of the set that emits a deprecation warning:\n\nhttps://github.com/openstack/manila/blob/master/manila/db/sqlalchemy/models.py#L224","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if context.is_admin:"},{"line_number":90,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d \\"},{"line_number":91,"context_line":"                share_instance.get(\u0027share_server_id\u0027)"},{"line_number":92,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @common.ViewBuilder.versioned_method(\"2.2\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_669412e8","line":91,"updated":"2016-01-07 22:16:15.000000000","message":"share_dict[\u0027share_server_id\u0027] \u003d share_instance.get(\n    \u0027share_server_id\u0027)","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if context.is_admin:"},{"line_number":90,"context_line":"            share_dict[\u0027share_server_id\u0027] \u003d \\"},{"line_number":91,"context_line":"                share_instance.get(\u0027share_server_id\u0027)"},{"line_number":92,"context_line":"        return {\u0027share\u0027: share_dict}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @common.ViewBuilder.versioned_method(\"2.2\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8eeb49b0","line":91,"in_reply_to":"fa69d971_669412e8","updated":"2016-01-08 03:36:46.000000000","message":"Done","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"10349f2a5307c59e27f76132645a73bf95caff7e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_type \u003d share[\u0027share_type_id\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        share_instance \u003d share.get(\u0027instance\u0027, {}) or {}"},{"line_number":65,"context_line":"        share_dict \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027: share.get(\u0027id\u0027),"},{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_af62c4ab","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":56},"updated":"2016-01-08 05:12:51.000000000","message":"The \u0027or {}\u0027 makes the default value unnecessary.","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cb5ccaf4286beeed5b2edf84b61571ea459b0b2e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_type \u003d share[\u0027share_type_id\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        share_instance \u003d share.get(\u0027instance\u0027, {}) or {}"},{"line_number":65,"context_line":"        share_dict \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027: share.get(\u0027id\u0027),"},{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_e4c8af76","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":56},"in_reply_to":"fa69d971_4908b62d","updated":"2016-01-08 16:30:37.000000000","message":"Matt, \"share_instance \u003d share.get(\u0027instance\u0027) or {}\" will work for both cases you described and it was Mark\u0027s point.","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"84b5c015f35cd4dcb61a2a8bfd5ea92b07c48d21","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_type \u003d share[\u0027share_type_id\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        share_instance \u003d share.get(\u0027instance\u0027, {}) or {}"},{"line_number":65,"context_line":"        share_dict \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027: share.get(\u0027id\u0027),"},{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_fa7ccab6","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":56},"in_reply_to":"fa69d971_9ac7ce11","updated":"2016-01-08 17:12:47.000000000","message":"better than under-thinking! (you didn\u0027t let that None value sneak thru)","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8e66e786c22d85bf0423eab04c5246ddac44aa25","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_type \u003d share[\u0027share_type_id\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        share_instance \u003d share.get(\u0027instance\u0027, {}) or {}"},{"line_number":65,"context_line":"        share_dict \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027: share.get(\u0027id\u0027),"},{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_4908b62d","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":56},"in_reply_to":"fa69d971_af62c4ab","updated":"2016-01-08 16:25:07.000000000","message":"No, it doesn\u0027t. The \u0027instance\u0027 key might not be in share, in which case get with the default gives us {}. But if \u0027instance\u0027 is in share but it\u0027s value is None, which it can be, then we need to default to {} so the share_instance.get calls below don\u0027t result in NoneType errors.","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bfecb41879d8bdf10e7a4cc867baafbf6c1ae755","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            share_type \u003d share[\u0027share_type_id\u0027]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        share_instance \u003d share.get(\u0027instance\u0027, {}) or {}"},{"line_number":65,"context_line":"        share_dict \u003d {"},{"line_number":66,"context_line":"            \u0027id\u0027: share.get(\u0027id\u0027),"},{"line_number":67,"context_line":"            \u0027size\u0027: share.get(\u0027size\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_9ac7ce11","line":64,"range":{"start_line":64,"start_character":54,"end_line":64,"end_character":56},"in_reply_to":"fa69d971_e4c8af76","updated":"2016-01-08 17:08:42.000000000","message":"Ah yes, was over-thinking this one.","commit_id":"a6a2eb15d420711fdd0eb9869fc366764cceceb7"}],"manila/tests/api/contrib/stubs.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3325870daae2266722b1521577ebbf7cdc88ca8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027snapshot_support\u0027: True,"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    share_instance \u003d {"},{"line_number":45,"context_line":"        \u0027host\u0027: \u0027fakehost\u0027,"},{"line_number":46,"context_line":"        \u0027availability_zone\u0027: \u0027fakeaz\u0027,"},{"line_number":47,"context_line":"        \u0027share_network_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_a11a28c4","line":44,"range":{"start_line":44,"start_character":18,"end_line":44,"end_character":19},"updated":"2015-12-21 22:07:02.000000000","message":"Please, do not introduce new stubs. Here is example how to use temporary DB instead of stubs: https://review.openstack.org/#/c/259024/","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d91692ed6fabcdc347ce3f67062c7b11d82ceedc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027snapshot_support\u0027: True,"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    share_instance \u003d {"},{"line_number":45,"context_line":"        \u0027host\u0027: \u0027fakehost\u0027,"},{"line_number":46,"context_line":"        \u0027availability_zone\u0027: \u0027fakeaz\u0027,"},{"line_number":47,"context_line":"        \u0027share_network_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b8c25283","line":44,"range":{"start_line":44,"start_character":18,"end_line":44,"end_character":19},"in_reply_to":"3a7e1126_a11a28c4","updated":"2015-12-22 03:18:52.000000000","message":"I\u0027m not sure what you mean by \u0027new stubs\u0027. This was already stubbed out, I\u0027m just re-organizing this to separate the share_instance from the share, otherwise it\u0027s the same. If you mean to actually insert records into the database, I\u0027d avoid that since it adds a performance penalty to your unit tests since it requires actually populating the database and retrieving from it everywhere, which is pretty heavy-weight for unit tests when you can just mock out the DB API using mock.\n\nIn nova we actually have a sub-class of TestCase which blocks access to the database and the tests that extend from that fail if they hit the DB API since we want a lot of the unit tests to be very light and fast.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4fb68a5705790a9a671ed5a099a5d1e96d6c903f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027snapshot_support\u0027: True,"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    share_instance \u003d {"},{"line_number":45,"context_line":"        \u0027host\u0027: \u0027fakehost\u0027,"},{"line_number":46,"context_line":"        \u0027availability_zone\u0027: \u0027fakeaz\u0027,"},{"line_number":47,"context_line":"        \u0027share_network_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_90fc06b9","line":44,"range":{"start_line":44,"start_character":18,"end_line":44,"end_character":19},"in_reply_to":"3a7e1126_b8c25283","updated":"2015-12-22 08:20:33.000000000","message":"The fact that you make conditions in main code just because of unit tests says that mocking , in such case, not suitable. Main code should not be affected by changes in unit tests. So, either mocking should be enhanced or replaced with proper approach.\n\nAbout Nova:\n\n- it is much bigger than Manila, so, amount of tests for Manila will never reach amount of Nova unit tests.\n- Nova is pretty unstable to use it as example for testing.\n\nSo, I do not insist to see usage of DB in your change, but implementation of conditions, that support \"separate\" approach for tests is wrong way and should not be implemented. Why? Because you do not test \"main part\" that will work in real service, but test thing that is used only in tests.","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"}],"manila/tests/api/v1/test_share_unmanage.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_unmanage_share(self):"},{"line_number":55,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":56,"context_line":"                     instance\u003d{})"},{"line_number":57,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027, mock.Mock(return_value\u003dshare))"},{"line_number":58,"context_line":"        self.mock_object(share_api.API, \u0027unmanage\u0027, mock.Mock())"},{"line_number":59,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_6e739116","line":56,"range":{"start_line":55,"start_character":16,"end_line":56,"end_character":32},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c20b29360bf1326da37b3964b62ff8628fa60019","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_unmanage_share(self):"},{"line_number":55,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":56,"context_line":"                     instance\u003d{})"},{"line_number":57,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027, mock.Mock(return_value\u003dshare))"},{"line_number":58,"context_line":"        self.mock_object(share_api.API, \u0027unmanage\u0027, mock.Mock())"},{"line_number":59,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_b8f22199","line":56,"range":{"start_line":55,"start_character":16,"end_line":56,"end_character":32},"in_reply_to":"7a5de9d1_6e739116","updated":"2016-02-03 15:05:26.000000000","message":"The test was already using dict. What is the point in switching everything to using {} rather than dict? They work the same. And I don\u0027t buy into the tiny performance difference as an argument worth making that change, especially in this many places. I definitely don\u0027t think it warrants a -1.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            self.context, self.resource_name, \u0027unmanage\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_unmanage_share_that_has_snapshots(self):"},{"line_number":77,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":78,"context_line":"                     instance\u003d{})"},{"line_number":79,"context_line":"        snapshots \u003d [\u0027foo\u0027, \u0027bar\u0027]"},{"line_number":80,"context_line":"        self.mock_object(self.controller.share_api, \u0027unmanage\u0027)"},{"line_number":81,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ae50a95f","line":78,"range":{"start_line":77,"start_character":16,"end_line":78,"end_character":33},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            self.context, self.resource_name, \u0027unmanage\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_unmanage_share_based_on_share_server(self):"},{"line_number":102,"context_line":"        share \u003d dict(instance\u003ddict(share_server_id\u003d\u0027foo_id\u0027), id\u003d\u0027bar_id\u0027)"},{"line_number":103,"context_line":"        self.mock_object("},{"line_number":104,"context_line":"            self.controller.share_api, \u0027get\u0027,"},{"line_number":105,"context_line":"            mock.Mock(return_value\u003dshare))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_0eb9bdec","line":102,"range":{"start_line":102,"start_character":16,"end_line":102,"end_character":74},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @ddt.data(*constants.TRANSITIONAL_STATUSES)"},{"line_number":117,"context_line":"    def test_unmanage_share_with_transitional_state(self, share_status):"},{"line_number":118,"context_line":"        share \u003d dict(status\u003dshare_status, id\u003d\u0027foo_id\u0027, instance\u003d{})"},{"line_number":119,"context_line":"        self.mock_object("},{"line_number":120,"context_line":"            self.controller.share_api, \u0027get\u0027,"},{"line_number":121,"context_line":"            mock.Mock(return_value\u003dshare))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_cecf2528","line":118,"range":{"start_line":118,"start_character":16,"end_line":118,"end_character":67},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    @ddt.data(exception.InvalidShare(reason\u003d\"fake\"),"},{"line_number":144,"context_line":"              exception.PolicyNotAuthorized(action\u003d\"fake\"),)"},{"line_number":145,"context_line":"    def test_unmanage_share_invalid(self, side_effect):"},{"line_number":146,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":147,"context_line":"                     instance\u003d{})"},{"line_number":148,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027, mock.Mock(return_value\u003dshare))"},{"line_number":149,"context_line":"        self.mock_object(share_api.API, \u0027unmanage\u0027, mock.Mock("},{"line_number":150,"context_line":"            side_effect\u003dside_effect))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_aed749be","line":147,"range":{"start_line":146,"start_character":16,"end_line":147,"end_character":33},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"}],"manila/tests/api/v1/test_shares.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                                size\u003dshr[\u0027size\u0027],"},{"line_number":266,"context_line":"                                share_proto\u003dshr[\u0027share_proto\u0027].upper(),"},{"line_number":267,"context_line":"                                snapshot_id\u003dshr[\u0027snapshot_id\u0027],"},{"line_number":268,"context_line":"                                instance\u003ddict("},{"line_number":269,"context_line":"                                    availability_zone\u003dshr[\u0027availability_zone\u0027],"},{"line_number":270,"context_line":"                                    share_network_id\u003dshr[\u0027share_network_id\u0027])))"},{"line_number":271,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, create_mock)"},{"line_number":272,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":273,"context_line":"                         stubs.stub_snapshot_get)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ce972539","line":270,"range":{"start_line":268,"start_character":41,"end_line":270,"end_character":76},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                                size\u003dshr[\u0027size\u0027],"},{"line_number":304,"context_line":"                                share_proto\u003dshr[\u0027share_proto\u0027].upper(),"},{"line_number":305,"context_line":"                                snapshot_id\u003dshr[\u0027snapshot_id\u0027],"},{"line_number":306,"context_line":"                                instance\u003ddict("},{"line_number":307,"context_line":"                                    availability_zone\u003dshr[\u0027availability_zone\u0027],"},{"line_number":308,"context_line":"                                    share_network_id\u003dshr[\u0027share_network_id\u0027])))"},{"line_number":309,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, create_mock)"},{"line_number":310,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":311,"context_line":"                         stubs.stub_snapshot_get)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ceae4581","line":308,"range":{"start_line":306,"start_character":41,"end_line":308,"end_character":77},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3325870daae2266722b1521577ebbf7cdc88ca8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":60,"context_line":"                         stubs.stub_snapshot_get)"},{"line_number":61,"context_line":"        self.maxDiff \u003d None"},{"line_number":62,"context_line":"        # This is a fake request body, not the DB object."},{"line_number":63,"context_line":"        self.share \u003d {"},{"line_number":64,"context_line":"            \"size\": 100,"},{"line_number":65,"context_line":"            \"display_name\": \"Share Test Name\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_215cf87b","line":62,"updated":"2015-12-21 22:07:02.000000000","message":"Why do you need this comment?","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d91692ed6fabcdc347ce3f67062c7b11d82ceedc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":60,"context_line":"                         stubs.stub_snapshot_get)"},{"line_number":61,"context_line":"        self.maxDiff \u003d None"},{"line_number":62,"context_line":"        # This is a fake request body, not the DB object."},{"line_number":63,"context_line":"        self.share \u003d {"},{"line_number":64,"context_line":"            \"size\": 100,"},{"line_number":65,"context_line":"            \"display_name\": \"Share Test Name\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_b8701273","line":62,"in_reply_to":"3a7e1126_215cf87b","updated":"2015-12-22 03:18:52.000000000","message":"Because I spent probably at least an hour or two debugging test failures in this module because of the variable created in the setUp along with in the test cases, and the naming on the variables is not clear if they are supposed to be a share in a request body or a share db object returned from the share API, so I\u0027m trying to document the code a bit for clarity (keep in mind this is probably my first manila patch so I\u0027m coming at this as a new-comer to the project).","commit_id":"2e365ce737e8b4f4b0bb32f7da3057303a04f895"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":60,"context_line":"                         stubs.stub_snapshot_get)"},{"line_number":61,"context_line":"        self.maxDiff \u003d None"},{"line_number":62,"context_line":"        # This is a fake request body, not the DB object."},{"line_number":63,"context_line":"        self.share \u003d {"},{"line_number":64,"context_line":"            \"size\": 100,"},{"line_number":65,"context_line":"            \"display_name\": \"Share Test Name\","}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_e65d6249","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":56},"updated":"2016-01-07 22:16:15.000000000","message":"It is too obvious, I don\u0027t see real reason too add this comment.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":60,"context_line":"                         stubs.stub_snapshot_get)"},{"line_number":61,"context_line":"        self.maxDiff \u003d None"},{"line_number":62,"context_line":"        # This is a fake request body, not the DB object."},{"line_number":63,"context_line":"        self.share \u003d {"},{"line_number":64,"context_line":"            \"size\": 100,"},{"line_number":65,"context_line":"            \"display_name\": \"Share Test Name\","}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ee768505","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":56},"in_reply_to":"fa69d971_e65d6249","updated":"2016-01-08 03:36:46.000000000","message":"I\u0027d argue it\u0027s not obvious to someone that\u0027s new to this code base, which I am, but I\u0027ll remove it.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                display_description\u003dself.share[\u0027display_description\u0027],"},{"line_number":76,"context_line":"                size\u003d100,"},{"line_number":77,"context_line":"                share_proto\u003dself.share[\u0027share_proto\u0027].upper(),"},{"line_number":78,"context_line":"                instance\u003ddict("},{"line_number":79,"context_line":"                    availability_zone\u003dself.share[\u0027availability_zone\u0027]))"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        self.vt \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_26437a6e","line":78,"updated":"2016-01-07 22:16:15.000000000","message":"Dict init using class \"dict\" is slower than usage of braces.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                display_description\u003dself.share[\u0027display_description\u0027],"},{"line_number":76,"context_line":"                size\u003d100,"},{"line_number":77,"context_line":"                share_proto\u003dself.share[\u0027share_proto\u0027].upper(),"},{"line_number":78,"context_line":"                instance\u003ddict("},{"line_number":79,"context_line":"                    availability_zone\u003dself.share[\u0027availability_zone\u0027]))"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        self.vt \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_eefbe545","line":78,"in_reply_to":"fa69d971_26437a6e","updated":"2016-01-08 03:36:46.000000000","message":"That\u0027s pretty nit-picky, I can\u0027t believe it would be noticeable in a full test run, but I\u0027ll change it.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                \u0027snapshot_id\u0027: \u0027fake_snapshot_id\u0027,"},{"line_number":698,"context_line":"                \u0027share_type_id\u0027: \u0027fake_share_type_id\u0027,"},{"line_number":699,"context_line":"                \u0027instance\u0027: {\u0027host\u0027: \u0027fake_host\u0027,"},{"line_number":700,"context_line":"                             \u0027share_network_id\u0027: \u0027fake_share_network_id\u0027},"},{"line_number":701,"context_line":"            },"},{"line_number":702,"context_line":"            {\u0027id\u0027: \u0027id3\u0027, \u0027display_name\u0027: \u0027n3\u0027},"},{"line_number":703,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_66309208","line":700,"updated":"2016-01-07 22:16:15.000000000","message":"\u0027instance\u0027: {\n    \u0027host\u0027: \u0027fake_host\u0027,\n    \u0027share_network_id\u0027: \u0027fake_share_network_id\u0027,\n},","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                \u0027snapshot_id\u0027: \u0027fake_snapshot_id\u0027,"},{"line_number":698,"context_line":"                \u0027share_type_id\u0027: \u0027fake_share_type_id\u0027,"},{"line_number":699,"context_line":"                \u0027instance\u0027: {\u0027host\u0027: \u0027fake_host\u0027,"},{"line_number":700,"context_line":"                             \u0027share_network_id\u0027: \u0027fake_share_network_id\u0027},"},{"line_number":701,"context_line":"            },"},{"line_number":702,"context_line":"            {\u0027id\u0027: \u0027id3\u0027, \u0027display_name\u0027: \u0027n3\u0027},"},{"line_number":703,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8e7109e3","line":700,"in_reply_to":"fa69d971_66309208","updated":"2016-01-08 03:36:46.000000000","message":"Again, pretty nit picky, but I\u0027ll update it.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"515b6e4ce5cafd9d91eab5c516fc98e4bdb9ae73","unresolved":false,"context_lines":[{"line_number":1429,"context_line":"    def _test_share_manage(self, data, version):"},{"line_number":1430,"context_line":"        self._setup_manage_mocks()"},{"line_number":1431,"context_line":"        return_share \u003d {\u0027share_type_id\u0027: \u0027\u0027, \u0027id\u0027: \u0027fake\u0027,"},{"line_number":1432,"context_line":"                        \u0027instance\u0027: {}}"},{"line_number":1433,"context_line":"        self.mock_object("},{"line_number":1434,"context_line":"            share_api.API, \u0027manage\u0027, mock.Mock(return_value\u003dreturn_share))"},{"line_number":1435,"context_line":"        share \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_863586f8","line":1432,"range":{"start_line":1432,"start_character":29,"end_line":1432,"end_character":30},"updated":"2016-01-07 22:16:15.000000000","message":"same here.","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ce1494da6f60399e9a14501d00731428ff0a6b28","unresolved":false,"context_lines":[{"line_number":1429,"context_line":"    def _test_share_manage(self, data, version):"},{"line_number":1430,"context_line":"        self._setup_manage_mocks()"},{"line_number":1431,"context_line":"        return_share \u003d {\u0027share_type_id\u0027: \u0027\u0027, \u0027id\u0027: \u0027fake\u0027,"},{"line_number":1432,"context_line":"                        \u0027instance\u0027: {}}"},{"line_number":1433,"context_line":"        self.mock_object("},{"line_number":1434,"context_line":"            share_api.API, \u0027manage\u0027, mock.Mock(return_value\u003dreturn_share))"},{"line_number":1435,"context_line":"        share \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a9fe4703","line":1432,"range":{"start_line":1432,"start_character":29,"end_line":1432,"end_character":30},"in_reply_to":"fa69d971_863586f8","updated":"2016-01-08 03:36:46.000000000","message":"Done","commit_id":"3086bdd9057e4e24d06854ede44df92568f8f3f4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                                size\u003dshr[\u0027size\u0027],"},{"line_number":324,"context_line":"                                share_proto\u003dshr[\u0027share_proto\u0027].upper(),"},{"line_number":325,"context_line":"                                snapshot_id\u003dshr[\u0027snapshot_id\u0027],"},{"line_number":326,"context_line":"                                instance\u003ddict("},{"line_number":327,"context_line":"                                    availability_zone\u003dshr[\u0027availability_zone\u0027],"},{"line_number":328,"context_line":"                                    share_network_id\u003dshr[\u0027share_network_id\u0027])))"},{"line_number":329,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, create_mock)"},{"line_number":330,"context_line":"        body \u003d {\"share\": copy.deepcopy(shr)}"},{"line_number":331,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/shares\u0027, version\u003d\u00272.7\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_2ee119d1","line":328,"range":{"start_line":326,"start_character":41,"end_line":328,"end_character":77},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                size\u003dshr[\u0027size\u0027],"},{"line_number":351,"context_line":"                                share_proto\u003dshr[\u0027share_proto\u0027].upper(),"},{"line_number":352,"context_line":"                                snapshot_id\u003dshr[\u0027snapshot_id\u0027],"},{"line_number":353,"context_line":"                                instance\u003ddict("},{"line_number":354,"context_line":"                                    availability_zone\u003dshr[\u0027availability_zone\u0027],"},{"line_number":355,"context_line":"                                    share_network_id\u003dshr[\u0027share_network_id\u0027])))"},{"line_number":356,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, create_mock)"},{"line_number":357,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":358,"context_line":"                         stubs.stub_snapshot_get)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_8ed04df9","line":355,"range":{"start_line":353,"start_character":41,"end_line":355,"end_character":77},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                                size\u003dshr[\u0027size\u0027],"},{"line_number":388,"context_line":"                                share_proto\u003dshr[\u0027share_proto\u0027].upper(),"},{"line_number":389,"context_line":"                                snapshot_id\u003dshr[\u0027snapshot_id\u0027],"},{"line_number":390,"context_line":"                                instance\u003ddict("},{"line_number":391,"context_line":"                                    availability_zone\u003dshr[\u0027availability_zone\u0027],"},{"line_number":392,"context_line":"                                    share_network_id\u003dshr[\u0027share_network_id\u0027])))"},{"line_number":393,"context_line":"        self.mock_object(share_api.API, \u0027create\u0027, create_mock)"},{"line_number":394,"context_line":"        self.mock_object(share_api.API, \u0027get_snapshot\u0027,"},{"line_number":395,"context_line":"                         stubs.stub_snapshot_get)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_cefc0575","line":392,"range":{"start_line":390,"start_character":41,"end_line":392,"end_character":77},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"        )"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def test_unmanage_share(self):"},{"line_number":1206,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":1207,"context_line":"                     instance\u003d{})"},{"line_number":1208,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027, mock.Mock(return_value\u003dshare))"},{"line_number":1209,"context_line":"        self.mock_object(share_api.API, \u0027unmanage\u0027, mock.Mock())"},{"line_number":1210,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ae22e9ff","line":1207,"range":{"start_line":1206,"start_character":15,"end_line":1207,"end_character":33},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"            self.request.environ[\u0027manila.context\u0027], share)"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"    def test_unmanage_share_that_has_snapshots(self):"},{"line_number":1226,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":1227,"context_line":"                     instance\u003d{})"},{"line_number":1228,"context_line":"        snapshots \u003d [\u0027foo\u0027, \u0027bar\u0027]"},{"line_number":1229,"context_line":"        self.mock_object(self.controller.share_api, \u0027unmanage\u0027)"},{"line_number":1230,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_2e16f9a7","line":1227,"range":{"start_line":1226,"start_character":15,"end_line":1227,"end_character":33},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"            self.request.environ[\u0027manila.context\u0027], share[\u0027id\u0027])"},{"line_number":1247,"context_line":""},{"line_number":1248,"context_line":"    def test_unmanage_share_based_on_share_server(self):"},{"line_number":1249,"context_line":"        share \u003d dict(instance\u003ddict(share_server_id\u003d\u0027foo_id\u0027), id\u003d\u0027bar_id\u0027)"},{"line_number":1250,"context_line":"        self.mock_object("},{"line_number":1251,"context_line":"            self.controller.share_api, \u0027get\u0027,"},{"line_number":1252,"context_line":"            mock.Mock(return_value\u003dshare))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_6eee31b6","line":1249,"range":{"start_line":1249,"start_character":16,"end_line":1249,"end_character":74},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"    @ddt.data(*constants.TRANSITIONAL_STATUSES)"},{"line_number":1262,"context_line":"    def test_unmanage_share_with_transitional_state(self, share_status):"},{"line_number":1263,"context_line":"        share \u003d dict(status\u003dshare_status, id\u003d\u0027foo_id\u0027, instance\u003d{})"},{"line_number":1264,"context_line":"        self.mock_object("},{"line_number":1265,"context_line":"            self.controller.share_api, \u0027get\u0027,"},{"line_number":1266,"context_line":"            mock.Mock(return_value\u003dshare))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_ee38e13f","line":1263,"range":{"start_line":1263,"start_character":16,"end_line":1263,"end_character":66},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cab1022ece510e3507cef5d42f9fc39f33816422","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"    @ddt.data(exception.InvalidShare(reason\u003d\"fake\"),"},{"line_number":1285,"context_line":"              exception.PolicyNotAuthorized(action\u003d\"fake\"),)"},{"line_number":1286,"context_line":"    def test_unmanage_share_invalid(self, side_effect):"},{"line_number":1287,"context_line":"        share \u003d dict(status\u003dconstants.STATUS_AVAILABLE, id\u003d\u0027foo_id\u0027,"},{"line_number":1288,"context_line":"                     instance\u003d{})"},{"line_number":1289,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027, mock.Mock(return_value\u003dshare))"},{"line_number":1290,"context_line":"        self.mock_object(share_api.API, \u0027unmanage\u0027, mock.Mock("},{"line_number":1291,"context_line":"            side_effect\u003dside_effect))"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_8e3e0d28","line":1288,"range":{"start_line":1287,"start_character":16,"end_line":1288,"end_character":33},"updated":"2016-02-02 15:21:10.000000000","message":"Please use {} instead of dict() constructor.","commit_id":"853bed02b82416e6d4806470e2532555e221e47f"}]}
