)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8b9c3053368246af26e699e44c216247a8f9b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nidhimittalhada \u003cnidhimittal19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-24 17:37:28 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"status\u003dNone while snapshot delete is in progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a temporary state, during snapshot deletion, when"},{"line_number":10,"context_line":"snapshot-instance is deleted but snapshot itself is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_c8291c39","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"updated":"2015-12-24 19:44:39.000000000","message":"Hide snapshots with no instances from listing","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8b9c3053368246af26e699e44c216247a8f9b2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"status\u003dNone while snapshot delete is in progress"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In a temporary state, during snapshot deletion, when"},{"line_number":10,"context_line":"snapshot-instance is deleted but snapshot itself is"},{"line_number":11,"context_line":"not yet deleted. In that small period of time, if we"},{"line_number":12,"context_line":"list snapshots we see status as None, which is not right."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Hence made the correction by not listing such snapshots."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_08d72424","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":57},"updated":"2015-12-24 19:44:39.000000000","message":"When a snapshot is being destroyed; for a small window of time\nbetween the deletion of all of its instances and the snapshot ref\nitself, the \u0027status\u0027 of the snapshot becomes \u0027None\u0027. This provides\na bad user experience if a list/show query is made within that\nwindow.\n\n\nFix this problem by filtering out snapshots that have this \u0027invalid\u0027\nstatus.","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"}],"manila/api/v1/share_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"decd9c62ee3cb763240b8913bab3c8ea7af16863","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, id)"},{"line_number":79,"context_line":"            # Snapshot with no instances is filtered out"},{"line_number":80,"context_line":"            if(\u0027status\u0027 in snapshot) and (snapshot[\u0027status\u0027] is None):"},{"line_number":81,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":82,"context_line":"        except exception.NotFound:"},{"line_number":83,"context_line":"            raise exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_380a507a","line":80,"range":{"start_line":80,"start_character":14,"end_line":80,"end_character":69},"updated":"2016-01-14 01:37:01.000000000","message":"Seems roundabout.. \n\nwouldn\u0027t this be simpler?\n\n\n    if snapshot.get(\u0027status\u0027) is not None:","commit_id":"7bb3c10973ebdd6cf7810f85c73244550466a5e4"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"bc7249bf2aad4e18154e1ec6c093fdda6247ba05","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        try:"},{"line_number":78,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, id)"},{"line_number":79,"context_line":"            # Snapshot with no instances is filtered out"},{"line_number":80,"context_line":"            if(\u0027status\u0027 in snapshot) and (snapshot[\u0027status\u0027] is None):"},{"line_number":81,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":82,"context_line":"        except exception.NotFound:"},{"line_number":83,"context_line":"            raise exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_0ab5a92f","line":80,"range":{"start_line":80,"start_character":14,"end_line":80,"end_character":69},"in_reply_to":"da6ed579_380a507a","updated":"2016-01-14 06:07:14.000000000","message":"you mean to say \nif snapshot.get(\u0027status\u0027) is None\n    raise exception \n\nright ??\ni did same earlier but \nThere are unit tests which have dummy snapshot data, here it doesn\u0027t have \"status\" key at all .. \nthey start giving key error..and these tests fail... \nhence had to check if status key in snapshot.\n\nlet me know does that make sense to you ?","commit_id":"7bb3c10973ebdd6cf7810f85c73244550466a5e4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"decd9c62ee3cb763240b8913bab3c8ea7af16863","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            sort_dir\u003dsort_dir,"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        snapshots[:] \u003d [s for s in snapshots"},{"line_number":137,"context_line":"                        if ((\u0027status\u0027 not in s) or (s[\u0027status\u0027] is not None))]"},{"line_number":138,"context_line":"        limited_list \u003d common.limited(snapshots, req)"},{"line_number":139,"context_line":"        if is_detail:"},{"line_number":140,"context_line":"            snapshots \u003d self._view_builder.detail_list(req, limited_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_78f0c867","line":137,"range":{"start_line":137,"start_character":28,"end_line":137,"end_character":76},"updated":"2016-01-14 01:37:01.000000000","message":"same here.. \n\nyou can try:\n\n    snapshots \u003d list(filter(lambda x: x.get(\u0027status\u0027) is not None, snapshots))\n\n\nAlso, please add a small comment above as to why we\u0027re doing this, just like in line 78","commit_id":"7bb3c10973ebdd6cf7810f85c73244550466a5e4"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"bc7249bf2aad4e18154e1ec6c093fdda6247ba05","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            sort_dir\u003dsort_dir,"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        snapshots[:] \u003d [s for s in snapshots"},{"line_number":137,"context_line":"                        if ((\u0027status\u0027 not in s) or (s[\u0027status\u0027] is not None))]"},{"line_number":138,"context_line":"        limited_list \u003d common.limited(snapshots, req)"},{"line_number":139,"context_line":"        if is_detail:"},{"line_number":140,"context_line":"            snapshots \u003d self._view_builder.detail_list(req, limited_list)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da6ed579_4d689bb9","line":137,"range":{"start_line":137,"start_character":28,"end_line":137,"end_character":76},"in_reply_to":"da6ed579_78f0c867","updated":"2016-01-14 06:07:14.000000000","message":"same here \ni have to include those snapshot records to new list ...which \n1)do not have status key and \n2)those records which have status key and its not none.","commit_id":"7bb3c10973ebdd6cf7810f85c73244550466a5e4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4ea30a3c884845e6c1972a025f9a2366fe32b86","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            # Snapshot with no instances is filtered out."},{"line_number":81,"context_line":"            if(snapshot.get(\u0027status\u0027) is None):"},{"line_number":82,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            raise exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_3737644e","line":81,"range":{"start_line":81,"start_character":14,"end_line":81,"end_character":46},"updated":"2016-01-15 12:14:01.000000000","message":"The parentheses are redundant. Please remove if you make another patch.","commit_id":"12548c9cea3c81ddd68e75c9433e8d6c735ce9b9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8a64c36672441b94a7db3bdad57b9f1bb6482e91","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            # Snapshot with no instances is filtered out."},{"line_number":81,"context_line":"            if(snapshot.get(\u0027status\u0027) is None):"},{"line_number":82,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            raise exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_489bed72","line":81,"range":{"start_line":81,"start_character":14,"end_line":81,"end_character":46},"in_reply_to":"da6ed579_3737644e","updated":"2016-01-19 21:37:12.000000000","message":"+1","commit_id":"12548c9cea3c81ddd68e75c9433e8d6c735ce9b9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"30692bc50c1097a7e8c1e452a9520715fb6b1fd6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            snapshot \u003d self.share_api.get_snapshot(context, id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            # Snapshot with no instances is filtered out."},{"line_number":81,"context_line":"            if(snapshot.get(\u0027status\u0027) is None):"},{"line_number":82,"context_line":"                raise exc.HTTPNotFound()"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            raise exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_8b5ce019","line":81,"range":{"start_line":81,"start_character":14,"end_line":81,"end_character":46},"in_reply_to":"da6ed579_3737644e","updated":"2016-01-15 14:49:14.000000000","message":"+1","commit_id":"12548c9cea3c81ddd68e75c9433e8d6c735ce9b9"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8b9c3053368246af26e699e44c216247a8f9b2","unresolved":false,"context_lines":[{"line_number":1803,"context_line":"        options(joinedload(\u0027share\u0027)).\\"},{"line_number":1804,"context_line":"        first()"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    if not result:"},{"line_number":1807,"context_line":"        raise exception.ShareSnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"    if result.status is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_a80cd094","line":1806,"range":{"start_line":1806,"start_character":4,"end_line":1806,"end_character":17},"updated":"2015-12-24 19:44:39.000000000","message":"if result is None or result.status is None:","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"e0f473a92a461937112bd7c58a805cd50ac4c9b5","unresolved":false,"context_lines":[{"line_number":1803,"context_line":"        options(joinedload(\u0027share\u0027)).\\"},{"line_number":1804,"context_line":"        first()"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    if not result:"},{"line_number":1807,"context_line":"        raise exception.ShareSnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"    if result.status is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_d0a53eb5","line":1806,"range":{"start_line":1806,"start_character":4,"end_line":1806,"end_character":17},"in_reply_to":"1a7b0d38_a80cd094","updated":"2015-12-25 06:02:02.000000000","message":"result if its None, i cant make a check to result.status it gives python error that Nonetype has no attribute status.\n\nin case when result is None(exception is raised) and when .status is none (result is made None)\n\ni cant raise exception in case .status is None, that deters a few unit tests .. i tried that earlier.","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4df0b5759962ee575758103291d56c2cdb15e01","unresolved":false,"context_lines":[{"line_number":1803,"context_line":"        options(joinedload(\u0027share\u0027)).\\"},{"line_number":1804,"context_line":"        first()"},{"line_number":1805,"context_line":""},{"line_number":1806,"context_line":"    if not result:"},{"line_number":1807,"context_line":"        raise exception.ShareSnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"    if result.status is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_10f9864d","line":1806,"range":{"start_line":1806,"start_character":4,"end_line":1806,"end_character":17},"in_reply_to":"1a7b0d38_d0a53eb5","updated":"2015-12-25 07:13:32.000000000","message":"For the \"or\" operator, the order of execution is left to right, if result is None, the condition is already met; so will bail out; you won\u0027t get the AttributeError.\n\nPlease fix any broken unit tests from earlier.","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8b9c3053368246af26e699e44c216247a8f9b2","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"    if not result:"},{"line_number":1807,"context_line":"        raise exception.ShareSnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"    if result.status is None:"},{"line_number":1810,"context_line":"        result \u003d None"},{"line_number":1811,"context_line":"    return result"},{"line_number":1812,"context_line":""},{"line_number":1813,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_6827c812","line":1810,"range":{"start_line":1809,"start_character":2,"end_line":1810,"end_character":21},"updated":"2015-12-24 19:44:39.000000000","message":"You need the exception on top. This query is being used by other queries in this file.","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"e0f473a92a461937112bd7c58a805cd50ac4c9b5","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"    if not result:"},{"line_number":1807,"context_line":"        raise exception.ShareSnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"    if result.status is None:"},{"line_number":1810,"context_line":"        result \u003d None"},{"line_number":1811,"context_line":"    return result"},{"line_number":1812,"context_line":""},{"line_number":1813,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_b0899228","line":1810,"range":{"start_line":1809,"start_character":2,"end_line":1810,"end_character":21},"in_reply_to":"1a7b0d38_6827c812","updated":"2015-12-25 06:02:02.000000000","message":"Its used by share_snapshot_create, share_snapshot_destroy and share_snapshot_update.\n\nwhere in case 1, 2 this effect is required.\nin case 3 it will not be effective.","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4df0b5759962ee575758103291d56c2cdb15e01","unresolved":false,"context_lines":[{"line_number":1806,"context_line":"    if not result:"},{"line_number":1807,"context_line":"        raise exception.ShareSnapshotNotFound(snapshot_id\u003dsnapshot_id)"},{"line_number":1808,"context_line":""},{"line_number":1809,"context_line":"    if result.status is None:"},{"line_number":1810,"context_line":"        result \u003d None"},{"line_number":1811,"context_line":"    return result"},{"line_number":1812,"context_line":""},{"line_number":1813,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_9bafd793","line":1810,"range":{"start_line":1809,"start_character":2,"end_line":1810,"end_character":21},"in_reply_to":"1a7b0d38_b0899228","updated":"2015-12-25 07:13:32.000000000","message":"I didn\u0027t understand, \n\nI looked at all these functions, I don\u0027t find anything amiss, apart from the one use case where you *could* use:\n\nshare_snapshot_create by specifying create_snapshot_instance\u003dFalse. (I don\u0027t know the use case where you\u0027d want to create the ref without the instance.. I do know of the other way around, where you could create multiple instances of the same ref (We haven\u0027t done that anywhere either)). \n\n\nThis will be required for share_snapshot_update as well... You\u0027d want to throw a proper exception and step out when you get an update call within that tiny window that we speak of. If you don\u0027t, you will get the NoneType AttributeError. (take a look at the share_snapshot_update logic in this file).","commit_id":"964bc1a122e045102c85e34715bf63c23b7ee9a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27b68bdf56258740b2cf3f73810f613b4fe672dd","unresolved":false,"context_lines":[{"line_number":1801,"context_line":"                         project_only\u003dTrue).\\"},{"line_number":1802,"context_line":"        filter_by(id\u003dsnapshot_id).\\"},{"line_number":1803,"context_line":"        options(joinedload(\u0027share\u0027)).\\"},{"line_number":1804,"context_line":"        options(joinedload(\u0027instances\u0027, innerjoin\u003dTrue)).\\"},{"line_number":1805,"context_line":"        first()"},{"line_number":1806,"context_line":""},{"line_number":1807,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a7553dfb","line":1804,"range":{"start_line":1804,"start_character":45,"end_line":1804,"end_character":58},"updated":"2016-01-07 14:10:53.000000000","message":"I know this is tech debt, but could you please wrap this long statement with paranthesis instead of \u0027\\\u0027\n\nhttp://docs.openstack.org/developer/hacking/#general","commit_id":"4c503051bc0a6c6f1b18bbdce5850379c47e1b64"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27b68bdf56258740b2cf3f73810f613b4fe672dd","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"        query \u003d query.filter_by(project_id\u003dproject_id)"},{"line_number":1824,"context_line":"    if share_id:"},{"line_number":1825,"context_line":"        query \u003d query.filter_by(share_id\u003dshare_id)"},{"line_number":1826,"context_line":"    query \u003d query.options(joinedload(\u0027share\u0027)).\\"},{"line_number":1827,"context_line":"        options(joinedload(\u0027instances\u0027, innerjoin\u003dTrue))"},{"line_number":1828,"context_line":""},{"line_number":1829,"context_line":"    # Apply filters"},{"line_number":1830,"context_line":"    if \u0027usage\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_27bdcd02","line":1827,"range":{"start_line":1826,"start_character":12,"end_line":1827,"end_character":56},"updated":"2016-01-07 14:10:53.000000000","message":"same here.","commit_id":"4c503051bc0a6c6f1b18bbdce5850379c47e1b64"}],"manila/tests/db/sqlalchemy/test_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27b68bdf56258740b2cf3f73810f613b4fe672dd","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        self.assertIn(\u0027share_name\u0027, instance_dict)"},{"line_number":570,"context_line":"        self.assertIn(\u0027share_id\u0027, instance_dict)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def test_get_instance_with_status_None(self):"},{"line_number":573,"context_line":"        share \u003d db_utils.create_share(size\u003d1)"},{"line_number":574,"context_line":"        values \u003d {"},{"line_number":575,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_274dcdc4","line":572,"range":{"start_line":572,"start_character":8,"end_line":572,"end_character":42},"updated":"2016-01-07 14:10:53.000000000","message":"test_create_and_get_share_snapshot_no_instances","commit_id":"4c503051bc0a6c6f1b18bbdce5850379c47e1b64"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27b68bdf56258740b2cf3f73810f613b4fe672dd","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            \u0027share_size\u0027: share[\u0027size\u0027],"},{"line_number":582,"context_line":"            \u0027display_name\u0027: \u0027fake\u0027,"},{"line_number":583,"context_line":"            \u0027display_description\u0027: \u0027fake\u0027,"},{"line_number":584,"context_line":"            \u0027share_proto\u0027: share[\u0027share_proto\u0027]"},{"line_number":585,"context_line":"        }"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        self.assertRaises(exception.ShareSnapshotNotFound,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4719e178","line":584,"range":{"start_line":584,"start_character":45,"end_line":584,"end_character":47},"updated":"2016-01-07 14:10:53.000000000","message":"add trailing comma.. \n\nalso, do you need all this data?","commit_id":"4c503051bc0a6c6f1b18bbdce5850379c47e1b64"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27b68bdf56258740b2cf3f73810f613b4fe672dd","unresolved":false,"context_lines":[{"line_number":587,"context_line":"        self.assertRaises(exception.ShareSnapshotNotFound,"},{"line_number":588,"context_line":"                          db_api.share_snapshot_create, self.ctxt,"},{"line_number":589,"context_line":"                          values, create_snapshot_instance\u003dFalse,"},{"line_number":590,"context_line":"                          )"},{"line_number":591,"context_line":"        snapshot_list \u003d db_api.share_snapshot_get_all_for_share("},{"line_number":592,"context_line":"            self.ctxt, share[\u0027id\u0027])"},{"line_number":593,"context_line":"        self.assertEqual(0, len(snapshot_list))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e72495b3","line":590,"range":{"start_line":590,"start_character":26,"end_line":590,"end_character":27},"updated":"2016-01-07 14:10:53.000000000","message":"pull brace up to previous line","commit_id":"4c503051bc0a6c6f1b18bbdce5850379c47e1b64"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"27b68bdf56258740b2cf3f73810f613b4fe672dd","unresolved":false,"context_lines":[{"line_number":588,"context_line":"                          db_api.share_snapshot_create, self.ctxt,"},{"line_number":589,"context_line":"                          values, create_snapshot_instance\u003dFalse,"},{"line_number":590,"context_line":"                          )"},{"line_number":591,"context_line":"        snapshot_list \u003d db_api.share_snapshot_get_all_for_share("},{"line_number":592,"context_line":"            self.ctxt, share[\u0027id\u0027])"},{"line_number":593,"context_line":"        self.assertEqual(0, len(snapshot_list))"},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a7e69dae","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":21},"updated":"2016-01-07 14:10:53.000000000","message":"add extra empty lines above and below this line.","commit_id":"4c503051bc0a6c6f1b18bbdce5850379c47e1b64"}]}
