)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b474582e87d350908877511a151bbd2aa99d16bc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     daiki kato \u003cd-kato@wr.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-25 07:25:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"corrects response code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following NotFound exceptions return response code 500 instad of 404:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_a535bfda","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2015-12-26 04:36:27.000000000","message":"s/corrects response code/Fix response code","commit_id":"7e239cd0def1c88df202ee402873e55f28ab2981"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b474582e87d350908877511a151bbd2aa99d16bc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Also, one of unit tests verify that it returns incorrect code"},{"line_number":16,"context_line":"- https://github.com/openstack/manila/blob/616ffabe/manila/tests/test_exception.py#L455"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch corrects a response code."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ic7be15c2f8951e512de88d1f559ec677ba4bd78e"},{"line_number":21,"context_line":"Closes-Bug: #1525860"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_659cb7c0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":36},"updated":"2015-12-26 04:36:27.000000000","message":"s/a/the","commit_id":"7e239cd0def1c88df202ee402873e55f28ab2981"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"fd818583abae0a48f18c96495b1401b41aaf1677","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix response code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following NotFound exceptions return response code 500 instad of 404:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- StorageResourceNotFound"},{"line_number":12,"context_line":"- SnapshotNotFound"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a7b0d38_697f9c66","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":61},"updated":"2015-12-28 07:56:57.000000000","message":"s/instad/instead","commit_id":"af1ce11859e4efb0b3ed931e5a73c0a916496127"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"fd818583abae0a48f18c96495b1401b41aaf1677","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- ShareResourceNotFound"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, one of unit tests verify that it returns incorrect code"},{"line_number":16,"context_line":"- https://github.com/openstack/manila/blob/616ffabe/manila/tests/test_exception.py#L455"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes the response code."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a7b0d38_a90ca4ed","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":87},"updated":"2015-12-28 07:56:57.000000000","message":"more than 72 characters. For details: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"af1ce11859e4efb0b3ed931e5a73c0a916496127"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7ab9d54210f522da37a0f10b500d998fba93e1fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     daiki kato \u003cd-kato@wr.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-08 02:01:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix response code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch corrects so that following NotFound exception might return"},{"line_number":10,"context_line":"reply code 404."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa69d971_b868c922","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":17},"updated":"2016-01-08 06:12:48.000000000","message":"Would be much better in a condensed listing if the 1st line had more meaning. I know it is supposed to be short, but perhaps \"Fix response code for various NotFound exceptions\" would be much better.","commit_id":"bf6157fb5647988b29f23e70d0906dd667364552"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e3aded5b0693dd254927d22631aa85688c6d41b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     daiki kato \u003cd-kato@wr.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-08 02:01:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix response code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch corrects so that following NotFound exception might return"},{"line_number":10,"context_line":"reply code 404."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa69d971_9a560705","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":17},"in_reply_to":"fa69d971_b868c922","updated":"2016-01-08 10:40:37.000000000","message":"+1\nIt is too ambiguous.","commit_id":"bf6157fb5647988b29f23e70d0906dd667364552"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e3aded5b0693dd254927d22631aa85688c6d41b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix response code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch corrects so that following NotFound exception might return"},{"line_number":10,"context_line":"reply code 404."},{"line_number":11,"context_line":"Also, this patch enables unit test of following NotFound exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- StorageResourceNotFound"},{"line_number":14,"context_line":"- SnapshotNotFound"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa69d971_3a5d9b15","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":67},"updated":"2016-01-08 10:40:37.000000000","message":"Fix response code for \"NotFound\"-like Manila exceptions.","commit_id":"bf6157fb5647988b29f23e70d0906dd667364552"}],"manila/exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b474582e87d350908877511a151bbd2aa99d16bc","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    message \u003d _(\"Storage resource exception.\")"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class StorageResourceNotFound(NotFound):"},{"line_number":567,"context_line":"    message \u003d _(\"Storage resource %(name)s not found.\")"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class SnapshotNotFound(StorageResourceNotFound):"},{"line_number":571,"context_line":"    message \u003d _(\"Snapshot %(name)s not found.\")"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"class SnapshotUnavailable(StorageResourceException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_c55ecb11","line":571,"range":{"start_line":566,"start_character":0,"end_line":571,"end_character":47},"updated":"2015-12-26 04:36:27.000000000","message":"This could be technical debt, but this was not caught earlier because of missing unit tests, could you please add them?","commit_id":"7e239cd0def1c88df202ee402873e55f28ab2981"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8346df617267f9541f38bfa7c8d5d170147fbcce","unresolved":false,"context_lines":[{"line_number":563,"context_line":"    message \u003d _(\"Storage resource exception.\")"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class StorageResourceNotFound(NotFound):"},{"line_number":567,"context_line":"    message \u003d _(\"Storage resource %(name)s not found.\")"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_00d2ef34","line":566,"range":{"start_line":566,"start_character":30,"end_line":566,"end_character":38},"updated":"2016-01-07 14:58:13.000000000","message":"StorageResourceException was conceived as a class of exceptions that could be used by drivers for issues with underlying storage resources.  This proposed change breaks that.  Instead, why not set the 404 code in StorageResourceNotFound ?","commit_id":"b074bfd7b98629f47a48db892eb374bf9f433319"}],"manila/tests/test_exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b474582e87d350908877511a151bbd2aa99d16bc","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        self.assertIn(instance_id, e.msg)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    def test_share_resource_not_found(self):"},{"line_number":452,"context_line":"        # verify response code for exception.ShareNotFound"},{"line_number":453,"context_line":"        share_id \u003d \"fake_share_id\""},{"line_number":454,"context_line":"        e \u003d exception.ShareResourceNotFound(share_id\u003dshare_id)"},{"line_number":455,"context_line":"        self.assertEqual(404, e.code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_4572dbae","line":452,"range":{"start_line":452,"start_character":45,"end_line":452,"end_character":58},"updated":"2015-12-26 04:36:27.000000000","message":"Could you please update this comment as well\n\nthis should be exception.ShareResourceNotFound\n\n(two completely different exceptions)","commit_id":"7e239cd0def1c88df202ee402873e55f28ab2981"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"fd818583abae0a48f18c96495b1401b41aaf1677","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        # verify response code for exception.StorageResourceNotFound"},{"line_number":453,"context_line":"        name \u003d \"fake_name\""},{"line_number":454,"context_line":"        e \u003d exception.StorageResourceNotFound(name\u003dname)"},{"line_number":455,"context_line":"        self.assertEqual(404, e.code)"},{"line_number":456,"context_line":"        self.assertIn(name, e.msg)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def test_snapshot_not_found(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_892e8841","line":455,"range":{"start_line":455,"start_character":25,"end_line":455,"end_character":28},"updated":"2015-12-28 07:56:57.000000000","message":"404 or 500 ? In CommitMessage describe \"using 500 instead of 404\"?","commit_id":"af1ce11859e4efb0b3ed931e5a73c0a916496127"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2cf15038fce5a6810770850da387fefa92539a26","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        # verify response code for exception.StorageResourceNotFound"},{"line_number":453,"context_line":"        name \u003d \"fake_name\""},{"line_number":454,"context_line":"        e \u003d exception.StorageResourceNotFound(name\u003dname)"},{"line_number":455,"context_line":"        self.assertEqual(404, e.code)"},{"line_number":456,"context_line":"        self.assertIn(name, e.msg)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def test_snapshot_not_found(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_3b4ea83b","line":455,"range":{"start_line":455,"start_character":25,"end_line":455,"end_character":28},"in_reply_to":"1a7b0d38_892e8841","updated":"2015-12-28 16:48:17.000000000","message":"500 instead of 404 is the bug. The correct is 404.","commit_id":"af1ce11859e4efb0b3ed931e5a73c0a916496127"}]}
