)]}'
{"manila/share/drivers/glusterfs/common.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                return gluster_execf(*((\u0027gluster\u0027,) + args), **kwargs)"},{"line_number":142,"context_line":"            except exception.ProcessExecutionError as exc:"},{"line_number":143,"context_line":"                if raw_error:"},{"line_number":144,"context_line":"                    raise"},{"line_number":145,"context_line":"                if logmsg:"},{"line_number":146,"context_line":"                    LOG.error(_LE(\"%s: GlusterFS instrumentation failed.\") %"},{"line_number":147,"context_line":"                              logmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cdae4781","line":144,"range":{"start_line":144,"start_character":20,"end_line":144,"end_character":25},"updated":"2016-01-07 18:32:50.000000000","message":"This path wasn\u0027t hit by a unit test, nor was the following if block.  Given the importance of this method to this patch, I think we should ensure it is fully covered.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"aba72837f0df6182f73ca67c18820e7c5db67a82","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                return gluster_execf(*((\u0027gluster\u0027,) + args), **kwargs)"},{"line_number":142,"context_line":"            except exception.ProcessExecutionError as exc:"},{"line_number":143,"context_line":"                if raw_error:"},{"line_number":144,"context_line":"                    raise"},{"line_number":145,"context_line":"                if logmsg:"},{"line_number":146,"context_line":"                    LOG.error(_LE(\"%s: GlusterFS instrumentation failed.\") %"},{"line_number":147,"context_line":"                              logmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_286280d9","line":144,"in_reply_to":"fa69d971_cdae4781","updated":"2016-01-18 23:53:49.000000000","message":"Done","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        return tuple(numvers)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def _mount_gluster_vol(execute, gluster_export, mount_path, ensure\u003dFalse):"},{"line_number":229,"context_line":"    \"\"\"Mount a GlusterFS volume at the specified mount path."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    :param execute: command exectution function"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ed01cb6b","line":228,"range":{"start_line":228,"start_character":4,"end_line":228,"end_character":22},"updated":"2016-01-07 18:32:50.000000000","message":"Not central to this patch, but this method doesn\u0027t appear to be covered at all with unit tests.  It wouldn\u0027t hurt to add that.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"aba72837f0df6182f73ca67c18820e7c5db67a82","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        return tuple(numvers)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"def _mount_gluster_vol(execute, gluster_export, mount_path, ensure\u003dFalse):"},{"line_number":229,"context_line":"    \"\"\"Mount a GlusterFS volume at the specified mount path."},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    :param execute: command exectution function"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_e8b548d0","line":228,"in_reply_to":"fa69d971_ed01cb6b","updated":"2016-01-18 23:53:49.000000000","message":"\"not covered at all\" is not the case, see the respective tests from\n\nhttps://review.openstack.org/gitweb?p\u003dopenstack/manila.git;a\u003dblob;f\u003dmanila/tests/share/drivers/glusterfs/test_common.py;h\u003d1ab7ac1;hb\u003d360d10#l331\n\ntill\n\nhttps://review.openstack.org/gitweb?p\u003dopenstack/manila.git;a\u003dblob;f\u003dmanila/tests/share/drivers/glusterfs/test_common.py;h\u003d1ab7ac1;hb\u003d360d10#l362\n\nI can\u0027t see now if there is an issue with coverage, as the CI results are not shown because of the merge conflict. I\u0027ll check it after the upcoming update.\n\nAnyway, if there is any issue with that, I\u0027d prefer to keep this patch semantically clean and submit a targeted fix.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"}],"manila/share/drivers/glusterfs/layout_directory.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.gluster_manager.gluster_call(*args)"},{"line_number":151,"context_line":"        except Exception as exc:"},{"line_number":152,"context_line":"            if isinstance(exc, exception.ProcessExecutionError):"},{"line_number":153,"context_line":"                exc \u003d exception.GlusterfsException(exc)"},{"line_number":154,"context_line":"            if isinstance(exc, exception.GlusterfsException):"},{"line_number":155,"context_line":"                self._cleanup_create_share(local_share_path, share[\u0027name\u0027])"},{"line_number":156,"context_line":"                LOG.error(_LE(\u0027Unable to create share %s\u0027), share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2d1603a8","line":153,"range":{"start_line":153,"start_character":22,"end_line":153,"end_character":31},"updated":"2016-01-07 18:32:50.000000000","message":"This line isn\u0027t covered by a unit test.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"aba72837f0df6182f73ca67c18820e7c5db67a82","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self.gluster_manager.gluster_call(*args)"},{"line_number":151,"context_line":"        except Exception as exc:"},{"line_number":152,"context_line":"            if isinstance(exc, exception.ProcessExecutionError):"},{"line_number":153,"context_line":"                exc \u003d exception.GlusterfsException(exc)"},{"line_number":154,"context_line":"            if isinstance(exc, exception.GlusterfsException):"},{"line_number":155,"context_line":"                self._cleanup_create_share(local_share_path, share[\u0027name\u0027])"},{"line_number":156,"context_line":"                LOG.error(_LE(\u0027Unable to create share %s\u0027), share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_be6d46ce","line":153,"range":{"start_line":153,"start_character":22,"end_line":153,"end_character":31},"in_reply_to":"fa69d971_2d1603a8","updated":"2016-01-18 23:53:49.000000000","message":"Done","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"}],"manila/share/drivers/glusterfs/layout_volume.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                logmsg \u003d _LE(\"Retrieving volume list \""},{"line_number":208,"context_line":"                             \"on host %s\") % gluster_mgr.host"},{"line_number":209,"context_line":"            else:"},{"line_number":210,"context_line":"                logmsg \u003d _LE(\"Retrieving volume list\")"},{"line_number":211,"context_line":"            out, err \u003d gluster_mgr.gluster_call(\u0027volume\u0027, \u0027list\u0027, log\u003dlogmsg)"},{"line_number":212,"context_line":"            for volname in out.split(\"\\n\"):"},{"line_number":213,"context_line":"                patmatch \u003d self.volume_pattern.match(volname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ad699327","line":210,"range":{"start_line":210,"start_character":30,"end_line":210,"end_character":40},"updated":"2016-01-07 18:32:50.000000000","message":"This line isn\u0027t covered by a unit test.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"f5ceddea67a2521a3293326b92d0d7c1a246710c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                logmsg \u003d _LE(\"Retrieving volume list \""},{"line_number":208,"context_line":"                             \"on host %s\") % gluster_mgr.host"},{"line_number":209,"context_line":"            else:"},{"line_number":210,"context_line":"                logmsg \u003d _LE(\"Retrieving volume list\")"},{"line_number":211,"context_line":"            out, err \u003d gluster_mgr.gluster_call(\u0027volume\u0027, \u0027list\u0027, log\u003dlogmsg)"},{"line_number":212,"context_line":"            for volname in out.split(\"\\n\"):"},{"line_number":213,"context_line":"                patmatch \u003d self.volume_pattern.match(volname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_324e71c2","line":210,"range":{"start_line":210,"start_character":30,"end_line":210,"end_character":40},"in_reply_to":"fa69d971_ad699327","updated":"2016-01-18 16:13:24.000000000","message":"The uncovered conditional has impact only on the content of the log message. I thought there is a consensus about not testing for log messages.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            args \u003d (\u0027--xml\u0027, \u0027snapshot\u0027, \u0027create\u0027, \u0027manila-\u0027 + snapshot[\u0027id\u0027],"},{"line_number":514,"context_line":"                    gluster_mgr.volume)"},{"line_number":515,"context_line":"            out, err \u003d gluster_mgr.gluster_call("},{"line_number":516,"context_line":"                *args,"},{"line_number":517,"context_line":"                log\u003d_LE(\"Retrieving volume info\"))"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"            if not out:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_61daca19","line":516,"range":{"start_line":516,"start_character":17,"end_line":516,"end_character":21},"updated":"2016-01-07 18:32:50.000000000","message":"No need to wrap here.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"41713d5468077b5356139e584fdbf8aff78a9529","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            args \u003d (\u0027--xml\u0027, \u0027snapshot\u0027, \u0027create\u0027, \u0027manila-\u0027 + snapshot[\u0027id\u0027],"},{"line_number":514,"context_line":"                    gluster_mgr.volume)"},{"line_number":515,"context_line":"            out, err \u003d gluster_mgr.gluster_call("},{"line_number":516,"context_line":"                *args,"},{"line_number":517,"context_line":"                log\u003d_LE(\"Retrieving volume info\"))"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"            if not out:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_de8e0127","line":516,"range":{"start_line":516,"start_character":17,"end_line":516,"end_character":21},"in_reply_to":"fa69d971_61daca19","updated":"2016-01-12 02:25:39.000000000","message":"I\u0027ve consistently wrapped the value of the \"log\" keyword arg with _LE, not just in the indicated two cases, but all the way through the refactor.\n\nDo you debate this practice in general, or  in this particular two cases?\n\n- If in general, why? The value of the \"log\" kwarg is a literal string and (if made use of at all) is used solely for being passed on to LOG.error, so that it would consist a part of the whole error message. So it sounded reasonable to me to expose it to i18n and in particular as part of the error catalogue. It would seem weird to me to find something like \"Tuning GlusterFS volume parameters: noeud de Gluster ne répond pas\" in the log.\n\n- If you mean just these two: in what way are they different than the others?","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":555,"context_line":"        args \u003d (\u0027--xml\u0027, \u0027snapshot\u0027, \u0027delete\u0027, backend_snapshot_name,"},{"line_number":556,"context_line":"                \u0027--mode\u003dscript\u0027)"},{"line_number":557,"context_line":"        out, err \u003d gluster_mgr.gluster_call("},{"line_number":558,"context_line":"            *args,"},{"line_number":559,"context_line":"            log\u003d_LE(\"Error deleting snapshot\"))"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        if not out:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e1fc7a74","line":558,"range":{"start_line":558,"start_character":13,"end_line":558,"end_character":17},"updated":"2016-01-07 18:32:50.000000000","message":"Same","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"}],"manila/share/drivers/glusterfs_native.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2d35a3f6","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":11},"updated":"2016-01-07 18:32:50.000000000","message":"Is there still a compelling reason to keep this file in manila/share/drivers instead of manila/share/drivers/glusterfs?  If you want to move it, the share manager contains a mapping to make such a change backwards compatible.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"41713d5468077b5356139e584fdbf8aff78a9529","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_be39cd43","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":11},"in_reply_to":"fa69d971_2d35a3f6","updated":"2016-01-12 02:25:39.000000000","message":"No, actually I perceive it to be pretty much a nuisance to have it at an irregular location. I just did not know of how to move it backward compatibly. Can you please give a pointer to said share manager mapping mechanism?\n\nAnyway, I intend to do that in a dedicated patch.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"2035be73caf24ff96c8df8c3c855a08ea3cc9301","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        try:"},{"line_number":233,"context_line":"            dynauth \u003d gluster_mgr.get_gluster_vol_option(DYNAMIC_AUTH) or \u0027off\u0027"},{"line_number":234,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":235,"context_line":"            msg \u003d (_(\"Error in querying gluster volume. \""},{"line_number":236,"context_line":"                     \"Volume: %(volname)s, Option: %(option)s, \""},{"line_number":237,"context_line":"                     \"Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cdb40784","line":234,"range":{"start_line":234,"start_character":15,"end_line":234,"end_character":24},"updated":"2016-01-07 18:32:50.000000000","message":"Not central to this patch, but this block isn\u0027t covered by a unit test.  Adding one test here would bring coverage on this file to 100%.","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"aba72837f0df6182f73ca67c18820e7c5db67a82","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        try:"},{"line_number":233,"context_line":"            dynauth \u003d gluster_mgr.get_gluster_vol_option(DYNAMIC_AUTH) or \u0027off\u0027"},{"line_number":234,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":235,"context_line":"            msg \u003d (_(\"Error in querying gluster volume. \""},{"line_number":236,"context_line":"                     \"Volume: %(volname)s, Option: %(option)s, \""},{"line_number":237,"context_line":"                     \"Error: %(error)s\") %"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba63e191_3de2b9d6","line":234,"in_reply_to":"fa69d971_cdb40784","updated":"2016-01-18 23:53:49.000000000","message":"Actually this block is unneeded -- get_gluster_vol_option won\u0027t raise ProcessExecutionError. Thanks for the catch!","commit_id":"360d103ee90ab5b219f1ee9db422f8249dc5a0fa"}]}
