)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ccb1daab449e242997c2ae0ad2f3332b85b69ed6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liuke2 \u003cliuke2@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-05 14:14:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"huawei: ensure that share is exported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ensure share is used when the service starts."},{"line_number":10,"context_line":"ensure share checks the share status on the array"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_c8bc72de","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2016-01-05 12:25:35.000000000","message":"s/huawei/Huawei","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ccb1daab449e242997c2ae0ad2f3332b85b69ed6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ensure share is used when the service starts."},{"line_number":10,"context_line":"ensure share checks the share status on the array"},{"line_number":11,"context_line":"and changes the logical IP from the configuration"},{"line_number":12,"context_line":"file"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Implements: blueprint huawei-driver-ensure-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_68cea683","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"updated":"2016-01-05 12:25:35.000000000","message":"Missing . EOL","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"d799284db3b2311cb531810d5c23d359e720ea3c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"and changes the logical IP from the configuration"},{"line_number":12,"context_line":"file"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Implements: blueprint huawei-driver-ensure-share"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I29d8a5306b88edcbf7bd405da05db1e6da39f41f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_d138a8f1","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2016-01-05 09:24:13.000000000","message":"Is there any DocImpact？","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Ensure that share is exported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure share is used when the service starts."},{"line_number":10,"context_line":"Ensure share checks the share status on the array"},{"line_number":11,"context_line":"and changes the logical IP from the configuration"},{"line_number":12,"context_line":"file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"da6ed579_e391db53","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":37},"updated":"2016-01-16 16:27:42.000000000","message":"share manager service","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei: Ensure that share is exported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure share is used when the service starts."},{"line_number":10,"context_line":"Ensure share checks the share status on the array"},{"line_number":11,"context_line":"and changes the logical IP from the configuration"},{"line_number":12,"context_line":"file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"da6ed579_47bb0176","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":37},"in_reply_to":"da6ed579_e391db53","updated":"2016-01-18 08:46:53.000000000","message":"Done\nThank you for your opinions","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Ensure that share is exported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure share is used when the service starts."},{"line_number":10,"context_line":"Ensure share checks the share status on the array"},{"line_number":11,"context_line":"and changes the logical IP from the configuration"},{"line_number":12,"context_line":"file."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint huawei-driver-ensure-share"},{"line_number":15,"context_line":"Change-Id: I29d8a5306b88edcbf7bd405da05db1e6da39f41f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"da6ed579_23393342","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":5},"updated":"2016-01-16 16:27:42.000000000","message":"I\u0027m not sure I understand this correctly. do you mean that ensure_share verifies the presence of the share on the backend and constructs the export location based on the configuration?","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei: Ensure that share is exported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure share is used when the service starts."},{"line_number":10,"context_line":"Ensure share checks the share status on the array"},{"line_number":11,"context_line":"and changes the logical IP from the configuration"},{"line_number":12,"context_line":"file."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint huawei-driver-ensure-share"},{"line_number":15,"context_line":"Change-Id: I29d8a5306b88edcbf7bd405da05db1e6da39f41f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"da6ed579_22f27b07","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":5},"in_reply_to":"da6ed579_23393342","updated":"2016-01-18 08:46:53.000000000","message":"Thank you,\nThis function check share status on the backend and check whether to change the logic IP from the configuration, when the share has existed on the share manager service.","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"}],"manila/share/drivers/huawei/base.py":[{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"d340509ab57d5d0efc72f927925998fbce73a665","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def update_share_stats(self, stats_dict):"},{"line_number":75,"context_line":"        \"\"\"Retrieve stats info from share group.\"\"\""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def ensure_share(self, share, share_server\u003dNone):"},{"line_number":78,"context_line":"        \"\"\"Ensure that share is exported.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_4eb0958a","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":23},"updated":"2016-01-05 09:06:16.000000000","message":"Should add a blank line","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":133,"context_line":"        \"\"\"Ensure that share is exported.\"\"\""},{"line_number":134,"context_line":"        LOG.debug(\"Ensure share.\")"},{"line_number":135,"context_line":"        location \u003d self.plugin.ensure_share(share, share_server)"},{"line_number":136,"context_line":"        return location"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":139,"context_line":"        \"\"\"Allow access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_1e688486","line":136,"range":{"start_line":135,"start_character":8,"end_line":136,"end_character":23},"updated":"2016-01-05 13:11:05.000000000","message":"can be done in one line:\n\n    return self.plugin.ensure_share(share, share_server)","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"d340509ab57d5d0efc72f927925998fbce73a665","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                (service[\u0027SUPPORTV3\u0027] \u003d\u003d \u0027false\u0027) or"},{"line_number":595,"context_line":"                (service[\u0027SUPPORTV4\u0027] \u003d\u003d \u0027false\u0027)):"},{"line_number":596,"context_line":"            self.helper._start_nfs_service_status()"},{"line_number":597,"context_line":"    def ensure_share(self, share, share_server\u003dNone):"},{"line_number":598,"context_line":"        \"\"\"Ensure that share is exported.\"\"\""},{"line_number":599,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":600,"context_line":"        share_name \u003d share[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_4e7735d3","line":597,"range":{"start_line":597,"start_character":8,"end_line":597,"end_character":20},"updated":"2016-01-05 09:06:16.000000000","message":"Should add a blank line","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        share_storage \u003d self.helper._get_share_by_name(share_name,"},{"line_number":605,"context_line":"                                                       share_url_type)"},{"line_number":606,"context_line":"        if not share_storage:"},{"line_number":607,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"},{"line_number":608,"context_line":"                       % share_export_location)"},{"line_number":609,"context_line":"            LOG.error(err_msg)"},{"line_number":610,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_fe181020","line":607,"range":{"start_line":607,"start_character":26,"end_line":607,"end_character":55},"updated":"2016-01-05 13:11:05.000000000","message":"This message is confusing. Do you mean:\n\n    Cannot get share ID with share name.\n\nor\n\n    Cannot get share ID for share with export location %s.\n\nor\n\n    Share %s does not exist on the backend.\n\n    \n\n?","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ccb1daab449e242997c2ae0ad2f3332b85b69ed6","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        share_storage \u003d self.helper._get_share_by_name(share_name,"},{"line_number":605,"context_line":"                                                       share_url_type)"},{"line_number":606,"context_line":"        if not share_storage:"},{"line_number":607,"context_line":"            err_msg \u003d (_(\"Can not get share ID by share %s.\")"},{"line_number":608,"context_line":"                       % share_export_location)"},{"line_number":609,"context_line":"            LOG.error(err_msg)"},{"line_number":610,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_e8e4d6e1","line":607,"range":{"start_line":607,"start_character":26,"end_line":607,"end_character":33},"updated":"2016-01-05 12:25:35.000000000","message":"s/Can not/Cannot","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":615,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":616,"context_line":"            raise exception.InvalidShare("},{"line_number":617,"context_line":"                reason\u003d(_(\u0027Invalid status of filesystem: \u0027"},{"line_number":618,"context_line":"                          \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":619,"context_line":"                          \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":620,"context_line":"                        % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":621,"context_line":"                           \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]}))"},{"line_number":622,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_be913849","line":619,"range":{"start_line":617,"start_character":26,"end_line":619,"end_character":55},"updated":"2016-01-05 13:11:05.000000000","message":"please define a variable outside. \n\n\n    err_msg \u003d _(\u0027Invalid status of filesystem: \u0027HEALTHSTATUS\u003d%(health)s \u0027\n                   \u0027RUNNINGSTATUS\u003d%(running)s.\u0027) % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],\n                           \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]}\n\n    raise exception.InvalidShare(reason\u003derr_msg)","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3c7e7200463017afe02ce69eca366f20202617f5","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        fs_id \u003d share_storage[\u0027FSID\u0027]"},{"line_number":1220,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"},{"line_number":1221,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1222,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":1223,"context_line":"            err_msg \u003d (_(\u0027Invalid status of filesystem: \u0027"},{"line_number":1224,"context_line":"                         \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":1225,"context_line":"                         \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":1226,"context_line":"                       % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1227,"context_line":"                          \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":1228,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        ip \u003d self._get_share_ip(share_server)"},{"line_number":1231,"context_line":"        location \u003d self._get_location_path(share_name, share_proto, ip)"},{"line_number":1232,"context_line":"        return [location]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_94ee17eb","line":1231,"range":{"start_line":1220,"start_character":8,"end_line":1231,"end_character":71},"updated":"2016-01-12 11:29:57.000000000","message":"From what I see here, you are not doing anything to fix the share in case it is not available, like re-exporting the share, mounting a file-system, etc. You are just updating the export path with the one in storage, or throwing an exception in case the share is not available. This is ok, but I would recommend trying to fix the unhealthy status if there is a way to do so.","commit_id":"1f959892b6e4ff886c198987a7781a860601bf7d"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"29357c2e5717b8795aa0b428dd591a3913a1226a","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        fs_id \u003d share_storage[\u0027FSID\u0027]"},{"line_number":1220,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"},{"line_number":1221,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1222,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":1223,"context_line":"            err_msg \u003d (_(\u0027Invalid status of filesystem: \u0027"},{"line_number":1224,"context_line":"                         \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":1225,"context_line":"                         \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":1226,"context_line":"                       % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1227,"context_line":"                          \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":1228,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        ip \u003d self._get_share_ip(share_server)"},{"line_number":1231,"context_line":"        location \u003d self._get_location_path(share_name, share_proto, ip)"},{"line_number":1232,"context_line":"        return [location]"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_2ad02053","line":1231,"range":{"start_line":1220,"start_character":8,"end_line":1231,"end_character":71},"in_reply_to":"da6ed579_94ee17eb","updated":"2016-01-12 12:50:57.000000000","message":"Thank you for your comments. When ensure share has checked the problems, these problems are array problems. As software can not repair the underlying hardware problem. So, the unhealthy status is keep until the array recovery.","commit_id":"1f959892b6e4ff886c198987a7781a860601bf7d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"93304d33f5269dd5392b387699e298317bd8c7e7","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"            err_msg \u003d (_(\"Cannot get storage share by share name %s.\")"},{"line_number":1228,"context_line":"                       % share_name)"},{"line_number":1229,"context_line":"            LOG.error(err_msg)"},{"line_number":1230,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"        fs_id \u003d share_storage[\u0027FSID\u0027]"},{"line_number":1233,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_7d3383f6","line":1230,"range":{"start_line":1230,"start_character":28,"end_line":1230,"end_character":40},"updated":"2016-01-15 10:24:44.000000000","message":"Why Invalid? Maybe NotFound?","commit_id":"c64075c913e6862606923e48a99785d200c012eb"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"65b1adaed3335c31c79d2a0c6fe0c871f78e244b","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"            err_msg \u003d (_(\"Cannot get storage share by share name %s.\")"},{"line_number":1228,"context_line":"                       % share_name)"},{"line_number":1229,"context_line":"            LOG.error(err_msg)"},{"line_number":1230,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"        fs_id \u003d share_storage[\u0027FSID\u0027]"},{"line_number":1233,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_37e17ad1","line":1230,"range":{"start_line":1230,"start_character":28,"end_line":1230,"end_character":40},"in_reply_to":"da6ed579_7d3383f6","updated":"2016-01-16 05:40:59.000000000","message":"Done\nThank you for your opinions","commit_id":"c64075c913e6862606923e48a99785d200c012eb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"93304d33f5269dd5392b387699e298317bd8c7e7","unresolved":false,"context_lines":[{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"        ip \u003d self._get_share_ip(share_server)"},{"line_number":1244,"context_line":"        location \u003d self._get_location_path(share_name, share_proto, ip)"},{"line_number":1245,"context_line":"        return [location]"}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_3d774ba1","line":1245,"range":{"start_line":1245,"start_character":8,"end_line":1245,"end_character":25},"updated":"2016-01-15 10:24:44.000000000","message":"Why do you need to return export location?","commit_id":"c64075c913e6862606923e48a99785d200c012eb"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"65b1adaed3335c31c79d2a0c6fe0c871f78e244b","unresolved":false,"context_lines":[{"line_number":1242,"context_line":""},{"line_number":1243,"context_line":"        ip \u003d self._get_share_ip(share_server)"},{"line_number":1244,"context_line":"        location \u003d self._get_location_path(share_name, share_proto, ip)"},{"line_number":1245,"context_line":"        return [location]"}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_46bd6301","line":1245,"range":{"start_line":1245,"start_character":8,"end_line":1245,"end_character":25},"in_reply_to":"da6ed579_3d774ba1","updated":"2016-01-16 05:40:59.000000000","message":"Thank you, this return Share\u0027s new Path List. For example,  logic IP is changed in the configuration file, share need to return the new path of the mount poi. The new path need to be recorded in the DB.","commit_id":"c64075c913e6862606923e48a99785d200c012eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"        share_storage \u003d self.helper._get_share_by_name(share_name,"},{"line_number":1226,"context_line":"                                                       share_url_type)"},{"line_number":1227,"context_line":"        if not share_storage:"},{"line_number":1228,"context_line":"            raise exception.ShareResourceNotFound(share_id)"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        fs_id \u003d share_storage[\u0027FSID\u0027]"},{"line_number":1231,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_83025fb3","line":1228,"range":{"start_line":1228,"start_character":50,"end_line":1228,"end_character":58},"updated":"2016-01-16 16:27:42.000000000","message":"share_id\u003dshare_id","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"        share_storage \u003d self.helper._get_share_by_name(share_name,"},{"line_number":1226,"context_line":"                                                       share_url_type)"},{"line_number":1227,"context_line":"        if not share_storage:"},{"line_number":1228,"context_line":"            raise exception.ShareResourceNotFound(share_id)"},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"        fs_id \u003d share_storage[\u0027FSID\u0027]"},{"line_number":1231,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_82d48747","line":1228,"range":{"start_line":1228,"start_character":50,"end_line":1228,"end_character":58},"in_reply_to":"da6ed579_83025fb3","updated":"2016-01-18 08:46:53.000000000","message":"Done\nThank you for your opinions","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"},{"line_number":1232,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1233,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":1234,"context_line":"            err_msg \u003d (_(\u0027Invalid status of filesystem: \u0027"},{"line_number":1235,"context_line":"                         \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":1236,"context_line":"                         \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":1237,"context_line":"                       % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1238,"context_line":"                          \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":1239,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        ip \u003d self._get_share_ip(share_server)"},{"line_number":1242,"context_line":"        location \u003d self._get_location_path(share_name, share_proto, ip)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_83ac9f8d","line":1239,"range":{"start_line":1234,"start_character":0,"end_line":1239,"end_character":56},"updated":"2016-01-16 16:27:42.000000000","message":"seen this exception in multiple places. Would like to understand it more... You seem to be checking for the status of the volume on the backend... if this is the case, I suggest that you define a new exception in manila/exception.py derived from ManilaException and pull this common logic into another method for reuse.. \n\n\nOne other use:\nhttps://review.openstack.org/#/c/259917/14/manila/share/drivers/huawei/v3/connection.py","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":1231,"context_line":"        fs \u003d self.helper._get_fs_info_by_id(fs_id)"},{"line_number":1232,"context_line":"        if not self.check_fs_status(fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1233,"context_line":"                                    fs[\u0027RUNNINGSTATUS\u0027]):"},{"line_number":1234,"context_line":"            err_msg \u003d (_(\u0027Invalid status of filesystem: \u0027"},{"line_number":1235,"context_line":"                         \u0027HEALTHSTATUS\u003d%(health)s \u0027"},{"line_number":1236,"context_line":"                         \u0027RUNNINGSTATUS\u003d%(running)s.\u0027)"},{"line_number":1237,"context_line":"                       % {\u0027health\u0027: fs[\u0027HEALTHSTATUS\u0027],"},{"line_number":1238,"context_line":"                          \u0027running\u0027: fs[\u0027RUNNINGSTATUS\u0027]})"},{"line_number":1239,"context_line":"            raise exception.InvalidShare(reason\u003derr_msg)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"        ip \u003d self._get_share_ip(share_server)"},{"line_number":1242,"context_line":"        location \u003d self._get_location_path(share_name, share_proto, ip)"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_a72af4e5","line":1239,"range":{"start_line":1234,"start_character":0,"end_line":1239,"end_character":56},"in_reply_to":"da6ed579_83ac9f8d","updated":"2016-01-18 08:46:53.000000000","message":"Done","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"               \"path\": [\"\\\\\\\\100.115.10.68\\\\share_fake_uuid\"]})"},{"line_number":1537,"context_line":"    @ddt.unpack"},{"line_number":1538,"context_line":"    def test_ensure_share_sucess(self, share_proto, path):"},{"line_number":1539,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":1540,"context_line":"            share \u003d self.share_nfs"},{"line_number":1541,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1542,"context_line":"            share \u003d self.share_cifs"},{"line_number":1543,"context_line":""},{"line_number":1544,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1545,"context_line":"        location \u003d self.driver.ensure_share(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9e86b4d9","line":1542,"range":{"start_line":1539,"start_character":8,"end_line":1542,"end_character":35},"updated":"2016-01-05 13:11:05.000000000","message":"same as below","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":1552,"context_line":"              {\"share_proto\": \"CIFS\","},{"line_number":1553,"context_line":"               \"path\": [\"\\\\\\\\111.111.111.109\\\\share_fake_uuid\"]})"},{"line_number":1554,"context_line":"    @ddt.unpack"},{"line_number":1555,"context_line":"    @dec_driver_handles_share_servers"},{"line_number":1556,"context_line":"    def test_ensure_share_with_share_server_sucess(self, share_proto, path):"},{"line_number":1557,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":1558,"context_line":"            share \u003d self.share_nfs"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_de0bcc8c","line":1555,"range":{"start_line":1555,"start_character":4,"end_line":1555,"end_character":37},"updated":"2016-01-05 13:11:05.000000000","message":"Where is this coming from?","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1560,"context_line":"            share \u003d self.share_cifs"},{"line_number":1561,"context_line":"        backend_details \u003d self.driver.setup_server(self.fake_network_info)"},{"line_number":1562,"context_line":"        fake_share_server \u003d {"},{"line_number":1563,"context_line":"            \u0027backend_details\u0027: backend_details"},{"line_number":1564,"context_line":"        }"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1567,"context_line":"        location \u003d self.driver.ensure_share(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_9e5d547b","line":1564,"range":{"start_line":1562,"start_character":8,"end_line":1564,"end_character":9},"updated":"2016-01-05 13:11:05.000000000","message":"please condense to same line.","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"15a39e9c991397325d5b546dc94aabc001444b23","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"              {\"share_proto\": \"CIFS\"})"},{"line_number":1574,"context_line":"    @ddt.unpack"},{"line_number":1575,"context_line":"    def test_ensure_share_get_share_fail(self, share_proto):"},{"line_number":1576,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":1577,"context_line":"            share \u003d self.share_nfs"},{"line_number":1578,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1579,"context_line":"            share \u003d self.share_cifs"},{"line_number":1580,"context_line":"        self.mock_object(self.driver.plugin.helper,"},{"line_number":1581,"context_line":"                         \u0027_get_share_by_name\u0027,"},{"line_number":1582,"context_line":"                         mock.Mock(return_value\u003d{}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_5e26fc15","line":1579,"range":{"start_line":1576,"start_character":8,"end_line":1579,"end_character":35},"updated":"2016-01-05 13:11:05.000000000","message":"This could be\n\n    share \u003d self.share_nfs if share_proto \u003d\u003d \"NFS\" else self.share_ifs","commit_id":"2ef17f17dd2403c999fb72a19113f839459f84de"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"c0eef31a3f85b43d2e5f8800905ff3b0f5b404ef","unresolved":false,"context_lines":[{"line_number":1428,"context_line":""},{"line_number":1429,"context_line":"    def test_deny_access_nfs_fail(self):"},{"line_number":1430,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":1431,"context_line":"        access_ip_not_exist \u003d {"},{"line_number":1432,"context_line":"            \u0027access_type\u0027: \u0027ip\u0027,"},{"line_number":1433,"context_line":"            \u0027access_to\u0027: \u0027100.112.0.99\u0027,"},{"line_number":1434,"context_line":"            \u0027access_level\u0027: \u0027rw\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_28aa7e1a","line":1431,"range":{"start_line":1431,"start_character":8,"end_line":1431,"end_character":27},"updated":"2016-01-12 04:14:53.000000000","message":"\u0027access_ip_not_exist\u0027 is not used.","commit_id":"245d0e5408cec070edc70553d3fd99e533dfffd8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6be11eb1d5a6fc794157c64266f82e6a0855cbb3","unresolved":false,"context_lines":[{"line_number":2688,"context_line":"               \"path\": [\"\\\\\\\\100.115.10.68\\\\share_fake_uuid\"]})"},{"line_number":2689,"context_line":"    @ddt.unpack"},{"line_number":2690,"context_line":"    def test_ensure_share_sucess(self, share_proto, path):"},{"line_number":2691,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":2692,"context_line":"            share \u003d self.share_nfs"},{"line_number":2693,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":2694,"context_line":"            share \u003d self.share_cifs"},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2697,"context_line":"        location \u003d self.driver.ensure_share(self._context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_99ef30b0","line":2694,"range":{"start_line":2691,"start_character":8,"end_line":2694,"end_character":35},"updated":"2016-01-12 11:23:43.000000000","message":"Should promote this and re-use it instead of copying it.","commit_id":"1f959892b6e4ff886c198987a7781a860601bf7d"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"29357c2e5717b8795aa0b428dd591a3913a1226a","unresolved":false,"context_lines":[{"line_number":2688,"context_line":"               \"path\": [\"\\\\\\\\100.115.10.68\\\\share_fake_uuid\"]})"},{"line_number":2689,"context_line":"    @ddt.unpack"},{"line_number":2690,"context_line":"    def test_ensure_share_sucess(self, share_proto, path):"},{"line_number":2691,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":2692,"context_line":"            share \u003d self.share_nfs"},{"line_number":2693,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":2694,"context_line":"            share \u003d self.share_cifs"},{"line_number":2695,"context_line":""},{"line_number":2696,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2697,"context_line":"        location \u003d self.driver.ensure_share(self._context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_c8c14b30","line":2694,"range":{"start_line":2691,"start_character":8,"end_line":2694,"end_character":35},"in_reply_to":"da6ed579_99ef30b0","updated":"2016-01-12 12:50:57.000000000","message":"Done","commit_id":"1f959892b6e4ff886c198987a7781a860601bf7d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6be11eb1d5a6fc794157c64266f82e6a0855cbb3","unresolved":false,"context_lines":[{"line_number":2706,"context_line":"    @ddt.unpack"},{"line_number":2707,"context_line":"    @dec_driver_handles_share_servers"},{"line_number":2708,"context_line":"    def test_ensure_share_with_share_server_sucess(self, share_proto, path):"},{"line_number":2709,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":2710,"context_line":"            share \u003d self.share_nfs"},{"line_number":2711,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":2712,"context_line":"            share \u003d self.share_cifs"},{"line_number":2713,"context_line":"        backend_details \u003d self.driver.setup_server(self.fake_network_info)"},{"line_number":2714,"context_line":"        fake_share_server \u003d {\u0027backend_details\u0027: backend_details}"},{"line_number":2715,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_d93cc831","line":2712,"range":{"start_line":2709,"start_character":8,"end_line":2712,"end_character":35},"updated":"2016-01-12 11:23:43.000000000","message":"same, Use a function instead of this.","commit_id":"1f959892b6e4ff886c198987a7781a860601bf7d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6be11eb1d5a6fc794157c64266f82e6a0855cbb3","unresolved":false,"context_lines":[{"line_number":2723,"context_line":"              {\"share_proto\": \"CIFS\"})"},{"line_number":2724,"context_line":"    @ddt.unpack"},{"line_number":2725,"context_line":"    def test_ensure_share_get_share_fail(self, share_proto):"},{"line_number":2726,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":2727,"context_line":"            share \u003d self.share_nfs"},{"line_number":2728,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":2729,"context_line":"            share \u003d self.share_cifs"},{"line_number":2730,"context_line":"        self.mock_object(self.driver.plugin.helper,"},{"line_number":2731,"context_line":"                         \u0027_get_share_by_name\u0027,"},{"line_number":2732,"context_line":"                         mock.Mock(return_value\u003d{}))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_191100ad","line":2729,"range":{"start_line":2726,"start_character":8,"end_line":2729,"end_character":35},"updated":"2016-01-12 11:23:43.000000000","message":"same","commit_id":"1f959892b6e4ff886c198987a7781a860601bf7d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"93304d33f5269dd5392b387699e298317bd8c7e7","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"        }"},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"    def _get_share_by_proto(self, share_proto):"},{"line_number":1076,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":1077,"context_line":"            share \u003d self.share_nfs"},{"line_number":1078,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1079,"context_line":"            share \u003d self.share_cifs"},{"line_number":1080,"context_line":"        return share"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"    def test_conf_product_fail(self):"},{"line_number":1083,"context_line":"        self.recreate_fake_conf_file(product_flag\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_fd7a1376","line":1080,"range":{"start_line":1076,"start_character":8,"end_line":1080,"end_character":20},"updated":"2016-01-15 10:24:44.000000000","message":"Not safe programming. Should be \"else\" clause, without it we can get \"NameError\" where \"share\" var not defined.","commit_id":"c64075c913e6862606923e48a99785d200c012eb"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"65b1adaed3335c31c79d2a0c6fe0c871f78e244b","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"        }"},{"line_number":1074,"context_line":""},{"line_number":1075,"context_line":"    def _get_share_by_proto(self, share_proto):"},{"line_number":1076,"context_line":"        if share_proto \u003d\u003d \"NFS\":"},{"line_number":1077,"context_line":"            share \u003d self.share_nfs"},{"line_number":1078,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1079,"context_line":"            share \u003d self.share_cifs"},{"line_number":1080,"context_line":"        return share"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"    def test_conf_product_fail(self):"},{"line_number":1083,"context_line":"        self.recreate_fake_conf_file(product_flag\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_1c86dc65","line":1080,"range":{"start_line":1076,"start_character":8,"end_line":1080,"end_character":20},"in_reply_to":"da6ed579_fd7a1376","updated":"2016-01-16 05:40:59.000000000","message":"Done.\nThank you for your opinions","commit_id":"c64075c913e6862606923e48a99785d200c012eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1079,"context_line":"            share \u003d self.share_cifs"},{"line_number":1080,"context_line":"        else:"},{"line_number":1081,"context_line":"            err_msg \u003d (_(\"Get the share_proto is error protocol.\"))"},{"line_number":1082,"context_line":"            self.assertRaises(exception.InvalidShare(reason\u003derr_msg))"},{"line_number":1083,"context_line":"        return share"},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_c3cdb787","line":1081,"range":{"start_line":1081,"start_character":26,"end_line":1081,"end_character":64},"updated":"2016-01-16 16:27:42.000000000","message":"_(\"Invalid share protocol: %(share_proto)s. share_proto can be either \u0027NFS\u0027 or \u0027CIFS\u0027.\") % {\u0027share_proto\u0027: share_proto)","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"        elif share_proto \u003d\u003d \"CIFS\":"},{"line_number":1079,"context_line":"            share \u003d self.share_cifs"},{"line_number":1080,"context_line":"        else:"},{"line_number":1081,"context_line":"            err_msg \u003d (_(\"Get the share_proto is error protocol.\"))"},{"line_number":1082,"context_line":"            self.assertRaises(exception.InvalidShare(reason\u003derr_msg))"},{"line_number":1083,"context_line":"        return share"},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_18c9e8ac","line":1081,"range":{"start_line":1081,"start_character":26,"end_line":1081,"end_character":64},"in_reply_to":"da6ed579_c3cdb787","updated":"2016-01-18 08:46:53.000000000","message":"Thank you for your opinions,\nThis error message is removed","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"            share \u003d self.share_cifs"},{"line_number":1080,"context_line":"        else:"},{"line_number":1081,"context_line":"            err_msg \u003d (_(\"Get the share_proto is error protocol.\"))"},{"line_number":1082,"context_line":"            self.assertRaises(exception.InvalidShare(reason\u003derr_msg))"},{"line_number":1083,"context_line":"        return share"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def test_conf_product_fail(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_c3e61716","line":1082,"range":{"start_line":1082,"start_character":12,"end_line":1082,"end_character":69},"updated":"2016-01-16 16:27:42.000000000","message":"This is not a test... do you mean to raise this exception?\n\nThis is a unit test helper method, i suggest remove this exception altogether because you always know what you are testing for... You should not be raising exceptions in the test code.","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"            share \u003d self.share_cifs"},{"line_number":1080,"context_line":"        else:"},{"line_number":1081,"context_line":"            err_msg \u003d (_(\"Get the share_proto is error protocol.\"))"},{"line_number":1082,"context_line":"            self.assertRaises(exception.InvalidShare(reason\u003derr_msg))"},{"line_number":1083,"context_line":"        return share"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"    def test_conf_product_fail(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_d8959088","line":1082,"range":{"start_line":1082,"start_character":12,"end_line":1082,"end_character":69},"in_reply_to":"da6ed579_c3e61716","updated":"2016-01-18 08:46:53.000000000","message":"Done\nThank you for your opinions","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e81dad5847553ac533fc8555eeb0275dd02c57ed","unresolved":false,"context_lines":[{"line_number":2715,"context_line":"    @ddt.unpack"},{"line_number":2716,"context_line":"    def test_ensure_share_sucess(self, share_proto, path):"},{"line_number":2717,"context_line":"        share \u003d self._get_share_by_proto(share_proto)"},{"line_number":2718,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2719,"context_line":"        location \u003d self.driver.ensure_share(self._context,"},{"line_number":2720,"context_line":"                                            share,"},{"line_number":2721,"context_line":"                                            self.share_server)"},{"line_number":2722,"context_line":"        self.assertEqual(path, location)"},{"line_number":2723,"context_line":""},{"line_number":2724,"context_line":"    @ddt.data({\"share_proto\": \"NFS\","},{"line_number":2725,"context_line":"               \"path\": [\"111.111.111.109:/share_fake_uuid\"]},"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_c3c9375c","line":2722,"range":{"start_line":2718,"start_character":8,"end_line":2722,"end_character":40},"updated":"2016-01-16 16:27:42.000000000","message":"please separate the asserts in this file with the following spacing.. makes for more readable code.. \n\n    some_setup_code\n    more_setup_code\n    \n    actual_method_call_that_you_are_testing\n    \n    some_assertion_1\n    some_assertion_2\n\n\n\nor\n\n    some_setup_code\n    more_setup_code\n    \n    assertRaises(some_exception, actual_method_call, params)\n    other_assertion_1\n    other_assertion_2","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"},{"author":{"_account_id":17717,"name":"liuke","email":"liuke2@huawei.com","username":"liuke"},"change_message_id":"5bf92767388159ba95211a603449e939e1f209a8","unresolved":false,"context_lines":[{"line_number":2715,"context_line":"    @ddt.unpack"},{"line_number":2716,"context_line":"    def test_ensure_share_sucess(self, share_proto, path):"},{"line_number":2717,"context_line":"        share \u003d self._get_share_by_proto(share_proto)"},{"line_number":2718,"context_line":"        self.driver.plugin.helper.login()"},{"line_number":2719,"context_line":"        location \u003d self.driver.ensure_share(self._context,"},{"line_number":2720,"context_line":"                                            share,"},{"line_number":2721,"context_line":"                                            self.share_server)"},{"line_number":2722,"context_line":"        self.assertEqual(path, location)"},{"line_number":2723,"context_line":""},{"line_number":2724,"context_line":"    @ddt.data({\"share_proto\": \"NFS\","},{"line_number":2725,"context_line":"               \"path\": [\"111.111.111.109:/share_fake_uuid\"]},"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_d87b5028","line":2722,"range":{"start_line":2718,"start_character":8,"end_line":2722,"end_character":40},"in_reply_to":"da6ed579_c3c9375c","updated":"2016-01-18 08:46:53.000000000","message":"Done","commit_id":"cf10009c40c4f6c65e66fb5bcf1793dd76cbb2f9"}]}
