)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f580e8c82ab23d6285f39586885627dd58913d1a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nidhimittalhada \u003cnidhimittal19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-08 15:14:13 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend share does not work gives error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extend share is currently not working. When trying to"},{"line_number":10,"context_line":"extend a share, manila raises an error telling that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_1490ae94","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"updated":"2016-01-08 10:16:17.000000000","message":"Fix \u0027extend\u0027 API for 2.7+ microversions","commit_id":"344e2bec6a2c3e8951cefe9b389064c74627f878"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f580e8c82ab23d6285f39586885627dd58913d1a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extend share does not work gives error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extend share is currently not working. When trying to"},{"line_number":10,"context_line":"extend a share, manila raises an error telling that"},{"line_number":11,"context_line":"the new share size must be an integer. Made the correction."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_345052d4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":38},"updated":"2016-01-08 10:16:17.000000000","message":"It does not work in specific cases, not always. Commit message does not describe why it was not working and was done to fix it.","commit_id":"344e2bec6a2c3e8951cefe9b389064c74627f878"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f580e8c82ab23d6285f39586885627dd58913d1a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extend share is currently not working. When trying to"},{"line_number":10,"context_line":"extend a share, manila raises an error telling that"},{"line_number":11,"context_line":"the new share size must be an integer. Made the correction."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I700581d815da0fdd6addedc42f3e2ba528680e60"},{"line_number":14,"context_line":"Closes-Bug: #1531536"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_d4cf76b1","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":59},"updated":"2016-01-08 10:16:17.000000000","message":"Ambigious statement.","commit_id":"344e2bec6a2c3e8951cefe9b389064c74627f878"}],"manila/api/v1/shares.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"d30b69918575caa27e1352a0c8fa570bcee6acc6","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        try:"},{"line_number":465,"context_line":"            size \u003d int(body.get(body.get(action,"},{"line_number":466,"context_line":"                                         action.split(\u0027os-\u0027)[-1]))[\u0027new_size\u0027])"},{"line_number":467,"context_line":"        except (KeyError, ValueError, TypeError):"},{"line_number":468,"context_line":"            msg \u003d _(\"New share size must be specified as an integer.\")"},{"line_number":469,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b929eb39","line":466,"range":{"start_line":465,"start_character":1,"end_line":466,"end_character":1},"updated":"2016-01-07 12:01:22.000000000","message":"This doesn\u0027t look like the right solution. Works for microversions \u003e\u003d 2.7, but when tested with --os-share-api 2.6 and it\u0027s failing.","commit_id":"af8c8453c45e4fa19d096221b19d72cbe905d746"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f580e8c82ab23d6285f39586885627dd58913d1a","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        try:"},{"line_number":465,"context_line":"            size \u003d int(body.get(action,"},{"line_number":466,"context_line":"                                body.get(action.split(\u0027os-\u0027)[-1]))[\u0027new_size\u0027])"},{"line_number":467,"context_line":"        except (KeyError, ValueError, TypeError):"},{"line_number":468,"context_line":"            msg \u003d _(\"New share size must be specified as an integer.\")"},{"line_number":469,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_f484fa5d","line":466,"range":{"start_line":465,"start_character":32,"end_line":466,"end_character":79},"updated":"2016-01-08 10:16:17.000000000","message":"Each bugfix should be performed with test coverage that works with bugfix and fails without it. And in current case it is not a problem.","commit_id":"344e2bec6a2c3e8951cefe9b389064c74627f878"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d0f061d6a7c3a9b263c4c4686a7ab3e14a404eb5","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dsix.text_type(e))"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        try:"},{"line_number":465,"context_line":"            size \u003d int(body.get(action,"},{"line_number":466,"context_line":"                                body.get(action.split(\u0027os-\u0027)[-1]))[\u0027new_size\u0027])"},{"line_number":467,"context_line":"        except (KeyError, ValueError, TypeError):"},{"line_number":468,"context_line":"            msg \u003d _(\"New share size must be specified as an integer.\")"},{"line_number":469,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_149f4e60","line":466,"range":{"start_line":465,"start_character":32,"end_line":466,"end_character":79},"in_reply_to":"fa69d971_f484fa5d","updated":"2016-01-08 10:17:11.000000000","message":"...not a problem to add such test coverage.","commit_id":"344e2bec6a2c3e8951cefe9b389064c74627f878"}],"manila_tempest_tests/tests/api/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d1cc7c8091227101292b0bbdb9015b358b621f73","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        self.assertEqual(share_get[\u0027size\u0027], new_size, msg)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Delete share"},{"line_number":98,"context_line":"        self.shares_v2_client.delete_share(share_get[\u0027id\u0027])"},{"line_number":99,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":100,"context_line":"            share_id\u003dshare_get[\u0027id\u0027])"},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":103,"context_line":"                          share_get[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":106,"context_line":"    def test_shrink_share(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_fe4b30af","line":103,"range":{"start_line":97,"start_character":8,"end_line":103,"end_character":42},"updated":"2016-01-11 09:54:20.000000000","message":"1) Lines 97-103 are redundant, it is not point of the test. Same for 128-134.\n\n2) It is incorrect test module for such tests. \"manila_tempest_tests/tests/api/test_shares_actions.py\" already has tests with v1. And this module should be updated to use v2.","commit_id":"ff95790460cf51cd316c14c8d1c173dc99569d33"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"26df6373ac3ac944723a01995cd6e6889f29b9dd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        self.assertEqual(share_get[\u0027size\u0027], new_size, msg)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Delete share"},{"line_number":98,"context_line":"        self.shares_v2_client.delete_share(share_get[\u0027id\u0027])"},{"line_number":99,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":100,"context_line":"            share_id\u003dshare_get[\u0027id\u0027])"},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":103,"context_line":"                          share_get[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":106,"context_line":"    def test_shrink_share(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_74551fc0","line":103,"range":{"start_line":97,"start_character":8,"end_line":103,"end_character":42},"in_reply_to":"fa69d971_346a47b4","updated":"2016-01-11 10:22:56.000000000","message":"1) All shares created using \"self.create_share\" method are autodeleted.\n\n2) Yes.","commit_id":"ff95790460cf51cd316c14c8d1c173dc99569d33"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"c55d4c02b19088ace434e29e8e27e0997439442f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        self.assertEqual(share_get[\u0027size\u0027], new_size, msg)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Delete share"},{"line_number":98,"context_line":"        self.shares_v2_client.delete_share(share_get[\u0027id\u0027])"},{"line_number":99,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":100,"context_line":"            share_id\u003dshare_get[\u0027id\u0027])"},{"line_number":101,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":102,"context_line":"                          self.shares_v2_client.get_share,"},{"line_number":103,"context_line":"                          share_get[\u0027id\u0027])"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":106,"context_line":"    def test_shrink_share(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_346a47b4","line":103,"range":{"start_line":97,"start_character":8,"end_line":103,"end_character":42},"in_reply_to":"fa69d971_fe4b30af","updated":"2016-01-11 10:20:28.000000000","message":"Hi Valeriy,\n\n1) you say lines 97 to 103... but line 97 98 is reqd to delete share created.. clean up, isnt it?\nrest i understand, can be removed.\n\n2)did not understand comment 2, you mean i should not write this test here, instead i should just edit/update already written test in \"manila_tempest_tests/tests/api/test_shares_actions.py ?  right ??","commit_id":"ff95790460cf51cd316c14c8d1c173dc99569d33"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4fcbb5b78d2d4ac0a957645c82627f39a5da7f80","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":471,"context_line":"    def test_extend_share(self):"},{"line_number":472,"context_line":"        share \u003d self.create_share(size\u003d1, cleanup_in_class\u003dFalse)"},{"line_number":473,"context_line":"        share_instances \u003d self.shares_v2_client.get_instances_of_share("},{"line_number":474,"context_line":"            share[\u0027id\u0027])"},{"line_number":475,"context_line":"        si \u003d share_instances[0]"},{"line_number":476,"context_line":"        new_size \u003d 2"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_98a793a6","line":473,"range":{"start_line":473,"start_character":48,"end_line":473,"end_character":70},"updated":"2016-01-11 16:11:57.000000000","message":"1) Share instances APIs are admin-only. That is why you get \"403\" response code.\n\n2) No need to call here share instances APIs. \"Share\" APIs should be enough. Same below.","commit_id":"7e93c4afaeb707be09fefa53151b88e2dfd20240"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"dc33222687578a8b58b91b0dcd07239fc9f009ef","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        \"Share extend tests are disabled.\")"},{"line_number":471,"context_line":"    def test_extend_share(self):"},{"line_number":472,"context_line":"        share \u003d self.create_share(size\u003d1, cleanup_in_class\u003dFalse)"},{"line_number":473,"context_line":"        share_instances \u003d self.shares_v2_client.get_instances_of_share("},{"line_number":474,"context_line":"            share[\u0027id\u0027])"},{"line_number":475,"context_line":"        si \u003d share_instances[0]"},{"line_number":476,"context_line":"        new_size \u003d 2"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_c6f2b306","line":473,"range":{"start_line":473,"start_character":48,"end_line":473,"end_character":70},"in_reply_to":"fa69d971_98a793a6","updated":"2016-01-12 05:10:41.000000000","message":"Hi Valeriy,\n\nActually, v2 client has only function, wait_for_share_instance_status() which takes instance id not share id...for using that func i had to obtain share instance...\nwhat to do ? shud i use v1 client\u0027s wait_for_share_Status function here?\n\nor shud i write the wait_for_share_status a new function in client ?","commit_id":"7e93c4afaeb707be09fefa53151b88e2dfd20240"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"299112315341ff284c46c9281f79faa75297d1d9","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                \"actual\": share_get[\u0027size\u0027],"},{"line_number":486,"context_line":"            }"},{"line_number":487,"context_line":"        )"},{"line_number":488,"context_line":"        self.assertEqual(share_get[\u0027size\u0027], new_size, msg)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":491,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_112b1eed","line":488,"range":{"start_line":488,"start_character":25,"end_line":488,"end_character":42},"updated":"2016-01-12 09:47:56.000000000","message":"assert(expected, actual[, msg])","commit_id":"dd3ce7528a9024556c63c7400b71f95a93bbb270"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"299112315341ff284c46c9281f79faa75297d1d9","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                \"actual\": share_get[\u0027size\u0027],"},{"line_number":509,"context_line":"            }"},{"line_number":510,"context_line":"        )"},{"line_number":511,"context_line":"        self.assertEqual(share_get[\u0027size\u0027], new_size, msg)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"class SharesRenameTest(base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_3130a256","line":511,"updated":"2016-01-12 09:47:56.000000000","message":"assert(expected, actual[, msg])","commit_id":"dd3ce7528a9024556c63c7400b71f95a93bbb270"}]}
