)]}'
{"manila/share/drivers/hitachi/hds_hnas.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"66a65c94a939fa50d535826e678bc06b8e88ea51","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":431,"context_line":"        \"\"\"Shinks a share to new size."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        :param share: Share that will be shrinked."},{"line_number":434,"context_line":"        :param new_size: New size of share."},{"line_number":435,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":436,"context_line":"        Not used by this driver."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_2fda094c","line":433,"range":{"start_line":433,"start_character":41,"end_line":433,"end_character":49},"updated":"2016-01-09 13:33:21.000000000","message":"s/shrinked/\"shrunk\"?","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"66a65c94a939fa50d535826e678bc06b8e88ea51","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        self._shrink_share(share_id, share[\u0027size\u0027], new_size)"},{"line_number":448,"context_line":"        LOG.info(_LI(\"Share %(shr_id)s successfully shrinked to \""},{"line_number":449,"context_line":"                     \"%(shr_size)s.\"),"},{"line_number":450,"context_line":"                 {\u0027shr_id\u0027: six.text_type(share[\u0027id\u0027]),"},{"line_number":451,"context_line":"                  \u0027shr_size\u0027: six.text_type(new_size)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_2fb1a901","line":448,"range":{"start_line":448,"start_character":52,"end_line":448,"end_character":60},"updated":"2016-01-09 13:33:21.000000000","message":"s/shrinked/\"shrunk\"?","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e555c455ca3807f716c4186ad61e41e4a6082dc6","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        self._shrink_share(share_id, share[\u0027size\u0027], new_size)"},{"line_number":448,"context_line":"        LOG.info(_LI(\"Share %(shr_id)s successfully shrinked to \""},{"line_number":449,"context_line":"                     \"%(shr_size)s.\"),"},{"line_number":450,"context_line":"                 {\u0027shr_id\u0027: six.text_type(share[\u0027id\u0027]),"},{"line_number":451,"context_line":"                  \u0027shr_size\u0027: six.text_type(new_size)})"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_e395fb3f","line":449,"range":{"start_line":449,"start_character":34,"end_line":449,"end_character":38},"updated":"2016-01-08 21:00:49.000000000","message":"You probably need the \u0027G\u0027 here.","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"66a65c94a939fa50d535826e678bc06b8e88ea51","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    def _shrink_share(self, share_id, old_size, new_size):"},{"line_number":579,"context_line":"        \"\"\"Shrinks a share to new size."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        :param share_id: ID of share that will be shrinked."},{"line_number":582,"context_line":"        :param old_size: Current size of share that will be shrinked."},{"line_number":583,"context_line":"        :param new_size: New size of share after shrink operation."},{"line_number":584,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_0f7b8529","line":581,"range":{"start_line":581,"start_character":50,"end_line":581,"end_character":58},"updated":"2016-01-09 13:33:21.000000000","message":"same","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"66a65c94a939fa50d535826e678bc06b8e88ea51","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        \"\"\"Shrinks a share to new size."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        :param share_id: ID of share that will be shrinked."},{"line_number":582,"context_line":"        :param old_size: Current size of share that will be shrinked."},{"line_number":583,"context_line":"        :param new_size: New size of share after shrink operation."},{"line_number":584,"context_line":"        \"\"\""},{"line_number":585,"context_line":"        self._ensure_share(share_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_cf700d43","line":582,"range":{"start_line":582,"start_character":60,"end_line":582,"end_character":68},"updated":"2016-01-09 13:33:21.000000000","message":"same","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e555c455ca3807f716c4186ad61e41e4a6082dc6","unresolved":false,"context_lines":[{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        usage \u003d self.hnas.get_share_usage(share_id)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        LOG.debug(\"Usage space in share %(share)sG: %(usage)sG\","},{"line_number":590,"context_line":"                  {\u0027share\u0027: share_id, \u0027usage\u0027: usage})"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if new_size \u003e usage:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_437f2766","line":589,"range":{"start_line":589,"start_character":49,"end_line":589,"end_character":50},"updated":"2016-01-08 21:00:49.000000000","message":"you probably don\u0027t want the G here?","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"66a65c94a939fa50d535826e678bc06b8e88ea51","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        LOG.debug(\"Usage space in share %(share)sG: %(usage)sG\","},{"line_number":590,"context_line":"                  {\u0027share\u0027: share_id, \u0027usage\u0027: usage})"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if new_size \u003e usage:"},{"line_number":593,"context_line":"            self.hnas.shrink_quota(share_id, new_size)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss(share_id\u003dshare_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_cf99ed7a","line":592,"range":{"start_line":592,"start_character":8,"end_line":592,"end_character":28},"updated":"2016-01-09 13:33:21.000000000","message":"If new_size\u003dusage, Dose the driver still return success? It is up to the driver, just a question.:)","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"5f3ffca5f85c62c3def1bfc09548c33ebf77f4fa","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        LOG.debug(\"Usage space in share %(share)sG: %(usage)sG\","},{"line_number":590,"context_line":"                  {\u0027share\u0027: share_id, \u0027usage\u0027: usage})"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if new_size \u003e usage:"},{"line_number":593,"context_line":"            self.hnas.shrink_quota(share_id, new_size)"},{"line_number":594,"context_line":"        else:"},{"line_number":595,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss(share_id\u003dshare_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_59e61616","line":592,"range":{"start_line":592,"start_character":8,"end_line":592,"end_character":28},"in_reply_to":"fa69d971_cf99ed7a","updated":"2016-01-11 10:06:13.000000000","message":"No, if new_size \u003c\u003d usage, this will fail. This is to avoid data loss, just like the generic driver does.","commit_id":"e8ac451981e4765dc514ddccba516ce71e518f25"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c971479567162653d83310ec1563d5acbc5a8244","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                  \u0027shr_id\u0027: six.text_type(share[\u0027id\u0027])})"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":431,"context_line":"        \"\"\"Shinks a share to new size."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        :param share: Share that will be shrunk."},{"line_number":434,"context_line":"        :param new_size: New size of share."}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_79c29886","line":431,"range":{"start_line":431,"start_character":11,"end_line":431,"end_character":17},"updated":"2016-01-15 19:28:55.000000000","message":"Shrinks","commit_id":"377d1e636bc4b40ccd98bdd2b83c0c8cbce52cbd"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"55c069f061b00ec0aa9d97c3e553ff441b438d05","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                  \u0027shr_id\u0027: six.text_type(share[\u0027id\u0027])})"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":431,"context_line":"        \"\"\"Shinks a share to new size."},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        :param share: Share that will be shrunk."},{"line_number":434,"context_line":"        :param new_size: New size of share."}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_c913a80c","line":431,"range":{"start_line":431,"start_character":11,"end_line":431,"end_character":17},"in_reply_to":"da6ed579_79c29886","updated":"2016-01-20 14:57:40.000000000","message":"Done","commit_id":"377d1e636bc4b40ccd98bdd2b83c0c8cbce52cbd"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"c971479567162653d83310ec1563d5acbc5a8244","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        LOG.debug(\"Shrinking share in HNAS: %(shr_id)s.\","},{"line_number":441,"context_line":"                  {\u0027shr_id\u0027: six.text_type(share[\u0027id\u0027])})"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        if share[\u0027share_proto\u0027].lower() !\u003d \u0027nfs\u0027:"},{"line_number":444,"context_line":"            msg \u003d _(\"Only NFS protocol is currently supported.\")"},{"line_number":445,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_391ae0c6","line":443,"range":{"start_line":443,"start_character":7,"end_line":443,"end_character":49},"updated":"2016-01-15 19:28:55.000000000","message":"Is it possible that a share, created by this driver (if this request is arriving here, it the share belongs to this backend right?) is not NFS?","commit_id":"377d1e636bc4b40ccd98bdd2b83c0c8cbce52cbd"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"55c069f061b00ec0aa9d97c3e553ff441b438d05","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        LOG.debug(\"Shrinking share in HNAS: %(shr_id)s.\","},{"line_number":441,"context_line":"                  {\u0027shr_id\u0027: six.text_type(share[\u0027id\u0027])})"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        if share[\u0027share_proto\u0027].lower() !\u003d \u0027nfs\u0027:"},{"line_number":444,"context_line":"            msg \u003d _(\"Only NFS protocol is currently supported.\")"},{"line_number":445,"context_line":"            raise exception.ShareBackendException(msg\u003dmsg)"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_89f610d6","line":443,"range":{"start_line":443,"start_character":7,"end_line":443,"end_character":49},"in_reply_to":"da6ed579_391ae0c6","updated":"2016-01-20 14:57:40.000000000","message":"Done","commit_id":"377d1e636bc4b40ccd98bdd2b83c0c8cbce52cbd"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8ce71870b39fa8d639033d5561996a3a16ba856","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        share_id \u003d self._get_hnas_share_id(share[\u0027id\u0027])"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        LOG.debug(\"Shrinking share in HNAS: %(shr_id)s.\","},{"line_number":440,"context_line":"                  {\u0027shr_id\u0027: six.text_type(share[\u0027id\u0027])})"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        self._shrink_share(share_id, share[\u0027size\u0027], new_size)"},{"line_number":443,"context_line":"        LOG.info(_LI(\"Share %(shr_id)s successfully shrunk to \""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_8d0d6e40","line":440,"range":{"start_line":440,"start_character":43,"end_line":440,"end_character":48},"updated":"2016-01-21 18:30:44.000000000","message":"Why must you cast share[\u0027id\u0027] to a string?  It is already defined as a string in the database and should never be anything else.  It could be a different patch to clean up the rest of the driver, but this does seem to be an opportunity for simplification.","commit_id":"0d5a978b8e69917af66bbc77b456084239204445"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"547fcf1b125023386954c7bd8d468c5176f75caf","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        share_id \u003d self._get_hnas_share_id(share[\u0027id\u0027])"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        LOG.debug(\"Shrinking share in HNAS: %(shr_id)s.\","},{"line_number":440,"context_line":"                  {\u0027shr_id\u0027: six.text_type(share[\u0027id\u0027])})"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        self._shrink_share(share_id, share[\u0027size\u0027], new_size)"},{"line_number":443,"context_line":"        LOG.info(_LI(\"Share %(shr_id)s successfully shrunk to \""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_7f2afc7f","line":440,"range":{"start_line":440,"start_character":43,"end_line":440,"end_character":48},"in_reply_to":"9a68dd71_8d0d6e40","updated":"2016-01-22 10:02:11.000000000","message":"Done. Fixed for the methods included in this patch. The rest of the driver will be cleaned up on a separate patch. Thanks for pointing this!","commit_id":"0d5a978b8e69917af66bbc77b456084239204445"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1978a9cafe0c3c7be1d18c938191fac66e6b8329","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        LOG.debug(\"Usage space in share %(share)s: %(usage)sG\","},{"line_number":585,"context_line":"                  {\u0027share\u0027: share_id, \u0027usage\u0027: usage})"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        if new_size \u003e usage:"},{"line_number":588,"context_line":"            self.hnas.modify_quota(share_id, new_size)"},{"line_number":589,"context_line":"        else:"},{"line_number":590,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss(share_id\u003dshare_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a68dd71_e6025b72","line":587,"range":{"start_line":587,"start_character":11,"end_line":587,"end_character":27},"updated":"2016-01-26 10:35:18.000000000","message":"Possible TypeError using py3 when \"usage\" is None.","commit_id":"19c0b49154b592fb68fd04f1446a8f0beaf5381d"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"2eccc83a8520531b9932bd75027086bb1b73ca69","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        LOG.debug(\"Usage space in share %(share)s: %(usage)sG\","},{"line_number":585,"context_line":"                  {\u0027share\u0027: share_id, \u0027usage\u0027: usage})"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        if new_size \u003e usage:"},{"line_number":588,"context_line":"            self.hnas.modify_quota(share_id, new_size)"},{"line_number":589,"context_line":"        else:"},{"line_number":590,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss(share_id\u003dshare_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a68dd71_3f4ab256","line":587,"range":{"start_line":587,"start_character":11,"end_line":587,"end_character":27},"in_reply_to":"9a68dd71_e6025b72","updated":"2016-01-26 11:21:19.000000000","message":"Thank you for pointing this. This is an implementation error. If the quota does not exist, get_share_usage should raise an exception. Fixed on a new patchset.","commit_id":"19c0b49154b592fb68fd04f1446a8f0beaf5381d"}],"manila/share/drivers/hitachi/ssh.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3454b957ed5fe01ad30d072caa551b8f107dd4d7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                   \u0027yes\u0027, self.fs_name, vvol_name]"},{"line_number":247,"context_line":"        self._execute(command)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def shrink_quota(self, vvol_name, new_size):"},{"line_number":250,"context_line":"        self._modify_quota(vvol_name, new_size)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def extend_quota(self, vvol_name, new_size):"},{"line_number":253,"context_line":"        self._modify_quota(vvol_name, new_size)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def check_vvol(self, vvol_name):"},{"line_number":256,"context_line":"        command \u003d [\u0027virtual-volume\u0027, \u0027list\u0027, \u0027--verbose\u0027, self.fs_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a5ad9cea","line":253,"range":{"start_line":249,"start_character":4,"end_line":253,"end_character":47},"updated":"2016-01-11 12:08:26.000000000","message":"I would remove these 2 methods and call modify quota (as a public method) from the upper layer. Knowing how HNAS works, this will be common to all protocols, so it makes sense to be a public method.","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"38e6e43bd671f19c0ed661640a99317f511fdb22","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                   \u0027yes\u0027, self.fs_name, vvol_name]"},{"line_number":247,"context_line":"        self._execute(command)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def shrink_quota(self, vvol_name, new_size):"},{"line_number":250,"context_line":"        self._modify_quota(vvol_name, new_size)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def extend_quota(self, vvol_name, new_size):"},{"line_number":253,"context_line":"        self._modify_quota(vvol_name, new_size)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def check_vvol(self, vvol_name):"},{"line_number":256,"context_line":"        command \u003d [\u0027virtual-volume\u0027, \u0027list\u0027, \u0027--verbose\u0027, self.fs_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8bb3b84c","line":253,"range":{"start_line":249,"start_character":4,"end_line":253,"end_character":47},"in_reply_to":"fa69d971_a5ad9cea","updated":"2016-01-11 17:09:15.000000000","message":"Done. Removed this change from this patch and added to the refactoring.","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3454b957ed5fe01ad30d072caa551b8f107dd4d7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                # Returns None if the quota is unset"},{"line_number":305,"context_line":"                return None"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def get_share_usage(self, share_id):"},{"line_number":308,"context_line":"        command \u003d [\u0027quota\u0027, \u0027list\u0027, self.fs_name, six.text_type(share_id)]"},{"line_number":309,"context_line":"        output, err \u003d self._execute(command)"},{"line_number":310,"context_line":"        items \u003d output.split(\u0027\\n\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        for item in items:"},{"line_number":313,"context_line":"            if \u0027Usage\u0027 in item:"},{"line_number":314,"context_line":"                usage \u003d item.split(\u0027:\u0027)[1].replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":315,"context_line":"                bytes_usage \u003d strutils.string_to_bytes(usage)"},{"line_number":316,"context_line":"                return bytes_usage / units.Gi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _modify_quota(self, vvol_name, new_size):"},{"line_number":319,"context_line":"        str_quota \u003d six.text_type(new_size) + \u0027G\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e5587433","line":316,"range":{"start_line":307,"start_character":4,"end_line":316,"end_character":45},"updated":"2016-01-11 12:08:26.000000000","message":"I would remove this method altogether, call get_share_quota and retrieve its usage property in the upper layer.","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"38e6e43bd671f19c0ed661640a99317f511fdb22","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                # Returns None if the quota is unset"},{"line_number":305,"context_line":"                return None"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def get_share_usage(self, share_id):"},{"line_number":308,"context_line":"        command \u003d [\u0027quota\u0027, \u0027list\u0027, self.fs_name, six.text_type(share_id)]"},{"line_number":309,"context_line":"        output, err \u003d self._execute(command)"},{"line_number":310,"context_line":"        items \u003d output.split(\u0027\\n\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        for item in items:"},{"line_number":313,"context_line":"            if \u0027Usage\u0027 in item:"},{"line_number":314,"context_line":"                usage \u003d item.split(\u0027:\u0027)[1].replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":315,"context_line":"                bytes_usage \u003d strutils.string_to_bytes(usage)"},{"line_number":316,"context_line":"                return bytes_usage / units.Gi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _modify_quota(self, vvol_name, new_size):"},{"line_number":319,"context_line":"        str_quota \u003d six.text_type(new_size) + \u0027G\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ab979c8e","line":316,"range":{"start_line":307,"start_character":4,"end_line":316,"end_character":45},"in_reply_to":"fa69d971_a56b5c1d","updated":"2016-01-11 17:09:15.000000000","message":"Done. Added parser on refactoring patch.","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"842e97dbc0681d32206cd29f9e1739fed5842b63","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                # Returns None if the quota is unset"},{"line_number":305,"context_line":"                return None"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def get_share_usage(self, share_id):"},{"line_number":308,"context_line":"        command \u003d [\u0027quota\u0027, \u0027list\u0027, self.fs_name, six.text_type(share_id)]"},{"line_number":309,"context_line":"        output, err \u003d self._execute(command)"},{"line_number":310,"context_line":"        items \u003d output.split(\u0027\\n\u0027)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        for item in items:"},{"line_number":313,"context_line":"            if \u0027Usage\u0027 in item:"},{"line_number":314,"context_line":"                usage \u003d item.split(\u0027:\u0027)[1].replace(\u0027 \u0027, \u0027\u0027)"},{"line_number":315,"context_line":"                bytes_usage \u003d strutils.string_to_bytes(usage)"},{"line_number":316,"context_line":"                return bytes_usage / units.Gi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _modify_quota(self, vvol_name, new_size):"},{"line_number":319,"context_line":"        str_quota \u003d six.text_type(new_size) + \u0027G\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_a56b5c1d","line":316,"range":{"start_line":307,"start_character":4,"end_line":316,"end_character":45},"in_reply_to":"fa69d971_e5587433","updated":"2016-01-11 12:19:21.000000000","message":"Actually, there should be two methods since total quota and usage quota are different values. So assuming a proper parser is created that retrieves both values, it is up to this method to return the usage value.","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3454b957ed5fe01ad30d072caa551b8f107dd4d7","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                bytes_usage \u003d strutils.string_to_bytes(usage)"},{"line_number":316,"context_line":"                return bytes_usage / units.Gi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _modify_quota(self, vvol_name, new_size):"},{"line_number":319,"context_line":"        str_quota \u003d six.text_type(new_size) + \u0027G\u0027"},{"line_number":320,"context_line":"        command \u003d [\u0027quota\u0027, \u0027mod\u0027, \u0027--usage-limit\u0027, str_quota,"},{"line_number":321,"context_line":"                   self.fs_name, vvol_name]"},{"line_number":322,"context_line":"        self._execute(command)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _nfs_export_list(self, share_id):"},{"line_number":325,"context_line":"        if share_id is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e57dd46d","line":322,"range":{"start_line":318,"start_character":0,"end_line":322,"end_character":30},"updated":"2016-01-11 12:08:26.000000000","message":"This should be a public method, for reasons explained in the comment above. Also, I would implement this in your parent patch (HDS HNAS Refactoring).","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"38e6e43bd671f19c0ed661640a99317f511fdb22","unresolved":false,"context_lines":[{"line_number":315,"context_line":"                bytes_usage \u003d strutils.string_to_bytes(usage)"},{"line_number":316,"context_line":"                return bytes_usage / units.Gi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _modify_quota(self, vvol_name, new_size):"},{"line_number":319,"context_line":"        str_quota \u003d six.text_type(new_size) + \u0027G\u0027"},{"line_number":320,"context_line":"        command \u003d [\u0027quota\u0027, \u0027mod\u0027, \u0027--usage-limit\u0027, str_quota,"},{"line_number":321,"context_line":"                   self.fs_name, vvol_name]"},{"line_number":322,"context_line":"        self._execute(command)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _nfs_export_list(self, share_id):"},{"line_number":325,"context_line":"        if share_id is not None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6b8d247b","line":322,"range":{"start_line":318,"start_character":0,"end_line":322,"end_character":30},"in_reply_to":"fa69d971_e57dd46d","updated":"2016-01-11 17:09:15.000000000","message":"Done on refactoring patch.","commit_id":"541f5b419001825647af27f1e1c11b3edd4f2503"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a97991d7ab94295bc6fde2c765240e0415b497d","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        if quota.usage is None:"},{"line_number":308,"context_line":"            return None"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            bytes_usage \u003d strutils.string_to_bytes(str(quota.usage) +"},{"line_number":311,"context_line":"                                                   quota.usage_unit)"},{"line_number":312,"context_line":"            return bytes_usage / units.Gi"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_1a0630ce","line":310,"range":{"start_line":310,"start_character":51,"end_line":310,"end_character":54},"updated":"2016-01-11 18:45:02.000000000","message":"six.text_type(quota.usage)","commit_id":"c0df0a9937389d2208f8eb4fd7cc459ad1d4aa03"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"0c16f04b6d7d18665e4634935fc25c30ba253848","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        quota \u003d Quota(output)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if quota.usage is None:"},{"line_number":308,"context_line":"            return None"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            bytes_usage \u003d strutils.string_to_bytes(six.text_type(quota.usage) +"},{"line_number":311,"context_line":"                                                   quota.usage_unit)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_dae12400","line":308,"range":{"start_line":308,"start_character":12,"end_line":308,"end_character":18},"updated":"2016-01-20 15:41:09.000000000","message":"No unit test coverage for this condition.","commit_id":"89e0463916ebe7ec97a77c707aa2bd749f7cb095"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"dafc0696e651c51db904fe7b40a18df40f41e6de","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        quota \u003d Quota(output)"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        if quota.usage is None:"},{"line_number":308,"context_line":"            return None"},{"line_number":309,"context_line":"        else:"},{"line_number":310,"context_line":"            bytes_usage \u003d strutils.string_to_bytes(six.text_type(quota.usage) +"},{"line_number":311,"context_line":"                                                   quota.usage_unit)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_aa093d2e","line":308,"range":{"start_line":308,"start_character":12,"end_line":308,"end_character":18},"in_reply_to":"9a68dd71_dae12400","updated":"2016-01-21 16:25:51.000000000","message":"Done","commit_id":"89e0463916ebe7ec97a77c707aa2bd749f7cb095"}],"manila/tests/share/drivers/hitachi/test_hds_hnas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1978a9cafe0c3c7be1d18c938191fac66e6b8329","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_get_hnas_share_id\","},{"line_number":398,"context_line":"                         mock.Mock(return_value\u003dshare[\u0027id\u0027]))"},{"line_number":399,"context_line":"        self.mock_object(hds_hnas.HDSHNASDriver, \"_ensure_share\", mock.Mock())"},{"line_number":400,"context_line":"        self.mock_object(ssh.HNASSSHBackend, \"get_share_usage\", mock.Mock("},{"line_number":401,"context_line":"            return_value\u003d10))"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertRaises(exception.ShareShrinkingPossibleDataLoss,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a68dd71_a6246360","line":400,"range":{"start_line":400,"start_character":46,"end_line":400,"end_character":61},"updated":"2016-01-26 10:35:18.000000000","message":"\"get_share_usage\" can return None and it is not covered with unit tests. Moreover, in file [1] you will get TypeError exception in this case on line 587 trying compare integer to None using py3. Using py2 you get fake \"True\" result always.\n\n[1] https://review.openstack.org/#/c/265434/10/manila/share/drivers/hitachi/hds_hnas.py","commit_id":"19c0b49154b592fb68fd04f1446a8f0beaf5381d"}]}
