)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c26be6624f0fa0aca85e2561e8584b73880a843b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhaohua \u003czhaohua.zhao@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-11 11:40:38 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei driver report pool capabilities [True, False]."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In liberty, huawei driver have been changed to support only"},{"line_number":10,"context_line":"thin or thick filesystem in one storagepool because of bug#1491272."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_0fab7476","line":7,"range":{"start_line":7,"start_character":51,"end_line":7,"end_character":53},"updated":"2016-01-11 07:27:41.000000000","message":"The title does not need a period in the end. see:\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"4508f2e6dd0cb5657739ca59b7e95af3558a408d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei driver report pool capabilities [True, False]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In liberty, huawei driver have been changed to support only"},{"line_number":10,"context_line":"thin or thick filesystem in one storagepool because of bug#1491272."},{"line_number":11,"context_line":"Now in mitaka, after blueprint support-lists-in-capabilities-filter"},{"line_number":12,"context_line":"have been merged. The scheduler is able to handle one storage pool"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_0720a99a","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":30},"updated":"2016-01-12 15:07:02.000000000","message":"s/have/has","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"779ad17e0adbf5a397838fe3ff54cac8fc28efd2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei driver report pool capabilities [True, False]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In liberty, huawei driver have been changed to support only"},{"line_number":10,"context_line":"thin or thick filesystem in one storagepool because of bug#1491272."},{"line_number":11,"context_line":"Now in mitaka, after blueprint support-lists-in-capabilities-filter"},{"line_number":12,"context_line":"have been merged. The scheduler is able to handle one storage pool"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_5a62dcae","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":30},"in_reply_to":"da6ed579_0720a99a","updated":"2016-01-13 02:39:35.000000000","message":"Done","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bcf6e1aa058d8114284aaf5c1cc0760881345212","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In liberty, huawei driver have been changed to support only"},{"line_number":10,"context_line":"thin or thick filesystem in one storagepool because of bug#1491272."},{"line_number":11,"context_line":"Now in mitaka, after blueprint support-lists-in-capabilities-filter"},{"line_number":12,"context_line":"have been merged. The scheduler is able to handle one storage pool"},{"line_number":13,"context_line":"report \"thin_provisioning\" :[True, False]."},{"line_number":14,"context_line":"Most of the code is the revert of bug#1491272."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_eec45793","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"updated":"2016-01-12 13:57:51.000000000","message":"s/have/has","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"4508f2e6dd0cb5657739ca59b7e95af3558a408d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In liberty, huawei driver have been changed to support only"},{"line_number":10,"context_line":"thin or thick filesystem in one storagepool because of bug#1491272."},{"line_number":11,"context_line":"Now in mitaka, after blueprint support-lists-in-capabilities-filter"},{"line_number":12,"context_line":"have been merged. The scheduler is able to handle one storage pool"},{"line_number":13,"context_line":"report \"thin_provisioning\" :[True, False]."},{"line_number":14,"context_line":"Most of the code is the revert of bug#1491272."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_270e0d35","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"in_reply_to":"da6ed579_eec45793","updated":"2016-01-12 15:07:02.000000000","message":"+1","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"779ad17e0adbf5a397838fe3ff54cac8fc28efd2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In liberty, huawei driver have been changed to support only"},{"line_number":10,"context_line":"thin or thick filesystem in one storagepool because of bug#1491272."},{"line_number":11,"context_line":"Now in mitaka, after blueprint support-lists-in-capabilities-filter"},{"line_number":12,"context_line":"have been merged. The scheduler is able to handle one storage pool"},{"line_number":13,"context_line":"report \"thin_provisioning\" :[True, False]."},{"line_number":14,"context_line":"Most of the code is the revert of bug#1491272."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_fa5870fc","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"in_reply_to":"da6ed579_eec45793","updated":"2016-01-13 02:39:35.000000000","message":"Done","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c26be6624f0fa0aca85e2561e8584b73880a843b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        stats_dict[\"pools\"] \u003d []"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        pool_name_list \u003d root.findtext(\u0027Filesystem/StoragePool\u0027)"},{"line_number":238,"context_line":"        if not pool_name_list:"},{"line_number":239,"context_line":"            err_msg \u003d _(\"The StoragePool is None.\")"},{"line_number":240,"context_line":"            LOG.error(err_msg)"},{"line_number":241,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_af8588cf","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":30},"updated":"2016-01-11 07:27:41.000000000","message":"This has been checked in code line 595.\nThe path 1(line 265~268) could be added in this code.","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        stats_dict[\"pools\"] \u003d []"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        pool_name_list \u003d root.findtext(\u0027Filesystem/StoragePool\u0027)"},{"line_number":238,"context_line":"        if not pool_name_list:"},{"line_number":239,"context_line":"            err_msg \u003d _(\"The StoragePool is None.\")"},{"line_number":240,"context_line":"            LOG.error(err_msg)"},{"line_number":241,"context_line":"            raise exception.InvalidInput(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cf4b1c86","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":30},"in_reply_to":"fa69d971_af8588cf","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                    huawei_smartcache\u003d[True, False],"},{"line_number":264,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":265,"context_line":"                )"},{"line_number":266,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def delete_share(self, share, share_server\u003dNone):"},{"line_number":269,"context_line":"        \"\"\"Delete share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_0f5374e3","line":266,"range":{"start_line":266,"start_character":13,"end_line":266,"end_character":48},"updated":"2016-01-11 07:15:14.000000000","message":"If the stats_dict[\"pools\"] is None, Is it will return true?\nIn path 1, code line 265, it will return error. please check it again.","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                    huawei_smartcache\u003d[True, False],"},{"line_number":264,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":265,"context_line":"                )"},{"line_number":266,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def delete_share(self, share, share_server\u003dNone):"},{"line_number":269,"context_line":"        \"\"\"Delete share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_af46e878","line":266,"range":{"start_line":266,"start_character":13,"end_line":266,"end_character":48},"in_reply_to":"fa69d971_0f5374e3","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        fileparam \u003d {"},{"line_number":320,"context_line":"            \"NAME\": name.replace(\"-\", \"_\"),"},{"line_number":321,"context_line":"            \"DESCRIPTION\": \"\","},{"line_number":322,"context_line":"            \"ALLOCTYPE\": 1,"},{"line_number":323,"context_line":"            \"CAPACITY\": size,"},{"line_number":324,"context_line":"            \"PARENTID\": poolinfo[\u0027ID\u0027],"},{"line_number":325,"context_line":"            \"INITIALALLOCCAPACITY\": units.Ki * 20,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_1d0e513b","line":322,"range":{"start_line":322,"start_character":25,"end_line":322,"end_character":26},"updated":"2016-01-11 07:15:14.000000000","message":"Please use the ALLOC_TYPE_THIN_FLAG instead of 1.\nhttps://github.com/openstack/manila/blob/master/manila/share/drivers/huawei/constants.py#L34","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        fileparam \u003d {"},{"line_number":320,"context_line":"            \"NAME\": name.replace(\"-\", \"_\"),"},{"line_number":321,"context_line":"            \"DESCRIPTION\": \"\","},{"line_number":322,"context_line":"            \"ALLOCTYPE\": 1,"},{"line_number":323,"context_line":"            \"CAPACITY\": size,"},{"line_number":324,"context_line":"            \"PARENTID\": poolinfo[\u0027ID\u0027],"},{"line_number":325,"context_line":"            \"INITIALALLOCCAPACITY\": units.Ki * 20,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ef1e206f","line":322,"range":{"start_line":322,"start_character":25,"end_line":322,"end_character":26},"in_reply_to":"fa69d971_1d0e513b","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            root \u003d self.helper._read_xml()"},{"line_number":342,"context_line":"            fstype \u003d root.findtext(\u0027Filesystem/AllocType\u0027)"},{"line_number":343,"context_line":"            if fstype:"},{"line_number":344,"context_line":"                fstype \u003d fstype.strip()"},{"line_number":345,"context_line":"                if fstype \u003d\u003d \u0027Thin\u0027:"},{"line_number":346,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 1"},{"line_number":347,"context_line":"                elif fstype \u003d\u003d \u0027Thick\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_0f493460","line":344,"range":{"start_line":344,"start_character":31,"end_line":344,"end_character":39},"updated":"2016-01-11 07:15:14.000000000","message":"Dose you need to add .strip(\u0027\\n\u0027)?","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            root \u003d self.helper._read_xml()"},{"line_number":342,"context_line":"            fstype \u003d root.findtext(\u0027Filesystem/AllocType\u0027)"},{"line_number":343,"context_line":"            if fstype:"},{"line_number":344,"context_line":"                fstype \u003d fstype.strip()"},{"line_number":345,"context_line":"                if fstype \u003d\u003d \u0027Thin\u0027:"},{"line_number":346,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 1"},{"line_number":347,"context_line":"                elif fstype \u003d\u003d \u0027Thick\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_92a22bfb","line":344,"range":{"start_line":344,"start_character":31,"end_line":344,"end_character":39},"in_reply_to":"fa69d971_0f493460","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            if fstype:"},{"line_number":344,"context_line":"                fstype \u003d fstype.strip()"},{"line_number":345,"context_line":"                if fstype \u003d\u003d \u0027Thin\u0027:"},{"line_number":346,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 1"},{"line_number":347,"context_line":"                elif fstype \u003d\u003d \u0027Thick\u0027:"},{"line_number":348,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 0"},{"line_number":349,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_3d0b152c","line":346,"range":{"start_line":346,"start_character":45,"end_line":346,"end_character":46},"updated":"2016-01-11 07:15:14.000000000","message":"above","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            if fstype:"},{"line_number":344,"context_line":"                fstype \u003d fstype.strip()"},{"line_number":345,"context_line":"                if fstype \u003d\u003d \u0027Thin\u0027:"},{"line_number":346,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 1"},{"line_number":347,"context_line":"                elif fstype \u003d\u003d \u0027Thick\u0027:"},{"line_number":348,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 0"},{"line_number":349,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b2a72f0a","line":346,"range":{"start_line":346,"start_character":45,"end_line":346,"end_character":46},"in_reply_to":"fa69d971_3d0b152c","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 0"},{"line_number":349,"context_line":"                else:"},{"line_number":350,"context_line":"                    err_msg \u003d (_("},{"line_number":351,"context_line":"                        \u0027Config file is wrong. Filesystem type must be \"Thin\"\u0027"},{"line_number":352,"context_line":"                        \u0027 or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":353,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":354,"context_line":"                    LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6f6790e9","line":351,"range":{"start_line":351,"start_character":58,"end_line":351,"end_character":62},"updated":"2016-01-11 07:15:14.000000000","message":"AllocType","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 0"},{"line_number":349,"context_line":"                else:"},{"line_number":350,"context_line":"                    err_msg \u003d (_("},{"line_number":351,"context_line":"                        \u0027Config file is wrong. Filesystem type must be \"Thin\"\u0027"},{"line_number":352,"context_line":"                        \u0027 or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":353,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":354,"context_line":"                    LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6faeb0e7","line":351,"range":{"start_line":351,"start_character":63,"end_line":351,"end_character":70},"updated":"2016-01-11 07:15:14.000000000","message":"must be set to","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 0"},{"line_number":349,"context_line":"                else:"},{"line_number":350,"context_line":"                    err_msg \u003d (_("},{"line_number":351,"context_line":"                        \u0027Config file is wrong. Filesystem type must be \"Thin\"\u0027"},{"line_number":352,"context_line":"                        \u0027 or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":353,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":354,"context_line":"                    LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_72ae97e7","line":351,"range":{"start_line":351,"start_character":58,"end_line":351,"end_character":62},"in_reply_to":"fa69d971_6f6790e9","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                    fileparam[\u0027ALLOCTYPE\u0027] \u003d 0"},{"line_number":349,"context_line":"                else:"},{"line_number":350,"context_line":"                    err_msg \u003d (_("},{"line_number":351,"context_line":"                        \u0027Config file is wrong. Filesystem type must be \"Thin\"\u0027"},{"line_number":352,"context_line":"                        \u0027 or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":353,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":354,"context_line":"                    LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_12b71b3b","line":351,"range":{"start_line":351,"start_character":63,"end_line":351,"end_character":70},"in_reply_to":"fa69d971_6faeb0e7","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            LOG.error(err_msg)"},{"line_number":593,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        if (not pool_node):"},{"line_number":596,"context_line":"            err_msg \u003d (_("},{"line_number":597,"context_line":"                \u0027check_conf_file: Config file invalid. \u0027"},{"line_number":598,"context_line":"                \u0027StoragePool must be set.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cfd1dc58","line":595,"range":{"start_line":595,"start_character":25,"end_line":595,"end_character":26},"updated":"2016-01-11 07:15:14.000000000","message":"\"( )\" is not necessary.","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"dcccd266aa6a81846f776502b24430a4268c35cc","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            LOG.error(err_msg)"},{"line_number":593,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        if (not pool_node):"},{"line_number":596,"context_line":"            err_msg \u003d (_("},{"line_number":597,"context_line":"                \u0027check_conf_file: Config file invalid. \u0027"},{"line_number":598,"context_line":"                \u0027StoragePool must be set.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_b2f5efed","line":595,"range":{"start_line":595,"start_character":25,"end_line":595,"end_character":26},"in_reply_to":"fa69d971_cfd1dc58","updated":"2016-01-11 07:53:32.000000000","message":"Done","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17718,"name":"Lallana","email":"gaozhiqiang2@huawei.com","username":"Lallana"},"change_message_id":"3d9a0cb267b8d92c60573dfcbbe94e6c82491d71","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        if (not pool_node):"},{"line_number":596,"context_line":"            err_msg \u003d (_("},{"line_number":597,"context_line":"                \u0027check_conf_file: Config file invalid. \u0027"},{"line_number":598,"context_line":"                \u0027StoragePool must be set.\u0027))"},{"line_number":599,"context_line":"            LOG.error(err_msg)"},{"line_number":600,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_af7ee867","line":598,"range":{"start_line":598,"start_character":40,"end_line":598,"end_character":41},"updated":"2016-01-11 07:15:14.000000000","message":"Add \"to \"Thin\" or \"Thick\"\".","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c26be6624f0fa0aca85e2561e8584b73880a843b","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                \u0027check_conf_file: Config file invalid. \u0027"},{"line_number":598,"context_line":"                \u0027StoragePool must be set.\u0027))"},{"line_number":599,"context_line":"            LOG.error(err_msg)"},{"line_number":600,"context_line":"            raise exception.InvalidInput(err_msg)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def check_service(self):"},{"line_number":603,"context_line":"        running_status \u003d self.helper._get_cifs_service_status()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_af84a80a","line":600,"range":{"start_line":600,"start_character":28,"end_line":600,"end_character":49},"updated":"2016-01-11 07:27:41.000000000","message":"InvalidInput(reason\u003derr_msg)","commit_id":"6c3a75b11f21d5586f1a94a4bd32b9570dcdeb68"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"4508f2e6dd0cb5657739ca59b7e95af3558a408d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            pool_name \u003d pool_name.strip().strip(\u0027\\n\u0027)"},{"line_number":243,"context_line":"            capacity \u003d self._get_capacity(pool_name, all_pool_info)"},{"line_number":244,"context_line":"            if capacity:"},{"line_number":245,"context_line":"                pool \u003d dict("},{"line_number":246,"context_line":"                    pool_name\u003dpool_name,"},{"line_number":247,"context_line":"                    total_capacity_gb\u003dcapacity[\u0027TOTALCAPACITY\u0027],"},{"line_number":248,"context_line":"                    free_capacity_gb\u003dcapacity[\u0027CAPACITY\u0027],"},{"line_number":249,"context_line":"                    provisioned_capacity_gb\u003d("},{"line_number":250,"context_line":"                        capacity[\u0027PROVISIONEDCAPACITYGB\u0027]),"},{"line_number":251,"context_line":"                    max_over_subscription_ratio\u003d("},{"line_number":252,"context_line":"                        self.configuration.safe_get("},{"line_number":253,"context_line":"                            \u0027max_over_subscription_ratio\u0027)),"},{"line_number":254,"context_line":"                    allocated_capacity_gb\u003dcapacity[\u0027CONSUMEDCAPACITY\u0027],"},{"line_number":255,"context_line":"                    QoS_support\u003dFalse,"},{"line_number":256,"context_line":"                    reserved_percentage\u003d0,"},{"line_number":257,"context_line":"                    thin_provisioning\u003d[True, False],"},{"line_number":258,"context_line":"                    dedupe\u003d[True, False],"},{"line_number":259,"context_line":"                    compression\u003d[True, False],"},{"line_number":260,"context_line":"                    huawei_smartcache\u003d[True, False],"},{"line_number":261,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":262,"context_line":"                )"},{"line_number":263,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if not stats_dict[\"pools\"]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_0412e762","line":262,"range":{"start_line":245,"start_character":23,"end_line":262,"end_character":17},"updated":"2016-01-12 15:07:02.000000000","message":"Please use braces instead of dict. Refer to: http://legacy.python.org/dev/peps/pep-0274/","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"779ad17e0adbf5a397838fe3ff54cac8fc28efd2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            pool_name \u003d pool_name.strip().strip(\u0027\\n\u0027)"},{"line_number":243,"context_line":"            capacity \u003d self._get_capacity(pool_name, all_pool_info)"},{"line_number":244,"context_line":"            if capacity:"},{"line_number":245,"context_line":"                pool \u003d dict("},{"line_number":246,"context_line":"                    pool_name\u003dpool_name,"},{"line_number":247,"context_line":"                    total_capacity_gb\u003dcapacity[\u0027TOTALCAPACITY\u0027],"},{"line_number":248,"context_line":"                    free_capacity_gb\u003dcapacity[\u0027CAPACITY\u0027],"},{"line_number":249,"context_line":"                    provisioned_capacity_gb\u003d("},{"line_number":250,"context_line":"                        capacity[\u0027PROVISIONEDCAPACITYGB\u0027]),"},{"line_number":251,"context_line":"                    max_over_subscription_ratio\u003d("},{"line_number":252,"context_line":"                        self.configuration.safe_get("},{"line_number":253,"context_line":"                            \u0027max_over_subscription_ratio\u0027)),"},{"line_number":254,"context_line":"                    allocated_capacity_gb\u003dcapacity[\u0027CONSUMEDCAPACITY\u0027],"},{"line_number":255,"context_line":"                    QoS_support\u003dFalse,"},{"line_number":256,"context_line":"                    reserved_percentage\u003d0,"},{"line_number":257,"context_line":"                    thin_provisioning\u003d[True, False],"},{"line_number":258,"context_line":"                    dedupe\u003d[True, False],"},{"line_number":259,"context_line":"                    compression\u003d[True, False],"},{"line_number":260,"context_line":"                    huawei_smartcache\u003d[True, False],"},{"line_number":261,"context_line":"                    huawei_smartpartition\u003d[True, False],"},{"line_number":262,"context_line":"                )"},{"line_number":263,"context_line":"                stats_dict[\"pools\"].append(pool)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if not stats_dict[\"pools\"]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_9d7daeb3","line":262,"range":{"start_line":245,"start_character":23,"end_line":262,"end_character":17},"in_reply_to":"da6ed579_0412e762","updated":"2016-01-13 02:39:35.000000000","message":"I don\u0027t know whether it is necessary to make this change.\nYou can see many dict() used in manila, even in python lib.\nI think it\u0027s more readable to use dict() than {}","commit_id":"4fdaafd729d9025a3503ead133e8f6f1978645bd"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"6cb7d25798b58c754c4c78ab89417e1b14f1ebb1","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                else:"},{"line_number":352,"context_line":"                    err_msg \u003d (_("},{"line_number":353,"context_line":"                        \u0027Config file is wrong. AllocType type must be set to\u0027"},{"line_number":354,"context_line":"                        \u0027 \"Thin\" or \"Thick\". AllocType:%(fetchtype)s\u0027) %"},{"line_number":355,"context_line":"                        {\u0027fetchtype\u0027: fstype})"},{"line_number":356,"context_line":"                    LOG.error(err_msg)"},{"line_number":357,"context_line":"                    raise exception.InvalidShare(reason\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_2d23e757","line":354,"range":{"start_line":354,"start_character":57,"end_line":354,"end_character":66},"updated":"2016-01-14 06:19:41.000000000","message":"It\u0027s not fetchtype, so using fstype or AllocType instead of fetchtype.","commit_id":"9096fc79197154cd7456aca2becbade7f09d32bb"}]}
