)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement update_access() method in huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add update_access() method to huawei driver."},{"line_number":10,"context_line":"Do not remove allow_access() and deny_access()."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic96ee3166b1b9f6a604688c0eea8f1c8131be919"},{"line_number":13,"context_line":"Implements: bp huawei-driver-implement-update-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bae84128_e1605da7","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":47},"updated":"2016-02-24 13:01:21.000000000","message":"Why not?","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"36352e260633994c7084b0d03173726e57df84f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement update_access() method in huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add update_access() method to huawei driver."},{"line_number":10,"context_line":"Do not remove allow_access() and deny_access()."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic96ee3166b1b9f6a604688c0eea8f1c8131be919"},{"line_number":13,"context_line":"Implements: bp huawei-driver-implement-update-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_6ea2f1af","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"9aed3d3a_48528fde","updated":"2016-02-28 01:19:20.000000000","message":"I don\u0027t understand this.  Are you saying you want your customers to run your Mitaka Manila driver with older OpenStack releases as far back as Juno?","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"6a4ef2ae58a39227d4df6825ac21f7c20336da2d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement update_access() method in huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add update_access() method to huawei driver."},{"line_number":10,"context_line":"Do not remove allow_access() and deny_access()."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic96ee3166b1b9f6a604688c0eea8f1c8131be919"},{"line_number":13,"context_line":"Implements: bp huawei-driver-implement-update-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_8e9d9e0c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"9aed3d3a_6ea2f1af","updated":"2016-02-29 08:42:09.000000000","message":"There is a cloude envirment based on Juno.\nIt uses Mitaka Manila driver, just replace some import lines(such as \u0027oslo_\u0027 to \u0027oslo.\u0027)\nIt works fine now.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"bc8603fbb7b8c1d0138391ac548764cc634efddc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implement update_access() method in huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add update_access() method to huawei driver."},{"line_number":10,"context_line":"Do not remove allow_access() and deny_access()."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic96ee3166b1b9f6a604688c0eea8f1c8131be919"},{"line_number":13,"context_line":"Implements: bp huawei-driver-implement-update-access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_48528fde","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":47},"in_reply_to":"bae84128_e1605da7","updated":"2016-02-27 08:16:02.000000000","message":"Huawei driver have been used in some cloud environments.\nMost of these cloud environments still use allow_access and deny_access.(They use Liberty or Kilo or even Juno version of manila. And did some bug fixes to these versions)\nSo we want to keep compatible with them.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"}],"manila/share/drivers/huawei/huawei_nas.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        location \u003d self.plugin.ensure_share(share, share_server)"},{"line_number":147,"context_line":"        return location"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":150,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":151,"context_line":"        LOG.debug(\"Allow access.\")"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_01df413a","line":149,"range":{"start_line":149,"start_character":8,"end_line":149,"end_character":20},"updated":"2016-02-24 13:01:21.000000000","message":"this class implements the base driver class, which will not have allow/deny anymore. Please remove this method.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        self.plugin.allow_access(share, access, share_server)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":156,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":157,"context_line":"        LOG.debug(\"Deny access.\")"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e1d5fd1b","line":155,"range":{"start_line":155,"start_character":8,"end_line":155,"end_character":19},"updated":"2016-02-24 13:01:21.000000000","message":"this class implements the base driver class, which will not have allow/deny anymore. Please remove this method.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"},{"line_number":162,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":163,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":164,"context_line":"        LOG.debug(\"Update access.\")"},{"line_number":165,"context_line":"        self.plugin.update_access(share, access_rules,"},{"line_number":166,"context_line":"                                  add_rules, delete_rules, share_server)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_a102d5b1","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":35},"updated":"2016-02-24 13:01:21.000000000","message":"nit: could have more info in here.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"}],"manila/share/drivers/huawei/v3/connection.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"53e1b2eac650e0e1ecc95c56ec8ca68256bf6ae8","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":434,"context_line":"        share_stor \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":435,"context_line":"        if not share_stor:"},{"line_number":436,"context_line":"            LOG.warning(_LW(\u0027Can not get share. share_name: %s\u0027), share_name)"},{"line_number":437,"context_line":"            return False"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        access_id \u003d self.helper._get_access_from_share(share_stor[\u0027ID\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_0a72fce5","line":436,"range":{"start_line":436,"start_character":29,"end_line":436,"end_character":62},"updated":"2016-01-12 12:13:36.000000000","message":"s/Can not get share. share_name: %s/Cannot get share %s","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ea772150d63c5c5c59369342738767c9e58d250","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        share_client_type \u003d self.helper._get_share_client_type(share_proto)"},{"line_number":433,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":434,"context_line":"        share_stor \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":435,"context_line":"        if not share_stor:"},{"line_number":436,"context_line":"            LOG.warning(_LW(\u0027Can not get share. share_name: %s\u0027), share_name)"},{"line_number":437,"context_line":"            return False"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        access_id \u003d self.helper._get_access_from_share(share_stor[\u0027ID\u0027],"},{"line_number":440,"context_line":"                                                       access_to,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_2f603235","line":437,"range":{"start_line":435,"start_character":1,"end_line":437,"end_character":24},"updated":"2016-01-12 12:00:27.000000000","message":"If the share can not be fund. It will go to code line 461. and will run allow_access that the results would definitely be wrong?","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ea772150d63c5c5c59369342738767c9e58d250","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                         \u0027share_name\u0027: share_name})"},{"line_number":447,"context_line":"            return False"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        LOG.warning(_LW(\u0027Access %(access_to)s exists\u0027"},{"line_number":450,"context_line":"                        \u0027 for share %(share_name)s.\u0027),"},{"line_number":451,"context_line":"                    {\u0027access_to\u0027: access_to,"},{"line_number":452,"context_line":"                     \u0027share_name\u0027: share_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_0fb52ecc","line":449,"range":{"start_line":449,"start_character":12,"end_line":449,"end_character":19},"updated":"2016-01-12 12:00:27.000000000","message":"This is correct, why need use warning and not use debug?","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dcd46b55388de792ed8d2052cc8f3d0f4097aa8","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                         \u0027share_name\u0027: share_name})"},{"line_number":447,"context_line":"            return False"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        LOG.warning(_LW(\u0027Access %(access_to)s exists\u0027"},{"line_number":450,"context_line":"                        \u0027 for share %(share_name)s.\u0027),"},{"line_number":451,"context_line":"                    {\u0027access_to\u0027: access_to,"},{"line_number":452,"context_line":"                     \u0027share_name\u0027: share_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_462db993","line":449,"range":{"start_line":449,"start_character":12,"end_line":449,"end_character":19},"in_reply_to":"da6ed579_0fb52ecc","updated":"2016-02-06 09:05:30.000000000","message":"debug or info (I think debug is better here)","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"53e1b2eac650e0e1ecc95c56ec8ca68256bf6ae8","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def update_access(self, share, access_rules, add_rules\u003dNone,"},{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_ca22a4b9","line":458,"range":{"start_line":458,"start_character":8,"end_line":458,"end_character":42},"updated":"2016-01-12 12:13:36.000000000","message":"Isn\u0027t it better to check if len() \u003d\u003d 0 to avoid confusion?","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ea772150d63c5c5c59369342738767c9e58d250","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def update_access(self, share, access_rules, add_rules\u003dNone,"},{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_2f9592e3","line":458,"range":{"start_line":458,"start_character":26,"end_line":458,"end_character":28},"updated":"2016-01-12 12:00:27.000000000","message":"and?","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ea772150d63c5c5c59369342738767c9e58d250","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def update_access(self, share, access_rules, add_rules\u003dNone,"},{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_4f9a4616","line":458,"range":{"start_line":458,"start_character":26,"end_line":458,"end_character":28},"updated":"2016-01-12 12:00:27.000000000","message":"and?\n\u0027access_rules\u0027 contains all access_rules, \u0027add_rules\u0027 and \u0027delete_rules\u0027 are None. Driver should apply all access rules for given share.","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dcd46b55388de792ed8d2052cc8f3d0f4097aa8","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def update_access(self, share, access_rules, add_rules\u003dNone,"},{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_c6120957","line":458,"range":{"start_line":458,"start_character":8,"end_line":458,"end_character":42},"in_reply_to":"5a5ae5dd_8cb779f4","updated":"2016-02-06 09:05:30.000000000","message":"It\u0027s OK.  Or you could get rid of \u0027not\u0027 by doing the else block first.","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f1ddb0cda2951bf1e25f5fa9fb7826812f27a8e1","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    def update_access(self, share, access_rules, add_rules\u003dNone,"},{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8cb779f4","line":458,"range":{"start_line":458,"start_character":8,"end_line":458,"end_character":42},"in_reply_to":"da6ed579_ca22a4b9","updated":"2016-02-05 11:07:46.000000000","message":"I think that is fine. it will only trigger in case of:\n\"if not ([] or [])\".","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"f1ddb0cda2951bf1e25f5fa9fb7826812f27a8e1","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"},{"line_number":462,"context_line":"        else:"},{"line_number":463,"context_line":"            for access in add_rules:"},{"line_number":464,"context_line":"                self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_cc0b318d","line":461,"range":{"start_line":459,"start_character":11,"end_line":461,"end_character":66},"updated":"2016-02-05 11:07:46.000000000","message":"This is supposed to be the recovery mode. Here all rules should be cleared and applied only access_rules.\n\nI see that your code is only applying rules that do not exist. In this case, you would need to delete rules that exist but are not in access_rules list, but you have no way of knowing that because you are querying them according to the contents of access_rules. The manager already does this job for you, so it is just better to clear the rules and add them all according to access_rules.","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dcd46b55388de792ed8d2052cc8f3d0f4097aa8","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":457,"context_line":"        \"\"\"Update access rules list.\"\"\""},{"line_number":458,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":459,"context_line":"            for access in access_rules:"},{"line_number":460,"context_line":"                if not self.check_access(share, access, share_server):"},{"line_number":461,"context_line":"                    self.allow_access(share, access, share_server)"},{"line_number":462,"context_line":"        else:"},{"line_number":463,"context_line":"            for access in add_rules:"},{"line_number":464,"context_line":"                self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_a63cadc8","line":461,"range":{"start_line":459,"start_character":11,"end_line":461,"end_character":66},"in_reply_to":"5a5ae5dd_cc0b318d","updated":"2016-02-06 09:05:30.000000000","message":"+1","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        access_id \u003d None"},{"line_number":499,"context_line":"        share_name \u003d share[\u0027name\u0027]"},{"line_number":500,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":501,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share[\u0027share_proto\u0027])"},{"line_number":502,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":503,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":504,"context_line":"        access_id \u003d self.helper._get_access_from_share(share[\u0027ID\u0027], access_to,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_81eb51db","line":501,"range":{"start_line":501,"start_character":57,"end_line":501,"end_character":77},"updated":"2016-02-24 13:01:21.000000000","message":"you are not using your new variable share_proto here","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"bc8603fbb7b8c1d0138391ac548764cc634efddc","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        access_id \u003d None"},{"line_number":499,"context_line":"        share_name \u003d share[\u0027name\u0027]"},{"line_number":500,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027]"},{"line_number":501,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share[\u0027share_proto\u0027])"},{"line_number":502,"context_line":"        access_to \u003d access[\u0027access_to\u0027]"},{"line_number":503,"context_line":"        share \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":504,"context_line":"        access_id \u003d self.helper._get_access_from_share(share[\u0027ID\u0027], access_to,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c8397f43","line":501,"range":{"start_line":501,"start_character":57,"end_line":501,"end_character":77},"in_reply_to":"bae84128_81eb51db","updated":"2016-02-27 08:16:02.000000000","message":"Done","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":728,"context_line":"            # Check if the access level equal"},{"line_number":729,"context_line":"            level_exist \u003d self.helper._get_level_by_access_id(access_id,"},{"line_number":730,"context_line":"                                                              share_proto)"},{"line_number":731,"context_line":"            if level_exist !\u003d access_level:"},{"line_number":732,"context_line":"                # Change the access level"},{"line_number":733,"context_line":"                self.helper._change_access_rest(access_id,"},{"line_number":734,"context_line":"                                                share_proto, access_level)"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            # Add this access to share"},{"line_number":737,"context_line":"            self.helper._allow_access_rest(share_id, access_to,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_818d11d5","line":734,"range":{"start_line":731,"start_character":11,"end_line":734,"end_character":74},"updated":"2016-02-24 13:01:21.000000000","message":"if you are in recovery mode, then rule should not exist. If you are not in recovery mode, the API will not allow tenant to add the same rule with different access_level before previous is removed, so this code is not going to be executed.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"bc8603fbb7b8c1d0138391ac548764cc634efddc","unresolved":false,"context_lines":[{"line_number":728,"context_line":"            # Check if the access level equal"},{"line_number":729,"context_line":"            level_exist \u003d self.helper._get_level_by_access_id(access_id,"},{"line_number":730,"context_line":"                                                              share_proto)"},{"line_number":731,"context_line":"            if level_exist !\u003d access_level:"},{"line_number":732,"context_line":"                # Change the access level"},{"line_number":733,"context_line":"                self.helper._change_access_rest(access_id,"},{"line_number":734,"context_line":"                                                share_proto, access_level)"},{"line_number":735,"context_line":"        else:"},{"line_number":736,"context_line":"            # Add this access to share"},{"line_number":737,"context_line":"            self.helper._allow_access_rest(share_id, access_to,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_48c1ef2d","line":734,"range":{"start_line":731,"start_character":11,"end_line":734,"end_character":74},"in_reply_to":"bae84128_818d11d5","updated":"2016-02-27 08:16:02.000000000","message":"Users have another ways to add rules(like the commond line of the storage system).\nThough, it\u0027s not a normal scene to add rules bypassing manila.\nIt\u0027s better to handle it.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"c34cf07e8e5ee85117fce7ed6cbaf337d87b35c2","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":760,"context_line":"            self.clear_access(share, share_server)"},{"line_number":761,"context_line":"            for access in access_rules:"},{"line_number":762,"context_line":"                    self.allow_access(share, access, share_server)"},{"line_number":763,"context_line":"        else:"},{"line_number":764,"context_line":"            for access in add_rules:"},{"line_number":765,"context_line":"                self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0eb81074","line":762,"range":{"start_line":762,"start_character":12,"end_line":762,"end_character":20},"updated":"2016-02-24 13:20:25.000000000","message":"remove double indentation","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"bc8603fbb7b8c1d0138391ac548764cc634efddc","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        if not (add_rules or delete_rules):"},{"line_number":760,"context_line":"            self.clear_access(share, share_server)"},{"line_number":761,"context_line":"            for access in access_rules:"},{"line_number":762,"context_line":"                    self.allow_access(share, access, share_server)"},{"line_number":763,"context_line":"        else:"},{"line_number":764,"context_line":"            for access in add_rules:"},{"line_number":765,"context_line":"                self.allow_access(share, access, share_server)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_28faab75","line":762,"range":{"start_line":762,"start_character":12,"end_line":762,"end_character":20},"in_reply_to":"bae84128_0eb81074","updated":"2016-02-27 08:16:02.000000000","message":"Done","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7b7f6d999da1e60e995dee4ea63a8351c4ae1efa","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":736,"context_line":"        share_stor \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":737,"context_line":"        if not share_stor:"},{"line_number":738,"context_line":"            LOG.warning(_LW(\u0027Can not get share %s.\u0027), share_name)"},{"line_number":739,"context_line":"            return"},{"line_number":740,"context_line":"        share_id \u003d share_stor[\u0027ID\u0027]"},{"line_number":741,"context_line":"        all_accesses \u003d self.helper._get_all_access_from_share(share_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_1d30b09d","line":738,"range":{"start_line":738,"start_character":29,"end_line":738,"end_character":36},"updated":"2016-02-28 20:02:31.000000000","message":"nit s/Can not/Cannot/","commit_id":"2e390dd90616236b4d31179bd4ecec957e66070b"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3942fa6443bb2cd615cffa67e89fce56f171a880","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        share_url_type \u003d self.helper._get_share_url_type(share_proto)"},{"line_number":736,"context_line":"        share_stor \u003d self.helper._get_share_by_name(share_name, share_url_type)"},{"line_number":737,"context_line":"        if not share_stor:"},{"line_number":738,"context_line":"            LOG.warning(_LW(\u0027Can not get share %s.\u0027), share_name)"},{"line_number":739,"context_line":"            return"},{"line_number":740,"context_line":"        share_id \u003d share_stor[\u0027ID\u0027]"},{"line_number":741,"context_line":"        all_accesses \u003d self.helper._get_all_access_from_share(share_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_0e54eec7","line":738,"range":{"start_line":738,"start_character":29,"end_line":738,"end_character":36},"in_reply_to":"9aed3d3a_1d30b09d","updated":"2016-02-29 08:31:37.000000000","message":"Done","commit_id":"2e390dd90616236b4d31179bd4ecec957e66070b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7b7f6d999da1e60e995dee4ea63a8351c4ae1efa","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            for access in access_rules:"},{"line_number":753,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":754,"context_line":"        else:"},{"line_number":755,"context_line":"            for access in add_rules:"},{"line_number":756,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":757,"context_line":"            for access in delete_rules:"},{"line_number":758,"context_line":"                self.deny_access(share, access, share_server)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def get_pool(self, share):"},{"line_number":761,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_bde8a4e3","line":758,"range":{"start_line":755,"start_character":12,"end_line":758,"end_character":61},"updated":"2016-02-28 20:02:31.000000000","message":"I don\u0027t know if it matters yet, but I\u0027d recommend doing deletes first so that, for example, a 1.2.3.4/RO is deleted before 1.2.3.4/RW is added instead of trying to do it in the other order.  I don\u0027t think the API contract says whether this will or won\u0027t happen in the future.","commit_id":"2e390dd90616236b4d31179bd4ecec957e66070b"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3942fa6443bb2cd615cffa67e89fce56f171a880","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            for access in access_rules:"},{"line_number":753,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":754,"context_line":"        else:"},{"line_number":755,"context_line":"            for access in add_rules:"},{"line_number":756,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":757,"context_line":"            for access in delete_rules:"},{"line_number":758,"context_line":"                self.deny_access(share, access, share_server)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def get_pool(self, share):"},{"line_number":761,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_eefeeaac","line":758,"range":{"start_line":755,"start_character":12,"end_line":758,"end_character":61},"in_reply_to":"9aed3d3a_bde8a4e3","updated":"2016-02-29 08:31:37.000000000","message":"Thanks for reminding.","commit_id":"2e390dd90616236b4d31179bd4ecec957e66070b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"aae4457327e2b879df30c1864df091d3cf0e9683","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            for access in access_rules:"},{"line_number":753,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":754,"context_line":"        else:"},{"line_number":755,"context_line":"            for access in add_rules:"},{"line_number":756,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":757,"context_line":"            for access in delete_rules:"},{"line_number":758,"context_line":"                self.deny_access(share, access, share_server)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def get_pool(self, share):"},{"line_number":761,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_cf15ede5","line":758,"range":{"start_line":755,"start_character":12,"end_line":758,"end_character":61},"in_reply_to":"9aed3d3a_bde8a4e3","updated":"2016-02-29 00:07:40.000000000","message":"The API contract makes no guarantees, and backends should do what works for them.  In my case, I do the adds before the deletes in order to prevent any transient interruption of access.\n\nhttps://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/protocols/cifs_cmode.py#L66","commit_id":"2e390dd90616236b4d31179bd4ecec957e66070b"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"3942fa6443bb2cd615cffa67e89fce56f171a880","unresolved":false,"context_lines":[{"line_number":752,"context_line":"            for access in access_rules:"},{"line_number":753,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":754,"context_line":"        else:"},{"line_number":755,"context_line":"            for access in add_rules:"},{"line_number":756,"context_line":"                self.allow_access(share, access, share_server)"},{"line_number":757,"context_line":"            for access in delete_rules:"},{"line_number":758,"context_line":"                self.deny_access(share, access, share_server)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"    def get_pool(self, share):"},{"line_number":761,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_8e80fef8","line":758,"range":{"start_line":755,"start_character":12,"end_line":758,"end_character":61},"in_reply_to":"9aed3d3a_cf15ede5","updated":"2016-02-29 08:31:37.000000000","message":"The deny_access of huawei driver did not check level.\nSo if Mark\u0027s example happend, it\u0027s safer to delete before add.","commit_id":"2e390dd90616236b4d31179bd4ecec957e66070b"}],"manila/share/drivers/huawei/v3/helper.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"c34cf07e8e5ee85117fce7ed6cbaf337d87b35c2","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    def _get_all_access_from_share(self, share_id, share_proto):"},{"line_number":397,"context_line":"        \"\"\"Return a list of all the access IDs of the share\"\"\""},{"line_number":398,"context_line":"        share_client_type \u003d self._get_share_client_type(share_proto)"},{"line_number":399,"context_line":"        count \u003d self._get_access_from_count(share_id, share_client_type)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        access_ids \u003d []"},{"line_number":402,"context_line":"        range_begin \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_640f3b37","line":399,"range":{"start_line":399,"start_character":21,"end_line":399,"end_character":43},"updated":"2016-02-24 13:20:25.000000000","message":"this method retrieves the number of access. Please rename it to _get_access_count","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":16652,"name":"zhaohua","email":"nk-zh@163.com","username":"zhaohua"},"change_message_id":"bc8603fbb7b8c1d0138391ac548764cc634efddc","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    def _get_all_access_from_share(self, share_id, share_proto):"},{"line_number":397,"context_line":"        \"\"\"Return a list of all the access IDs of the share\"\"\""},{"line_number":398,"context_line":"        share_client_type \u003d self._get_share_client_type(share_proto)"},{"line_number":399,"context_line":"        count \u003d self._get_access_from_count(share_id, share_client_type)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        access_ids \u003d []"},{"line_number":402,"context_line":"        range_begin \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c887bfd5","line":399,"range":{"start_line":399,"start_character":21,"end_line":399,"end_character":43},"in_reply_to":"bae84128_640f3b37","updated":"2016-02-27 08:16:02.000000000","message":"Done","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3c229461879315a88db2bf6407ef72ab9e1b6a5","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            access_level \u003d access_info.get(\u0027PERMISSION\u0027)"},{"line_number":456,"context_line":"        return access_level"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _change_access_rest(self, access_id,"},{"line_number":459,"context_line":"                            share_proto, access_level):"},{"line_number":460,"context_line":"        \"\"\"Change access level of the share.\"\"\""},{"line_number":461,"context_line":"        if share_proto \u003d\u003d \u0027NFS\u0027:"},{"line_number":462,"context_line":"            self._change_nfs_access_rest(access_id, access_level)"},{"line_number":463,"context_line":"        elif share_proto \u003d\u003d \u0027CIFS\u0027:"},{"line_number":464,"context_line":"            self._change_cifs_access_rest(access_id, access_level)"},{"line_number":465,"context_line":"        else:"},{"line_number":466,"context_line":"            raise exception.InvalidInput("},{"line_number":467,"context_line":"                reason\u003d(_(\u0027Invalid NAS protocol supplied: %s.\u0027)"},{"line_number":468,"context_line":"                        % share_proto))"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _change_nfs_access_rest(self, access_id, access_level):"},{"line_number":471,"context_line":"        url \u003d \"/NFS_SHARE_AUTH_CLIENT/\" + access_id"},{"line_number":472,"context_line":"        access \u003d {"},{"line_number":473,"context_line":"            \"ACCESSVAL\": access_level,"},{"line_number":474,"context_line":"            \"SYNC\": \"0\","},{"line_number":475,"context_line":"            \"ALLSQUASH\": \"1\","},{"line_number":476,"context_line":"            \"ROOTSQUASH\": \"0\","},{"line_number":477,"context_line":"        }"},{"line_number":478,"context_line":"        data \u003d jsonutils.dumps(access)"},{"line_number":479,"context_line":"        result \u003d self.call(url, data, \"PUT\")"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        msg \u003d \u0027Change access error.\u0027"},{"line_number":482,"context_line":"        self._assert_rest_result(result, msg)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _change_cifs_access_rest(self, access_id, access_level):"},{"line_number":485,"context_line":"        url \u003d \"/CIFS_SHARE_AUTH_CLIENT/\" + access_id"},{"line_number":486,"context_line":"        access \u003d {"},{"line_number":487,"context_line":"            \"PERMISSION\": access_level,"},{"line_number":488,"context_line":"        }"},{"line_number":489,"context_line":"        data \u003d jsonutils.dumps(access)"},{"line_number":490,"context_line":"        result \u003d self.call(url, data, \"PUT\")"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        msg \u003d \u0027Change access error.\u0027"},{"line_number":493,"context_line":"        self._assert_rest_result(result, msg)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def _allow_access_rest(self, share_id, access_to,"},{"line_number":496,"context_line":"                           share_proto, access_level):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_446677ed","line":493,"range":{"start_line":458,"start_character":0,"end_line":493,"end_character":45},"updated":"2016-02-24 13:01:21.000000000","message":"according to my comment in other file, this would not be used.","commit_id":"c8a16017e18e82e2d1ee33cc8df9fabc5fab6422"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"386c74a4aad58000a6da26992412b2dd202c856e","unresolved":false,"context_lines":[{"line_number":408,"context_line":"            for item in access_range:"},{"line_number":409,"context_line":"                access_ids.append(item[\u0027ID\u0027])"},{"line_number":410,"context_line":"            range_begin +\u003d 100"},{"line_number":411,"context_line":"            count -\u003d 100"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        return access_ids"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_ca0ae978","line":411,"updated":"2016-02-29 11:41:26.000000000","message":"Maybe I missed previous discussions about it - is this a limitation of the backend that you can only get 100 rules a time?\nNot sure how long this can take (when thousand of rules are there) but this loop is blocking the whole driver when executed.","commit_id":"2844ed7fe81c4bbe9d944364b5092c9da29b0b7b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"5c1c41ac6751d50f537db3436a6f26e7935f4639","unresolved":false,"context_lines":[{"line_number":437,"context_line":"    def _get_access_from_share_range(self, share_id,"},{"line_number":438,"context_line":"                                     range_begin,"},{"line_number":439,"context_line":"                                     share_client_type):"},{"line_number":440,"context_line":"        range_end \u003d range_begin + 100"},{"line_number":441,"context_line":"        url \u003d (\"/\" + share_client_type + \"?filter\u003dPARENTID::\""},{"line_number":442,"context_line":"               + share_id + \"\u0026range\u003d[\" + six.text_type(range_begin)"},{"line_number":443,"context_line":"               + \"-\" + six.text_type(range_end) + \"]\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_6d1e40bc","line":440,"range":{"start_line":440,"start_character":8,"end_line":440,"end_character":37},"updated":"2016-02-29 17:37:44.000000000","message":"Is this inclusive? 0-100, 100-200, 200-300: If it is up-to-but-not-including range_end, that is good. If it includes the range ends then you are getting 100,200,... twice. If that is the case, you want 0-99,100-199,200-299 instead.","commit_id":"2844ed7fe81c4bbe9d944364b5092c9da29b0b7b"}],"manila/tests/share/drivers/huawei/test_huawei_nas.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dcd46b55388de792ed8d2052cc8f3d0f4097aa8","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"        self.allow_rw_flag \u003d False"},{"line_number":1239,"context_line":"        self.deny_flag \u003d False"},{"line_number":1240,"context_line":"        add_rules \u003d [self.access_ip]"},{"line_number":1241,"context_line":"        delete_rules \u003d [self.access_ip]"},{"line_number":1242,"context_line":"        self.driver.update_access(self._context,"},{"line_number":1243,"context_line":"                                  self.share_nfs,"},{"line_number":1244,"context_line":"                                  None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_269d1dbc","line":1241,"updated":"2016-02-06 09:05:30.000000000","message":"you should test with different rules","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dcd46b55388de792ed8d2052cc8f3d0f4097aa8","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"        self.allow_flag \u003d False"},{"line_number":1255,"context_line":"        self.allow_rw_flag \u003d False"},{"line_number":1256,"context_line":"        rules \u003d [self.access_ip]"},{"line_number":1257,"context_line":"        self.mock_object(self.driver.plugin.helper,"},{"line_number":1258,"context_line":"                         \u0027_get_access_from_share\u0027,"},{"line_number":1259,"context_line":"                         mock.Mock(return_value\u003dNone))"},{"line_number":1260,"context_line":"        self.driver.update_access(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_a6b10d49","line":1257,"range":{"start_line":1257,"start_character":13,"end_line":1257,"end_character":24},"updated":"2016-02-06 09:05:30.000000000","message":"you should assert that the mocked method was called with expected params","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dcd46b55388de792ed8d2052cc8f3d0f4097aa8","unresolved":false,"context_lines":[{"line_number":1271,"context_line":"        self.allow_flag \u003d False"},{"line_number":1272,"context_line":"        self.allow_rw_flag \u003d False"},{"line_number":1273,"context_line":"        rules \u003d [self.access_ip]"},{"line_number":1274,"context_line":"        self.mock_object(self.driver.plugin.helper,"},{"line_number":1275,"context_line":"                         \u0027_get_access_from_share\u0027,"},{"line_number":1276,"context_line":"                         mock.Mock(return_value\u003d\"exists_access_id\"))"},{"line_number":1277,"context_line":"        self.driver.update_access(self._context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_66b7953a","line":1274,"updated":"2016-02-06 09:05:30.000000000","message":"here too","commit_id":"629feb2efd8606107361a7626f83ccc88a1772d3"}]}
