)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c1e676aca4e48c605f27e4475895c766e5451875","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nidhimittalhada \u003cnidhimittal19@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-19 15:53:09 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"wait for access-rule() is reqd. in tempest-client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tempest.clients_share call wait_for_resource_deletion"},{"line_number":10,"context_line":"does not accept acccess-rule ids and there is no other"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_d776b13d","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":31},"updated":"2016-01-21 09:59:52.000000000","message":"\"is reqd.\"?\n\nAnyway, topic can be much better:\n\n\"\"\"\nAdd access rule deletion waiter to tempest plugin\n\"\"\"","commit_id":"65efeac33a5e2d62c35e8c0ecfb31f936930df92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c1e676aca4e48c605f27e4475895c766e5451875","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"wait for access-rule() is reqd. in tempest-client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tempest.clients_share call wait_for_resource_deletion"},{"line_number":10,"context_line":"does not accept acccess-rule ids and there is no other"},{"line_number":11,"context_line":"call for waiting for access-rule deletion."},{"line_number":12,"context_line":"Hence creating same."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I099bdf66eb5e5b6468fde275754694638304cf10"},{"line_number":15,"context_line":"Closes-Bug: #1429952"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a68dd71_9704b97e","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":20},"updated":"2016-01-21 09:59:52.000000000","message":"In bug description it is said that it existed and was deleted as unused. So, it would be correct to implement that you are implementing here with usage of it. Not adding it as unused again.","commit_id":"65efeac33a5e2d62c35e8c0ecfb31f936930df92"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"does not accept acccess-rule ids and there is no other"},{"line_number":11,"context_line":"call for waiting for access-rule deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As bug descriptions says, one usecase is, if we delete"},{"line_number":14,"context_line":"an access rule and  try to mount the share on nas client."},{"line_number":15,"context_line":"In case mount via ssh is faster than access rule deletion,"},{"line_number":16,"context_line":"we might get false results and then this wait function"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a68dd71_90bdf603","line":13,"range":{"start_line":13,"start_character":30,"end_line":13,"end_character":37},"updated":"2016-01-25 17:14:36.000000000","message":"s/usecase/use case/","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"call for waiting for access-rule deletion."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"As bug descriptions says, one usecase is, if we delete"},{"line_number":14,"context_line":"an access rule and  try to mount the share on nas client."},{"line_number":15,"context_line":"In case mount via ssh is faster than access rule deletion,"},{"line_number":16,"context_line":"we might get false results and then this wait function"},{"line_number":17,"context_line":"is required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a68dd71_d0e04e2b","line":14,"updated":"2016-01-25 17:14:36.000000000","message":"there\u0027s an extra space between \u0027and\u0027 and \u0027try\u0027","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"}],"manila_tempest_tests/services/share/json/shares_client.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            rule_found \u003d False"},{"line_number":295,"context_line":"            rules \u003d self.list_access_rules(share_id)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"            for rule in rules:"},{"line_number":298,"context_line":"                if rule[\"id\"] \u003d\u003d rule_id:"},{"line_number":299,"context_line":"                    rule_found \u003d True"},{"line_number":300,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_4405830e","line":297,"updated":"2016-01-25 17:14:36.000000000","message":"python\u0027s for/else can make this nicer","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            for rule in rules:"},{"line_number":298,"context_line":"                if rule[\"id\"] \u003d\u003d rule_id:"},{"line_number":299,"context_line":"                    rule_found \u003d True"},{"line_number":300,"context_line":"                    break"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            if not rule_found:"},{"line_number":303,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_1011065d","line":300,"updated":"2016-01-25 17:14:36.000000000","message":"Use for/else so you don\u0027t need the rule_found","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                    rule_found \u003d True"},{"line_number":300,"context_line":"                    break"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            if not rule_found:"},{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            elif rule_found and (int(time.time()) - start \u003e\u003d"},{"line_number":305,"context_line":"                                 self.build_timeout):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_442ca398","line":302,"updated":"2016-01-25 17:14:36.000000000","message":"Using for/else this is just:\nelse:\n   break","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"            if not rule_found:"},{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            elif rule_found and (int(time.time()) - start \u003e\u003d"},{"line_number":305,"context_line":"                                 self.build_timeout):"},{"line_number":306,"context_line":"                message \u003d (\u0027access rule %s failed to be deleted within\u0027"},{"line_number":307,"context_line":"                           \u0027 the required time (%s s).\u0027 %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_c46653ec","line":304,"updated":"2016-01-25 17:14:36.000000000","message":"Here you already know rule_found, so:\ns/elif rule_found and/if/","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                break"},{"line_number":304,"context_line":"            elif rule_found and (int(time.time()) - start \u003e\u003d"},{"line_number":305,"context_line":"                                 self.build_timeout):"},{"line_number":306,"context_line":"                message \u003d (\u0027access rule %s failed to be deleted within\u0027"},{"line_number":307,"context_line":"                           \u0027 the required time (%s s).\u0027 %"},{"line_number":308,"context_line":"                           (rule_id, self.build_timeout))"},{"line_number":309,"context_line":"                raise exceptions.TimeoutException(message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_84e13b2c","line":306,"updated":"2016-01-25 17:14:36.000000000","message":"s/access/Access/","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fd89849e5830ceaf16e0b0d412c3d8700e55ed6f","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                           \u0027 the required time (%s s).\u0027 %"},{"line_number":308,"context_line":"                           (rule_id, self.build_timeout))"},{"line_number":309,"context_line":"                raise exceptions.TimeoutException(message)"},{"line_number":310,"context_line":"            else:"},{"line_number":311,"context_line":"                time.sleep(self.build_interval)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def default_quotas(self, tenant_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_848a9b62","line":310,"updated":"2016-01-25 17:14:36.000000000","message":"Don\u0027t need the else:  If you get past the above just sleep and loop.","commit_id":"1391d5938e7b03d82ff5fbac140a76f50815fbbc"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c1e676aca4e48c605f27e4475895c766e5451875","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        body \u003d {self._get_access_action_name(version, \u0027os-access_list\u0027): None}"},{"line_number":404,"context_line":"        resp, body \u003d self.post("},{"line_number":405,"context_line":"            \"shares/%s/action\" % share_id, json.dumps(body), version\u003dversion)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":408,"context_line":"        return self._parse_resp(body)"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_371e2d0d","line":406,"updated":"2016-01-21 09:59:52.000000000","message":"Why new line is added here?","commit_id":"65efeac33a5e2d62c35e8c0ecfb31f936930df92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c1e676aca4e48c605f27e4475895c766e5451875","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":421,"context_line":"        return body"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def wait_for_access_rule_deletion(self, share_id, rule_id,"},{"line_number":424,"context_line":"                                      version\u003dLATEST_MICROVERSION):"},{"line_number":425,"context_line":"        \"\"\"Waits for a access rule to be deleted.\"\"\""},{"line_number":426,"context_line":"        start \u003d int(time.time())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_17e8c9e1","line":423,"range":{"start_line":423,"start_character":8,"end_line":423,"end_character":37},"updated":"2016-01-21 09:59:52.000000000","message":"logic of this method is compatible with v1 too. So, why it is exactly in v2 and not available for v1?","commit_id":"65efeac33a5e2d62c35e8c0ecfb31f936930df92"}]}