)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c305a371e660367afb2c4acbd6c1c088149603cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yangyapeng \u003cyang.yapeng@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-18 03:36:36 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the environment variable about  venv_path venv_dir in run_test.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Execute run.test.sh export venv_path venv_dir venv_name,this is not"},{"line_number":10,"context_line":"the correct path."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_e4cb1371","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":72},"updated":"2016-01-19 10:48:25.000000000","message":"Fix usage of env vars in run_tests.sh","commit_id":"01ce4575adb24c4019580c72a4bcb4c378feb7a7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c305a371e660367afb2c4acbd6c1c088149603cc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the environment variable about  venv_path venv_dir in run_test.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Execute run.test.sh export venv_path venv_dir venv_name,this is not"},{"line_number":10,"context_line":"the correct path."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closed-Bug :#1535514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_445e9fea","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":19},"updated":"2016-01-19 10:48:25.000000000","message":"run.test.sh ? There is no such file in Manila. Manila has \"run_tests.sh\"","commit_id":"01ce4575adb24c4019580c72a4bcb4c378feb7a7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c305a371e660367afb2c4acbd6c1c088149603cc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Execute run.test.sh export venv_path venv_dir venv_name,this is not"},{"line_number":10,"context_line":"the correct path."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closed-Bug :#1535514"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id8adf1fc11d04ed5779e6de05ca5a4166c32f9e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_249e0b57","line":11,"updated":"2016-01-19 10:48:25.000000000","message":"Script \u0027run_tests.sh\u0027 exports env vars called \u0027venv_dir\u0027 and \u0027venv_name\u0027, but tools for setup of venv expect them in uppercase. Fix it by setting lowercase in both places.","commit_id":"01ce4575adb24c4019580c72a4bcb4c378feb7a7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c305a371e660367afb2c4acbd6c1c088149603cc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Execute run.test.sh export venv_path venv_dir venv_name,this is not"},{"line_number":10,"context_line":"the correct path."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closed-Bug :#1535514"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id8adf1fc11d04ed5779e6de05ca5a4166c32f9e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_e448f32f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":20},"updated":"2016-01-19 10:48:25.000000000","message":"Closed-Bug: #1535514","commit_id":"01ce4575adb24c4019580c72a4bcb4c378feb7a7"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"812348bb16f92103a9fdf4c5258d655182b25dfc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Execute run.test.sh export venv_path venv_dir venv_name,this is not"},{"line_number":10,"context_line":"the correct path."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closed-Bug :#1535514"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id8adf1fc11d04ed5779e6de05ca5a4166c32f9e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba63e191_3f035b0f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":20},"in_reply_to":"ba63e191_e448f32f","updated":"2016-01-19 17:25:52.000000000","message":"Closes-Bug: #1535514","commit_id":"01ce4575adb24c4019580c72a4bcb4c378feb7a7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f60c206ad90c4f28ae256eab364f3204b62528e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yangyapeng \u003cyang.yapeng@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-18 07:57:26 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the environment variable about  venv_path venv_dir in run_test.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Execute run_test.sh export the env vars \u0027venv_path\u0027 and \u0027venv_dir\u0027 and"},{"line_number":10,"context_line":" \u0027venv_name\u0027,but tools for setup of venv expect them in uppercase."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_e030a0a0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":72},"updated":"2016-02-04 15:01:09.000000000","message":"Please, rename it to something like following:\n\n\"\"\"\nFix usage of env vars in run_tests.sh\n\"\"\"","commit_id":"c64b7cf9e1f1b9e0a2b7b8dc94469f9e34fbb9b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f60c206ad90c4f28ae256eab364f3204b62528e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify the environment variable about  venv_path venv_dir in run_test.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Execute run_test.sh export the env vars \u0027venv_path\u0027 and \u0027venv_dir\u0027 and"},{"line_number":10,"context_line":" \u0027venv_name\u0027,but tools for setup of venv expect them in uppercase."},{"line_number":11,"context_line":"Fix it by setting lowercase in both places."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_20c1d82e","line":9,"updated":"2016-02-04 15:01:09.000000000","message":"s/run_test.sh/run_tests.sh/\n\nAlso, it looks not-english-like.\n\nbetter to say:\n\n\"\"\"\nScript \u0027run_tests.sh\u0027 exports env vars called \u0027venv_dir\u0027 and \u0027venv_name\u0027, but tools for setup of venv expect them in uppercase. Fix it by setting lowercase in both places.\n\"\"\"","commit_id":"c64b7cf9e1f1b9e0a2b7b8dc94469f9e34fbb9b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8f60c206ad90c4f28ae256eab364f3204b62528e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modify the environment variable about  venv_path venv_dir in run_test.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Execute run_test.sh export the env vars \u0027venv_path\u0027 and \u0027venv_dir\u0027 and"},{"line_number":10,"context_line":" \u0027venv_name\u0027,but tools for setup of venv expect them in uppercase."},{"line_number":11,"context_line":"Fix it by setting lowercase in both places."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1535514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_40973448","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":14},"updated":"2016-02-04 15:01:09.000000000","message":"space is lost between comma and word","commit_id":"c64b7cf9e1f1b9e0a2b7b8dc94469f9e34fbb9b3"}],"tools/install_venv.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"a6930b3d7c888e38894fd2933f49fcf7ccbe8206","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def main(argv):"},{"line_number":49,"context_line":"    root \u003d os.path.dirname(os.path.dirname(os.path.realpath(__file__)))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if os.environ.get(\u0027tools_path\u0027):"},{"line_number":52,"context_line":"        root \u003d os.environ[\u0027tools_path\u0027]"},{"line_number":53,"context_line":"    venv \u003d os.path.join(root, \u0027.venv\u0027)"},{"line_number":54,"context_line":"    if os.environ.get(\u0027venv\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_23d1b823","line":51,"updated":"2016-02-05 09:53:20.000000000","message":"How should this work? run_tests.sh never exports the variable \"tools_path\" only \"tools_dir\"","commit_id":"c64b7cf9e1f1b9e0a2b7b8dc94469f9e34fbb9b3"}]}
