)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bed5d12fd6c9ab9b8ae88020926f6158099f0908","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Ceph Native driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I33801215f64eacb9dade4d92f11f659173abb7f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_29e7e441","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":52},"updated":"2016-01-20 14:58:23.000000000","message":"Please add launchpad blueprint link","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Ceph Native driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I33801215f64eacb9dade4d92f11f659173abb7f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a68dd71_f5243bb3","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":52},"in_reply_to":"9a68dd71_29e7e441","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-01-26 17:32:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Ceph Native driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint cephfs-driver"},{"line_number":10,"context_line":"Change-Id: I33801215f64eacb9dade4d92f11f659173abb7f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a68dd71_3ddce345","line":8,"updated":"2016-01-26 19:21:41.000000000","message":"I would add some form of description in here as to what the CEPH driver does. A brief summary should suffice. Have a look at the LVM driver\u0027s commit message for an idea of what to do: https://review.openstack.org/#/c/232970/","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Ramana Raja \u003crraja@redhat.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: If33e6d847d3c1e6a72ce334b645b45538576058d"},{"line_number":18,"context_line":"Implements: blueprint cephfs-driver"},{"line_number":19,"context_line":"Change-Id: I33801215f64eacb9dade4d92f11f659173abb7f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a5ae5dd_c619fc89","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":53},"updated":"2016-02-04 17:08:40.000000000","message":"Shouldn\u0027t this be the other way around? the client patch depends on the server patch?","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"03feb70f7e39b4917c3cae6c1c4e624b4fc576ad","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Ramana Raja \u003crraja@redhat.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: If33e6d847d3c1e6a72ce334b645b45538576058d"},{"line_number":18,"context_line":"Implements: blueprint cephfs-driver"},{"line_number":19,"context_line":"Change-Id: I33801215f64eacb9dade4d92f11f659173abb7f5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a5ae5dd_bff2be6d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":53},"in_reply_to":"5a5ae5dd_c619fc89","updated":"2016-02-09 02:11:43.000000000","message":"Does it matter?  The reason I\u0027ve done it this way round is that the server depends on the client patch for its tempest tests to pass, but the client patch does not depend on the server for its tests to pass.","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33a60d17268125f51d19862b8320e727397cca66","unresolved":false,"context_lines":[{"line_number":11,"context_line":"client to access the share.  The interface"},{"line_number":12,"context_line":"to Ceph is CephFSVolumeClient, included in"},{"line_number":13,"context_line":"the \u0027Jewel\u0027 Ceph release and later."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Ramana Raja \u003crraja@redhat.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: If33e6d847d3c1e6a72ce334b645b45538576058d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"9aed3d3a_3caaf170","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2016-02-27 03:24:28.000000000","message":"Please add an \"APIImpact\" flag:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"256a86e1dad1abc88d3ca47b542a5d5b2363abc1"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"26f251fca0828759ca074353e2883f40ad29725b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"client to access the share.  The interface"},{"line_number":12,"context_line":"to Ceph is CephFSVolumeClient, included in"},{"line_number":13,"context_line":"the \u0027Jewel\u0027 Ceph release and later."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Ramana Raja \u003crraja@redhat.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: If33e6d847d3c1e6a72ce334b645b45538576058d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"9aed3d3a_785bc0f6","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"9aed3d3a_3caaf170","updated":"2016-02-29 07:16:59.000000000","message":"Done","commit_id":"256a86e1dad1abc88d3ca47b542a5d5b2363abc1"}],"doc/source/devref/cephfs_native_driver.rst":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":2,"context_line":"CephFS Native driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The CephFS Native driver enables Manila to export shared filesystems to guests"},{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_aa4640bd","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":39},"updated":"2016-01-28 01:10:21.000000000","message":"s/Manila/manila/ maybe watch this review which is aiming for consistency with that: https://review.openstack.org/#/c/272158/","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"CephFS Native driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The CephFS Native driver enables Manila to export shared filesystems to guests"},{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_b06b4e1d","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":39},"in_reply_to":"7a5de9d1_aa4640bd","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"},{"line_number":10,"context_line":"a distinct authentication key that must be passed to clients for them to use it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prerequisities"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- A Ceph cluster with a filesystem configured (http://docs.ceph.com/docs/master/cephfs/createfs/)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_2ad6d0c5","line":12,"updated":"2016-01-28 01:10:21.000000000","message":"Look at the docs job output. Only \"CephFS Native Driver\" should be top-level and Prerequisites... should be indented. For Ceph Prereq... is top-level.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"},{"line_number":10,"context_line":"a distinct authentication key that must be passed to clients for them to use it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prerequisities"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- A Ceph cluster with a filesystem configured (http://docs.ceph.com/docs/master/cephfs/createfs/)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_f0e9c67f","line":12,"in_reply_to":"7a5de9d1_2ad6d0c5","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and your manila server"},{"line_number":17,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. important:: A Manila share backed onto CephFS is only as good as the underlying filesystem.  Take"},{"line_number":20,"context_line":"               care when configuring your Ceph cluster, and consult the latest guidance on the use of"},{"line_number":21,"context_line":"               CephFS in the Ceph documentation (http://docs.ceph.com/docs/master/cephfs/)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_0a0c3493","line":19,"updated":"2016-01-28 01:10:21.000000000","message":"s/Manila/manila/","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and your manila server"},{"line_number":17,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. important:: A Manila share backed onto CephFS is only as good as the underlying filesystem.  Take"},{"line_number":20,"context_line":"               care when configuring your Ceph cluster, and consult the latest guidance on the use of"},{"line_number":21,"context_line":"               CephFS in the Ceph documentation (http://docs.ceph.com/docs/master/cephfs/)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_7071560b","line":19,"in_reply_to":"7a5de9d1_0a0c3493","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":19733,"name":"Devin","email":"genghang888@gmail.com","username":"HangGeng"},"change_message_id":"1939bf39b21a0466c32182836083178b2c2b9b72","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Authorize the driver to communicate with Ceph"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_a15c1e26","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":2},"updated":"2016-01-28 06:51:50.000000000","message":"It\u0027s should be.. code-block:: console ？See http://docs.openstack.org/contributor-guide/rst-conv.html on Documentation conventions.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Authorize the driver to communicate with Ceph"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_70df16d6","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":2},"in_reply_to":"7a5de9d1_a15c1e26","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_8afca43f","line":27,"updated":"2016-01-28 01:10:21.000000000","message":"This long command looks strange. I think something such as \"Run the following command:\" would help some.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"::"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_10f1026b","line":27,"in_reply_to":"7a5de9d1_8afca43f","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":31,"context_line":"on your manila server, and the paths to these configured in your manila.conf."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_dda9077d","line":31,"range":{"start_line":31,"start_character":3,"end_line":31,"end_character":21},"updated":"2016-01-26 19:21:41.000000000","message":"This could be clarified to be \"the server where your Manila services are running\". As it reads it might imply that the CephFS server might be the Manila server.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":31,"context_line":"on your manila server, and the paths to these configured in your manila.conf."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_908c12db","line":31,"range":{"start_line":31,"start_character":3,"end_line":31,"end_character":21},"in_reply_to":"9a68dd71_dda9077d","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"on your manila server, and the paths to these configured in your manila.conf."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"::etc"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_5debd7b0","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":25},"updated":"2016-01-26 19:21:41.000000000","message":"The comma can be removed.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"on your manila server, and the paths to these configured in your manila.conf."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"::etc"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_70f6365e","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":25},"in_reply_to":"7a5de9d1_6a9a8816","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":31,"context_line":"on your manila server, and the paths to these configured in your manila.conf."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"::etc"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_6a9a8816","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":25},"in_reply_to":"9a68dd71_5debd7b0","updated":"2016-01-28 01:10:21.000000000","message":"s/Manila/manila/","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"::etc"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_8a9344fa","line":36,"updated":"2016-01-28 01:10:21.000000000","message":"Not sure what the ::etc followed by a command means.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Enable snapshots in Ceph, if you want to use them in Manila:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"::etc"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_d09daa0a","line":36,"in_reply_to":"7a5de9d1_8a9344fa","updated":"2016-02-02 00:23:45.000000000","message":"typo, fixed.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Configure CephFS Backend in manila.conf"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Add CephFS to ``enabled_share_protocols`` (enforced at manila api layer)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_8a810492","line":40,"updated":"2016-01-28 01:10:21.000000000","message":"s/Backend/backend/ -- unless that is part of some CephFS naming standard.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Configure CephFS Backend in manila.conf"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Add CephFS to ``enabled_share_protocols`` (enforced at manila api layer)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_b087ceb3","line":40,"in_reply_to":"7a5de9d1_8a810492","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"::"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    enabled_share_protocols \u003d NFS,CIFS,CEPHFS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Create a section like this (defines a backend):"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_ea5bd852","line":47,"updated":"2016-01-28 01:10:21.000000000","message":"You might want to explain that NFS,CIFS aren\u0027t needed for you.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"::"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    enabled_share_protocols \u003d NFS,CIFS,CEPHFS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Create a section like this (defines a backend):"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_10bfc261","line":47,"in_reply_to":"7a5de9d1_ea5bd852","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    enabled_share_protocols \u003d NFS,CIFS,CEPHFS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Create a section like this (defines a backend):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"::"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_7d781bf9","line":49,"updated":"2016-01-26 19:21:41.000000000","message":"I\u0027d make this a little more specific, something like \"Create a section that defines the CephFS backend.\"","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    enabled_share_protocols \u003d NFS,CIFS,CEPHFS"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Create a section like this (defines a backend):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"::"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_d0b4ca82","line":49,"in_reply_to":"9a68dd71_7d781bf9","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":19733,"name":"Devin","email":"genghang888@gmail.com","username":"HangGeng"},"change_message_id":"1939bf39b21a0466c32182836083178b2c2b9b72","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Create a section like this (defines a backend):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    [cephfs1]"},{"line_number":54,"context_line":"    driver_handles_share_servers \u003d False"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_c1d03a56","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"updated":"2016-01-28 06:51:50.000000000","message":"It\u0027s should be.. code-block:: ini ？See http://docs.openstack.org/contributor-guide/rst-conv.html on Documentation conventions.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Create a section like this (defines a backend):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    [cephfs1]"},{"line_number":54,"context_line":"    driver_handles_share_servers \u003d False"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_70a4f649","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":2},"in_reply_to":"7a5de9d1_c1d03a56","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cephfs_conf_path \u003d /etc/ceph/ceph.conf"},{"line_number":58,"context_line":"    cephfs_auth_id \u003d manila"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":" * Then edit ``enabled_share_backends`` to point to it"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_1d51df62","line":60,"updated":"2016-01-26 19:21:41.000000000","message":"I\u0027d make a note here that the user must provide the name given between the square brackets in the backend definition. Something like \"make sure to use the same name that was provided in the square brackets in the backend definition\"","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cephfs_conf_path \u003d /etc/ceph/ceph.conf"},{"line_number":58,"context_line":"    cephfs_auth_id \u003d manila"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":" * Then edit ``enabled_share_backends`` to point to it"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"::"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_d0428a67","line":60,"in_reply_to":"9a68dd71_1d51df62","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Creating shares"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"The default share type may have driver_handles_share_servers set to true.  Configure"},{"line_number":74,"context_line":"a share type suitable for cephfs:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_1dff9f35","line":73,"updated":"2016-01-26 19:21:41.000000000","message":"I\u0027d leave the first line but change the second line to: \"Since the CephFS driver currently does not support handling share servers, you will need to configure a share type suitable for CephFS:\"","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"The default share type may have driver_handles_share_servers set to true.  Configure"},{"line_number":74,"context_line":"a share type suitable for cephfs:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"::"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a5de9d1_aa03a00e","line":74,"updated":"2016-01-28 01:10:21.000000000","message":"I think you use CephFS here.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    manila create --share-type cephfstype --name cephshare1 cephfs 1"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Mounting a client with FUSE"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Using the key from your export location, and the share ID, create a keyring file like"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_7881094d","line":87,"updated":"2016-01-26 19:21:41.000000000","message":"You might want to add any sort of prerequisites needed in the Nova instance to mount a CephFS share with FUSE.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Mounting a client with FUSE"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Using the key from your export location, and the share ID, create a keyring file like"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"::"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_5d48b787","line":90,"updated":"2016-01-26 19:21:41.000000000","message":"I\u0027d add a line in here to show how to get the export location and the share ID. I\u0027d also want to make it explicit that we are creating a new keyring file named \"client.keyring\".","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Mounting a client with FUSE"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Using the key from your export location, and the share ID, create a keyring file like"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"::"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_dd54a722","line":90,"range":{"start_line":90,"start_character":39,"end_line":90,"end_character":40},"updated":"2016-01-26 19:21:41.000000000","message":"This comma can be removed","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    [client.share-4c55ad20-9c55-4a5e-9233-8ac64566b98c]"},{"line_number":95,"context_line":"            key \u003d AQA8+ANW/4ZWNRAAOtWJMFPEihBA1unFImJczA\u003d\u003d"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Using the mon IP addresses from your export location, create a ceph.conf file like:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"::"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_78cfc9b3","line":97,"updated":"2016-01-26 19:21:41.000000000","message":"I\u0027d add a line in here to show where you get the monitor IP addresses from the export location. I\u0027d also spell out that mon\u003dmonitor for clarity.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            mon addr \u003d 192.168.1.9:6789"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Finally, mount the filesystem, substituting the filenames of the keyring and"},{"line_number":114,"context_line":"configuration files you just created:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"::"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a68dd71_b8f0e1ca","line":114,"updated":"2016-01-26 19:21:41.000000000","message":"I\u0027d also add a note to include the ID of the share you created in addition to the keyring and Ceph configuration files.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"5f422e2c471da24780be9958d5417523768c4085","unresolved":false,"context_lines":[{"line_number":13,"context_line":"--------------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- A Ceph cluster with a filesystem configured (http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":16,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and your manila server"},{"line_number":17,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. important:: A manila share backed onto CephFS is only as good as the underlying filesystem.  Take"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a5de9d1_06f1ba95","line":16,"updated":"2016-02-02 09:34:51.000000000","message":"\"manila server\" is manila-api or manila-share service?","commit_id":"28e531876d4c8c54b7f28e90f623d75511d9b72f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The CephFS Native driver enables manila to export shared filesystems to guests"},{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_7a80dc46","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":34},"updated":"2016-02-04 17:08:40.000000000","message":"nit: delete extra space here","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"03feb70f7e39b4917c3cae6c1c4e624b4fc576ad","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The CephFS Native driver enables manila to export shared filesystems to guests"},{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_df821a94","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":34},"in_reply_to":"5a5ae5dd_7a80dc46","updated":"2016-02-09 02:11:43.000000000","message":"Is there actually a rule against double spacing between sentences?  It\u0027s done in some other places in the docs.  Usually I find this is just a personal thing.","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"},{"line_number":10,"context_line":"a distinct authentication key that must be passed to clients for them to use it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Prerequisities"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_5a7de06c","line":9,"range":{"start_line":9,"start_character":60,"end_line":9,"end_character":62},"updated":"2016-02-04 17:08:40.000000000","message":"nit: delete extra space here","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":".. important:: A manila share backed onto CephFS is only as good as the underlying filesystem.  Take"},{"line_number":21,"context_line":"               care when configuring your Ceph cluster, and consult the latest guidance on the use of"},{"line_number":22,"context_line":"               CephFS in the Ceph documentation (http://docs.ceph.com/docs/master/cephfs/)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Authorize the driver to communicate with Ceph"}],"source_content_type":"text/x-rst","patch_set":13,"id":"5a5ae5dd_1a744866","line":21,"range":{"start_line":21,"start_character":99,"end_line":21,"end_character":101},"updated":"2016-02-04 17:08:40.000000000","message":"wrap word to next line.. rst files have the 79 char limit as well.","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3e33df27d2a7bac8866ddc07bedc6870171308","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The CephFS Native driver enables manila to export shared filesystems to guests"},{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"},{"line_number":10,"context_line":"a distinct authentication key that must be passed to clients for them to use"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5a5ae5dd_ab9abbc3","line":7,"range":{"start_line":6,"start_character":34,"end_line":7,"end_character":21},"updated":"2016-02-09 17:19:49.000000000","message":"Could you please list the supported clients? Please include a link of their website/download as well.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"9de1abc9cc065cd6daa910ce55f7a7b18892af91","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The CephFS Native driver enables manila to export shared filesystems to guests"},{"line_number":6,"context_line":"using the Ceph network protocol.  Guests require a Ceph client in order to"},{"line_number":7,"context_line":"mount the filesystem."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Access is controlled via Ceph\u0027s cephx authentication system.  Each share has"},{"line_number":10,"context_line":"a distinct authentication key that must be passed to clients for them to use"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a57f1b5_f523a2a5","line":7,"range":{"start_line":6,"start_character":34,"end_line":7,"end_character":21},"in_reply_to":"5a5ae5dd_ab9abbc3","updated":"2016-02-10 18:36:32.000000000","message":"Done","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3e33df27d2a7bac8866ddc07bedc6870171308","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":18,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":19,"context_line":"  server running the manila-share service."},{"line_number":20,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"},{"line_number":23,"context_line":"               underlying filesystem.  Take care when configuring your Ceph"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5a5ae5dd_2bdd6b70","line":20,"range":{"start_line":20,"start_character":51,"end_line":20,"end_character":65},"updated":"2016-02-09 17:19:49.000000000","message":"Shouldn\u0027t it have two different networks? one for admin and one for guests?","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bc8816fed6b82453d268262aff4c637e928dc8cf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":18,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":19,"context_line":"  server running the manila-share service."},{"line_number":20,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"},{"line_number":23,"context_line":"               underlying filesystem.  Take care when configuring your Ceph"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a57f1b5_cd94bae3","line":20,"range":{"start_line":20,"start_character":51,"end_line":20,"end_character":65},"in_reply_to":"3a57f1b5_352a9a7f","updated":"2016-02-11 11:08:08.000000000","message":"Ok.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"9de1abc9cc065cd6daa910ce55f7a7b18892af91","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":18,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":19,"context_line":"  server running the manila-share service."},{"line_number":20,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"},{"line_number":23,"context_line":"               underlying filesystem.  Take care when configuring your Ceph"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a57f1b5_352a9a7f","line":20,"range":{"start_line":20,"start_character":51,"end_line":20,"end_character":65},"in_reply_to":"5a5ae5dd_2bdd6b70","updated":"2016-02-10 18:36:32.000000000","message":"No -- from ceph\u0027s point of view the network for administration is the same as the one for data.  The non-administrative clients are limited in what they can do by their cephx capabilities.\n\nFor an extra layer of security we are looking to add an extra NFS hop on top of cephfs in the future, so that clients aren\u0027t exposed directly to the backend ceph network.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3e33df27d2a7bac8866ddc07bedc6870171308","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Creating shares"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The default share type may have driver_handles_share_servers set to true."},{"line_number":84,"context_line":"Configure a share type suitable for cephfs:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5a5ae5dd_4ba0e790","line":83,"range":{"start_line":83,"start_character":68,"end_line":83,"end_character":72},"updated":"2016-02-09 17:19:49.000000000","message":"s/true/True","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bc8816fed6b82453d268262aff4c637e928dc8cf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Creating shares"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The default share type may have driver_handles_share_servers set to true."},{"line_number":84,"context_line":"Configure a share type suitable for cephfs:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a57f1b5_6dba6670","line":83,"range":{"start_line":83,"start_character":68,"end_line":83,"end_character":72},"in_reply_to":"3a57f1b5_35513a0f","updated":"2016-02-11 11:08:08.000000000","message":"I would still change to \"True\" for consistency. But this is ok, was just a suggestion.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"687575d1a879e61975665df401e43db5105913f9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Creating shares"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The default share type may have driver_handles_share_servers set to true."},{"line_number":84,"context_line":"Configure a share type suitable for cephfs:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":19,"id":"dae33548_3ee8777c","line":83,"range":{"start_line":83,"start_character":68,"end_line":83,"end_character":72},"in_reply_to":"3a57f1b5_6dba6670","updated":"2016-02-15 08:15:53.000000000","message":"Done","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"9de1abc9cc065cd6daa910ce55f7a7b18892af91","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Creating shares"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The default share type may have driver_handles_share_servers set to true."},{"line_number":84,"context_line":"Configure a share type suitable for cephfs:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a57f1b5_35513a0f","line":83,"range":{"start_line":83,"start_character":68,"end_line":83,"end_character":72},"in_reply_to":"5a5ae5dd_4ba0e790","updated":"2016-02-10 18:36:32.000000000","message":"The CLI accepts lowercase, so I think this is correct?","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. code-block:: console"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Configure CephFS backend in manila.conf"},{"line_number":55,"context_line":"---------------------------------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"bae84128_5204357d","line":52,"range":{"start_line":52,"start_character":38,"end_line":52,"end_character":60},"updated":"2016-02-19 23:37:37.000000000","message":"Interesting...","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"- A Ceph cluster with a filesystem configured ("},{"line_number":23,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":24,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":25,"context_line":"  server running the manila-share service."},{"line_number":26,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"}],"source_content_type":"text/x-rst","patch_set":33,"id":"bae84128_503558f5","line":25,"updated":"2016-02-25 09:58:36.000000000","message":"s/manila-share/:term:`manila-share`/","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":22,"context_line":"- A Ceph cluster with a filesystem configured ("},{"line_number":23,"context_line":"  http://docs.ceph.com/docs/master/cephfs/createfs/)"},{"line_number":24,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and the"},{"line_number":25,"context_line":"  server running the manila-share service."},{"line_number":26,"context_line":"- Network connectivity between your Ceph cluster\u0027s public network and guests"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. important:: A manila share backed onto CephFS is only as good as the"}],"source_content_type":"text/x-rst","patch_set":33,"id":"bae84128_3a069820","line":25,"in_reply_to":"bae84128_503558f5","updated":"2016-02-25 16:22:51.000000000","message":"Done","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. code-block:: console"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":44,"context_line":"on the server where the manila-share service runs, and the paths to these"}],"source_content_type":"text/x-rst","patch_set":33,"id":"bae84128_ab3a79e5","line":41,"updated":"2016-02-25 09:58:36.000000000","message":"nit: can you add a linebreak please?","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. code-block:: console"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":44,"context_line":"on the server where the manila-share service runs, and the paths to these"}],"source_content_type":"text/x-rst","patch_set":33,"id":"bae84128_da084c30","line":41,"in_reply_to":"bae84128_ab3a79e5","updated":"2016-02-25 16:22:51.000000000","message":"Because of all the nested quote marks in this line, it\u0027s very awkward to try and wrap: since it\u0027s just a nit I\u0027d rather leave it on one line (also to guarantee nice clean copy-pasting of it for users)","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":44,"context_line":"on the server where the manila-share service runs, and the paths to these"},{"line_number":45,"context_line":"configured in your manila.conf."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"bae84128_6b17d154","line":44,"updated":"2016-02-25 09:58:36.000000000","message":"s/manila-share/:term:`manila-share`/","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    ceph auth get-or-create client.manila mon \u0027allow r; allow command \"auth del\" with entity prefix client.manila.; allow command \"auth caps\" with entity prefix client.manila.; allow command \"auth get\" with entity prefix client.manila., allow command \"auth get-or-create\" with entity prefix client.manila.\u0027 mds \u0027allow *\u0027 osd \u0027allow rw\u0027 \u003e keyring.manila"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"keyring.manila, along with your ceph.conf file, will then need to be placed"},{"line_number":44,"context_line":"on the server where the manila-share service runs, and the paths to these"},{"line_number":45,"context_line":"configured in your manila.conf."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"bae84128_f8fef903","line":44,"in_reply_to":"bae84128_6b17d154","updated":"2016-02-25 16:22:51.000000000","message":"Done","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. code-block:: console"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Configure CephFS backend in manila.conf"},{"line_number":55,"context_line":"---------------------------------------"}],"source_content_type":"text/x-rst","patch_set":34,"id":"9aed3d3a_dda7cc4d","line":52,"range":{"start_line":52,"start_character":38,"end_line":52,"end_character":60},"updated":"2016-02-26 02:37:55.000000000","message":"holy wow.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79613eaaa7eebe4373647d63733075b093ce20b3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"information."},{"line_number":27,"context_line":"Column value \"-\" means that this feature is not currently supported."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The J, K, L etc letters in these tables refer to the OpenStack release in which"},{"line_number":30,"context_line":"the feature became available."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Mapping of share drivers and share features support"},{"line_number":33,"context_line":"---------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"dae33548_a2f8e17d","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":29},"updated":"2016-02-15 10:54:20.000000000","message":"Lines 23-24 already say the same.","commit_id":"e38623db209107e3da4079187ab9a9ac97498bd9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"0e5969f49048ffc4c106923c9975796f84ed8819","unresolved":false,"context_lines":[{"line_number":26,"context_line":"information."},{"line_number":27,"context_line":"Column value \"-\" means that this feature is not currently supported."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"The J, K, L etc letters in these tables refer to the OpenStack release in which"},{"line_number":30,"context_line":"the feature became available."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Mapping of share drivers and share features support"},{"line_number":33,"context_line":"---------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":24,"id":"dae33548_f5bbb70c","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":29},"in_reply_to":"dae33548_a2f8e17d","updated":"2016-02-15 15:35:00.000000000","message":"Done","commit_id":"e38623db209107e3da4079187ab9a9ac97498bd9"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":84,"context_line":"|                 EMC VNX                |    NFS (J)   |    CIFS (J)    |     \\-     |      \\-      |    NFS (L)   |    CIFS (L)    |     \\-     |     \\-     |"},{"line_number":85,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":86,"context_line":"|               EMC Isilon               | NFS,CIFS (K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":87,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":88,"context_line":"|            Red Hat GlusterFS           |     NFS (J)  |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":89,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":28,"id":"bae84128_d28965cc","line":86,"range":{"start_line":86,"start_character":108,"end_line":86,"end_character":110},"updated":"2016-02-19 23:37:37.000000000","message":"Please restore the EMC Isilon entry here.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":84,"context_line":"|                 EMC VNX                |    NFS (J)   |    CIFS (J)    |     \\-     |      \\-      |    NFS (L)   |    CIFS (L)    |     \\-     |     \\-     |"},{"line_number":85,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":86,"context_line":"|               EMC Isilon               | NFS,CIFS (K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":87,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":88,"context_line":"|            Red Hat GlusterFS           |     NFS (J)  |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":89,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"}],"source_content_type":"text/x-rst","patch_set":28,"id":"bae84128_1e0841d9","line":86,"range":{"start_line":86,"start_character":108,"end_line":86,"end_character":110},"in_reply_to":"bae84128_d28965cc","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":107,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":108,"context_line":"|              Oracle ZFSSA              |  NFS,CIFS(K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":109,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":110,"context_line":"|              CephFS Native             |      \\-      |       \\-       |     \\-     |   CEPH(M)    |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":111,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Mapping of share drivers and security services support"}],"source_content_type":"text/x-rst","patch_set":34,"id":"9aed3d3a_13bbe5c5","line":110,"range":{"start_line":110,"start_character":152,"end_line":110,"end_character":154},"updated":"2016-02-26 02:50:49.000000000","message":"Are you not able to support read-only shares?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":108,"context_line":"|              Oracle ZFSSA              |  NFS,CIFS(K) |       \\-       |     \\-     |      \\-      |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":109,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":110,"context_line":"|              CephFS Native             |      \\-      |       \\-       |     \\-     |   CEPH(M)    |      \\-      |       \\-       |     \\-     |     \\-     |"},{"line_number":111,"context_line":"+----------------------------------------+--------------+----------------+------------+--------------+--------------+----------------+------------+------------+"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Mapping of share drivers and security services support"}],"source_content_type":"text/x-rst","patch_set":34,"id":"9aed3d3a_873cb894","line":110,"range":{"start_line":110,"start_character":152,"end_line":110,"end_character":154},"in_reply_to":"9aed3d3a_13bbe5c5","updated":"2016-02-26 12:33:18.000000000","message":"Not currently, no.  See _allow_access.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    * 2.7 - Rename old extension-like API URLs to core-API-like"},{"line_number":56,"context_line":"    * 2.8 - Attr \"is_public\" can be set for share using API \"manage\""},{"line_number":57,"context_line":"    * 2.9 - Add export locations API"},{"line_number":58,"context_line":"    * 2.10 - Add \"cephx\" auth type to allow_access"},{"line_number":59,"context_line":"\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_c5736d4c","line":58,"updated":"2016-01-28 01:10:21.000000000","message":"It is probably a good idea to make the API change a separate patch set and then make the Ceph driver dependent on that.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# The default api version request is defined to be the"},{"line_number":65,"context_line":"# the minimum version of the API supported."},{"line_number":66,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":67,"context_line":"_MAX_API_VERSION \u003d \"2.10\""},{"line_number":68,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_1a28c8e1","line":67,"range":{"start_line":67,"start_character":22,"end_line":67,"end_character":24},"updated":"2016-02-04 17:08:40.000000000","message":"Please change this as well..","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"03feb70f7e39b4917c3cae6c1c4e624b4fc576ad","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# The default api version request is defined to be the"},{"line_number":65,"context_line":"# the minimum version of the API supported."},{"line_number":66,"context_line":"_MIN_API_VERSION \u003d \"2.0\""},{"line_number":67,"context_line":"_MAX_API_VERSION \u003d \"2.10\""},{"line_number":68,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_bf64fe48","line":67,"range":{"start_line":67,"start_character":22,"end_line":67,"end_character":24},"in_reply_to":"5a5ae5dd_1a28c8e1","updated":"2016-02-09 02:11:43.000000000","message":"Done","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bed5d12fd6c9ab9b8ae88020926f6158099f0908","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":381,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":382,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":383,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @wsgi.action(\u0027os-allow_access\u0027)"},{"line_number":386,"context_line":"    def _allow_access(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_490018ab","line":383,"range":{"start_line":383,"start_character":48,"end_line":383,"end_character":49},"updated":"2016-01-20 14:58:23.000000000","message":"missing period :)","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":381,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":382,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":383,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @wsgi.action(\u0027os-allow_access\u0027)"},{"line_number":386,"context_line":"    def _allow_access(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_75128b5a","line":383,"range":{"start_line":383,"start_character":48,"end_line":383,"end_character":49},"in_reply_to":"9a68dd71_490018ab","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":383,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @wsgi.action(\u0027os-allow_access\u0027)"},{"line_number":386,"context_line":"    def _allow_access(self, req, id, body):"},{"line_number":387,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":388,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_95c13f83","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":35},"updated":"2016-01-20 16:05:17.000000000","message":"This decorator should be removed.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":383,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    @wsgi.action(\u0027os-allow_access\u0027)"},{"line_number":386,"context_line":"    def _allow_access(self, req, id, body):"},{"line_number":387,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":388,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b507a317","line":385,"range":{"start_line":385,"start_character":4,"end_line":385,"end_character":35},"in_reply_to":"9a68dd71_95c13f83","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":401,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":402,"context_line":"        else:"},{"line_number":403,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":404,"context_line":"                        \"are supported.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d52a572c","line":401,"range":{"start_line":400,"start_character":8,"end_line":401,"end_character":54},"updated":"2016-01-20 16:05:17.000000000","message":"Doing so you change v1 API contract making it support \"ceph\". But it is incorrect and should be supported only with newest microversion. And microversion bump should be added with that API update.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":401,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":402,"context_line":"        else:"},{"line_number":403,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":404,"context_line":"                        \"are supported.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_f5fd1b09","line":401,"range":{"start_line":400,"start_character":8,"end_line":401,"end_character":54},"in_reply_to":"9a68dd71_d52a572c","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif req.api_version_request \u003e api_version_request.APIVersionRequest(\"2.10\")\\"},{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_0f88ad21","line":400,"range":{"start_line":400,"start_character":37,"end_line":400,"end_character":39},"updated":"2016-01-27 08:19:48.000000000","message":"* 2.10 - Add \"cephx\" auth type to allow_access\nDoes you need to support 2.10? Change \"\u003e\" to \"\u003e\u003d\"?\nBy the way, It is better to restrict the version in https://github.com/openstack/manila/blob/master/manila/api/v2/shares.py#L85","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif req.api_version_request \u003e api_version_request.APIVersionRequest(\"2.10\")\\"},{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_18232d07","line":400,"updated":"2016-01-26 19:21:41.000000000","message":"This line\u0027s over the 70 character limit. See http://docs.openstack.org/contributor-guide/rst-conv/gen-guidelines.html#lines-length","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif req.api_version_request \u003e api_version_request.APIVersionRequest(\"2.10\")\\"},{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_c3059314","line":400,"range":{"start_line":400,"start_character":84,"end_line":400,"end_character":85},"updated":"2016-01-27 08:19:48.000000000","message":"Use () instead of \\","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif req.api_version_request \u003e api_version_request.APIVersionRequest(\"2.10\")\\"},{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_c51554e5","line":400,"range":{"start_line":400,"start_character":37,"end_line":400,"end_character":39},"in_reply_to":"9a68dd71_0f88ad21","updated":"2016-02-02 00:23:45.000000000","message":"Updated \u003e to be \u003e\u003d","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif req.api_version_request \u003e api_version_request.APIVersionRequest(\"2.10\")\\"},{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_8533dcaa","line":400,"in_reply_to":"9a68dd71_18232d07","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            self._validate_username(access_to)"},{"line_number":398,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":399,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":400,"context_line":"        elif req.api_version_request \u003e api_version_request.APIVersionRequest(\"2.10\")\\"},{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_e5fbb0bf","line":400,"range":{"start_line":400,"start_character":84,"end_line":400,"end_character":85},"in_reply_to":"9a68dd71_c3059314","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"},{"line_number":404,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":405,"context_line":"                        \"are supported.\")"},{"line_number":406,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":407,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cc3e3a29","line":404,"range":{"start_line":404,"start_character":50,"end_line":404,"end_character":52},"updated":"2016-01-26 19:21:41.000000000","message":"Should really be \"and\", but now I\u0027m nitpicking :)","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":402,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":403,"context_line":"        else:"},{"line_number":404,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":405,"context_line":"                        \"are supported.\")"},{"line_number":406,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":407,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_a50138b1","line":404,"range":{"start_line":404,"start_character":50,"end_line":404,"end_character":52},"in_reply_to":"9a68dd71_cc3e3a29","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":382,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":383,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":384,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    def _allow_access(self, req, id, body):"},{"line_number":387,"context_line":"        \"\"\"Add share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_9fd08bcb","line":384,"updated":"2016-02-03 03:20:43.000000000","message":"I think it is probably better to check whether all characters in cephx_id are valid rather than only eliminating the period.  There could be other invalid characters that are not a period.","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            self._validate_username(access_to)"},{"line_number":413,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":414,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":415,"context_line":"        elif (req.api_version_request \u003e\u003d"},{"line_number":416,"context_line":"                api_version_request.APIVersionRequest(\"2.10\")"},{"line_number":417,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027):"},{"line_number":418,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":419,"context_line":"        else:"},{"line_number":420,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 and \u0027cephx\u0027 access types \""},{"line_number":421,"context_line":"                        \"are supported.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_36adcfe9","line":418,"range":{"start_line":415,"start_character":0,"end_line":418,"end_character":54},"updated":"2016-02-03 22:08:49.000000000","message":"I agree with Ramana Raja. To avoid problems like this, I suggest moving this code to manila/api/v2/shares.py and using a different allow_access method for when microversion is 2.10 or newer.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"731fd2ccc1f96c39d6c6e537161c7c017ba05947","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                and access_type \u003d\u003d \u0027cephx\u0027):"},{"line_number":418,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":419,"context_line":"        else:"},{"line_number":420,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 and \u0027cephx\u0027 access types \""},{"line_number":421,"context_line":"                        \"are supported.\")"},{"line_number":422,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":423,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_838fb622","line":420,"updated":"2016-02-03 15:20:49.000000000","message":"So for API v1 request, the cephx access type would fail as per code, and yet the error would be report \u0027cephx\u0027 access type is supported?","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":426,"context_line":"                            \"are supported.\")"},{"line_number":427,"context_line":"            else:"},{"line_number":428,"context_line":"                exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027,or \u0027cert\u0027 access types \""},{"line_number":429,"context_line":"                            \"are supported.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_562f10f6","line":428,"updated":"2016-02-25 09:58:36.000000000","message":"nit: if you change this, please remove the \u0027,\u0027. So \"Only \u0027ip\u0027,\u0027user\u0027 or \u0027cert\u0027 access types \"","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":426,"context_line":"                            \"are supported.\")"},{"line_number":427,"context_line":"            else:"},{"line_number":428,"context_line":"                exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027,or \u0027cert\u0027 access types \""},{"line_number":429,"context_line":"                            \"are supported.\")"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_78ddc96f","line":428,"in_reply_to":"bae84128_562f10f6","updated":"2016-02-25 16:22:51.000000000","message":"Done (I am neutral in all debates about oxford commas)","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":391,"context_line":"                \u0027Ceph IDs may not be empty\u0027))"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        # This restriction may be lifted in Ceph in the future:"},{"line_number":394,"context_line":"        # http://tracker.ceph.com/issues/14626"},{"line_number":395,"context_line":"        if not set(cephx_id) \u003c\u003d set(string.printable):"},{"line_number":396,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_30e9bf1b","line":393,"range":{"start_line":393,"start_character":10,"end_line":393,"end_character":39},"updated":"2016-02-26 02:37:55.000000000","message":"Please feel free to add a # TODO(jcsp): to this.. it\u0027s good to keep things tracked.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":391,"context_line":"                \u0027Ceph IDs may not be empty\u0027))"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        # This restriction may be lifted in Ceph in the future:"},{"line_number":394,"context_line":"        # http://tracker.ceph.com/issues/14626"},{"line_number":395,"context_line":"        if not set(cephx_id) \u003c\u003d set(string.printable):"},{"line_number":396,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_f30c6a96","line":393,"range":{"start_line":393,"start_character":10,"end_line":393,"end_character":39},"in_reply_to":"9aed3d3a_30e9bf1b","updated":"2016-02-26 12:33:18.000000000","message":"We don\u0027t track things with TODOs in the Manila code, and this is a possible change rather than a definite plan.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            self._validate_cephx_id(access_to)"},{"line_number":423,"context_line":"        else:"},{"line_number":424,"context_line":"            if enable_ceph:"},{"line_number":425,"context_line":"                exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 or \u0027cephx\u0027 access types \""},{"line_number":426,"context_line":"                            \"are supported.\")"},{"line_number":427,"context_line":"            else:"},{"line_number":428,"context_line":"                exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027 or \u0027cert\u0027 access types \""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_13300556","line":425,"range":{"start_line":425,"start_character":34,"end_line":425,"end_character":45},"updated":"2016-02-26 02:50:49.000000000","message":"The new part of this sentence looks fine.  If you do another patch, could you insert a space in here as well, please?  Same in the following block.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila/api/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":89,"context_line":"        return self._allow_access(req, id, body)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.9\u0027)"},{"line_number":92,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":93,"context_line":"    def allow_access(self, req, id, body):"},{"line_number":94,"context_line":"        \"\"\"Add share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_faa60c52","line":91,"range":{"start_line":91,"start_character":41,"end_line":91,"end_character":44},"updated":"2016-02-04 17:08:40.000000000","message":"2.10?","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"03feb70f7e39b4917c3cae6c1c4e624b4fc576ad","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":89,"context_line":"        return self._allow_access(req, id, body)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.9\u0027)"},{"line_number":92,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":93,"context_line":"    def allow_access(self, req, id, body):"},{"line_number":94,"context_line":"        \"\"\"Add share access rule.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_64765fda","line":91,"range":{"start_line":91,"start_character":41,"end_line":91,"end_character":44},"in_reply_to":"5a5ae5dd_faa60c52","updated":"2016-02-09 02:11:43.000000000","message":"Done","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9c935d2cfa8a976beb94cdb831a9b5ad8f6da4e4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":115,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @wsgi.Controller.api_version(\u00272.11\u0027)  # noqa"},{"line_number":118,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":119,"context_line":"    def allow_access(self, req, id, body):"},{"line_number":120,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":121,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":122,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a5ae5dd_2365a2e0","line":119,"range":{"start_line":117,"start_character":3,"end_line":119,"end_character":42},"updated":"2016-02-09 13:21:01.000000000","message":"I suspect that exactly this method will run for 2.7-2.10 microversions too because of bug [1]. So, current implementation adds bug - behaviour of 2.7-2.10 versions of \"access-allow\" action changes.\n\n[1] https://bugs.launchpad.net/manila/+bug/1512403","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6bee21a0560d659a13f8c0bba0f82e39da6c13de","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":115,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @wsgi.Controller.api_version(\u00272.11\u0027)  # noqa"},{"line_number":118,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":119,"context_line":"    def allow_access(self, req, id, body):"},{"line_number":120,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":121,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":122,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a54edaf_12fc923d","line":119,"range":{"start_line":117,"start_character":3,"end_line":119,"end_character":42},"in_reply_to":"5a5ae5dd_2365a2e0","updated":"2016-02-13 09:38:16.000000000","message":"Done","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3e33df27d2a7bac8866ddc07bedc6870171308","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def allow_access(self, req, id, body):  # noqa"},{"line_number":123,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":124,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":125,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"},{"line_number":126,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        access_type \u003d access_data[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a5ae5dd_a673d2b3","line":125,"range":{"start_line":125,"start_character":57,"end_line":125,"end_character":60},"updated":"2016-02-09 17:19:49.000000000","message":"the action name and body should not include \"os-\" for this microversion. I really suggest not trying both like you are doing here.\n\nHere is a sample:\n\nREQ: curl -i -X POST http://172.24.47.149:8786/v2/1ba713360a334a9881955811d685dcdc/shares/44fd55ca-592a-4a2f-bf7d-e4ccce83d34c/action -H \"X-Openstack-Manila-Api-Version: 2.10\" -H \"X-Auth-Token: 36906b7cc38448888826c4a35903423e\" -H \"Content-Type: application/json\" -H \"Accept: application/json\" -H \"User-Agent: python-manilaclient\" -d \u0027{\"allow_access\": {\"access_type\": \"ip\", \"access_to\": \"10.0.0.1\"}}\u0027","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"9de1abc9cc065cd6daa910ce55f7a7b18892af91","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def allow_access(self, req, id, body):  # noqa"},{"line_number":123,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":124,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":125,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"},{"line_number":126,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        access_type \u003d access_data[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_75b5722f","line":125,"range":{"start_line":125,"start_character":57,"end_line":125,"end_character":60},"in_reply_to":"5a5ae5dd_a673d2b3","updated":"2016-02-10 18:36:32.000000000","message":"OK -- this was just carried forward from the v1 _allow_access.  I\u0027ve removed the os- part now.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3e33df27d2a7bac8866ddc07bedc6870171308","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self._validate_username(access_to)"},{"line_number":134,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":135,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":136,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":137,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 and \u0027cephx\u0027 access types \""},{"line_number":140,"context_line":"                        \"are supported.\")"},{"line_number":141,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            access \u003d self.share_api.allow_access("},{"line_number":144,"context_line":"                context, share, access_type, access_to,"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a5ae5dd_e6c78a62","line":141,"range":{"start_line":136,"start_character":8,"end_line":141,"end_character":63},"updated":"2016-02-09 17:19:49.000000000","message":"If you could refactor the method to use the old access_allow, just checking this parameter separately and the return value appropriately, I think it would be better. You can supply a parameter to adjust the behavior.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"09336b939f1374fb8d70509d07fd782bd511a484","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self._validate_username(access_to)"},{"line_number":134,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":135,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":136,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":137,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 and \u0027cephx\u0027 access types \""},{"line_number":140,"context_line":"                        \"are supported.\")"},{"line_number":141,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            access \u003d self.share_api.allow_access("},{"line_number":144,"context_line":"                context, share, access_type, access_to,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a54edaf_1281f28f","line":141,"range":{"start_line":136,"start_character":8,"end_line":141,"end_character":63},"in_reply_to":"3a57f1b5_8d4b2287","updated":"2016-02-13 09:40:28.000000000","message":"Done as per email","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bc8816fed6b82453d268262aff4c637e928dc8cf","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self._validate_username(access_to)"},{"line_number":134,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":135,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":136,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":137,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 and \u0027cephx\u0027 access types \""},{"line_number":140,"context_line":"                        \"are supported.\")"},{"line_number":141,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            access \u003d self.share_api.allow_access("},{"line_number":144,"context_line":"                context, share, access_type, access_to,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_8d4b2287","line":141,"range":{"start_line":136,"start_character":8,"end_line":141,"end_character":63},"in_reply_to":"3a57f1b5_f5f642f8","updated":"2016-02-11 11:08:08.000000000","message":"I believe it was incorrect to check the version in the v1 method, I suggest having this 2.11 checked and then call the v1, get the return of it and treat it accordingly.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"9de1abc9cc065cd6daa910ce55f7a7b18892af91","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self._validate_username(access_to)"},{"line_number":134,"context_line":"        elif access_type \u003d\u003d \u0027cert\u0027:"},{"line_number":135,"context_line":"            self._validate_common_name(access_to.strip())"},{"line_number":136,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":137,"context_line":"            self._validate_cephx_id(access_to.strip())"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            exc_str \u003d _(\"Only \u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027 and \u0027cephx\u0027 access types \""},{"line_number":140,"context_line":"                        \"are supported.\")"},{"line_number":141,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":142,"context_line":"        try:"},{"line_number":143,"context_line":"            access \u003d self.share_api.allow_access("},{"line_number":144,"context_line":"                context, share, access_type, access_to,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_f5f642f8","line":141,"range":{"start_line":136,"start_character":8,"end_line":141,"end_character":63},"in_reply_to":"5a5ae5dd_e6c78a62","updated":"2016-02-10 18:36:32.000000000","message":"Isn\u0027t that pretty much what I was doing in the earlier revision where I had a conditional in the v1 _allow_access that checked the version and permitted ceph if it was sufficient?  Or do you mean to have this 2.11 version of allow_access() pass through a ceph_allowed boolean to the v1 _allow_access, and then use that to allow/deny cephx and mutate the exc_string accordingly?","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @wsgi.Controller.api_version(\u00272.11\u0027)  # noqa"},{"line_number":121,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":122,"context_line":"    def allow_access(self, req, id, body):  # noqa"},{"line_number":123,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":124,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":125,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_dae8ee12","line":122,"range":{"start_line":122,"start_character":4,"end_line":122,"end_character":50},"updated":"2016-02-11 10:56:55.000000000","message":"Please, look at comments for PS18, introduced problem not resolved yet.\n\nIt was following:\n\n\"\"\"\nI suspect that exactly this method will run for 2.7-2.10 microversions too because of bug [1]. So, current implementation adds bug - behaviour of 2.7-2.10 versions of \"access-allow\" action changes.\n[1] https://bugs.launchpad.net/manila/+bug/1512403\n\"\"\"","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @wsgi.Controller.api_version(\u00272.11\u0027)  # noqa"},{"line_number":121,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":122,"context_line":"    def allow_access(self, req, id, body):  # noqa"},{"line_number":123,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":124,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":125,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_fe49ef8f","line":122,"range":{"start_line":122,"start_character":4,"end_line":122,"end_character":50},"in_reply_to":"3a57f1b5_dae8ee12","updated":"2016-02-15 08:16:08.000000000","message":"Done. Replied to comment in PS18 as well.","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b7662c2925b5957caf98f116746c7ec136ddb3fc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.12\"):"},{"line_number":94,"context_line":"            return self._allow_access(req, id, body)"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            return self._allow_access(req, id, body, enable_ceph\u003dTrue)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":99,"context_line":"    @wsgi.action(\u0027os-deny_access\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_c2a97b7d","line":96,"updated":"2016-02-16 07:26:16.000000000","message":"not unit tested","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab38b6f5fd303576a1882cde529fc30f7f6710ef","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.12\"):"},{"line_number":94,"context_line":"            return self._allow_access(req, id, body)"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            return self._allow_access(req, id, body, enable_ceph\u003dTrue)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":99,"context_line":"    @wsgi.action(\u0027os-deny_access\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_a5f9e182","line":96,"in_reply_to":"dae33548_c2a97b7d","updated":"2016-02-16 08:01:15.000000000","message":"+1","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                      wsgi.Controller,"},{"line_number":29,"context_line":"                      wsgi.AdminActionsMixin):"},{"line_number":30,"context_line":"    \"\"\"The Shares API v2 controller for the OpenStack API.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Silence linter: versioned API definitions may re-use fn names"},{"line_number":33,"context_line":"    # pylint: disable\u003dfunction-redefined"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    resource_name \u003d \u0027share\u0027"},{"line_number":36,"context_line":"    _view_builder_class \u003d share_views.ViewBuilder"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_10cc7b34","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":40},"updated":"2016-02-26 02:37:55.000000000","message":"you don\u0027t need this. disable E0102 in place.. \n\n # pylint: disable\u003dE0102","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                      wsgi.Controller,"},{"line_number":29,"context_line":"                      wsgi.AdminActionsMixin):"},{"line_number":30,"context_line":"    \"\"\"The Shares API v2 controller for the OpenStack API.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Silence linter: versioned API definitions may re-use fn names"},{"line_number":33,"context_line":"    # pylint: disable\u003dfunction-redefined"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    resource_name \u003d \u0027share\u0027"},{"line_number":36,"context_line":"    _view_builder_class \u003d share_views.ViewBuilder"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_d3ede68c","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":40},"in_reply_to":"9aed3d3a_10cc7b34","updated":"2016-02-26 12:33:18.000000000","message":"Actually this isn\u0027t needed at all any more, since an earlier review asked us to remove the multiple same-named methods.  Removed.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":91,"context_line":"    def allow_access(self, req, id, body):"},{"line_number":92,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":93,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.12\"):"},{"line_number":94,"context_line":"            return self._allow_access(req, id, body)"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            return self._allow_access(req, id, body, enable_ceph\u003dTrue)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":99,"context_line":"    @wsgi.action(\u0027os-deny_access\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_30125fb5","line":96,"range":{"start_line":93,"start_character":8,"end_line":96,"end_character":70},"updated":"2016-02-26 02:37:55.000000000","message":"Nope.. This isn\u0027t technically incorrect as much as it is inconsistent. \n\nPlease use a different method. \n\n\n    @wsgi.Controller.api_version(\u00272.7\u0027, \u00272.11\u0027)\n    @wsgi.action(\u0027allow_access\u0027)\n    def allow_access(self, req, id, body):\n    \"\"\"Add share access rule.\"\"\"\n        return self._allow_access(req, id, body)\n\n\n  \n    @wsgi.Controller.api_version(\u00272.12\u0027) # noqa\n    @wsgi.action(\u0027allow_access\u0027)\n    def allow_access(self, req, id, body):    # pylint: disable\u003dE0102\n    \"\"\"Add share access rule.\"\"\"\n         return self._allow_access(req, id, body, enable_ceph\u003dTrue)\n\n\nThis allows for better reading of this file.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @wsgi.action(\u0027allow_access\u0027)"},{"line_number":91,"context_line":"    def allow_access(self, req, id, body):"},{"line_number":92,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":93,"context_line":"        if req.api_version_request \u003c api_version.APIVersionRequest(\"2.12\"):"},{"line_number":94,"context_line":"            return self._allow_access(req, id, body)"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            return self._allow_access(req, id, body, enable_ceph\u003dTrue)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":99,"context_line":"    @wsgi.action(\u0027os-deny_access\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_534c36c7","line":96,"range":{"start_line":93,"start_character":8,"end_line":96,"end_character":70},"in_reply_to":"9aed3d3a_30125fb5","updated":"2016-02-26 12:33:18.000000000","message":"No.  This was already tried in a (much) earlier revision of the code, and we were very explicitly told not to do it, because there is a bug affecting it.  See comments on previous patches, or ask Rodrigo.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila/share/drivers/ceph/cephfs.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        Manila uses gibibytes everywhere."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param gigs: integer number of gibibytes"},{"line_number":101,"context_line":"        :return: integer number of bytes"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        return gigs * units.Gi"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_bff02cca","line":100,"range":{"start_line":100,"start_character":47,"end_line":100,"end_character":48},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        Manila uses gibibytes everywhere."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param gigs: integer number of gibibytes"},{"line_number":101,"context_line":"        :return: integer number of bytes"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        return gigs * units.Gi"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_dfbff0cd","line":101,"range":{"start_line":101,"start_character":39,"end_line":101,"end_character":40},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if not ceph_module_found:"},{"line_number":111,"context_line":"            raise exception.ManilaException("},{"line_number":112,"context_line":"                _(\"Ceph client libraries not found)\")"},{"line_number":113,"context_line":"            )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        conf_path \u003d self.configuration.safe_get(\u0027cephfs_conf_path\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_3faa5c85","line":112,"range":{"start_line":112,"start_character":50,"end_line":112,"end_character":51},"updated":"2016-02-24 13:33:58.000000000","message":"remove this parenthesis and add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            self._volume_client \u003d None"},{"line_number":133,"context_line":"            raise"},{"line_number":134,"context_line":"        else:"},{"line_number":135,"context_line":"            LOG.info(_LI(\"[%(be)s] Ceph client connection complete\"),"},{"line_number":136,"context_line":"                     {\"be\": self.backend_name})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        return self._volume_client"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_bf9e6c60","line":135,"range":{"start_line":135,"start_character":65,"end_line":135,"end_character":67},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":156,"context_line":"        \"\"\"Create a CephFS volume."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        :param context: A RequestContext"},{"line_number":159,"context_line":"        :param share: A ShareInstance"},{"line_number":160,"context_line":"        :param share_server: Always None for CephFS native"},{"line_number":161,"context_line":"        :return: The export location string"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_1f84b808","line":158,"range":{"start_line":158,"start_character":39,"end_line":158,"end_character":40},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \"\"\"Create a CephFS volume."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        :param context: A RequestContext"},{"line_number":159,"context_line":"        :param share: A ShareInstance"},{"line_number":160,"context_line":"        :param share_server: Always None for CephFS native"},{"line_number":161,"context_line":"        :return: The export location string"},{"line_number":162,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_5f7ac024","line":159,"range":{"start_line":159,"start_character":36,"end_line":159,"end_character":37},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        :param context: A RequestContext"},{"line_number":159,"context_line":"        :param share: A ShareInstance"},{"line_number":160,"context_line":"        :param share_server: Always None for CephFS native"},{"line_number":161,"context_line":"        :return: The export location string"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_ff911448","line":160,"range":{"start_line":160,"start_character":57,"end_line":160,"end_character":58},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        :param context: A RequestContext"},{"line_number":159,"context_line":"        :param share: A ShareInstance"},{"line_number":160,"context_line":"        :param share_server: Always None for CephFS native"},{"line_number":161,"context_line":"        :return: The export location string"},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        # `share` is a ShareInstance"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_bfacac8c","line":161,"range":{"start_line":161,"start_character":42,"end_line":161,"end_character":43},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    def _allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":191,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":192,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":193,"context_line":"                reason\u003d_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":196,"context_line":"            raise exception.InvalidShareAccessLevel("}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_df31b0a3","line":193,"range":{"start_line":193,"start_character":57,"end_line":193,"end_character":59},"updated":"2016-02-24 13:33:58.000000000","message":"add a period.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":207,"context_line":"        self.volume_client.deauthorize(self._share_path(share),"},{"line_number":208,"context_line":"                                       access[\u0027access_to\u0027])"},{"line_number":209,"context_line":"        self.volume_client.evict(access[\u0027access_to\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"},{"line_number":212,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_df4ff08f","line":209,"range":{"start_line":207,"start_character":8,"end_line":209,"end_character":53},"updated":"2016-02-24 13:33:58.000000000","message":"you are not validating access_type here. Consider the following scenario. A user adds a rule with type \"cephx\" with correct \"access_to\" value. Then the user adds a rule type \"user\" or \"ip\" with a cephx type value, this request you block in allow_access. Then the user wants to remove this rule because it is in ERROR state in DB. So when removing this rule, you will end up removing the correct \"cephx\" type rule because you did not validate it. You should LOG.warning this case if it fails validation and return without running any command in your backend.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"88ca43668604493a78f3a6f488bc8de4c8487930","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":207,"context_line":"        self.volume_client.deauthorize(self._share_path(share),"},{"line_number":208,"context_line":"                                       access[\u0027access_to\u0027])"},{"line_number":209,"context_line":"        self.volume_client.evict(access[\u0027access_to\u0027])"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"},{"line_number":212,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_f54f7368","line":209,"range":{"start_line":207,"start_character":8,"end_line":209,"end_character":53},"in_reply_to":"bae84128_df4ff08f","updated":"2016-02-24 14:06:04.000000000","message":"Done","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            for rule in delete_rules:"},{"line_number":226,"context_line":"                self._deny_access(context, share, rule)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # This is where we would list all permitted clients and remove"},{"line_number":229,"context_line":"        # those that are not in `access_rules` if the ceph interface"},{"line_number":230,"context_line":"        # enabled it."},{"line_number":231,"context_line":"        if add_rules is None and delete_rules is None:"},{"line_number":232,"context_line":"            for rule in access_rules:"},{"line_number":233,"context_line":"                self._allow_access(context, share, rule)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":236,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_dfcc1037","line":233,"range":{"start_line":228,"start_character":8,"end_line":233,"end_character":56},"updated":"2016-02-24 13:33:58.000000000","message":"I only see you allowing access for everything, is this WIP?","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"88ca43668604493a78f3a6f488bc8de4c8487930","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            for rule in delete_rules:"},{"line_number":226,"context_line":"                self._deny_access(context, share, rule)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # This is where we would list all permitted clients and remove"},{"line_number":229,"context_line":"        # those that are not in `access_rules` if the ceph interface"},{"line_number":230,"context_line":"        # enabled it."},{"line_number":231,"context_line":"        if add_rules is None and delete_rules is None:"},{"line_number":232,"context_line":"            for rule in access_rules:"},{"line_number":233,"context_line":"                self._allow_access(context, share, rule)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":236,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_b5bdeb03","line":233,"range":{"start_line":228,"start_character":8,"end_line":233,"end_character":56},"in_reply_to":"bae84128_dfcc1037","updated":"2016-02-24 14:06:04.000000000","message":"As I\u0027ve explained, the ceph library we\u0027re sitting on top of doesn\u0027t have a method to list the rules, so we can\u0027t list the rules and then subtract access_rules to get a set of rules to remove.\n\nThis is essentially the same as the ShareInstanceAccess fallback.  We will add proper hooks to enable the new update_access method fully at some point, but not right now.   See discussion with bswartz here: http://eavesdrop.openstack.org/irclogs/%23openstack-manila/%23openstack-manila.2016-02-18.log.html","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"669f27e924a3ac99bee4835b021e61ec34e9fd4c","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict,"},{"line_number":278,"context_line":"                                                 cgsnapshot_dict,"},{"line_number":279,"context_line":"                                                 share_server\u003dNone):"},{"line_number":280,"context_line":"        # TODO(jspray)"},{"line_number":281,"context_line":"        raise NotImplementedError()"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def create_consistency_group(self, context, cg_dict, share_server\u003dNone):"},{"line_number":284,"context_line":"        self.volume_client.create_group(cg_dict[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_fa280288","line":281,"range":{"start_line":280,"start_character":6,"end_line":281,"end_character":35},"updated":"2016-02-24 13:33:58.000000000","message":"WIP for this release? if not, you can remove it.","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"88ca43668604493a78f3a6f488bc8de4c8487930","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict,"},{"line_number":278,"context_line":"                                                 cgsnapshot_dict,"},{"line_number":279,"context_line":"                                                 share_server\u003dNone):"},{"line_number":280,"context_line":"        # TODO(jspray)"},{"line_number":281,"context_line":"        raise NotImplementedError()"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def create_consistency_group(self, context, cg_dict, share_server\u003dNone):"},{"line_number":284,"context_line":"        self.volume_client.create_group(cg_dict[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"bae84128_d53cef94","line":281,"range":{"start_line":280,"start_character":6,"end_line":281,"end_character":35},"in_reply_to":"bae84128_fa280288","updated":"2016-02-24 14:06:04.000000000","message":"Done","commit_id":"153dc349d6cd0f22cc9c810b6cff47503a03df7f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6ffd10b95b3630295a07452093f53bccfacb08fd","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":207,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":208,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, ignoring in deny\"),"},{"line_number":209,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_555c5f4a","line":208,"range":{"start_line":208,"start_character":74,"end_line":208,"end_character":77},"updated":"2016-02-24 14:10:07.000000000","message":"add a period.","commit_id":"eacb574df4d280845dd4ed35ceefbdbf3e63620e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"3ccbdf3c8b2f0ed9d98f6f9f1159e61952326f84","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":207,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":208,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, ignoring in deny\"),"},{"line_number":209,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"bae84128_70c7f195","line":208,"range":{"start_line":208,"start_character":74,"end_line":208,"end_character":77},"in_reply_to":"bae84128_555c5f4a","updated":"2016-02-24 14:11:34.000000000","message":"Done","commit_id":"eacb574df4d280845dd4ed35ceefbdbf3e63620e"}],"manila/share/drivers/cephfs.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            return self._volume_client"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        try:"},{"line_number":99,"context_line":"            from ceph_volume_client import CephFSVolumeClient"},{"line_number":100,"context_line":"        except ImportError as e:"},{"line_number":101,"context_line":"            raise exception.ManilaException("},{"line_number":102,"context_line":"                _(\"Ceph client libraries not found: {ex}\").format("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_9f116b60","line":99,"updated":"2016-02-03 03:20:43.000000000","message":"import should be moved to the beginning of the file.\n\nHere is an example in Cinder which handles the situation when the library does not exist.  It didn\u0027t throw an exception so it won\u0027t fail on hosts without this library.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/emc_vmax_common.py#L42","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def _share_path(self, share):"},{"line_number":141,"context_line":"        \"\"\"Get VolumePath from ShareInstance.\"\"\""},{"line_number":142,"context_line":"        from ceph_volume_client import VolumePath"},{"line_number":143,"context_line":"        return VolumePath(share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_3ab6453e","line":142,"updated":"2016-02-03 03:20:43.000000000","message":"See previous comment on import.","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        # `share` is a ShareInstance"},{"line_number":157,"context_line":"        log.debug(\"create_share {0} name\u003d{1} size\u003d{2} cg_id\u003d{3}\".format("},{"line_number":158,"context_line":"            self.backend_name, share[\u0027share_id\u0027], share[\u0027size\u0027],"},{"line_number":159,"context_line":"            share[\u0027consistency_group_id\u0027]))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":162,"context_line":"        data_isolated \u003d extra_specs.get(\"data_isolated\", False)"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_1ae7c941","line":159,"updated":"2016-02-03 03:20:43.000000000","message":"Keyword parameters are recommended.\n\nhttp://docs.openstack.org/developer/hacking/#internationalization-i18n-strings","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":183,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":184,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":185,"context_line":"                _(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":188,"context_line":"            raise exception.InvalidShareAccess("}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_da5db1ed","line":185,"updated":"2016-02-03 03:20:43.000000000","message":"exception.InvalidShareAccess(reason\u003d_(\"xxx\"))","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        return self.create_share(context, share, share_server)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":217,"context_line":"        log.debug(\"extend_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":218,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share),"},{"line_number":219,"context_line":"                                         self._to_bytes(new_size))"},{"line_number":220,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_da04d1c7","line":217,"updated":"2016-02-03 03:20:43.000000000","message":"Use keyword parameters.","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10c3c0493000f4f4a5d9845665a83a99bf27f38c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                         self._to_bytes(new_size))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":222,"context_line":"        log.debug(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":223,"context_line":"        new_bytes \u003d self._to_bytes(new_size)"},{"line_number":224,"context_line":"        used \u003d self.volume_client.get_used_bytes(self._share_path(share))"},{"line_number":225,"context_line":"        if used \u003e new_bytes:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a5ae5dd_9a0e59e4","line":222,"updated":"2016-02-03 03:20:43.000000000","message":"Same","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import units"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.common import constants"},{"line_number":23,"context_line":"import manila.exception as exception"},{"line_number":24,"context_line":"from manila.i18n import _, _LI"},{"line_number":25,"context_line":"from manila.share import driver"},{"line_number":26,"context_line":"from manila.share import share_types"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_3624ef0b","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":36},"updated":"2016-02-03 22:08:49.000000000","message":"from manila import exception","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_utils import units"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.common import constants"},{"line_number":23,"context_line":"import manila.exception as exception"},{"line_number":24,"context_line":"from manila.i18n import _, _LI"},{"line_number":25,"context_line":"from manila.share import driver"},{"line_number":26,"context_line":"from manila.share import share_types"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_c944b61c","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":36},"in_reply_to":"5a5ae5dd_3624ef0b","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CEPH_DEFAULT_AUTH_ID \u003d \"admin\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"log \u003d log.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cephfs_native_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_d649dbd1","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":3},"updated":"2016-02-03 22:08:49.000000000","message":"please use capital \"LOG\" to not confuse with \"log\" you are importing","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CEPH_DEFAULT_AUTH_ID \u003d \"admin\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"log \u003d log.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cephfs_native_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_a9585afb","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":3},"in_reply_to":"5a5ae5dd_d649dbd1","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":73,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":76,"context_line":"    _snapshots_are_supported \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_b69a1f13","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":40},"updated":"2016-02-03 22:08:49.000000000","message":"This is not being used. This config is automatically read by the driver base class and set as an attribute.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":73,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":76,"context_line":"    _snapshots_are_supported \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_09cbae1f","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":40},"in_reply_to":"5a5ae5dd_b69a1f13","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":76,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":79,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_767267e7","line":76,"range":{"start_line":76,"start_character":5,"end_line":76,"end_character":36},"updated":"2016-02-03 22:08:49.000000000","message":"you are not using this anywhere, you should return this in _update_share_stats() (or get_share_stats() in your case)","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":76,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":79,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_e9c73210","line":76,"range":{"start_line":76,"start_character":5,"end_line":76,"end_character":36},"in_reply_to":"5a5ae5dd_767267e7","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        :param gigs: integer number of gibibytes"},{"line_number":93,"context_line":"        :return: integer number of bytes"},{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":"        if gigs is not None:"},{"line_number":96,"context_line":"            return gigs * units.Gi"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            return None"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_76d6e7c6","line":96,"range":{"start_line":95,"start_character":8,"end_line":96,"end_character":34},"updated":"2016-02-03 22:08:49.000000000","message":"Can it really be None? I don\u0027t think so, the API is supposed to prevent this.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        :param gigs: integer number of gibibytes"},{"line_number":93,"context_line":"        :return: integer number of bytes"},{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":"        if gigs is not None:"},{"line_number":96,"context_line":"            return gigs * units.Gi"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            return None"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_b100c402","line":96,"range":{"start_line":95,"start_character":8,"end_line":96,"end_character":34},"in_reply_to":"5a5ae5dd_76d6e7c6","updated":"2016-02-04 14:28:02.000000000","message":"There must have been some reason, but I can\u0027t find it now, so I\u0027ll remove it.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        auth_id \u003d self.configuration.safe_get(\u0027cephfs_auth_id\u0027)"},{"line_number":115,"context_line":"        self._volume_client \u003d ceph_volume_client.CephFSVolumeClient("},{"line_number":116,"context_line":"            auth_id, conf_path, cluster_name)"},{"line_number":117,"context_line":"        log.info(_LI(\"Ceph client found, connecting...\"))"},{"line_number":118,"context_line":"        if auth_id !\u003d CEPH_DEFAULT_AUTH_ID:"},{"line_number":119,"context_line":"            # Evict any other manila sessions.  Only do this if we\u0027re"},{"line_number":120,"context_line":"            # using a client ID that isn\u0027t the default admin ID, to avoid"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_b6d8df54","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":57},"updated":"2016-02-03 22:08:49.000000000","message":"Please include additional information like cluster_name. There may be multiple backends, it is important to know which one connected.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        auth_id \u003d self.configuration.safe_get(\u0027cephfs_auth_id\u0027)"},{"line_number":115,"context_line":"        self._volume_client \u003d ceph_volume_client.CephFSVolumeClient("},{"line_number":116,"context_line":"            auth_id, conf_path, cluster_name)"},{"line_number":117,"context_line":"        log.info(_LI(\"Ceph client found, connecting...\"))"},{"line_number":118,"context_line":"        if auth_id !\u003d CEPH_DEFAULT_AUTH_ID:"},{"line_number":119,"context_line":"            # Evict any other manila sessions.  Only do this if we\u0027re"},{"line_number":120,"context_line":"            # using a client ID that isn\u0027t the default admin ID, to avoid"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_d151c00f","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":57},"in_reply_to":"5a5ae5dd_b6d8df54","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            self._volume_client \u003d None"},{"line_number":129,"context_line":"            raise"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            log.info(_LI(\"Ceph client connection complete\"))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        return self._volume_client"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_76e26705","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":60},"updated":"2016-02-03 22:08:49.000000000","message":"Please include additional information like cluster_name. There may be multiple backends, it is important to know which one connected.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            self._volume_client \u003d None"},{"line_number":129,"context_line":"            raise"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            log.info(_LI(\"Ceph client connection complete\"))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        return self._volume_client"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_d178e091","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":60},"in_reply_to":"5a5ae5dd_76e26705","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"e4b6808253b5be3730a28a1a83f5d31df3bac0ff","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            addrs\u003d\",\".join(mon_addrs),"},{"line_number":180,"context_line":"            path\u003dvolume[\u0027mount_path\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        log.info(_LI(\"Calculated export location: %(loc)s\").format("},{"line_number":183,"context_line":"            loc\u003dexport_location))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return export_location"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_36f62f90","line":183,"range":{"start_line":182,"start_character":8,"end_line":183,"end_character":33},"updated":"2016-02-03 22:08:49.000000000","message":"for which share ID?","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6a59e52e824434f63c020ecdba0e5d5f9d2dfb0b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            addrs\u003d\",\".join(mon_addrs),"},{"line_number":180,"context_line":"            path\u003dvolume[\u0027mount_path\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        log.info(_LI(\"Calculated export location: %(loc)s\").format("},{"line_number":183,"context_line":"            loc\u003dexport_location))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return export_location"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_51f5d080","line":183,"range":{"start_line":182,"start_character":8,"end_line":183,"end_character":33},"in_reply_to":"5a5ae5dd_36f62f90","updated":"2016-02-04 14:28:02.000000000","message":"Done","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        :return: The export location string"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        assert share_server is None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        # `share` is a ShareInstance"},{"line_number":161,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_ce16eea6","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":35},"updated":"2016-02-04 17:08:40.000000000","message":"Would be nice to reuse:\n  \n     exceptions.InvalidDriverMode \n\nfor clarity.","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9c935d2cfa8a976beb94cdb831a9b5ad8f6da4e4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cephfs_native_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"},{"line_number":47,"context_line":"               default\u003d\"\","},{"line_number":48,"context_line":"               help\u003d\"Fully qualified path to the ceph.conf file.\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":50,"context_line":"               help\u003d\"The name of the cluster in use, if it is not \""},{"line_number":51,"context_line":"                    \"the default (\u0027ceph\u0027).\""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a5ae5dd_43c9beab","line":48,"range":{"start_line":46,"start_character":4,"end_line":48,"end_character":67},"updated":"2016-02-09 13:21:01.000000000","message":"I guess you may want to set arg \"required\u003dTrue\" here. Because driver will not work without it, right? Same for all other config options.","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6bee21a0560d659a13f8c0bba0f82e39da6c13de","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cephfs_native_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"},{"line_number":47,"context_line":"               default\u003d\"\","},{"line_number":48,"context_line":"               help\u003d\"Fully qualified path to the ceph.conf file.\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":50,"context_line":"               help\u003d\"The name of the cluster in use, if it is not \""},{"line_number":51,"context_line":"                    \"the default (\u0027ceph\u0027).\""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a54edaf_d294bae9","line":48,"range":{"start_line":46,"start_character":4,"end_line":48,"end_character":67},"in_reply_to":"5a5ae5dd_43c9beab","updated":"2016-02-13 09:38:16.000000000","message":"The driver can operate without it.  Ceph has a built in default path.  Same for cluster name.","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9c935d2cfa8a976beb94cdb831a9b5ad8f6da4e4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"},{"line_number":79,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":80,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Ceph\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a5ae5dd_639dda58","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":23},"updated":"2016-02-09 13:21:01.000000000","message":"It should have been \"_update_share_stats\" method. In this case you w\u0027ont need to call super","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6bee21a0560d659a13f8c0bba0f82e39da6c13de","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"},{"line_number":79,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":80,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Ceph\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a54edaf_52b0ca8b","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":23},"in_reply_to":"5a5ae5dd_639dda58","updated":"2016-02-13 09:38:16.000000000","message":"Done","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9c935d2cfa8a976beb94cdb831a9b5ad8f6da4e4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        :return: The export location string"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if share_server is not None:"},{"line_number":159,"context_line":"            raise exception.InvalidDriverMode(driver_mode\u003d_("},{"line_number":160,"context_line":"                \"Share server enabled\"))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # `share` is a ShareInstance"},{"line_number":163,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("}],"source_content_type":"text/x-python","patch_set":18,"id":"5a5ae5dd_43dc5e46","line":160,"range":{"start_line":158,"start_character":8,"end_line":160,"end_character":40},"updated":"2016-02-09 13:21:01.000000000","message":"Such check should be performed for all driver methods that have such argument. Not only \"create_share\". So, would be useful to use decorator.","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6bee21a0560d659a13f8c0bba0f82e39da6c13de","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        :return: The export location string"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if share_server is not None:"},{"line_number":159,"context_line":"            raise exception.InvalidDriverMode(driver_mode\u003d_("},{"line_number":160,"context_line":"                \"Share server enabled\"))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # `share` is a ShareInstance"},{"line_number":163,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("}],"source_content_type":"text/x-python","patch_set":18,"id":"1a54edaf_12aa521a","line":160,"range":{"start_line":158,"start_character":8,"end_line":160,"end_character":40},"in_reply_to":"5a5ae5dd_43dc5e46","updated":"2016-02-13 09:38:16.000000000","message":"This was originally just an assertion, should never happen because manager.py enforces the limits on values of driver_handles_share_servers that we set in __init__.  I\u0027m just going to remove this to avoid confusion.","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5a3e33df27d2a7bac8866ddc07bedc6870171308","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a5ae5dd_c6992e21","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":36},"updated":"2016-02-09 17:19:49.000000000","message":"in the doc you mention that the user may want to enable snapshots either way. Shouldn\u0027t this value be configurable? It currently is not going to allow snapshots to be created, if an user enables using the command you described, Manila will still prevent Snapshots from being created.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"09336b939f1374fb8d70509d07fd782bd511a484","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a54edaf_52776ad4","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":36},"in_reply_to":"3a57f1b5_4d13ea66","updated":"2016-02-13 09:40:28.000000000","message":"Ok, made it configurable.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bc8816fed6b82453d268262aff4c637e928dc8cf","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_4d13ea66","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":36},"in_reply_to":"3a57f1b5_f55ba2f4","updated":"2016-02-11 11:08:08.000000000","message":"If you see any value from being able to create snapshots but not create from snapshots... like an admin may want to use. The default should be False since you cannot create from snapshot. Or you could make it always false and remove create_snapshot and delete_snapshot.","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"9de1abc9cc065cd6daa910ce55f7a7b18892af91","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_f55ba2f4","line":75,"range":{"start_line":75,"start_character":3,"end_line":75,"end_character":36},"in_reply_to":"5a5ae5dd_c6992e21","updated":"2016-02-10 18:36:32.000000000","message":"We can certainly make this configurable: would it be correct to permit users to set this to true even though we don\u0027t implement create_share_from_snapshot?","commit_id":"b1db35f4ff15959048d23f4f100fc6ad443d1227"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cephfs_native_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"},{"line_number":47,"context_line":"               default\u003d\"\","},{"line_number":48,"context_line":"               help\u003d\"Fully qualified path to the ceph.conf file.\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":50,"context_line":"               help\u003d\"The name of the cluster in use, if it is not \""},{"line_number":51,"context_line":"                    \"the default (\u0027ceph\u0027).\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_1a79a6c8","line":48,"range":{"start_line":46,"start_character":4,"end_line":48,"end_character":67},"updated":"2016-02-11 10:56:55.000000000","message":"Not resolved comment from PS18:\n\n\"\"\"\nI guess you may want to set arg \"required\u003dTrue\" here. Because driver will not work without it, right? Same for all other config options.\n\"\"\"","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":43,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cephfs_native_opts \u003d ["},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"},{"line_number":47,"context_line":"               default\u003d\"\","},{"line_number":48,"context_line":"               help\u003d\"Fully qualified path to the ceph.conf file.\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":50,"context_line":"               help\u003d\"The name of the cluster in use, if it is not \""},{"line_number":51,"context_line":"                    \"the default (\u0027ceph\u0027).\""}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_5ead7b30","line":48,"range":{"start_line":46,"start_character":4,"end_line":48,"end_character":67},"in_reply_to":"3a57f1b5_1a79a6c8","updated":"2016-02-15 08:16:08.000000000","message":"Done. Replied to the comment in PS 18.","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"},{"line_number":79,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":80,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Ceph\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_fa54ca21","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":23},"updated":"2016-02-11 10:56:55.000000000","message":"Not resolved comment from PS18:\n\n\"\"\"\nIt should have been \"_update_share_stats\" method. In this case you w\u0027ont need to call super\n\"\"\"","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":75,"context_line":"    _snapshots_are_supported \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":78,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"},{"line_number":79,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":80,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Ceph\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_beaac717","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":23},"in_reply_to":"3a57f1b5_fa54ca21","updated":"2016-02-15 08:16:08.000000000","message":"Done. Replied to the comment in PS18.","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        :return: The export location string"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if share_server is not None:"},{"line_number":159,"context_line":"            raise exception.InvalidDriverMode(driver_mode\u003d_("},{"line_number":160,"context_line":"                \"Share server enabled\"))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # `share` is a ShareInstance"},{"line_number":163,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_da30ee03","line":160,"range":{"start_line":158,"start_character":8,"end_line":160,"end_character":40},"updated":"2016-02-11 10:56:55.000000000","message":"Not resolved comment from PS18:\n\n\"\"\"\nSuch check should be performed for all driver methods that have such argument. Not only \"create_share\". So, would be useful to use decorator.\n\"\"\"","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        :return: The export location string"},{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if share_server is not None:"},{"line_number":159,"context_line":"            raise exception.InvalidDriverMode(driver_mode\u003d_("},{"line_number":160,"context_line":"                \"Share server enabled\"))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # `share` is a ShareInstance"},{"line_number":163,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_3e6d1705","line":160,"range":{"start_line":158,"start_character":8,"end_line":160,"end_character":40},"in_reply_to":"3a57f1b5_da30ee03","updated":"2016-02-15 08:16:08.000000000","message":"Done. Replied to the comment in PS18.","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":249,"context_line":"        # We assign names to created snapshots"},{"line_number":250,"context_line":"        assert snapshot[\u0027name\u0027] is not None"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.volume_client.destroy_snapshot_volume("},{"line_number":253,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_6d5b462f","line":250,"range":{"start_line":250,"start_character":8,"end_line":250,"end_character":43},"updated":"2016-02-11 10:56:55.000000000","message":"If snapshot does not exist on backend, why do you need to raise exception? Moreover, such unspecific exception as failure of assertion?","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":249,"context_line":"        # We assign names to created snapshots"},{"line_number":250,"context_line":"        assert snapshot[\u0027name\u0027] is not None"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.volume_client.destroy_snapshot_volume("},{"line_number":253,"context_line":"            self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_1e72d3e5","line":250,"range":{"start_line":250,"start_character":8,"end_line":250,"end_character":43},"in_reply_to":"3a57f1b5_6d5b462f","updated":"2016-02-15 08:16:08.000000000","message":"Done","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5495b9bfd86089b998534f5ab1283215b8948f7f","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return export_location"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":184,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":185,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":186,"context_line":"                reason\u003d_(\"Only \u0027cephx\u0027 access type allowed\"))"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_ef456970","line":183,"range":{"start_line":183,"start_character":4,"end_line":183,"end_character":20},"updated":"2016-02-16 16:12:57.000000000","message":"Please implement update_access() instead of allow_access","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"8cfb9e6a3f7a5e1b766a77e5413d28c7486ac4ba","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                reason\u003d_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":189,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":190,"context_line":"                reason\u003d_(\"Ceph driver does not support readonly access\"))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_87c5bc3d","line":189,"updated":"2016-02-16 10:14:45.000000000","message":"Here indeed InvalidShareAccessLevel should be raised.","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6607667900229421c236cf163ca6fa39d598dfce","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                reason\u003d_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d constants.ACCESS_LEVEL_RO:"},{"line_number":189,"context_line":"            raise exception.InvalidShareAccess("},{"line_number":190,"context_line":"                reason\u003d_(\"Ceph driver does not support readonly access\"))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_008e2dcf","line":189,"in_reply_to":"dae33548_87c5bc3d","updated":"2016-02-18 12:15:17.000000000","message":"Done","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5495b9bfd86089b998534f5ab1283215b8948f7f","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":200,"context_line":"        self.volume_client.deauthorize(self._share_path(share),"},{"line_number":201,"context_line":"                                       access[\u0027access_to\u0027])"},{"line_number":202,"context_line":"        self.volume_client.evict(access[\u0027access_to\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_4f55751b","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":19},"updated":"2016-02-16 16:12:57.000000000","message":"Please implement update_access() instead of deny_access","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_b26f8191","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":11},"updated":"2016-02-19 23:37:37.000000000","message":"Please move this file to manila/share/drivers/ceph/cephfs.py or similar.  Having each new driver in its own directory makes it cleaner to add modules as your driver grows and matures, it makes it simpler to run unit tests for just one driver, etc.  Same for the unit test file.  Note that the Gluster guys have another patch up now to move glusterfs_native.py  to the gluster driver directory.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_2e1fd45b","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":11},"in_reply_to":"bae84128_b26f8191","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_share_stats(self):"},{"line_number":79,"context_line":"        data \u003d {\u0027consistency_group_support\u0027: \u0027pool\u0027,"},{"line_number":80,"context_line":"                \u0027vendor_name\u0027: \u0027Ceph\u0027,"},{"line_number":81,"context_line":"                \u0027driver_version\u0027: \u00271.0\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_ed480e5e","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":27},"updated":"2016-02-19 23:37:37.000000000","message":"Why is there no capacity info or \u0027pools\u0027 member returned here?  Do you plan to have multiple pools in the future?  Even if not, you could still report a single pool named \u0027cephfs\u0027 or similar.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_share_stats(self):"},{"line_number":79,"context_line":"        data \u003d {\u0027consistency_group_support\u0027: \u0027pool\u0027,"},{"line_number":80,"context_line":"                \u0027vendor_name\u0027: \u0027Ceph\u0027,"},{"line_number":81,"context_line":"                \u0027driver_version\u0027: \u00271.0\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_ae80048c","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":27},"in_reply_to":"bae84128_ed480e5e","updated":"2016-02-24 13:15:29.000000000","message":"I\u0027m not familiar enough with the pools aspect, so I\u0027ll take your suggestion of returning [\u0027cephfs\u0027] here.  We might map it onto a ceph concept later in which case we could treat \u0027cephfs\u0027 as a request for the defaults.\n\nI\u0027ve added the total/free capacity fields.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_share_stats(self):"},{"line_number":79,"context_line":"        data \u003d {\u0027consistency_group_support\u0027: \u0027pool\u0027,"},{"line_number":80,"context_line":"                \u0027vendor_name\u0027: \u0027Ceph\u0027,"},{"line_number":81,"context_line":"                \u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":82,"context_line":"                \u0027share_backend_name\u0027: self.backend_name,"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_6d0ebe35","line":79,"range":{"start_line":79,"start_character":17,"end_line":79,"end_character":42},"updated":"2016-02-19 23:37:37.000000000","message":"Please wrap dicts according to the guidelines:\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    supported_protocols \u003d (\u0027CEPHFS\u0027,)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_share_stats(self):"},{"line_number":79,"context_line":"        data \u003d {\u0027consistency_group_support\u0027: \u0027pool\u0027,"},{"line_number":80,"context_line":"                \u0027vendor_name\u0027: \u0027Ceph\u0027,"},{"line_number":81,"context_line":"                \u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":82,"context_line":"                \u0027share_backend_name\u0027: self.backend_name,"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_6efb9c79","line":79,"range":{"start_line":79,"start_character":17,"end_line":79,"end_character":42},"in_reply_to":"bae84128_6d0ebe35","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":263,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":264,"context_line":"            self._share_path(snapshot[\u0027share\u0027]),"},{"line_number":265,"context_line":"            snapshot[\u0027name\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":268,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_4d2c9a4a","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":29},"updated":"2016-02-19 23:37:37.000000000","message":"Please unwrap this one, just like the following method.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":263,"context_line":"        self.volume_client.create_snapshot_volume("},{"line_number":264,"context_line":"            self._share_path(snapshot[\u0027share\u0027]),"},{"line_number":265,"context_line":"            snapshot[\u0027name\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":268,"context_line":"        self.volume_client.destroy_snapshot_volume("}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_0e46507a","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":29},"in_reply_to":"bae84128_4d2c9a4a","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # TODO(jspray)"},{"line_number":275,"context_line":"        raise NotImplementedError()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def create_consistency_group(self, context, cg_dict, share_server\u003dNone):"},{"line_number":278,"context_line":"        self.volume_client.create_group(cg_dict[\u0027id\u0027])"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def delete_consistency_group(self, context, cg_dict, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_ad928655","line":277,"range":{"start_line":277,"start_character":8,"end_line":277,"end_character":32},"updated":"2016-02-19 23:37:37.000000000","message":"No issues here, but please be aware that manila is planning to implement generic groups, which will supplant the current experimental CG mechanism.  The equivalent functionality of CGs will still be available, but the user and driver interfaces will both look very different.\n\nhttps://wiki.openstack.org/wiki/Manila/design/manila-generic-groups","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        # TODO(jspray)"},{"line_number":275,"context_line":"        raise NotImplementedError()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def create_consistency_group(self, context, cg_dict, share_server\u003dNone):"},{"line_number":278,"context_line":"        self.volume_client.create_group(cg_dict[\u0027id\u0027])"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def delete_consistency_group(self, context, cg_dict, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_0e3db0dc","line":277,"range":{"start_line":277,"start_character":8,"end_line":277,"end_character":32},"in_reply_to":"bae84128_ad928655","updated":"2016-02-24 13:15:29.000000000","message":"I guess we\u0027ll have to look at this when the driver interface is updated.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        self.volume_client.destroy_snapshot_group("},{"line_number":285,"context_line":"            snap_dict[\u0027consistency_group_id\u0027],"},{"line_number":286,"context_line":"            snap_dict[\u0027id\u0027]"},{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return None, []"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_6db51ecc","line":287,"range":{"start_line":287,"start_character":7,"end_line":287,"end_character":9},"updated":"2016-02-19 23:37:37.000000000","message":"Similar nit about wrapping relative to the following method...","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        self.volume_client.destroy_snapshot_group("},{"line_number":285,"context_line":"            snap_dict[\u0027consistency_group_id\u0027],"},{"line_number":286,"context_line":"            snap_dict[\u0027id\u0027]"},{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return None, []"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_ce1d8874","line":287,"range":{"start_line":287,"start_character":7,"end_line":287,"end_character":9},"in_reply_to":"bae84128_6db51ecc","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"}],"manila/share/drivers/cephfs/__init__.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               default\u003d\"\","},{"line_number":38,"context_line":"               help\u003d\"\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"},{"line_number":41,"context_line":"               help\u003d\"The name of the cluster in use, if it is not the default (\u0027ceph\u0027)\""},{"line_number":42,"context_line":"               ),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_95793f32","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":27},"updated":"2016-01-20 16:05:17.000000000","message":"redundant","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               default\u003d\"\","},{"line_number":38,"context_line":"               help\u003d\"\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"},{"line_number":41,"context_line":"               help\u003d\"The name of the cluster in use, if it is not the default (\u0027ceph\u0027)\""},{"line_number":42,"context_line":"               ),"},{"line_number":43,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_159f8fb5","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":27},"in_reply_to":"9a68dd71_95793f32","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"0ebceafa5c418077d5cdc4da92d3d7be6e866bbf","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":64,"context_line":"    _snapshots_are_supported \u003d True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":67,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_3ac99659","line":64,"updated":"2016-01-25 12:43:19.000000000","message":"Should not set the attribue to True if the driver cannot support creation of shares from snapshot.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # We support snapshots, but not creating shares from them (yet)"},{"line_number":64,"context_line":"    _snapshots_are_supported \u003d True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_share_stats(self, refresh\u003dFalse):"},{"line_number":67,"context_line":"        data \u003d super(CephFSNativeDriver, self).get_share_stats(refresh)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b5a32300","line":64,"in_reply_to":"9a68dd71_3ac99659","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":69,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Red Hat\u0027"},{"line_number":70,"context_line":"        data[\u0027driver_version\u0027] \u003d \u00271.0\u0027"},{"line_number":71,"context_line":"        return data"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _to_bytes(self, gigs):"},{"line_number":74,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d502576f","line":71,"range":{"start_line":71,"start_character":15,"end_line":71,"end_character":19},"updated":"2016-01-20 16:05:17.000000000","message":"Maybe you may want to set \"share_backend_name\"?","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":69,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Red Hat\u0027"},{"line_number":70,"context_line":"        data[\u0027driver_version\u0027] \u003d \u00271.0\u0027"},{"line_number":71,"context_line":"        return data"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _to_bytes(self, gigs):"},{"line_number":74,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_5568a787","line":71,"range":{"start_line":71,"start_character":15,"end_line":71,"end_character":19},"in_reply_to":"9a68dd71_d502576f","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return self._volume_client"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            from ceph_volume_client import CephFSVolumeClient"},{"line_number":93,"context_line":"        except ImportError as e:"},{"line_number":94,"context_line":"            raise exception.ManilaException("},{"line_number":95,"context_line":"                \"Ceph client libraries not found: {0}\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_95513f65","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":61},"updated":"2016-01-20 16:05:17.000000000","message":"Code does not verify client version. All versions of client are going to be supported?","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return self._volume_client"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            from ceph_volume_client import CephFSVolumeClient"},{"line_number":93,"context_line":"        except ImportError as e:"},{"line_number":94,"context_line":"            raise exception.ManilaException("},{"line_number":95,"context_line":"                \"Ceph client libraries not found: {0}\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_15d78f24","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":61},"in_reply_to":"9a68dd71_95513f65","updated":"2016-01-26 12:14:45.000000000","message":"The interface to Ceph is not currently versioned.  We will have to deal with this on the ceph side at some point in the future.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        Get VolumePath from ShareInstance"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        from ceph_volume_client import VolumePath"},{"line_number":136,"context_line":"        return VolumePath(share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_15c1cfe4","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":49},"updated":"2016-01-20 16:05:17.000000000","message":"Openstack quidelines requires all imports be in the top of the module. And only modules should be imported.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        Get VolumePath from ShareInstance"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        from ceph_volume_client import VolumePath"},{"line_number":136,"context_line":"        return VolumePath(share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b539e3f4","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":49},"in_reply_to":"9a68dd71_15c1cfe4","updated":"2016-01-26 12:14:45.000000000","message":"Hmm.  I want to handle ImportError exceptions inline (like in the volume_client property) so that I can pass the exception up to callers, rather than having this whole module fail to import.  Can we make an exception?\n\nBecause the ceph python bindings wrap a native library, it\u0027s possible to get exceptions other than a simple missing module, maybe it can give us a message about failing to load an .so file etc","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79948f7b293a31d412bbf5c499bcd33376c1984a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        Get VolumePath from ShareInstance"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        from ceph_volume_client import VolumePath"},{"line_number":136,"context_line":"        return VolumePath(share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_fc23c3a5","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":49},"in_reply_to":"9a68dd71_b539e3f4","updated":"2016-01-26 12:34:07.000000000","message":"Then, please, add a comment describing reason.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        assert share_server is None"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # `share` is a ShareInstance"},{"line_number":150,"context_line":"        log.info(\"create_share name\u003d{0} size\u003d{1} cg_id\u003d{2}\".format("},{"line_number":151,"context_line":"            share[\u0027share_id\u0027], share[\u0027size\u0027], share[\u0027consistency_group_id\u0027]))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_9913b95c","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":67},"updated":"2016-01-20 16:05:17.000000000","message":"Having more than one backend you will have mess in logs. Better to add backend name in the message.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        assert share_server is None"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # `share` is a ShareInstance"},{"line_number":150,"context_line":"        log.info(\"create_share name\u003d{0} size\u003d{1} cg_id\u003d{2}\".format("},{"line_number":151,"context_line":"            share[\u0027share_id\u0027], share[\u0027size\u0027], share[\u0027consistency_group_id\u0027]))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_75cdab85","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":67},"in_reply_to":"9a68dd71_9913b95c","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        volume \u003d self.volume_client.create_volume("},{"line_number":160,"context_line":"            self._share_path(share), size\u003dsize, data_isolated\u003ddata_isolated)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # To mount this you need to know the mon IPs, the volume name, and they key"},{"line_number":163,"context_line":"        mon_addrs \u003d self.volume_client.get_mon_addrs()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        export_location \u003d \"{0}:{1}\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_392bad84","line":162,"range":{"start_line":162,"start_character":71,"end_line":162,"end_character":83},"updated":"2016-01-20 16:05:17.000000000","message":"and they key?","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        volume \u003d self.volume_client.create_volume("},{"line_number":160,"context_line":"            self._share_path(share), size\u003dsize, data_isolated\u003ddata_isolated)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # To mount this you need to know the mon IPs, the volume name, and they key"},{"line_number":163,"context_line":"        mon_addrs \u003d self.volume_client.get_mon_addrs()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        export_location \u003d \"{0}:{1}\".format("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_559bc772","line":162,"range":{"start_line":162,"start_character":71,"end_line":162,"end_character":83},"in_reply_to":"9a68dd71_392bad84","updated":"2016-01-26 12:14:45.000000000","message":"Done","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ed0a319065c3c908b9c4d30d1e5d1ba644bbab0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        auth_result \u003d self.volume_client.authorize(self._share_path(share), ceph_auth_id)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d97b717a","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":42},"updated":"2016-01-20 16:05:17.000000000","message":"It also has \"access_level\" key with either \"rw\" or \"ro\" values. You do not use it, why?","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79948f7b293a31d412bbf5c499bcd33376c1984a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        auth_result \u003d self.volume_client.authorize(self._share_path(share), ceph_auth_id)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_19bb4977","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":42},"in_reply_to":"9a68dd71_d5b337e8","updated":"2016-01-26 12:34:07.000000000","message":"Right, so you need to perform check for key \"ro\" and fail access rule in this case. Right now, your driver says \"OK\u0027 for request of \"RO\" rule making \"RW\" indeed. It is bug, that should be fixed.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b03e471adfa071dcd64ba76951f7b238bc47ad35","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        auth_result \u003d self.volume_client.authorize(self._share_path(share), ceph_auth_id)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d5b337e8","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":42},"in_reply_to":"9a68dd71_d97b717a","updated":"2016-01-26 12:14:45.000000000","message":"Interface to ceph doesn\u0027t currently have a flag for RO access, we should at it at some point in the future.","commit_id":"c0f50c8722ec1973c251e6e12649e06546bfe078"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8c1fe2b6","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2016-01-26 19:21:41.000000000","message":"Do we have to update this now?","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3df1e001","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"9a68dd71_8c1fe2b6","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cf8295c8","line":15,"updated":"2016-01-27 08:19:48.000000000","message":"The __init__.py should be null. please move all of this code to a new file(.py)","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_log import log"},{"line_number":18,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_7debd813","line":15,"in_reply_to":"9a68dd71_cf8295c8","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"cephfs_native_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"},{"line_number":37,"context_line":"               default\u003d\"\","},{"line_number":38,"context_line":"               help\u003d\"\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":40,"context_line":"               help\u003d\"The name of the cluster in use, if it is not the default (\u0027ceph\u0027)\""},{"line_number":41,"context_line":"               ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4c5faa75","line":38,"range":{"start_line":38,"start_character":19,"end_line":38,"end_character":24},"updated":"2016-01-26 19:21:41.000000000","message":"We should have a help string in here.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"cephfs_native_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027cephfs_conf_path\u0027,"},{"line_number":37,"context_line":"               default\u003d\"\","},{"line_number":38,"context_line":"               help\u003d\"\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":40,"context_line":"               help\u003d\"The name of the cluster in use, if it is not the default (\u0027ceph\u0027)\""},{"line_number":41,"context_line":"               ),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_5d5b7cf6","line":38,"range":{"start_line":38,"start_character":19,"end_line":38,"end_character":24},"in_reply_to":"9a68dd71_4c5faa75","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               default\u003d\"\","},{"line_number":38,"context_line":"               help\u003d\"\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":40,"context_line":"               help\u003d\"The name of the cluster in use, if it is not the default (\u0027ceph\u0027)\""},{"line_number":41,"context_line":"               ),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":43,"context_line":"               default\u003d\"manila\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_ecfe9e37","line":40,"updated":"2016-01-26 19:21:41.000000000","message":"Could we specify a default value of \"ceph\" here for this option? The line is also over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               default\u003d\"\","},{"line_number":38,"context_line":"               help\u003d\"\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":40,"context_line":"               help\u003d\"The name of the cluster in use, if it is not the default (\u0027ceph\u0027)\""},{"line_number":41,"context_line":"               ),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":43,"context_line":"               default\u003d\"manila\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_bdbcf006","line":40,"in_reply_to":"9a68dd71_ecfe9e37","updated":"2016-02-02 00:23:45.000000000","message":"I don\u0027t want to enforce in manila that the default cluster name is \u0027ceph\u0027 -- that\u0027s something that\u0027s built into ceph itself, so it\u0027s correct to pass None here and let ceph apply its policy of the default cluster name.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               ),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":43,"context_line":"               default\u003d\"manila\","},{"line_number":44,"context_line":"               help\u003d\"The name of the ceph auth identity to use.  Default \u0027manila\u0027.\""},{"line_number":45,"context_line":"               ),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6f862067","line":44,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               ),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":43,"context_line":"               default\u003d\"manila\","},{"line_number":44,"context_line":"               help\u003d\"The name of the ceph auth identity to use.  Default \u0027manila\u0027.\""},{"line_number":45,"context_line":"               ),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3d56c0ce","line":44,"in_reply_to":"9a68dd71_6f862067","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opts(cephfs_native_opts)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class CephFSNativeDriver(driver.ShareDriver,):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8ff81d7e","line":50,"range":{"start_line":50,"start_character":19,"end_line":50,"end_character":37},"updated":"2016-01-27 08:19:48.000000000","message":"This should be added in manila/opts.py.\nSuch as: https://review.openstack.org/#/c/138242/28/manila/opts.py","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d cfg.CONF"},{"line_number":50,"context_line":"CONF.register_opts(cephfs_native_opts)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class CephFSNativeDriver(driver.ShareDriver,):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_9d3334ab","line":50,"range":{"start_line":50,"start_character":19,"end_line":50,"end_character":37},"in_reply_to":"9a68dd71_8ff81d7e","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"a1875e6da6241009b19bd955fab8c28d0eb59c5e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":68,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Red Hat\u0027"},{"line_number":69,"context_line":"        data[\u0027driver_version\u0027] \u003d \u00271.0\u0027"},{"line_number":70,"context_line":"        data[\u0027share_backend_name\u0027] \u003d self.backend_name"},{"line_number":71,"context_line":"        return data"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _to_bytes(self, gigs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_1ba8051f","line":70,"updated":"2016-01-28 05:42:39.000000000","message":"Report \u0027storage_protocol\u0027 as CEPHFS.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        data[\u0027consistency_group_support\u0027] \u003d \u0027pool\u0027"},{"line_number":68,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027Red Hat\u0027"},{"line_number":69,"context_line":"        data[\u0027driver_version\u0027] \u003d \u00271.0\u0027"},{"line_number":70,"context_line":"        data[\u0027share_backend_name\u0027] \u003d self.backend_name"},{"line_number":71,"context_line":"        return data"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _to_bytes(self, gigs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_dd152ce5","line":70,"in_reply_to":"7a5de9d1_1ba8051f","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _to_bytes(self, gigs):"},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        Convert a Manila size into bytes.  Manila uses gigs everywhere.  If the input"},{"line_number":76,"context_line":"        is None, return None."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param gigs: integer number of gigabytes"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2f458816","line":75,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _to_bytes(self, gigs):"},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        Convert a Manila size into bytes.  Manila uses gigs everywhere.  If the input"},{"line_number":76,"context_line":"        is None, return None."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param gigs: integer number of gigabytes"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3ddb2051","line":75,"in_reply_to":"9a68dd71_2f458816","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        Convert a Manila size into bytes.  Manila uses gigs everywhere.  If the input"},{"line_number":76,"context_line":"        is None, return None."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param gigs: integer number of gigabytes"},{"line_number":79,"context_line":"        :return: integer number of bytes"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if gigs is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_c58dad7c","line":78,"updated":"2016-01-28 01:10:21.000000000","message":"We actually use Gibibytes (GiB). Would be nice to have your naming use that.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        Convert a Manila size into bytes.  Manila uses gigs everywhere.  If the input"},{"line_number":76,"context_line":"        is None, return None."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        :param gigs: integer number of gigabytes"},{"line_number":79,"context_line":"        :return: integer number of bytes"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if gigs is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_5db7fcf4","line":78,"in_reply_to":"7a5de9d1_c58dad7c","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        :return: integer number of bytes"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if gigs is not None:"},{"line_number":82,"context_line":"            return gigs * 1024 * 1024 * 1024"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return None"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_0f63cd1b","line":82,"range":{"start_line":82,"start_character":25,"end_line":82,"end_character":44},"updated":"2016-01-27 08:19:48.000000000","message":"Could use units.Gi instead of 1024.1024.1024\n\n(from oslo.utils import units  )","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        :return: integer number of bytes"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        if gigs is not None:"},{"line_number":82,"context_line":"            return gigs * 1024 * 1024 * 1024"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return None"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_9d96d43d","line":82,"range":{"start_line":82,"start_character":25,"end_line":82,"end_character":44},"in_reply_to":"9a68dd71_0f63cd1b","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6af42a23e3be0f430dd2c298a272c279ebfc305e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if gigs is not None:"},{"line_number":82,"context_line":"            return gigs * 1024 * 1024 * 1024"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return None"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @property"},{"line_number":87,"context_line":"    def volume_client(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_524ab3ad","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":23},"updated":"2016-01-28 19:02:59.000000000","message":"This may cause TypeErrors","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            from ceph_volume_client import CephFSVolumeClient"},{"line_number":93,"context_line":"        except ImportError as e:"},{"line_number":94,"context_line":"            raise exception.ManilaException("},{"line_number":95,"context_line":"                \"Ceph client libraries not found: {0}\".format("},{"line_number":96,"context_line":"                    e"},{"line_number":97,"context_line":"                )"},{"line_number":98,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_a5be71fd","line":95,"range":{"start_line":95,"start_character":28,"end_line":95,"end_character":29},"updated":"2016-01-28 01:10:21.000000000","message":"Needs to be localized with _() See: http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            from ceph_volume_client import CephFSVolumeClient"},{"line_number":93,"context_line":"        except ImportError as e:"},{"line_number":94,"context_line":"            raise exception.ManilaException("},{"line_number":95,"context_line":"                \"Ceph client libraries not found: {0}\".format("},{"line_number":96,"context_line":"                    e"},{"line_number":97,"context_line":"                )"},{"line_number":98,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_7d9758ec","line":95,"range":{"start_line":95,"start_character":28,"end_line":95,"end_character":29},"in_reply_to":"7a5de9d1_a5be71fd","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        except ImportError as e:"},{"line_number":94,"context_line":"            raise exception.ManilaException("},{"line_number":95,"context_line":"                \"Ceph client libraries not found: {0}\".format("},{"line_number":96,"context_line":"                    e"},{"line_number":97,"context_line":"                )"},{"line_number":98,"context_line":"            )"},{"line_number":99,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cf714c79","line":96,"updated":"2016-01-26 19:21:41.000000000","message":"This can probably be put on the same line as the format() call.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        except ImportError as e:"},{"line_number":94,"context_line":"            raise exception.ManilaException("},{"line_number":95,"context_line":"                \"Ceph client libraries not found: {0}\".format("},{"line_number":96,"context_line":"                    e"},{"line_number":97,"context_line":"                )"},{"line_number":98,"context_line":"            )"},{"line_number":99,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_655e39eb","line":96,"in_reply_to":"9a68dd71_cf714c79","updated":"2016-01-28 01:10:21.000000000","message":"e should be wrapped with six.text_type()","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            conf_path \u003d self.configuration.safe_get(\u0027cephfs_conf_path\u0027)"},{"line_number":101,"context_line":"            cluster_name \u003d self.configuration.safe_get(\u0027cephfs_cluster_name\u0027)"},{"line_number":102,"context_line":"            auth_id \u003d self.configuration.safe_get(\u0027cephfs_auth_id\u0027)"},{"line_number":103,"context_line":"            self._volume_client \u003d CephFSVolumeClient(auth_id, conf_path, cluster_name)"},{"line_number":104,"context_line":"            log.info(\"Ceph client found, connecting...\")"},{"line_number":105,"context_line":"            if auth_id !\u003d CEPH_DEFAULT_AUTH_ID:"},{"line_number":106,"context_line":"                # Evict any other manila sessions.  Only do this if we\u0027re using a client ID"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4f047cc5","line":103,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 character limit.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            conf_path \u003d self.configuration.safe_get(\u0027cephfs_conf_path\u0027)"},{"line_number":101,"context_line":"            cluster_name \u003d self.configuration.safe_get(\u0027cephfs_cluster_name\u0027)"},{"line_number":102,"context_line":"            auth_id \u003d self.configuration.safe_get(\u0027cephfs_auth_id\u0027)"},{"line_number":103,"context_line":"            self._volume_client \u003d CephFSVolumeClient(auth_id, conf_path, cluster_name)"},{"line_number":104,"context_line":"            log.info(\"Ceph client found, connecting...\")"},{"line_number":105,"context_line":"            if auth_id !\u003d CEPH_DEFAULT_AUTH_ID:"},{"line_number":106,"context_line":"                # Evict any other manila sessions.  Only do this if we\u0027re using a client ID"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_8033c713","line":103,"in_reply_to":"9a68dd71_4f047cc5","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self._volume_client \u003d CephFSVolumeClient(auth_id, conf_path, cluster_name)"},{"line_number":104,"context_line":"            log.info(\"Ceph client found, connecting...\")"},{"line_number":105,"context_line":"            if auth_id !\u003d CEPH_DEFAULT_AUTH_ID:"},{"line_number":106,"context_line":"                # Evict any other manila sessions.  Only do this if we\u0027re using a client ID"},{"line_number":107,"context_line":"                # that isn\u0027t the default admin ID, to avoid rudely disrupting anyone else."},{"line_number":108,"context_line":"                premount_evict \u003d auth_id"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                premount_evict \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2f13480f","line":107,"range":{"start_line":106,"start_character":16,"end_line":107,"end_character":90},"updated":"2016-01-26 19:21:41.000000000","message":"Lines are over 79 character limit.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self._volume_client \u003d CephFSVolumeClient(auth_id, conf_path, cluster_name)"},{"line_number":104,"context_line":"            log.info(\"Ceph client found, connecting...\")"},{"line_number":105,"context_line":"            if auth_id !\u003d CEPH_DEFAULT_AUTH_ID:"},{"line_number":106,"context_line":"                # Evict any other manila sessions.  Only do this if we\u0027re using a client ID"},{"line_number":107,"context_line":"                # that isn\u0027t the default admin ID, to avoid rudely disrupting anyone else."},{"line_number":108,"context_line":"                premount_evict \u003d auth_id"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                premount_evict \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_a03843f0","line":107,"range":{"start_line":106,"start_character":16,"end_line":107,"end_character":90},"in_reply_to":"9a68dd71_2f13480f","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _share_path(self, share):"},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        Get VolumePath from ShareInstance"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        from ceph_volume_client import VolumePath"},{"line_number":136,"context_line":"        return VolumePath(share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_af59615d","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":22},"updated":"2016-01-27 08:19:48.000000000","message":"VolumePath or shre path?","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _share_path(self, share):"},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        Get VolumePath from ShareInstance"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        from ceph_volume_client import VolumePath"},{"line_number":136,"context_line":"        return VolumePath(share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_40106f59","line":133,"range":{"start_line":133,"start_character":12,"end_line":133,"end_character":22},"in_reply_to":"9a68dd71_af59615d","updated":"2016-02-02 00:23:45.000000000","message":"VolumePath.  The function gets the VolumePath (or \u0027path\u0027) from a share: hence _share_path.  We could call this \"get_volume_path_from_share\" but since it\u0027s a helper used lots of places I want it to have a short name.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        :param context: A RequestContext"},{"line_number":142,"context_line":"        :param share: A ShareInstance"},{"line_number":143,"context_line":"        :param share_server: Always None for CephFS native"},{"line_number":144,"context_line":"        :return:"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        assert share_server is None"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4fd23c36","line":144,"updated":"2016-01-26 19:21:41.000000000","message":":return: The export location information for the new share.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        :param context: A RequestContext"},{"line_number":142,"context_line":"        :param share: A ShareInstance"},{"line_number":143,"context_line":"        :param share_server: Always None for CephFS native"},{"line_number":144,"context_line":"        :return:"},{"line_number":145,"context_line":"        \"\"\""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        assert share_server is None"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_c0045f19","line":144,"in_reply_to":"9a68dd71_4fd23c36","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # `share` is a ShareInstance"},{"line_number":150,"context_line":"        log.info(\"create_share {0} name\u003d{1} size\u003d{2} cg_id\u003d{3}\".format("},{"line_number":151,"context_line":"            self.backend_name, share[\u0027share_id\u0027], share[\u0027size\u0027], share[\u0027consistency_group_id\u0027]))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":154,"context_line":"        data_isolated \u003d extra_specs.get(\"data_isolated\", False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_afedf8f0","line":151,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # `share` is a ShareInstance"},{"line_number":150,"context_line":"        log.info(\"create_share {0} name\u003d{1} size\u003d{2} cg_id\u003d{3}\".format("},{"line_number":151,"context_line":"            self.backend_name, share[\u0027share_id\u0027], share[\u0027size\u0027], share[\u0027consistency_group_id\u0027]))"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":154,"context_line":"        data_isolated \u003d extra_specs.get(\"data_isolated\", False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_530ccb3a","line":151,"in_reply_to":"9a68dd71_afedf8f0","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6f938050","line":175,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d318bb77","line":175,"in_reply_to":"9a68dd71_6f938050","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_f2597e36","line":177,"range":{"start_line":177,"start_character":37,"end_line":177,"end_character":41},"updated":"2016-01-27 08:19:48.000000000","message":"Should use common_constants.ACCESS_LEVEL_RO instead of \"ro\".\n\nfrom manila.common import constants as common_constants\nhttps://github.com/openstack/manila/blob/master/manila/common/constants.py#L91","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_53a84bdb","line":177,"range":{"start_line":177,"start_character":37,"end_line":177,"end_character":41},"in_reply_to":"9a68dd71_f2597e36","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_afa9787d","line":178,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_926842bc","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":46},"updated":"2016-01-27 08:19:48.000000000","message":"https://github.com/openstack/manila/blob/master/manila/exception.py#L414\nexception.InvalidShareAccess(reason\u003d\"...\")","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            raise exception.InvalidShareAccess(_(\"Only \u0027cephx\u0027 access type allowed\"))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if access[\u0027access_level\u0027] \u003d\u003d \"ro\":"},{"line_number":178,"context_line":"            raise exception.InvalidShareAccess(_(\"Ceph driver does not support readonly access\"))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_7339c7a3","line":178,"range":{"start_line":178,"start_character":28,"end_line":178,"end_character":46},"in_reply_to":"9a68dd71_926842bc","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        auth_result \u003d self.volume_client.authorize(self._share_path(share), ceph_auth_id)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_0faf647e","line":182,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        ceph_auth_id \u003d access[\u0027access_to\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        auth_result \u003d self.volume_client.authorize(self._share_path(share), ceph_auth_id)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_53292b36","line":182,"in_reply_to":"9a68dd71_0faf647e","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":187,"context_line":"        self.volume_client.deauthorize(self._share_path(share), access[\u0027access_to\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":190,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8fc35438","line":187,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        return auth_result[\u0027auth_key\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":187,"context_line":"        self.volume_client.deauthorize(self._share_path(share), access[\u0027access_to\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":190,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_f3229751","line":187,"in_reply_to":"9a68dd71_8fc35438","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        auth_name \u003d share[\u0027share_id\u0027]"},{"line_number":194,"context_line":"        self.volume_client.deauthorize(self._share_path(share), auth_name)"},{"line_number":195,"context_line":"        self.volume_client.evict(auth_name)"},{"line_number":196,"context_line":"        self.volume_client.delete_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":197,"context_line":"        self.volume_client.purge_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_8f4834ce","line":196,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        auth_name \u003d share[\u0027share_id\u0027]"},{"line_number":194,"context_line":"        self.volume_client.deauthorize(self._share_path(share), auth_name)"},{"line_number":195,"context_line":"        self.volume_client.evict(auth_name)"},{"line_number":196,"context_line":"        self.volume_client.delete_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":197,"context_line":"        self.volume_client.purge_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d3151be5","line":196,"in_reply_to":"9a68dd71_8f4834ce","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.volume_client.deauthorize(self._share_path(share), auth_name)"},{"line_number":195,"context_line":"        self.volume_client.evict(auth_name)"},{"line_number":196,"context_line":"        self.volume_client.delete_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":197,"context_line":"        self.volume_client.purge_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":200,"context_line":"        # Creation is idempotent"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_af45f8b3","line":197,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.volume_client.deauthorize(self._share_path(share), auth_name)"},{"line_number":195,"context_line":"        self.volume_client.evict(auth_name)"},{"line_number":196,"context_line":"        self.volume_client.delete_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":197,"context_line":"        self.volume_client.purge_volume(self._share_path(share), data_isolated\u003ddata_isolated)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":200,"context_line":"        # Creation is idempotent"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_93da434b","line":197,"in_reply_to":"9a68dd71_af45f8b3","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        return self.create_share(context, share, share_server)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":204,"context_line":"        log.info(\"extend_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":205,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share), self._to_bytes(new_size))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_652cf94a","line":204,"updated":"2016-01-28 01:10:21.000000000","message":"_LI() for localization (everything except debug) -- actually I think these enter message should be debug.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        return self.create_share(context, share, share_server)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":204,"context_line":"        log.info(\"extend_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":205,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share), self._to_bytes(new_size))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_7306a787","line":204,"in_reply_to":"7a5de9d1_652cf94a","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":204,"context_line":"        log.info(\"extend_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":205,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share), self._to_bytes(new_size))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":208,"context_line":"        log.info(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_4f5f9c75","line":205,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":204,"context_line":"        log.info(\"extend_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":205,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share), self._to_bytes(new_size))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":208,"context_line":"        log.info(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d3d67bf0","line":205,"in_reply_to":"9a68dd71_4f5f9c75","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share), self._to_bytes(new_size))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":208,"context_line":"        log.info(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":209,"context_line":"        new_bytes \u003d self._to_bytes(new_size)"},{"line_number":210,"context_line":"        used \u003d self.volume_client.get_used_bytes(self._share_path(share))"},{"line_number":211,"context_line":"        if used \u003e new_bytes:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_051e650c","line":208,"updated":"2016-01-28 01:10:21.000000000","message":"I think everyone is using %(name)s and % instead of {0} and .format -- not sure if that is a documented standard","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        self.volume_client.set_max_bytes(self._share_path(share), self._to_bytes(new_size))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":208,"context_line":"        log.info(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":209,"context_line":"        new_bytes \u003d self._to_bytes(new_size)"},{"line_number":210,"context_line":"        used \u003d self.volume_client.get_used_bytes(self._share_path(share))"},{"line_number":211,"context_line":"        if used \u003e new_bytes:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_b3d97f24","line":208,"in_reply_to":"7a5de9d1_051e650c","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6af42a23e3be0f430dd2c298a272c279ebfc305e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        log.info(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":209,"context_line":"        new_bytes \u003d self._to_bytes(new_size)"},{"line_number":210,"context_line":"        used \u003d self.volume_client.get_used_bytes(self._share_path(share))"},{"line_number":211,"context_line":"        if used \u003e new_bytes:"},{"line_number":212,"context_line":"            # While in fact we can \"shrink\" our volumes to less than their"},{"line_number":213,"context_line":"            # used bytes (it\u0027s just a quota), raise error anyway to avoid"},{"line_number":214,"context_line":"            # confusing API consumers that might depend on typical shrink"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_52e15399","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":28},"updated":"2016-01-28 19:02:59.000000000","message":"Since new_bytes may come from _to_bytes which may return None, this may raise a TypeError.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        log.info(\"shrink_share {0} {1}\".format(share[\u0027share_id\u0027], new_size))"},{"line_number":209,"context_line":"        new_bytes \u003d self._to_bytes(new_size)"},{"line_number":210,"context_line":"        used \u003d self.volume_client.get_used_bytes(self._share_path(share))"},{"line_number":211,"context_line":"        if used \u003e new_bytes:"},{"line_number":212,"context_line":"            # While in fact we can \"shrink\" our volumes to less than their"},{"line_number":213,"context_line":"            # used bytes (it\u0027s just a quota), raise error anyway to avoid"},{"line_number":214,"context_line":"            # confusing API consumers that might depend on typical shrink"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_137c131e","line":211,"range":{"start_line":211,"start_character":8,"end_line":211,"end_character":28},"in_reply_to":"7a5de9d1_52e15399","updated":"2016-02-02 00:23:45.000000000","message":"Only if some passes None into shrink_share.  We don\u0027t check all our other arguments for None, I don\u0027t think it\u0027s logical to check this one argument.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        # We assign names to created snapshots"},{"line_number":227,"context_line":"        assert snapshot[\u0027name\u0027] is not None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        self.volume_client.destroy_snapshot_volume(self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"},{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict, cgsnapshot_dict, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6f4e2098","line":229,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        # We assign names to created snapshots"},{"line_number":227,"context_line":"        assert snapshot[\u0027name\u0027] is not None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        self.volume_client.destroy_snapshot_volume(self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"},{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict, cgsnapshot_dict, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_f34137aa","line":229,"in_reply_to":"9a68dd71_6f4e2098","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        assert snapshot[\u0027name\u0027] is not None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        self.volume_client.destroy_snapshot_volume(self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"},{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict, cgsnapshot_dict, share_server\u003dNone):"},{"line_number":233,"context_line":"        # TODO"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_52b96a2d","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":19},"updated":"2016-01-27 08:19:48.000000000","message":"Why need to return None?","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        assert snapshot[\u0027name\u0027] is not None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        self.volume_client.destroy_snapshot_volume(self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"},{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict, cgsnapshot_dict, share_server\u003dNone):"},{"line_number":233,"context_line":"        # TODO"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_53384b3d","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":19},"in_reply_to":"9a68dd71_52b96a2d","updated":"2016-02-02 00:23:45.000000000","message":"No reason.  removed.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.volume_client.destroy_snapshot_volume(self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"},{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict, cgsnapshot_dict, share_server\u003dNone):"},{"line_number":233,"context_line":"        # TODO"},{"line_number":234,"context_line":"        raise NotImplementedError()"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_cf5dcc49","line":232,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self.volume_client.destroy_snapshot_volume(self._share_path(snapshot[\u0027share\u0027]), snapshot[\u0027name\u0027])"},{"line_number":230,"context_line":"        return None"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_consistency_group_from_cgsnapshot(self, context, cg_dict, cgsnapshot_dict, share_server\u003dNone):"},{"line_number":233,"context_line":"        # TODO"},{"line_number":234,"context_line":"        raise NotImplementedError()"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d3ed1bb8","line":232,"in_reply_to":"9a68dd71_cf5dcc49","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            snap_dict[\u0027id\u0027]"},{"line_number":246,"context_line":"        )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return None, []"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def create_cgsnapshot(self, context, snap_dict, share_server\u003dNone):"},{"line_number":251,"context_line":"        self.volume_client.create_snapshot_group("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_6f1ce077","line":248,"updated":"2016-01-26 19:21:41.000000000","message":"What is this returning and why? A docstring explaining this would help clarify.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            snap_dict[\u0027id\u0027]"},{"line_number":246,"context_line":"        )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return None, []"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def create_cgsnapshot(self, context, snap_dict, share_server\u003dNone):"},{"line_number":251,"context_line":"        self.volume_client.create_snapshot_group("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_b3f09f92","line":248,"in_reply_to":"9a68dd71_6f1ce077","updated":"2016-02-02 00:23:45.000000000","message":"The return format of all these functions is defined in the ShareDriver interface, I don\u0027t think it makes sense to repeat it in every driver implementation","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            snap_dict[\u0027id\u0027],"},{"line_number":253,"context_line":"            snap_dict[\u0027id\u0027])"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        return None, []"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def __del__(self):"},{"line_number":258,"context_line":"        if self._volume_client:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_2f16e855","line":255,"updated":"2016-01-26 19:21:41.000000000","message":"Same as above.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"}],"manila/share/drivers/cephfs/cephfs_native.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\"Fully qualified path to the ceph.conf file.\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":49,"context_line":"               help\u003d\"The name of the cluster in use, if it is not \""},{"line_number":50,"context_line":"                    \"the default (\u0027ceph\u0027).\""},{"line_number":51,"context_line":"               ),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":53,"context_line":"               default\u003d\"manila\","}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_362feca2","line":50,"updated":"2016-02-25 09:58:36.000000000","message":"default\u003d\"ceph\" missing . Also you don\u0027t need to explicitly write the default in the help text. It will be obvious from the generated manila.conf.sample","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\"Fully qualified path to the ceph.conf file.\"),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027cephfs_cluster_name\u0027,"},{"line_number":49,"context_line":"               help\u003d\"The name of the cluster in use, if it is not \""},{"line_number":50,"context_line":"                    \"the default (\u0027ceph\u0027).\""},{"line_number":51,"context_line":"               ),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":53,"context_line":"               default\u003d\"manila\","}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_77396b41","line":50,"in_reply_to":"bae84128_362feca2","updated":"2016-02-25 16:22:51.000000000","message":"This is a default that comes from ceph, not this driver.  This driver passes through None for the default.","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":53,"context_line":"               default\u003d\"manila\","},{"line_number":54,"context_line":"               help\u003d\"The name of the ceph auth identity to use.  \""},{"line_number":55,"context_line":"                    \"Default \u0027manila\u0027.\""},{"line_number":56,"context_line":"               ),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027cephfs_enable_snapshots\u0027,"},{"line_number":58,"context_line":"               default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_b1402609","line":55,"updated":"2016-02-25 09:58:36.000000000","message":"same here. no default in help text needed","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027cephfs_auth_id\u0027,"},{"line_number":53,"context_line":"               default\u003d\"manila\","},{"line_number":54,"context_line":"               help\u003d\"The name of the ceph auth identity to use.  \""},{"line_number":55,"context_line":"                    \"Default \u0027manila\u0027.\""},{"line_number":56,"context_line":"               ),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027cephfs_enable_snapshots\u0027,"},{"line_number":58,"context_line":"               default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_98f7ed58","line":55,"in_reply_to":"bae84128_b1402609","updated":"2016-02-25 16:22:51.000000000","message":"Done","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               help\u003d\"The name of the ceph auth identity to use.  \""},{"line_number":55,"context_line":"                    \"Default \u0027manila\u0027.\""},{"line_number":56,"context_line":"               ),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027cephfs_enable_snapshots\u0027,"},{"line_number":58,"context_line":"               default\u003dFalse,"},{"line_number":59,"context_line":"               help\u003d\"Whether to enable snapshots in this driver.  \""},{"line_number":60,"context_line":"                    \"Default: False.\""}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_3606cc20","line":57,"updated":"2016-02-25 09:58:36.000000000","message":"Please use BoolOpt here","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               help\u003d\"The name of the ceph auth identity to use.  \""},{"line_number":55,"context_line":"                    \"Default \u0027manila\u0027.\""},{"line_number":56,"context_line":"               ),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027cephfs_enable_snapshots\u0027,"},{"line_number":58,"context_line":"               default\u003dFalse,"},{"line_number":59,"context_line":"               help\u003d\"Whether to enable snapshots in this driver.  \""},{"line_number":60,"context_line":"                    \"Default: False.\""}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_3ba5fb03","line":57,"in_reply_to":"bae84128_3606cc20","updated":"2016-02-25 16:22:51.000000000","message":"Done","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cfg.StrOpt(\u0027cephfs_enable_snapshots\u0027,"},{"line_number":58,"context_line":"               default\u003dFalse,"},{"line_number":59,"context_line":"               help\u003d\"Whether to enable snapshots in this driver.  \""},{"line_number":60,"context_line":"                    \"Default: False.\""},{"line_number":61,"context_line":"               ),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_31e7f641","line":60,"updated":"2016-02-25 09:58:36.000000000","message":"same here. no default in help text needed","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    cfg.StrOpt(\u0027cephfs_enable_snapshots\u0027,"},{"line_number":58,"context_line":"               default\u003dFalse,"},{"line_number":59,"context_line":"               help\u003d\"Whether to enable snapshots in this driver.  \""},{"line_number":60,"context_line":"                    \"Default: False.\""},{"line_number":61,"context_line":"               ),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_5baa7fd3","line":60,"in_reply_to":"bae84128_31e7f641","updated":"2016-02-25 16:22:51.000000000","message":"Done","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"a1a3fb93f373c3103fbdfcf95af6502a8ca8f03a","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":242,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":243,"context_line":"        data_isolated \u003d extra_specs.get(\"data_isolated\", False)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.volume_client.delete_volume(self._share_path(share),"},{"line_number":246,"context_line":"                                         data_isolated\u003ddata_isolated)"}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_0381c98f","line":243,"updated":"2016-02-25 09:58:36.000000000","message":"Shouldn\u0027t the extra spec be namespaced? like \"cephfs:data_isolated\" ?","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"4f53215da599ca8cbd4d096312bedd6c76dd69ab","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":242,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"},{"line_number":243,"context_line":"        data_isolated \u003d extra_specs.get(\"data_isolated\", False)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.volume_client.delete_volume(self._share_path(share),"},{"line_number":246,"context_line":"                                         data_isolated\u003ddata_isolated)"}],"source_content_type":"text/x-python","patch_set":33,"id":"bae84128_5b21dffb","line":243,"in_reply_to":"bae84128_0381c98f","updated":"2016-02-25 16:22:51.000000000","message":"Done","commit_id":"3aab703d18adaace47f38fded35a94b0b59b2fab"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila.share import share_types"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"try:"},{"line_number":29,"context_line":"    import ceph_volume_client"},{"line_number":30,"context_line":"    ceph_module_found \u003d True"},{"line_number":31,"context_line":"except ImportError as e:"},{"line_number":32,"context_line":"    ceph_volume_client \u003d None"},{"line_number":33,"context_line":"    ceph_module_found \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CEPHX_ACCESS_TYPE \u003d \"cephx\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_7357d102","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":29},"updated":"2016-02-26 02:37:55.000000000","message":"oslo_utils has this module called \"import_utils\"\nA bit more elegant.. no try...except.  http://docs.openstack.org/developer/oslo.utils/api/importutils.html#oslo_utils.importutils.try_import\n\n\n \n   ceph_volume_client \u003d importutils.try_import(\u0027cep_volume_client\u0027)\n   ceph_module_found \u003d False if ceph_module_client is None","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila.share import share_types"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"try:"},{"line_number":29,"context_line":"    import ceph_volume_client"},{"line_number":30,"context_line":"    ceph_module_found \u003d True"},{"line_number":31,"context_line":"except ImportError as e:"},{"line_number":32,"context_line":"    ceph_volume_client \u003d None"},{"line_number":33,"context_line":"    ceph_module_found \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CEPHX_ACCESS_TYPE \u003d \"cephx\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_f6a57804","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":29},"in_reply_to":"9aed3d3a_7357d102","updated":"2016-02-26 12:33:18.000000000","message":"I don\u0027t agree that bringing in a third party helper function to do this is more elegant.  What I\u0027ve written is perfectly standard python that anyone will understand.  Using a helper function would force the reader to go read that to find out what it does.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":83,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":84,"context_line":"            \u0027storage_protocol\u0027: \"CEPHFS\","},{"line_number":85,"context_line":"            \u0027pools\u0027: [\u0027cephfs\u0027],"},{"line_number":86,"context_line":"            \u0027total_capacity_gb\u0027: stats[\u0027kb\u0027] * units.Mi,"},{"line_number":87,"context_line":"            \u0027free_capacity_gb\u0027: stats[\u0027kb_avail\u0027] * units.Mi,"},{"line_number":88,"context_line":"            \u0027snapshot_support\u0027: self.configuration.safe_get("},{"line_number":89,"context_line":"                \u0027cephfs_enable_snapshots\u0027),"},{"line_number":90,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_b3b0398d","line":87,"range":{"start_line":85,"start_character":12,"end_line":87,"end_character":61},"updated":"2016-02-26 02:50:49.000000000","message":"Good to see the capacity info added, but it should go into the pool dict.  Here\u0027s an example:  https://github.com/openstack/manila/blob/master/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py#L258","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":83,"context_line":"            \u0027share_backend_name\u0027: self.backend_name,"},{"line_number":84,"context_line":"            \u0027storage_protocol\u0027: \"CEPHFS\","},{"line_number":85,"context_line":"            \u0027pools\u0027: [\u0027cephfs\u0027],"},{"line_number":86,"context_line":"            \u0027total_capacity_gb\u0027: stats[\u0027kb\u0027] * units.Mi,"},{"line_number":87,"context_line":"            \u0027free_capacity_gb\u0027: stats[\u0027kb_avail\u0027] * units.Mi,"},{"line_number":88,"context_line":"            \u0027snapshot_support\u0027: self.configuration.safe_get("},{"line_number":89,"context_line":"                \u0027cephfs_enable_snapshots\u0027),"},{"line_number":90,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_96bb4cc4","line":87,"range":{"start_line":85,"start_character":12,"end_line":87,"end_character":61},"in_reply_to":"9aed3d3a_b3b0398d","updated":"2016-02-26 12:33:18.000000000","message":"It\u0027s a global figure.  I guess you\u0027re asking me to report it twice, once in the outer dict and then again inside the pool dict?\n\nIs this documented anywhere?  The docstring for _update_share_stats helpfully says \"dict -- dict with key-value pairs to redefine common ones.\".\n\nI\u0027ve modified this to roughly follow what the netapp driver does.  Let me know if that is okay with you.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        return self._volume_client"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":139,"context_line":"        super(CephFSNativeDriver, self).__init__("},{"line_number":140,"context_line":"            [False], *args, **kwargs)"},{"line_number":141,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_ce7434ff","line":138,"range":{"start_line":138,"start_character":4,"end_line":138,"end_character":16},"updated":"2016-02-26 02:50:49.000000000","message":"Not a huge deal, but it was a little strange to not see __init__() appear first in the class.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        return self._volume_client"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":139,"context_line":"        super(CephFSNativeDriver, self).__init__("},{"line_number":140,"context_line":"            [False], *args, **kwargs)"},{"line_number":141,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_36d24001","line":138,"range":{"start_line":138,"start_character":4,"end_line":138,"end_character":16},"in_reply_to":"9aed3d3a_ce7434ff","updated":"2016-02-26 12:33:18.000000000","message":"If you prefer, I\u0027ll move it to the top.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        return self._volume_client"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":139,"context_line":"        super(CephFSNativeDriver, self).__init__("},{"line_number":140,"context_line":"            [False], *args, **kwargs)"},{"line_number":141,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":142,"context_line":"            \u0027share_backend_name\u0027) or \u0027CephFS-Native\u0027"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_0e7e1ce4","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":37},"updated":"2016-02-26 02:50:49.000000000","message":"No need to wrap this line.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":139,"context_line":"        super(CephFSNativeDriver, self).__init__("},{"line_number":140,"context_line":"            [False], *args, **kwargs)"},{"line_number":141,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":142,"context_line":"            \u0027share_backend_name\u0027) or \u0027CephFS-Native\u0027"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_f39f615d","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":19},"updated":"2016-02-26 02:37:55.000000000","message":"Why a list? just False is sufficient.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        return self._volume_client"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":139,"context_line":"        super(CephFSNativeDriver, self).__init__("},{"line_number":140,"context_line":"            [False], *args, **kwargs)"},{"line_number":141,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":142,"context_line":"            \u0027share_backend_name\u0027) or \u0027CephFS-Native\u0027"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_16ae1c2e","line":140,"range":{"start_line":139,"start_character":0,"end_line":140,"end_character":37},"in_reply_to":"9aed3d3a_0e7e1ce4","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":139,"context_line":"        super(CephFSNativeDriver, self).__init__("},{"line_number":140,"context_line":"            [False], *args, **kwargs)"},{"line_number":141,"context_line":"        self.backend_name \u003d self.configuration.safe_get("},{"line_number":142,"context_line":"            \u0027share_backend_name\u0027) or \u0027CephFS-Native\u0027"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_f6b61889","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":19},"in_reply_to":"9aed3d3a_f39f615d","updated":"2016-02-26 12:33:18.000000000","message":"Sure, one can pass False here and it gets converted to a list later.  If it makes you happy I\u0027ll change [False] to a completely equivalent False.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.configuration.append_config_values(cephfs_native_opts)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _share_path(self, share):"},{"line_number":149,"context_line":"        \"\"\"Get VolumePath from ShareInstance.\"\"\""},{"line_number":150,"context_line":"        return ceph_volume_client.VolumePath("},{"line_number":151,"context_line":"            share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_73b071de","line":149,"range":{"start_line":149,"start_character":31,"end_line":149,"end_character":44},"updated":"2016-02-26 02:37:55.000000000","message":"Share. Lets pretend you don\u0027t know about Instances. (It will always stay that way) Please update all docstrings below as well. \n\nYou will receive a Share (with Instance data), the share manager handles the abstraction..","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.configuration.append_config_values(cephfs_native_opts)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _share_path(self, share):"},{"line_number":149,"context_line":"        \"\"\"Get VolumePath from ShareInstance.\"\"\""},{"line_number":150,"context_line":"        return ceph_volume_client.VolumePath("},{"line_number":151,"context_line":"            share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_812b0882","line":149,"range":{"start_line":149,"start_character":31,"end_line":149,"end_character":44},"in_reply_to":"9aed3d3a_73b071de","updated":"2016-02-26 12:33:18.000000000","message":"I think it is bizarre to simply say something untrue in comments like this, but since you and Clinton both agree, I\u0027ll change it.\n\nIs this documented anywhere?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _share_path(self, share):"},{"line_number":149,"context_line":"        \"\"\"Get VolumePath from ShareInstance.\"\"\""},{"line_number":150,"context_line":"        return ceph_volume_client.VolumePath("},{"line_number":151,"context_line":"            share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":154,"context_line":"        \"\"\"Create a CephFS volume."}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_1365a544","line":151,"range":{"start_line":151,"start_character":43,"end_line":151,"end_character":59},"updated":"2016-02-26 02:37:55.000000000","message":"nope.. share[\u0027id\u0027] please.. \n \nshare[\u0027share_id\u0027] refers to the superficial share model which could have many instances.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _share_path(self, share):"},{"line_number":149,"context_line":"        \"\"\"Get VolumePath from ShareInstance.\"\"\""},{"line_number":150,"context_line":"        return ceph_volume_client.VolumePath("},{"line_number":151,"context_line":"            share[\u0027consistency_group_id\u0027], share[\u0027share_id\u0027])"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":154,"context_line":"        \"\"\"Create a CephFS volume."}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_e1cad4a0","line":151,"range":{"start_line":151,"start_character":43,"end_line":151,"end_character":59},"in_reply_to":"9aed3d3a_1365a544","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        \"\"\"Create a CephFS volume."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :param context: A RequestContext."},{"line_number":157,"context_line":"        :param share: A ShareInstance."},{"line_number":158,"context_line":"        :param share_server: Always None for CephFS native."},{"line_number":159,"context_line":"        :return: The export location string."},{"line_number":160,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_5303ad73","line":157,"range":{"start_line":157,"start_character":24,"end_line":157,"end_character":37},"updated":"2016-02-26 02:37:55.000000000","message":"A Share","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        \"\"\"Create a CephFS volume."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :param context: A RequestContext."},{"line_number":157,"context_line":"        :param share: A ShareInstance."},{"line_number":158,"context_line":"        :param share_server: Always None for CephFS native."},{"line_number":159,"context_line":"        :return: The export location string."},{"line_number":160,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_8effcc33","line":157,"range":{"start_line":157,"start_character":24,"end_line":157,"end_character":37},"in_reply_to":"9aed3d3a_5303ad73","updated":"2016-02-26 02:50:49.000000000","message":"+1  Technically, yes, this is a ShareInstance.  But ShareInstances are a recent necessary invention to enable things like migration and replication, so the design point is that drivers know nothing about them.  As far as the driver is concerned, it\u0027s just a \u0027share\u0027.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # `share` is a ShareInstance"},{"line_number":163,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("},{"line_number":164,"context_line":"            be\u003dself.backend_name, id\u003dshare[\u0027share_id\u0027], size\u003dshare[\u0027size\u0027],"},{"line_number":165,"context_line":"            cg\u003dshare[\u0027consistency_group_id\u0027]))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_730cf194","line":164,"range":{"start_line":164,"start_character":37,"end_line":164,"end_character":54},"updated":"2016-02-26 02:37:55.000000000","message":"Whyyy? :(\n\nThis should be share[\u0027id\u0027]","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # `share` is a ShareInstance"},{"line_number":163,"context_line":"        LOG.debug(\"create_share {be} name\u003d{id} size\u003d{size} cg_id\u003d{cg}\".format("},{"line_number":164,"context_line":"            be\u003dself.backend_name, id\u003dshare[\u0027share_id\u0027], size\u003dshare[\u0027size\u0027],"},{"line_number":165,"context_line":"            cg\u003dshare[\u0027consistency_group_id\u0027]))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        extra_specs \u003d share_types.get_extra_specs_from_share(share)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_21c5dc8d","line":164,"range":{"start_line":164,"start_character":37,"end_line":164,"end_character":54},"in_reply_to":"9aed3d3a_730cf194","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            path\u003dvolume[\u0027mount_path\u0027])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(_LI(\"Calculated export location for share %(id)s: %(loc)s\"),"},{"line_number":184,"context_line":"                 {\"id\": share[\u0027share_id\u0027], \"loc\": export_location})"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        return export_location"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_13f3e574","line":184,"range":{"start_line":184,"start_character":29,"end_line":184,"end_character":41},"updated":"2016-02-26 02:37:55.000000000","message":"share[\u0027id\u0027]","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            path\u003dvolume[\u0027mount_path\u0027])"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        LOG.info(_LI(\"Calculated export location for share %(id)s: %(loc)s\"),"},{"line_number":184,"context_line":"                 {\"id\": share[\u0027share_id\u0027], \"loc\": export_location})"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        return export_location"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_c1b070f7","line":184,"range":{"start_line":184,"start_character":29,"end_line":184,"end_character":41},"in_reply_to":"9aed3d3a_13f3e574","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":205,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":206,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, \""},{"line_number":207,"context_line":"                            \"ignoring in deny.\"),"},{"line_number":208,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":209,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_2e1200b5","line":206,"range":{"start_line":206,"start_character":12,"end_line":206,"end_character":23},"updated":"2016-02-26 02:50:49.000000000","message":"This block wasn\u0027t hit by a unit test.  In fact, you could boost unit test coverage to 100% by adding about 3 unit tests.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":205,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":206,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, \""},{"line_number":207,"context_line":"                            \"ignoring in deny.\"),"},{"line_number":208,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":209,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_9386d5b7","line":206,"range":{"start_line":206,"start_character":52,"end_line":206,"end_character":55},"updated":"2016-02-26 02:37:55.000000000","message":"why one letter short?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":205,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":206,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, \""},{"line_number":207,"context_line":"                            \"ignoring in deny.\"),"},{"line_number":208,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":209,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_c1b510ce","line":206,"range":{"start_line":206,"start_character":12,"end_line":206,"end_character":23},"in_reply_to":"9aed3d3a_2e1200b5","updated":"2016-02-26 12:33:18.000000000","message":"I\u0027m aiming for the 90% target that is specified in http://docs.openstack.org/developer/manila/devref/driver_requirements.html#unit-tests for this review.  We can look at bringing that up to 100% in subsequent patches","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":205,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":206,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, \""},{"line_number":207,"context_line":"                            \"ignoring in deny.\"),"},{"line_number":208,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":209,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_e70f84df","line":206,"range":{"start_line":206,"start_character":52,"end_line":206,"end_character":55},"in_reply_to":"9aed3d3a_9386d5b7","updated":"2016-02-26 12:33:18.000000000","message":"This was squeezed to fit in at some point, but now it\u0027s wrapped so never mind.  Expanded it to be type.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":206,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, \""},{"line_number":207,"context_line":"                            \"ignoring in deny.\"),"},{"line_number":208,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":209,"context_line":"            return"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.volume_client.deauthorize(self._share_path(share),"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_eedbf819","line":208,"range":{"start_line":208,"start_character":26,"end_line":208,"end_character":29},"updated":"2016-02-26 02:50:49.000000000","message":"You couldn\u0027t spell out \u0027type\u0027?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        if access[\u0027access_type\u0027] !\u003d CEPHX_ACCESS_TYPE:"},{"line_number":206,"context_line":"            LOG.warning(_LW(\"Invalid access type \u0027%(typ)s\u0027, \""},{"line_number":207,"context_line":"                            \"ignoring in deny.\"),"},{"line_number":208,"context_line":"                        {\"typ\": access[\u0027access_type\u0027]})"},{"line_number":209,"context_line":"            return"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        self.volume_client.deauthorize(self._share_path(share),"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_81a668bf","line":208,"range":{"start_line":208,"start_character":26,"end_line":208,"end_character":29},"in_reply_to":"9aed3d3a_eedbf819","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        if used \u003e new_bytes:"},{"line_number":264,"context_line":"            # While in fact we can \"shrink\" our volumes to less than their"},{"line_number":265,"context_line":"            # used bytes (it\u0027s just a quota), raise error anyway to avoid"},{"line_number":266,"context_line":"            # confusing API consumers that might depend on typical shrink"},{"line_number":267,"context_line":"            # behaviour."},{"line_number":268,"context_line":"            raise exception.ShareShrinkingPossibleDataLoss("},{"line_number":269,"context_line":"                share_id\u003dshare[\u0027share_id\u0027])"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_b35e7943","line":267,"range":{"start_line":266,"start_character":14,"end_line":267,"end_character":24},"updated":"2016-02-26 02:37:55.000000000","message":"+1","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9be27240109559c844765668ca54ec644f9fd7dd","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        :param context: A RequestContext."},{"line_number":170,"context_line":"        :param share: A Share."},{"line_number":171,"context_line":"        :param share_server: Always None for CephFS native."},{"line_number":172,"context_line":"        :return: The export location string."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # `share` is a Share"}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_3c0a9a79","line":172,"range":{"start_line":172,"start_character":17,"end_line":172,"end_character":43},"updated":"2016-02-29 22:04:44.000000000","message":"It should have not been a string. String El is deprecated now.\n\nhttps://github.com/openstack/manila/blob/c288d902/manila/share/manager.py#L809\n\nhttps://github.com/openstack/manila/blob/c288d902/manila/db/sqlalchemy/api.py#L2323","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"12932b9684d69c4a2515f7f0b2511200e3d3ad86","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        :param context: A RequestContext."},{"line_number":170,"context_line":"        :param share: A Share."},{"line_number":171,"context_line":"        :param share_server: Always None for CephFS native."},{"line_number":172,"context_line":"        :return: The export location string."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # `share` is a Share"}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_9598c71d","line":172,"range":{"start_line":172,"start_character":17,"end_line":172,"end_character":43},"in_reply_to":"9aed3d3a_3c0a9a79","updated":"2016-03-01 08:17:03.000000000","message":"Thanks! Done.","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9be27240109559c844765668ca54ec644f9fd7dd","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        # interface should be extended to enable a full implementation"},{"line_number":235,"context_line":"        # of update_access."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        if add_rules:"},{"line_number":238,"context_line":"            for rule in add_rules:"},{"line_number":239,"context_line":"                self._allow_access(context, share, rule)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_5c883ec5","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":21},"updated":"2016-02-29 22:04:44.000000000","message":"This condition completely redundant.","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"12932b9684d69c4a2515f7f0b2511200e3d3ad86","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        # interface should be extended to enable a full implementation"},{"line_number":235,"context_line":"        # of update_access."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        if add_rules:"},{"line_number":238,"context_line":"            for rule in add_rules:"},{"line_number":239,"context_line":"                self._allow_access(context, share, rule)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_3961f5a9","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":21},"in_reply_to":"9aed3d3a_5c883ec5","updated":"2016-03-01 08:17:03.000000000","message":"Currently, this is not as straight forward as you imply. Please see the exchanges between Clinton and Rodrigo on patchset 29 of generic driver\u0027s update_access support,\nhttps://review.openstack.org/#/c/256281/29/manila/share/driver.py\n\nBut yeah, let me do this change, and not wait for the changes to be made to driver.py\u0027s doc string and method signature for the update_access method.","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9be27240109559c844765668ca54ec644f9fd7dd","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            for rule in add_rules:"},{"line_number":239,"context_line":"                self._allow_access(context, share, rule)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if delete_rules:"},{"line_number":242,"context_line":"            for rule in delete_rules:"},{"line_number":243,"context_line":"                self._deny_access(context, share, rule)"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_bc918af3","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":24},"updated":"2016-02-29 22:04:44.000000000","message":"same here.","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"12932b9684d69c4a2515f7f0b2511200e3d3ad86","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            for rule in add_rules:"},{"line_number":239,"context_line":"                self._allow_access(context, share, rule)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if delete_rules:"},{"line_number":242,"context_line":"            for rule in delete_rules:"},{"line_number":243,"context_line":"                self._deny_access(context, share, rule)"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_1964f1b6","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":24},"in_reply_to":"9aed3d3a_bc918af3","updated":"2016-03-01 08:17:03.000000000","message":"Same as above.","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9be27240109559c844765668ca54ec644f9fd7dd","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":262,"context_line":"        # Creation is idempotent"},{"line_number":263,"context_line":"        return self.create_share(context, share, share_server)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":266,"context_line":"        LOG.debug(\"extend_share {id} {size}\".format("}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_fc64b222","line":263,"range":{"start_line":263,"start_character":20,"end_line":263,"end_character":32},"updated":"2016-02-29 22:04:44.000000000","message":"create share in \"ensure\"?","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"12932b9684d69c4a2515f7f0b2511200e3d3ad86","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":262,"context_line":"        # Creation is idempotent"},{"line_number":263,"context_line":"        return self.create_share(context, share, share_server)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def extend_share(self, share, new_size, share_server\u003dNone):"},{"line_number":266,"context_line":"        LOG.debug(\"extend_share {id} {size}\".format("}],"source_content_type":"text/x-python","patch_set":39,"id":"9aed3d3a_b514eb4c","line":263,"range":{"start_line":263,"start_character":20,"end_line":263,"end_character":32},"in_reply_to":"9aed3d3a_fc64b222","updated":"2016-03-01 08:17:03.000000000","message":"Missed reading the comment above?","commit_id":"ed46eb76d3a7efa09cfbf97c5b4dd707b6aa8637"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0b9c19b2aa95c368b3afbe2c7a2b87391c8c8ca0","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                                       access[\u0027access_to\u0027])"},{"line_number":230,"context_line":"        self.volume_client.evict(access[\u0027access_to\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"},{"line_number":233,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":234,"context_line":"        # The interface to Ceph just provides add/remove methods, since it"},{"line_number":235,"context_line":"        # was created at start of mitaka cycle when there was no requirement"}],"source_content_type":"text/x-python","patch_set":41,"id":"7af24918_495dc4e8","line":232,"range":{"start_line":232,"start_character":67,"end_line":232,"end_character":72},"updated":"2016-03-01 16:35:44.000000000","message":"removal of conditions should have been accompanied with removal of default \"None\" value as it will lead to error in code logic.","commit_id":"cb04b5cb1f21d9f03f06c162a86bbe268da9d313"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3dc4bbb9d76738d3797789933498474faebd121","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                                       access[\u0027access_to\u0027])"},{"line_number":230,"context_line":"        self.volume_client.evict(access[\u0027access_to\u0027])"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def update_access(self, context, share, access_rules, add_rules\u003dNone,"},{"line_number":233,"context_line":"                      delete_rules\u003dNone, share_server\u003dNone):"},{"line_number":234,"context_line":"        # The interface to Ceph just provides add/remove methods, since it"},{"line_number":235,"context_line":"        # was created at start of mitaka cycle when there was no requirement"}],"source_content_type":"text/x-python","patch_set":41,"id":"7af24918_8ccb5a72","line":232,"range":{"start_line":232,"start_character":67,"end_line":232,"end_character":72},"in_reply_to":"7af24918_495dc4e8","updated":"2016-03-01 16:50:42.000000000","message":"-1. Removal of conditions was due to the fact that this function is currently never receiving add_rules\u003dNone. Method signature should not be changed at this moment. A later patch will fix the signature for base driver class and all affected drivers.","commit_id":"cb04b5cb1f21d9f03f06c162a86bbe268da9d313"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"8c3d9e063bfcc32fdb209e20016e744489b497fc","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        # of update_access."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        for rule in add_rules:"},{"line_number":242,"context_line":"            self._allow_access(context, share, rule)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        for rule in delete_rules:"},{"line_number":245,"context_line":"            self._deny_access(context, share, rule)"}],"source_content_type":"text/x-python","patch_set":41,"id":"9aed3d3a_a2adceea","line":242,"updated":"2016-03-01 09:16:20.000000000","message":"While Valeriy thought it was redundant to have an \"if add_rules\" here, I\u0027m not sure that\u0027s true.  The documentation for ShareDriver.update_access defines add_rules as being either None or a list.  If it\u0027s None, we need a check for that.  Perhaps Valeriy can tell us if that documentation is incorrect?","commit_id":"cb04b5cb1f21d9f03f06c162a86bbe268da9d313"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"b0b35a2ada953ae6f0db737b189d621439909cb8","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        # of update_access."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        for rule in add_rules:"},{"line_number":242,"context_line":"            self._allow_access(context, share, rule)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        for rule in delete_rules:"},{"line_number":245,"context_line":"            self._deny_access(context, share, rule)"}],"source_content_type":"text/x-python","patch_set":41,"id":"9aed3d3a_c20f3235","line":242,"in_reply_to":"9aed3d3a_625aa6f3","updated":"2016-03-01 09:36:32.000000000","message":"Ah, OK.  Thanks.","commit_id":"cb04b5cb1f21d9f03f06c162a86bbe268da9d313"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"85fa2678f909e71d64273511ab9d83c414f2e8de","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        # of update_access."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        for rule in add_rules:"},{"line_number":242,"context_line":"            self._allow_access(context, share, rule)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        for rule in delete_rules:"},{"line_number":245,"context_line":"            self._deny_access(context, share, rule)"}],"source_content_type":"text/x-python","patch_set":41,"id":"9aed3d3a_625aa6f3","line":242,"in_reply_to":"9aed3d3a_a2adceea","updated":"2016-03-01 09:20:56.000000000","message":"The documentation is incorrect. John, were you able to see my reply to Valeriy in patchset 39.","commit_id":"cb04b5cb1f21d9f03f06c162a86bbe268da9d313"}],"manila/tests/api/v1/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":"# Copyright 2012 NetApp"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_e94c0472","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":14},"updated":"2016-02-04 17:08:40.000000000","message":"editor artifact? this file isn\u0027t modified though?","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                         mock.Mock(return_value\u003d{\u0027fake\u0027: \u0027fake\u0027}))"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        id \u003d \u0027fake_share_id\u0027"},{"line_number":862,"context_line":"        body \u003d {\u0027os-allow_access\u0027: access}"},{"line_number":863,"context_line":"        expected \u003d {\u0027access\u0027: {\u0027fake\u0027: \u0027fake\u0027}}"},{"line_number":864,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":865,"context_line":"            \u0027/v2/tenant1/shares/%s/action\u0027 % id,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_2df6aed7","line":862,"range":{"start_line":862,"start_character":17,"end_line":862,"end_character":32},"updated":"2016-02-11 10:56:55.000000000","message":"v2 API with microversion 2.11 cannot have \"os-allow_access\" action and should fail on it. And, actually, unit tests fail on it indeed.","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                         mock.Mock(return_value\u003d{\u0027fake\u0027: \u0027fake\u0027}))"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        id \u003d \u0027fake_share_id\u0027"},{"line_number":862,"context_line":"        body \u003d {\u0027os-allow_access\u0027: access}"},{"line_number":863,"context_line":"        expected \u003d {\u0027access\u0027: {\u0027fake\u0027: \u0027fake\u0027}}"},{"line_number":864,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":865,"context_line":"            \u0027/v2/tenant1/shares/%s/action\u0027 % id,"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_be812792","line":862,"range":{"start_line":862,"start_character":17,"end_line":862,"end_character":32},"in_reply_to":"3a57f1b5_2df6aed7","updated":"2016-02-15 08:16:08.000000000","message":"Done","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"8ae12fd5d6b2a1dabbd3119cbeb19419f9c6da5a","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        common.remove_invalid_options(ctx, search_opts, allowed_opts)"},{"line_number":965,"context_line":"        self.assertEqual(expected_opts, search_opts)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    @ddt.data("},{"line_number":968,"context_line":"        {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u0027127.0.0.1\u0027},"},{"line_number":969,"context_line":"        {\u0027access_type\u0027: \u0027user\u0027, \u0027access_to\u0027: \u00271\u0027 * 4},"},{"line_number":970,"context_line":"        {\u0027access_type\u0027: \u0027user\u0027, \u0027access_to\u0027: \u00271\u0027 * 32},"}],"source_content_type":"text/x-python","patch_set":27,"id":"dae33548_befbf046","line":967,"updated":"2016-02-19 06:45:17.000000000","message":"The following two tests do not seem relevant to this patch, and can be removed. And, similar tests are at line 1054 and 1080 although incorrectly they make use of v1 API requests, and tests for \"_allow_access\" method that is not over-ridden by api v2\u0027s ShareController.","commit_id":"08ca6dae2a08ae21cb1891ec499e5b278968de45"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"0d032947e30e4aebe816513e9ca8b7cabcce7851","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        common.remove_invalid_options(ctx, search_opts, allowed_opts)"},{"line_number":965,"context_line":"        self.assertEqual(expected_opts, search_opts)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    @ddt.data("},{"line_number":968,"context_line":"        {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u0027127.0.0.1\u0027},"},{"line_number":969,"context_line":"        {\u0027access_type\u0027: \u0027user\u0027, \u0027access_to\u0027: \u00271\u0027 * 4},"},{"line_number":970,"context_line":"        {\u0027access_type\u0027: \u0027user\u0027, \u0027access_to\u0027: \u00271\u0027 * 32},"}],"source_content_type":"text/x-python","patch_set":27,"id":"bae84128_160e4134","line":967,"in_reply_to":"dae33548_befbf046","updated":"2016-02-19 12:30:57.000000000","message":"Done","commit_id":"08ca6dae2a08ae21cb1891ec499e5b278968de45"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"e9f42c576e8efd56016a1923a760fae1e74e9d06","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        common.remove_invalid_options(ctx, search_opts, allowed_opts)"},{"line_number":965,"context_line":"        self.assertEqual(expected_opts, search_opts)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"    @ddt.data("},{"line_number":968,"context_line":"        {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u0027127.0.0.1\u0027},"},{"line_number":969,"context_line":"        {\u0027access_type\u0027: \u0027user\u0027, \u0027access_to\u0027: \u00271\u0027 * 4},"},{"line_number":970,"context_line":"        {\u0027access_type\u0027: \u0027user\u0027, \u0027access_to\u0027: \u00271\u0027 * 32},"}],"source_content_type":"text/x-python","patch_set":27,"id":"dae33548_7924e2c5","line":967,"in_reply_to":"dae33548_befbf046","updated":"2016-02-19 07:02:21.000000000","message":"s/tests/test/\ns/by/in/","commit_id":"08ca6dae2a08ae21cb1891ec499e5b278968de45"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"            self.assertRaises(exc, self.controller.allow_access, req, share_id,"},{"line_number":1073,"context_line":"                              body)"},{"line_number":1074,"context_line":"        else:"},{"line_number":1075,"context_line":"            self.controller.allow_access(req, id, body)"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def test_deny_access(self):"},{"line_number":1078,"context_line":"        def _stub_deny_access(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_eeb93830","line":1075,"range":{"start_line":1075,"start_character":12,"end_line":1075,"end_character":55},"updated":"2016-02-26 02:37:55.000000000","message":"Please check the response?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"            self.assertRaises(exc, self.controller.allow_access, req, share_id,"},{"line_number":1073,"context_line":"                              body)"},{"line_number":1074,"context_line":"        else:"},{"line_number":1075,"context_line":"            self.controller.allow_access(req, id, body)"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def test_deny_access(self):"},{"line_number":1078,"context_line":"        def _stub_deny_access(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_e10f74df","line":1075,"range":{"start_line":1075,"start_character":12,"end_line":1075,"end_character":55},"in_reply_to":"9aed3d3a_eeb93830","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila/tests/db/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def __getattr__(self, name):"},{"line_number":28,"context_line":"        return self.values.get(name)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":31,"context_line":"        return self.values.get(key, default)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __getitem__(self, key):"},{"line_number":34,"context_line":"        if key in self.values:"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_6e41a80b","line":31,"range":{"start_line":30,"start_character":4,"end_line":31,"end_character":44},"updated":"2016-02-26 02:37:55.000000000","message":"There\u0027s hardly any difference between this and the previous method .. please revert this change.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def __getattr__(self, name):"},{"line_number":28,"context_line":"        return self.values.get(name)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":31,"context_line":"        return self.values.get(key, default)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __getitem__(self, key):"},{"line_number":34,"context_line":"        if key in self.values:"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_811788a2","line":31,"range":{"start_line":30,"start_character":4,"end_line":31,"end_character":44},"in_reply_to":"9aed3d3a_6e41a80b","updated":"2016-02-26 12:33:18.000000000","message":"This came out of a merge (someone else added get() at the same time as it was originally added for ceph driver).\n\nRemoved it now.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila/tests/fake_share.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6af42a23e3be0f430dd2c298a272c279ebfc305e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027project_id\u0027: \u0027fake_project_uuid\u0027,"},{"line_number":31,"context_line":"        \u0027availability_zone\u0027: \u0027fake_az\u0027,"},{"line_number":32,"context_line":"        \u0027snapshot_support\u0027: \u0027True\u0027,"},{"line_number":33,"context_line":"        \u0027consistency_group_id\u0027: \u0027fakecgid\u0027"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    share.update(kwargs)"},{"line_number":36,"context_line":"    return db_fakes.FakeModel(share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_32c93779","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":42},"updated":"2016-01-28 19:02:59.000000000","message":"Missing comma at the end of the line","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027project_id\u0027: \u0027fake_project_uuid\u0027,"},{"line_number":31,"context_line":"        \u0027availability_zone\u0027: \u0027fake_az\u0027,"},{"line_number":32,"context_line":"        \u0027snapshot_support\u0027: \u0027True\u0027,"},{"line_number":33,"context_line":"        \u0027consistency_group_id\u0027: \u0027fakecgid\u0027"},{"line_number":34,"context_line":"    }"},{"line_number":35,"context_line":"    share.update(kwargs)"},{"line_number":36,"context_line":"    return db_fakes.FakeModel(share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_eaefb41b","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":42},"in_reply_to":"7a5de9d1_32c93779","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027share_proto\u0027: \u0027fake_proto\u0027,"},{"line_number":28,"context_line":"        \u0027share_network_id\u0027: \u0027fake share network id\u0027,"},{"line_number":29,"context_line":"        \u0027share_server_id\u0027: \u0027fake share server id\u0027,"},{"line_number":30,"context_line":"        \u0027share_type_id\u0027: \u0027fake share type id\u0027,"},{"line_number":31,"context_line":"        \u0027export_location\u0027: \u0027fake_location:/fake_share\u0027,"},{"line_number":32,"context_line":"        \u0027project_id\u0027: \u0027fake_project_uuid\u0027,"},{"line_number":33,"context_line":"        \u0027availability_zone\u0027: \u0027fake_az\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_0e63bcb2","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":44},"updated":"2016-02-26 02:37:55.000000000","message":"nit: will not contain spaces.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027share_proto\u0027: \u0027fake_proto\u0027,"},{"line_number":28,"context_line":"        \u0027share_network_id\u0027: \u0027fake share network id\u0027,"},{"line_number":29,"context_line":"        \u0027share_server_id\u0027: \u0027fake share server id\u0027,"},{"line_number":30,"context_line":"        \u0027share_type_id\u0027: \u0027fake share type id\u0027,"},{"line_number":31,"context_line":"        \u0027export_location\u0027: \u0027fake_location:/fake_share\u0027,"},{"line_number":32,"context_line":"        \u0027project_id\u0027: \u0027fake_project_uuid\u0027,"},{"line_number":33,"context_line":"        \u0027availability_zone\u0027: \u0027fake_az\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_2155dc4f","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":44},"in_reply_to":"9aed3d3a_0e63bcb2","updated":"2016-02-26 12:33:18.000000000","message":"I\u0027m afraid I don\u0027t know what \"will not contain spaces\" means in this context.\n\nIf you\u0027re suggesting the fake value here should not contain spaces, can you explain how it is idfferent to the network ID and server ID in that respect?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila/tests/share/drivers/cephfs/test_cephfs_native.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from manila.tests import fake_share"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def fake_share_instance(base_share\u003dNone, **kwargs):"},{"line_number":34,"context_line":"    if base_share is None:"},{"line_number":35,"context_line":"        share \u003d fake_share.fake_share()"},{"line_number":36,"context_line":"    else:"},{"line_number":37,"context_line":"        share \u003d base_share"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    share_instance \u003d {"},{"line_number":40,"context_line":"        \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":41,"context_line":"        \u0027id\u0027: \"fakeinstanceid\","},{"line_number":42,"context_line":"        \u0027status\u0027: \"active\","},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    for attr in models.ShareInstance._proxified_properties:"},{"line_number":46,"context_line":"        share_instance[attr] \u003d getattr(share, attr, None)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    return db_fakes.FakeModel(share_instance)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class MockVolumeClientModule(object):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_0e0a9cd2","line":48,"range":{"start_line":33,"start_character":0,"end_line":48,"end_character":45},"updated":"2016-02-26 02:37:55.000000000","message":"Please move this to manila/tests/fake_share.py","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from manila.tests import fake_share"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def fake_share_instance(base_share\u003dNone, **kwargs):"},{"line_number":34,"context_line":"    if base_share is None:"},{"line_number":35,"context_line":"        share \u003d fake_share.fake_share()"},{"line_number":36,"context_line":"    else:"},{"line_number":37,"context_line":"        share \u003d base_share"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    share_instance \u003d {"},{"line_number":40,"context_line":"        \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":41,"context_line":"        \u0027id\u0027: \"fakeinstanceid\","},{"line_number":42,"context_line":"        \u0027status\u0027: \"active\","},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    for attr in models.ShareInstance._proxified_properties:"},{"line_number":46,"context_line":"        share_instance[attr] \u003d getattr(share, attr, None)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    return db_fakes.FakeModel(share_instance)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class MockVolumeClientModule(object):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_01aed82d","line":48,"range":{"start_line":33,"start_character":0,"end_line":48,"end_character":45},"in_reply_to":"9aed3d3a_0e0a9cd2","updated":"2016-02-26 12:33:18.000000000","message":"Since the driver has now been changed as requested to pretend that it is being passed Shares and not ShareInstances, this class is no longer needed.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def setUp(self):"},{"line_number":104,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"},{"line_number":105,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":106,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":107,"context_line":"        self._share_instance \u003d fake_share_instance(fake_share.fake_share("},{"line_number":108,"context_line":"            share_proto\u003d\u0027CEPHFS\u0027))"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_ce00b4ad","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":51},"updated":"2016-02-26 02:37:55.000000000","message":"nit: you might have user context as well","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    def setUp(self):"},{"line_number":104,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"},{"line_number":105,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":106,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":107,"context_line":"        self._share_instance \u003d fake_share_instance(fake_share.fake_share("},{"line_number":108,"context_line":"            share_proto\u003d\u0027CEPHFS\u0027))"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_a163ac19","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":51},"in_reply_to":"9aed3d3a_ce00b4ad","updated":"2016-02-26 12:33:18.000000000","message":"I don\u0027t know what you are asking me to do here.  get_admin_context appears to be used pretty much throughout the other preexisting tests.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"},{"line_number":105,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":106,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":107,"context_line":"        self._share_instance \u003d fake_share_instance(fake_share.fake_share("},{"line_number":108,"context_line":"            share_proto\u003d\u0027CEPHFS\u0027))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.fake_conf.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_4e2b0431","line":108,"range":{"start_line":107,"start_character":8,"end_line":108,"end_character":34},"updated":"2016-02-26 02:37:55.000000000","message":"should really be \u0027fake_share\u0027","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"},{"line_number":105,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":106,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":107,"context_line":"        self._share_instance \u003d fake_share_instance(fake_share.fake_share("},{"line_number":108,"context_line":"            share_proto\u003d\u0027CEPHFS\u0027))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        self.fake_conf.set_default(\u0027driver_handles_share_servers\u0027, False)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_bc72afe3","line":108,"range":{"start_line":107,"start_character":8,"end_line":108,"end_character":34},"in_reply_to":"9aed3d3a_4e2b0431","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            data_isolated\u003dTrue)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_allow_access(self):"},{"line_number":178,"context_line":"        self._driver._allow_access(self._context, self._share_instance, {"},{"line_number":179,"context_line":"            \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":180,"context_line":"            \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":181,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027"},{"line_number":182,"context_line":"        })"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self._driver._volume_client.authorize.assert_called_once_with("},{"line_number":185,"context_line":"            self._driver._share_path(self._share_instance),"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_299b1acb","line":182,"range":{"start_line":178,"start_character":72,"end_line":182,"end_character":9},"updated":"2016-02-26 02:50:49.000000000","message":"The OpenStack style guidelines would have you separate compound function arguments such as these.\n\nhttp://docs.openstack.org/developer/hacking/#calling-methods","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            data_isolated\u003dTrue)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_allow_access(self):"},{"line_number":178,"context_line":"        self._driver._allow_access(self._context, self._share_instance, {"},{"line_number":179,"context_line":"            \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":180,"context_line":"            \u0027access_type\u0027: \u0027cephx\u0027,"},{"line_number":181,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027"},{"line_number":182,"context_line":"        })"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self._driver._volume_client.authorize.assert_called_once_with("},{"line_number":185,"context_line":"            self._driver._share_path(self._share_instance),"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_a79bbcc8","line":182,"range":{"start_line":178,"start_character":72,"end_line":182,"end_character":9},"in_reply_to":"9aed3d3a_299b1acb","updated":"2016-02-26 12:33:18.000000000","message":"Sure, why not.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                          self._driver._allow_access,"},{"line_number":191,"context_line":"                          self._context, self._share_instance, {"},{"line_number":192,"context_line":"                              \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":193,"context_line":"                              \u0027access_type\u0027: \u0027RHUBARB\u0027,"},{"line_number":194,"context_line":"                              \u0027access_to\u0027: \u0027alice\u0027"},{"line_number":195,"context_line":"                          })"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_eec81877","line":193,"range":{"start_line":193,"start_character":46,"end_line":193,"end_character":53},"updated":"2016-02-26 02:37:55.000000000","message":"of course you don\u0027t give anyone rhubarb access ;)","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"15c3e3d99f1d1a30bb0848a9f9455d816f22ae80","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                          self._driver._allow_access,"},{"line_number":191,"context_line":"                          self._context, self._share_instance, {"},{"line_number":192,"context_line":"                              \u0027access_level\u0027: constants.ACCESS_LEVEL_RW,"},{"line_number":193,"context_line":"                              \u0027access_type\u0027: \u0027RHUBARB\u0027,"},{"line_number":194,"context_line":"                              \u0027access_to\u0027: \u0027alice\u0027"},{"line_number":195,"context_line":"                          })"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_09045613","line":193,"range":{"start_line":193,"start_character":46,"end_line":193,"end_character":53},"in_reply_to":"9aed3d3a_eec81877","updated":"2016-02-26 02:50:49.000000000","message":"Of course you do!  Ever had a good strawberry rhubarb pie?","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        del self._driver"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def test_connect_noevict(self):"},{"line_number":362,"context_line":"        # When acting as \"admin\", driver should skip evicting"},{"line_number":363,"context_line":"        self._driver.configuration.local_conf.set_override(\u0027cephfs_auth_id\u0027,"},{"line_number":364,"context_line":"                                                           \"admin\")"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_2eb680dc","line":362,"range":{"start_line":362,"start_character":8,"end_line":362,"end_character":61},"updated":"2016-02-26 02:37:55.000000000","message":"Could you please add this comment in the driver module? was confused about the selective \"eviction\", but this makes sense!","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        del self._driver"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def test_connect_noevict(self):"},{"line_number":362,"context_line":"        # When acting as \"admin\", driver should skip evicting"},{"line_number":363,"context_line":"        self._driver.configuration.local_conf.set_override(\u0027cephfs_auth_id\u0027,"},{"line_number":364,"context_line":"                                                           \"admin\")"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_67ba5425","line":362,"range":{"start_line":362,"start_character":8,"end_line":362,"end_character":61},"in_reply_to":"9aed3d3a_2eb680dc","updated":"2016-02-26 12:33:18.000000000","message":"There is already a comment in the driver:\n            # Evict any other manila sessions.  Only do this if we\u0027re\n            # using a client ID that isn\u0027t the default admin ID, to avoid\n            # rudely disrupting anyone else.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33a60d17268125f51d19862b8320e727397cca66","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manila.common import constants"},{"line_number":22,"context_line":"from manila import context"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import manila.exception as exception"},{"line_number":25,"context_line":"from manila.share import configuration"},{"line_number":26,"context_line":"from manila.share.drivers.cephfs import cephfs_native"}],"source_content_type":"text/x-python","patch_set":37,"id":"9aed3d3a_9cd4dd20","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":0},"updated":"2016-02-27 03:24:28.000000000","message":"Please remove this line","commit_id":"256a86e1dad1abc88d3ca47b542a5d5b2363abc1"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"26f251fca0828759ca074353e2883f40ad29725b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manila.common import constants"},{"line_number":22,"context_line":"from manila import context"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import manila.exception as exception"},{"line_number":25,"context_line":"from manila.share import configuration"},{"line_number":26,"context_line":"from manila.share.drivers.cephfs import cephfs_native"}],"source_content_type":"text/x-python","patch_set":37,"id":"9aed3d3a_f867d0b4","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":0},"in_reply_to":"9aed3d3a_9cd4dd20","updated":"2016-02-29 07:16:59.000000000","message":"Done","commit_id":"256a86e1dad1abc88d3ca47b542a5d5b2363abc1"}],"manila/tests/share/drivers/test_cephfs.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_create_consistency_group(self):"},{"line_number":308,"context_line":"        self._driver.create_consistency_group(self._context,"},{"line_number":309,"context_line":"                                              {"},{"line_number":310,"context_line":"                                                  \"id\": \"grp1\""},{"line_number":311,"context_line":"                                              },"},{"line_number":312,"context_line":"                                              None)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self._driver._volume_client.create_group.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_cd6d4a34","line":311,"range":{"start_line":309,"start_character":46,"end_line":311,"end_character":47},"updated":"2016-02-19 23:37:37.000000000","message":"No need to wrap here.  Same below.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def test_create_consistency_group(self):"},{"line_number":308,"context_line":"        self._driver.create_consistency_group(self._context,"},{"line_number":309,"context_line":"                                              {"},{"line_number":310,"context_line":"                                                  \"id\": \"grp1\""},{"line_number":311,"context_line":"                                              },"},{"line_number":312,"context_line":"                                              None)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self._driver._volume_client.create_group.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_fe8d9d31","line":311,"range":{"start_line":309,"start_character":46,"end_line":311,"end_character":47},"in_reply_to":"bae84128_cd6d4a34","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"}],"manila/tests/share/drivers/test_cephfs_native.py":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class VolumePath(object):"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    Copy of VolumePath from VolumeClient (it\u0027s so simple that I can live with the copy-paste)"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    def __init__(self, group_id, volume_id):"},{"line_number":43,"context_line":"        self.group_id \u003d group_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_02089b27","line":40,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class VolumePath(object):"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    Copy of VolumePath from VolumeClient (it\u0027s so simple that I can live with the copy-paste)"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    def __init__(self, group_id, volume_id):"},{"line_number":43,"context_line":"        self.group_id \u003d group_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_cabf585f","line":40,"in_reply_to":"9a68dd71_02089b27","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.volume_id \u003d volume_id"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __eq__(self, other):"},{"line_number":47,"context_line":"        return self.group_id \u003d\u003d other.group_id and self.volume_id \u003d\u003d other.volume_id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __str__(self):"},{"line_number":50,"context_line":"        return \"{0}/{1}\".format(self.group_id, self.volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_e20f872c","line":47,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.volume_id \u003d volume_id"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def __eq__(self, other):"},{"line_number":47,"context_line":"        return self.group_id \u003d\u003d other.group_id and self.volume_id \u003d\u003d other.volume_id"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __str__(self):"},{"line_number":50,"context_line":"        return \"{0}/{1}\".format(self.group_id, self.volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_aab8dc75","line":47,"in_reply_to":"9a68dd71_e20f872c","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f9fe606509515036aad744687c4ad81578152830","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                       {\"auth_key\": \"abc123\"}"},{"line_number":70,"context_line":"                                       )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class CephFSNativeDriverTestCase(test.TestCase):"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    Test the CephFS native driver.  This is a very simple driver that mainly"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9272827b","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":0},"updated":"2016-01-27 08:19:48.000000000","message":"Please add the test about create snapshot, delete snapshot, create_consistency_group.. and so on.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class CephFSNativeDriverTestCase(test.TestCase):"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    Test the CephFS native driver.  This is a very simple driver that mainly"},{"line_number":76,"context_line":"    calls through to "},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    def setUp(self):"},{"line_number":79,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_424c5376","line":76,"updated":"2016-01-26 19:21:41.000000000","message":"Looks like the docstring got cut off.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class CephFSNativeDriverTestCase(test.TestCase):"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    Test the CephFS native driver.  This is a very simple driver that mainly"},{"line_number":76,"context_line":"    calls through to "},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    def setUp(self):"},{"line_number":79,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_f2056a45","line":76,"in_reply_to":"7a5de9d1_25ab618b","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"2c6465bc943177c6fc5f6c257dd01c65bf5ea093","unresolved":false,"context_lines":[{"line_number":73,"context_line":"class CephFSNativeDriverTestCase(test.TestCase):"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    Test the CephFS native driver.  This is a very simple driver that mainly"},{"line_number":76,"context_line":"    calls through to "},{"line_number":77,"context_line":"    \"\"\""},{"line_number":78,"context_line":"    def setUp(self):"},{"line_number":79,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_25ab618b","line":76,"in_reply_to":"9a68dd71_424c5376","updated":"2016-01-28 01:10:21.000000000","message":"There is a guideline for docstrings:\nhttp://docs.openstack.org/developer/hacking/#internationalization-i18n-strings","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"},{"line_number":80,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":81,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":82,"context_line":"        self._share_instance \u003d fake_share_instance(fake_share.fake_share(share_proto\u003d\u0027CEPHFS\u0027))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # As soon as the driver tries to initialize volume_client, it\u0027ll"},{"line_number":85,"context_line":"        # see our fake instead"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_824a4b54","line":82,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        super(CephFSNativeDriverTestCase, self).setUp()"},{"line_number":80,"context_line":"        self.fake_conf \u003d configuration.Configuration(None)"},{"line_number":81,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":82,"context_line":"        self._share_instance \u003d fake_share_instance(fake_share.fake_share(share_proto\u003d\u0027CEPHFS\u0027))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # As soon as the driver tries to initialize volume_client, it\u0027ll"},{"line_number":85,"context_line":"        # see our fake instead"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_72f17a6a","line":82,"in_reply_to":"9a68dd71_824a4b54","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"e602ee0a4039d6c1095fc1b5270e0eaa310d2cb9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                         mock.Mock(return_value\u003d{}))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_share(self):"},{"line_number":94,"context_line":"        export_location \u003d self._driver.create_share(self._context, self._share_instance)"},{"line_number":95,"context_line":"        self.assertEqual(export_location, \"1.2.3.4,5.6.7.8:/foo/bar\")"},{"line_number":96,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":97,"context_line":"            self._driver._share_path(self._share_instance),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_62787790","line":94,"updated":"2016-01-26 19:21:41.000000000","message":"Line is over 79 characters long.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                         mock.Mock(return_value\u003d{}))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_share(self):"},{"line_number":94,"context_line":"        export_location \u003d self._driver.create_share(self._context, self._share_instance)"},{"line_number":95,"context_line":"        self.assertEqual(export_location, \"1.2.3.4,5.6.7.8:/foo/bar\")"},{"line_number":96,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":97,"context_line":"            self._driver._share_path(self._share_instance),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_4c7e256b","line":94,"in_reply_to":"9a68dd71_62787790","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6af42a23e3be0f430dd2c298a272c279ebfc305e","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_share(self):"},{"line_number":94,"context_line":"        export_location \u003d self._driver.create_share(self._context, self._share_instance)"},{"line_number":95,"context_line":"        self.assertEqual(export_location, \"1.2.3.4,5.6.7.8:/foo/bar\")"},{"line_number":96,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":97,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":98,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * 1024 * 1024 * 1024,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_3204d7be","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":69},"updated":"2016-01-28 19:02:59.000000000","message":"Please fix params order: assertEqual(expected, actual_result)","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def test_create_share(self):"},{"line_number":94,"context_line":"        export_location \u003d self._driver.create_share(self._context, self._share_instance)"},{"line_number":95,"context_line":"        self.assertEqual(export_location, \"1.2.3.4,5.6.7.8:/foo/bar\")"},{"line_number":96,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":97,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":98,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * 1024 * 1024 * 1024,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_12da86e8","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":69},"in_reply_to":"7a5de9d1_3204d7be","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6af42a23e3be0f430dd2c298a272c279ebfc305e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertEqual(export_location, \"1.2.3.4,5.6.7.8:/foo/bar\")"},{"line_number":96,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":97,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":98,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * 1024 * 1024 * 1024,"},{"line_number":99,"context_line":"            data_isolated\u003dFalse)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_allow_access(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_1262fbad","line":98,"range":{"start_line":98,"start_character":48,"end_line":98,"end_character":66},"updated":"2016-01-28 19:02:59.000000000","message":"You can use units.Gi instead.","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertEqual(export_location, \"1.2.3.4,5.6.7.8:/foo/bar\")"},{"line_number":96,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":97,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":98,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * 1024 * 1024 * 1024,"},{"line_number":99,"context_line":"            data_isolated\u003dFalse)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_allow_access(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_ec9911c5","line":98,"range":{"start_line":98,"start_character":48,"end_line":98,"end_character":66},"in_reply_to":"7a5de9d1_1262fbad","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"6af42a23e3be0f430dd2c298a272c279ebfc305e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self._driver.create_share(self._context, self._share_instance)"},{"line_number":117,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":118,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":119,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * 1024 * 1024 * 1024,"},{"line_number":120,"context_line":"            data_isolated\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d25b03f5","line":119,"range":{"start_line":119,"start_character":48,"end_line":119,"end_character":66},"updated":"2016-01-28 19:02:59.000000000","message":"Same","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"97b5b41d1bd8f63a5113ba151fb7fac15a144db3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self._driver.create_share(self._context, self._share_instance)"},{"line_number":117,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":118,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":119,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * 1024 * 1024 * 1024,"},{"line_number":120,"context_line":"            data_isolated\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_0c958d85","line":119,"range":{"start_line":119,"start_character":48,"end_line":119,"end_character":66},"in_reply_to":"7a5de9d1_d25b03f5","updated":"2016-02-02 00:23:45.000000000","message":"Done","commit_id":"77f741b95baf1a91004adfaf33c1fd478ef2140e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                         mock.Mock(return_value\u003d{}))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_create_share(self):"},{"line_number":117,"context_line":"        export_location \u003d self._driver.create_share(self._context,"},{"line_number":118,"context_line":"                                                    self._share_instance)"},{"line_number":119,"context_line":"        self.assertEqual(\"1.2.3.4,5.6.7.8:/foo/bar\", export_location)"},{"line_number":120,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":121,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":122,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * units.Gi,"},{"line_number":123,"context_line":"            data_isolated\u003dFalse)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_ensure_share(self):"},{"line_number":126,"context_line":"        self._driver.ensure_share(self._context,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_e9f2c4d1","line":123,"range":{"start_line":117,"start_character":8,"end_line":123,"end_character":32},"updated":"2016-02-04 17:08:40.000000000","message":"a small nit/note about unit test consistency, all unit tests have:\n\n    def test_some_module_some_test_case(self):\n        some_setup_for_the_test\n           \n        method_call(some_params)\n \n        assert_output_\n        assert_some_call_\n        etc.\n\n\nor:\n\n    def test_some_module_some_test_case(self):\n        some_setup_for_the_test\n \n        assertRaises(some_exception, method_call, some_params)\n        assert_some_call_was_made_\n        etc.\n\n\n\n(the spacing makes it easier to read the test)","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"03feb70f7e39b4917c3cae6c1c4e624b4fc576ad","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                         mock.Mock(return_value\u003d{}))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_create_share(self):"},{"line_number":117,"context_line":"        export_location \u003d self._driver.create_share(self._context,"},{"line_number":118,"context_line":"                                                    self._share_instance)"},{"line_number":119,"context_line":"        self.assertEqual(\"1.2.3.4,5.6.7.8:/foo/bar\", export_location)"},{"line_number":120,"context_line":"        self._driver._volume_client.create_volume.assert_called_once_with("},{"line_number":121,"context_line":"            self._driver._share_path(self._share_instance),"},{"line_number":122,"context_line":"            size\u003dself._share_instance[\u0027size\u0027] * units.Gi,"},{"line_number":123,"context_line":"            data_isolated\u003dFalse)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_ensure_share(self):"},{"line_number":126,"context_line":"        self._driver.ensure_share(self._context,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_a7077917","line":123,"range":{"start_line":117,"start_character":8,"end_line":123,"end_character":32},"in_reply_to":"5a5ae5dd_e9f2c4d1","updated":"2016-02-09 02:11:43.000000000","message":"Done","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3edc497b821839c7cf2faeb3f591ad1e978c7dcc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               help\u003d\"The minimum api microversion is configured to be the \""},{"line_number":37,"context_line":"                    \"value of the minimum microversion supported by Manila.\"),"},{"line_number":38,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":39,"context_line":"               default\u003d\"2.10\","},{"line_number":40,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":41,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_0973a04e","line":39,"range":{"start_line":39,"start_character":24,"end_line":39,"end_character":28},"updated":"2016-02-04 17:08:40.000000000","message":"should the max_api_microversion be bumped here?","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"03feb70f7e39b4917c3cae6c1c4e624b4fc576ad","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               help\u003d\"The minimum api microversion is configured to be the \""},{"line_number":37,"context_line":"                    \"value of the minimum microversion supported by Manila.\"),"},{"line_number":38,"context_line":"    cfg.StrOpt(\"max_api_microversion\","},{"line_number":39,"context_line":"               default\u003d\"2.10\","},{"line_number":40,"context_line":"               help\u003d\"The maximum api microversion is configured to be the \""},{"line_number":41,"context_line":"                    \"value of the latest microversion supported by Manila.\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\"region\","}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_bf7ddee8","line":39,"range":{"start_line":39,"start_character":24,"end_line":39,"end_character":28},"in_reply_to":"5a5ae5dd_0973a04e","updated":"2016-02-09 02:11:43.000000000","message":"Done","commit_id":"0916eb9fecb5115f2bb0ac7a1dd7d71e81243d51"}],"manila_tempest_tests/tests/api/admin/test_share_manage.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"350b90e203b6a4b009e9bfae02f61b78780375f0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    protocol \u003d \u0027hdfs\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class ManageCEPHFSShareTest(ManageNFSShareTest):"},{"line_number":202,"context_line":"    protocol \u003d \u0027cephfs\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_f29c696b","line":201,"range":{"start_line":201,"start_character":6,"end_line":201,"end_character":27},"updated":"2016-02-19 23:37:37.000000000","message":"Not a big deal, but it isn\u0027t required that CEPH is all caps here.  I\u0027m not sure why gluster is, either.  They probably just copied the others, which are all acronyms.","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"2fc9b6b5f8057dbecad8efebde62299bf31381a3","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    protocol \u003d \u0027hdfs\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class ManageCEPHFSShareTest(ManageNFSShareTest):"},{"line_number":202,"context_line":"    protocol \u003d \u0027cephfs\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"bae84128_de57f923","line":201,"range":{"start_line":201,"start_character":6,"end_line":201,"end_character":27},"in_reply_to":"bae84128_f29c696b","updated":"2016-02-24 13:15:29.000000000","message":"Done","commit_id":"0717d624684f9720f4dac2456f211fa4d4a6c334"}],"manila_tempest_tests/tests/api/test_rules.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"38e80ac0844678459f7d8ad6c3f32d783f7ed9ea","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":298,"context_line":"                    for p in cls.protocols) or"},{"line_number":299,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":300,"context_line":"                    for p in cls.protocols)):"},{"line_number":301,"context_line":"            cls.message \u003d \"Rule tests are disabled\""},{"line_number":302,"context_line":"            raise cls.skipException(cls.message)"},{"line_number":303,"context_line":"        if CONF.share.enable_ip_rules_for_protocols:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_d0d7b8eb","line":300,"updated":"2016-02-02 18:40:18.000000000","message":"This test suite makes use of v1 APIs. CephX available with only v2 API. Will fix this in the next patch set.","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"1bf89d8ed511724bf71526b75d860b5aa3c83a08","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        # Provide access to a client identified by a cephx auth id."},{"line_number":255,"context_line":"        cls.access_to \u003d \"bob\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":258,"context_line":"    def test_create_delete_cephx_rule(self):"},{"line_number":259,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":260,"context_line":"            self.share[\"id\"], self.access_type, self.access_to)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_a3d51244","line":257,"updated":"2016-02-03 15:17:24.000000000","message":"Maybe add more types of valid access id as done here, line #759 of\nhttps://review.openstack.org/#/c/270211/12/manila/tests/api/v1/test_shares.py","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e71b4dd648221afee2ea43294a33defdfcfd162","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":288,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":291,"context_line":"    def test_list_access_rules(self):"},{"line_number":292,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":293,"context_line":"            self.share[\"id\"], self.access_type, self.access_to)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        self.shares_v2_client.wait_for_access_rule_status("},{"line_number":296,"context_line":"            self.share[\"id\"], rule[\"id\"], \"active\")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        rules \u003d self.shares_v2_client.list_access_rules(self.share[\"id\"])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        for key in (\"state\", \"id\", \"access_type\", \"access_to\", \"access_level\"):"},{"line_number":301,"context_line":"            [self.assertIn(key, r.keys()) for r in rules]"},{"line_number":302,"context_line":"        for key in (\u0027deleted\u0027, \u0027deleted_at\u0027, \u0027instance_mappings\u0027):"},{"line_number":303,"context_line":"            [self.assertNotIn(key, r.keys()) for r in rules]"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        self.assertEqual(\"active\", rules[0][\"state\"])"},{"line_number":306,"context_line":"        self.assertEqual(self.access_type, rules[0][\"access_type\"])"},{"line_number":307,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":308,"context_line":"        self.assertEqual(\u0027rw\u0027, rules[0][\"access_level\"])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        gen \u003d [r[\"id\"] for r in rules if r[\"id\"] in rule[\"id\"]]"},{"line_number":311,"context_line":"        msg \u003d \"expected id lists %s times in rule list\" % (len(gen))"},{"line_number":312,"context_line":"        self.assertEqual(len(gen), 1, msg)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self.shares_v2_client.delete_access_rule("},{"line_number":315,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":318,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":321,"context_line":"    def test_access_rule_cephx_deleted_if_share_deleted(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_1238f6d2","line":318,"range":{"start_line":290,"start_character":4,"end_line":318,"end_character":58},"updated":"2016-02-03 14:19:33.000000000","message":"This is duplication of test defined in class below.\n\nYou try to workaround incorrectly configured tempest,see comments for bug following: https://bugs.launchpad.net/manila/+bug/1541312","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"feb072e14fe5c8716334747746fb5982633a5583","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":288,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":291,"context_line":"    def test_list_access_rules(self):"},{"line_number":292,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":293,"context_line":"            self.share[\"id\"], self.access_type, self.access_to)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        self.shares_v2_client.wait_for_access_rule_status("},{"line_number":296,"context_line":"            self.share[\"id\"], rule[\"id\"], \"active\")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        rules \u003d self.shares_v2_client.list_access_rules(self.share[\"id\"])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        for key in (\"state\", \"id\", \"access_type\", \"access_to\", \"access_level\"):"},{"line_number":301,"context_line":"            [self.assertIn(key, r.keys()) for r in rules]"},{"line_number":302,"context_line":"        for key in (\u0027deleted\u0027, \u0027deleted_at\u0027, \u0027instance_mappings\u0027):"},{"line_number":303,"context_line":"            [self.assertNotIn(key, r.keys()) for r in rules]"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        self.assertEqual(\"active\", rules[0][\"state\"])"},{"line_number":306,"context_line":"        self.assertEqual(self.access_type, rules[0][\"access_type\"])"},{"line_number":307,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":308,"context_line":"        self.assertEqual(\u0027rw\u0027, rules[0][\"access_level\"])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        gen \u003d [r[\"id\"] for r in rules if r[\"id\"] in rule[\"id\"]]"},{"line_number":311,"context_line":"        msg \u003d \"expected id lists %s times in rule list\" % (len(gen))"},{"line_number":312,"context_line":"        self.assertEqual(len(gen), 1, msg)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self.shares_v2_client.delete_access_rule("},{"line_number":315,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":318,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":321,"context_line":"    def test_access_rule_cephx_deleted_if_share_deleted(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_5d72ffe6","line":318,"range":{"start_line":290,"start_character":4,"end_line":318,"end_character":58},"in_reply_to":"5a5ae5dd_1238f6d2","updated":"2016-02-03 14:58:22.000000000","message":"This duplication of the test is not the bug fix.\nThe bug fix is here as suggested, https://review.openstack.org/#/c/275678/\n\nThe duplication was done as the common tests, test for both v1 and v2 client. And \u0027cephx\u0027 access type is not a valid access type for v1 client right?","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e8a6d61d7cb32653b72066d67119e4b7e78f53ef","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":288,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":291,"context_line":"    def test_list_access_rules(self):"},{"line_number":292,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("},{"line_number":293,"context_line":"            self.share[\"id\"], self.access_type, self.access_to)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        self.shares_v2_client.wait_for_access_rule_status("},{"line_number":296,"context_line":"            self.share[\"id\"], rule[\"id\"], \"active\")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        rules \u003d self.shares_v2_client.list_access_rules(self.share[\"id\"])"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        for key in (\"state\", \"id\", \"access_type\", \"access_to\", \"access_level\"):"},{"line_number":301,"context_line":"            [self.assertIn(key, r.keys()) for r in rules]"},{"line_number":302,"context_line":"        for key in (\u0027deleted\u0027, \u0027deleted_at\u0027, \u0027instance_mappings\u0027):"},{"line_number":303,"context_line":"            [self.assertNotIn(key, r.keys()) for r in rules]"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        self.assertEqual(\"active\", rules[0][\"state\"])"},{"line_number":306,"context_line":"        self.assertEqual(self.access_type, rules[0][\"access_type\"])"},{"line_number":307,"context_line":"        self.assertEqual(self.access_to, rules[0][\"access_to\"])"},{"line_number":308,"context_line":"        self.assertEqual(\u0027rw\u0027, rules[0][\"access_level\"])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        gen \u003d [r[\"id\"] for r in rules if r[\"id\"] in rule[\"id\"]]"},{"line_number":311,"context_line":"        msg \u003d \"expected id lists %s times in rule list\" % (len(gen))"},{"line_number":312,"context_line":"        self.assertEqual(len(gen), 1, msg)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        self.shares_v2_client.delete_access_rule("},{"line_number":315,"context_line":"            self.share[\u0027id\u0027], rule[\u0027id\u0027])"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":318,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":321,"context_line":"    def test_access_rule_cephx_deleted_if_share_deleted(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_ba13b9b7","line":318,"range":{"start_line":290,"start_character":4,"end_line":318,"end_character":58},"in_reply_to":"5a5ae5dd_5d72ffe6","updated":"2016-02-04 14:31:49.000000000","message":"Right. And making duplication is wrong way to fix that issue. Need just update appropriate tests to be skipped using v1 client and Ceph.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e591596b19e980b245fda4ca33ed239dd31f7b0a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("},{"line_number":318,"context_line":"            rule_id\u003drule[\"id\"], share_id\u003dself.share[\u0027id\u0027])"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @test.attr(type\u003d[\"gate\", ])"},{"line_number":321,"context_line":"    def test_access_rule_cephx_deleted_if_share_deleted(self):"},{"line_number":322,"context_line":"        share \u003d self.create_share(self.protocol)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        rule \u003d self.shares_v2_client.create_access_rule("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_f268babc","line":321,"range":{"start_line":320,"start_character":4,"end_line":321,"end_character":62},"updated":"2016-02-03 14:20:31.000000000","message":"Same here. Duplication.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"feb072e14fe5c8716334747746fb5982633a5583","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                any(p in CONF.share.enable_user_rules_for_protocols"},{"line_number":348,"context_line":"                    for p in cls.protocols) or"},{"line_number":349,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":350,"context_line":"                    for p in cls.protocols) or"},{"line_number":351,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":352,"context_line":"                    for p in cls.protocols)):"},{"line_number":353,"context_line":"            cls.message \u003d \"Rule tests are disabled\""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_5ded1f8a","line":350,"updated":"2016-02-03 14:58:22.000000000","message":"the following two lines need to be removed. lines 350 and 351.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1e71b4dd648221afee2ea43294a33defdfcfd162","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        elif CONF.share.enable_cert_rules_for_protocols:"},{"line_number":364,"context_line":"            cls.protocol \u003d CONF.share.enable_cert_rules_for_protocols[0]"},{"line_number":365,"context_line":"            cls.access_type \u003d \"cert\""},{"line_number":366,"context_line":"            cls.access_to \u003d \"client3.com\""},{"line_number":367,"context_line":"        cls.shares_v2_client.share_protocol \u003d cls.protocol"},{"line_number":368,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_8f4fdd91","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":41},"updated":"2016-02-03 14:19:33.000000000","message":"Lost \"elif\" for your new config option \u0027CONF.share.enable_cephx_rules_for_protocols\u0027\n\nRight now, it will fail for sure.\n\nSame in manila_tempest_tests/tests/api/test_rules_negative.py","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"feb072e14fe5c8716334747746fb5982633a5583","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        elif CONF.share.enable_cert_rules_for_protocols:"},{"line_number":364,"context_line":"            cls.protocol \u003d CONF.share.enable_cert_rules_for_protocols[0]"},{"line_number":365,"context_line":"            cls.access_type \u003d \"cert\""},{"line_number":366,"context_line":"            cls.access_to \u003d \"client3.com\""},{"line_number":367,"context_line":"        cls.shares_v2_client.share_protocol \u003d cls.protocol"},{"line_number":368,"context_line":"        cls.share \u003d cls.create_share()"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_b8e7813f","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":41},"in_reply_to":"5a5ae5dd_8f4fdd91","updated":"2016-02-03 14:58:22.000000000","message":"Intended to not run any cephx related test as part of the common tests (i.e. Remove lines 350 and 351), as it tests v1 and v2 clients.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9c935d2cfa8a976beb94cdb831a9b5ad8f6da4e4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        for key in (\u0027deleted\u0027, \u0027deleted_at\u0027, \u0027instance_mappings\u0027):"},{"line_number":405,"context_line":"            self.assertNotIn(key, rule.keys())"},{"line_number":406,"context_line":"        self.shares_v2_client.wait_for_access_rule_status("},{"line_number":407,"context_line":"            self.share[\"id\"], rule[\"id\"], \"active\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        self.shares_v2_client.delete_access_rule(self.share[\"id\"], rule[\"id\"])"},{"line_number":410,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("}],"source_content_type":"text/x-python","patch_set":18,"id":"5a5ae5dd_03b0a68a","line":407,"range":{"start_line":407,"start_character":42,"end_line":407,"end_character":50},"updated":"2016-02-09 13:21:01.000000000","message":"How can it be \"active\" if your driver does not support RO rules?","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6bee21a0560d659a13f8c0bba0f82e39da6c13de","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        for key in (\u0027deleted\u0027, \u0027deleted_at\u0027, \u0027instance_mappings\u0027):"},{"line_number":405,"context_line":"            self.assertNotIn(key, rule.keys())"},{"line_number":406,"context_line":"        self.shares_v2_client.wait_for_access_rule_status("},{"line_number":407,"context_line":"            self.share[\"id\"], rule[\"id\"], \"active\")"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        self.shares_v2_client.delete_access_rule(self.share[\"id\"], rule[\"id\"])"},{"line_number":410,"context_line":"        self.shares_v2_client.wait_for_resource_deletion("}],"source_content_type":"text/x-python","patch_set":18,"id":"1a54edaf_32a74e51","line":407,"range":{"start_line":407,"start_character":42,"end_line":407,"end_character":50},"in_reply_to":"5a5ae5dd_03b0a68a","updated":"2016-02-13 09:38:16.000000000","message":"Done","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dda86d87eee33629dcf128af80e567a955840800","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if (cls.protocol not in CONF.share.enable_protocols or"},{"line_number":369,"context_line":"                cls.protocol not in"},{"line_number":370,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":371,"context_line":"            msg \u003d (\"Cephx rule tests for %s protocol are disabled\" %"},{"line_number":372,"context_line":"                   cls.protocol)"},{"line_number":373,"context_line":"            raise cls.skipException(msg)"},{"line_number":374,"context_line":"        cls.share \u003d cls.create_share(cls.protocol)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_6ee7e8e4","line":371,"range":{"start_line":371,"start_character":65,"end_line":371,"end_character":66},"updated":"2016-02-26 02:37:55.000000000","message":"Please add a period.","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"bc7b2cdd53aecc8597a566dac22d65991ccb42a4","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        if (cls.protocol not in CONF.share.enable_protocols or"},{"line_number":369,"context_line":"                cls.protocol not in"},{"line_number":370,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":371,"context_line":"            msg \u003d (\"Cephx rule tests for %s protocol are disabled\" %"},{"line_number":372,"context_line":"                   cls.protocol)"},{"line_number":373,"context_line":"            raise cls.skipException(msg)"},{"line_number":374,"context_line":"        cls.share \u003d cls.create_share(cls.protocol)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aed3d3a_478e3079","line":371,"range":{"start_line":371,"start_character":65,"end_line":371,"end_character":66},"in_reply_to":"9aed3d3a_6ee7e8e4","updated":"2016-02-26 12:33:18.000000000","message":"Done","commit_id":"30c6568d6a3a1e5548dbfccccbb196437679a788"}],"manila_tempest_tests/tests/api/test_rules_negative.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"38e80ac0844678459f7d8ad6c3f32d783f7ed9ea","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                    for p in cls.protocols) or"},{"line_number":345,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":346,"context_line":"                    for p in cls.protocols) or"},{"line_number":347,"context_line":"                any(p in CONF.share.enable_cephx_rules_for_protocols"},{"line_number":348,"context_line":"                    for p in cls.protocols)):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"            cls.message \u003d \"Rule tests are disabled\""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_908ce036","line":347,"updated":"2016-02-02 18:40:18.000000000","message":"In this test suite, ip based rules  and v1 client APIs are tested. Shouldn\u0027t do both. Will fix this in the next patch set.","commit_id":"00ba7feb5099488f9b41ab4d2da8a0f41f1eadf6"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"1bf89d8ed511724bf71526b75d860b5aa3c83a08","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":311,"context_line":"    def test_create_access_rule_cephx_with_invalid_cephx_id(self):"},{"line_number":312,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":313,"context_line":"                          self.shares_v2_client.create_access_rule,"},{"line_number":314,"context_line":"                          self.share[\"id\"], self.access_type, \"jane.doe\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_78a109a9","line":311,"updated":"2016-02-03 15:17:24.000000000","message":"Maybe add different kinds of invalid id as done here, in line #753 of https://review.openstack.org/#/c/270211/12/manila/tests/api/v1/test_shares.py","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"feb072e14fe5c8716334747746fb5982633a5583","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                    for p in cls.protocols) or"},{"line_number":354,"context_line":"                any(p in CONF.share.enable_cert_rules_for_protocols"},{"line_number":355,"context_line":"                    for p in cls.protocols)):"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"            cls.message \u003d \"Rule tests are disabled\""},{"line_number":358,"context_line":"            raise cls.skipException(cls.message)"},{"line_number":359,"context_line":"        # create share"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_1d2327bf","line":356,"updated":"2016-02-03 14:58:22.000000000","message":"Undo this.","commit_id":"cea881a346d0629b36d79fa1a3f9bbf90a35d3b3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9c935d2cfa8a976beb94cdb831a9b5ad8f6da4e4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":370,"context_line":"    @ddt.data(\u0027shares_client\u0027, \u0027shares_v2_client\u0027)"},{"line_number":371,"context_line":"    def test_delete_access_rule_with_wrong_id(self, client_name):"},{"line_number":372,"context_line":"        if (client_name \u003d\u003d \u0027shares_client\u0027 and"},{"line_number":373,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":374,"context_line":"            msg \u003d (\"Skip test for client version 1.0 as it does not support \""},{"line_number":375,"context_line":"                   \"cephx access type.\")"},{"line_number":376,"context_line":"            raise self.skipException(msg)"},{"line_number":377,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":378,"context_line":"                          getattr(self, client_name).delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a5ae5dd_c357ee24","line":375,"range":{"start_line":372,"start_character":8,"end_line":375,"end_character":40},"updated":"2016-02-09 13:21:01.000000000","message":"This condition should also check microversion of v2 client. Supported only 2.11+","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6bee21a0560d659a13f8c0bba0f82e39da6c13de","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":370,"context_line":"    @ddt.data(\u0027shares_client\u0027, \u0027shares_v2_client\u0027)"},{"line_number":371,"context_line":"    def test_delete_access_rule_with_wrong_id(self, client_name):"},{"line_number":372,"context_line":"        if (client_name \u003d\u003d \u0027shares_client\u0027 and"},{"line_number":373,"context_line":"                CONF.share.enable_cephx_rules_for_protocols):"},{"line_number":374,"context_line":"            msg \u003d (\"Skip test for client version 1.0 as it does not support \""},{"line_number":375,"context_line":"                   \"cephx access type.\")"},{"line_number":376,"context_line":"            raise self.skipException(msg)"},{"line_number":377,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":378,"context_line":"                          getattr(self, client_name).delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a54edaf_f2677623","line":375,"range":{"start_line":372,"start_character":8,"end_line":375,"end_character":40},"in_reply_to":"5a5ae5dd_c357ee24","updated":"2016-02-13 09:38:16.000000000","message":"Done","commit_id":"4ffb2ca73498b25b0e8018cb7d8c4f3aa1aacb42"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"986e07ea0df41fa2bfcde50b82624dab7438be06","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":370,"context_line":"    @ddt.data(\u0027shares_client\u0027, \u0027shares_v2_client\u0027)"},{"line_number":371,"context_line":"    def test_delete_access_rule_with_wrong_id(self, client_name):"},{"line_number":372,"context_line":"        if client_name \u003d\u003d \u0027shares_client\u0027:"},{"line_number":373,"context_line":"            version \u003d \u00271.0\u0027"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            version \u003d LATEST_MICROVERSION"},{"line_number":376,"context_line":"        if (CONF.share.enable_cephx_rules_for_protocols and"},{"line_number":377,"context_line":"                utils.is_microversion_lt(version, \u00272.11\u0027)):"},{"line_number":378,"context_line":"            msg \u003d (\"API version %s does not support cephx access type, \""},{"line_number":379,"context_line":"                   \"need version greater than 2.11.\" % version)"},{"line_number":380,"context_line":"            raise self.skipException(msg)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":383,"context_line":"                          getattr(self, client_name).delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a57f1b5_9a1356b8","line":380,"range":{"start_line":372,"start_character":8,"end_line":380,"end_character":41},"updated":"2016-02-11 10:56:55.000000000","message":"This part is duplicated lots of times. It should be split out to separate func and just called in such places.","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"9d926ac06be9094d840c60cc002a1a7547685386","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":370,"context_line":"    @ddt.data(\u0027shares_client\u0027, \u0027shares_v2_client\u0027)"},{"line_number":371,"context_line":"    def test_delete_access_rule_with_wrong_id(self, client_name):"},{"line_number":372,"context_line":"        if client_name \u003d\u003d \u0027shares_client\u0027:"},{"line_number":373,"context_line":"            version \u003d \u00271.0\u0027"},{"line_number":374,"context_line":"        else:"},{"line_number":375,"context_line":"            version \u003d LATEST_MICROVERSION"},{"line_number":376,"context_line":"        if (CONF.share.enable_cephx_rules_for_protocols and"},{"line_number":377,"context_line":"                utils.is_microversion_lt(version, \u00272.11\u0027)):"},{"line_number":378,"context_line":"            msg \u003d (\"API version %s does not support cephx access type, \""},{"line_number":379,"context_line":"                   \"need version greater than 2.11.\" % version)"},{"line_number":380,"context_line":"            raise self.skipException(msg)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        self.assertRaises(lib_exc.NotFound,"},{"line_number":383,"context_line":"                          getattr(self, client_name).delete_access_rule,"}],"source_content_type":"text/x-python","patch_set":20,"id":"dae33548_5e745bce","line":380,"range":{"start_line":372,"start_character":8,"end_line":380,"end_character":41},"in_reply_to":"3a57f1b5_9a1356b8","updated":"2016-02-15 08:16:08.000000000","message":"Done","commit_id":"5433e3f61ccb080d2600a6dc12fea8ce16fd377a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f244e7574c0d4fa45c87338e6d01725ba8f9ed71","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":342,"context_line":"                          self.shares_v2_client.create_access_rule,"},{"line_number":343,"context_line":"                          self.share[\"id\"], self.access_type, access_to)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"@ddt.ddt"},{"line_number":347,"context_line":"class ShareRulesNegativeTest(base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dae33548_a27741d3","line":344,"updated":"2016-02-15 11:00:47.000000000","message":"Would be good to have test checking that RO rules creation returns error.","commit_id":"e38623db209107e3da4079187ab9a9ac97498bd9"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"0e5969f49048ffc4c106923c9975796f84ed8819","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":342,"context_line":"                          self.shares_v2_client.create_access_rule,"},{"line_number":343,"context_line":"                          self.share[\"id\"], self.access_type, access_to)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"@ddt.ddt"},{"line_number":347,"context_line":"class ShareRulesNegativeTest(base.BaseSharesTest):"}],"source_content_type":"text/x-python","patch_set":24,"id":"dae33548_15561bd2","line":344,"in_reply_to":"dae33548_a27741d3","updated":"2016-02-15 15:35:00.000000000","message":"Done","commit_id":"e38623db209107e3da4079187ab9a9ac97498bd9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab38b6f5fd303576a1882cde529fc30f7f6710ef","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        cls.share \u003d cls.create_share(cls.protocol)"},{"line_number":333,"context_line":"        cls.access_type \u003d \"cephx\""},{"line_number":334,"context_line":"        cls.access_to \u003d \"david\""},{"line_number":335,"context_line":"        if CONF.share.run_snapshot_tests:"},{"line_number":336,"context_line":"            # create snapshot"},{"line_number":337,"context_line":"            cls.snap \u003d cls.create_snapshot_wait_for_active(cls.share[\"id\"])"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":340,"context_line":"    @ddt.data(\u0027jane.doe\u0027, u\"bj\\u00F6rn\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_05ba4dc0","line":337,"range":{"start_line":335,"start_character":8,"end_line":337,"end_character":75},"updated":"2016-02-16 08:01:15.000000000","message":"This part looks very strange. It is \"rules\" module and this snapshot not used at all. Should be removed.","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"b7662c2925b5957caf98f116746c7ec136ddb3fc","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":347,"context_line":"    @ddt.data(\u0027ro\u0027, \u0027su\u0027)"},{"line_number":348,"context_line":"    def test_create_access_rule_cephx_with_wrong_level(self, access_level):"},{"line_number":349,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":350,"context_line":"                          self.shares_v2_client.create_access_rule,"},{"line_number":351,"context_line":"                          self.share[\"id\"], self.access_type, self.access_to,"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_62b18fe1","line":348,"updated":"2016-02-16 07:26:16.000000000","message":"When access_level is \u0027ro\u0027 the functional test fails.","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"37fa5baa36e35535875648461e0ceb2a33cccb27","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":347,"context_line":"    @ddt.data(\u0027ro\u0027, \u0027su\u0027)"},{"line_number":348,"context_line":"    def test_create_access_rule_cephx_with_wrong_level(self, access_level):"},{"line_number":349,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":350,"context_line":"                          self.shares_v2_client.create_access_rule,"},{"line_number":351,"context_line":"                          self.share[\"id\"], self.access_type, self.access_to,"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_4fbdfed6","line":348,"in_reply_to":"dae33548_4f9e9eb9","updated":"2016-02-18 12:19:56.000000000","message":"It should validate error state of rule. Not bad request. So, test should just be fixed.","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"},{"author":{"_account_id":18643,"name":"John Spray","email":"jspray@redhat.com","username":"jcsp"},"change_message_id":"6607667900229421c236cf163ca6fa39d598dfce","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @test.attr(type\u003d[\"negative\", \"gate\", ])"},{"line_number":347,"context_line":"    @ddt.data(\u0027ro\u0027, \u0027su\u0027)"},{"line_number":348,"context_line":"    def test_create_access_rule_cephx_with_wrong_level(self, access_level):"},{"line_number":349,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":350,"context_line":"                          self.shares_v2_client.create_access_rule,"},{"line_number":351,"context_line":"                          self.share[\"id\"], self.access_type, self.access_to,"}],"source_content_type":"text/x-python","patch_set":26,"id":"dae33548_4f9e9eb9","line":348,"in_reply_to":"dae33548_62b18fe1","updated":"2016-02-18 12:15:17.000000000","message":"\u0027ro\u0027 is validated in the driver, not in the API, so I don\u0027t expect it to raise badrequest here.  I\u0027m removing the \u0027ro\u0027 case from this test.","commit_id":"82f36eddfd4b2d82ad184d3ab9f6a6acb951ca74"}]}
