)]}'
{"manila/scheduler/rpcapi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7aa4801b16891178a55df3851c7c357c793e51f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            context,"},{"line_number":55,"context_line":"            \u0027create_share_instance\u0027,"},{"line_number":56,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":57,"context_line":"            filter_properties\u003dfilter_properties,)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def update_service_capabilities(self, context,"},{"line_number":60,"context_line":"                                    service_name, host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b4a51705","line":57,"range":{"start_line":57,"start_character":47,"end_line":57,"end_character":48},"updated":"2016-01-21 19:56:32.000000000","message":"see below","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"03faedb42ab0aca28f3b7fccdb3fe2ead0134e26","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                    service_name, host,"},{"line_number":61,"context_line":"                                    capabilities):"},{"line_number":62,"context_line":"        call_context \u003d self.client.prepare(fanout\u003dTrue, version\u003d\u00271.0\u0027)"},{"line_number":63,"context_line":"        call_context.cast("},{"line_number":64,"context_line":"            context,"},{"line_number":65,"context_line":"            \u0027update_service_capabilities\u0027,"},{"line_number":66,"context_line":"            service_name\u003dservice_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b43bd7ea","line":63,"range":{"start_line":63,"start_character":25,"end_line":63,"end_character":26},"updated":"2016-01-21 20:17:58.000000000","message":"nit. Better without the carriage return here if the lines still fit.","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"03faedb42ab0aca28f3b7fccdb3fe2ead0134e26","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027update_service_capabilities\u0027,"},{"line_number":66,"context_line":"            service_name\u003dservice_name,"},{"line_number":67,"context_line":"            host\u003dhost,"},{"line_number":68,"context_line":"            capabilities\u003dcapabilities,)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get_pools(self, context, filters\u003dNone):"},{"line_number":71,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.1\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_4f8c467f","line":68,"range":{"start_line":68,"start_character":37,"end_line":68,"end_character":39},"updated":"2016-01-21 20:17:58.000000000","message":"trailing comma here too. If you didn\u0027t touch the line then I\u0027d leave it alone, but since you are moving the ) I\u0027d prefer it deleted.","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"03faedb42ab0aca28f3b7fccdb3fe2ead0134e26","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get_pools(self, context, filters\u003dNone):"},{"line_number":71,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":72,"context_line":"        return call_context.call("},{"line_number":73,"context_line":"            context,"},{"line_number":74,"context_line":"            \u0027get_pools\u0027,"},{"line_number":75,"context_line":"            filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b412f760","line":72,"range":{"start_line":72,"start_character":32,"end_line":72,"end_character":33},"updated":"2016-01-21 20:17:58.000000000","message":"same here. I\u0027m guessing the ones with filter_properties don\u0027t fit that way, though.","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7aa4801b16891178a55df3851c7c357c793e51f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027create_consistency_group\u0027,"},{"line_number":84,"context_line":"            cg_id\u003dcg_id,"},{"line_number":85,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":86,"context_line":"            filter_properties\u003dfilter_properties,)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def migrate_share_to_host(self, context, share_id, host,"},{"line_number":89,"context_line":"                              force_host_copy\u003dFalse, request_spec\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d45a0b2a","line":86,"range":{"start_line":86,"start_character":47,"end_line":86,"end_character":48},"updated":"2016-01-21 19:56:32.000000000","message":"I don\u0027t see the point of this trailing comma, I can see you fixed the parenthesis to pass pep8 and be consistent with the rest of the methods in this file... but I don\u0027t see a guideline for trailing commas wrt method calls.\n\nhttp://docs.openstack.org/developer/hacking/#calling-methods\n\nThe trailing commas guideline applies to lists/dictionaries and not to method calls.. if it was there in the base code, it was probably in error.","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"03faedb42ab0aca28f3b7fccdb3fe2ead0134e26","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027create_consistency_group\u0027,"},{"line_number":84,"context_line":"            cg_id\u003dcg_id,"},{"line_number":85,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":86,"context_line":"            filter_properties\u003dfilter_properties,)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def migrate_share_to_host(self, context, share_id, host,"},{"line_number":89,"context_line":"                              force_host_copy\u003dFalse, request_spec\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_af6e22c7","line":86,"range":{"start_line":86,"start_character":47,"end_line":86,"end_character":48},"in_reply_to":"9a68dd71_d45a0b2a","updated":"2016-01-21 20:17:58.000000000","message":"+1","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ea7b57cac148e41daeaca99641eb207ec91a3429","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                    service_name, host,"},{"line_number":61,"context_line":"                                    capabilities):"},{"line_number":62,"context_line":"        call_context \u003d self.client.prepare(fanout\u003dTrue, version\u003d\u00271.0\u0027)"},{"line_number":63,"context_line":"        call_context.cast(context, \u0027update_service_capabilities\u0027,"},{"line_number":64,"context_line":"                          service_name\u003dservice_name, host\u003dhost,"},{"line_number":65,"context_line":"                          capabilities\u003dcapabilities)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_a6f722f4","line":63,"range":{"start_line":63,"start_character":63,"end_line":63,"end_character":65},"updated":"2016-01-28 21:27:11.000000000","message":"Sorry. I meant \"context,\" on this line and the others below it. Guideline is to put args on separate lines if they don\u0027t fit. I was just saying the first one didn\u0027t need a CR (and that was a picky-nit). http://docs.openstack.org/developer/hacking/#calling-methods","commit_id":"8fdc43cf9c874127e0efd1744b9d1e5741bea2cb"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"207aa6b512ff799a13b33fa44b5e38c667219633","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        call_context \u003d self.client.prepare(fanout\u003dTrue, version\u003d\u00271.0\u0027)"},{"line_number":62,"context_line":"        call_context.cast(context,"},{"line_number":63,"context_line":"                          \u0027update_service_capabilities\u0027,"},{"line_number":64,"context_line":"                          service_name\u003dservice_name, host\u003dhost,"},{"line_number":65,"context_line":"                          capabilities\u003dcapabilities)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def get_pools(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_9aeb2478","line":64,"updated":"2016-01-29 21:32:13.000000000","message":"if you need another update, put host\u003dhost on its own line","commit_id":"d5b82db490d9e7d217b92a75d0a4dcb5f84658a6"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"207aa6b512ff799a13b33fa44b5e38c667219633","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":87,"context_line":"        return call_context.cast(context,"},{"line_number":88,"context_line":"                                 \u0027migrate_share_to_host\u0027,"},{"line_number":89,"context_line":"                                 share_id\u003dshare_id, host\u003dhost,"},{"line_number":90,"context_line":"                                 force_host_copy\u003dforce_host_copy,"},{"line_number":91,"context_line":"                                 request_spec\u003drequest_spec_p,"},{"line_number":92,"context_line":"                                 filter_properties\u003dfilter_properties)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_1ae1749a","line":89,"updated":"2016-01-29 21:32:13.000000000","message":"if you need another update, put host\u003dhost on its own line.","commit_id":"d5b82db490d9e7d217b92a75d0a4dcb5f84658a6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47f89da22cf630ac8442b927fe638b09d51002a4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                             filter_properties\u003dNone):"},{"line_number":97,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":98,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.5\u0027)"},{"line_number":99,"context_line":"        return call_context.cast("},{"line_number":100,"context_line":"            context,"},{"line_number":101,"context_line":"            \u0027create_share_replica\u0027,"},{"line_number":102,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":103,"context_line":"            filter_properties\u003dfilter_properties,"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_ecde096c","line":104,"range":{"start_line":99,"start_character":15,"end_line":104,"end_character":9},"updated":"2016-02-16 19:55:18.000000000","message":"Please wrap this like the other returns in this file","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"},{"author":{"_account_id":17436,"name":"Sumit Kumar","email":"sumit.kumar2@netapp.com","username":"timuster"},"change_message_id":"a105495e7629f5a44f4a94271b948083f0b2860f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                             filter_properties\u003dNone):"},{"line_number":97,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":98,"context_line":"        call_context \u003d self.client.prepare(version\u003d\u00271.5\u0027)"},{"line_number":99,"context_line":"        return call_context.cast("},{"line_number":100,"context_line":"            context,"},{"line_number":101,"context_line":"            \u0027create_share_replica\u0027,"},{"line_number":102,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":103,"context_line":"            filter_properties\u003dfilter_properties,"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_2c0591bb","line":104,"range":{"start_line":99,"start_character":15,"end_line":104,"end_character":9},"in_reply_to":"dae33548_ecde096c","updated":"2016-02-16 20:32:53.000000000","message":"Done","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"}],"manila/share/rpcapi.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c7aa4801b16891178a55df3851c7c357c793e51f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            share_instance_id\u003dshare_instance[\u0027id\u0027],"},{"line_number":68,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":69,"context_line":"            filter_properties\u003dfilter_properties,"},{"line_number":70,"context_line":"            snapshot_id\u003dsnapshot_id,)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def manage_share(self, context, share, driver_options\u003dNone):"},{"line_number":73,"context_line":"        host \u003d utils.extract_host(share[\u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_74b0ff43","line":70,"range":{"start_line":70,"start_character":35,"end_line":70,"end_character":36},"updated":"2016-01-21 19:56:32.000000000","message":"same here","commit_id":"a73d3e2d0ff21c168bed8ed5b983bd1133d4d35b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47f89da22cf630ac8442b927fe638b09d51002a4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":218,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":219,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":220,"context_line":"        call_context.cast("},{"line_number":221,"context_line":"            context,"},{"line_number":222,"context_line":"            \u0027create_share_replica\u0027,"},{"line_number":223,"context_line":"            share_replica_id\u003dshare_replica[\u0027id\u0027],"},{"line_number":224,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":225,"context_line":"            filter_properties\u003dfilter_properties,"},{"line_number":226,"context_line":"            share_id\u003dshare_replica[\u0027share_id\u0027],"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def delete_share_replica(self, context, share_replica_id, host,"},{"line_number":230,"context_line":"                             share_id\u003dNone, force\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_accb61a4","line":227,"range":{"start_line":220,"start_character":26,"end_line":227,"end_character":9},"updated":"2016-02-16 19:55:18.000000000","message":"same here","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"},{"author":{"_account_id":17436,"name":"Sumit Kumar","email":"sumit.kumar2@netapp.com","username":"timuster"},"change_message_id":"a105495e7629f5a44f4a94271b948083f0b2860f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":218,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":219,"context_line":"        request_spec_p \u003d jsonutils.to_primitive(request_spec)"},{"line_number":220,"context_line":"        call_context.cast("},{"line_number":221,"context_line":"            context,"},{"line_number":222,"context_line":"            \u0027create_share_replica\u0027,"},{"line_number":223,"context_line":"            share_replica_id\u003dshare_replica[\u0027id\u0027],"},{"line_number":224,"context_line":"            request_spec\u003drequest_spec_p,"},{"line_number":225,"context_line":"            filter_properties\u003dfilter_properties,"},{"line_number":226,"context_line":"            share_id\u003dshare_replica[\u0027share_id\u0027],"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def delete_share_replica(self, context, share_replica_id, host,"},{"line_number":230,"context_line":"                             share_id\u003dNone, force\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_f77d36b2","line":227,"range":{"start_line":220,"start_character":26,"end_line":227,"end_character":9},"in_reply_to":"dae33548_accb61a4","updated":"2016-02-16 20:32:53.000000000","message":"Done","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47f89da22cf630ac8442b927fe638b09d51002a4","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                             share_id\u003dNone, force\u003dFalse):"},{"line_number":231,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":232,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":233,"context_line":"        call_context.cast("},{"line_number":234,"context_line":"            context,"},{"line_number":235,"context_line":"            \u0027delete_share_replica\u0027,"},{"line_number":236,"context_line":"            share_replica_id\u003dshare_replica_id,"},{"line_number":237,"context_line":"            share_id\u003dshare_id,"},{"line_number":238,"context_line":"            force\u003dforce,"},{"line_number":239,"context_line":"        )"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def promote_share_replica(self, context, share_replica_id, host,"},{"line_number":242,"context_line":"                              share_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_2ce91115","line":239,"range":{"start_line":233,"start_character":26,"end_line":239,"end_character":9},"updated":"2016-02-16 19:55:18.000000000","message":"same here","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"},{"author":{"_account_id":17436,"name":"Sumit Kumar","email":"sumit.kumar2@netapp.com","username":"timuster"},"change_message_id":"a105495e7629f5a44f4a94271b948083f0b2860f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                             share_id\u003dNone, force\u003dFalse):"},{"line_number":231,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":232,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":233,"context_line":"        call_context.cast("},{"line_number":234,"context_line":"            context,"},{"line_number":235,"context_line":"            \u0027delete_share_replica\u0027,"},{"line_number":236,"context_line":"            share_replica_id\u003dshare_replica_id,"},{"line_number":237,"context_line":"            share_id\u003dshare_id,"},{"line_number":238,"context_line":"            force\u003dforce,"},{"line_number":239,"context_line":"        )"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def promote_share_replica(self, context, share_replica_id, host,"},{"line_number":242,"context_line":"                              share_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_574b4287","line":239,"range":{"start_line":233,"start_character":26,"end_line":239,"end_character":9},"in_reply_to":"dae33548_2ce91115","updated":"2016-02-16 20:32:53.000000000","message":"Done","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"47f89da22cf630ac8442b927fe638b09d51002a4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                              share_id\u003dNone):"},{"line_number":243,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":244,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":245,"context_line":"        call_context.cast("},{"line_number":246,"context_line":"            context,"},{"line_number":247,"context_line":"            \u0027promote_share_replica\u0027,"},{"line_number":248,"context_line":"            share_replica_id\u003dshare_replica_id,"},{"line_number":249,"context_line":"            share_id\u003dshare_id,"},{"line_number":250,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_6cd15957","line":250,"range":{"start_line":245,"start_character":26,"end_line":250,"end_character":9},"updated":"2016-02-16 19:55:18.000000000","message":"same here","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"},{"author":{"_account_id":17436,"name":"Sumit Kumar","email":"sumit.kumar2@netapp.com","username":"timuster"},"change_message_id":"a105495e7629f5a44f4a94271b948083f0b2860f","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                              share_id\u003dNone):"},{"line_number":243,"context_line":"        new_host \u003d utils.extract_host(host)"},{"line_number":244,"context_line":"        call_context \u003d self.client.prepare(server\u003dnew_host, version\u003d\u00271.8\u0027)"},{"line_number":245,"context_line":"        call_context.cast("},{"line_number":246,"context_line":"            context,"},{"line_number":247,"context_line":"            \u0027promote_share_replica\u0027,"},{"line_number":248,"context_line":"            share_replica_id\u003dshare_replica_id,"},{"line_number":249,"context_line":"            share_id\u003dshare_id,"},{"line_number":250,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_9745ca71","line":250,"range":{"start_line":245,"start_character":26,"end_line":250,"end_character":9},"in_reply_to":"dae33548_6cd15957","updated":"2016-02-16 20:32:53.000000000","message":"Done","commit_id":"30b30002bad37f842d290b3429e78c7b4f6f7acb"}]}