)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"65a2277d6ac0fe1b003c7e4876857f0a829df2cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC Isilon Driver Support For NFS Read-Only Share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support for read-only shares to the NFS protocol in the Isilon driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Idf8b8772e30d55667317de9f50117968d34ee877"},{"line_number":12,"context_line":"Implements: blueprint emc-isilon-driver-readonly-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_829b1072","line":9,"updated":"2016-02-04 04:11:26.000000000","message":"Can you add a line here to say \"Fixed parameters in the exceptions\"?  This is to address Tom\u0027s comments in previous patch set that those changes are not related to the commit message.","commit_id":"09dcb8155e8b26124be92c04d53c7ecbb2d1c623"}],"manila/share/drivers/emc/plugins/isilon/isilon.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b9a55c8ef66b5498d8d37485128d4540eef34089","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":186,"context_line":"            message \u003d _(\u0027Only ip access type allowed.\u0027)"},{"line_number":187,"context_line":"            LOG.error(message)"},{"line_number":188,"context_line":"            raise exception.ShareBackendException(message\u003dmessage)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_4109a330","line":188,"range":{"start_line":188,"start_character":49,"end_line":188,"end_character":66},"updated":"2016-01-27 03:38:58.000000000","message":"https://github.com/openstack/manila/blob/master/manila/exception.py#L421\n\nmsg\u003dmessage","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"110af6db88e493f4f41c2803b7eea2ad417b70ee","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":186,"context_line":"            message \u003d _(\u0027Only ip access type allowed.\u0027)"},{"line_number":187,"context_line":"            LOG.error(message)"},{"line_number":188,"context_line":"            raise exception.ShareBackendException(message\u003dmessage)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_35d35e06","line":188,"range":{"start_line":188,"start_character":49,"end_line":188,"end_character":66},"in_reply_to":"9a68dd71_4109a330","updated":"2016-01-29 19:50:11.000000000","message":"Done","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b9a55c8ef66b5498d8d37485128d4540eef34089","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                \u0027\"CIFS\" are currently supported share protocols.\u0027) % share["},{"line_number":202,"context_line":"                \u0027share_proto\u0027]"},{"line_number":203,"context_line":"            LOG.error(message)"},{"line_number":204,"context_line":"            raise exception.InvalidShare(message\u003dmessage)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _nfs_allow_access(self, access_ip, export_path, access_level):"},{"line_number":207,"context_line":"        \"\"\"Allow access to nfs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_541f1f5b","line":204,"range":{"start_line":204,"start_character":28,"end_line":204,"end_character":57},"updated":"2016-01-27 03:38:58.000000000","message":"https://github.com/openstack/manila/blob/master/manila/exception.py#L383\n\nreason\u003dmessage","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"110af6db88e493f4f41c2803b7eea2ad417b70ee","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                \u0027\"CIFS\" are currently supported share protocols.\u0027) % share["},{"line_number":202,"context_line":"                \u0027share_proto\u0027]"},{"line_number":203,"context_line":"            LOG.error(message)"},{"line_number":204,"context_line":"            raise exception.InvalidShare(message\u003dmessage)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _nfs_allow_access(self, access_ip, export_path, access_level):"},{"line_number":207,"context_line":"        \"\"\"Allow access to nfs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_55ce1a5b","line":204,"range":{"start_line":204,"start_character":28,"end_line":204,"end_character":57},"in_reply_to":"9a68dd71_541f1f5b","updated":"2016-01-29 19:50:11.000000000","message":"Done","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b9a55c8ef66b5498d8d37485128d4540eef34089","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":234,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":235,"context_line":"            LOG.error(message)"},{"line_number":236,"context_line":"            raise exception.InvalidShareAccess(message\u003dmessage)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        allowed_ip \u003d \u0027allow:\u0027 + ip"},{"line_number":239,"context_line":"        smb_share \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_a1173f53","line":236,"range":{"start_line":236,"start_character":18,"end_line":236,"end_character":62},"updated":"2016-01-27 03:38:58.000000000","message":"s/exception.InvalidShareAccess(message\u003dmessage)/exception.InvalidShareAccess(reason\u003dmessage)","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"110af6db88e493f4f41c2803b7eea2ad417b70ee","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            message \u003d _(\u0027Only RW Access allowed for CIFS Protocol when using \u0027"},{"line_number":234,"context_line":"                        \u0027the \"ip\" access type.\u0027)"},{"line_number":235,"context_line":"            LOG.error(message)"},{"line_number":236,"context_line":"            raise exception.InvalidShareAccess(message\u003dmessage)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        allowed_ip \u003d \u0027allow:\u0027 + ip"},{"line_number":239,"context_line":"        smb_share \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_9502526e","line":236,"range":{"start_line":236,"start_character":18,"end_line":236,"end_character":62},"in_reply_to":"9a68dd71_a1173f53","updated":"2016-01-29 19:50:11.000000000","message":"Done","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"31d1ae6d40947866ef001f48a6d68f32edbebb16","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":275,"context_line":"            LOG.error(message)"},{"line_number":276,"context_line":"            raise exception.ShareBackendException(message\u003dmessage)"},{"line_number":277,"context_line":"        clients \u003d self._get_existing_nfs_export(export_id)[share_access_group]"},{"line_number":278,"context_line":"        allowed_ips \u003d set(clients)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        if allowed_ips.__contains__(denied_ip):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_67ac138d","line":277,"range":{"start_line":277,"start_character":8,"end_line":277,"end_character":78},"updated":"2016-01-26 16:05:13.000000000","message":"What about the existing exports from previous versions (the \u0027clients\u0027 group)? Shouldn\u0027t those be supported somehow?","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"110af6db88e493f4f41c2803b7eea2ad417b70ee","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":275,"context_line":"            LOG.error(message)"},{"line_number":276,"context_line":"            raise exception.ShareBackendException(message\u003dmessage)"},{"line_number":277,"context_line":"        clients \u003d self._get_existing_nfs_export(export_id)[share_access_group]"},{"line_number":278,"context_line":"        allowed_ips \u003d set(clients)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        if allowed_ips.__contains__(denied_ip):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_8edbea4e","line":277,"range":{"start_line":277,"start_character":8,"end_line":277,"end_character":78},"in_reply_to":"9a68dd71_67ac138d","updated":"2016-01-29 19:50:11.000000000","message":"Good point, I reverted my driver to go back to using the \"clients\" field. (The \"clients\" field specifies which clients have access to the share)","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b9a55c8ef66b5498d8d37485128d4540eef34089","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        return export"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _cifs_deny_access(self, denied_ip, share, access_level):"},{"line_number":299,"context_line":"        \"\"\"Deny access to cifs share.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        share_json \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_b451bb10","line":298,"range":{"start_line":298,"start_character":50,"end_line":298,"end_character":62},"updated":"2016-01-27 03:38:58.000000000","message":"This parameter not be used?","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"110af6db88e493f4f41c2803b7eea2ad417b70ee","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        return export"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _cifs_deny_access(self, denied_ip, share, access_level):"},{"line_number":299,"context_line":"        \"\"\"Deny access to cifs share.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        share_json \u003d self._isilon_api.lookup_smb_share(share[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_5574dacd","line":298,"range":{"start_line":298,"start_character":50,"end_line":298,"end_character":62},"in_reply_to":"9a68dd71_b451bb10","updated":"2016-01-29 19:50:11.000000000","message":"Fixed, by removing param, cifs deny access support will be added in a later contribution","commit_id":"81bb9fbd1922e9c77e9e50db98634608d34e6470"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cce29446951120d13db193f010755bf292dcd1d9","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":275,"context_line":"            LOG.error(message)"},{"line_number":276,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":277,"context_line":"        clients \u003d self._get_existing_nfs_export(export_id)[share_access_group]"},{"line_number":278,"context_line":"        allowed_ips \u003d set(clients)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        if allowed_ips.__contains__(denied_ip):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_350e8ce5","line":277,"range":{"start_line":277,"start_character":59,"end_line":277,"end_character":77},"updated":"2016-02-01 14:15:48.000000000","message":"Potential \"KeyError\", need either to use safe approach or verify and fail in condition is false.","commit_id":"5e155d4c613e4019a264e7c536b114d403536554"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"9f8e6a49dba9d103729fff05589d8319dd655b5f","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                        \u0027found.\u0027) % share[\u0027name\u0027]"},{"line_number":275,"context_line":"            LOG.error(message)"},{"line_number":276,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":277,"context_line":"        clients \u003d self._get_existing_nfs_export(export_id)[share_access_group]"},{"line_number":278,"context_line":"        allowed_ips \u003d set(clients)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        if allowed_ips.__contains__(denied_ip):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_057b107c","line":277,"range":{"start_line":277,"start_character":59,"end_line":277,"end_character":77},"in_reply_to":"7a5de9d1_350e8ce5","updated":"2016-02-01 17:56:32.000000000","message":"Done","commit_id":"5e155d4c613e4019a264e7c536b114d403536554"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cce29446951120d13db193f010755bf292dcd1d9","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            message \u003d _(\u0027NFS share with export id %d should have been \u0027"},{"line_number":292,"context_line":"                        \u0027created, but was not found.\u0027) % export_id"},{"line_number":293,"context_line":"            LOG.error(message)"},{"line_number":294,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        return export"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_55f548ea","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":53},"updated":"2016-02-01 14:15:48.000000000","message":"Looks like here and above you fix completely different bug - but of exception message handling.","commit_id":"5e155d4c613e4019a264e7c536b114d403536554"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"9f8e6a49dba9d103729fff05589d8319dd655b5f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            message \u003d _(\u0027NFS share with export id %d should have been \u0027"},{"line_number":292,"context_line":"                        \u0027created, but was not found.\u0027) % export_id"},{"line_number":293,"context_line":"            LOG.error(message)"},{"line_number":294,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        return export"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_c59978c5","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":53},"in_reply_to":"7a5de9d1_55f548ea","updated":"2016-02-01 17:56:32.000000000","message":"I\u0027m assuming this is just a comment?","commit_id":"5e155d4c613e4019a264e7c536b114d403536554"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":71,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":72,"context_line":"            LOG.error(message)"},{"line_number":73,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # apply directory quota based on share size"},{"line_number":76,"context_line":"        max_share_size \u003d share[\u0027size\u0027] * units.Gi"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_fc0af4d0","line":73,"updated":"2016-02-02 08:48:32.000000000","message":"This is a) unrelated to the commit message and b) afaics wrong. The exception class takes a parameter called \"message\" in it\u0027s constructor. See https://github.com/openstack/manila/blob/master/manila/exception.py#L75","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":71,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":72,"context_line":"            LOG.error(message)"},{"line_number":73,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # apply directory quota based on share size"},{"line_number":76,"context_line":"        max_share_size \u003d share[\u0027size\u0027] * units.Gi"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_7e9a55c7","line":73,"in_reply_to":"7a5de9d1_3e7388b6","updated":"2016-02-02 19:51:28.000000000","message":"Xing is correct, I was asked to fix exception parameters in a previous review comment.","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5f36d067a1bc604ada25d038db085a318ceca645","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            message \u003d (_(\u0027Unsupported share protocol: %(proto)s.\u0027) %"},{"line_number":71,"context_line":"                       {\u0027proto\u0027: share[\u0027share_proto\u0027]})"},{"line_number":72,"context_line":"            LOG.error(message)"},{"line_number":73,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # apply directory quota based on share size"},{"line_number":76,"context_line":"        max_share_size \u003d share[\u0027size\u0027] * units.Gi"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_3e7388b6","line":73,"in_reply_to":"7a5de9d1_fc0af4d0","updated":"2016-02-02 15:48:11.000000000","message":"Hi Tom,\n\nI think this is from a previous comment.  The definition of InvalidShare is from the following line so \"reason\u003dxxx\" is the correct input:\n\nhttps://github.com/openstack/manila/blob/master/manila/exception.py#L384\n\nWhat if in the commit message, it is added that \"Fixed parameters in the exceptions\".  Is that ok or do you prefer all changes to existing exception parameters to be fixed in a separate patch?","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                _(\u0027The requested NFS share \"%(share)s\" was not created.\u0027) %"},{"line_number":104,"context_line":"                {\u0027share\u0027: share[\u0027name\u0027]})"},{"line_number":105,"context_line":"            LOG.error(message)"},{"line_number":106,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":107,"context_line":"        location \u003d \u0027{0}:{1}\u0027.format(self._server, container_path)"},{"line_number":108,"context_line":"        return location"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_bc10fc00","line":106,"updated":"2016-02-02 08:48:32.000000000","message":"same here","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                _(\u0027The requested NFS share \"%(share)s\" was not created.\u0027) %"},{"line_number":104,"context_line":"                {\u0027share\u0027: share[\u0027name\u0027]})"},{"line_number":105,"context_line":"            LOG.error(message)"},{"line_number":106,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":107,"context_line":"        location \u003d \u0027{0}:{1}\u0027.format(self._server, container_path)"},{"line_number":108,"context_line":"        return location"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_be8f6d74","line":106,"in_reply_to":"7a5de9d1_bc10fc00","updated":"2016-02-02 19:51:28.000000000","message":"see above comment","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            message \u003d (_(\u0027Unsupported share type: %(type)s.\u0027) %"},{"line_number":133,"context_line":"                       {\u0027type\u0027: share[\u0027share_proto\u0027]})"},{"line_number":134,"context_line":"            LOG.error(message)"},{"line_number":135,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _delete_nfs_share(self, share):"},{"line_number":138,"context_line":"        \"\"\"Is called to remove nfs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_5cfc68b7","line":135,"updated":"2016-02-02 08:48:32.000000000","message":"same here","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            message \u003d (_(\u0027Unsupported share type: %(type)s.\u0027) %"},{"line_number":133,"context_line":"                       {\u0027type\u0027: share[\u0027share_proto\u0027]})"},{"line_number":134,"context_line":"            LOG.error(message)"},{"line_number":135,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _delete_nfs_share(self, share):"},{"line_number":138,"context_line":"        \"\"\"Is called to remove nfs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_9eedd127","line":135,"in_reply_to":"7a5de9d1_5cfc68b7","updated":"2016-02-02 19:51:28.000000000","message":"see above comment","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            if not export_deleted:"},{"line_number":150,"context_line":"                message \u003d _(\u0027Error deleting NFS share: %s\u0027) % share[\u0027name\u0027]"},{"line_number":151,"context_line":"                LOG.error(message)"},{"line_number":152,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _delete_cifs_share(self, share):"},{"line_number":155,"context_line":"        \"\"\"Is called to remove CIFS share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_7cf7e4d2","line":152,"updated":"2016-02-02 08:48:32.000000000","message":"same here","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            if not export_deleted:"},{"line_number":150,"context_line":"                message \u003d _(\u0027Error deleting NFS share: %s\u0027) % share[\u0027name\u0027]"},{"line_number":151,"context_line":"                LOG.error(message)"},{"line_number":152,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def _delete_cifs_share(self, share):"},{"line_number":155,"context_line":"        \"\"\"Is called to remove CIFS share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_5ef759f5","line":152,"in_reply_to":"7a5de9d1_7cf7e4d2","updated":"2016-02-02 19:51:28.000000000","message":"see above comment","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            if not share_deleted:"},{"line_number":164,"context_line":"                message \u003d _(\u0027Error deleting CIFS share: %s\u0027) % share[\u0027name\u0027]"},{"line_number":165,"context_line":"                LOG.error(message)"},{"line_number":166,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def delete_snapshot(self, context, snapshot, share_server):"},{"line_number":169,"context_line":"        \"\"\"Is called to remove snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_1c0270b4","line":166,"updated":"2016-02-02 08:48:32.000000000","message":"same here","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            if not share_deleted:"},{"line_number":164,"context_line":"                message \u003d _(\u0027Error deleting CIFS share: %s\u0027) % share[\u0027name\u0027]"},{"line_number":165,"context_line":"                LOG.error(message)"},{"line_number":166,"context_line":"                raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def delete_snapshot(self, context, snapshot, share_server):"},{"line_number":169,"context_line":"        \"\"\"Is called to remove snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_de68298a","line":166,"in_reply_to":"7a5de9d1_1c0270b4","updated":"2016-02-02 19:51:28.000000000","message":"see above comment","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":186,"context_line":"            message \u003d _(\u0027Only ip access type allowed.\u0027)"},{"line_number":187,"context_line":"            LOG.error(message)"},{"line_number":188,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_dc2e1842","line":188,"updated":"2016-02-02 08:48:32.000000000","message":"same here","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        if access[\u0027access_type\u0027] !\u003d \u0027ip\u0027:"},{"line_number":186,"context_line":"            message \u003d _(\u0027Only ip access type allowed.\u0027)"},{"line_number":187,"context_line":"            LOG.error(message)"},{"line_number":188,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        access_ip \u003d access[\u0027access_to\u0027]"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_3e0e1de6","line":188,"in_reply_to":"7a5de9d1_dc2e1842","updated":"2016-02-02 19:51:28.000000000","message":"see above comment","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            self._nfs_allow_access("},{"line_number":195,"context_line":"                access_ip, export_path, access[\u0027access_level\u0027])"},{"line_number":196,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":197,"context_line":"            self._cifs_allow_access(access_ip, share, access[\u0027access_level\u0027])"},{"line_number":198,"context_line":"        else:"},{"line_number":199,"context_line":"            message \u003d _("},{"line_number":200,"context_line":"                \u0027Unsupported share protocol: %s. Only \"NFS\" and \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_3cebacdd","line":197,"updated":"2016-02-02 08:48:32.000000000","message":"nit: can you do the same linebreak style as for \"self._nfs_allow_access\" please?","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            self._nfs_allow_access("},{"line_number":195,"context_line":"                access_ip, export_path, access[\u0027access_level\u0027])"},{"line_number":196,"context_line":"        elif share[\u0027share_proto\u0027] \u003d\u003d \u0027CIFS\u0027:"},{"line_number":197,"context_line":"            self._cifs_allow_access(access_ip, share, access[\u0027access_level\u0027])"},{"line_number":198,"context_line":"        else:"},{"line_number":199,"context_line":"            message \u003d _("},{"line_number":200,"context_line":"                \u0027Unsupported share protocol: %s. Only \"NFS\" and \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_bef0cdca","line":197,"in_reply_to":"7a5de9d1_3cebacdd","updated":"2016-02-02 19:51:28.000000000","message":"Done","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"65fcc2f8950ffb3e5d3ca77fb143d2e475f1df5a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                \u0027\"CIFS\" are currently supported share protocols.\u0027) % share["},{"line_number":202,"context_line":"                \u0027share_proto\u0027]"},{"line_number":203,"context_line":"            LOG.error(message)"},{"line_number":204,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _nfs_allow_access(self, access_ip, export_path, access_level):"},{"line_number":207,"context_line":"        \"\"\"Allow access to nfs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_fcbf54cd","line":204,"updated":"2016-02-02 08:48:32.000000000","message":"same here (don\u0027t change this)","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                \u0027\"CIFS\" are currently supported share protocols.\u0027) % share["},{"line_number":202,"context_line":"                \u0027share_proto\u0027]"},{"line_number":203,"context_line":"            LOG.error(message)"},{"line_number":204,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _nfs_allow_access(self, access_ip, export_path, access_level):"},{"line_number":207,"context_line":"        \"\"\"Allow access to nfs share.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_deffc9a8","line":204,"in_reply_to":"7a5de9d1_fcbf54cd","updated":"2016-02-02 19:51:28.000000000","message":"see above comment","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"265768ed755be87c36bd6f73a1a857e2d629b2cd","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        export \u003d self._get_existing_nfs_export(export_id)"},{"line_number":279,"context_line":"        try:"},{"line_number":280,"context_line":"            clients \u003d export[share_access_group]"},{"line_number":281,"context_line":"        except KeyError:"},{"line_number":282,"context_line":"            message \u003d (_(\u0027Export %(export_name)s should have contained the \u0027"},{"line_number":283,"context_line":"                         \u0027JSON key %(json_key)s, but this key was not found.\u0027)"},{"line_number":284,"context_line":"                       % {\u0027export_name\u0027: share[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a54edaf_0690dc94","line":281,"range":{"start_line":281,"start_character":15,"end_line":281,"end_character":23},"updated":"2016-02-13 02:50:23.000000000","message":"This block wasn\u0027t covered by a unit test.","commit_id":"20efd1046dfc36c02d94d972911f476ceac08d4a"}],"manila/tests/share/drivers/emc/plugins/isilon/test_isilon.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"624e27fa45db2d8130b9f4178d4c911de1f9b729","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # verify expected REST API call is executed"},{"line_number":111,"context_line":"        expected_url \u003d (self.API_URL + \u0027/platform/1/protocols/nfs/exports/\u0027 +"},{"line_number":112,"context_line":"                        str(fake_export_id))"},{"line_number":113,"context_line":"        expected_data \u003d {\u0027read_only_clients\u0027: [\u002710.1.1.10\u0027]}"},{"line_number":114,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":115,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_cc667cec","line":112,"range":{"start_line":112,"start_character":24,"end_line":112,"end_character":27},"updated":"2016-02-01 21:04:06.000000000","message":"six.text_type()","commit_id":"1cac2b2b687c7f15b7ae45e71d12f9f653869424"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"a1dffc8a8a8368c08d1e7f0d4ecfa9230e42d80e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # verify expected REST API call is executed"},{"line_number":111,"context_line":"        expected_url \u003d (self.API_URL + \u0027/platform/1/protocols/nfs/exports/\u0027 +"},{"line_number":112,"context_line":"                        str(fake_export_id))"},{"line_number":113,"context_line":"        expected_data \u003d {\u0027read_only_clients\u0027: [\u002710.1.1.10\u0027]}"},{"line_number":114,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":115,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_c28723b3","line":112,"range":{"start_line":112,"start_character":24,"end_line":112,"end_character":27},"in_reply_to":"7a5de9d1_cc667cec","updated":"2016-02-01 22:08:29.000000000","message":"Done","commit_id":"1cac2b2b687c7f15b7ae45e71d12f9f653869424"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"624e27fa45db2d8130b9f4178d4c911de1f9b729","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # verify expected REST API call is executed"},{"line_number":132,"context_line":"        expected_url \u003d (self.API_URL + \u0027/platform/1/protocols/nfs/exports/\u0027 +"},{"line_number":133,"context_line":"                        str(fake_export_id))"},{"line_number":134,"context_line":"        expected_data \u003d {\u0027clients\u0027: [\u002710.1.1.10\u0027]}"},{"line_number":135,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":136,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_ac6b00b6","line":133,"range":{"start_line":133,"start_character":24,"end_line":133,"end_character":27},"updated":"2016-02-01 21:04:06.000000000","message":"six.text_type()","commit_id":"1cac2b2b687c7f15b7ae45e71d12f9f653869424"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"a1dffc8a8a8368c08d1e7f0d4ecfa9230e42d80e","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # verify expected REST API call is executed"},{"line_number":132,"context_line":"        expected_url \u003d (self.API_URL + \u0027/platform/1/protocols/nfs/exports/\u0027 +"},{"line_number":133,"context_line":"                        str(fake_export_id))"},{"line_number":134,"context_line":"        expected_data \u003d {\u0027clients\u0027: [\u002710.1.1.10\u0027]}"},{"line_number":135,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":136,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_22bf1762","line":133,"range":{"start_line":133,"start_character":24,"end_line":133,"end_character":27},"in_reply_to":"7a5de9d1_ac6b00b6","updated":"2016-02-01 22:08:29.000000000","message":"Done","commit_id":"1cac2b2b687c7f15b7ae45e71d12f9f653869424"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"624e27fa45db2d8130b9f4178d4c911de1f9b729","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # verify that a call is made to remove an existing IP from the list"},{"line_number":194,"context_line":"        expected_url \u003d (self.API_URL + \u0027/platform/1/protocols/nfs/exports/\u0027 +"},{"line_number":195,"context_line":"                        str(fake_export_id))"},{"line_number":196,"context_line":"        expected_data \u003d {\u0027read_only_clients\u0027: []}"},{"line_number":197,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":198,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_4c7a8c89","line":195,"range":{"start_line":195,"start_character":24,"end_line":195,"end_character":27},"updated":"2016-02-01 21:04:06.000000000","message":"Please use six.text_type() instead of str().","commit_id":"1cac2b2b687c7f15b7ae45e71d12f9f653869424"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"a1dffc8a8a8368c08d1e7f0d4ecfa9230e42d80e","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # verify that a call is made to remove an existing IP from the list"},{"line_number":194,"context_line":"        expected_url \u003d (self.API_URL + \u0027/platform/1/protocols/nfs/exports/\u0027 +"},{"line_number":195,"context_line":"                        str(fake_export_id))"},{"line_number":196,"context_line":"        expected_data \u003d {\u0027read_only_clients\u0027: []}"},{"line_number":197,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":198,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_42c253ea","line":195,"range":{"start_line":195,"start_character":24,"end_line":195,"end_character":27},"in_reply_to":"7a5de9d1_4c7a8c89","updated":"2016-02-01 22:08:29.000000000","message":"Done","commit_id":"1cac2b2b687c7f15b7ae45e71d12f9f653869424"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6768bca2d1a378f3f924f2bc4916ddfa68e050e8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_allow_access__nfs_readonly(self):"},{"line_number":98,"context_line":"        # setup"},{"line_number":99,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":100,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_2564f6b6","line":97,"updated":"2016-02-02 04:19:08.000000000","message":"Any reason why you have double underscore before \"nfs\"?","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"2d07c9650f703a0e9cd1a12174879f0eff176393","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_allow_access__nfs_readonly(self):"},{"line_number":98,"context_line":"        # setup"},{"line_number":99,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":100,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_971e410a","line":97,"in_reply_to":"7a5de9d1_2564f6b6","updated":"2016-02-02 05:07:53.000000000","message":"I wanted to make it clear which part was the method name and which part was the condition. I could name it something like \"test_allow_access_with_nfs_readonly\" if that would be preferable.","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_allow_access__nfs_readonly(self):"},{"line_number":98,"context_line":"        # setup"},{"line_number":99,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":100,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_3925d75b","line":97,"in_reply_to":"7a5de9d1_3b94fae6","updated":"2016-02-02 19:51:28.000000000","message":"Done","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5f36d067a1bc604ada25d038db085a318ceca645","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":95,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_allow_access__nfs_readonly(self):"},{"line_number":98,"context_line":"        # setup"},{"line_number":99,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":100,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_3b94fae6","line":97,"in_reply_to":"7a5de9d1_971e410a","updated":"2016-02-02 15:48:11.000000000","message":"Sure.","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6768bca2d1a378f3f924f2bc4916ddfa68e050e8","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":116,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_allow_access__nfs_readwrite(self):"},{"line_number":119,"context_line":"        # setup"},{"line_number":120,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":121,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_c55642cd","line":118,"updated":"2016-02-02 04:19:08.000000000","message":"same question here.","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"2d07c9650f703a0e9cd1a12174879f0eff176393","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":116,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_allow_access__nfs_readwrite(self):"},{"line_number":119,"context_line":"        # setup"},{"line_number":120,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027NFS\u0027}"},{"line_number":121,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_17d9f156","line":118,"in_reply_to":"7a5de9d1_c55642cd","updated":"2016-02-02 05:07:53.000000000","message":"see above answer","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6768bca2d1a378f3f924f2bc4916ddfa68e050e8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":137,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_allow_access__cifs_ip_readonly(self):"},{"line_number":140,"context_line":"        # Note: Driver does not currently support readonly access for \"ip\" type"},{"line_number":141,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027CIFS\u0027}"},{"line_number":142,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_e5ac9ea0","line":139,"updated":"2016-02-02 04:19:08.000000000","message":"here too","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"5ef9c867c70418c1354a58fd81182cde8983b57e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":137,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_allow_access__cifs_ip_readonly(self):"},{"line_number":140,"context_line":"        # Note: Driver does not currently support readonly access for \"ip\" type"},{"line_number":141,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027CIFS\u0027}"},{"line_number":142,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_39b3970c","line":139,"in_reply_to":"7a5de9d1_77eaa5dc","updated":"2016-02-02 19:51:28.000000000","message":"Done","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"},{"author":{"_account_id":15077,"name":"Shaun Edwards","email":"shaun.edwards@emc.com","username":"sedwards"},"change_message_id":"2d07c9650f703a0e9cd1a12174879f0eff176393","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        self._mock_isilon_api.request.assert_called_once_with("},{"line_number":137,"context_line":"            \u0027PUT\u0027, expected_url, data\u003dexpected_data)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_allow_access__cifs_ip_readonly(self):"},{"line_number":140,"context_line":"        # Note: Driver does not currently support readonly access for \"ip\" type"},{"line_number":141,"context_line":"        share \u003d {\u0027name\u0027: self.SHARE_NAME, \u0027share_proto\u0027: \u0027CIFS\u0027}"},{"line_number":142,"context_line":"        access \u003d {\u0027access_type\u0027: \u0027ip\u0027, \u0027access_to\u0027: \u002710.1.1.10\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_77eaa5dc","line":139,"in_reply_to":"7a5de9d1_e5ac9ea0","updated":"2016-02-02 05:07:53.000000000","message":"see above answer","commit_id":"a6882f98bfb5dd4b744ad4ecea254ba6663ea597"}]}
