)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8440e96d7f4e134258bbdc3986330fcd922e8192","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"max_over_subscription_ratio is used when the following two"},{"line_number":10,"context_line":"conditions are both met:"},{"line_number":11,"context_line":"1. The capability of the pool contains \"thin_provision\u003dTrue\";"},{"line_number":12,"context_line":"2. The share type contains \"capabilities:thin_provision\u003d\u003cis\u003e True\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1ac39f4659975ec90df13241d7a425bf57242e29"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_720d2be7","line":11,"range":{"start_line":11,"start_character":45,"end_line":11,"end_character":54},"updated":"2016-02-12 07:52:23.000000000","message":"provisioning","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8440e96d7f4e134258bbdc3986330fcd922e8192","unresolved":false,"context_lines":[{"line_number":9,"context_line":"max_over_subscription_ratio is used when the following two"},{"line_number":10,"context_line":"conditions are both met:"},{"line_number":11,"context_line":"1. The capability of the pool contains \"thin_provision\u003dTrue\";"},{"line_number":12,"context_line":"2. The share type contains \"capabilities:thin_provision\u003d\u003cis\u003e True\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1ac39f4659975ec90df13241d7a425bf57242e29"},{"line_number":15,"context_line":"Closes-Bug: #1536936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_b2d5e31c","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":65},"updated":"2016-02-12 07:52:23.000000000","message":"This can now be use \u0027true\u0027 (or other strings that match true).  See: https://review.openstack.org/#q,I959906bc92a374abc25625d012cfbad8aaf11065,n,z","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"8440e96d7f4e134258bbdc3986330fcd922e8192","unresolved":false,"context_lines":[{"line_number":9,"context_line":"max_over_subscription_ratio is used when the following two"},{"line_number":10,"context_line":"conditions are both met:"},{"line_number":11,"context_line":"1. The capability of the pool contains \"thin_provision\u003dTrue\";"},{"line_number":12,"context_line":"2. The share type contains \"capabilities:thin_provision\u003d\u003cis\u003e True\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1ac39f4659975ec90df13241d7a425bf57242e29"},{"line_number":15,"context_line":"Closes-Bug: #1536936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a57f1b5_52f90fc6","line":12,"range":{"start_line":12,"start_character":46,"end_line":12,"end_character":55},"updated":"2016-02-12 07:52:23.000000000","message":"provisioning","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23f51cb97f6431fade0609ca84e0804a044cd5b7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"max_over_subscription_ratio is used when the following two"},{"line_number":10,"context_line":"conditions are both met:"},{"line_number":11,"context_line":"1. The capability of the pool contains \"thin_provision\u003dTrue\";"},{"line_number":12,"context_line":"2. The share type contains \"capabilities:thin_provision\u003d\u003cis\u003e True\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1ac39f4659975ec90df13241d7a425bf57242e29"},{"line_number":15,"context_line":"Closes-Bug: #1536936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bae84128_f9a54904","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":65},"in_reply_to":"3a57f1b5_b2d5e31c","updated":"2016-02-21 23:22:31.000000000","message":"Link for the True/False change: https://review.openstack.org/#/c/270604/","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"50da76b90e52eba5e126c042c2ac21fccff28452","unresolved":false,"context_lines":[{"line_number":10,"context_line":"conditions are both met:"},{"line_number":11,"context_line":"1. The capability of the pool contains \"thin_provision\u003dTrue\";"},{"line_number":12,"context_line":"2. The share type contains \"capabilities:thin_provision\u003d\u003cis\u003e True\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1ac39f4659975ec90df13241d7a425bf57242e29"},{"line_number":15,"context_line":"Closes-Bug: #1536936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bae84128_1e62373e","line":13,"updated":"2016-02-23 15:39:58.000000000","message":"Can you add a short description *why* you want this change?","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"}],"manila/scheduler/filters/capacity.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9032edda7f31c4446a7f76e78c621b9003638f17","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Return True if thin_provisioning in resource_type is True.\"\"\""},{"line_number":38,"context_line":"        if not resource_type:"},{"line_number":39,"context_line":"            return False"},{"line_number":40,"context_line":"        extra_specs \u003d resource_type.get(\u0027extra_specs\u0027, [])"},{"line_number":41,"context_line":"        if not extra_specs:"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_e1c77762","line":40,"range":{"start_line":40,"start_character":22,"end_line":40,"end_character":58},"updated":"2016-01-27 03:11:22.000000000","message":"Can just use resource_type.get(\u0027extra_specs\u0027), \u0027None\u0027 would be the default return value.","commit_id":"b885f11e7beaf52d27b713610c44096d5567fd0c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9032edda7f31c4446a7f76e78c621b9003638f17","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if not extra_specs:"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        for key, req in six.iteritems(extra_specs):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            # Either not scoped format, or in capabilities scope"},{"line_number":47,"context_line":"            scope \u003d key.split(\u0027:\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_de056e14","line":44,"range":{"start_line":44,"start_character":24,"end_line":44,"end_character":50},"updated":"2016-01-27 03:11:22.000000000","message":"Using dict.items() is better than six.iteritems(dict)","commit_id":"b885f11e7beaf52d27b713610c44096d5567fd0c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9032edda7f31c4446a7f76e78c621b9003638f17","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        for key, req in six.iteritems(extra_specs):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            # Either not scoped format, or in capabilities scope"},{"line_number":47,"context_line":"            scope \u003d key.split(\u0027:\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"            # Ignore scoped (such as vendor-specific) capabilities"},{"line_number":50,"context_line":"            if len(scope) \u003e 1 and scope[0] !\u003d \"capabilities\":"},{"line_number":51,"context_line":"                continue"},{"line_number":52,"context_line":"            # Strip off prefix if spec started with \u0027capabilities:\u0027"},{"line_number":53,"context_line":"            elif scope[0] \u003d\u003d \"capabilities\":"},{"line_number":54,"context_line":"                del scope[0]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"            for index in range(len(scope)):"},{"line_number":57,"context_line":"                if scope[index] \u003d\u003d \"thin_provisioning\":"},{"line_number":58,"context_line":"                    return extra_specs_ops.match(\u0027True\u0027, req)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return False"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_e10217b4","line":58,"range":{"start_line":46,"start_character":12,"end_line":58,"end_character":61},"updated":"2016-01-27 03:11:22.000000000","message":"Why not just use req\u003dextra_specs.get(\u0027thin_provisioning\u0027) or  req\u003dextra_specs.get(\u0027capabilities:thin_provisioning\u0027)","commit_id":"b885f11e7beaf52d27b713610c44096d5567fd0c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7e2c0785957627dff8bdb88aa8ac32bee14f07fe","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if not extra_specs:"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        for key, req in six.iteritems(extra_specs):"},{"line_number":45,"context_line":"            # Either not scoped format, or in capabilities scope"},{"line_number":46,"context_line":"            if key in (\"thin_provisioning\", \"capabilities:thin_provisioning\"):"},{"line_number":47,"context_line":"                return extra_specs_ops.match(\u0027True\u0027, req)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_d4b16802","line":44,"range":{"start_line":44,"start_character":24,"end_line":44,"end_character":50},"updated":"2016-01-30 07:01:04.000000000","message":"Using dict.items() is better than six.iteritems(dict):\n\n//review.openstack.org/#/c/268866/","commit_id":"cc119d5ffe4a48bc8d4350f201cff4071f963324"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23f51cb97f6431fade0609ca84e0804a044cd5b7","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _check_thin_in_type(self, resource_type):"},{"line_number":36,"context_line":"        \"\"\"Return True if thin_provisioning in resource_type is True.\"\"\""},{"line_number":37,"context_line":"        if not resource_type:"},{"line_number":38,"context_line":"            return False"},{"line_number":39,"context_line":"        extra_specs \u003d resource_type.get(\u0027extra_specs\u0027)"},{"line_number":40,"context_line":"        if not extra_specs:"},{"line_number":41,"context_line":"            return False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        for key, req in extra_specs.items():"},{"line_number":44,"context_line":"            # Either not scoped format, or in capabilities scope"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_79bad924","line":41,"range":{"start_line":37,"start_character":8,"end_line":41,"end_character":24},"updated":"2016-02-21 23:22:31.000000000","message":"if resource_type is None or not resource_type.get(\u0027extra_specs\u0027): \n        return False","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23f51cb97f6431fade0609ca84e0804a044cd5b7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        if not extra_specs:"},{"line_number":41,"context_line":"            return False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        for key, req in extra_specs.items():"},{"line_number":44,"context_line":"            # Either not scoped format, or in capabilities scope"},{"line_number":45,"context_line":"            if key in (\"thin_provisioning\", \"capabilities:thin_provisioning\"):"},{"line_number":46,"context_line":"                return extra_specs_ops.match(\u0027True\u0027, req)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_b982a150","line":43,"range":{"start_line":43,"start_character":24,"end_line":43,"end_character":43},"updated":"2016-02-21 23:22:31.000000000","message":"resource_type[\u0027extra_specs\u0027].items()   # if you make the above change..","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"}],"manila/tests/scheduler/filters/test_capacity.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23f51cb97f6431fade0609ca84e0804a044cd5b7","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        {\u0027size\u0027: 100, \u0027cap_thin\u0027: \u0027\u003cis\u003e True\u0027,"},{"line_number":147,"context_line":"         \u0027total\u0027: 500, \u0027free\u0027: 99, \u0027provisioned\u0027: 500,"},{"line_number":148,"context_line":"         \u0027max_ratio\u0027: 2.0, \u0027reserved\u0027: 5, \u0027thin_prov\u0027: [True, False]},"},{"line_number":149,"context_line":"        {\u0027size\u0027: 100, \u0027cap_thin\u0027: \u0027\u003cis\u003e False\u0027,"},{"line_number":150,"context_line":"         \u0027total\u0027: 500, \u0027free\u0027: 200, \u0027provisioned\u0027: 500,"},{"line_number":151,"context_line":"         \u0027max_ratio\u0027: 2.0, \u0027reserved\u0027: 5, \u0027thin_prov\u0027: [True, False]})"},{"line_number":152,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_1992ad9f","line":149,"range":{"start_line":149,"start_character":22,"end_line":149,"end_character":46},"updated":"2016-02-21 23:22:31.000000000","message":"How did this pass ? :?","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"23f51cb97f6431fade0609ca84e0804a044cd5b7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                             \u0027resource_type\u0027: {"},{"line_number":158,"context_line":"                                 \u0027name\u0027: \u0027fake_type\u0027,"},{"line_number":159,"context_line":"                                 \u0027extra_specs\u0027: {"},{"line_number":160,"context_line":"                                     \u0027capabilities:thin_provisioning\u0027: cap_thin"},{"line_number":161,"context_line":"                                 }"},{"line_number":162,"context_line":"                             }}"},{"line_number":163,"context_line":"        service \u003d {\u0027disabled\u0027: False}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_f9f38908","line":160,"range":{"start_line":160,"start_character":36,"end_line":160,"end_character":79},"updated":"2016-02-21 23:22:31.000000000","message":"Could you add a test for unscoped too?","commit_id":"1314a56743aa0e5982910eb933ca6d0101350f27"}]}