)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fb8039c66142a44057ab5afe96a7ce6538b44518","unresolved":false,"context_lines":[{"line_number":9,"context_line":"GlusterManager:"},{"line_number":10,"context_line":"- add set_vol_option method, with optional error tolerance"},{"line_number":11,"context_line":"- rename get_gluster_vol_option method to get_vol_option"},{"line_number":12,"context_line":"  for uniform nomenclature and easyness (the \"gluster\" in"},{"line_number":13,"context_line":"  the method name was reduntant as the classname already"},{"line_number":14,"context_line":"  hints about the Gluster scope)"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_4fe193fd","line":12,"updated":"2016-01-29 08:16:05.000000000","message":"s/easyness/easiness/","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"0ae8858552d54f03929591eb1ca8f078dc21bfd6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"GlusterManager:"},{"line_number":10,"context_line":"- add set_vol_option method, with optional error tolerance"},{"line_number":11,"context_line":"- rename get_gluster_vol_option method to get_vol_option"},{"line_number":12,"context_line":"  for uniform nomenclature and easyness (the \"gluster\" in"},{"line_number":13,"context_line":"  the method name was reduntant as the classname already"},{"line_number":14,"context_line":"  hints about the Gluster scope)"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_27a750ab","line":12,"in_reply_to":"7a5de9d1_1d9af263","updated":"2016-02-01 08:57:10.000000000","message":"Finally I did: s/easyness/simplicity/","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"187c36997811adfc5b5508f8d1773e74dee67e9a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"GlusterManager:"},{"line_number":10,"context_line":"- add set_vol_option method, with optional error tolerance"},{"line_number":11,"context_line":"- rename get_gluster_vol_option method to get_vol_option"},{"line_number":12,"context_line":"  for uniform nomenclature and easyness (the \"gluster\" in"},{"line_number":13,"context_line":"  the method name was reduntant as the classname already"},{"line_number":14,"context_line":"  hints about the Gluster scope)"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_1d9af263","line":12,"in_reply_to":"7a5de9d1_4fe193fd","updated":"2016-01-29 10:28:44.000000000","message":"easiness of what?","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fb8039c66142a44057ab5afe96a7ce6538b44518","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- add set_vol_option method, with optional error tolerance"},{"line_number":11,"context_line":"- rename get_gluster_vol_option method to get_vol_option"},{"line_number":12,"context_line":"  for uniform nomenclature and easyness (the \"gluster\" in"},{"line_number":13,"context_line":"  the method name was reduntant as the classname already"},{"line_number":14,"context_line":"  hints about the Gluster scope)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  Partially implements bp gluster-code-cleanup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_8fbeabd2","line":13,"updated":"2016-01-29 08:16:05.000000000","message":"s/reduntant/redundant/","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"0ae8858552d54f03929591eb1ca8f078dc21bfd6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- add set_vol_option method, with optional error tolerance"},{"line_number":11,"context_line":"- rename get_gluster_vol_option method to get_vol_option"},{"line_number":12,"context_line":"  for uniform nomenclature and easyness (the \"gluster\" in"},{"line_number":13,"context_line":"  the method name was reduntant as the classname already"},{"line_number":14,"context_line":"  hints about the Gluster scope)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  Partially implements bp gluster-code-cleanup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_87b2c4e3","line":13,"in_reply_to":"7a5de9d1_8fbeabd2","updated":"2016-02-01 08:57:10.000000000","message":"Done","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"}],"manila/share/drivers/glusterfs/common.py":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fb8039c66142a44057ab5afe96a7ce6538b44518","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def wrapper(self, *args, **kwargs):"},{"line_number":56,"context_line":"        if not self.components.get(\u0027volume\u0027):"},{"line_number":57,"context_line":"            raise exception.GlusterfsException("},{"line_number":58,"context_line":"                _(\"Gluster adddress does not have a volume component\"))"},{"line_number":59,"context_line":"        return f(self, *args, **kwargs)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_ef263fcd","line":58,"updated":"2016-01-29 08:16:05.000000000","message":"s/adddress/address/\n\nAnd the sentence is missing a period.","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"0ae8858552d54f03929591eb1ca8f078dc21bfd6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def wrapper(self, *args, **kwargs):"},{"line_number":56,"context_line":"        if not self.components.get(\u0027volume\u0027):"},{"line_number":57,"context_line":"            raise exception.GlusterfsException("},{"line_number":58,"context_line":"                _(\"Gluster adddress does not have a volume component\"))"},{"line_number":59,"context_line":"        return f(self, *args, **kwargs)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_eb891a27","line":58,"in_reply_to":"7a5de9d1_ef263fcd","updated":"2016-02-01 08:57:10.000000000","message":"Done","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fb8039c66142a44057ab5afe96a7ce6538b44518","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            self.gluster_call("},{"line_number":198,"context_line":"                \u0027volume\u0027, args[0], self.volume, *args[1], raw_error\u003dTrue)"},{"line_number":199,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":200,"context_line":"            if exc.exit_code \u003d\u003d 1 and ignore_failure:"},{"line_number":201,"context_line":"                pass"},{"line_number":202,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_c7c48760","line":199,"updated":"2016-01-29 08:16:05.000000000","message":"gluster_call now raises GlusterfsException.\nhttps://github.com/openstack/manila/commit/c1f2234dd201dbfbff7c56cd25909d55eaf49434#diff-c00bbe3ed900fc7be90971e4de73484dR142\n\nAlso, can _gluster_call be enhanced to ignore failure instead of doing it here?","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"187c36997811adfc5b5508f8d1773e74dee67e9a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            self.gluster_call("},{"line_number":198,"context_line":"                \u0027volume\u0027, args[0], self.volume, *args[1], raw_error\u003dTrue)"},{"line_number":199,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":200,"context_line":"            if exc.exit_code \u003d\u003d 1 and ignore_failure:"},{"line_number":201,"context_line":"                pass"},{"line_number":202,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_4c5f56e5","line":199,"in_reply_to":"7a5de9d1_c7c48760","updated":"2016-01-29 10:28:44.000000000","message":"Sorry, I missed seeing the call made with \u0027raw_error\u003dTrue\u0027 which can raise ProcessExecutionError. Thanks!","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"0ae8858552d54f03929591eb1ca8f078dc21bfd6","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            self.gluster_call("},{"line_number":198,"context_line":"                \u0027volume\u0027, args[0], self.volume, *args[1], raw_error\u003dTrue)"},{"line_number":199,"context_line":"        except exception.ProcessExecutionError as exc:"},{"line_number":200,"context_line":"            if exc.exit_code \u003d\u003d 1 and ignore_failure:"},{"line_number":201,"context_line":"                pass"},{"line_number":202,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_ab7fa215","line":199,"in_reply_to":"7a5de9d1_c7c48760","updated":"2016-02-01 08:57:10.000000000","message":"With raw_error\u003dTrue gluster_call does not raise GlusterfsException.\n\nBut yeah, moving the error handling logic to gluster_call is a good idea.","commit_id":"9dba3e347b09ea615c61132f80fe1952430f9a41"}],"manila/tests/share/drivers/test_glusterfs.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"f5d2b0365aa133718d7834ea195629ccff5106da","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @ddt.data(True, False)"},{"line_number":87,"context_line":"    def test_setup_via_manager(self, has_parent):"},{"line_number":88,"context_line":"        gmgr \u003d mock.Mock()"},{"line_number":89,"context_line":"        gmgr.et_vol_option \u003d mock.Mock()"},{"line_number":90,"context_line":"        share_mgr_parent \u003d mock.Mock() if has_parent else None"},{"line_number":91,"context_line":"        nfs_helper \u003d mock.Mock()"},{"line_number":92,"context_line":"        nfs_helper.get_export \u003d mock.Mock(return_value\u003d\u0027host:/vol\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a54edaf_8c25cb5d","line":89,"range":{"start_line":89,"start_character":13,"end_line":89,"end_character":15},"updated":"2016-02-13 05:09:42.000000000","message":"et?","commit_id":"5083d49dba469a15425ea005ac30826475650115"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"8e4bebbff93d89d69f30a1d36371c8ea169ff11c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @ddt.data(True, False)"},{"line_number":87,"context_line":"    def test_setup_via_manager(self, has_parent):"},{"line_number":88,"context_line":"        gmgr \u003d mock.Mock()"},{"line_number":89,"context_line":"        gmgr.et_vol_option \u003d mock.Mock()"},{"line_number":90,"context_line":"        share_mgr_parent \u003d mock.Mock() if has_parent else None"},{"line_number":91,"context_line":"        nfs_helper \u003d mock.Mock()"},{"line_number":92,"context_line":"        nfs_helper.get_export \u003d mock.Mock(return_value\u003d\u0027host:/vol\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_fbd58fb9","line":89,"in_reply_to":"1a54edaf_8c25cb5d","updated":"2016-02-14 09:11:27.000000000","message":"Yup thanks. We actually don\u0027t need this setting as set_volume_option is already mocked.","commit_id":"5083d49dba469a15425ea005ac30826475650115"}]}
