)]}'
{"manila/share/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"710fd7d8da9e0cc00ffc0be9b59b54bd02dbe314","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            \u0027user_id\u0027: share[\u0027user_id\u0027],"},{"line_number":295,"context_line":"            \u0027project_id\u0027: share[\u0027project_id\u0027],"},{"line_number":296,"context_line":"            \u0027metadata\u0027: self.db.share_metadata_get(context, share[\u0027id\u0027]),"},{"line_number":297,"context_line":"            \u0027share_server_id\u0027: share_instance[\u0027share_server_id\u0027],"},{"line_number":298,"context_line":"            \u0027snapshot_support\u0027: share[\u0027snapshot_support\u0027],"},{"line_number":299,"context_line":"            \u0027share_proto\u0027: share[\u0027share_proto\u0027],"},{"line_number":300,"context_line":"            \u0027share_type_id\u0027: share[\u0027share_type_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_160d4b37","line":297,"updated":"2016-01-26 15:21:26.000000000","message":"Note that this is in share_instance_properties below, I\u0027m not sure if these key is even needed in share_properties anymore. But I don\u0027t know so I\u0027m leaving it to be safe.","commit_id":"997af041ea54e3c5426589dd502e1b69d4bfa5b1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6c3dac11781d46a2c67e8cf8c33d7438d930e40","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if snapshot and not CONF.use_scheduler_creating_share_from_snapshot:"},{"line_number":248,"context_line":"            # Shares from snapshots with restriction - source host only."},{"line_number":249,"context_line":"            # It is common situation for different types of backends."},{"line_number":250,"context_line":"            host \u003d snapshot[\u0027share\u0027][\u0027host\u0027]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.create_instance(context, share, share_network_id\u003dshare_network_id,"},{"line_number":253,"context_line":"                             host\u003dhost, availability_zone\u003davailability_zone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_281cb176","line":250,"updated":"2016-02-02 14:54:00.000000000","message":"Missed this one:\n\nhttp://logs.openstack.org/12/260212/12/check/gate-manila-tempest-dsvm-neutron/ca1f5b9/logs/screen-m-api.txt.gz?level\u003dTRACE#_2016-02-02_00_43_13_828","commit_id":"70c75b5d8117a44b7f821c539bcf591895209528"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"341b88c18174a5efaa182eb7ffddad0d85cdb818","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if snapshot and not CONF.use_scheduler_creating_share_from_snapshot:"},{"line_number":248,"context_line":"            # Shares from snapshots with restriction - source host only."},{"line_number":249,"context_line":"            # It is common situation for different types of backends."},{"line_number":250,"context_line":"            host \u003d snapshot[\u0027share\u0027][\u0027instance\u0027][\u0027host\u0027]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.create_instance(context, share, share_network_id\u003dshare_network_id,"},{"line_number":253,"context_line":"                             host\u003dhost, availability_zone\u003davailability_zone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_2e935951","line":250,"updated":"2016-02-02 15:17:03.000000000","message":"I\u0027m not entirely sure that this will work since right after this it\u0027s creating the instance, but it must have been working before because it proxies the host attribute via the instance property on the share db model object. Else maybe it\u0027s supposed to be None...tempest will find out.","commit_id":"e8a22da292757d471410e7d50c1f32ecfc40cdeb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1ca1e7310ab6322f0b67ace019301d071a872a87","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        if snapshot and not CONF.use_scheduler_creating_share_from_snapshot:"},{"line_number":248,"context_line":"            # Shares from snapshots with restriction - source host only."},{"line_number":249,"context_line":"            # It is common situation for different types of backends."},{"line_number":250,"context_line":"            host \u003d snapshot[\u0027share\u0027][\u0027instance\u0027][\u0027host\u0027]"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.create_instance(context, share, share_network_id\u003dshare_network_id,"},{"line_number":253,"context_line":"                             host\u003dhost, availability_zone\u003davailability_zone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_06251daa","line":250,"in_reply_to":"7a5de9d1_2e935951","updated":"2016-02-03 12:55:05.000000000","message":"Jenkins passed.","commit_id":"e8a22da292757d471410e7d50c1f32ecfc40cdeb"}]}
